Re: [libvirt] [PATCH v4 3/3] Add TLS support for Veritas HyperScale (VxHS) block device protocol

On Fri, Jun 30, 2017 at 2:21 PM, John Ferlan wrote: > [...] > >>> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c >>> index 8e00782..99bc94f 100644 >>> --- a/src/qemu/qemu_command.c >>> +++ b/src/qemu/qemu_command.c >>> @@ -931,6 +931,68 @@

Re: [libvirt] [PATCH v4 3/3] Add TLS support for Veritas HyperScale (VxHS) block device protocol

[...] >> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c >> index 8e00782..99bc94f 100644 >> --- a/src/qemu/qemu_command.c >> +++ b/src/qemu/qemu_command.c >> @@ -931,6 +931,68 @@ qemuBuildGlusterDriveJSON(virStorageSourcePtr src) >> return ret; >> } >> >> +/*

Re: [libvirt] [PATCH v4 2/3] conf: Introduce TLS options for VxHS block device clients

On Fri, Jun 30, 2017 at 1:29 PM, John Ferlan wrote: > > > On 06/29/2017 10:02 PM, Ashish Mittal wrote: >> From: Ashish Mittal >> >> Add a new TLS X.509 certificate type - "vxhs". This will handle the >> creation of a TLS certificate capability for

Re: [libvirt] [PATCH v4 3/3] Add TLS support for Veritas HyperScale (VxHS) block device protocol

On 06/30/2017 04:56 AM, Peter Krempa wrote: > On Fri, Jun 30, 2017 at 10:44:39 +0200, Peter Krempa wrote: >> On Thu, Jun 29, 2017 at 19:02:41 -0700, Ashish Mittal wrote: >>> From: Ashish Mittal > > [...] > >>> diff --git a/docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH v4 2/3] conf: Introduce TLS options for VxHS block device clients

On 06/29/2017 10:02 PM, Ashish Mittal wrote: > From: Ashish Mittal > > Add a new TLS X.509 certificate type - "vxhs". This will handle the > creation of a TLS certificate capability for properly configured > VxHS network block device clients. > > Signed-off-by:

Re: [libvirt] [PATCH v4 0/3] Add support for Veritas HyperScale (VxHS) block device protocol

On Fri, Jun 30, 2017 at 1:07 PM, John Ferlan wrote: > > > On 06/30/2017 11:30 AM, ashish mittal wrote: >> Hi, >> >> Thanks for the review! >> >> On Fri, Jun 30, 2017 at 12:41 AM, Peter Krempa wrote: >>> On Thu, Jun 29, 2017 at 19:02:38 -0700, Ashish Mittal

Re: [libvirt] [PATCH v4 0/3] Add support for Veritas HyperScale (VxHS) block device protocol

On 06/30/2017 11:30 AM, ashish mittal wrote: > Hi, > > Thanks for the review! > > On Fri, Jun 30, 2017 at 12:41 AM, Peter Krempa wrote: >> On Thu, Jun 29, 2017 at 19:02:38 -0700, Ashish Mittal wrote: >>> From: Ashish Mittal >>> >>> QEMU changes

[libvirt] [PATCH] pci: add support for VMD domains

VMD domains start at 0x1, so expand dev->name to fit at least this many characters. Signed-off-by: Jon Derrick --- src/util/virpci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index 2c1b758..b3afefe

Re: [libvirt] [PATCH v3 25/26] qemu: Isolate hostdevs on pSeries guests

On Thu, 2017-06-29 at 17:37 +0200, Andrea Bolognani wrote: > > I can see one problem here - a device that is a hostdev network > > interface won't be properly recognized. > >   > > We can solve the problem for plain by just > > checking for that in addition to here. >  > Right, I hadn't

Re: [libvirt] [PATCH v3 08/12] nodedev: Dereference the obj/def in virNodeDeviceObjListFind* APIs

On 06/30/2017 08:06 AM, Erik Skultety wrote: > On Sat, Jun 03, 2017 at 09:11:58AM -0400, John Ferlan wrote: >> Create local @obj and @def for the API's rather than referencing the >> devs->objs[i][->def->]. It'll make future patches easier to read. ^ [1] >> >>

Re: [libvirt] Entering freeze for libvirt-3.5.0

On Fri, 2017-06-30 at 14:19 +0100, Daniel P. Berrange wrote: > > > Not all builders run all jobs, eg. the test suite is skipped > > > on FreeBSD, but they all at least compile the library. > >  > > Is there any specific reason why it doesn't run test suite on FreeBSD? > > Generally, '(g)make

Re: [libvirt] Entering freeze for libvirt-3.5.0

On Fri, Jun 30, 2017 at 05:45:04PM +0200, Andrea Bolognani wrote: > On Fri, 2017-06-30 at 14:19 +0100, Daniel P. Berrange wrote: > > > > Not all builders run all jobs, eg. the test suite is skipped > > > > on FreeBSD, but they all at least compile the library. > > >  > > > Is there any specific

Re: [libvirt] [PATCH v4 0/3] Add support for Veritas HyperScale (VxHS) block device protocol

Hi, Thanks for the review! On Fri, Jun 30, 2017 at 12:41 AM, Peter Krempa wrote: > On Thu, Jun 29, 2017 at 19:02:38 -0700, Ashish Mittal wrote: >> From: Ashish Mittal >> >> QEMU changes for VxHS (including TLS support) are already upstream. >>

Re: [libvirt] [PATCH v3 01/12] nodedev: Alter virNodeDeviceObjRemove

On 06/30/2017 07:41 AM, Erik Skultety wrote: > On Fri, Jun 30, 2017 at 07:14:13AM -0400, John Ferlan wrote: >> >> >> On 06/30/2017 04:40 AM, Erik Skultety wrote: >>> On Thu, Jun 29, 2017 at 12:07:42PM -0400, John Ferlan wrote: On 06/29/2017 10:28 AM, Erik Skultety wrote: > On

Re: [libvirt] [PATCH 08/10] conf, qemu: Use virDomainDeviceInfoNew()

On Thu, Jun 29, 2017 at 20:04:01 +0200, Andrea Bolognani wrote: > Instances allocated on the stack or using VIR_ALLOC() > directly skip the initialization process. Use the > proper allocation function instead to ensure all > virDomainDeviceInfo instances are properly initialized. > >

Re: [libvirt] Entering freeze for libvirt-3.5.0

On Fri, Jun 30, 2017 at 05:11:09PM +0400, Roman Bogorodskiy wrote: > Andrea Bolognani wrote: > > > On Thu, 2017-06-29 at 09:04 +0200, Daniel Veillard wrote: > > > BTW what is the list of platfdorms we compile on in CentOS CI ? > > > >   * CentOS 6 and 7 > >   * Fedora 23, 24, 25 and rawhide >

Re: [libvirt] Entering freeze for libvirt-3.5.0

Andrea Bolognani wrote: > On Thu, 2017-06-29 at 09:04 +0200, Daniel Veillard wrote: > > BTW what is the list of platfdorms we compile on in CentOS CI ? > >   * CentOS 6 and 7 >   * Fedora 23, 24, 25 and rawhide >   * Debian (oldstable?) >   * FreeBSD (11?) > >

Re: [libvirt] [PATCH v3 11/12] nodedev: Privatize _virNodeDeviceObj and _virNodeDeviceObjList

On Sat, Jun 03, 2017 at 09:12:01AM -0400, John Ferlan wrote: > Move the structures to withing virnodedeviceobj.c > > Move the typedefs from node_device_conf to virnodedeviceobj.h > > Signed-off-by: John Ferlan ACK Erik -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 09/10] conf: Provide missing virDomain*DefNew() functions

On Fri, Jun 30, 2017 at 12:34:15PM +0200, Andrea Bolognani wrote: On Fri, 2017-06-30 at 10:18 +0200, Ján Tomko wrote: > Same as virDomainDeviceInfo itself, any struct that > embeds it needs to be initialized properly before use; > however, none of the structs in question even had a > proper

Re: [libvirt] [PATCH] tpm: Use /dev/null for cancel path if none was found

Hello Stefan, On 06/29/2017 08:01 PM, Stefan Berger wrote: > TPM 2 does not implement sysfs files for cancellation of commands. > We therefore use /dev/null for the cancel path passed to QEMU. > > Signed-off-by: Stefan Berger > --- > src/util/virtpm.c | 4 +--- > 1

Re: [libvirt] [PATCH v3 08/12] nodedev: Dereference the obj/def in virNodeDeviceObjListFind* APIs

On Sat, Jun 03, 2017 at 09:11:58AM -0400, John Ferlan wrote: > Create local @obj and @def for the API's rather than referencing the > devs->objs[i][->def->]. It'll make future patches easier to read. > > Signed-off-by: John Ferlan > --- > src/conf/virnodedeviceobj.c | 60 >

Re: [libvirt] [PATCH v3 13/26] conf: Parse and format

On Fri, Jun 23, 2017 at 8:33 PM, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > docs/formatdomain.html.in | 5 + > docs/schemas/domaincommon.rng | 5 + > src/conf/domain_conf.c| 24 >

Re: [libvirt] [PATCH v3 01/12] nodedev: Alter virNodeDeviceObjRemove

On Fri, Jun 30, 2017 at 07:14:13AM -0400, John Ferlan wrote: > > > On 06/30/2017 04:40 AM, Erik Skultety wrote: > > On Thu, Jun 29, 2017 at 12:07:42PM -0400, John Ferlan wrote: > >> > >> > >> On 06/29/2017 10:28 AM, Erik Skultety wrote: > >>> On Thu, Jun 29, 2017 at 09:57:09AM -0400, John Ferlan

Re: [libvirt] [PATCH v3 07/12] nodedev: Alter node device obj list function names

On Sat, Jun 03, 2017 at 09:11:57AM -0400, John Ferlan wrote: > Ensure that any function that walks the node device object list is prefixed > by virNodeDeviceObjList. > > Also, modify the @filter param name for virNodeDeviceObjListExport to > be @aclfilter. > > Signed-off-by: John Ferlan

Re: [libvirt] [PATCH] qemu: Don't update CPU when checking ABI stability

On Wed, Jun 28, 2017 at 04:24:39PM +0200, Jiri Denemark wrote: > When checking ABI stability between two domain definitions, we first > make migratable copies of them. However, we also asked for the guest CPU > to be updated, even though the updated CPU is supposed to be already > included in the

Re: [libvirt] [PATCH 04/10] conf: Clean up virDomain{Memory, Shmem}DefParseXML()

On Fri, Jun 30, 2017 at 13:17:04 +0200, Andrea Bolognani wrote: > On Fri, 2017-06-30 at 12:50 +0200, Peter Krempa wrote: > > >  if (virDomainDeviceInfoParseXML(node, NULL, >info, flags) < 0) > > > -goto cleanup; > > > - > > > +goto error; > > >   > > > -ret = def; > > > -   

Re: [libvirt] [PATCH v3 01/12] nodedev: Alter virNodeDeviceObjRemove

On 06/30/2017 04:40 AM, Erik Skultety wrote: > On Thu, Jun 29, 2017 at 12:07:42PM -0400, John Ferlan wrote: >> >> >> On 06/29/2017 10:28 AM, Erik Skultety wrote: >>> On Thu, Jun 29, 2017 at 09:57:09AM -0400, John Ferlan wrote: On 06/29/2017 08:12 AM, Erik Skultety wrote: > On

Re: [libvirt] [PATCH 07/10] conf: Clean up virDomainDeviceInfo functions

On Thu, Jun 29, 2017 at 20:04:00 +0200, Andrea Bolognani wrote: > Mostly style changes to make them a little bit nicer. > > Signed-off-by: Andrea Bolognani > --- > src/conf/device_conf.c | 38 +++--- > 1 file changed, 31 insertions(+), 7

Re: [libvirt] [PATCH 04/10] conf: Clean up virDomain{Memory, Shmem}DefParseXML()

On Fri, 2017-06-30 at 12:50 +0200, Peter Krempa wrote: > >  if (virDomainDeviceInfoParseXML(node, NULL, >info, flags) < 0) > > -goto cleanup; > > - > > +goto error; > >   > > -ret = def; > > -def = NULL; > >   cleanup: > > -ctxt->node = save; > >  VIR_FREE(tmp);

Re: [libvirt] [PATCH 00/10] conf: Clean up virDomain*Def creation

On Fri, 2017-06-30 at 12:38 +0200, Peter Krempa wrote: > > Isolation groups are used to make sure any given device ends > > up on the same bus as related devices and on a different bus > > as unrelated devices. > >  > > They're an abstract concept, and while working on the initial > >

Re: [libvirt] [PATCH RFC V2 1/2] Resctrl: Add new xml element to support cache tune

On Mon, Jun 26, 2017 at 06:33:39PM +0800, Eli Qiao wrote: This patch adds new xml element to support cache tune as: ... ... cacheId: reference of the host's cache banks id, it's from capabilities xml. type:cache bank type, it could be both, code, data. sizeKiB: must be

Re: [libvirt] [PATCH 06/10] conf: Introduce virDomainDeviceInfoNew()

On Thu, Jun 29, 2017 at 20:03:59 +0200, Andrea Bolognani wrote: > It allocates and initializes a virDomainDeviceInfo struct > in one fell swoop. > > Signed-off-by: Andrea Bolognani > --- > src/conf/device_conf.c | 13 + > src/conf/device_conf.h | 1 + > 2 files

Re: [libvirt] [PATCH 05/10] conf: Move some virDomainDeviceInfo functions

On Thu, Jun 29, 2017 at 20:03:58 +0200, Andrea Bolognani wrote: > The virDomainDeviceInfo struct is defined in device_conf, > so generic functions that operate on it should also be > defined there rather than in domain_conf. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [PATCH 04/10] conf: Clean up virDomain{Memory, Shmem}DefParseXML()

On Thu, Jun 29, 2017 at 20:03:57 +0200, Andrea Bolognani wrote: > Follow the same style as other similar functions. > > Signed-off-by: Andrea Bolognani > --- > src/conf/domain_conf.c | 36 ++-- > 1 file changed, 18 insertions(+), 18

Re: [libvirt] [PATCH 03/10] conf: Clean up virDomainHostdevDefNew()

On Thu, Jun 29, 2017 at 20:03:56 +0200, Andrea Bolognani wrote: > Follow the same style as other similar functions. > > Signed-off-by: Andrea Bolognani > --- > src/conf/domain_conf.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git

Re: [libvirt] [PATCH 02/10] conf: Rename virDomainHostdevDefAlloc() to virDomainHostdevDefNew()

On Thu, Jun 29, 2017 at 20:03:55 +0200, Andrea Bolognani wrote: > All other virDomain*Def follow this naming convention for > their allocation function. > > Signed-off-by: Andrea Bolognani > --- > src/conf/domain_conf.c| 4 ++-- > src/conf/domain_conf.h| 2

Re: [libvirt] [PATCH 01/10] conf: Make virDomainDeviceGetInfo() private

On Thu, Jun 29, 2017 at 20:03:54 +0200, Andrea Bolognani wrote: > There are no external users. > > Signed-off-by: Andrea Bolognani > --- > src/conf/domain_conf.c | 21 - > src/conf/domain_conf.h | 1 - > 2 files changed, 12 insertions(+), 10

Re: [libvirt] [PATCH 3/3] tests: check domain XML to libxl structures conversion

On 06/29/2017 11:08 PM, Marek Marczykowski-Górecki wrote: > On Thu, Jun 29, 2017 at 10:06:39AM +0100, Joao Martins wrote: >> On 06/29/2017 02:11 AM, Marek Marczykowski-Górecki wrote: >>> libxl contains a method to dump libxl_domain_config in json format, >>> which is really convenient for tests.

Re: [libvirt] [PATCH 00/10] conf: Clean up virDomain*Def creation

On Fri, Jun 30, 2017 at 12:24:33 +0200, Andrea Bolognani wrote: > On Fri, 2017-06-30 at 10:58 +0200, Peter Krempa wrote: > > > Or we could just, you know, do the sensible thing and > > > store (IOMMU group + 1) instead of (IOMMU group) in > >  > > How is that sensible? That looks as a source of

Re: [libvirt] [PATCH 09/10] conf: Provide missing virDomain*DefNew() functions

On Fri, 2017-06-30 at 10:18 +0200, Ján Tomko wrote: > > Same as virDomainDeviceInfo itself, any struct that > > embeds it needs to be initialized properly before use; > > however, none of the structs in question even had a > > proper allocation function defined. > >  > > Implement an allocation

Re: [libvirt] [PATCH v3 06/12] nodedev: Introduce virNodeDeviceObjListNew

On Sat, Jun 03, 2017 at 09:11:56AM -0400, John Ferlan wrote: > In preparation to make things private, make the ->devs be pointers to a > virNodeDeviceObjList and then manage everything inside virnodedeviceobj > > Signed-off-by: John Ferlan > --- > src/conf/virnodedeviceobj.c

Re: [libvirt] [PATCH 00/10] conf: Clean up virDomain*Def creation

On Fri, 2017-06-30 at 10:58 +0200, Peter Krempa wrote: > > Or we could just, you know, do the sensible thing and > > store (IOMMU group + 1) instead of (IOMMU group) in >  > How is that sensible? That looks as a source of bugs in the long run. Isolation groups are used to make sure any given

Re: [libvirt] [PATCH 00/10] conf: Clean up virDomain*Def creation

On Fri, Jun 30, 2017 at 10:58:42 +0200, Peter Krempa wrote: > On Fri, Jun 30, 2017 at 10:48:36 +0200, Andrea Bolognani wrote: > > On Thu, 2017-06-29 at 20:03 +0200, Andrea Bolognani wrote: > > [...] > > > > That's worked out just fine so far, because zero was a > > > sensible default value for

Re: [libvirt] [PATCH 00/10] conf: Clean up virDomain*Def creation

On Fri, Jun 30, 2017 at 10:48:36 +0200, Andrea Bolognani wrote: > On Thu, 2017-06-29 at 20:03 +0200, Andrea Bolognani wrote: [...] > > That's worked out just fine so far, because zero was a > > sensible default value for all existing fields; however, > > when implementing isolation groups, we

Re: [libvirt] [PATCH v4 3/3] Add TLS support for Veritas HyperScale (VxHS) block device protocol

On Fri, Jun 30, 2017 at 10:44:39 +0200, Peter Krempa wrote: > On Thu, Jun 29, 2017 at 19:02:41 -0700, Ashish Mittal wrote: > > From: Ashish Mittal [...] > > diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng > > index 7525a2a..909af50 100644 >

Re: [libvirt] [PATCH 09/10] conf: Provide missing virDomain*DefNew() functions

On Thu, Jun 29, 2017 at 20:04:02 +0200, Andrea Bolognani wrote: > Same as virDomainDeviceInfo itself, any struct that > embeds it needs to be initialized properly before use; > however, none of the structs in question even had a > proper allocation function defined. > > Implement an allocation

Re: [libvirt] [PATCH 00/10] conf: Clean up virDomain*Def creation

On Thu, 2017-06-29 at 20:03 +0200, Andrea Bolognani wrote: > This series is required to solve a known limitation in the > current incarnation of device isolation support[1], namely > the inability to isolate host devices coming from IOMMU > group 0. >  > The issue lies in the fact that

Re: [libvirt] [PATCH v4 1/3] Add support for Veritas HyperScale (VxHS) block device protocol

On Thu, Jun 29, 2017 at 19:02:39 -0700, Ashish Mittal wrote: > From: Ashish Mittal > > Sample XML for a VxHS disk: > > > > > > > > > eb90327c-8302-4725-9e1b-4e85ed4dc251 > > > > > Signed-off-by: Ashish Mittal

Re: [libvirt] [PATCH v4 3/3] Add TLS support for Veritas HyperScale (VxHS) block device protocol

On Thu, Jun 29, 2017 at 19:02:41 -0700, Ashish Mittal wrote: > From: Ashish Mittal > > The following describes the behavior of TLS for VxHS block device: > > (1) Two new options have been added in /etc/libvirt/qemu.conf > to control TLS behavior with VxHS block

Re: [libvirt] [PATCH v3 01/12] nodedev: Alter virNodeDeviceObjRemove

On Thu, Jun 29, 2017 at 12:07:42PM -0400, John Ferlan wrote: > > > On 06/29/2017 10:28 AM, Erik Skultety wrote: > > On Thu, Jun 29, 2017 at 09:57:09AM -0400, John Ferlan wrote: > >> > >> > >> On 06/29/2017 08:12 AM, Erik Skultety wrote: > >>> On Sat, Jun 03, 2017 at 09:11:51AM -0400, John Ferlan

Re: [libvirt] [PATCH v3 18/26] qemu: Use multiple PHBs for pSeries guests

On Thu, Jun 29, 2017 at 1:03 PM, Andrea Bolognani wrote: > On Tue, 2017-06-27 at 13:53 +0530, Shivaprasad bhat wrote: > > Hi Andrea, > > > > We need to also adjust the memlock limits along with this patch. > > Good point. I must have remembered about that at least > five

[libvirt] [PATCH] qemu: Take all PHBs into account while calculating memlock limits

Now that the multi-phb support series is in, work on the TODO at qemuDomainGetMemLockLimitBytes() to arrive at the correct memlock limit value. Signed-off-by: Shivaprasad G Bhat --- This patch should be applied on top of Andrea's multi-phb support patchset.

Re: [libvirt] [PATCH v4 1/3] Add support for Veritas HyperScale (VxHS) block device protocol

On Thu, Jun 29, 2017 at 19:02:39 -0700, Ashish Mittal wrote: > From: Ashish Mittal > > Sample XML for a VxHS disk: > > > > > > > > > eb90327c-8302-4725-9e1b-4e85ed4dc251 > > > > > Signed-off-by: Ashish Mittal

Re: [libvirt] [PATCH 09/10] conf: Provide missing virDomain*DefNew() functions

On Thu, Jun 29, 2017 at 08:04:02PM +0200, Andrea Bolognani wrote: Same as virDomainDeviceInfo itself, any struct that embeds it needs to be initialized properly before use; however, none of the structs in question even had a proper allocation function defined. Implement an allocation function

Re: [libvirt] [PATCH v4 0/3] Add support for Veritas HyperScale (VxHS) block device protocol

On Thu, Jun 29, 2017 at 19:02:38 -0700, Ashish Mittal wrote: > From: Ashish Mittal > > QEMU changes for VxHS (including TLS support) are already upstream. > This series of patches adds support for VxHS block devices in libvirt. > > Patch 1 adds the base functionality

Re: [libvirt] [RFC PATCH 0/5] hotplug: fix premature rebinding of VFIO devices to host

On Thu, 2017-06-29 at 15:59 -0500, Michael Roth wrote: > > > Patches 1-4 address 1) by deferring rebinding of a hostdev to the host > > > driver > > > until all the devices in the group have been detached, at which point all > > > the hostdevs are rebound as a group. Until that point, the devices

[libvirt] [PATCH v2] vz: support disabled items in vz boot order

At the time the check was written virtuozzo did not use disabled items in boot order configuration. Boot items were always enabled. Now they can be disabled as well. Supporting such items is easy - they just should be ignored. --- src/vz/vz_sdk.c | 7 ++- 1 file changed, 2 insertions(+), 5