Re: [libvirt] [PATCH] test: adding tests to virStrToDouble() inside virstringtest.

On 06/24/2017 08:15 PM, Julio Faracco wrote: > There are no occurrences of tests related to Strings and Double numbers > inside virstringtest.c. This commit introduces some tests to validate the > conversion. The test does not include locale changes yet. > > Signed-off-by: Julio Faracco

Re: [libvirt] [PATCH v7 0/6] Hyper-V method invocation

2017-06-27 21:13 GMT+02:00 Sri Ramanujam : > Changes from v6: > * Added news entry > > Sri Ramanujam (6): > hyperv: Functions to work with invocation parameters. > hyperv: Generate object property type information. > hyperv: add hypervInvokeMethod > hyperv: support

Re: [libvirt] [PATCH v4 6/6] virStream*All: Report error if a callback fails

On 06/22/2017 08:30 AM, Michal Privoznik wrote: > All of these four functions (virStreamRecvAll, virStreamSendAll, > virStreamSparseRecvAll, virStreamSparseSendAll) take one or more > callback that handle various aspects of streams. However, if any (same as previous review) s/callback/callback

Re: [libvirt] [PATCH v4 5/6] virFileInData: preserve errno in cleanup path

On 06/22/2017 08:30 AM, Michal Privoznik wrote: > Callers might be interested in the original value of errno. Let's > not overwrite it with lseek() done in cleanup path. > > Signed-off-by: Michal Privoznik > --- > src/util/virfile.c | 5 - > 1 file changed, 4

Re: [libvirt] [PATCH v4 4/6] virStream*All: Preserve reported error

On 06/22/2017 08:30 AM, Michal Privoznik wrote: > If one these four functions fail (virStreamRecvAll, > virStreamSendAll, virStreamSparseRecvAll, virStreamSparseSendAll) > the stream is aborted by calling virStreamAbort(). This is, > however, an public API - therefore the first thing it does is

Re: [libvirt] [PATCH v4 3/6] virStream*All: Call virStreamAbort() more frequently

On 06/22/2017 08:30 AM, Michal Privoznik wrote: > Our documentation to all four virStreamRecvAll, virStreamSendAll, > virStreamSparseRecvAll, virStreamSparseSendAll says that if these > functions fail, virStreamAbort() is called. But that is not Our documentation to the virStreamRecvAll,

Re: [libvirt] [PATCH v4 1/6] virfdstream: Check for thread error more frequently

On 06/22/2017 08:30 AM, Michal Privoznik wrote: > When the I/O thread quits (e.g. due to an I/O error, lseek() > error, whatever), any subsequent virFDStream API should return > error too. Moreover, when invoking stream event callback, we must > set the VIR_STREAM_EVENT_ERROR flag so that the

Re: [libvirt] [PATCH v4 2/6] fdstream: Report error from the I/O thread

On 06/22/2017 08:30 AM, Michal Privoznik wrote: > Problem with our error reporting is that the error object is a > thread local variable. That means if there's an error reported > within the I/O thread it gets logged and everything, but later > when the event loop aborts the stream it doesn't

[libvirt] [PATCH go-xml] Add support for domain clock

Signed-off-by: zhenwei.pi --- domain.go | 5 + domain_test.go | 4 2 files changed, 9 insertions(+) diff --git a/domain.go b/domain.go index b9b0f77..8bbf82b 100644 --- a/domain.go +++ b/domain.go @@ -532,6 +532,10 @@ type DomainCPU struct {