Hello Peter,
This is my first review. I tested the patch series on my system and it
works fine. The refactoring part and the logic for autoCpuset and
autoNodeset looks good. ACK from my side.
Thanks,
Nitesh.
On Wed, Jul 12, 2017 at 7:14 PM, Peter Krempa wrote:
> Cgroups code fails if it's ins
Hi. I'm testing libvirt 3.5.0 and have many issues like this:
Jul 14 09:47:25 cn25 libvirtd[18820]: 2017-07-14 06:47:25.598+:
18841: error : qemuDomainObjBeginJobInternal:3872 : Timed out during
operation: cannot acquire state change lock (held by
remoteDispatchConnectGetAllDomainStats)
Jul 14
On Fri, Jul 14, 2017 at 10:09:00AM +0300, Vasiliy Tolstov wrote:
Hi. I'm testing libvirt 3.5.0 and have many issues like this:
Jul 14 09:47:25 cn25 libvirtd[18820]: 2017-07-14 06:47:25.598+:
18841: error : qemuDomainObjBeginJobInternal:3872 : Timed out during
operation: cannot acquire state
On Tue, Jul 11, 2017 at 03:47:55PM -0400, Liang Yan wrote:
Hi,
We hit some problems when we attached some lun devices in our vm, turns
out that libvirt created lsilogic scsi controller automatically for
these scsi devices, however these device works well under virtio_scsi
controller.
the curren
On 07/13/2017 07:19 PM, John Ferlan wrote:
>
>
> On 07/11/2017 11:52 AM, Michal Privoznik wrote:
>> On 06/03/2017 03:27 PM, John Ferlan wrote:
>>> Rather than rely on virSecretObjEndAPI to make the final virObjectUnref
>>> after the call virSecretObjListRemove, be more explicit by calling
>>> vir
On 07/13/2017 06:43 PM, John Ferlan wrote:
>
>
> On 07/11/2017 11:52 AM, Michal Privoznik wrote:
>> On 06/03/2017 03:27 PM, John Ferlan wrote:
>>> Move the consumption of @newdef into virSecretObjNew and then handle that
>>> in the calling path. Because on error the calling code expects to free
On 07/13/2017 06:36 PM, John Ferlan wrote:
>
>
> On 07/11/2017 11:52 AM, Michal Privoznik wrote:
>> On 06/03/2017 03:27 PM, John Ferlan wrote:
>>> Make use of an error: label to handle the failure and need to call
>>> virSecretObjEndAPI for the object to set it to NULL for return.
>>>
>>> Also ra
On 07/13/2017 06:54 PM, John Ferlan wrote:
>
>
> On 07/11/2017 11:52 AM, Michal Privoznik wrote:
>> On 06/03/2017 03:27 PM, John Ferlan wrote:
>>> Since the virSecretObjListAdd technically consumes @def on success,
>>> the secretDefineXML should fetch the @def from the object afterwards
>>> and m
2017-07-14 10:27 GMT+03:00 Martin Kletzander :
> On Fri, Jul 14, 2017 at 10:09:00AM +0300, Vasiliy Tolstov wrote:
>>
>> Hi. I'm testing libvirt 3.5.0 and have many issues like this:
>>
>> Jul 14 09:47:25 cn25 libvirtd[18820]: 2017-07-14 06:47:25.598+:
>> 18841: error : qemuDomainObjBeginJobInte
On Fri, Jul 14, 2017 at 11:53:15AM +0300, Vasiliy Tolstov wrote:
2017-07-14 10:27 GMT+03:00 Martin Kletzander :
On Fri, Jul 14, 2017 at 10:09:00AM +0300, Vasiliy Tolstov wrote:
Hi. I'm testing libvirt 3.5.0 and have many issues like this:
Jul 14 09:47:25 cn25 libvirtd[18820]: 2017-07-14 06:47
2017-07-14 12:07 GMT+03:00 Martin Kletzander :
>>> What's be stacktrace of libvirtd in this case?
>>>
>>
>>
>> How can i get it when new lock appears?
>>
>
> gdb -batch -p $(pgrep libvirtd) -ex 't a a bt'
>
>
I'm try, does i need to have debugging symbols on this host ?
--
Vasiliy Tolstov,
e-m
On Fri, Jul 14, 2017 at 09:51:48 +0300, Nikolay Shirokovskiy wrote:
> ping
Oops, I completely forgot about this series. But since it is a few
months old, could you resend the series after rebasing it to current
libvirt? I promise to review them while they are fresh.
Jirka
--
libvir-list mailing
On Thu, Jul 13, 2017 at 07:23:58PM -0400, John Ferlan wrote:
>
>
> On 07/11/2017 10:38 AM, Erik Skultety wrote:
> > On Mon, Jul 03, 2017 at 05:25:30PM -0400, John Ferlan wrote:
> >> Since virnodedeviceobj now has a self-lockable hash table, there's no
> >> need to lock the table from the driver for
On Fri, Jul 14, 2017 at 12:18:06PM +0300, Vasiliy Tolstov wrote:
2017-07-14 12:07 GMT+03:00 Martin Kletzander :
What's be stacktrace of libvirtd in this case?
How can i get it when new lock appears?
gdb -batch -p $(pgrep libvirtd) -ex 't a a bt'
I'm try, does i need to have debugging
> >> cleanup:
> >> -if (obj)
> >> -virNodeDeviceObjUnlock(obj);
> >> +virNodeDeviceObjEndAPI(&obj);
> >> testDriverUnlock(driver);
> >> virNodeDeviceDefFree(def);
> >> virObjectUnref(dev);
> >> @@ -5596,13 +5595,13 @@ testNodeDeviceDestroy(virNodeDevicePtr dev)
> >>
QEMU fails to launch a sPAPR guest with clock sources other that RTC.
Internally qemu only uses RTC timer for hwclock. This patch reports
the right error message instead of qemu erroring out when any other
timer other than RTC is used.
Signed-off-by: Kothapally Madhu Pavan
---
src/qemu/qemu_doma
On Thu, Jul 13, 2017 at 03:40:26PM -0400, John Ferlan wrote:
>
>
> On 07/11/2017 04:27 AM, Pavel Hrdina wrote:
> > On Tue, May 09, 2017 at 11:30:09AM -0400, John Ferlan wrote:
> >> A virStoragePoolObjPtr will be an 'obj'.
> >>
> >> A virStoragePoolPtr will be a 'pool'.
> >>
> >> Signed-off-by: Jo
On Thu, Jul 13, 2017 at 05:49:35PM -0400, John Ferlan wrote:
>
>
> On 07/12/2017 04:17 AM, Pavel Hrdina wrote:
> > On Tue, May 09, 2017 at 11:30:14AM -0400, John Ferlan wrote:
> >> A virStoragePoolObjPtr will be an 'obj'.
> >>
> >> A virStoragePoolPtr will be a 'pool'.
> >
> > There is no such c
On 07/14/2017 04:26 AM, Michal Privoznik wrote:
> On 07/13/2017 06:54 PM, John Ferlan wrote:
>>
>>
>> On 07/11/2017 11:52 AM, Michal Privoznik wrote:
>>> On 06/03/2017 03:27 PM, John Ferlan wrote:
Since the virSecretObjListAdd technically consumes @def on success,
the secretDefineXML sh
On 07/14/2017 01:52 AM, John Ferlan wrote:
>
>
> On 07/13/2017 10:41 AM, Michal Privoznik wrote:
>> On 06/02/2017 12:25 PM, John Ferlan wrote:
>>> After returning from virNWFilterObjListAssignDef the @obj is locked;
>>> however, if virNWFilterSaveConfig fails to save the generated UUID
>>> the co
On 07/14/2017 01:50 AM, John Ferlan wrote:
>
>
> On 07/13/2017 10:41 AM, Michal Privoznik wrote:
>> On 06/02/2017 12:25 PM, John Ferlan wrote:
>>> If the virNWFilterSaveConfig in virNWFilterObjListLoadConfig, then jumping
>>
>> s/,/ fails,/
>>
>>> to the error label would free the @def owned by t
On 07/14/2017 02:01 PM, John Ferlan wrote:
>
>
> On 07/14/2017 04:26 AM, Michal Privoznik wrote:
>> On 07/13/2017 06:54 PM, John Ferlan wrote:
>>>
>>>
>>> On 07/11/2017 11:52 AM, Michal Privoznik wrote:
On 06/03/2017 03:27 PM, John Ferlan wrote:
> Since the virSecretObjListAdd technicall
On 07/14/2017 04:15 AM, Michal Privoznik wrote:
> On 07/13/2017 07:19 PM, John Ferlan wrote:
>>
>>
>> On 07/11/2017 11:52 AM, Michal Privoznik wrote:
>>> On 06/03/2017 03:27 PM, John Ferlan wrote:
Rather than rely on virSecretObjEndAPI to make the final virObjectUnref
after the call vir
On 7/14/17 3:56 AM, Martin Kletzander wrote:
> On Tue, Jul 11, 2017 at 03:47:55PM -0400, Liang Yan wrote:
>> Hi,
>>
>> We hit some problems when we attached some lun devices in our vm, turns
>> out that libvirt created lsilogic scsi controller automatically for
>> these scsi devices, however these
On 07/10/2017 02:07 PM, Peter Krempa wrote:
> Few cleanups I made to cleanup the def->JSON generator for qemu disk sources.
>
> Peter Krempa (10):
> qemu: command: Set port number only for TCP transport
> util: Extract helper to retrieve default port for network protocol
> util: storage: Fil
On 07/14/2017 08:26 AM, Michal Privoznik wrote:
> On 07/14/2017 02:01 PM, John Ferlan wrote:
>>
>>
>> On 07/14/2017 04:26 AM, Michal Privoznik wrote:
>>> On 07/13/2017 06:54 PM, John Ferlan wrote:
On 07/11/2017 11:52 AM, Michal Privoznik wrote:
> On 06/03/2017 03:27 PM, John Fe
On Tue, May 09, 2017 at 11:30:15AM -0400, John Ferlan wrote:
> A virStoragePoolObjPtr will be an 'obj'.
Now that I'm thinking about it, this should be poolObj or poolobj, it
would make it easier using git grep and also some functions takes more
than one object. We should thought about it earlier,
On Tue, May 09, 2017 at 11:30:17AM -0400, John Ferlan wrote:
> In preparation for making a private object, create accessor API's for
> consumer storage functions to use:
>
> virStoragePoolObjGetDef
> virStoragePoolObjGetNewDef
> virStoragePoolObjStealNewDef
> virStoragePoolObjGetCo
v1: https://www.redhat.com/archives/libvir-list/2017-June/msg00168.html
but review was done more recently in 2017-July...
Changes since v1...
... Pushed v1 patches 1-3 since they were ACK'd
... Altered old patch 4, new patch 1 to use if/else processing
... Altered old patch 5, new patch 2 to
Rather than assign to a local variable, let's just assign directly to the
object using the error path for cleanup.
Signed-off-by: John Ferlan
---
src/conf/virsecretobj.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/src/conf/virsecretobj.c b/src/conf/virs
Since the virSecretObjListAdd technically consumes @def on success,
the secretDefineXML should set @def = NULL immediately and process
the remaining calls using a new @objdef variable. We can use use
VIR_STEAL_PTR since we know the Add function just stores @def in
obj->def.
This fixes a possible d
Rather than rely on virSecretObjEndAPI to make the final virObjectUnref
after the call to virSecretObjListRemove, be more explicit by calling
virObjectUnref and setting @obj to NULL for secretUndefine and in
the error path of secretDefineXML. Calling EndAPI will end up calling
Unlock on an already
Make use of an error: label to handle the failure and need to call
virSecretObjEndAPI for the object to set it to NULL for return.
Signed-off-by: John Ferlan
---
src/conf/virsecretobj.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/conf/virsecre
On 07/14/2017 05:28 AM, Erik Skultety wrote:
cleanup:
-if (obj)
-virNodeDeviceObjUnlock(obj);
+virNodeDeviceObjEndAPI(&obj);
testDriverUnlock(driver);
virNodeDeviceDefFree(def);
virObjectUnref(dev);
@@ -5596,13 +5595,13 @@ t
On Fri, Jul 14, 2017 at 08:52:35 -0400, Liang Yan wrote:
> On 7/14/17 3:56 AM, Martin Kletzander wrote:
> > On Tue, Jul 11, 2017 at 03:47:55PM -0400, Liang Yan wrote:
> >> Hi,
> >>
> >> We hit some problems when we attached some lun devices in our vm, turns
> >> out that libvirt created lsilogic sc
On Tue, May 09, 2017 at 11:30:15AM -0400, John Ferlan wrote:
> A virStoragePoolObjPtr will be an 'obj'.
>
> A virStoragePoolPtr will be a 'pool'.
>
> A virStorageVolPtr will be a 'vol'.
>
> A virStorageVolDefPtr will be a 'voldef'.
>
> Signed-off-by: John Ferlan
> ---
> src/storage/storage_dr
On Tue, May 09, 2017 at 11:30:21AM -0400, John Ferlan wrote:
> Create/use virStoragePoolObjAddVol in order to add volumes onto list.
>
> Create/use virStoragePoolObjRemoveVol in order to remove volumes from list.
>
> Create/use virStoragePoolObjGetVolumesCount to get count of volumes on list.
>
On Fri, May 19, 2017 at 08:38:16AM -0400, John Ferlan wrote:
> Introduce virStoragePoolObjForEachVolume to scan each volume calling the
> passed callback function until all volumes have been processed in the
> storage pool volume list, unless the callback function returns an error.
>
> Introduce v
On 07/14/2017 05:23 AM, Erik Skultety wrote:
> On Thu, Jul 13, 2017 at 07:23:58PM -0400, John Ferlan wrote:
>>
>>
>> On 07/11/2017 10:38 AM, Erik Skultety wrote:
>>> On Mon, Jul 03, 2017 at 05:25:30PM -0400, John Ferlan wrote:
Since virnodedeviceobj now has a self-lockable hash table, there'
On Tue, May 09, 2017 at 11:30:17AM -0400, John Ferlan wrote:
> In preparation for making a private object, create accessor API's for
> consumer storage functions to use:
>
> virStoragePoolObjGetDef
> virStoragePoolObjGetNewDef
> virStoragePoolObjStealNewDef
> virStoragePoolObjGetCo
On 7/14/17 10:33 AM, Peter Krempa wrote:
> On Fri, Jul 14, 2017 at 08:52:35 -0400, Liang Yan wrote:
>> On 7/14/17 3:56 AM, Martin Kletzander wrote:
>>> On Tue, Jul 11, 2017 at 03:47:55PM -0400, Liang Yan wrote:
Hi,
We hit some problems when we attached some lun devices in our vm, t
On 07/14/2017 11:37 AM, John Ferlan wrote:
>
>
> On 07/14/2017 05:23 AM, Erik Skultety wrote:
>> On Thu, Jul 13, 2017 at 07:23:58PM -0400, John Ferlan wrote:
>>>
>>>
>>> On 07/11/2017 10:38 AM, Erik Skultety wrote:
On Mon, Jul 03, 2017 at 05:25:30PM -0400, John Ferlan wrote:
> Since vi
On 07/14/2017 06:55 AM, Kothapally Madhu Pavan wrote:
> QEMU fails to launch a sPAPR guest with clock sources other that RTC.
> Internally qemu only uses RTC timer for hwclock. This patch reports
> the right error message instead of qemu erroring out when any other
> timer other than RTC is used.
>
On 07/11/2017 08:15 AM, Christian Ehrhardt wrote:
Hi,
Hi,
Thanks for the report and sorry for delayed response. I'm slowly catching up on
libvirt mail after being away for a while...
we have found an issue caused by 321a28c6 "libxl: set default disk format in
device post-parse" (and maybe
On 07/12/2017 09:35 AM, Christian Ehrhardt wrote:
Not sure how stupid it might be so clearly just a very humble RFC, but the
following seems to work for me:
Therefore no nicely polished patch, but just inline diff
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@ -367,8 +367,9 @
There's some specific logic in qemuBuildCpuCommandLine to support
auto adding -cpu qemu 32 for arch=i686 with an x86_64 qemu-kvm binary.
Add a test case for it
Signed-off-by: Cole Robinson
---
.../qemuxml2argv-x86-kvm-32-on-64.args | 21 +
.../qemuxml2argv-x86-kv
The code only currently handles writing an x86 default -cpu
argument, and doesn't know anything about other architectures.
Let's make this explicit rather than leaving ex. qemu ppc64 to
throw an error about -cpu qemu64
Signed-off-by: Cole Robinson
---
src/qemu/qemu_command.c | 25 +++
Just some minor patches to do with encoding a default CPU on the
qemu command line.
Patch 1 adds a test case
Patch 2 simplifies the code
Patch 3 throws an explicit error for a confusing situation
Cole Robinson (3):
tests: add qemu x86 kvm 32-on-64 test
qemu: command: rework adding of default
Certain XML features that aren't in the block map to -cpu
flags on the qemu cli. If one of these is specified but the user
didn't explicitly pass an XML model, we need to format a
default model on the command line.
The current code handles this by sprinkling this default cpu handling
among all t
On 07/01/2017 08:16 PM, Marek Marczykowski-Górecki wrote:
On Sun, Feb 26, 2017 at 07:02:24PM -0700, Jim Fehlig wrote:
Long ago danpb posted some patches to test libvirt domXML to
libxl_domain_config conversion
https://www.redhat.com/archives/libvir-list/2014-May/msg01102.html
Some of the prere
@driverpath, allocated by virAsprintfQuiet, was not freed and leaked.
Signed-off-by: Zhipeng Lu
---
tests/virpcimock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/virpcimock.c b/tests/virpcimock.c
index e9408aa..dec9e01 100644
--- a/tests/virpcimock.c
+++ b/tests/virpcimock.c
@@ -4
virNetSocketRemoveIOCallback get sock's ObjectLock and will call
virNetSocketEventFree. virNetSocketEventFree may be free sock
object and virNetSocketRemoveIOCallback will access a null pointer
in release sock's ObjectLock.
Signed-off-by: Liu Yun
Signed-off-by: Peng Hao
---
src/rpc/virnetsocket
From: Hao Peng
At present shared disks can be migrated with either readonly or cache=none. But
cache=directsync should be safe for migration, because both cache=directsync
and cache=none
don't use the host page cache, and cache=direct write through qemu block layer
cache.
Signed-off-by: Peng H
From: caoxinhua
when we start a vm, we call JOB_MASK(QEMU_JOB_NONE), then 1 << -1 will be
execute. we fix it as return 0
---
src/libxl/libxl_domain.h | 2 +-
src/qemu/qemu_domain.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/libxl/libxl_domain.h b/src/libxl/libx
54 matches
Mail list logo
