Re: [libvirt] [PATCH 11/17] nwfilter: Rename __virNWFilterInstantiateFilter

On 07/13/2017 10:40 AM, Michal Privoznik wrote: > On 06/02/2017 12:25 PM, John Ferlan wrote: >> Rename to virNWFilterInstantiateFilterUpdate and alter the callers to not >> have one parameter per line. >> >> Signed-off-by: John Ferlan >> --- >>

Re: [libvirt] [PATCH 06/17] nwfilter: Add configFile into virNWFilterObj

On 07/13/2017 10:41 AM, Michal Privoznik wrote: > On 06/02/2017 12:25 PM, John Ferlan wrote: >> When creating an object, save the configFile name in the object rather >> than needing to build it up each time for the SaveConfig. This involves >> adding a @configDir parameter to

Re: [libvirt] [PATCH 07/17] nwfilter: Add @def into virNWFilterObjNew

On 07/13/2017 10:41 AM, Michal Privoznik wrote: > On 06/02/2017 12:25 PM, John Ferlan wrote: >> Modify the virNWFilterObjNew to take @def as a parameter and consume it. >> >> Signed-off-by: John Ferlan >> --- >> src/conf/virnwfilterobj.c | 13 - >> 1 file

Re: [libvirt] [PATCH 05/17] nwfilter: Move virNWFilterSaveConfig virnwfilterobj

On 07/13/2017 10:41 AM, Michal Privoznik wrote: > On 06/02/2017 12:25 PM, John Ferlan wrote: >> Move the function into nwfilterobj, rename it to virNWFilterObjSaveConfig, >> and alter the order of the arguments. >> >> Signed-off-by: John Ferlan >> --- >>

Re: [libvirt] [PATCH v4 3/4] qemu: Isolate hostdevs on pSeries guests

On 07/15/2017 11:30 AM, Andrea Bolognani wrote: > All the pieces are now in place, so we can finally start > using isolation groups to achieve our initial goal, which is > separating hostdevs from emulated PCI devices while keeping > hostdevs that belong to the same host IOMMU group together. > >

Re: [libvirt] [PATCH v4 2/4] conf: Implement isolation rules

On 07/15/2017 11:30 AM, Andrea Bolognani wrote: > These rules will make it possible for libvirt to > automatically assign PCI addresses in a way that > respects any isolation constraints devices might > have. > > Signed-off-by: Andrea Bolognani > Reviewed-by: Laine Stump

[libvirt] [PATCH] Revert "nwfilter: Move save of config until after successful assign"

This reverts commit b3e71a8830b2683ee88fa10cb048eabb99a446c0. As it turns out this ends up very badly as the @def could be Free'd even though it's owned by @obj as a result of the AssignDef. Signed-off-by: John Ferlan --- src/conf/virnwfilterobj.c | 6 +++--- 1 file

Re: [libvirt] [PATCH 02/17] nwfilter: Fix possible corruption on failure path during LoadConfig

On 07/14/2017 08:09 AM, Michal Privoznik wrote: > On 07/14/2017 01:50 AM, John Ferlan wrote: >> >> >> On 07/13/2017 10:41 AM, Michal Privoznik wrote: >>> On 06/02/2017 12:25 PM, John Ferlan wrote: If the virNWFilterSaveConfig in virNWFilterObjListLoadConfig, then jumping >>> >>> s/,/

[libvirt] [PATCH] docs: formatdomain: Tweak disk discard= docs

Change from 'controls whether to discard ... requests are ignored' to 'controls whether discard requests ... are ignored' Signed-off-by: Cole Robinson --- Pushed as trivial docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH 3/3] qemu: command: explicitly error for non-x86 default CPU

On Fri, 2017-07-14 at 19:43 -0400, Cole Robinson wrote: > The code only currently handles writing an x86 default -cpu > argument, and doesn't know anything about other architectures. > Let's make this explicit rather than leaving ex. qemu ppc64 to > throw an error about -cpu qemu64 > >

[libvirt] [PATCH v4 3/4] qemu: Isolate hostdevs on pSeries guests

All the pieces are now in place, so we can finally start using isolation groups to achieve our initial goal, which is separating hostdevs from emulated PCI devices while keeping hostdevs that belong to the same host IOMMU group together. Resolves:

[libvirt] [PATCH v4 2/4] conf: Implement isolation rules

These rules will make it possible for libvirt to automatically assign PCI addresses in a way that respects any isolation constraints devices might have. Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/conf/domain_addr.c | 73

[libvirt] [PATCH v4 4/4] news: Update for hostdev isolation

Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index d519b72..ea21cbc 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -51,6 +51,16 @@

[libvirt] [PATCH v4 1/4] conf: Introduce isolation groups

Isolation groups will eventually allow us to make sure certain devices, eg. PCI hostdevs, are assigned to guest PCI buses in a way that guarantees improved isolation, error detection and recovery for machine types and hypervisors that support it, eg. pSeries guest on QEMU. This patch merely

[libvirt] [PATCH v4 0/4] Host device isolation for pSeries guests

Changes from [v3]: * correctly handle interfaces connected to hostdev-backed networks; * drop patches implementing support for multiple PHBs, as they have been merged already; * some minor cleanups. Changes from [v2]: * support hot(un)plug properly; * add documentation.

Re: [libvirt] [PATCH 03/17] nwfilter: Fix possible locking problem in LoadConfig error path

On 07/14/2017 08:09 AM, Michal Privoznik wrote: > On 07/14/2017 01:52 AM, John Ferlan wrote: >> >> >> On 07/13/2017 10:41 AM, Michal Privoznik wrote: >>> On 06/02/2017 12:25 PM, John Ferlan wrote: After returning from virNWFilterObjListAssignDef the @obj is locked; however, if

[libvirt] [PATCH] security: Use VIR_DEBUG instead of VIR_INFO in virSecurityDACSetOwnershipInternal

virSecurityDACSetOwnershipInternal was called by libvirt child process, so if we log message by VIR_INFO at normal scene, it would probability occurs dead lock sence, then libvirtd will also by dead lock because libvirtd is waitting for child message. so our suggest is use VIR_DEBUG instead of

[libvirt] [PATCH] fix 1 << -1 at JOB_MASK macro

From: caoxinhua when we start a vm, we call JOB_MASK(QEMU_JOB_NONE), then 1 << -1 will be execute. we fix it as return 0 --- src/libxl/libxl_domain.h | 2 +- src/qemu/qemu_domain.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH RESEND] qemu: shared disks with cache=directsync should be safe for migration

From: Hao Peng At present shared disks can be migrated with either readonly or cache=none. But cache=directsync should be safe for migration, because both cache=directsync and cache=none don't use the host page cache, and cache=direct write through qemu block layer cache.

[libvirt] [PATCH] rpc : fix a access for null pointer

virNetSocketRemoveIOCallback get sock's ObjectLock and will call virNetSocketEventFree. virNetSocketEventFree may be free sock object and virNetSocketRemoveIOCallback will access a null pointer in release sock's ObjectLock. Signed-off-by: Liu Yun Signed-off-by: Peng Hao