Re: [libvirt] [PATCH v4 2/3] conf: Introduce TLS options for VxHS block device clients

On 07/18/2017 11:11 PM, ashish mittal wrote: > On Mon, Jul 17, 2017 at 4:50 PM, John Ferlan wrote: >> >> >> On 07/12/2017 06:09 PM, ashish mittal wrote: >>> On Fri, Jun 30, 2017 at 1:29 PM, John Ferlan wrote: On 06/29/2017 10:02 PM, Ashish

[libvirt] [PATCH] qemu: Fix bug assuming usage of default UUID for certificate passphrase

If an environment specific _tls_x509_cert_dir is provided, then do not VIR_STRDUP the defaultTLSx509secretUUID as that would be for the "default" environment and not the vnc, spice, chardev, or migrate environments. If the environment needs a secret to decode it's certificate, then it must provide

Re: [libvirt] [PATCH v3 2/2] virt-aa-helper-test: Add test for aarch32 UEFI image path

On 07/20/2017 03:56 PM, dann frazier wrote: > Signed-off-by: dann frazier > --- > tests/virt-aa-helper-test | 1 + > 1 file changed, 1 insertion(+) > Just in case it's not obvious - this one got pushed too. Tks - John -- libvir-list mailing list

Re: [libvirt] [PATCH v3 1/2] qemu: Add AAVMF32 to the list of known UEFIs

On 07/21/2017 06:52 AM, Andrea Bolognani wrote: > On Thu, 2017-07-20 at 13:56 -0600, dann frazier wrote: >> @@ -131,6 +131,8 @@ void qemuDomainCmdlineDefFree(qemuDomainCmdlineDefPtr >> def) >> #define VIR_QEMU_OVMF_SEC_NVRAM_PATH "/usr/share/OVMF/OVMF_VARS.fd" >> #define

[libvirt] [PATCH v3] qemu: Check for existence of provided *_tls_x509_cert_dir

https://bugzilla.redhat.com/show_bug.cgi?id=1458630 Introduce virQEMUDriverConfigTLSDirValidateResetDefault to validate that if any of the *_tls_x509_cert_dir values were set properly and reset the default value if the default_tls_x509_cert_dir changed. Update the qemu.conf description for

[libvirt] [PATCH 0/3] properly handle '=' in the VNC socket path

Pavel Hrdina (3): qemu: capabilities: introduce QEMU_CAPS_VNC_MULTI_SERVERS qemu: properly handle '=' in the VNC socket path tests: add test case for VNC unix path with '=' src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 3

[libvirt] [PATCH 2/3] qemu: properly handle '=' in the VNC socket path

If a domain name contains a '=' and the unix socket path is auto-generated or socket path provided by user contains '=' QEMU is unable to properly parse the command line. In order to make it work we need to use the new command line syntax for VNC or we will fail to start/define such domain.

[libvirt] [PATCH 1/3] qemu: capabilities: introduce QEMU_CAPS_VNC_MULTI_SERVERS

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_capabilities.c| 4 src/qemu/qemu_capabilities.h| 3 +++ tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml| 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml

[libvirt] [PATCH 3/3] tests: add test case for VNC unix path with '='

Signed-off-by: Pavel Hrdina --- ...muxml2argv-graphics-vnc-socket-new-cmdline.args | 22 ++ ...emuxml2argv-graphics-vnc-socket-new-cmdline.xml | 20 ...argv-graphics-vnc-socket-path-not-supported.xml | 1 + tests/qemuxml2argvtest.c

[libvirt] [PATCH 1/3] migrate-getmaxdowntime command qemu side

From: Scott Garfinkle JSON-only implementation to retrieve downtime-limit from Qemu - aka GetMaxDowntime. Signed-off-by: Scott Garfinkle --- src/qemu/qemu_driver.c | 45 src/qemu/qemu_monitor.c | 12

[libvirt] [PATCH 0/3] implement migrate-getmaxdowntime command

Currently, the maximum tolerable downtime for a domain being migrated is write-only. This patch implements a way to query that value nondestructively. Signed-off-by: Scott Garfinkle -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH 2/3] migrate-getmaxdowntime public symbols and table indices

From: Scott Garfinkle virsh migrate-getmaxdowntime command public symbols, indices, and dependencies. Signed-off-by: Scott Garfinkle --- src/libvirt_public.syms | 4 src/remote/remote_protocol.x | 16 +++- src/remote_protocol-structs

Re: [libvirt] 答复: Re: [PATCH v2] network: allow to specify buffer size fornetlink socket

On 07/20/2017 11:08 PM, lu.zhip...@zte.com.cn wrote: > i will try to update libnl3 to 3.2.29 ,now libnl3 is 3.2.8 in my host Do you really mean 3.2.8 and not 3.2.28? 3.2.8 was released in April 2012, so a lot has changed since then; 3.2.28 was released in July 2016, so much more recent. --

[libvirt] [PATCH 3/3] migrate-getmaxdowntime local/libvirt bits

From: Scott Garfinkle virsh migrate-getmaxdowntime command libvirt and virsh side, including help Signed-off-by: Scott Garfinkle --- include/libvirt/libvirt-domain.h | 4 src/driver-hypervisor.h | 6 ++ src/libvirt-domain.c |

Re: [libvirt] [PATCH v2] qemu: Remove duplicated code in qemuBuildSerialChrDeviceStr()

On Thu, 2017-06-22 at 16:03 -0400, Laine Stump wrote: > > The call to qemuBuildDeviceAddressStr() happens no matter > > what, so we can move it to the outer possible scope inside > > the function. > >  > > We can also move the call to virBufferAsprintf() after all > > the checks have been

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

On Fri, Jul 21, 2017 at 04:33:06PM +0200, Jiri Denemark wrote: > On Fri, Jul 21, 2017 at 14:42:05 +0100, Daniel P. Berrange wrote: > > On Fri, Jul 21, 2017 at 03:00:20PM +0200, Martin Kletzander wrote: > > > > struct meh { > > > /*# This is comment for the following member foo */ > > >

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

On Fri, Jul 21, 2017 at 02:42:05PM +0100, Daniel P. Berrange wrote: On Fri, Jul 21, 2017 at 03:00:20PM +0200, Martin Kletzander wrote: On Fri, Jul 21, 2017 at 11:58:45AM +0100, Daniel P. Berrange wrote: > On Fri, Jul 21, 2017 at 12:52:06PM +0200, Michal Privoznik wrote: > > There are only two

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

On Fri, Jul 21, 2017 at 14:42:05 +0100, Daniel P. Berrange wrote: > On Fri, Jul 21, 2017 at 03:00:20PM +0200, Martin Kletzander wrote: > > struct meh { > > /*# This is comment for the following member foo */ > > unsigned int foo; > > int bar; /*< This is for member bar that's on

Re: [libvirt] [PATCH 2/3] qemu: command: rework adding of default cpu model

On Fri, Jul 14, 2017 at 07:43:05PM -0400, Cole Robinson wrote: Certain XML features that aren't in the block map to -cpu flags on the qemu cli. If one of these is specified but the user didn't explicitly pass an XML model, we need to format a default model on the command line. The current

Re: [libvirt] [PATCH 3/3] qemu: command: explicitly error for non-x86 default CPU

On Fri, Jul 14, 2017 at 07:43:06PM -0400, Cole Robinson wrote: The code only currently handles writing an x86 default -cpu argument, and doesn't know anything about other architectures. Let's make this explicit rather than leaving ex. qemu ppc64 to throw an error about -cpu qemu64

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

On Fri, Jul 21, 2017 at 03:00:20PM +0200, Martin Kletzander wrote: > On Fri, Jul 21, 2017 at 11:58:45AM +0100, Daniel P. Berrange wrote: > > On Fri, Jul 21, 2017 at 12:52:06PM +0200, Michal Privoznik wrote: > > > There are only two acceptable places for describing enum values. > > > It's either: >

[libvirt] [PATCH v2 7/7] qemu: privatize _virQEMUCapsCachePriv struct

Signed-off-by: Pavel Hrdina --- Notes: Changes in v2: - the body of structure was changed src/qemu/qemu_capabilities.c | 10 ++ src/qemu/qemu_capspriv.h | 12 2 files changed, 10 insertions(+), 12 deletions(-) diff --git

[libvirt] [PATCH v2 0/7] introduce virFileCache and use it for qemu capabilities

Pavel Hrdina (7): util: introduce virFileCache tests: add virfilecachetest qemu: introduce struct _virQEMUCapsCachePriv tests: rewrite host CPU mocking qemu: pass only host arch instead of the whole virCaps qemu: switch QEMU capabilities to use virFileCache qemu: privatize

[libvirt] [PATCH v2 3/7] qemu: introduce struct _virQEMUCapsCachePriv

This will store private data that will be used by following patches when switching to virFileCache. Signed-off-by: Pavel Hrdina Reviewed-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 51 ++--

[libvirt] [PATCH v2 5/7] qemu: pass only host arch instead of the whole virCaps

This is a preparation for following patches where we switch to virFileCache for QEMU capabilities cache The host arch will always remain the same but virCaps may change. Now the host arch is stored while creating new qemu capabilities cache. It removes the need to pass virCaps into

[libvirt] [PATCH v2 6/7] qemu: switch QEMU capabilities to use virFileCache

The switch contains considerable amount of changes: virQEMUCapsRememberCached() is removed because this is now handled by virFileCacheSave(). virQEMUCapsInitCached() is removed because this is now handled by virFileCacheLoad(). virQEMUCapsNewForBinary() is split into two functions,

Re: [libvirt] [PATCH v3 3/3] qemu: Enable NUMA node tag in pci-root for PPC64

On Fri, 2017-07-21 at 13:33 +0530, Shivaprasad G Bhat wrote: [...] > +++ b/docs/formatdomain.html.in > @@ -3778,7 +3778,9 @@ > >node > > -pci-expander-bus controllers can have an > +Some PCI controllers (pci-expander-bus for the pc machine > +type,

[libvirt] [PATCH v2 4/7] tests: rewrite host CPU mocking

Move all the host CPU data into a separate file and rewrite qemucpumock to not use passed @caps. This is preparation for following patch which will replace virCaps argument with virArch. Signed-off-by: Pavel Hrdina --- Notes: New in v2 tests/domaincapstest.c| 55

[libvirt] [PATCH v2 2/7] tests: add virfilecachetest

Implements 3 test cases that covers how the cache is used. We have to mock unlink() function because the caching code unlinks files that are no longer valid and we don't want to do it in our tests. Signed-off-by: Pavel Hrdina --- Notes: Changes in v2: - added

[libvirt] [PATCH v2 1/7] util: introduce virFileCache

The new virFileCache will nicely handle the caching logic for any data that we would like to cache. For each type of data we will just need to implement few handlers that will take care of creating, validating, loading and saving the cached data. The cached data must be an instance of virObject.

Re: [libvirt] 答复: Re: [PATCH] rpc : fix a access for null pointer

On 07/21/2017 08:20 AM, liu.y...@zte.com.cn wrote: > Hi Michal, > > This problem is triggerred by libvirt python's example event-test.py. the > original examples has resouce leak issue > > at the remove_handle and remove_timer. > > with "python -u event-test.py" run this example and

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

On Fri, Jul 21, 2017 at 11:58:45AM +0100, Daniel P. Berrange wrote: On Fri, Jul 21, 2017 at 12:52:06PM +0200, Michal Privoznik wrote: There are only two acceptable places for describing enum values. It's either: typedef enum { /* Some long description. Therefore it's placed before

[libvirt] 答复: Re: [PATCH] rpc : fix a access for null pointer

Hi Michal, This problem is triggerred by libvirt python's example event-test.py. the original examples has resouce leak issue at the remove_handle and remove_timer. with "python -u event-test.py" run this example and "systemctl restart libvirtd.service" will trigger resource leak

Re: [libvirt] [PATCH v3 2/3] qemu: capabilitity: Introduce QEMU_CAPS_SPAPR_PCI_HOST_BRIDGE_NUMA_NODE

On Fri, 2017-07-21 at 13:32 +0530, Shivaprasad G Bhat wrote: > @@ -1899,7 +1904,10 @@ static struct virQEMUCapsObjectTypeProps > virQEMUCapsObjectProps[] = { >-1 }, >  { "intel-iommu", virQEMUCapsObjectPropsIntelIOMMU, >ARRAY_CARDINALITY(virQEMUCapsObjectPropsIntelIOMMU), > -  

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, 21 Jul 2017 13:26:14 +0200 Michal Privoznik wrote: > On 07/21/2017 01:17 PM, Tomáš Golembiovský wrote: > > On Fri, 21 Jul 2017 12:58:55 +0200 > > Michal Privoznik wrote: > > > >> On 07/21/2017 12:25 PM, Tomáš Golembiovský wrote: > >>> On

Re: [libvirt] [PATCH v2 1/6] qemu: command: Rename and move qemuNetworkDriveGetPort

[...] Before it's too late... > + > +/** > + * virStringParsePort: > + * @str: port number to parse > + * @port: pointer to parse port into > + * > + * Parses a string representation of a network port and validates it. Returns > + * 0 on success and -1 on error. > + */ > +int >

Re: [libvirt] [PATCH 1/3] tests: add qemu x86 kvm 32-on-64 test

On Fri, Jul 14, 2017 at 07:43:04PM -0400, Cole Robinson wrote: > There's some specific logic in qemuBuildCpuCommandLine to support > auto adding -cpu qemu 32 for arch=i686 with an x86_64 qemu-kvm binary. > Add a test case for it > > Signed-off-by: Cole Robinson > --- >

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On 07/21/2017 01:17 PM, Tomáš Golembiovský wrote: > On Fri, 21 Jul 2017 12:58:55 +0200 > Michal Privoznik wrote: > >> On 07/21/2017 12:25 PM, Tomáš Golembiovský wrote: >>> On Fri, 21 Jul 2017 10:12:38 +0200 >>> Michal Privoznik wrote: >>> On

Re: [libvirt] [PATCH] qemu: Clean up firmware list initialization

On 07/21/2017 12:44 PM, Andrea Bolognani wrote: > Instead of going through two completely different code paths, > one of which repeats the same hardcoded bit of information > three times in rapid succession, depending on whether or not > a firmware list has been provided at configure time, just >

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, 21 Jul 2017 12:58:55 +0200 Michal Privoznik wrote: > On 07/21/2017 12:25 PM, Tomáš Golembiovský wrote: > > On Fri, 21 Jul 2017 10:12:38 +0200 > > Michal Privoznik wrote: > > > >> On 07/20/2017 08:21 PM, Tomáš Golembiovský wrote: > >>> The

Re: [libvirt] [PATCH 10/19] storage: Create accessor API's for virStoragePoolObj

On 07/21/2017 04:22 AM, Pavel Hrdina wrote: > On Thu, Jul 20, 2017 at 05:38:53PM -0400, John Ferlan wrote: >> On 07/14/2017 11:37 AM, Pavel Hrdina wrote: >>> On Tue, May 09, 2017 at 11:30:17AM -0400, John Ferlan wrote: In preparation for making a private object, create accessor API's for

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, Jul 21, 2017 at 01:03:13PM +0200, Michal Privoznik wrote: > On 07/21/2017 01:01 PM, Daniel P. Berrange wrote: > > On Fri, Jul 21, 2017 at 12:58:55PM +0200, Michal Privoznik wrote: > >> > >> Yeah. Our generator is not that great. I wish that we'd switch to > >> something already out there

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On 07/21/2017 01:01 PM, Daniel P. Berrange wrote: > On Fri, Jul 21, 2017 at 12:58:55PM +0200, Michal Privoznik wrote: >> >> Yeah. Our generator is not that great. I wish that we'd switch to >> something already out there so that we don't have to maintain our own >> generator. > > There's a good

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, Jul 21, 2017 at 12:58:55PM +0200, Michal Privoznik wrote: > On 07/21/2017 12:25 PM, Tomáš Golembiovský wrote: > > On Fri, 21 Jul 2017 10:12:38 +0200 > > Michal Privoznik wrote: > > > >> On 07/20/2017 08:21 PM, Tomáš Golembiovský wrote: > >>> The documentation string

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

On Fri, Jul 21, 2017 at 12:52:06PM +0200, Michal Privoznik wrote: > There are only two acceptable places for describing enum values. > It's either: > > typedef enum { > /* Some long description. Therefore it's placed before > * the value. */ > VIR_ENUM_A_VAL = 1, >

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On 07/21/2017 12:25 PM, Tomáš Golembiovský wrote: > On Fri, 21 Jul 2017 10:12:38 +0200 > Michal Privoznik wrote: > >> On 07/20/2017 08:21 PM, Tomáš Golembiovský wrote: >>> The documentation string has to follow the definition of a constant in >>> the enum. Otherwise, the

[libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

There are only two acceptable places for describing enum values. It's either: typedef enum { /* Some long description. Therefore it's placed before * the value. */ VIR_ENUM_A_VAL = 1, } virEnumA; or: typedef enum { VIR_ENUM_B_VAL = 1, /* Some short

Re: [libvirt] [PATCH v3 1/2] qemu: Add AAVMF32 to the list of known UEFIs

On Thu, 2017-07-20 at 13:56 -0600, dann frazier wrote: > @@ -131,6 +131,8 @@ void qemuDomainCmdlineDefFree(qemuDomainCmdlineDefPtr def) >  #define VIR_QEMU_OVMF_SEC_NVRAM_PATH "/usr/share/OVMF/OVMF_VARS.fd" >  #define VIR_QEMU_AAVMF_LOADER_PATH "/usr/share/AAVMF/AAVMF_CODE.fd" >  #define

[libvirt] [PATCH] qemu: Clean up firmware list initialization

Instead of going through two completely different code paths, one of which repeats the same hardcoded bit of information three times in rapid succession, depending on whether or not a firmware list has been provided at configure time, just provide a reasonable default value and remove the extra

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, Jul 21, 2017 at 12:25:02PM +0200, Tomáš Golembiovský wrote: > On Fri, 21 Jul 2017 10:12:38 +0200 > Michal Privoznik wrote: > > > On 07/20/2017 08:21 PM, Tomáš Golembiovský wrote: > > > The documentation string has to follow the definition of a constant in > > > the

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, Jul 21, 2017 at 10:12:38AM +0200, Michal Privoznik wrote: > On 07/20/2017 08:21 PM, Tomáš Golembiovský wrote: > > The documentation string has to follow the definition of a constant in > > the enum. Otherwise, the HTML documentation will be generated > > incorrectly. > > > >

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, 21 Jul 2017 10:12:38 +0200 Michal Privoznik wrote: > On 07/20/2017 08:21 PM, Tomáš Golembiovský wrote: > > The documentation string has to follow the definition of a constant in > > the enum. Otherwise, the HTML documentation will be generated > > incorrectly. > > >

Re: [libvirt] [PATCH v2 0/6] Convert port to unsigned integer

On Thu, Jul 20, 2017 at 02:29:57PM +0200, Peter Krempa wrote: Since Michal did not want to finis this I did. I also found a few bugs in my previous patches which are addressed here. Thank you for taking this up, even though you did not finish the word 'finish'. Peter Krempa (6): qemu:

Re: [libvirt] [PATCH v2 2/3] qemu: capabilitity: Introduce QEMU_CAPS_SPAPR_PCI_HOST_BRIDGE_NUMA_NODE

On 07/19/2017 07:08 PM, Andrea Bolognani wrote: On Mon, 2017-07-17 at 21:28 +0530, Shivaprasad G Bhat wrote: [...] @@ -1900,6 +1905,9 @@ static struct virQEMUCapsObjectTypeProps virQEMUCapsObjectProps[] = { { "intel-iommu", virQEMUCapsObjectPropsIntelIOMMU,

Re: [libvirt] [PATCH RESEND] qemu: Remove inactive vm when failedtostart it

>On 07/12/2017 07:34 AM, wang yi59 zte com cn wrote: >> Hi John, >> >> Thanks for your review! >> > >Somehow your response is out of synch with the rest of the series - >things like this get lost very quickly. > >>> This seems to be a strange sequence of operations, but the claim is that

Re: [libvirt] [PATCH] conf: Fix backwards migration of pSeries guests

On Fri, 2017-07-21 at 10:07 +0200, Andrea Bolognani wrote: > > That is the main reason to fill all the values in right away. Since > > there apparently was a period, where a default would be used, but not > > recorded, it needs some trickery unfortunately. > >   > > In such case you basically

Re: [libvirt] [PATCH 10/19] storage: Create accessor API's for virStoragePoolObj

On Thu, Jul 20, 2017 at 05:38:53PM -0400, John Ferlan wrote: > On 07/14/2017 11:37 AM, Pavel Hrdina wrote: > > On Tue, May 09, 2017 at 11:30:17AM -0400, John Ferlan wrote: > >> In preparation for making a private object, create accessor API's for > >> consumer storage functions to use: > >> > >>

Re: [libvirt] [PATCH 11/19] storage: Introduce virStoragePoolObjNew

On Thu, Jul 20, 2017 at 06:00:05PM -0400, John Ferlan wrote: > > > On 07/11/2017 11:17 AM, Pavel Hrdina wrote: > > On Tue, May 09, 2017 at 11:30:18AM -0400, John Ferlan wrote: > >> Create/use a helper to perform object allocation. > >> > >> Signed-off-by: John Ferlan > >>

Re: [libvirt] [PATCH] conf: Fix backwards migration of pSeries guests

On Thu, 2017-07-20 at 09:55 +0200, Peter Krempa wrote: > > In any case, that made me realize that not sending the model, > > even if automatically filled in, could cause issues in the > > future if a new model is added and becomes the default, as > > the guest ABI would not be preserved during

Re: [libvirt] [PATCH v2 3/3] qemu: Enable NUMA node tag in pci-root for PPC64

Hi Andrea, On 07/20/2017 09:16 PM, Andrea Bolognani wrote: On Mon, 2017-07-17 at 21:29 +0530, Shivaprasad G Bhat wrote: @@ -3786,6 +3786,11 @@ part of the specified NUMA node (it is up to the user of the libvirt API to attach host devices to the correct

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On 07/20/2017 08:21 PM, Tomáš Golembiovský wrote: > The documentation string has to follow the definition of a constant in > the enum. Otherwise, the HTML documentation will be generated > incorrectly. > > Signed-off-by: Tomáš Golembiovský > --- >

[libvirt] [PATCH v3 3/3] qemu: Enable NUMA node tag in pci-root for PPC64

This patch addresses the same aspects on PPC the bug 1103314 addressed on x86. PCI expander bus creates multiple primary PCI busses, where each of these busses can be assigned a specific NUMA affinity, which, on x86 is advertised through ACPI on a per-bus basis. For SPAPR, a PHB's NUMA

[libvirt] [PATCH v3 2/3] qemu: capabilitity: Introduce QEMU_CAPS_SPAPR_PCI_HOST_BRIDGE_NUMA_NODE

The patch adds a capability for spapr-pci-host-bridge.numa_node. Signed-off-by: Shivaprasad G Bhat Reviewed-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 10 ++ src/qemu/qemu_capabilities.h |