Re: [libvirt] [PATCH 0/3] libxl: Add a test suite for libxl_domain_config generator

2017-07-27 Thread Marek Marczykowski-Górecki
On Thu, Jul 27, 2017 at 03:24:38PM -0600, Jim Fehlig wrote: > On 07/26/2017 05:07 PM, Marek Marczykowski-Górecki wrote: > > On Fri, Jul 14, 2017 at 05:59:57PM -0600, Jim Fehlig wrote: > > > On 07/01/2017 08:16 PM, Marek Marczykowski-Górecki wrote: > > > > On Sun, Feb 26, 2017 at 07:02:24PM -0700, J

Re: [libvirt] [PATCH 0/3] libxl: Add a test suite for libxl_domain_config generator

2017-07-27 Thread Jim Fehlig
On 07/26/2017 05:07 PM, Marek Marczykowski-Górecki wrote: On Fri, Jul 14, 2017 at 05:59:57PM -0600, Jim Fehlig wrote: On 07/01/2017 08:16 PM, Marek Marczykowski-Górecki wrote: On Sun, Feb 26, 2017 at 07:02:24PM -0700, Jim Fehlig wrote: Long ago danpb posted some patches to test libvirt domXML

Re: [libvirt] [PATCH v3 00/16] virObject adjustments for common object

2017-07-27 Thread John Ferlan
On 07/25/2017 05:29 AM, Pavel Hrdina wrote: > On Thu, Jun 22, 2017 at 10:02:30AM -0400, John Ferlan wrote: > > Let's move the discussion [1] into correct place. > >> Still, I must be missing something. Why is it wrong to create a new >> object that would have a specific use? virObjectLockable w

Re: [libvirt] Entering freeze for libvirt-3.6.0

2017-07-27 Thread Peter Krempa
On Thu, Jul 27, 2017 at 17:20:22 +0100, Daniel Berrange wrote: > On Thu, Jul 27, 2017 at 06:14:58PM +0200, Andrea Bolognani wrote: > > On Thu, 2017-07-27 at 22:42 +0800, Daniel Veillard wrote: > > >   As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 > > > signed tarball and r

Re: [libvirt] [RFC]Add new mdev interface for QoS

2017-07-27 Thread Alex Williamson
On Thu, 27 Jul 2017 17:17:48 +0100 "Daniel P. Berrange" wrote: > On Wed, Jul 26, 2017 at 10:43:43AM -0600, Alex Williamson wrote: > > [cc +libvir-list] > > > > On Wed, 26 Jul 2017 21:16:59 +0800 > > "Gao, Ping A" wrote: > > > > > The vfio-mdev provide the capability to let different guest sh

Re: [libvirt] status of support for cache allocation technology?

2017-07-27 Thread Chris Friesen
On 07/27/2017 05:08 AM, Martin Kletzander wrote: Is the "[PATH V10 00/12] Support cache tune in libvirt" patch series the most recent set of patches? No, then there were several RFCs and then patch series again, IIRC, but you can expect a new one written from scratch to be posted soon. I can

Re: [libvirt] Entering freeze for libvirt-3.6.0

2017-07-27 Thread Daniel P. Berrange
On Thu, Jul 27, 2017 at 06:14:58PM +0200, Andrea Bolognani wrote: > On Thu, 2017-07-27 at 22:42 +0800, Daniel Veillard wrote: > >   As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 > > signed tarball and rpms available from the usual place: > >  > >   ftp://libvirt.org/libvir

Re: [libvirt] [RFC]Add new mdev interface for QoS

2017-07-27 Thread Daniel P. Berrange
On Wed, Jul 26, 2017 at 10:43:43AM -0600, Alex Williamson wrote: > [cc +libvir-list] > > On Wed, 26 Jul 2017 21:16:59 +0800 > "Gao, Ping A" wrote: > > > The vfio-mdev provide the capability to let different guest share the > > same physical device through mediate sharing, as result it bring a >

Re: [libvirt] Entering freeze for libvirt-3.6.0

2017-07-27 Thread Andrea Bolognani
On Thu, 2017-07-27 at 22:42 +0800, Daniel Veillard wrote: >   As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 > signed tarball and rpms available from the usual place: >  >   ftp://libvirt.org/libvirt/ >  >  > seems to work in my limited testing, https://ci.centos.org/view/l

Re: [libvirt] [RFC]Add new mdev interface for QoS

2017-07-27 Thread Gao, Ping A
On 2017/7/27 0:43, Alex Williamson wrote: > [cc +libvir-list] > > On Wed, 26 Jul 2017 21:16:59 +0800 > "Gao, Ping A" wrote: > >> The vfio-mdev provide the capability to let different guest share the >> same physical device through mediate sharing, as result it bring a >> requirement about how to

Re: [libvirt] [PATCH] tools: virsh: Adding unix socket support to 'domdisplay' command.

2017-07-27 Thread Julio Faracco
Thanks for the update, Michal. I did some other fixes related to spice too. Libvirt is freezed right now. So, I will wait the next wave to send the V2. 2017-07-24 10:42 GMT-03:00 Michal Privoznik : > On 07/20/2017 11:11 PM, Julio Faracco wrote: >> This commit adds the unix socket URL support to '

[libvirt] Entering freeze for libvirt-3.6.0

2017-07-27 Thread Daniel Veillard
As planned I tagged 3.6.0-rc1 in git and I made the Release Candidate 1 signed tarball and rpms available from the usual place: ftp://libvirt.org/libvirt/ seems to work in my limited testing, https://ci.centos.org/view/libvirt/ is all green (except for mingw maybe there is a portability issu

Re: [libvirt] [PATCH 00/12] Cleanup website generation & add favicons

2017-07-27 Thread Daniel P. Berrange
On Thu, Jul 27, 2017 at 04:02:35PM +0200, Michal Privoznik wrote: > On 07/26/2017 07:51 PM, Daniel P. Berrange wrote: > > This started as an attempt to add modern favicon support to > > the website. This requires use of HTML5 only syntax, which > > lead to the massive cleanup to stop using XHTML 1.

Re: [libvirt] [PATCH 03/12] docs: make xmllint & xsltproc compulsory

2017-07-27 Thread Michal Privoznik
On 07/26/2017 07:51 PM, Daniel P. Berrange wrote: > We already require libxml to be installed, so it is not unreasonable > to require xmllint and xsltproc to be installed too - any platform > with the former will have the latter too. > > Signed-off-by: Daniel P. Berrange > --- > docs/Makefile.am

Re: [libvirt] [PATCH 00/12] Cleanup website generation & add favicons

2017-07-27 Thread Michal Privoznik
On 07/26/2017 07:51 PM, Daniel P. Berrange wrote: > This started as an attempt to add modern favicon support to > the website. This requires use of HTML5 only syntax, which > lead to the massive cleanup to stop using XHTML 1.0, which > forms all of this series except the last patch > > Daniel P. B

Re: [libvirt] Exposing mem-path in domain XML

2017-07-27 Thread Daniel P. Berrange
On Thu, Jul 27, 2017 at 02:11:25PM +0200, Michal Privoznik wrote: > Dear list, > > there is the following bug [1] which I'm not quite sure how to grasp. So > there is this application/infrastructure called Kove [2] that allows you > to have memory for your application stored on a distant host in n

Re: [libvirt] [PATCH 2/2] conf: Introduce the virDomainNetModel enumeration

2017-07-27 Thread Andrea Bolognani
On Thu, 2017-07-27 at 14:36 +0200, Peter Krempa wrote: > > Would you still be against it if the enumeration was extended > > to include every NIC model ever supported by QEMU and Xen? As > > mentioned, other drivers already perform their own validation > > and only accept a very limited number of m

Re: [libvirt] [PATCH 2/2] conf: Introduce the virDomainNetModel enumeration

2017-07-27 Thread Peter Krempa
On Thu, Jul 27, 2017 at 13:05:16 +0200, Andrea Bolognani wrote: > On Wed, 2017-07-26 at 18:21 +0200, Peter Krempa wrote: > > > @@ -10330,18 +10349,20 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr > > > xmlopt, > > >   * i82551 i82557b i82559er ne2k_pci pcnet rtl8139 e1000 virtio > > >  

[libvirt] Exposing mem-path in domain XML

2017-07-27 Thread Michal Privoznik
Dear list, there is the following bug [1] which I'm not quite sure how to grasp. So there is this application/infrastructure called Kove [2] that allows you to have memory for your application stored on a distant host in network and basically fetch needed region on pagefault. Now imagine that some

Re: [libvirt] [PATCH v2] Add support for virtio-net.tx_queue_size

2017-07-27 Thread Peter Krempa
On Thu, Jul 20, 2017 at 21:36:28 -0400, Laine Stump wrote: > On 07/18/2017 07:12 AM, Michal Privoznik wrote: [...] > > @@ -5201,6 +5201,20 @@ qemu-kvm -net nic,model=? /dev/null > > In general you should leave this option alone, unless you > > are very certain you kn

[libvirt] [PATCH 5/7] virNodeDeviceObjList: Derive from virObjectRWLockable

2017-07-27 Thread Michal Privoznik
There is no reason why two threads trying to look up two node devices should mutually exclude each other. Utilize new virObjectRWLockable that was just introduced. Signed-off-by: Michal Privoznik --- src/conf/virnodedeviceobj.c | 16 1 file changed, 8 insertions(+), 8 deletions(

[libvirt] [PATCH 6/7] virConnect: Derive from virObjectRWLockable

2017-07-27 Thread Michal Privoznik
There is no reason why two threads trying to copy error from connection should mutually exclude each other. Utilize new virObjectRWLockable that was just introduced. Signed-off-by: Michal Privoznik --- src/datatypes.c | 6 -- src/datatypes.h | 2 +- src/util/virerror.c | 2 +- 3 file

[libvirt] [PATCH 7/7] storageDriver: Use RW locks

2017-07-27 Thread Michal Privoznik
Currently, the storage driver doesn't have virStoragePoolList object. It maintains the list itself. To mutually exclude two threads trying to access it mutexes are used. However, this hurts performance as there's no reason why two threads reading from the list cannot run at the same time. Signed-o

[libvirt] [PATCH 0/7] Misc improvements

2017-07-27 Thread Michal Privoznik
As I started to turn more object into using RW locks, I've found couple of areas for improvement too. Michal Privoznik (7): virConnect: Update comment for @privateData Report error if virMutexInit fails virnetworkobj: Make virNetworkObjFindBy{UUID,Name}Locked() static again virNetworkO

[libvirt] [PATCH 4/7] virNetworkObjList: Derive from virObjectRWLockable

2017-07-27 Thread Michal Privoznik
There is no reason why two threads trying to look up two networks should mutually exclude each other. Utilize new virObjectRWLockable that was just introduced. Signed-off-by: Michal Privoznik --- src/conf/virnetworkobj.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-

[libvirt] [PATCH 2/7] Report error if virMutexInit fails

2017-07-27 Thread Michal Privoznik
The virMutexInit() function is not reporting any error on failure rather than returning -1 and setting errno. It's up to the caller to report the error. Signed-off-by: Michal Privoznik --- src/bhyve/bhyve_driver.c | 1 + src/lxc/lxc_driver.c | 1 + src/lxc/lxc_f

[libvirt] [PATCH 1/7] virConnect: Update comment for @privateData

2017-07-27 Thread Michal Privoznik
This member allows us to store a pointer to some private data. However, the comment says it's used in both domain driver and network driver. Well, it is not. It's just one pointer and domain driver uses it directly. Network driver has a global driver variable. Update the comment to not confuse othe

[libvirt] [PATCH 3/7] virnetworkobj: Make virNetworkObjFindBy{UUID, Name}Locked() static again

2017-07-27 Thread Michal Privoznik
These functions were made exportable back in 3aa3e072 when I was splitting network code into parsing and list management parts. Since then the split is finished now and these two functions do not need to be exported anymore. Signed-off-by: Michal Privoznik --- src/conf/virnetworkobj.c | 22 ++---

Re: [libvirt] status of support for cache allocation technology?

2017-07-27 Thread Martin Kletzander
On Wed, Jul 26, 2017 at 03:20:02PM -0600, Chris Friesen wrote: Hi, I'm just wondering what the current status is about exposing/controlling cache banks. Looking at the code, it appears that we report the banks as part of "virsh capabilities". Is it possible to associate a particular bank with

Re: [libvirt] [PATCH 2/2] conf: Introduce the virDomainNetModel enumeration

2017-07-27 Thread Andrea Bolognani
On Wed, 2017-07-26 at 18:21 +0200, Peter Krempa wrote: > > @@ -10330,18 +10349,20 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr > > xmlopt, > >   * i82551 i82557b i82559er ne2k_pci pcnet rtl8139 e1000 virtio > >   * QEMU PPC64 supports spapr-vlan > >   */ > > -if (model != NULL)

[libvirt] [PATCH] Revert "build: distribute tests/virfilecachedata"

2017-07-27 Thread Pavel Hrdina
This reverts commit d3d422e00c995d50c4b78066367bfbc4f872f586. Already fixed by commit 5a30b817ec93543c7a6cc93b5a6091ae377e. --- Sigh, Dan pushed it before me while I was waiting for "make distcheck". Well, that happens :) tests/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/

[libvirt] [PATCH] build: distribute tests/virfilecachedata

2017-07-27 Thread Pavel Hrdina
Missed by 478f0c5b8575. Signed-off-by: Pavel Hrdina --- Pushed under build-breaker rule. tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 8349bbec41..a7aa973746 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -147,6 +14

Re: [libvirt] [PATCH 00/24] qemu: refactor node name detection

2017-07-27 Thread Peter Krempa
On Wed, Jul 26, 2017 at 17:20:33 -0500, Eric Blake wrote: > On 07/26/2017 05:00 AM, Peter Krempa wrote: > > Since query-blockstats provides full hierarchy of node names without any > > doubtful > > matching algorithm, use it to make the node name detector reliable. > > > > Unfortunately some of t

[libvirt] [PATCH] tests: add virfilecachedata to EXTRA_DIST

2017-07-27 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- Pushed as a build fix tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 8349bbec4..9a822f7d5 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -164,6 +164,7 @@ EXTRA_DIST =

Re: [libvirt] [PATCH 2/2] security: apparmor: load the storage driver dynamically

2017-07-27 Thread Daniel P. Berrange
On Wed, Jul 26, 2017 at 10:12:14PM +0200, Peter Krempa wrote: > In commit 5e515b542d I've attempted to fix the inability to access > storage from the apparmor helper program by linking with the storage > driver. By linking with the .so the linker complains that it's not > portable. Fix this by load

Re: [libvirt] [PATCH RFC 1/2] make: Drop building without driver modules

2017-07-27 Thread Daniel P. Berrange
On Wed, Jul 26, 2017 at 10:12:13PM +0200, Peter Krempa wrote: > Driver modules proved to be reliable for a long time. Since support for > not building modules complicates the code and makefiles drop the support > for not building drivers as modules. > --- > > Notes: > This was suggested a whil

Re: [libvirt] [PATCH v2 0/3] properly handle '=' in the VNC socket path

2017-07-27 Thread Pavel Hrdina
On Thu, Jul 27, 2017 at 10:45:56AM +0200, Ján Tomko wrote: > On Thu, Jul 27, 2017 at 10:33:27AM +0200, Pavel Hrdina wrote: > >Pavel Hrdina (3): > > qemu: capabilities: introduce QEMU_CAPS_VNC_MULTI_SERVERS > > qemu: properly handle '=' in the VNC socket path > > tests: add test case for new synt

Re: [libvirt] [PATCH v2 0/3] properly handle '=' in the VNC socket path

2017-07-27 Thread Ján Tomko
On Thu, Jul 27, 2017 at 10:33:27AM +0200, Pavel Hrdina wrote: Pavel Hrdina (3): qemu: capabilities: introduce QEMU_CAPS_VNC_MULTI_SERVERS qemu: properly handle '=' in the VNC socket path tests: add test case for new syntax of VNC unix path with '=' src/qemu/qemu_capabilities.c

Re: [libvirt] [PATCH v4] qemu: Check for existence of provided *_tls_x509_cert_dir

2017-07-27 Thread Ján Tomko
On Wed, Jul 26, 2017 at 05:05:17PM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1458630 Introduce virQEMUDriverConfigTLSDirResetDefaults in order to check if the defaultTLSx509certdir was changed, then change the default for any other *TLSx509certdir that was not set to

[libvirt] [PATCH v2 2/3] qemu: properly handle '=' in the VNC socket path

2017-07-27 Thread Pavel Hrdina
If a domain name contains a '=' and the unix socket path is auto-generated or socket path provided by user contains '=' QEMU is unable to properly parse the command line. In order to make it work we need to use the new command line syntax for VNC if it's available, otherwise we can use the old syn

[libvirt] [PATCH v2 0/3] properly handle '=' in the VNC socket path

2017-07-27 Thread Pavel Hrdina
Pavel Hrdina (3): qemu: capabilities: introduce QEMU_CAPS_VNC_MULTI_SERVERS qemu: properly handle '=' in the VNC socket path tests: add test case for new syntax of VNC unix path with '=' src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h

[libvirt] [PATCH v2 1/3] qemu: capabilities: introduce QEMU_CAPS_VNC_MULTI_SERVERS

2017-07-27 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- Notes: ACKed src/qemu/qemu_capabilities.c| 2 ++ src/qemu/qemu_capabilities.h| 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml| 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml

[libvirt] [PATCH v2 3/3] tests: add test case for new syntax of VNC unix path with '='

2017-07-27 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- Notes: Changes in v2: - removed the test that should fail if qemu doesn't support new syntax for VNC ...muxml2argv-graphics-vnc-socket-new-cmdline.args | 22 ++ ...emuxml2argv-graphics-vnc-socket-new-cmdline.xml | 20

Re: [libvirt] [PATCH 20/24] tests: qemumonitorjson: Fix 'gluster' node name detection test case

2017-07-27 Thread Peter Krempa
On Wed, Jul 26, 2017 at 16:46:23 -0500, Eric Blake wrote: > On 07/26/2017 05:00 AM, Peter Krempa wrote: > > Add the blockstats data and fix the expected output. > > --- > > ...emumonitorjson-nodename-gluster-blockstats.json | 111 > > + > > ...mumonitorjson-nodename-gluster-na

Re: [libvirt] [PATCH 14/24] qemu: block: Refactor node name detection code

2017-07-27 Thread Peter Krempa
On Wed, Jul 26, 2017 at 16:21:25 -0500, Eric Blake wrote: > On 07/26/2017 05:00 AM, Peter Krempa wrote: > > Remove the complex and unreliable code which inferred the node name > > hierarchy only from data returned by 'query-named-block-nodes'. It turns > > out that query-blockstats contain the full

Re: [libvirt] [PATCH 07/24] tests: utils: Add virTestLoadFilePath helper

2017-07-27 Thread Peter Krempa
On Wed, Jul 26, 2017 at 10:46:56 -0500, Eric Blake wrote: > On 07/26/2017 08:39 AM, Eric Blake wrote: > > On 07/26/2017 05:00 AM, Peter Krempa wrote: > >> This new helper loads and returns a file from 'abs_srcdir'. By using > >> variable arguments for the function, it's not necessary to format the