Re: [libvirt] [PATCH 0/3] libxl: Add a test suite for libxl_domain_config generator

On Fri, Jul 28, 2017 at 05:24:10PM -0600, Jim Fehlig wrote: > On 07/27/2017 04:51 PM, Marek Marczykowski-Górecki wrote: > > On Thu, Jul 27, 2017 at 03:24:38PM -0600, Jim Fehlig wrote: > > > >> Did you have any comment on the approach taken in the attachments to this > >> thread? Particularly the

Re: [libvirt] [PATCH V2 2/2] libxl: Add a test suite for libxl_domain_config generator

On 07/28/2017 05:07 PM, Jim Fehlig wrote: > The libxl library allows a libxl_domain_config object to be serialized > from/to a JSON string. Use this to allow testing of the XML to > libxl_domain_config conversion process. Test XML is converted to > libxl_domain_config, which is then serialized to

Re: [libvirt] [PATCH 0/3] libxl: Add a test suite for libxl_domain_config generator

On 07/27/2017 04:51 PM, Marek Marczykowski-Górecki wrote: > On Thu, Jul 27, 2017 at 03:24:38PM -0600, Jim Fehlig wrote: > >> Did you have any comment on the approach taken in the attachments to this >> thread? Particularly the patch titled "libxl: make emulator checks >> mockable"? > I don't see

[libvirt] [PATCH V2 2/2] libxl: Add a test suite for libxl_domain_config generator

The libxl library allows a libxl_domain_config object to be serialized from/to a JSON string. Use this to allow testing of the XML to libxl_domain_config conversion process. Test XML is converted to libxl_domain_config, which is then serialized to json. A json template corresponding to the test

[libvirt] [PATCH V2 0/2]

This is V2 of a long standing series to add unit tests for libvirt domXML to libxl_domain_config conversions. There's a lot more history than a V2 would imply, which can be read in the last posting of the series https://www.redhat.com/archives/libvir-list/2017-February/msg01477.html Unlike

[libvirt] [PATCH V2 1/2] libxl: make emulator checks mockable

Export the libxl emulator checks with ATTRIBUTE_NOINLINE so they can be mocked in the test suite. While add it, change the function names to conform to naming standards. Signed-off-by: Jim Fehlig --- src/libxl/libxl_capabilities.c | 30 +-

[libvirt] [PATCH v2] tools: virsh: Adding unix socket support to 'domdisplay' command.

This commit adds the unix socket URL support to 'domdisplay' command. Before, even if an user was using unix socket to define a spice graphics, the command 'domdisplay' showed that the settings were not supported. Now, the command shows the proper URL: spice+unix://foo/bar.sock. Settings:

Re: [libvirt] [PATCH v2 1/2] tests: utils: Allow NULL strings to be equal to empty file in virTestCompareToFile

On 07/28/2017 05:43 AM, Peter Krempa wrote: > Treat an NULL string equivalent to an empty string in > virTestCompareToFile so that callers don't need to add additional logic > in case when a test produces no output. > --- > tests/testutils.c | 5 + > 1 file changed, 5 insertions(+) Works for

Re: [libvirt] [PATCH 7/7] util: Add safety net of checks to ensure valid object

On 07/28/2017 01:19 PM, Pavel Hrdina wrote: > On Fri, Jul 28, 2017 at 12:39:01PM -0400, John Ferlan wrote: >> The virObject logic "assumes" that whatever is passed to its API's >> would be some sort of virObjectPtr; however, if it is not then some >> really bad things can happen. >> >> So far

Re: [libvirt] [PATCH 1/7] util: Alter virObjectLockRead to return status

On 07/28/2017 12:56 PM, Pavel Hrdina wrote: > On Fri, Jul 28, 2017 at 12:38:55PM -0400, John Ferlan wrote: >> Rather than ignore errors, let's have virObjectLockRead check for >> the correct usage and issue an error when not properly used so >> so that we don't run into situations where the

Re: [libvirt] [PATCH 2/7] util: Introduce and use virObjectLockWrite

On 07/28/2017 12:59 PM, Pavel Hrdina wrote: > On Fri, Jul 28, 2017 at 12:38:56PM -0400, John Ferlan wrote: >> Instead of making virObjectLock be the entry point for two >> different types of locks, let's create a virObjectLockWrite API >> which will be able to return status and force the (new)

Re: [libvirt] [PATCH 7/7] util: Add safety net of checks to ensure valid object

On Fri, Jul 28, 2017 at 12:39:01PM -0400, John Ferlan wrote: > The virObject logic "assumes" that whatever is passed to its API's > would be some sort of virObjectPtr; however, if it is not then some > really bad things can happen. > > So far there's been only virObject{Ref|Unref},

Re: [libvirt] [PATCH 6/7] util: Create common error path for invalid object

On Fri, Jul 28, 2017 at 12:39:00PM -0400, John Ferlan wrote: > If virObjectIsClass fails "internally" to virobject.c, create a > macro to generate the VIR_WARN describing what the problem is. > Also improve the checks and message a bit to indicate which was > the failure - whether the obj was NULL

Re: [libvirt] [PATCH 5/7] util: Introduce and use virObjectRWUnlock

On Fri, Jul 28, 2017 at 12:38:59PM -0400, John Ferlan wrote: > Rather than overload virObjectUnlock as commit id '77f4593b' has > done, create a separate virObjectRWUnlock API that will force the > consumers to make the proper decision regarding unlocking the > RWLock's. This restores the

Re: [libvirt] [PATCH 4/7] util: Introduce virObjectGetRWLockableObj

On Fri, Jul 28, 2017 at 12:38:58PM -0400, John Ferlan wrote: > Introduce a helper to handle the error path more cleanly. The same > as virObjectGetLockableObj. > > Signed-off-by: John Ferlan > --- > src/util/virobject.c | 51

Re: [libvirt] [PATCH 3/7] util: Only have virObjectLock handle virObjectLockable

On Fri, Jul 28, 2017 at 12:38:57PM -0400, John Ferlan wrote: > Now that virObjectLockWrite exists to handle the virObjectRWLockable > objects, let's restore virObjectLock to only handle virObjectLockable > type locks. There still exists the possibility that the input @anyobj > isn't a valid object

Re: [libvirt] [PATCH 1/7] util: Alter virObjectLockRead to return status

On Fri, Jul 28, 2017 at 12:38:55PM -0400, John Ferlan wrote: > Rather than ignore errors, let's have virObjectLockRead check for > the correct usage and issue an error when not properly used so > so that we don't run into situations where the resource we think > we're locking really isn't locked

Re: [libvirt] [PATCH 2/7] util: Introduce and use virObjectLockWrite

On Fri, Jul 28, 2017 at 12:38:56PM -0400, John Ferlan wrote: > Instead of making virObjectLock be the entry point for two > different types of locks, let's create a virObjectLockWrite API > which will be able to return status and force the (new) consumers > of the RWLock to make sure the lock is

[libvirt] [PATCH 7/7] util: Add safety net of checks to ensure valid object

The virObject logic "assumes" that whatever is passed to its API's would be some sort of virObjectPtr; however, if it is not then some really bad things can happen. So far there's been only virObject{Ref|Unref}, virObject{Lock|Unlock}, and virObjectIsClass and the virObject and virObjectLockable

[libvirt] [PATCH 3/7] util: Only have virObjectLock handle virObjectLockable

Now that virObjectLockWrite exists to handle the virObjectRWLockable objects, let's restore virObjectLock to only handle virObjectLockable type locks. There still exists the possibility that the input @anyobj isn't a valid object and the resource isn't truly locked, but that also exists before

[libvirt] [PATCH 5/7] util: Introduce and use virObjectRWUnlock

Rather than overload virObjectUnlock as commit id '77f4593b' has done, create a separate virObjectRWUnlock API that will force the consumers to make the proper decision regarding unlocking the RWLock's. This restores the virObjectUnlock code to using the virObjectGetLockableObj as well.

[libvirt] [PATCH 4/7] util: Introduce virObjectGetRWLockableObj

Introduce a helper to handle the error path more cleanly. The same as virObjectGetLockableObj. Signed-off-by: John Ferlan --- src/util/virobject.c | 51 ++- 1 file changed, 30 insertions(+), 21 deletions(-) diff --git

[libvirt] [PATCH 2/7] util: Introduce and use virObjectLockWrite

Instead of making virObjectLock be the entry point for two different types of locks, let's create a virObjectLockWrite API which will be able to return status and force the (new) consumers of the RWLock to make sure the lock is really obtained when the "right" object type is passed.

[libvirt] [PATCH 6/7] util: Create common error path for invalid object

If virObjectIsClass fails "internally" to virobject.c, create a macro to generate the VIR_WARN describing what the problem is. Also improve the checks and message a bit to indicate which was the failure - whether the obj was NULL or just not the right class Signed-off-by: John Ferlan

[libvirt] [PATCH 0/7] Some virObjectRW* adjustments

As indicated in a couple of recent reviews, the new virObjectRWLockable object and API's I believe needed a few adjustments in order to make them better. So I present those thoughts in patch format to be hopefully dicussed and dissected. Essentially this series, will modify the newly added

[libvirt] [PATCH 1/7] util: Alter virObjectLockRead to return status

Rather than ignore errors, let's have virObjectLockRead check for the correct usage and issue an error when not properly used so so that we don't run into situations where the resource we think we're locking really isn't locked because the void input parameter wasn't valid. Signed-off-by: John

[libvirt] [PATCH] hyperv: Correct number of milliseconds in five minutes

--- src/hyperv/hyperv_wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 57125ae..33ad964 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src/hyperv/hyperv_wmi.c @@ -42,7 +42,7 @@ #define VIR_FROM_THIS VIR_FROM_HYPERV

[libvirt] [PATCH] hyperv: Reduce usage of libxml API functions

Slight refactor of the WMI serialization code to minimize mixing openwsman and libxml2 APIs. The only usage of libxml2 APIs now is in creating CDATA blocks, because the openwsman API does not provide that functionality. --- src/hyperv/hyperv_wmi.c | 65

Re: [libvirt] [PATCH 0/7] Misc improvements

On Fri, Jul 28, 2017 at 11:47:56AM -0400, John Ferlan wrote: > > > On 07/28/2017 11:24 AM, Daniel P. Berrange wrote: > > On Fri, Jul 28, 2017 at 11:09:03AM -0400, John Ferlan wrote: > >> > >> > >> On 07/28/2017 10:32 AM, Martin Kletzander wrote: > >>> On Thu, Jul 27, 2017 at 01:47:20PM +0200,

Re: [libvirt] [PATCH 0/7] Misc improvements

On 07/28/2017 11:24 AM, Daniel P. Berrange wrote: > On Fri, Jul 28, 2017 at 11:09:03AM -0400, John Ferlan wrote: >> >> >> On 07/28/2017 10:32 AM, Martin Kletzander wrote: >>> On Thu, Jul 27, 2017 at 01:47:20PM +0200, Michal Privoznik wrote: As I started to turn more object into using RW

Re: [libvirt] [PATCH 0/7] Misc improvements

On Fri, Jul 28, 2017 at 11:09:03AM -0400, John Ferlan wrote: > > > On 07/28/2017 10:32 AM, Martin Kletzander wrote: > > On Thu, Jul 27, 2017 at 01:47:20PM +0200, Michal Privoznik wrote: > >> As I started to turn more object into using RW locks, I've found > >> couple of > >> areas for

Re: [libvirt] [PATCH] qemu: Split shmem preparation as it's supposed to be

On Mon, Jul 24, 2017 at 03:54:19PM +0200, Martin Kletzander wrote: Since the introduction of shmem, there was a split of preparation code from the formatting code from qemuBuildCommandLine() into qemuProcessPrepareDomain(). Let's fix shmem in this regard, so that we can slowly get to a cleaner

Re: [libvirt] [PATCH 0/7] Misc improvements

On 07/28/2017 10:32 AM, Martin Kletzander wrote: > On Thu, Jul 27, 2017 at 01:47:20PM +0200, Michal Privoznik wrote: >> As I started to turn more object into using RW locks, I've found >> couple of >> areas for improvement too. >> >> Michal Privoznik (7): >> virConnect: Update comment for

Re: [libvirt] [PATCH v3 00/16] virObject adjustments for common object

On Fri, Jul 28, 2017 at 09:44:59AM -0400, John Ferlan wrote: > > > On 07/28/2017 04:51 AM, Pavel Hrdina wrote: > > On Thu, Jul 27, 2017 at 04:46:41PM -0400, John Ferlan wrote: > >> > >> > >> On 07/25/2017 05:29 AM, Pavel Hrdina wrote: > >>> On Thu, Jun 22, 2017 at 10:02:30AM -0400, John Ferlan

Re: [libvirt] [PATCH v2 0/2] Add test case for node name detection

On Fri, Jul 28, 2017 at 12:43:43PM +0200, Peter Krempa wrote: Patch 2/2 was originallly included in the node name detection refactor. v2 does not contain an ugly hack to make virTestCompareToFile, but rather fixes the function to treat NULL as an empty string. Peter Krempa (2): tests: utils:

Re: [libvirt] [PATCH 0/2] tests: fix build without WITH_LIBVIRTD defined

On Fri, Jul 28, 2017 at 12:18:10PM +0200, Peter Krempa wrote: 'virdrivermoduletest' failure was caught by the centos ci. virt-aa-helper-test while testing it on my machine with specifically disabled libvirtd. Peter Krempa (2): tests: Run virt-aa-helper-test only when the helper was compiled

[libvirt] [PATCH v3 2/3] qemu: Implement virDomainMigrateGetMaxDowntime

From: Scott Garfinkle --- src/qemu/qemu_driver.c | 51 src/qemu/qemu_monitor.h | 3 +++ src/qemu/qemu_monitor_json.c | 4 src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 16 +-

[libvirt] [PATCH v3 3/3] virsh: Add support for virDomainMigrateGetMaxDowntime

From: Scott Garfinkle --- tools/virsh-domain.c | 46 ++ tools/virsh.pod | 18 ++ 2 files changed, 64 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 0684979..10fdd0f 100644 ---

[libvirt] [PATCH v3 0/3] implement migrate-getmaxdowntime command

Currently, the maximum tolerable downtime for a domain being migrated is write-only. This patch implements a way to query that value nondestructively. Changes from [v2]: * Resequenced and renamed patches * Use updated qemuMonitorJSONGetMigrationParams for querying migration parameters. [v1}

[libvirt] [PATCH v3 1/3] Add virDomainMigrateGetMaxDowntime public API

From: Scott Garfinkle --- include/libvirt/libvirt-domain.h | 4 src/driver-hypervisor.h | 6 ++ src/libvirt-domain.c | 45 src/libvirt_public.syms | 4 4 files changed, 59 insertions(+)

Re: [libvirt] [PATCH 0/7] Misc improvements

On Thu, Jul 27, 2017 at 01:47:20PM +0200, Michal Privoznik wrote: As I started to turn more object into using RW locks, I've found couple of areas for improvement too. Michal Privoznik (7): virConnect: Update comment for @privateData Report error if virMutexInit fails virnetworkobj: Make

Re: [libvirt] [PATCH 6/7] virConnect: Derive from virObjectRWLockable

On Thu, Jul 27, 2017 at 01:47:26PM +0200, Michal Privoznik wrote: There is no reason why two threads trying to copy error from connection should mutually exclude each other. Utilize new virObjectRWLockable that was just introduced. ACK, although I see it mostly as an example patch on how to

Re: [libvirt] [PATCH 2/7] Report error if virMutexInit fails

On Thu, Jul 27, 2017 at 01:47:22PM +0200, Michal Privoznik wrote: The virMutexInit() function is not reporting any error on failure rather than returning -1 and setting errno. It's up to the caller to report the error. I would rather see virMutexInit() report the error since it looks like

[libvirt] [PATCH] news: Update for 3.6.0 release

I was volunteered to prepare the release notes. Signed-off-by: Michal Privoznik --- Feel free to propose your stuff too if I forgot to add it. docs/news.xml | 69 +++ 1 file changed, 69 insertions(+) diff --git

Re: [libvirt] [PATCH] docs: Format comment timestamp in UTC

On Fri, Jul 28, 2017 at 10:46:35AM +0200, Martin Kletzander wrote: I just forgot '-u' in a54c9622860a. Signed-off-by: Martin Kletzander --- docs/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ACK Jan signature.asc Description: Digital signature

Re: [libvirt] [PATCH 1/7] virConnect: Update comment for @privateData

On Thu, Jul 27, 2017 at 01:47:21PM +0200, Michal Privoznik wrote: This member allows us to store a pointer to some private data. However, the comment says it's used in both domain driver and network driver. Well, it is not. It's just one pointer and domain driver uses it directly. Network driver

Re: [libvirt] [PATCH v3 00/16] virObject adjustments for common object

On 07/28/2017 04:51 AM, Pavel Hrdina wrote: > On Thu, Jul 27, 2017 at 04:46:41PM -0400, John Ferlan wrote: >> >> >> On 07/25/2017 05:29 AM, Pavel Hrdina wrote: >>> On Thu, Jun 22, 2017 at 10:02:30AM -0400, John Ferlan wrote: >>> >>> Let's move the discussion [1] into correct place. >>>

Re: [libvirt] [PATCH 2/2] conf: Introduce the virDomainNetModel enumeration

On Thu, Jul 27, 2017 at 15:08:11 +0200, Andrea Bolognani wrote: > On Thu, 2017-07-27 at 14:36 +0200, Peter Krempa wrote: > > > Would you still be against it if the enumeration was extended > > > to include every NIC model ever supported by QEMU and Xen? As > > > mentioned, other drivers already

[libvirt] [PATCH v2 2/2] tests: qemumonitorjson: Old and empty test case for node name detection

Prior to qemu 2.5 the node names would not be generated, thus would be missing from 'query-blockstats' and 'query-named-block-nodes'. Test that the code correctly detects nothing. Additionally make sure that a VM without disks does not cause problems. The test case change is necessary as our

[libvirt] [PATCH v2 1/2] tests: utils: Allow NULL strings to be equal to empty file in virTestCompareToFile

Treat an NULL string equivalent to an empty string in virTestCompareToFile so that callers don't need to add additional logic in case when a test produces no output. --- tests/testutils.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/testutils.c b/tests/testutils.c index

[libvirt] [PATCH v2 0/2] Add test case for node name detection

Patch 2/2 was originallly included in the node name detection refactor. v2 does not contain an ugly hack to make virTestCompareToFile, but rather fixes the function to treat NULL as an empty string. Peter Krempa (2): tests: utils: Allow NULL strings to be equal to empty file in

[libvirt] [PATCH 2/2] tests: Run virdrivermoduletest only when WITH_LIBVIRTD is defined

The test makes sense only when building the daemon, thus run it only in such case. --- tests/Makefile.am | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 6da3e4778..3e3d58071 100644 --- a/tests/Makefile.am +++

[libvirt] [PATCH 0/2] tests: fix build without WITH_LIBVIRTD defined

'virdrivermoduletest' failure was caught by the centos ci. virt-aa-helper-test while testing it on my machine with specifically disabled libvirtd. Peter Krempa (2): tests: Run virt-aa-helper-test only when the helper was compiled tests: Run virdrivermoduletest only when WITH_LIBVIRTD is

[libvirt] [PATCH 1/2] tests: Run virt-aa-helper-test only when the helper was compiled

'virt-aa-helper' is compiled when both WITH_LIBVIRTD and WITH_SECDRIVER_APPARMOR are defined. The test was run only when WITH_SECDRIVER_APPARMOR was defined thus causing a build failure when building without the daemon. --- tests/Makefile.am | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [libvirt] [PATCH v2 0/5] Workaround mdev uevent race affecting node device driver

On Fri, Jul 28, 2017 at 09:43:57AM +0200, Erik Skultety wrote: > v1 here https://www.redhat.com/archives/libvir-list/2017-June/msg00826.html > > This series addresses [1]. It builds on top of [2], series which introduces > a few small fixes and improvements. Even though that one hasn't gotten a >

Re: [libvirt] [PATCH] nodedev: Fix double unlock of the driver on udevEnumerateDevices failure

On Fri, Jul 28, 2017 at 11:31:27AM +0200, Michal Privoznik wrote: > On 07/26/2017 10:45 AM, Erik Skultety wrote: > > Commit @4cb719b2dc moved the driver locks around since these have become > > unnecessary at spots where the code handles now self-lockable object > > list, but missed the possible

Re: [libvirt] [PATCH] nodedev: Fix double unlock of the driver on udevEnumerateDevices failure

On 07/26/2017 10:45 AM, Erik Skultety wrote: > Commit @4cb719b2dc moved the driver locks around since these have become > unnecessary at spots where the code handles now self-lockable object > list, but missed the possible double unlock if udevEnumerateDevices > fails, because at that point the

[libvirt] [PATCH] hostdev: display leading zeros of USB vendor/product id's in error messages

From: Chen Hanxiao Many vendor id's and product id's have leading zeros. Show them in error messages. Signed-off-by: Chen Hanxiao --- src/util/virhostdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [libvirt] Exposing mem-path in domain XML

On Fri, Jul 28, 2017 at 10:45:21AM +0200, Michal Privoznik wrote: > On 07/27/2017 03:50 PM, Daniel P. Berrange wrote: > > On Thu, Jul 27, 2017 at 02:11:25PM +0200, Michal Privoznik wrote: > >> Dear list, > >> > >> there is the following bug [1] which I'm not quite sure how to grasp. So > >> there

Re: [libvirt] [PATCH v3 00/16] virObject adjustments for common object

On Thu, Jul 27, 2017 at 04:46:41PM -0400, John Ferlan wrote: > > > On 07/25/2017 05:29 AM, Pavel Hrdina wrote: > > On Thu, Jun 22, 2017 at 10:02:30AM -0400, John Ferlan wrote: > > > > Let's move the discussion [1] into correct place. > > > >> Still, I must be missing something. Why is it wrong

Re: [libvirt] [PATCH] tools: virsh: Adding unix socket support to 'domdisplay' command.

On 07/27/2017 04:51 PM, Julio Faracco wrote: > Thanks for the update, Michal. > > I did some other fixes related to spice too. > Libvirt is freezed right now. So, I will wait the next wave to send the V2. That's okay. Libvirt freezes take about a week. Moreover, patches can be reviewed

[libvirt] [PATCH] docs: Format comment timestamp in UTC

I just forgot '-u' in a54c9622860a. Signed-off-by: Martin Kletzander --- docs/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index a5bff7de1c9d..34f84e526daa 100644 --- a/docs/Makefile.am +++

Re: [libvirt] Exposing mem-path in domain XML

On 07/27/2017 03:50 PM, Daniel P. Berrange wrote: > On Thu, Jul 27, 2017 at 02:11:25PM +0200, Michal Privoznik wrote: >> Dear list, >> >> there is the following bug [1] which I'm not quite sure how to grasp. So >> there is this application/infrastructure called Kove [2] that allows you >> to have

Re: [libvirt] about support quorum and replication in xml

Re-asking the same question multiple times within a day will not get you a faster reply: https://www.redhat.com/archives/libvir-list/2017-July/msg01218.html https://www.redhat.com/archives/libvir-list/2017-July/msg01220.html https://www.redhat.com/archives/libvir-list/2017-July/msg01267.html On

Re: [libvirt] [RFC]Add new mdev interface for QoS

On Thu, Jul 27, 2017 at 12:01:58PM -0600, Alex Williamson wrote: > On Thu, 27 Jul 2017 17:17:48 +0100 > "Daniel P. Berrange" wrote: > > > On Wed, Jul 26, 2017 at 10:43:43AM -0600, Alex Williamson wrote: > > > [cc +libvir-list] > > > > > > On Wed, 26 Jul 2017 21:16:59 +0800

[libvirt] [PATCH v2 5/5] nodedev: Work around the uevent race by hooking up virFileWaitForAccess

If we find ourselves in the situation that the 'add' uevent has been fired earlier than the sysfs tree for a device was created, we should use the best-effort approach and give kernel some predetermined amount of time, thus waiting for the attributes to be ready rather than discarding the device

[libvirt] [PATCH v2 4/5] util: Introduce virFileWaitForAccess

Since we have a number of places where we workaround timing issues with devices, attributes (files in general) not being available at the time of processing them by calling usleep in a loop for a fixed number of tries, we could as well have a utility function that would do that. Therefore we won't

[libvirt] [PATCH v2 2/5] udev: Split udevEventHandleCallback in two functions

This patch splits udevEventHandleCallback in two (introduces udevEventHandleThread) in order to be later able to refactor the latter to actually become a detached thread which will wait some time for the kernel to create the whole sysfs tree for a device as we cannot do that in the event loop

[libvirt] [PATCH v2 1/5] nodedev: Introduce udevCheckMonitorFD helper function

We need to perform some sanity checks on the udev monitor before every use so that we know nothing changed in the meantime. The reason for moving the code to a separate function is to be able to perform the same check from a worker thread that will replace the udevEventHandleCallback in terms of

[libvirt] [PATCH v2 3/5] udev: Convert udevEventHandleThread to an actual thread routine

Adjust udevEventHandleThread to be a proper thread routine running in an infinite loop handling devices. Also introduce udevEventThreadData private structure. Every time there's and incoming event from udev, udevEventHandleCallback only increments the number of events queuing on the monitor and

[libvirt] [PATCH v2 0/5] Workaround mdev uevent race affecting node device driver

v1 here https://www.redhat.com/archives/libvir-list/2017-June/msg00826.html This series addresses [1]. It builds on top of [2], series which introduces a few small fixes and improvements. Even though that one hasn't gotten a review yet, you can fetch and build this from my github branch [3].

[libvirt] about support quorum and replication in xml

hi we wiill use quorum and replication in qemu. but we found that libvirt does not support quorum and replication in xml. so we want submit some patches for supporting quorum and replication in xml how about it??.-- libvir-list mailing list libvir-list@redhat.com