[libvirt] [PATCH 3/3] util: match phys_port_id when converting PF-netdev to/from VF-netdev

This patch updates functions in netdev.c to pay attention to phys_port_id. It uses the new function virNetDevGetPhysPortID() to learn the phys_port_id of a VF or PF, then sends that info to virPCIGetNetName(), which has newly been modified to take an optional phys_port_id. ---

[libvirt] [PATCH 1/3] util: new function virNetDevGetPhysPortID()

On Linux each network device *can* (but not necessarily *does*) have an attribute called phys_port_id which can be read from the file of that name in the netdev's sysfs directory. The examples I've seen have been a many-digit hexadecimal number (as an ASCII string). This value can be useful when

[libvirt] [PATCH 0/3] Properly deal with multiple netdevs per PCI device when converting VF <-> PF

The commit log of Patch 1 explains the majority of the reason for these patches. In short, they disambiguate the multiple netdevs per PCI device on the SRIOV PF and VFs of a Mellanox dual port NIC *when converting from a VF netdev to a PF netdev and vice versa*. This permits us to set the vlan tag

[libvirt] [PATCH 2/3] util: support matching a phys_port_id in virPCIGetNetName()

A single PCI device may have multiple netdevs associated with it. Each of those netdevs will have a different phys_port_id entry in sysfs. This patch modifies virPCIGetNetName() to allow matching the netdev for a PCI device that has the same phys_port_id that the caller wants. ---

Re: [libvirt] [libvirt-php PATCH v2 01/11] Move PHP version compat macros to utils.h

On Thu, 2017-08-03 at 14:34 -0400, Dawid Zamirski wrote: > Also util now includes all the PHP headers. > --- > src/libvirt-php.c | 1 - > src/libvirt-php.h | 157 +--- > > src/util.h| 174 >

Re: [libvirt] [PATCH v4 1/8] docs: schema: Add basic documentation for the virtual

On 07/07/2017 04:07 AM, Longpeng(Mike) wrote: > This patch documents XML elements used for support of virtual > crypto devices. > > In the devices section in the domain XML users may specify: > > Add an example too. > > to enable the crypto device for guests. > > Signed-off-by:

Re: [libvirt] [RFC]Add new mdev interface for QoS

On Thu, 3 Aug 2017 20:26:14 +0800 "Gao, Ping A" wrote: > On 2017/8/3 0:58, Alex Williamson wrote: > > On Wed, 2 Aug 2017 21:16:28 +0530 > > Kirti Wankhede wrote: > > > >> On 8/2/2017 6:29 PM, Gao, Ping A wrote: > >>> On 2017/8/2 18:19, Kirti

[libvirt] [libvirt-php PATCH v2 08/11] Split up the bindings for libvirt snapshot API

--- src/Makefile.am| 1 + src/libvirt-php.c | 257 + src/libvirt-php.h | 18 +--- src/libvirt-snapshot.c | 244 ++ src/libvirt-snapshot.h | 58 +++ 5 files changed, 306

[libvirt] [libvirt-php PATCH v2 10/11] Split up the bindings for libvirt NWFilter API

--- src/Makefile.am| 3 +- src/libvirt-nwfilter.c | 415 + src/libvirt-nwfilter.h | 66 src/libvirt-php.c | 445 + src/libvirt-php.h | 28 5 files changed, 487

[libvirt] [libvirt-php PATCH v2 03/11] Split up the bindings for libvirt node API

--- src/Makefile.am | 3 +- src/libvirt-connection.c | 1 + src/libvirt-connection.h | 2 - src/libvirt-node.c | 305 src/libvirt-node.h | 23 src/libvirt-php.c| 322

[libvirt] [libvirt-php PATCH v2 07/11] Split up the bindings for libvirt storage API

--- src/Makefile.am |3 +- src/libvirt-php.c | 1188 + src/libvirt-php.h | 49 -- src/libvirt-storage.c | 1130 ++ src/libvirt-storage.h | 137 ++ 5 files changed, 1271

[libvirt] [libvirt-php PATCH v2 01/11] Move PHP version compat macros to utils.h

Also util now includes all the PHP headers. --- src/libvirt-php.c | 1 - src/libvirt-php.h | 157 +--- src/util.h| 174 ++ 3 files changed, 175 insertions(+), 157 deletions(-) diff --git

[libvirt] [libvirt-php PATCH v2 06/11] Split up the bindings for libvirt network API

--- src/Makefile.am | 3 +- src/libvirt-network.c | 587 src/libvirt-network.h | 73 ++ src/libvirt-php.c | 610 +- src/libvirt-php.h | 24 +- 5 files changed, 665 insertions(+),

[libvirt] [libvirt-php PATCH v2 04/11] Split up the bindings for libvirt stream API

--- src/Makefile.am | 3 +- src/libvirt-php.c| 231 +-- src/libvirt-php.h| 15 +--- src/libvirt-stream.c | 230 ++ src/libvirt-stream.h | 39 + 5 files changed, 274

[libvirt] [libvirt-php PATCH v2 09/11] Split up the bindings for libvirt nodedev API

--- src/Makefile.am | 3 +- src/libvirt-nodedev.c | 340 src/libvirt-nodedev.h | 54 src/libvirt-php.c | 353 +- src/libvirt-php.h | 13 -- 5 files changed, 399

[libvirt] [libvirt-php PATCH v2 11/11] Fix is_local_connection implementation.

As it was failing when local host is using FQDN for hostnames. The logic to do so follows libvirt's implementation for the same thing. This fixes an issue where unit tests would falsely fail on workstations that have FQDN hostnames. --- src/libvirt-php.c | 38

[libvirt] [libvirt-php PATCH v2 02/11] Split up the bindings for libvirt connection API

* add libvirt-connection.h and libvirt-connection.c * move all libvirt_connect_* function declarations and definitions to above files * other minor adjusments to libvirt-php.h and util.h to keep the code compilable while the code is being moved around. --- src/Makefile.am | 3 +-

[libvirt] [libvirt-php PATCH v2 00/11] Refactor into smaller components

As per [1], this patch series splits up the large libvirt-php.c into components that (attempts) to resemble the structure of the libvirt project. Each patch successive patch was compile-tested while the whole series was verified with "make check" and a simple custom written PHP script. Changes

Re: [libvirt] [PATCH RESEND] Interface: return appropriate status for bridge device

On 08/02/2017 05:09 PM, John Ferlan wrote: > [pardon the top-post comment] > Doing some (personal) mail box cleaning and found this "older" patch... > Sorry that this has sat unattended (and probably now forgotten or given > up on) for so long. Suppose it's an assumption that someone like Laine >

Re: [libvirt] [PATCH] qemu: Honour

Hello, Am 03.08.2017 um 09:36 schrieb Michal Privoznik: > https://bugzilla.redhat.com/show_bug.cgi?id=1476866 > > For some reason, we completely ignore setting for > domains. The implementation is simply not there. It never was. > However, things are slightly more complicated. QEMU sends us two

Re: [libvirt] [libvirt-php PATCH 04/13] Split up the bindings for libvirt connection API

On Thu, 2017-08-03 at 17:02 +0200, Michal Privoznik wrote: > On 08/03/2017 04:58 PM, Dawid Zamirski wrote: > > > > On Thu, 2017-08-03 at 14:27 +0200, Michal Privoznik wrote: > > > On 08/01/2017 11:46 PM, Dawid Zamirski wrote: > > > > * add libvirt-connection.h and libvirt-connection.c > > > > *

[libvirt] [PATCH v2] tests: add qemu x86 kvm 32-on-64 test

There's some specific logic in qemuBuildCpuCommandLine to support auto adding -cpu qemu 32 for arch=i686 with an x86_64 qemu binary. Add a test case for it Signed-off-by: Cole Robinson --- v2: Drop unnecessary qemu-kvm path usage .../qemuxml2argv-x86-kvm-32-on-64.args

Re: [libvirt] [PATCH 1/3] tests: add qemu x86 kvm 32-on-64 test

On 07/21/2017 07:40 AM, Pavel Hrdina wrote: > On Fri, Jul 14, 2017 at 07:43:04PM -0400, Cole Robinson wrote: >> There's some specific logic in qemuBuildCpuCommandLine to support >> auto adding -cpu qemu 32 for arch=i686 with an x86_64 qemu-kvm binary. >> Add a test case for it >> >> Signed-off-by:

Re: [libvirt] [PATCH v2 0/8] Some virObjectRW* adjustments

On 08/03/2017 11:34 AM, Michal Privoznik wrote: > On 08/01/2017 02:05 AM, John Ferlan wrote: >> v1: https://www.redhat.com/archives/libvir-list/2017-July/msg01313.html >> >> Differences from v1: >> >> * Use the names virObjectRWLockRead, virObjectRWLockWrite and >>virObjectRWUnlock >> >> *

Re: [libvirt] [PATCH 3/3] qemu: command: explicitly error for non-x86 default CPU

On 07/21/2017 10:25 AM, Ján Tomko wrote: > On Fri, Jul 14, 2017 at 07:43:06PM -0400, Cole Robinson wrote: >> The code only currently handles writing an x86 default -cpu >> argument, and doesn't know anything about other architectures. >> Let's make this explicit rather than leaving ex. qemu ppc64

Re: [libvirt] [PATCH v2 3/8] util: Only have virObjectLock handle virObjectLockable

On 08/01/2017 02:05 AM, John Ferlan wrote: > Now that virObjectRWLockWrite exists to handle the virObjectRWLockable > objects, let's restore virObjectLock to only handle virObjectLockable > class locks. There still exists the possibility that the input @anyobj > isn't a valid object and the

Re: [libvirt] [PATCH v2 0/8] Some virObjectRW* adjustments

On 08/01/2017 02:05 AM, John Ferlan wrote: > v1: https://www.redhat.com/archives/libvir-list/2017-July/msg01313.html > > Differences from v1: > > * Use the names virObjectRWLockRead, virObjectRWLockWrite and >virObjectRWUnlock > > * Instead of an 'int' return, make the

Re: [libvirt] [PATCH v3 1/2] qemu: Restrict usage of hpet and kvm.pit timers by unsupported architectures

On 07/25/2017 10:36 AM, Kothapally Madhu Pavan wrote: > hpet and kvm.pit clock timers are specific to x86 architecture and > are not suppose to be used in other architectures. This patch restricts > the usage of hpet and kvm.pit timers in unsupported architectures. > > Signed-off-by: Kothapally

Re: [libvirt] [PATCH 0/2] Fix smartcard formatting regression

On 08/03/2017 08:55 AM, Ján Tomko wrote: > *** BLURB HERE *** > > Ján Tomko (2): > tests: add smartcard test cases to qemuxml2xmltest > conf: fix formatting of smartcard devices > > src/conf/domain_conf.c | 43 > ++ >

Re: [libvirt] [libvirt-php PATCH 04/13] Split up the bindings for libvirt connection API

On 08/03/2017 04:58 PM, Dawid Zamirski wrote: > > On Thu, 2017-08-03 at 14:27 +0200, Michal Privoznik wrote: >> On 08/01/2017 11:46 PM, Dawid Zamirski wrote: >>> * add libvirt-connection.h and libvirt-connection.c >>> * move all libvirt_connect_* function declarations and definitions >>> to >>>

Re: [libvirt] [libvirt-php PATCH 04/13] Split up the bindings for libvirt connection API

On Thu, 2017-08-03 at 14:27 +0200, Michal Privoznik wrote: > On 08/01/2017 11:46 PM, Dawid Zamirski wrote: > > * add libvirt-connection.h and libvirt-connection.c > > * move all libvirt_connect_* function declarations and definitions > > to > > above files > > * other minor adjusments to

Re: [libvirt] [PATCH v3] libxl: Add a test suite for libxl_domain_config generator

On Tue, Aug 01, 2017 at 03:17:51PM +0200, Marek Marczykowski-Górecki wrote: > From: Jim Fehlig > > The libxl library allows a libxl_domain_config object to be serialized > from/to a JSON string. Use this to allow testing of the XML to > libxl_domain_config conversion process.

Re: [libvirt] [PATCH v2 1/8] util: Rename virObjectLockRead to virObjectRWLockRead

On 08/01/2017 05:36 PM, John Ferlan wrote: > > > On 08/01/2017 09:24 AM, Michal Privoznik wrote: >> On 08/01/2017 02:05 AM, John Ferlan wrote: >>> Since the class it represents is based on virObjectRWLockableClass >>> and in order to make sure we diffentiate lest anyone somehow >> >> ^^ couple

Re: [libvirt] [PATCH 2/1] tests: Add xml2xml tests for smartcard processing

Thanks for volunteering to fix this after me, I did not expect that, here is my attempt: https://www.redhat.com/archives/libvir-list/2017-August/msg00134.html On Thu, Aug 03, 2017 at 07:30:43AM -0400, John Ferlan wrote: Merge into previous... With the explanation to add smartcard xml2xml A

[libvirt] [PATCH 0/2] Fix smartcard formatting regression

*** BLURB HERE *** Ján Tomko (2): tests: add smartcard test cases to qemuxml2xmltest conf: fix formatting of smartcard devices src/conf/domain_conf.c | 43 ++ .../qemuxml2xmlout-smartcard-controller.xml| 31

[libvirt] [PATCH 2/2] conf: fix formatting of smartcard devices

My commit 0c1d863 broke formatting of passthrough smartcard devices: resulted in invalid XML: type='spicevmc'> Split out chardev source formatting function into two - one formatting the attributes and other formatting the subelements. Reported-by: Cole Robinson

Re: [libvirt] [PATCH 3/8] Use a separate buffer for subelements

On 08/03/2017 08:57 AM, Ján Tomko wrote: > On Wed, Aug 02, 2017 at 01:12:15PM -0400, Cole Robinson wrote: >> On 07/26/2017 09:29 AM, Ján Tomko wrote: >>> Convert virDomainSmartcardDefFormat to use a separate buffer >>> for possible subelements, to avoid the need for duplicated >>> formatting logic

Re: [libvirt] [PATCH 3/8] Use a separate buffer for subelements

On Wed, Aug 02, 2017 at 01:12:15PM -0400, Cole Robinson wrote: On 07/26/2017 09:29 AM, Ján Tomko wrote: Convert virDomainSmartcardDefFormat to use a separate buffer for possible subelements, to avoid the need for duplicated formatting logic in virDomainDeviceInfoNeedsFormat. ---

[libvirt] [PATCH 1/2] tests: add smartcard test cases to qemuxml2xmltest

Generated from the tests files used by qemuxml2argvtest with the formatting function from before my commit 0c1d8632 broke smartcard XML formatting. --- .../qemuxml2xmlout-smartcard-controller.xml| 31 .../qemuxml2xmlout-smartcard-host-certificates.xml | 34

Re: [libvirt] [libvirt-php PATCH 02/13] Update AUTHORS file

On 08/01/2017 11:46 PM, Dawid Zamirski wrote: > Since the project is about to get a bunch of new header files, it's > much easier to maintain just the AUTHORS file. > --- > AUTHORS | 29 +++-- > src/libvirt-php.c | 10 -- > src/libvirt-php.h | 10

Re: [libvirt] [libvirt-php PATCH 04/13] Split up the bindings for libvirt connection API

On 08/01/2017 11:46 PM, Dawid Zamirski wrote: > * add libvirt-connection.h and libvirt-connection.c > * move all libvirt_connect_* function declarations and definitions to > above files > * other minor adjusments to libvirt-php.h and util.h to keep the code > compilable while the code is being

Re: [libvirt] [RFC]Add new mdev interface for QoS

On 2017/8/3 0:58, Alex Williamson wrote: > On Wed, 2 Aug 2017 21:16:28 +0530 > Kirti Wankhede wrote: > >> On 8/2/2017 6:29 PM, Gao, Ping A wrote: >>> On 2017/8/2 18:19, Kirti Wankhede wrote: On 8/2/2017 3:56 AM, Alex Williamson wrote: > On Tue, 1 Aug 2017

Re: [libvirt] [PATCH v2] vz: support disabled items in vz boot order

On 06/30/2017 02:34 AM, Nikolay Shirokovskiy wrote: > At the time the check was written virtuozzo did not use disabled items in boot > order configuration. Boot items were always enabled. Now they can be disabled > as well. Supporting such items is easy - they just should be ignored. > --- >

[libvirt] [PATCH 2/1] tests: Add xml2xml tests for smartcard processing

Merge into previous... With the explanation to add smartcard xml2xml tests. As shown below other tests already exists. This includes the aha moment where an extra > was being printed for smartcards using type= as a result of virDomainChrTypeFormat doing the printing. Needed to print the > for

Re: [libvirt] Repack git repo?

On Thu, Aug 03, 2017 at 11:33:29AM +0200, Michal Privoznik wrote: > On 08/03/2017 09:57 AM, Daniel P. Berrange wrote: > > On Thu, Aug 03, 2017 at 09:16:13AM +0200, Michal Privoznik wrote: > >> So I was checking out the repo the other day and it took ages. So it got > >> me thinking what might be

Re: [libvirt] Repack git repo?

On 08/03/2017 09:57 AM, Daniel P. Berrange wrote: > On Thu, Aug 03, 2017 at 09:16:13AM +0200, Michal Privoznik wrote: >> So I was checking out the repo the other day and it took ages. So it got >> me thinking what might be the problem. Looks like a part of it is that >> our pack is split among

Re: [libvirt] [PATCH] conf: Fix printing of 'type' and 'tty_compat' for Chr devices

On Wed, Aug 02, 2017 at 03:51:34PM -0400, John Ferlan wrote: > Commit id '0c1d8632' caused a regression in the virt-manager > test suite when formatting the type='spicevmc'/>. > > Adust the code to print the type in it's own new helper called > virDomainChrTypeFormat and have the

Re: [libvirt] Repack git repo?

On Thu, Aug 03, 2017 at 10:33:47AM +0200, Peter Krempa wrote: On Thu, Aug 03, 2017 at 09:16:13 +0200, Michal Privoznik wrote: So I was checking out the repo the other day and it took ages. So it got me thinking what might be the problem. Looks like a part of it is that our pack is split among

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

On Thu, Aug 03, 2017 at 10:28:59 +0200, Bjoern Walk wrote: > Peter Krempa [2017-08-03, 09:47AM +0200]: > > On Thu, Aug 03, 2017 at 07:24:35 +0200, Bjoern Walk wrote: > > > Peter Krempa [2017-08-02, 05:39PM +0200]: > > > > It turns out that our

Re: [libvirt] Repack git repo?

On Thu, Aug 03, 2017 at 09:16:13 +0200, Michal Privoznik wrote: > So I was checking out the repo the other day and it took ages. So it got > me thinking what might be the problem. Looks like a part of it is that > our pack is split among ~250 files. Therefore when somebody does 250 files should

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

Peter Krempa [2017-08-03, 09:47AM +0200]: > On Thu, Aug 03, 2017 at 07:24:35 +0200, Bjoern Walk wrote: > > Peter Krempa [2017-08-02, 05:39PM +0200]: > > > It turns out that our implementation of the hashing function is > > > endian-dependent and thus if

Re: [libvirt] [PATCH] docs: Add "PCI topology and hotplug" guidelines

On Wed, 2017-08-02 at 11:06 +0200, Marcin Juszkiewicz wrote: > Thanks a lot for that documentation. Glad you found it useful :) Hopefully I can get it merged soon. > At Linaro we use AArch64 servers to deploy VM machines (with OpenStack > Newton or just libvirt) and issues with PCI hotplug came

Re: [libvirt] Repack git repo?

On Thu, Aug 03, 2017 at 10:14:02 +0200, Martin Kletzander wrote: > On Thu, Aug 03, 2017 at 08:57:47AM +0100, Daniel P. Berrange wrote: > >On Thu, Aug 03, 2017 at 09:16:13AM +0200, Michal Privoznik wrote: > >> So I was checking out the repo the other day and it took ages. So it got > >> me thinking

Re: [libvirt] Repack git repo?

On Thu, Aug 03, 2017 at 08:57:47AM +0100, Daniel P. Berrange wrote: On Thu, Aug 03, 2017 at 09:16:13AM +0200, Michal Privoznik wrote: So I was checking out the repo the other day and it took ages. So it got me thinking what might be the problem. Looks like a part of it is that our pack is split

Re: [libvirt] Repack git repo?

On Thu, Aug 03, 2017 at 09:16:13AM +0200, Michal Privoznik wrote: > So I was checking out the repo the other day and it took ages. So it got > me thinking what might be the problem. Looks like a part of it is that > our pack is split among ~250 files. Therefore when somebody does > checkout git

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

On Thu, Aug 03, 2017 at 07:24:35 +0200, Bjoern Walk wrote: > Peter Krempa [2017-08-02, 05:39PM +0200]: > > It turns out that our implementation of the hashing function is > > endian-dependent and thus if used on various architectures the testsuite > > may have different

[libvirt] [PATCH] qemu: Honour

https://bugzilla.redhat.com/show_bug.cgi?id=1476866 For some reason, we completely ignore setting for domains. The implementation is simply not there. It never was. However, things are slightly more complicated. QEMU sends us two RESET events on domain reboot. Fortunately, the event contains

[libvirt] Repack git repo?

So I was checking out the repo the other day and it took ages. So it got me thinking what might be the problem. Looks like a part of it is that our pack is split among ~250 files. Therefore when somebody does checkout git needs to repack it into a single pack every time. And this may take ages on

Re: [libvirt] support for configuring all ports of a multiport SRIOV VF when assigning to guest

Another think I forgot is that driver should be configured with probe_vf [1] to work in a single port vf for ConnectX-3/PRO. For example if my driver configuration is as follows: options mlx4_core port_type_array=2,2 num_vfs=4,4,0 probe_vf=4,4,0 I will have 4 VF on port 1 and 4 VF on port 2, but

Re: [libvirt] support for configuring all ports of a multiport SRIOV VF when assigning to guest

Hi Laine, I have a few question before I can give my opinion. I the Mellanox Card Dual Port that support one PCI with 2 PF is ConnectX-3 and ConnectX-3 Pro. (maybe others cards I will check this) The ConnectX-4 Dual Port and above is implemented with 2 PCI devices per 2 PF. I can check with

Re: [libvirt] [PATCH python] include usable memory in virDomainMemoryStats

On Wed, Aug 02, 2017 at 01:59:02PM +0200, Michal Privoznik wrote: On 08/02/2017 01:17 PM, Martin Kletzander wrote: On Wed, Aug 02, 2017 at 12:52:32PM +0200, Michal Privoznik wrote: On 08/01/2017 03:23 PM, Tomáš Golembiovský wrote: Signed-off-by: Tomáš Golembiovský ---