On Sun, Aug 13, 2017 at 01:16:13PM -0400, John Ferlan wrote:
On 08/13/2017 11:44 AM, Laine Stump wrote:
John found these two problems with Coverity after I pushed my series
fixing MAC address saving/setting on Mellanox dual port NICs.
Laine Stump (2):
util: fix Coverity complaint (and actua
On Wed, 2017-08-09 at 10:36 +0100, Daniel P. Berrange wrote:
> Signed-off-by: Daniel P. Berrange
> ---
> src/Makefile.am| 2 +-
> src/keycodemapdb | 2 +-
> src/util/virkeycode.c | 5 ++---
> tests/virkeycodetest.c | 4 ++--
> 4 files changed, 6 insertions(+), 7 deletions(-)
Revie
Hi,
On Sun, Aug 13, 2017 at 07:36:40PM -0400, Laine Stump wrote:
> On 08/11/2017 04:05 PM, Guido Günther wrote:
> > ---
> > src/vbox/vbox_tmpl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
> > index 07f25ba24f..dffeabde
On 08/11/2017 04:05 PM, Guido Günther wrote:
> ---
> src/vbox/vbox_tmpl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
> index 07f25ba24f..dffeabde02 100644
> --- a/src/vbox/vbox_tmpl.c
> +++ b/src/vbox/vbox_tmpl.c
> @@ -1836,
On 08/13/2017 11:44 AM, Laine Stump wrote:
> John found these two problems with Coverity after I pushed my series
> fixing MAC address saving/setting on Mellanox dual port NICs.
>
> Laine Stump (2):
> util: fix Coverity complaint (and actual bug) in
> virHostdevReadNetConfig()
> util: fi
Commit 81fb440b further qualified an if statement by adding the
boolean saveVlan to the condition, eliminating the need to check
saveVlan in an argument to virAsprintf().
---
src/util/virnetdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/util/virnetdev.c b/src/util
Commit 9a94af6d restructured virHostdevReadNetConfig() so that it
would manually set ret = 0 after successfully reading the device's
config, but the "ret = 0" was erroneously placed outside of an "else"
clause, meaning that the the value of ret set in the "if" clause was
unnecessarily and incorrect
John found these two problems with Coverity after I pushed my series
fixing MAC address saving/setting on Mellanox dual port NICs.
Laine Stump (2):
util: fix Coverity complaint (and actual bug) in
virHostdevReadNetConfig()
util: fix Coverity complaint in virNetDevSetNetConfig()
src/util/