Re: [libvirt] [discuss] add reconnect support for vhost-user

2017-08-27 Thread Michal Privoznik
On 08/22/2017 03:54 AM, lu.zhip...@zte.com.cn wrote: > Hello everyone: > > I want to implement a function, it is unclear whether anyone has submitted > such a patch. > > add reconnect support for vhost-user when unix control socket between > vhost-user and vhost-user backend is

Re: [libvirt] Why not support additional machine args in XML such as max-ram-below-4g?

2017-08-27 Thread Michal Privoznik
On 08/21/2017 01:04 PM, Wuzongyong (Euler Dept) wrote: > Since qemu support the arg -machine like that: > -machine [type=]name[,prop[=value][,...]] > So I'm inquisitive about why libvirt doesn't support specify the prop in xml ? Usually libvirt features are request driven. In other words you seem

[libvirt] [PATCH go-xml] Add support for domain hostdev and test code

2017-08-27 Thread ZhenweiPi
Signed-off-by: zhenwei.pi --- domain.go | 36 domain_test.go | 36 2 files changed, 72 insertions(+) diff --git a/domain.go b/domain.go index a5d3203..2c63307 100644 --- a/domain.go

[libvirt] [PATCH] spec: Own %{_libdir}/libvirt{, /connection-driver} dirs, mark licenses as %license

2017-08-27 Thread Cole Robinson
From: Ville Skyttä https://bugzilla.redhat.com/show_bug.cgi?id=1483293 Signed-off-by: Cole Robinson --- libvirt.spec.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 2b58bf3a9..2d21e60bc

[libvirt] [PATCH v2 2/2] security: dac: relabel spice rendernode

2017-08-27 Thread Cole Robinson
For a logged in user this a path like /dev/dri/renderD128 will have default ownership root:video which won't work for the qemu:qemu user, so we need to chown it. We only do this when mount namespaces are enabled in the qemu driver, so the chown'ing doesn't interfere with other users of the shared

[libvirt] [PATCH v2 0/2] dac: relabel spice rendernode

2017-08-27 Thread Cole Robinson
This fixes the last issue preventing qemu:///system spice GL from working out of the box: chown'ing the rendernode path so we have permissions to open it. We skip this if mount namespaces are disabled, so the chown'ing won't interfere with other rendernode users on the host.

[libvirt] [PATCH v2 1/2] security: add MANAGER_MOUNT_NAMESPACE flag

2017-08-27 Thread Cole Robinson
The VIR_SECURITY_MANAGER_MOUNT_NAMESPACE flag informs the DAC driver if mount namespaces are in use for the VM. Will be used for future changes. Wire it up in the qemu driver Signed-off-by: Cole Robinson --- src/qemu/qemu_driver.c | 2 ++

Re: [libvirt] [PATCH] qemu: undefine is not allowed during domainstarting up

2017-08-27 Thread wang.yi59
>On 07/22/2017 04:55 AM, Yi Wang wrote: >> Start a domain whilst undefine it, if starting failed duing ProcessLaunch, >> on which period qemu exited unexpectedly, the operation will lead to failure >> of undefine the domain until libvirtd restarted. The reason is that libvirtd >> will unlock

[libvirt] [PATCH v2 4/5] qemu: Set default video type in qemu PostParse

2017-08-27 Thread Cole Robinson
And not generic domain_conf code. We will need qemu private functions in a bit. Signed-off-by: Cole Robinson --- src/conf/domain_conf.c | 3 --- src/qemu/qemu_domain.c | 7 +++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH v2 2/5] conf: domain: add VIDEO_TYPE_DEFAULT

2017-08-27 Thread Cole Robinson
Will be needed for future patches to pull the default video type setting out of XML parsing routines. Signed-off-by: Cole Robinson --- src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 3 +++

[libvirt] [PATCH v2 5/5] qemu: Default to video type=virtio for machvirt

2017-08-27 Thread Cole Robinson
arm/aarch64 -M virt on KVM doesn't and will never work with standard VGA card emulation. The recommended method is to use type=virtio, so let's make it the default for video devices without an explicit type set by the user https://bugzilla.redhat.com/show_bug.cgi?id=1404112 Signed-off-by: Cole

[libvirt] [PATCH v2 0/5] qemu: Default to video type=virtio for machvirt

2017-08-27 Thread Cole Robinson
This series aim is to change the qemu machvirt video type default to virtio, but rather than continue to hack things into place in domain_conf.c, this rearranges things to allow drivers to set a video type default. Patches 1 is a small prep change in the qemu code Patches 2-4 are the plumbing to

[libvirt] [PATCH v2 3/5] conf: domain: move video type validation to DeviceDefValidate

2017-08-27 Thread Cole Robinson
This allows drivers to set their own default. But if a driver neglects to fill one in, we still error like we previously would at parse time. Signed-off-by: Cole Robinson --- src/conf/domain_conf.c | 28 1 file changed, 16 insertions(+), 12

[libvirt] [PATCH v2 1/5] qemu: whitelist valid video types

2017-08-27 Thread Cole Robinson
Rather than require an explicit blacklist that needs to be extended for every new VIDEO_TYPE Signed-off-by: Cole Robinson --- src/qemu/qemu_domain.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_domain.c

Re: [libvirt] [PATCH 3/8] qemu: annotate some VIDEO_TYPE enum switch

2017-08-27 Thread Cole Robinson
On 07/18/2017 06:24 PM, John Ferlan wrote: > > > On 06/28/2017 02:49 PM, Cole Robinson wrote: >> For the ram/vram monitor wrappers, just add a default: clause... >> seems like it should be rarely extended so this saves every committer >> from needing to update >> >> For the validation switch,

Re: [libvirt] [PATCH 1/8] qemu: parse: drop redundant video config

2017-08-27 Thread Cole Robinson
On 07/18/2017 06:20 PM, John Ferlan wrote: > > > On 06/28/2017 02:49 PM, Cole Robinson wrote: >> The ram/vram = 0 bits aren't needed, and PostParse will fill in the >> needed QXL default >> >> Signed-off-by: Cole Robinson >> --- >> src/qemu/qemu_command.c | 4