Re: [libvirt] Yet another RFC for CAT

2017-09-06 Thread Eli Qiao
2017-09-04 23:57 GMT+08:00 Daniel P. Berrange : > On Mon, Sep 04, 2017 at 04:14:00PM +0200, Martin Kletzander wrote: > > * The current design (finally something libvirt-related, right?) > > > > The discussion ended with a conclusion of the following (with my best > >

Re: [libvirt] [PATCH 2/2] qemu: Order PCI controllers on the command line

2017-09-06 Thread Laine Stump
On 09/05/2017 09:25 AM, Andrea Bolognani wrote: > Unlike other controllers, PCI controller can plug into each other, s/PCI controller/PCI controllers/ > which might turn into a problem if they are not listed in the > expected order on the QEMU command line, because the guest will > then not be

[libvirt] [PATCH] storage: Check and possibly update config file after build

2017-09-06 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1464313 As it turns out, the on-disk config file (e.g. not the stateDir file) needs to be updated when --override is provided since it's possible and highly probable that the def->source.format has been adjusted and could cause a future start after

Re: [libvirt] [PATCH] qemu: Be more selective when determining cdrom for taint messaging

2017-09-06 Thread John Ferlan
On 09/06/2017 08:17 AM, Michal Privoznik wrote: > On 09/05/2017 10:51 PM, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1471225 >> >> Commit id '99a2d6af2' was a bit too aggressive with determining whether >> the provided path was a "physical" cd-rom in order to generate a

[libvirt] [PATCH] qemu: Provide default LUN=0 for iSCSI if not provided

2017-09-06 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1477880 If the "/#" is missing from the provided iSCSI path, then we need to provide the default LUN of /0; otherwise, QEMU will fail to parse the URL causing a failure to either create the guest or hotplug attach the storage. Alter the command lines

Re: [libvirt] [PATCH 1/2] qemu: Clean up qemuBuildControllerDevCommandLine()

2017-09-06 Thread Laine Stump
On 09/05/2017 09:25 AM, Andrea Bolognani wrote: > Add a cleanup: label, which will be used later, and improve > the readability of one of the checks by making it conform to > our formatting standard and moving a comment. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by:

Re: [libvirt] [PATCH 2/2] travis: Install gettext

2017-09-06 Thread Daniel P. Berrange
On Wed, Sep 06, 2017 at 03:13:30PM +0200, Andrea Bolognani wrote: > msgmerge(1) and friends are required to build libvirt, so the > corresponding package should be installed in the Travis worker. It is only used if you regenerate .po files. 99% of the time developers or apps bulding libvirt won't

[libvirt] [PATCH 2/2] travis: Install gettext

2017-09-06 Thread Andrea Bolognani
msgmerge(1) and friends are required to build libvirt, so the corresponding package should be installed in the Travis worker. Signed-off-by: Andrea Bolognani --- I'm honestly baffled it ever worked at all. Pushed as a CI build fix. .travis.yml | 1 + 1 file changed, 1

[libvirt] [PATCH 0/2] travis: Fix build issues

2017-09-06 Thread Andrea Bolognani
I can't believe there is no blurb here! Andrea Bolognani (2): travis: Sort build dependencies travis: Install gettext .travis.yml | 49 + 1 file changed, 25 insertions(+), 24 deletions(-) -- 2.13.5 -- libvir-list mailing list

[libvirt] [PATCH 1/2] travis: Sort build dependencies

2017-09-06 Thread Andrea Bolognani
Keeping the list of build dependencies sorted alphabetically makes it way easier to visually scan it for issues. Signed-off-by: Andrea Bolognani --- Pushed as a CI build fix. .travis.yml | 48 1 file changed, 24

Re: [libvirt] libvirt domain memory statistics

2017-09-06 Thread Marko Myllynen
Hi, On 2017-09-06 14:42, Michal Privoznik wrote: > On 09/06/2017 01:09 PM, Marko Myllynen wrote: > > Sure. It should be fairly simple. Mind opening a bug for that so that we > can track the RFE? Also, if you're willing to provide patches please be > my guest. Otherwise we will assign the work

Re: [libvirt] [PATCH] qemu: Be more selective when determining cdrom for taint messaging

2017-09-06 Thread Michal Privoznik
On 09/05/2017 10:51 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1471225 > > Commit id '99a2d6af2' was a bit too aggressive with determining whether > the provided path was a "physical" cd-rom in order to generate a taint > message due to the possibility of some guest and

Re: [libvirt] [PATCH] cpu: Add new EPYC CPU model

2017-09-06 Thread Jiri Denemark
On Wed, Aug 23, 2017 at 13:49:41 -0500, Brijesh Singh wrote: > Add a new CPU model called 'EPYC' to model processors from AMD EPYC > family (which includes EPYC 76xx,75xx,74xx, 73xx and 72xx). > > The following features bits have been added/removed compare to Opteron_G5 > > Added: monitor,

[libvirt] [PATCH 2/2] cpu: Add new EPYC CPU model

2017-09-06 Thread Jiri Denemark
From: Brijesh Singh Add a new CPU model called 'EPYC' to model processors from AMD EPYC family (which includes EPYC 76xx,75xx,74xx, 73xx and 72xx). The following features bits have been added/removed compare to Opteron_G5 Added: monitor, movbe, rdrand, mmxext, ffxsr,

[libvirt] [PATCH 1/2] tests: Add CPUID data for AMD Ryzen 7 1800X Eight-Core Processor

2017-09-06 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- tests/cputest.c| 1 + ..._64-cpuid-Ryzen-7-1800X-Eight-Core-disabled.xml | 9 + ...6_64-cpuid-Ryzen-7-1800X-Eight-Core-enabled.xml | 10 + ...x86_64-cpuid-Ryzen-7-1800X-Eight-Core-guest.xml | 40

[libvirt] [PATCH 0/2] Add new EPYC CPU model

2017-09-06 Thread Jiri Denemark
Brijesh Singh (1): cpu: Add new EPYC CPU model Jiri Denemark (1): tests: Add CPUID data for AMD Ryzen 7 1800X Eight-Core Processor src/cpu/cpu_map.xml| 74 tests/cputest.c| 1 +

Re: [libvirt] Exposing mem-path in domain XML

2017-09-06 Thread Daniel P. Berrange
On Wed, Sep 06, 2017 at 01:35:45PM +0200, Michal Privoznik wrote: > On 09/05/2017 04:07 PM, Daniel P. Berrange wrote: > > On Tue, Sep 05, 2017 at 03:59:09PM +0200, Michal Privoznik wrote: > >> On 07/28/2017 10:59 AM, Daniel P. Berrange wrote: > >>> On Fri, Jul 28, 2017 at 10:45:21AM +0200, Michal

Re: [libvirt] libvirt domain memory statistics

2017-09-06 Thread Michal Privoznik
On 09/06/2017 01:09 PM, Marko Myllynen wrote: > Hi, > > At least on RHEL 7 / libvirt-3.2 for domainListGetStats we only have the > following in libvirt.py: > > # virDomainStatsTypes > VIR_DOMAIN_STATS_STATE = 1 > VIR_DOMAIN_STATS_CPU_TOTAL = 2 > VIR_DOMAIN_STATS_BALLOON = 4 >

Re: [libvirt] Exposing mem-path in domain XML

2017-09-06 Thread Michal Privoznik
On 09/05/2017 04:07 PM, Daniel P. Berrange wrote: > On Tue, Sep 05, 2017 at 03:59:09PM +0200, Michal Privoznik wrote: >> On 07/28/2017 10:59 AM, Daniel P. Berrange wrote: >>> On Fri, Jul 28, 2017 at 10:45:21AM +0200, Michal Privoznik wrote: On 07/27/2017 03:50 PM, Daniel P. Berrange wrote:

[libvirt] libvirt domain memory statistics

2017-09-06 Thread Marko Myllynen
Hi, At least on RHEL 7 / libvirt-3.2 for domainListGetStats we only have the following in libvirt.py: # virDomainStatsTypes VIR_DOMAIN_STATS_STATE = 1 VIR_DOMAIN_STATS_CPU_TOTAL = 2 VIR_DOMAIN_STATS_BALLOON = 4 VIR_DOMAIN_STATS_VCPU = 8 VIR_DOMAIN_STATS_INTERFACE = 16 VIR_DOMAIN_STATS_BLOCK = 32

[libvirt] [PATCH python] Post-release version bump to 3.8.0

2017-09-06 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- Pushed as trivial setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 6e5242d..f33ff1a 100755 --- a/setup.py +++ b/setup.py @@ -334,7 +334,7 @@ class my_clean(clean): _c_modules,

Re: [libvirt] [PATCH] conf: Validate device on update-device

2017-09-06 Thread Michal Privoznik
On 09/06/2017 10:45 AM, Erik Skultety wrote: > On Tue, Sep 05, 2017 at 04:37:23PM +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1439991 >> >> Whenever a device is being updated via >> virDomainUpdateDeviceFlags() API, we parse the device XML and >> ideally run some

Re: [libvirt] [PATCH] conf: Validate device on update-device

2017-09-06 Thread Erik Skultety
On Tue, Sep 05, 2017 at 04:37:23PM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1439991 > > Whenever a device is being updated via > virDomainUpdateDeviceFlags() API, we parse the device XML and > ideally run some generic checks to validate the configuration > (e.g.