On Thu, Sep 14, 2017 at 14:03:06 -0400, John Ferlan wrote:
> Add a couple of tests to "validate" checks in domain_conf that either
The quotes seem slightly inapropriate here. If this only "validates" the
checks, then why to add it? Just validate them.
> a missing secrettype (CONFIG_UNSUPPORTED) o
On Thu, Sep 14, 2017 at 14:03:05 -0400, John Ferlan wrote:
> Alter the example to remove the from:
>
>
>
>
>
>
>
>
>
>
> and
>
>
>
>
>
>
>
>
>
>
> The reality is, it's not even used. For a the authdef
> from the stora
On Thu, Sep 14, 2017 at 14:03:10 -0400, John Ferlan wrote:
> Commit id 'e02ff020cac' neglected to use the attrBuf and childBuf
> in the virDomainDiskSourceFormatNetwork call.
>
> So make the necessary alterations to allow usage.
>
> Signed-off-by: John Ferlan
> ---
> src/conf/domain_conf.c | 34
On Thu, Sep 14, 2017 at 14:03:08 -0400, John Ferlan wrote:
> Add a test to prove checking for invalid luks disk formatting check
According to the error message the element is not necessary
when defining a disk for a domain:
419) QEMU XML-2-ARGV luks-disk-invalid .
On Thu, Sep 14, 2017 at 14:03:09 -0400, John Ferlan wrote:
> Rather than checking during XML processing, move the check for
> valid into virDomainDiskDefParseValidate.
>
> Signed-off-by: John Ferlan
> ---
> src/conf/domain_conf.c | 29 +
> 1 file changed, 17 insertio
On Thu, Sep 14, 2017 at 14:03:07 -0400, John Ferlan wrote:
> Rather than checking during XML processing, move the checks for correct
> and valid auth into virDomainDiskDefParseValidate. This will introduce
> virDomainDiskSourceDefParseAuthValidate to validate that the authdef
> stored for the virSt
On 08/28/2017 03:15 AM, Peter Krempa wrote:
> On Sun, Aug 27, 2017 at 12:35:07 -0400, Cole Robinson wrote:
>> From: Ville Skyttä
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1483293
>> Signed-off-by: Cole Robinson
>> ---
>
> Looks like two separate problems. Also the commit message is rathe
This is required by the fedora packaging guidelines:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines
This macro isn't available on stock RHEL6 so provide a backcompat
definition
https://bugzilla.redhat.com/show_bug.cgi?id=1483293
Reported-by: Ville Skyttä
Signed-off-by: Cole Robin
From: Ville Skyttä
Owning all created directories is a requirement of the Fedora
packaging guidelines
https://bugzilla.redhat.com/show_bug.cgi?id=1483293
Signed-off-by: Cole Robinson
---
libvirt.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
ind
Rather than checking during XML processing, move the check for
valid into virDomainDiskDefParseValidate.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c | 29 +
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/do
Add a couple of tests to "validate" checks in domain_conf that either
a missing secrettype (CONFIG_UNSUPPORTED) or an mismatched secrettype
of ceph for an iSCSI disk (INTERNAL_ERROR) will cause a parsing error.
Signed-off-by: John Ferlan
---
...drive-network-iscsi-auth-secrettype-invalid.xml | 3
Perform some cleanups with the auth and encryption processing.
This is a precursor to some other changes that will move/create
disk level and elements since they
are already in the _virStorageSource.
I'm still working on the latter, but before there's too many patches.
John Ferlan (6):
docs
Commit id 'e02ff020cac' neglected to use the attrBuf and childBuf
in the virDomainDiskSourceFormatNetwork call.
So make the necessary alterations to allow usage.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c | 34 ++
1 file changed, 14 insertions(+), 20 d
Rather than checking during XML processing, move the checks for correct
and valid auth into virDomainDiskDefParseValidate. This will introduce
virDomainDiskSourceDefParseAuthValidate to validate that the authdef
stored for the virStorageSource is valid. This can then be expanded
to service backingS
Add a test to prove checking for invalid luks disk formatting check
Signed-off-by: John Ferlan
---
.../qemuxml2argv-luks-disk-invalid.xml | 37 ++
tests/qemuxml2argvtest.c | 1 +
2 files changed, 38 insertions(+)
create mode 100644 test
Alter the example to remove the from:
and
The reality is, it's not even used. For a the authdef
from the storage source pool will supercede whatever is in the
definition during virStorageTranslateDiskSourcePool proce
On Wed, Sep 13, 2017 at 05:28:56PM +0200, Michal Privoznik wrote:
> On 09/13/2017 03:54 PM, Stefan Hajnoczi wrote:
> > 2. Only allow NVDIMM hotplug if the domain was started with -M
> >nvdimm=on.
> >
> > I think QEMU will not add -M nvdimm=on to the "pc" machine type by
> > default since it ad
On Thu, 2017-09-14 at 17:31 +0200, Martin Kletzander wrote:
> On Thu, Sep 14, 2017 at 03:09:08PM +0200, Andrea Bolognani wrote:
> > Order them more logically and make sure that stuff that doesn't
> > need to be modified frequently if at all, such as the notification
> > settings, are out of the way
On Thu, Sep 14, 2017 at 03:09:08PM +0200, Andrea Bolognani wrote:
Order them more logically and make sure that stuff that doesn't
need to be modified frequently if at all, such as the notification
settings, are out of the way.
Perform other minor tweaks as well.
Signed-off-by: Andrea Bolognani
On Thu, Sep 14, 2017 at 05:10:24PM +0200, Andrea Bolognani wrote:
On Thu, 2017-09-14 at 16:49 +0200, Martin Kletzander wrote:
> So I'm on the fence about this patch - I'd have a slight preference for
> existing behaviour of failing fast to keep errors at the end of the log
I, personally, would
(Almost all of my comments result in "ok, no action needed". There are
just three items I would like to see changed (2 trivial, 1 also small
but Edan or John may think it prudent to re-test with the change before
pushing) - I marked those comments with [**].
On 08/21/2017 05:19 AM, Edan David wrot
On Thu, Sep 14, 2017 at 02:48:06PM +0100, Daniel P. Berrange wrote:
On Thu, Sep 14, 2017 at 03:09:04PM +0200, Andrea Bolognani wrote:
The build will fail if any of the commands fail, but this way we
might catch more errors in a single run.
Signed-off-by: Andrea Bolognani
---
.travis.yml | 4 +
On Thu, 2017-09-14 at 16:49 +0200, Martin Kletzander wrote:
> > So I'm on the fence about this patch - I'd have a slight preference for
> > existing behaviour of failing fast to keep errors at the end of the log
>
> I, personally, would go with:
>
> script:
> - make -j3 check
> - make -j3 synta
On Thu, Sep 14, 2017 at 04:09:37PM +0200, Andrea Bolognani wrote:
> On Thu, 2017-09-14 at 14:50 +0100, Daniel P. Berrange wrote:
> > > @@ -5,37 +5,60 @@ addons:
> > >apt:
> > > # Please keep this list sorted alphabetically
> > > packages:
> [...]
> > > + - zfs-fuse
> >
> > Did y
On Thu, 2017-09-14 at 14:50 +0100, Daniel P. Berrange wrote:
> > @@ -5,37 +5,60 @@ addons:
> >apt:
> > # Please keep this list sorted alphabetically
> > packages:
[...]
> > + - zfs-fuse
>
> Did you check if travis actually lets you install all these ? They have
> to whitelist e
On Thu, 2017-09-14 at 14:48 +0100, Daniel P. Berrange wrote:
> > script:
> > - - make -j3 && make -j3 syntax-check && make -j3 check
> > + - make -j3
> > + - make -j3 syntax-check
> > + - make -j3 check
> >
> > # Environments here are run in addition to the main environment defined
> > abov
On Thu, Sep 14, 2017 at 04:45:30PM +0200, Andrea Bolognani wrote:
> On Thu, 2017-09-14 at 14:48 +0100, Daniel P. Berrange wrote:
> > > script:
> > > - - make -j3 && make -j3 syntax-check && make -j3 check
> > > + - make -j3
> > > + - make -j3 syntax-check
> > > + - make -j3 check
> > >
> > >
Only feature policy is checked on s390, which was previously done in
virCPUUpdate, but that's not the correct place for the check once we
have virCPUValidateFeatures.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_s390.c | 29 +
1 file changed, 21 insertions(+), 8 delet
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_process.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 7e9b406b6a..d3155e4e75 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -4659,6 +4659,10 @@ qemuProcessStar
The function checks whether all CPU features used in a CPU definition
are specified in cpu_map.xml.
https://bugzilla.redhat.com/show_bug.cgi?id=1460086
Signed-off-by: Jiri Denemark
---
src/cpu/cpu_x86.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/src/cpu/cpu_x86
CPU features are usually checked by libvirt, but not if libvirt decides
it should not check the CPU at all, which happens with host-passthrough
CPUs, for example. Let's check all used CPU features are valid for all
CPU definitions.
https://bugzilla.redhat.com/show_bug.cgi?id=1460086
Jiri Denemark
This new API may be used to check whether all features used in a CPU
definition are valid (e.g., libvirt knows their name, their policy is
supported, etc.). Leaving this API unimplemented in an arch subdriver
means libvirt does not restrict CPU features usable on the associated
architectures.
Sign
On Thu, Sep 14, 2017 at 03:09:05PM +0200, Andrea Bolognani wrote:
> Make single commands OS-dependent instead.
>
> Signed-off-by: Andrea Bolognani
> ---
> .travis.yml | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index c2526bc6d.
On Thu, Sep 14, 2017 at 03:09:06PM +0200, Andrea Bolognani wrote:
> The default distribution is apparently ignored if an explicit test
> matrix is provided, so we haven't actually been testing the precise
> plus gcc combo.
>
> Signed-off-by: Andrea Bolognani
> ---
> .travis.yml | 10 --
>
On 09/14/2017 02:50 PM, Daniel P. Berrange wrote:
The sanity test check aims to ensure that every function listed in
the Python code maps to a corresponding C function. The Sparse
send/recv methods are special though - we're never calling the
corresponding C APIs, instead we have a pure python im
On Thu, Sep 14, 2017 at 03:09:04PM +0200, Andrea Bolognani wrote:
> The build will fail if any of the commands fail, but this way we
> might catch more errors in a single run.
>
> Signed-off-by: Andrea Bolognani
> ---
> .travis.yml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
On Thu, Sep 14, 2017 at 03:09:07PM +0200, Andrea Bolognani wrote:
> Since configure automatically picks up as many optional dependencies
> as possible, installing more packages allows us to improve our test
> coverage.
>
> Signed-off-by: Andrea Bolognani
> ---
> .travis.yml | 37
On Thu, Sep 14, 2017 at 03:09:03PM +0200, Andrea Bolognani wrote:
> The openwsman header files are at fault here, but precise is entirely
> unmaintained at this point so the issue will never be fixed.
>
> Better to ignore the error and have coverage over the Hyper-V driver
> than disabling it: if
On Thu, Sep 14, 2017 at 03:09:02PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> .travis.yml | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 8831f742c..367baf861 100644
> --- a/.travis.yml
> +++ b/
On Thu, Sep 14, 2017 at 03:09:01PM +0200, Andrea Bolognani wrote:
> We don't need 50 commits for our purposes, so might as well save some
> bandwidth and possibly some time by making the clone more shallow.
>
> Signed-off-by: Andrea Bolognani
> ---
> .travis.yml | 1 +
> 1 file changed, 1 insert
Make single commands OS-dependent instead.
Signed-off-by: Andrea Bolognani
---
.travis.yml | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index c2526bc6d..e93fc73b2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -77,8 +77,10 @@ before_scri
Signed-off-by: Andrea Bolognani
---
.travis.yml | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 8831f742c..367baf861 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -60,14 +60,20 @@ git:
depth: 5
submodules: true
+env:
+ glob
The openwsman header files are at fault here, but precise is entirely
unmaintained at this point so the issue will never be fixed.
Better to ignore the error and have coverage over the Hyper-V driver
than disabling it: if code that would trigger the warning will be
added to libvirt, the CentOS CI
The build will fail if any of the commands fail, but this way we
might catch more errors in a single run.
Signed-off-by: Andrea Bolognani
---
.travis.yml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index ba8ff49a1..c2526bc6d 100644
--- a/.trav
On 09/14/2017 02:42 PM, Daniel P. Berrange wrote:
> On Thu, Sep 14, 2017 at 01:41:08PM +0200, Michal Privoznik wrote:
>> Currently, we require 0.9.11. However, some APIs are missing
>> there and thus sanity check fails:
>>
>> DEBUG: /usr/bin/python sanitytest.py build/lib.linux-s390x-2.7
>> /usr/s
Since configure automatically picks up as many optional dependencies
as possible, installing more packages allows us to improve our test
coverage.
Signed-off-by: Andrea Bolognani
---
.travis.yml | 37 ++---
1 file changed, 30 insertions(+), 7 deletions(-)
diff --
We don't need 50 commits for our purposes, so might as well save some
bandwidth and possibly some time by making the clone more shallow.
Signed-off-by: Andrea Bolognani
---
.travis.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.travis.yml b/.travis.yml
index f59bd19c8..8831f742c 100644
On Thu, Sep 14, 2017 at 03:05:15PM +0200, Michal Privoznik wrote:
> On 09/14/2017 02:42 PM, Daniel P. Berrange wrote:
> > On Thu, Sep 14, 2017 at 01:41:08PM +0200, Michal Privoznik wrote:
> >> Currently, we require 0.9.11. However, some APIs are missing
> >> there and thus sanity check fails:
> >>
This series fixes the precise+gcc combo not being actually tested
and significantly improves test coverage by installing a bunch of
additional optional dependencies on the workers.
Andrea Bolognani (8):
travis: Limit git depth to 5 commits
travis: Move variables to 'env' section
travis: Don'
On Thu, Sep 14, 2017 at 01:41:08PM +0200, Michal Privoznik wrote:
Currently, we require 0.9.11. However, some APIs are missing
there and thus sanity check fails:
DEBUG: /usr/bin/python sanitytest.py build/lib.linux-s390x-2.7
/usr/share/libvirt/api/libvirt-api.xml
DEBUG: FAIL virStream.sparseRec
Order them more logically and make sure that stuff that doesn't
need to be modified frequently if at all, such as the notification
settings, are out of the way.
Perform other minor tweaks as well.
Signed-off-by: Andrea Bolognani
---
.travis.yml | 62 +++--
The default distribution is apparently ignored if an explicit test
matrix is provided, so we haven't actually been testing the precise
plus gcc combo.
Signed-off-by: Andrea Bolognani
---
.travis.yml | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/.travis.yml b/.tra
From: Ashish Mittal
Extract out the "guts" of building a server entry into it's own
separately callable/usable function in order to allow building
a server entry for a consumer with src->nhosts == 1.
Signed-off-by: John Ferlan
---
src/qemu/qemu_block.c | 106 +--
From: Ashish Mittal
Alter the schema to allow a VxHS block device. Sample XML is:
eb90327c-8302-4725-9e1b-4e85ed4dc251
Update the html docs to describe the capability for VxHS.
Alter the qemuxml2xmltest to validate the formatting.
Signed-off-by: Ashis
From: Ashish Mittal
Add a new virStorageNetProtocol for Veritas HyperScale (VxHS) disks
Signed-off-by: Ashish Mittal
Signed-off-by: John Ferlan
---
src/libxl/libxl_conf.c| 1 +
src/qemu/qemu_block.c | 1 +
src/qemu/qemu_command.c | 1 +
src/qemu/qemu_driver.c| 3
Using the query-qmp-schema introspection - look for the 'vxhs'
blockdevOptions type.
NB: This is a "best effort" type situation as there is not a
mechanism to determine whether the running QEMU has been
built with '--enable-vxhs'. All we can do is check if the
option to use vxhs for a
On Tue, Sep 12, 2017 at 12:09:43PM +0200, Peter Krempa wrote:
Add helpers to remember existing errors when they might be overwritten
and use it to fix "unknown error" reported when attaching disk with lock
manager enabled.
Peter Krempa (3):
util: error: Add helpers for saving and restoring of l
Introduce a function to setup any TLS needs for a disk source.
If there's a configuration or other error setting up the disk source
for TLS, then cause the domain startup to fail.
For VxHS, follow the chardevTLS model where if the src->haveTLS hasn't
been configured, then take the system/global c
From: Ashish Mittal
Add the backing parse and a test case to verify parsing of VxHS
backing storage.
Signed-off-by: Ashish Mittal
Signed-off-by: John Ferlan
---
src/util/virstoragefile.c | 37 +
tests/virstoragetest.c| 11 +++
2 files changed, 4
On Thu, 14 Sep 2017 13:51:45 +0200
Michal Privoznik wrote:
> On 09/14/2017 02:33 AM, Haozhong Zhang wrote:
> > On 09/13/17 17:28 +0200, Michal Privoznik wrote:
> >>
> >> BTW: I ran a migration from no nvdimm qemu to one that had -M nvdimm=on
> >> and guest migrated happily. So looks like guest
From: Ashish Mittal
Alter qemu command line generation in order to possibly add TLS for
a suitably configured domain.
Sample TLS args generated by libvirt -
-object tls-creds-x509,id=objvirtio-disk0_tls0,dir=/etc/pki/qemu,\
endpoint=client,verify-peer=yes \
-drive file.driver=vxhs,f
From: Ashish Mittal
Add a test case to verify TLS arguments are parsed correctly for
a VxHS disk. This includes saving off a found tls-creds into the
storage source @tlsAlias field since that's what's used to link
the TLS object for the authentication credentials and the disk.
Test case verifies
From: Ashish Mittal
Add an optional virTristateBool haveTLS to virStorageSource to
manage whether a storage source will be using TLS.
Sample XML for a VxHS disk:
Additionally add a tlsFromConfig boolean to control whether the TLS
setting was due to domain configuration or qe
From: Ashish Mittal
Add a new TLS X.509 certificate type - "vxhs". This will handle the
creation of a TLS certificate capability for properly configured
VxHS network block device clients.
The following describes the behavior of TLS for VxHS block device:
(1) Two new options have been added in
v7: https://www.redhat.com/archives/libvir-list/2017-September/msg00035.html
Patches 1-4 are already ACK'd, but are presented again for completeness
Differences:
* Former patch1 already pushed (QEMU 2.10 replies and xml changes)
* Patch 5 is new - to split up the server args into a single ser
From: Ashish Mittal
The VxHS block device will only use the newer formatting options and
avoid the legacy URI syntax.
An excerpt for a sample QEMU command line is:
-drive file.driver=vxhs,file.vdisk-id=eb90327c-8302-4725-9e1b-4e85ed4dc251,\
file.server.type=tcp,file.server.host=192.168.0.1
The sanity test check aims to ensure that every function listed in
the Python code maps to a corresponding C function. The Sparse
send/recv methods are special though - we're never calling the
corresponding C APIs, instead we have a pure python impl.
Signed-off-by: Daniel P. Berrange
---
sanityt
On Thu, Sep 14, 2017 at 01:41:08PM +0200, Michal Privoznik wrote:
> Currently, we require 0.9.11. However, some APIs are missing
> there and thus sanity check fails:
>
> DEBUG: /usr/bin/python sanitytest.py build/lib.linux-s390x-2.7
> /usr/share/libvirt/api/libvirt-api.xml
> DEBUG: FAIL virStream
On 09/14/2017 02:33 AM, Haozhong Zhang wrote:
> On 09/13/17 17:28 +0200, Michal Privoznik wrote:
>>
>> BTW: I ran a migration from no nvdimm qemu to one that had -M nvdimm=on
>> and guest migrated happily. So looks like guest ABI is stable (or at
>> least stable enough not to crash). But since ACPI
Currently, we require 0.9.11. However, some APIs are missing
there and thus sanity check fails:
DEBUG: /usr/bin/python sanitytest.py build/lib.linux-s390x-2.7
/usr/share/libvirt/api/libvirt-api.xml
DEBUG: FAIL virStream.sparseRecvAll (Python API not mapped to C)
DEBUG: FAIL virStream.sparse
On 09/06/2017 01:42 PM, Daniel P. Berrange wrote:
> On Wed, Sep 06, 2017 at 01:35:45PM +0200, Michal Privoznik wrote:
>> On 09/05/2017 04:07 PM, Daniel P. Berrange wrote:
>>> On Tue, Sep 05, 2017 at 03:59:09PM +0200, Michal Privoznik wrote:
On 07/28/2017 10:59 AM, Daniel P. Berrange wrote:
>>>
Hi,
here are some doc updates I found on a long unused branch but they still apply.
Cheers,
-- Guido
Guido Günther (3):
Add some missing docs
streams: fix references
gvir_stream_send: make it obvious that we send bytes
libvirt-gobject/libvirt-gobject-connection.c | 15 ++-
libvirt
---
libvirt-gobject/libvirt-gobject-connection.c | 15 ++-
libvirt-gobject/libvirt-gobject-domain.c | 2 +-
libvirt-gobject/libvirt-gobject-stream.c | 10 ++
3 files changed, 25 insertions(+), 2 deletions(-)
diff --git a/libvirt-gobject/libvirt-gobject-connection.c
b
Fix doc and use a proper variable name
---
libvirt-gobject/libvirt-gobject-stream.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/libvirt-gobject/libvirt-gobject-stream.c
b/libvirt-gobject/libvirt-gobject-stream.c
index 296c00e..93788b5 100644
---
---
libvirt-gobject/libvirt-gobject-stream.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt-gobject/libvirt-gobject-stream.c
b/libvirt-gobject/libvirt-gobject-stream.c
index b6bf774..296c00e 100644
--- a/libvirt-gobject/libvirt-gobject-stream.c
+++ b/libvirt-gobje
On Thu, Sep 14, 2017 at 12:56:30PM +0200, Peter Krempa wrote:
> On Thu, Sep 14, 2017 at 16:37:03 +0800, Liu Qing wrote:
> > On Thu, Sep 14, 2017 at 10:02:40AM +0200, Peter Krempa wrote:
> > > On Thu, Sep 14, 2017 at 09:29:28 +0200, Peter Krempa wrote:
>
> [...]
>
> > > One more thing. The design
The host CPU definitions reported in the capabilities XML may contain
CPU features unknown to QEMU, but the result of virConnectBaselineCPU is
supposed to be directly usable as a guest CPU definition and thus it
should only contain features QEMU knows about.
https://bugzilla.redhat.com/show_bug.cg
For parsing a list of CPU XMLs into a NULL-terminated list of CPU defs.
Signed-off-by: Jiri Denemark
---
src/conf/cpu_conf.c | 78
src/conf/cpu_conf.h | 7 +
src/libvirt_private.syms | 2 ++
3 files changed, 87 insertions(+)
diff
Signed-off-by: Jiri Denemark
---
src/cpu/cpu.c | 52 ++--
1 file changed, 6 insertions(+), 46 deletions(-)
diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c
index 96160901e1..bf3c6d53dd 100644
--- a/src/cpu/cpu.c
+++ b/src/cpu/cpu.c
@@ -523,11 +523,9 @@ c
On 09/14/2017 04:13 AM, Peter Krempa wrote:
> On Tue, Sep 12, 2017 at 14:39:58 -0400, John Ferlan wrote:
>> This patch would be merged with the existing 06/11 patch for the
>> following changes:
>>
>>1. Use qemuBlockStorageSourceBuildJSONSocketAddress to build a single
>> server address
On Thu, Sep 14, 2017 at 06:53:10 -0400, John Ferlan wrote:
> On 09/14/2017 04:13 AM, Peter Krempa wrote:
> > On Tue, Sep 12, 2017 at 14:39:58 -0400, John Ferlan wrote:
[...]
> > With all the squash-ins and .5 patches this got messy. Please repost.
> >
>
> Sure, not problem. Any issue w/ me push
The filter only needs to know the CPU architecture. Passing
virQEMUCapsPtr as opaque is a bit overkill.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilitie
On Thu, Sep 14, 2017 at 16:37:03 +0800, Liu Qing wrote:
> On Thu, Sep 14, 2017 at 10:02:40AM +0200, Peter Krempa wrote:
> > On Thu, Sep 14, 2017 at 09:29:28 +0200, Peter Krempa wrote:
[...]
> > One more thing. The design you've proposed is really not user friendly.
> > The user has to read a leng
On Fri, Sep 01, 2017 at 01:09:45PM -0400, John Ferlan wrote:
> For reference, these were generated by updating a local qemu git
> repository to the latest upstream, making sure the latest dependencies
> were met via "dnf builddep qemu" from my sufficiently privileged root
> account, checking out th
The host CPU definitions reported in the capabilities XML may contain
CPU features unknown to QEMU, but the result of virConnectBaselineCPU is
supposed to be directly usable as a guest CPU definition and thus it
should only contain features QEMU knows about.
https://bugzilla.redhat.com/show_bug.cg
The implementation of virConnectBaselineCPU may be different for each
hypervisor. Thus it shouldn't really be implmented in the cpu code.
Signed-off-by: Jiri Denemark
---
src/bhyve/bhyve_driver.c | 22 +++---
src/cpu/cpu.c| 58 -
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_capabilities.c | 2 +-
src/qemu/qemu_capabilities.h | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 52d63f44ec..7bc88be0f5 100644
--- a/src/qemu/qemu_capabilitie
They are logged in cpuBaseline anyway.
Signed-off-by: Jiri Denemark
---
src/cpu/cpu.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c
index bf3c6d53dd..e75f406040 100644
--- a/src/cpu/cpu.c
+++ b/src/cpu/cpu.c
@@ -526,18 +526,12 @@ cpuBaselineXML(const char
On Thu, Sep 14, 2017 at 10:02:40AM +0200, Peter Krempa wrote:
> On Thu, Sep 14, 2017 at 09:29:28 +0200, Peter Krempa wrote:
> > On Thu, Sep 14, 2017 at 13:02:46 +0800, Liu Qing wrote:
> > > On Wed, Sep 13, 2017 at 01:20:03PM +0200, Peter Krempa wrote:
> > > > On Wed, Sep 13, 2017 at 17:21:23 +0800,
On Tue, Sep 12, 2017 at 14:39:58 -0400, John Ferlan wrote:
> This patch would be merged with the existing 06/11 patch for the
> following changes:
>
>1. Use qemuBlockStorageSourceBuildJSONSocketAddress to build a single
> server address
>2. Alter the output file to remove the server
On Thu, Sep 14, 2017 at 09:29:28AM +0200, Peter Krempa wrote:
> On Thu, Sep 14, 2017 at 13:02:46 +0800, Liu Qing wrote:
> > On Wed, Sep 13, 2017 at 01:20:03PM +0200, Peter Krempa wrote:
> > > On Wed, Sep 13, 2017 at 17:21:23 +0800, Liu Qing wrote:
>
> [...]
>
> > > [1] There's discussion I can li
On Thu, Sep 14, 2017 at 09:29:28 +0200, Peter Krempa wrote:
> On Thu, Sep 14, 2017 at 13:02:46 +0800, Liu Qing wrote:
> > On Wed, Sep 13, 2017 at 01:20:03PM +0200, Peter Krempa wrote:
> > > On Wed, Sep 13, 2017 at 17:21:23 +0800, Liu Qing wrote:
>
> [...]
>
> > > [1] There's discussion I can link
On 09/13/2017 06:02 PM, Laine Stump wrote:
> On 09/13/2017 06:46 AM, Michal Privoznik wrote:
>> On 09/12/2017 09:16 PM, Laine Stump wrote:
>>> On 09/12/2017 05:32 AM, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1075520
+/* QEMU needs some space
On Thu, Sep 14, 2017 at 13:02:46 +0800, Liu Qing wrote:
> On Wed, Sep 13, 2017 at 01:20:03PM +0200, Peter Krempa wrote:
> > On Wed, Sep 13, 2017 at 17:21:23 +0800, Liu Qing wrote:
[...]
> > [1] There's discussion I can link to for other tuning parameters. The
> > gist is that allowing users to se
94 matches
Mail list logo