On 17.10.2017 15:34, John Ferlan wrote:
>
>
> On 10/17/2017 03:40 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 16.10.2017 15:47, John Ferlan wrote:
>>>
>>>
>>> On 09/27/2017 08:45 AM, Nikolay Shirokovskiy wrote:
Current daemon shutdown can cause crashes. The problem is that threads
ser
On Fri, Sep 08, 2017 at 10:48:10AM -0500, Brijesh Singh wrote:
> > > > 11. GO verifies the measurement and if measurement matches then it
> > > may
> > > > give a secret blob -- which must be injected into the guest before
> > > > libvirt starts the VM. If verification failed, GO
On 10/16/2017 04:20 PM, Kothapally Madhu Pavan wrote:
> Move qemuFreeKeywords into qemu_parse_command.c as
> qemuKeywordsFree and call it rather than inline code
> in multiple places.
To be consistent, the new API would be qemuParseKeywordsFree - API's in
qemu_parse_command.c start with qemuPars
On 10/12/2017 03:13 PM, Peter Krempa wrote:
> When formatting an inactive or migratable XML we will need to suppress
> backing chain members which were detected from the disk to keep
> semantics straight. This means we need to record, whether a
> virStorageSource originates from autodetection.
>
On 10/12/2017 03:13 PM, Peter Krempa wrote:
> See individual patches please.
>
> Peter Krempa (3):
> qemu: command: Separate wrapping of disk backend props to 'file'
> object
> qemu: block: Add support for file/block/dir storage to JSON disk src
> generator
> util: storagefile: Tra
ping?
Thanks -
John
On 10/06/2017 04:59 PM, John Ferlan wrote:
> Patches should hopefully speak for themselves.
>
> John Ferlan (4):
> storage: Extract out the LVCREATE
> storage: Introduce virStorageBackendCreateVolUsingQemuImg
> storage: Allow creation of a LUKS using logical volume
>
ping?
Thanks
John
On 10/06/2017 02:13 PM, John Ferlan wrote:
> The patches hopefully speak for themselves.
>
> John Ferlan (5):
> storage: Alter args to storageBackendResizeQemuImg
> storage: Add error path for virStorageBackendCreateQemuImgCmdFromVol
> storage: Alter storageBackendCrea
On 10/10/2017 05:52 PM, Dawid Zamirski wrote:
> The original description got it backwards.
> ---
> docs/formatdomain.html.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>From commit id '24e0171b' !! and subsequently just carried on by
multiple people without regard to readin
On 10/10/2017 05:52 PM, Dawid Zamirski wrote:
> VirutalBox has a IVRDEServerInfo sturcture available that
> gives the effective runtime port that the VM is using when it's
> running. This is useful when the "TCP/Ports" VBox property was set to
> port range (e.g. via autoport = "yes" or via VBoxMa
On 10/10/2017 05:52 PM, Dawid Zamirski wrote:
> Originally autoport in vbox driver was setting the port to default
> value (3389) which caused mutiple VM instances use the same port.
> Since libvirt XML does not allow to set port ranges, this patch changes
> the "autoport" behavior to set VBox's
On Tue, 2017-10-17 at 15:44 -0400, John Ferlan wrote:
>
> On 10/09/2017 04:49 PM, Dawid Zamirski wrote:
> > From: Dawid Zamirski
> >
> > When registering a VM we call OpenMedium on each disk image which
> > adds it
> > to vbox's global media registry. Therefore, we should make sure to
> > call
>
On Tue, Oct 17, 2017 at 16:23:49 -0400, John Ferlan wrote:
>
>
> On 10/10/2017 09:14 AM, Jiri Denemark wrote:
> > Even though only family and model are used for matching CPUID data with
> > CPU models from cpu_map.xml, stepping is used by x86DataFilterTSX which
> > is supposed to disable TSX on C
On 10/10/2017 09:14 AM, Jiri Denemark wrote:
> Even though only family and model are used for matching CPUID data with
> CPU models from cpu_map.xml, stepping is used by x86DataFilterTSX which
> is supposed to disable TSX on CPU models with broken TSX support.
>
> This series applies on top of "
On 10/17/2017 09:56 AM, Nikolay Shirokovskiy wrote:
> If same boot order is specified twice (or more) in domain xml
> we call free for uninitiaziled loadparm on cleanup in
> virDomainDeviceBootParseXML
> and SIGABRT (or similar) as a result.
> ---
> src/conf/domain_conf.c | 2 +-
> 1 file chang
On 10/09/2017 04:49 PM, Dawid Zamirski wrote:
> From: Dawid Zamirski
>
> ---
> docs/formatdomain.html.in | 3 +++
> 1 file changed, 3 insertions(+)
>
This would be merged into patch 2...
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index c0e3c2221..ddcc9f1b1 100644
On 10/09/2017 04:49 PM, Dawid Zamirski wrote:
> From: Dawid Zamirski
>
> * added vboxDumpStorageControllers
> * replaced vboxDumpIDEHDDs with vboxDumpDisks which has been refectored
> quite a bit to handle removable devices, the new SAS controller
> support etc.
> * align the logic in vboxS
On 10/09/2017 04:49 PM, Dawid Zamirski wrote:
> From: Dawid Zamirski
>
> Until now the vbox driver was completely ignoring element
ignoring the
> for storage in the XML definition. This patch adds support for
> interpretting element for storage devices. With this the
interpreting the
>
On 10/09/2017 04:49 PM, Dawid Zamirski wrote:
> From: Dawid Zamirski
>
> This patch 'maps' additonal methods for VBOX API to the libvirt unified
"for the VBOX API"
additional
> vbox API to deal with IStorageController. The 'mapped' methods are:
>
> * IStorageController->GetStorageController
On 10/09/2017 04:49 PM, Dawid Zamirski wrote:
> From: Dawid Zamirski
>
> The optional values are 'piix3', 'piix4' or 'ich6'. Those will be
> needed to allow setting IDE controller model in VirtualBox driver.
> ---
> docs/schemas/domaincommon.rng | 18 --
> src/conf/domain_conf.
On 10/09/2017 04:49 PM, Dawid Zamirski wrote:
> From: Dawid Zamirski
>
> When registering a VM we call OpenMedium on each disk image which adds it
> to vbox's global media registry. Therefore, we should make sure to call
> Close when unregistering VM so we cleanup the media registry entries
> a
17-Oct-17 20:40, Jiri Denemark пишет:
On Tue, Oct 17, 2017 at 16:55:13 +0300, Nikolay Shirokovskiy wrote:
Nikolay Shirokovskiy (2):
vz: missing pieces for fd885a06 for vz driver
vz: fix typo for 0d3d020b
src/vz/vz_driver.c | 4 ++--
src/vz/vz_sdk.c| 2 +-
2 files changed, 3 inser
On Tue, Oct 17, 2017 at 16:55:13 +0300, Nikolay Shirokovskiy wrote:
> Nikolay Shirokovskiy (2):
> vz: missing pieces for fd885a06 for vz driver
> vz: fix typo for 0d3d020b
>
> src/vz/vz_driver.c | 4 ++--
> src/vz/vz_sdk.c| 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
ACK ser
On Tue, 2017-10-17 at 18:16 +0200, Pavel Hrdina wrote:
> > Could we just generate a random root password, but install SSH public
> > keys and set SSH to only permit public key auth.
>
> That's the idea, having the root password stored on the host is just
> if something goes wrong and you need to
On Tue, 2017-10-17 at 17:32 +0100, Daniel P. Berrange wrote:
> Yeah, I think it is reasonable to have Ubuntu support. Travis is somewhat
> performance limited
Not to mention the embarassingly outdated OS offering. But hey,
it's worth every penny we spend on it! :)
--
Andrea Bolognani / Red Hat /
On Tue, Oct 17, 2017 at 06:24:47PM +0200, Andrea Bolognani wrote:
> On Tue, 2017-10-17 at 17:57 +0200, Pavel Hrdina wrote:
> > I wouldn't include Ubuntu related things. Yes, we use travis where they
> > have Ubuntu nodes, but this is jenkins-ci repository where we don't use
> > Ubuntu at all.
>
>
On Tue, 2017-10-17 at 17:57 +0200, Pavel Hrdina wrote:
> I wouldn't include Ubuntu related things. Yes, we use travis where they
> have Ubuntu nodes, but this is jenkins-ci repository where we don't use
> Ubuntu at all.
While a sane CI setup is definitely the primary reason why this work
is happe
On Tue, Oct 17, 2017 at 06:14:35PM +0200, Pavel Hrdina wrote:
> On Tue, Oct 17, 2017 at 05:04:57PM +0100, Daniel P. Berrange wrote:
> > On Tue, Oct 17, 2017 at 05:57:30PM +0200, Pavel Hrdina wrote:
> > > On Mon, Oct 16, 2017 at 06:02:06PM +0200, Andrea Bolognani wrote:
> > > > The 'manage' tool can
On Tue, Oct 17, 2017 at 05:11:40PM +0100, Daniel P. Berrange wrote:
> On Tue, Oct 17, 2017 at 06:05:23PM +0200, Pavel Hrdina wrote:
> > On Mon, Oct 16, 2017 at 06:02:04PM +0200, Andrea Bolognani wrote:
> > > Having to bootstrap the guest as a separate phase is annoying and
> > > can be avoided by a
On Tue, Oct 17, 2017 at 05:04:57PM +0100, Daniel P. Berrange wrote:
> On Tue, Oct 17, 2017 at 05:57:30PM +0200, Pavel Hrdina wrote:
> > On Mon, Oct 16, 2017 at 06:02:06PM +0200, Andrea Bolognani wrote:
> > > The 'manage' tool can now be used to install most known guests
> > > without requiring user
On Tue, Oct 17, 2017 at 06:05:23PM +0200, Pavel Hrdina wrote:
> On Mon, Oct 16, 2017 at 06:02:04PM +0200, Andrea Bolognani wrote:
> > Having to bootstrap the guest as a separate phase is annoying and
> > can be avoided by assuming the root password is well-known.
>
> I'm not sure about this. Yes
On Mon, Oct 16, 2017 at 06:02:04PM +0200, Andrea Bolognani wrote:
> Having to bootstrap the guest as a separate phase is annoying and
> can be avoided by assuming the root password is well-known.
I'm not sure about this. Yes the password will be well known for us
but I would rather have it genera
On Tue, Oct 17, 2017 at 05:57:30PM +0200, Pavel Hrdina wrote:
> On Mon, Oct 16, 2017 at 06:02:06PM +0200, Andrea Bolognani wrote:
> > The 'manage' tool can now be used to install most known guests
> > without requiring user interaction.
> >
> > Signed-off-by: Andrea Bolognani
> > ---
> > ansible
On Mon, Oct 16, 2017 at 06:02:06PM +0200, Andrea Bolognani wrote:
> The 'manage' tool can now be used to install most known guests
> without requiring user interaction.
>
> Signed-off-by: Andrea Bolognani
> ---
> ansible/group_vars/all/install.yml | 10 +++
> ansible/host_vars/li
I don't think a reliable syntax-check rule checking tab spacing can be used,
but I can of course be proven wrong.
Erik Skultety (2):
maint: Replace tabs with spaces in all source files in repo
maint: Remove not-so-much informative block commentaries
daemon/remote.c | 7 -
docs/
So we have a syntax-check rule to catch all tab indents but it naturally
can't catch tab spacing, i.e. as a delimiter. This patch is a result of
running 'vim -en +retab +wq'
(using tabstop=8 softtabstop=4 shiftwidth=4 expandtab) on each file from
a list generated by the following:
find . -regextype
There were a bunch of commentary blocks that were literally useless in
terms of describing what the code following them does, since most of
them were documenting "the obvious" or it just wouldn't help at all.
Signed-off-by: Erik Skultety
---
daemon/remote.c | 7 ---
src/network/
A function that builds the -device string for input devices.
---
src/qemu/qemu_command.c | 42 +-
src/qemu/qemu_command.h | 7 +++
2 files changed, 36 insertions(+), 13 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 1
For both virtio input devices and USB input devices.
https://bugzilla.redhat.com/show_bug.cgi?id=1379603
---
src/libvirt_private.syms | 2 ++
src/qemu/qemu_driver.c | 9 +-
src/qemu/qemu_hotplug.c | 73
src/qemu/qemu_hotplug.h | 5
Allow unplugging USB and virtio USB devices.
https://bugzilla.redhat.com/show_bug.cgi?id=1379603
---
src/qemu/qemu_driver.c | 4 ++-
src/qemu/qemu_hotplug.c | 76 +
src/qemu/qemu_hotplug.h | 3 ++
3 files changed, 82 insertions(+), 1 deletion(-)
Move assignment of input device alias into a separate function,
for reuse on hotplug.
---
src/qemu/qemu_alias.c | 24 +++-
src/qemu/qemu_alias.h | 3 +++
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c
index 72df1083
There are two more cases where we set an S390/CCW/PCI address
type based on the machine type.
Reuse qemuDomainEnsureVirtioAddress to reduce repetition.
---
src/qemu/qemu_hotplug.c | 56 -
1 file changed, 4 insertions(+), 52 deletions(-)
diff --git
https://bugzilla.redhat.com/show_bug.cgi?id=1379603
---
src/qemu/qemu_driver.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index fb4d72236..050a41524 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -8060,6 +8060,10 @@
Let it be reused in qemu_domain_address.
---
src/qemu/qemu_command.c | 40
src/qemu/qemu_command.h | 5 -
src/qemu/qemu_domain.c | 40
src/qemu/qemu_domain.h | 5 +
4 files changed, 45 insertions(+), 45 d
After a successful attach, the device address has already been set.
Remove the pointless assignment.
---
src/qemu/qemu_hotplug.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 0288986d8..2d13c2891 100644
--- a/src/qem
We pass the source.file to qemuCheckCCWS390AddressSupport for
the purpose of reporting an error message without actually checking
that the rng device is of type VIR_DOMAIN_RNG_BACKEND_RANDOM.
Change it to a hardcoded "rng" string, which also avoids
referring to the device by a host-side attribute.
https://bugzilla.redhat.com/show_bug.cgi?id=1379603
---
src/conf/domain_conf.c | 37 +
src/conf/domain_conf.h | 3 +++
src/libvirt_private.syms | 1 +
src/qemu/qemu_driver.c | 8
4 files changed, 49 insertions(+)
diff --git a/src/conf/domain_c
Split out the common code responsible for reserving/assigning
PCI/CCW addresses for virtio disks into a helper function
for reuse by other virtio devices.
---
src/qemu/qemu_domain_address.c | 45 ++
src/qemu/qemu_domain_address.h | 4
src/qemu/qemu_hot
Introduce virDomainAuditInput and use it to log the evdev passed
to the guest.
---
src/conf/domain_audit.c | 44
src/conf/domain_audit.h | 5 +
2 files changed, 49 insertions(+)
diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c
index
https://bugzilla.redhat.com/show_bug.cgi?id=1379603
Ján Tomko (12):
conf: audit passthrough input devices at domain startup
qemuDomainAttachControllerDevice: remove dead code
qemuDomainAttachRNGDevice: do not access source.file randomly
Move qemuCheckCCWS390AddressSupport to qemu_domain
---
src/vz/vz_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index c339622..3864d43 100644
--- a/src/vz/vz_driver.c
+++ b/src/vz/vz_driver.c
@@ -134,7 +134,7 @@ vzBuildCapabilities(void)
goto error;
if (!(cap
---
src/vz/vz_sdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 5f37714..52bd0fc 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -4495,7 +4495,7 @@ prlsdkGetNetStats(PRL_HANDLE sdkstats, PRL_HANDLE sdkdom,
const char *device,
If same boot order is specified twice (or more) in domain xml
we call free for uninitiaziled loadparm on cleanup in
virDomainDeviceBootParseXML
and SIGABRT (or similar) as a result.
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf
Nikolay Shirokovskiy (2):
vz: missing pieces for fd885a06 for vz driver
vz: fix typo for 0d3d020b
src/vz/vz_driver.c | 4 ++--
src/vz/vz_sdk.c| 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
--
1.8.3.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/ma
On Tue, Oct 17, 2017 at 09:32:43AM +0200, Ján Tomko wrote:
> Commit e371b3b changed all the links to libvirt.org to use https.
> Remove the leftover 'http' links from downloads page, since they
> point to https anyway.
> ---
> Pushed as trivial.
/me wonders why on earth I added both https & http l
On Tue, 2017-10-17 at 15:21 +0200, Pavel Hrdina wrote:
> > +do_list() {
> > +INVENTORY=$(grep "^inventory\\s*=" ansible.cfg 2>/dev/null | sed
> > "s/^.*=\\s*//g")
> > +INVENTORY=${INVENTORY:-/etc/ansible/hosts}
>
> I don't think that there is a need to include system-wide inventory
> sinc
On Tue, Oct 17, 2017 at 14:34:25 +0200, Pavel Hrdina wrote:
> On Wed, Oct 11, 2017 at 12:11:17PM +0200, Jiri Denemark wrote:
> > When libvirt older than 3.9.0 reconnected to a running domain started by
> > old libvirt it could have messed up the expansion of host-model by
> > adding features QEMU d
On Mon, Oct 16, 2017 at 06:02:05PM +0200, Andrea Bolognani wrote:
> This script replaces the existing Makefile, and will be extended
> to provide more functionality in future commits.
>
> Signed-off-by: Andrea Bolognani
> ---
> ansible/Makefile | 9 -
> ansible/manage | 57
>
On Wed, Oct 11, 2017 at 10:52:16AM +0200, Andrea Bolognani wrote:
> Rely on built-in functionality instead of reinventing the wheel.
>
> Andrea Bolognani (2):
> ansible: Use systemd module
> ansible: Use built-in init system detection
Reviewed-by: Pavel Hrdina
signature.asc
Description: PG
On 10/17/2017 03:40 AM, Nikolay Shirokovskiy wrote:
>
>
> On 16.10.2017 15:47, John Ferlan wrote:
>>
>>
>> On 09/27/2017 08:45 AM, Nikolay Shirokovskiy wrote:
>>> Current daemon shutdown can cause crashes. The problem is that threads
>>> serving client request are joined on daemon dispose after
On Wed, Oct 11, 2017 at 12:11:17PM +0200, Jiri Denemark wrote:
> When libvirt older than 3.9.0 reconnected to a running domain started by
> old libvirt it could have messed up the expansion of host-model by
> adding features QEMU does not support (such as cmt). Thus whenever we
> reconnect to a run
On Tue, Oct 17, 2017 at 01:15:43PM +0200, Jiri Denemark wrote:
> On Tue, Oct 17, 2017 at 12:57:10 +0200, Pavel Hrdina wrote:
> > On Wed, Oct 11, 2017 at 12:11:16PM +0200, Jiri Denemark wrote:
> > > The host CPU definition from host capabilities may contain features
> > > unknown to QEMU. Thus whene
On Tue, Oct 17, 2017 at 12:57:10 +0200, Pavel Hrdina wrote:
> On Wed, Oct 11, 2017 at 12:11:16PM +0200, Jiri Denemark wrote:
> > The host CPU definition from host capabilities may contain features
> > unknown to QEMU. Thus whenever we want to use this CPU definition, we
> > have to filter the unkno
On Wed, Oct 11, 2017 at 12:11:16PM +0200, Jiri Denemark wrote:
> The host CPU definition from host capabilities may contain features
> unknown to QEMU. Thus whenever we want to use this CPU definition, we
> have to filter the unknown features.
Might be nice to explicitly mention in the commit mess
On Mon, Oct 16, 2017 at 17:18:58 +0200, Pavel Hrdina wrote:
> On Thu, Oct 12, 2017 at 03:48:29PM +0200, Jiri Denemark wrote:
> > When migration fails, QEMU may provide a description of the error in
> > the reply to query-migrate QMP command. We can fetch this error and use
> > it instead of the gen
When running the manage tool as part of scheduled maintainance, eg.
in a cron job, it would be annoying to have to loop over the output
of 'manage list' and call 'manage update' on each of the guests; it
would also mean not taking advantage of Ansible's parallel execution
capabilities, which can sp
On 16.10.2017 15:47, John Ferlan wrote:
>
>
> On 09/27/2017 08:45 AM, Nikolay Shirokovskiy wrote:
>> Current daemon shutdown can cause crashes. The problem is that threads
>> serving client request are joined on daemon dispose after drivers already
>> cleaned up. But this threads typically uses
On Mon, Oct 16, 2017 at 3:58 PM, John Ferlan wrote:
>
>
> On 10/06/2017 02:47 AM, Ladi Prosek wrote:
>> The code was vulnerable to SQL injection. Likely not a security issue due to
>> WMI SQL and other constraints but still lame. For example:
>>
>> virsh # dominfo \"
>> error: failed to get do
Commit e371b3b changed all the links to libvirt.org to use https.
Remove the leftover 'http' links from downloads page, since they
point to https anyway.
---
Pushed as trivial.
docs/downloads.html.in | 17 -
1 file changed, 17 deletions(-)
diff --git a/docs/downloads.html.in b/do
On Mon, Oct 16, 2017 at 3:58 PM, John Ferlan wrote:
>
>
> On 10/06/2017 02:47 AM, Ladi Prosek wrote:
>> "%s is not a Hyper-V server" is not a correct generalization of all possible
>> error conditions of hypervEnumAndPull. For example:
>>
>> $ virsh --connect hyperv://localhost/?transport=http
>
On Fri, Sep 29, 2017 at 4:58 PM, Michal Privoznik
wrote:
> On 09/20/2017 04:59 PM, Christian Ehrhardt wrote:
> > If users only specified vendor&product (the common case) then parsing
> > the xml via virDomainHostdevSubsysUSBDefParseXML would only set these.
> > Bus and Device would much later be
70 matches
Mail list logo
