[libvirt] [PATCH v4 2/2] libvirtd: fix crash on termination

2017-10-26 Thread John Ferlan
From: Nikolay Shirokovskiy The problem is incorrect order of qemu driver shutdown and shutdown of netserver threads that serve client requests (thru qemu driver particularly). Net server threads are shutdown upon dispose which is triggered by last daemon object

[libvirt] [PATCH v4 1/2] rpc: When adding srv to dmn servers, need to add ref

2017-10-26 Thread John Ferlan
From: Nikolay Shirokovskiy Commit id '252610f7d' modified net server management to use a hash table to store/manage the various servers; however, during virNetDaemonAddServerPostExec an @srv object is created, added to the dmn->servers hash table, but did not

[libvirt] [PATCH v4 0/2] daemon: fix termination/reload issues

2017-10-26 Thread John Ferlan
This is a repost/fixup of Nikolay's v3: https://www.redhat.com/archives/libvir-list/2017-October/msg01089.html The primary difference here is a reorder of the patches to perform the proper refcnt operations before reordering the shutdown path in order to clean up servers out of the hash table

[libvirt] [PATCH go-xml] Add address support for memory device

2017-10-26 Thread zhenwei.pi
Add Base element for DomainAddress. Add address element for DomainMemorydev. Add test code for new DomainMemorydev. Signed-off-by: zhenwei.pi --- domain.go | 2 ++ domain_test.go | 9 + 2 files changed, 11 insertions(+) diff --git a/domain.go

[libvirt] 答复: [PATCH v2] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

2017-10-26 Thread Caoxinhua
Yes,In qemuxml2argvtest case, mymain call qemuTestDriverInit to init qemu driver, qemuTestDriverInit call mkdtemp() to init stateDir, so stateDir is randomly. But '-monitor' part of the command line must be a const value. Can I use a const value "/tmp/lib" to instead of random value at

Re: [libvirt] [PATCH v5 4/4] xlconfigtest: add tests for numa cell sibling distances

2017-10-26 Thread Jim Fehlig
On 10/12/2017 01:31 PM, Wim Ten Have wrote: From: Wim ten Have Test a bidirectional xen-xl domxml to and from native for numa support administration as brought under this patch series. Signed-off-by: Wim ten Have ---

Re: [libvirt] [PATCH v5 3/4] libxl: vnuma support

2017-10-26 Thread Jim Fehlig
On 10/12/2017 01:31 PM, Wim Ten Have wrote: From: Wim ten Have This patch generates a NUMA distance-aware libxl description from the information extracted from a NUMA distance-aware libvirt XML file. By default, if no NUMA node distance information is supplied in the

Re: [libvirt] [PATCH v5 2/4] xenconfig: add domxml conversions for xen-xl

2017-10-26 Thread Jim Fehlig
On 10/12/2017 01:31 PM, Wim Ten Have wrote: From: Wim ten Have This patch converts NUMA configurations between the Xen libxl configuration file format and libvirt's XML format. XML HVM domain on a 4 node (2 cores/socket) configuration:

[libvirt] [PATCH 04/12] qemu: Generalize APPEND macro in qemuMonitorJSONSetMigrationParams

2017-10-26 Thread Jiri Denemark
The APPEND macro is now be usable for any type. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index

[libvirt] [PATCH 06/12] qemu: Drop giant if statement from qemuMonitorSetMigrationParams

2017-10-26 Thread Jiri Denemark
The check can be easily replaced with a simple test in the JSON implementation and we don't need to update it every time a new parameter is added. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor.c | 9 - src/qemu/qemu_monitor_json.c | 5 + 2 files

[libvirt] [PATCH 00/12] qemu: Add support for more migration parameters

2017-10-26 Thread Jiri Denemark
QEMU is transforming existing special migration parameters (those which need dedicated QMP commands to be set or queried) into proper parameters handled by query-migrate-parameters and migrate-set-parameters. Even though we may still want to use the existing commands adding support for tha

[libvirt] [PATCH 03/12] qemu: Use macro for parsing ull migration parameters

2017-10-26 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index cb0bb0d0d..76fc84ed0 100644 --- a/src/qemu/qemu_monitor_json.c +++

[libvirt] [PATCH 11/12] qemu: Add support for max-bandwidth migration parameter

2017-10-26 Thread Jiri Denemark
We already support several ways of setting migration bandwidth and this is not adding another one. With this patch we are able to read and write this parameter using query-migrate-parameters and migrate-set-parameters in one call with all other parameters. Signed-off-by: Jiri Denemark

[libvirt] [PATCH 09/12] qemu: Add support for setting downtime-limit migration parameter

2017-10-26 Thread Jiri Denemark
We already support setting the maximum downtime with a dedicated virDomainMigrateSetMaxDowntime API. This patch does not implement another way of setting the downtime by adding a new public migration parameter. It just makes sure any parameter we are able to get from a QEMU monitor by

[libvirt] [PATCH 05/12] qemu: Use macro for setting string migration parameters

2017-10-26 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 218bbd8bd..826133543 100644 ---

[libvirt] [PATCH 12/12] qemu: Add support for block-incremental migration parameter

2017-10-26 Thread Jiri Denemark
We handle incremental storage migration in a different way. The support for this new (as of QEMU 2.10) parameter is only needed for full coverage of migration parameters used by QEMU. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor.c | 6 --

[libvirt] [PATCH 02/12] qemu: Use macro for parsing string migration parameters

2017-10-26 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 16554d5b2..cb0bb0d0d 100644 ---

[libvirt] [PATCH 01/12] qemu: Generalize PARSE macro in qemuMonitorJSONGetMigrationParams

2017-10-26 Thread Jiri Denemark
The macro (now called PARSE_SET) is now usable for any type which needs a *_set bool for indicating a valid value. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git

[libvirt] [PATCH 10/12] qemu: Rename TLS related migration parameters

2017-10-26 Thread Jiri Denemark
The parameters used "migrate" prefix which is pretty redundant and qemuMonitorMigrationParams structure is our internal representation of QEMU migration parameters and it is supposed to use names which match QEMU names. Signed-off-by: Jiri Denemark ---

[libvirt] [PATCH 07/12] qemumonitorjsontest: Rename 1st CHECK macro in migration params test

2017-10-26 Thread Jiri Denemark
The first CHECK macro in the test is used for checking integer values. Let's make it a bit more generic to be usable for any numeric type and use it for a new CHECK_INT macro. Signed-off-by: Jiri Denemark --- tests/qemumonitorjsontest.c | 20 1 file

[libvirt] [PATCH 08/12] qemumonitorjsontest: Rename 2nd CHECK macro in migration params test

2017-10-26 Thread Jiri Denemark
The second CHECK macro was used for string parameters. Let's rename it to CHECK_STR and move it up to have all checks in one place. Signed-off-by: Jiri Denemark --- tests/qemumonitorjsontest.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-)

Re: [libvirt] [REPOST PATCH 0/4] Add the ability to LUKS encrypt during LV creation

2017-10-26 Thread John Ferlan
ping? tks John On 10/19/2017 09:56 AM, John Ferlan wrote: > Repost to address merge conflict from commit id '0a294a8e2' which > used if (virStorageSourceHasBacking(>target)) instead of > if (vol->target.backingStore). > > Original series: >

Re: [libvirt] [PATCH 0/5] Properly resize a local LUKS encrypted volume

2017-10-26 Thread John Ferlan
ping^2 ? Tks, John On 10/17/2017 06:34 PM, John Ferlan wrote: > > > ping? > > Thanks > > John > > On 10/06/2017 02:13 PM, John Ferlan wrote: >> The patches hopefully speak for themselves. >> >> John Ferlan (5): >> storage: Alter args to storageBackendResizeQemuImg >> storage: Add error

Re: [libvirt] [PATCH] qemu: logrotate: drop minsize directive

2017-10-26 Thread Jim Fehlig
On 10/26/2017 11:14 AM, Daniel P. Berrange wrote: On Thu, Oct 26, 2017 at 11:13:23AM -0600, Jim Fehlig wrote: On 10/26/2017 12:48 AM, Daniel P. Berrange wrote: On Wed, Oct 25, 2017 at 03:30:46PM -0600, Jim Fehlig wrote: On a cloud host it is possible to create 100's of unique instances per

Re: [libvirt] [PATCH] qemu: logrotate: drop minsize directive

2017-10-26 Thread Daniel P. Berrange
On Thu, Oct 26, 2017 at 11:13:23AM -0600, Jim Fehlig wrote: > On 10/26/2017 12:48 AM, Daniel P. Berrange wrote: > > On Wed, Oct 25, 2017 at 03:30:46PM -0600, Jim Fehlig wrote: > > > On a cloud host it is possible to create 100's of unique instances > > > per day, each leaving behind a

Re: [libvirt] [PATCH] qemu: logrotate: drop minsize directive

2017-10-26 Thread Jim Fehlig
On 10/26/2017 12:48 AM, Daniel P. Berrange wrote: On Wed, Oct 25, 2017 at 03:30:46PM -0600, Jim Fehlig wrote: On a cloud host it is possible to create 100's of unique instances per day, each leaving behind a /var/log/libvirt/qemu/instance-name.log file that is < 100k. With the current 'minsize

Re: [libvirt] [PATCH v2 03/15] vbox: Cleanup partially-defined VM on failure

2017-10-26 Thread Dawid Zamirski
On Tue, 2017-10-24 at 15:35 -0400, Dawid Zamirski wrote: > Since the VBOX API requires to register an initial VM before > proceeding > to attach any remaining devices to it, any failure to attach such > devices should result in automatic cleanup of the initially > registered > VM so that the state

Re: [libvirt] [PATCH v2] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

2017-10-26 Thread Michal Privoznik
On 10/16/2017 04:08 AM, xinhua.Cao wrote: > directory /var/lib alway is Persistence directory, but in redhat system, > /var/run is memory directory. > our running domain xml is saved at /var/run/libvirt/qemu. so if we cold reset > system, > the /var/run/libvirt/qemu directory is clear, but >

Re: [libvirt] [PATCH 12/12] qemu: domain: skip chain detection to end of backing chain

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > When a user provides the backing chain, we will not need to re-detect > all the backing stores again, but should move to the end of the user > specified chain. Additionally if a user provides a full terminated chain > we should not attempt any

Re: [libvirt] [PATCH 12/12] qemu: domain: skip chain detection to end of backing chain

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > When a user provides the backing chain, we will not need to re-detect > all the backing stores again, but should move to the end of the user > specified chain. Additionally if a user provides a full terminated chain > we should not attempt any

Re: [libvirt] [PATCH 11/12] qemu: domain: Prepare TLS data for the whole backing chain

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > Iterate through the backing chain when setting up TLS for disks. > --- > src/qemu/qemu_domain.c | 41 ++--- > 1 file changed, 22 insertions(+), 19 deletions(-) > So (for now) a VxHS device could be at some depth

Re: [libvirt] [PATCH 10/12] qemu: domain: Remove pointless alias check

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > When attaching the disks, aliases are always generated. > --- > src/qemu/qemu_domain.c | 8 > src/qemu/qemu_domain.h | 3 +-- > src/qemu/qemu_hotplug.c | 2 +- > src/qemu/qemu_process.c | 2 +- > 4 files changed, 3 insertions(+), 12

Re: [libvirt] [PATCH 09/12] qemu: domain: Destroy secrets for complete backing chain

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > --- > src/qemu/qemu_domain.c | 22 -- > 1 file changed, 16 insertions(+), 6 deletions(-) > Reviewed-by: John Ferlan John -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 08/12] qemu: domain: Extract setup for disk source secrets

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > Separate it so that it deals only with single virStorageSource, so that > it can later be reused for full backing chain support. > > Two aliases are passed since authentication is more relevant to the > 'storage backend' whereas encryption is more

Re: [libvirt] [PATCH 07/12] qemu: domain: Simplify using DAC permissions of top of backing chain

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > qemuDomainGetImageIds and qemuDomainStorageFileInit are helpful when > trying to access a virStorageSource from the qemu driver since they > figure out the correct uid and gid for the image. > > When accessing members of a backing chain the

Re: [libvirt] [PATCH 06/12] security: selinux: Take parent security label into account

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > Until now we ignored user-provided backing chains and while detecting > the code inherited labels of the parent device. With user provided > chains we should keep this functionality, so label of the parent image > in the backing chain will be applied

Re: [libvirt] [PATCH 05/12] security: dac: Take parent security label into account

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > Until now we ignored user-provided backing chains and while detecting > the code inherited labels of the parent device. With user provided > chains we should keep this functionality, so label of the parent image > in the backing chain will be applied

Re: [libvirt] RFC: how to help to detect backing chain when no backing format info in images

2017-10-26 Thread Nikolay Shirokovskiy
On 26.10.2017 17:15, Peter Krempa wrote: > On Thu, Oct 26, 2017 at 17:05:41 +0300, Nikolay Shirokovskiy wrote: >> I create transient domain with disk based on qcow2 image with 2 backing >> images. >> I specify qcow2 format explicitly for the top image and omit the backing >> chain in xml for

Re: [libvirt] [PATCH 2/2] virt-aa-helper-test: only fails go to stdout by default

2017-10-26 Thread Jamie Strandboge
On Thu, 2017-10-26 at 15:22 +0200, Christian Ehrhardt wrote: > By Default (without -d) the tests will only print Failures. > So a log should follow general "no message is a good message" style. > > But the testfw checks always emit the skip info to stdout. Instead > they should use the

Re: [libvirt] RFC: how to help to detect backing chain when no backing format info in images

2017-10-26 Thread Peter Krempa
On Thu, Oct 26, 2017 at 17:05:41 +0300, Nikolay Shirokovskiy wrote: > I create transient domain with disk based on qcow2 image with 2 backing > images. > I specify qcow2 format explicitly for the top image and omit the backing > chain in xml for create becase libvirt does not utilize this data

Re: [libvirt] [PATCH 04/12] security: selinux: Pass parent storage source into image labeling helper

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > virSecuritySELinuxSetImageLabelInternal assigns different labels to > backing chain members than to the parent image. This was done via the > 'first' flag. Convert it to passing in pointer to the parent > virStorageSource. This will allow us to use

Re: [libvirt] [PATCH 03/12] storage: Extract error reporting for broken chains

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > Simplify reporting the error if backing chain is broken for further > callers by extracting it into a separate function. > --- > src/storage/storage_source.c | 47 > +++- > src/storage/storage_source.h | 4

Re: [libvirt] [PATCH 02/12] storage: Add feature check for storage file backend supporting access check

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > When the user provides backing chain, we don't need the full support for > traversing the backing chain. This patch adds a feature check for the > virStorageSourceAccess API. > --- > src/storage/storage_source.c | 20 >

Re: [libvirt] [PATCH 1/2] virt-aa-helper: apparmor wildcards to forbidden chars

2017-10-26 Thread Jamie Strandboge
On Thu, 2017-10-26 at 15:22 +0200, Christian Ehrhardt wrote: > Some globbing chars in the domain name could be used to break out of > apparmor rules, so lets forbid these when in virt-aa-helper. > > Also adding a test to ensure all those cases were detected as bad > char. > > Signed-off-by:

Re: [libvirt] [PATCH 01/12] storage: Extract common code to retrieve driver backend for support check

2017-10-26 Thread John Ferlan
On 10/20/2017 09:47 AM, Peter Krempa wrote: > The 'file access' module of the storage driver has few feature checks to > determine whether libvirt supports given storage driver method. The code > to retrieve the driver struct needed for the check is the same so it can > be extracted. > --- >

[libvirt] RFC: how to help to detect backing chain when no backing format info in images

2017-10-26 Thread Nikolay Shirokovskiy
I create transient domain with disk based on qcow2 image with 2 backing images. I specify qcow2 format explicitly for the top image and omit the backing chain in xml for create becase libvirt does not utilize this data anyway. Top image and its backing file don't have backing file format

Re: [libvirt] [PATCH] AppArmor: add rules needed with additional mediation features brought by Linux 4.14.

2017-10-26 Thread Jamie Strandboge
On Thu, 2017-10-26 at 08:39 -0500, Jamie Strandboge wrote: > On Thu, 2017-10-26 at 10:22 +, intrigeri+libv...@boum.org wrote: > > diff --git a/examples/apparmor/usr.sbin.libvirtd > > b/examples/apparmor/usr.sbin.libvirtd > > index 819068ffc3..eb24726e08 100644 > > ---

Re: [libvirt] [PATCH] AppArmor: add rules needed with additional mediation features brought by Linux 4.14.

2017-10-26 Thread Jamie Strandboge
On Thu, 2017-10-26 at 10:22 +, intrigeri+libv...@boum.org wrote: > From: intrigeri > > --- > examples/apparmor/libvirt-qemu | 2 ++ > examples/apparmor/usr.sbin.libvirtd | 6 ++ > 2 files changed, 8 insertions(+) > > diff --git

Re: [libvirt] [PATCH] qemu: treat iso images as raw

2017-10-26 Thread Peter Krempa
On Thu, Oct 26, 2017 at 16:22:37 +0300, Nikolay Shirokovskiy wrote: > > > On 26.10.2017 16:18, Peter Krempa wrote: > > On Thu, Oct 26, 2017 at 13:09:25 +0100, Daniel Berrange wrote: > >> On Thu, Oct 26, 2017 at 03:04:08PM +0300, Nikolay Shirokovskiy wrote: > >>> if image format probing is on and

Re: [libvirt] [PATCH] qemu: treat iso images as raw

2017-10-26 Thread Nikolay Shirokovskiy
On 26.10.2017 16:18, Peter Krempa wrote: > On Thu, Oct 26, 2017 at 13:09:25 +0100, Daniel Berrange wrote: >> On Thu, Oct 26, 2017 at 03:04:08PM +0300, Nikolay Shirokovskiy wrote: >>> if image format probing is on and image format of iso file >>> is not specified qemu fail to start a domain or

[libvirt] [PATCH 2/2] virt-aa-helper-test: only fails go to stdout by default

2017-10-26 Thread Christian Ehrhardt
By Default (without -d) the tests will only print Failures. So a log should follow general "no message is a good message" style. But the testfw checks always emit the skip info to stdout. Instead they should use the redirection that is controlled by -d. This avoids mesages like the following to

[libvirt] [PATCH 0/2] virt-aa-helper cleanups

2017-10-26 Thread Christian Ehrhardt
As follow up to [1] some smaller extensions and fixups to virt-aa-helper and its tests. [1]: https://www.redhat.com/archives/libvir-list/2017-October/msg01161.html Christian Ehrhardt (2): virt-aa-helper: apparmor wildcards to forbidden chars virt-aa-helper-test: only fails go to stdout by

[libvirt] [PATCH 1/2] virt-aa-helper: apparmor wildcards to forbidden chars

2017-10-26 Thread Christian Ehrhardt
Some globbing chars in the domain name could be used to break out of apparmor rules, so lets forbid these when in virt-aa-helper. Also adding a test to ensure all those cases were detected as bad char. Signed-off-by: Christian Ehrhardt ---

Re: [libvirt] [PATCH 3/4] virt-aa-helper: allow spaces in vm names

2017-10-26 Thread Christian Ehrhardt
On Wed, Oct 25, 2017 at 8:48 PM, Jamie Strandboge wrote: > On Wed, 2017-09-20 at 16:59 +0200, Christian Ehrhardt wrote: > > libvirt allows spaces in vm names, there were issues in the past but > > it > > seems not removed so the assumption has to be that spaces are > >

Re: [libvirt] [PATCH] qemu: treat iso images as raw

2017-10-26 Thread Peter Krempa
On Thu, Oct 26, 2017 at 13:09:25 +0100, Daniel Berrange wrote: > On Thu, Oct 26, 2017 at 03:04:08PM +0300, Nikolay Shirokovskiy wrote: > > if image format probing is on and image format of iso file > > is not specified qemu fail to start a domain or change disk > > media giving errors like [1].

Re: [libvirt] [PATCH v3 2/2] virtlogd: add missing netserver refcount increment on reload

2017-10-26 Thread John Ferlan
On 10/25/2017 05:48 AM, John Ferlan wrote: > > > On 10/25/2017 05:15 AM, Nikolay Shirokovskiy wrote: >> >> >> On 25.10.2017 12:06, John Ferlan wrote: >>> >>> >>> On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote: After virNetDaemonAddServerPostExec call in virtlogd we should have

Re: [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-26 Thread Cornelia Huck
On Fri, 20 Oct 2017 16:54:37 +0200 Christian Borntraeger wrote: > Starting a guest with > > hvm > > > > on an IBM z14 results in > > "qemu-system-s390x: Some features requested in the CPU model are not > available in the configuration: gs" > > This is

Re: [libvirt] [[RFC] 0/8] Implement async QEMU event handling in libvirtd.

2017-10-26 Thread Daniel P. Berrange
On Tue, Oct 24, 2017 at 10:34:53AM -0700, Prerna Saxena wrote: > > As noted in > https://www.redhat.com/archives/libvir-list/2017-May/msg00016.html > libvirt-QEMU driver handles all async events from the main loop. > Each event handling needs the per-VM lock to make forward progress. In > the

Re: [libvirt] [PATCH] qemu: treat iso images as raw

2017-10-26 Thread Daniel P. Berrange
On Thu, Oct 26, 2017 at 03:04:08PM +0300, Nikolay Shirokovskiy wrote: > if image format probing is on and image format of iso file > is not specified qemu fail to start a domain or change disk > media giving errors like [1]. The problem is format is being > detected as 'iso' and qemu expect format

[libvirt] [PATCH] qemu: treat iso images as raw

2017-10-26 Thread Nikolay Shirokovskiy
if image format probing is on and image format of iso file is not specified qemu fail to start a domain or change disk media giving errors like [1]. The problem is format is being detected as 'iso' and qemu expect format to be raw for iso images. It makes sense to me because iso refers to

Re: [libvirt] [PATCH] virt-aa-helper: grant locking permission on -f

2017-10-26 Thread Michal Privoznik
On 10/24/2017 04:54 PM, Christian Ehrhardt wrote: > Hot-adding disks does not parse the full XML to generate apparmor rules. > Instead it uses -f to append a generic rule for that file path. > > 580cdaa7: "virt-aa-helper: locking disk files for qemu 2.10" implemented > the qemu 2.10 requirement

Re: [libvirt] [PATCH] virt-aa-helper: fix libusb access to udev usb descriptions

2017-10-26 Thread Michal Privoznik
On 10/25/2017 02:42 PM, Christian Ehrhardt wrote: > In bf3a4140 "virt-aa-helper: fix libusb access to udev usb data" the > libusb access to properly detect the device/bus ids was fixed. > > The path /run/udev/data/+usb* contains a subset of that information we > already allow to be read and are

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-26 Thread Halil Pasic
On 10/26/2017 10:13 AM, Christian Borntraeger wrote: > > > On 10/26/2017 01:35 AM, Halil Pasic wrote: > try the most interesting scenarios out. >> >> The idea of the patch is very clear, but I don't understand the bigger gs >> feature context fully. >> >> From what I read in the code, the

Re: [libvirt] Libvirt xl to xml converter only picks up first occurrence of an option

2017-10-26 Thread Wei Liu
On Wed, Oct 25, 2017 at 02:53:01PM -0600, Jim Fehlig wrote: > On 10/20/2017 08:46 AM, Wei Liu wrote: > > Hi Jim > > Hi Wei, > > Sorry for the delay. Catching up on mail after some days off... > > > I discovered that libvirt's native config file to xml converter for > > libxl only pick up the

Re: [libvirt] [PATCH] conf: Avoid leaking blockers from virDomainCapsCPUModel

2017-10-26 Thread Pavel Hrdina
On Thu, Oct 26, 2017 at 12:22:59PM +0200, Jiri Denemark wrote: > When adding CPU usability blockers I forgot to properly free them when > in virDomainCapsCPUModelsDispose. > > Reported-by: Marc Hartmayer > Signed-off-by: Jiri Denemark > --- >

Re: [libvirt] [PATCH] spec: Enable unit tests during build

2017-10-26 Thread Michal Privoznik
On 10/20/2017 01:51 PM, mka...@redhat.com wrote: > From: Marek Kasik > > Enable unit tests so that we can catch some problems soon enough > before the package gets to the users. > > https://bugzilla.redhat.com/show_bug.cgi?id=1502639 > --- > libvirt-glib.spec.in | 3 +++ > 1

Re: [libvirt] [PATCH 0/2] Further Increase default file handle limits

2017-10-26 Thread Michal Privoznik
On 10/18/2017 11:19 AM, Christian Ehrhardt wrote: > In 27cd7635 new default limits were set: > Author: Daniel P. Berrange > Date: Wed Mar 15 16:51:51 2017 + > > Increase default file handle limits for daemons > > But I faced some constraints with these values

Re: [libvirt] [PATCH v2 02/22] conf: Add usability blockers to virDomainCapsCPUModel

2017-10-26 Thread Jiri Denemark
On Wed, Oct 25, 2017 at 10:56:51 +0200, Marc Hartmayer wrote: > On Fri, Oct 13, 2017 at 08:14 PM +0200, Jiri Denemark > wrote: > > When a hypervisor marks a CPU model as unusable on the current host, it > > may also give us a list of features which prevent the model from

[libvirt] [PATCH] conf: Avoid leaking blockers from virDomainCapsCPUModel

2017-10-26 Thread Jiri Denemark
When adding CPU usability blockers I forgot to properly free them when in virDomainCapsCPUModelsDispose. Reported-by: Marc Hartmayer Signed-off-by: Jiri Denemark --- src/conf/domain_capabilities.c | 4 +++- 1 file changed, 3 insertions(+), 1

[libvirt] [PATCH] AppArmor: add rules needed with additional mediation features brought by Linux 4.14.

2017-10-26 Thread intrigeri+libvirt
From: intrigeri --- examples/apparmor/libvirt-qemu | 2 ++ examples/apparmor/usr.sbin.libvirtd | 6 ++ 2 files changed, 8 insertions(+) diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu index b341e31f42..5994a35042 100644 ---

[libvirt] [PATCH v2] AppArmor: add rules needed with additional mediation features brought by Linux 4.14.

2017-10-26 Thread intrigeri+libvirt
[PATCH v2] AppArmor: add rules needed with additional mediation features Changes since v1: - remove unneeded "network unix" rules added by v1: they were only needed due to a bug in apparmor_parser, that was fixed in AppArmor 2.11.1 since then; - move the "network netlink raw" rule to

[libvirt] [PATCH] docs: Drop mention that WWN for disks must be unique

2017-10-26 Thread Peter Krempa
For multipath disks it might be useful to have the same WWN for multiple disks. It's the users choice to do so. Since we dropped the check that disallows using duplicate WWNs drop the docs as well. https://bugzilla.redhat.com/show_bug.cgi?id=1464975 --- Pushed as trivial.

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-26 Thread Christian Borntraeger
On 10/26/2017 01:35 AM, Halil Pasic wrote: try the most interesting scenarios out. > > The idea of the patch is very clear, but I don't understand the bigger gs > feature context fully. > > From what I read in the code, the attempt to enable the gs capability in > the kernel is made

Re: [libvirt] [[RFC] 0/8] Implement async QEMU event handling in libvirtd.

2017-10-26 Thread Peter Krempa
On Thu, Oct 26, 2017 at 10:21:17 +0530, Prerna wrote: > On Wed, Oct 25, 2017 at 4:12 PM, Jiri Denemark wrote: > > On Tue, Oct 24, 2017 at 10:34:53 -0700, Prerna Saxena wrote: [...] > > > Patch Series status: > > > Strictly RFC only. No compilation issues. I have not had a

Re: [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

2017-10-26 Thread David Hildenbrand
On 25.10.2017 18:45, Marc Hartmayer wrote: > On Wed, Oct 25, 2017 at 05:50 PM +0200, David Hildenbrand > wrote: >> On 25.10.2017 17:09, Boris Fiuczynski wrote: >>> On 10/25/2017 12:23 PM, David Hildenbrand wrote: On 25.10.2017 12:18, Christian Borntraeger wrote: >

[libvirt] Plans for next release

2017-10-26 Thread Daniel Veillard
Hi all, we are getting close to the end of the month, and I think we should enter freeze over the week-end. Then I can try to push an RC2 on Tuesday and make the GA release on the 2nd Nov (I'm travelling ATM and Nov 1st is closed, not sure I could do this that day). Hope this works for

Re: [libvirt] [PATCH v2 3/3] vbox: Read runtime RDP port and handle autoport

2017-10-26 Thread John Ferlan
On 10/25/2017 05:54 PM, Dawid Zamirski wrote: > On Wed, 2017-10-25 at 17:35 -0400, John Ferlan wrote: >> >> On 10/24/2017 05:09 PM, Dawid Zamirski wrote: >>> VirutalBox has a IVRDEServerInfo structure available that >>> gives the effective runtime port that the VM is using when it's >>> running.

Re: [libvirt] [PATCH] qemu: logrotate: drop minsize directive

2017-10-26 Thread Daniel P. Berrange
On Wed, Oct 25, 2017 at 03:30:46PM -0600, Jim Fehlig wrote: > On a cloud host it is possible to create 100's of unique instances > per day, each leaving behind a /var/log/libvirt/qemu/instance-name.log > file that is < 100k. With the current 'minsize 100k' directive, these > files are never