[libvirt] [PATCH v3] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

directory /var/lib alway is Persistence directory, but in redhat system, /var/run is memory directory. our running domain xml is saved at /var/run/libvirt/qemu. so if we cold reset system, the /var/run/libvirt/qemu directory is clear, but /var/lib/libvirt/qemu/domain-*** is saved., so there

[libvirt] 答复: [PATCH] remote: Fix libvirtd service memory leak when libvirt client was terminated unexpectly

ping -邮件原件- 发件人: Caoxinhua 发送时间: 2017年10月24日 13:52 收件人: libvir-list@redhat.com; jfer...@redhat.com; mklet...@redhat.com; berra...@redhat.com 抄送: Huangweidong (C); Yanqiangjun; weifuqiang; Wangjing (King, Euler); Caoxinhua 主题: [PATCH] remote: Fix libvirtd service memory leak when libvirt

[libvirt] 答复: [PATCH] fix libvirtd memory leak when client was killed by user at eventRegister sense

Sorry ,This is our inner patch. Sorry for disturb every one -邮件原件- 发件人: Caoxinhua 发送时间: 2017年10月28日 9:24 收件人: libvir-list@redhat.com; jfer...@redhat.com; mklet...@redhat.com; berra...@redhat.com 抄送: Huangweidong (C); Yanqiangjun; weifuqiang; Wangjing (King, Euler); Caoxinhua 主题: [PATCH]

[libvirt] [PATCH] fix libvirtd memory leak when client was killed by user at eventRegister sense

【DTS/AR】:DTS2017102200357 【description】:当客户端注册libvirt事件后，将客户端进程Kill，libvirtd服务端会有内存泄露。 Change-Id: I7eeffb4f1ba46038cd41fd26e6725ad2943229a8 --- daemon/remote.c | 52 1 file changed, 32 insertions(+), 20 deletions(-) diff --git

Re: [libvirt] [PATCH dbus] Run system instance as an unprivileged user account

On Fri, Oct 27, 2017 at 04:35:39PM +0200, Pino Toscano wrote: > On Friday, 27 October 2017 16:18:42 CEST Daniel P. Berrange wrote: > > There is no reason for the libvirt-dbus daemon to require root privileges. > > All > > it actually needs is ability to connect to libvirtd, which can be achieved

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 07:12 PM, Jiri Denemark wrote: > On Fri, Oct 27, 2017 at 17:18:44 +0200, Halil Pasic wrote: >> On 10/27/2017 04:06 PM, Christian Borntraeger wrote: > ... >>> I talked to several people and it seems that on x86 the host model will >>> also enable new features >>> that are not known

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On Fri, Oct 27, 2017 at 17:18:44 +0200, Halil Pasic wrote: > On 10/27/2017 04:06 PM, Christian Borntraeger wrote: ... > > I talked to several people and it seems that on x86 the host model will > > also enable new features > > that are not known by older QEMUs and its considered works as

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 04:06 PM, Christian Borntraeger wrote: > > > On 10/27/2017 03:40 PM, Halil Pasic wrote: >> >> >> On 10/27/2017 02:57 PM, Christian Borntraeger wrote: >>> >>> >>> On 10/27/2017 02:45 PM, Christian Borntraeger wrote: On 10/27/2017 02:31 PM, Halil Pasic wrote: gs

Re: [libvirt] [PATCH v3 REBASE v2 1/2] qemu: prepare blockjob complete event error usage

On Fri, Oct 27, 2017 at 15:37:22 +0300, Nikolay Shirokovskiy wrote: > This patch pass event error up to the place where we can > use it. Error is passed only for sync blockjob event mode > as we can't use the error in async mode. In async mode we > just pass the event details to the client thru

Re: [libvirt] [PATCH dbus] Run system instance as an unprivileged user account

On Friday, 27 October 2017 16:18:42 CEST Daniel P. Berrange wrote: > There is no reason for the libvirt-dbus daemon to require root privileges. All > it actually needs is ability to connect to libvirtd, which can be achieved by > dropping in a polkit configuration file > > Now a libvirt

Re: [libvirt] [PATCH dbus 0/5] Harden the build process

On Fri, Oct 27, 2017 at 02:31:38PM +0100, Daniel P. Berrange wrote: > This hardens the build process by turning on all possible compiler flags and > enabling features like relro and PIE. > > Daniel P. Berrange (5): > util: don't inline virtDBusUtilVirDomainListFreep > src: annotate parameters

[libvirt] [PATCH dbus] Run system instance as an unprivileged user account

There is no reason for the libvirt-dbus daemon to require root privileges. All it actually needs is ability to connect to libvirtd, which can be achieved by dropping in a polkit configuration file Now a libvirt connection to the system bus gives you privileges equivalent to root, so this doesn't

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 03:40 PM, Halil Pasic wrote: > > > On 10/27/2017 02:57 PM, Christian Borntraeger wrote: >> >> >> On 10/27/2017 02:45 PM, Christian Borntraeger wrote: >>> >>> >>> On 10/27/2017 02:31 PM, Halil Pasic wrote: >>> gs is explicitly disabled. Now that I think about it, maybe

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 03:31 PM, Cornelia Huck wrote: > On Fri, 27 Oct 2017 14:42:57 +0200 > Christian Borntraeger wrote: > >> Yes, we should also replace that with >> >> return s390_has_feat(S390_FEAT_GUARDED_STORAGE) >> >> I can fixup my patch or provide a 2nd one. >> > >

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 02:57 PM, Christian Borntraeger wrote: > > > On 10/27/2017 02:45 PM, Christian Borntraeger wrote: >> >> >> On 10/27/2017 02:31 PM, Halil Pasic wrote: >> gs is explicitly disabled. >>> >>> Now that I think about it, maybe the 2.9 binary is going to reject >>> the explicit gs flag

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On Fri, 27 Oct 2017 14:42:57 +0200 Christian Borntraeger wrote: > Yes, we should also replace that with > > return s390_has_feat(S390_FEAT_GUARDED_STORAGE) > > I can fixup my patch or provide a 2nd one. > Consider a fixed up patch acked by me. -- libvir-list mailing

[libvirt] [PATCH dbus 4/5] Enable full RELRO mode

By passing the flags -z relro -z now to the linker, we can force it to resolve all library symbols at startup, instead of on-demand. This allows it to then make the global offset table (GOT) read-only, which makes some security attacks harder. Signed-off-by: Daniel P. Berrange

[libvirt] [PATCH dbus 0/5] Harden the build process

This hardens the build process by turning on all possible compiler flags and enabling features like relro and PIE. Daniel P. Berrange (5): util: don't inline virtDBusUtilVirDomainListFreep src: annotate parameters that are unused in functions build: turn on all practical compiler warning

[libvirt] [PATCH dbus 3/5] build: turn on all practical compiler warning flags

Signed-off-by: Daniel P. Berrange --- .gitignore | 1 + Makefile.am | 2 + configure.ac| 3 + m4/manywarnings.m4 | 276 m4/virt-arg.m4 | 154

[libvirt] [PATCH dbus 5/5] Build all binaries with PIE

PIE (position independent executable) adds security to executables by composing them entirely of position-independent code (PIC. The .so libraries already build with -fPIC. This adds -fPIE which is the equivalent to -fPIC, but for executables. This for allows Exec Shield to use address space

[libvirt] [PATCH dbus 2/5] src: annotate parameters that are unused in functions

Introduce a VIR_ATTR_UNUSED macro to annotate parameters that are unused in functions. Signed-off-by: Daniel P. Berrange --- src/domain.c | 78 +-- src/events.c | 12 - src/main.c| 12 -

[libvirt] [PATCH dbus 1/5] util: don't inline virtDBusUtilVirDomainListFreep

When building GCC reports that it'll never inline this method, so don't mark it status+inline as that will cause multiple instances of it to be defined in each source file that includes util.h In file included from manager.c:4:0: manager.c: In function ‘virtDBusManagerEnumarateDomains’:

Re: [libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

On Fri, Oct 27, 2017 at 18:47:51 +0530, Madhu Pavan wrote: > On 10/27/2017 02:51 PM, Jiri Denemark wrote: > > I think this is actually a bit more complicated. When reverting to a > > snapshot, when reverting a snapshot we should revert both active and > > inactive configuration for backward

Re: [libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

On 10/27/2017 02:51 PM, Jiri Denemark wrote: On Fri, Oct 27, 2017 at 14:02:23 +0530, Kothapally Madhu Pavan wrote: Restoring to a snapshot should not overwrite the persistent configuration xml of a snapshot as a side effect. This patch fixes the same. Currently, virDomainSnapshotDef only

Re: [libvirt] [jenkins-ci PATCH v2 0/4] Expand test matrix, plus cleanups

On Fri, Oct 27, 2017 at 02:43:26PM +0200, Andrea Bolognani wrote: > Changes from [v1]: > > * don't move project-specific environment variables to the default > check_env. > > [v1] https://www.redhat.com/archives/libvir-list/2017-October/msg01256.html > > Andrea Bolognani (4): > README:

Re: [libvirt] [PATCH] qemuhotplugtest: Test user supplied alias

On 10/23/2017 09:10 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > tests/qemuhotplugtest.c| 6 +++ > .../qemuhotplug-watchdog-user-alias-full.xml | 4 ++ > .../qemuhotplug-watchdog-user-alias.xml| 3 ++ >

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 02:45 PM, Christian Borntraeger wrote: > > > On 10/27/2017 02:31 PM, Halil Pasic wrote: > gs is explicitly disabled. >> >> Now that I think about it, maybe the 2.9 binary is going to reject >> the explicit gs flag altogether, because it's unknown. >> >> Isn't this a problem? >

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 02:31 PM, Halil Pasic wrote: gs is explicitly disabled. > > Now that I think about it, maybe the 2.9 binary is going to reject > the explicit gs flag altogether, because it's unknown. > > Isn't this a problem? No. This is exactly the _solution_ and not the problem. The target

[libvirt] [jenkins-ci PATCH v2 4/4] projects: Expand test matrix

We're limiting builds to CentOS and Fedora, or even just Fedora, in a lot of cases where the project builds just fine on Debian and even FreeBSD. Let's build all the things on all the operating systems! Signed-off-by: Andrea Bolognani --- projects/libosinfo.yaml | 4

[libvirt] [jenkins-ci PATCH v2 2/4] jobs: Move check_env defaults

We have a place specifically for defaults, so make use of it instead of setting the default in two separate places. Signed-off-by: Andrea Bolognani --- jobs/autotools.yaml | 1 - jobs/defaults.yaml | 1 + jobs/go.yaml| 1 - 3 files changed, 1 insertion(+), 2

[libvirt] [jenkins-ci PATCH v2 0/4] Expand test matrix, plus cleanups

Changes from [v1]: * don't move project-specific environment variables to the default check_env. [v1] https://www.redhat.com/archives/libvir-list/2017-October/msg01256.html Andrea Bolognani (4): README: Update, expand and convert to Markdown jobs: Move check_env defaults projects:

[libvirt] [jenkins-ci PATCH v2 1/4] README: Update, expand and convert to Markdown

The documentation is not very extensive, plus the documented commands don't really work anymore now that the guests/ directory has been added. Move to Markdown while at it, since it's a much nicer format than whatever ad-hoc pseudo-markup we're using now. Signed-off-by: Andrea Bolognani

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 02:31 PM, Halil Pasic wrote: > > > On 10/25/2017 08:13 PM, Jason J. Herne wrote: >> On 10/20/2017 10:54 AM, Christian Borntraeger wrote: >>> Starting a guest with >>>     >>> hvm >>>    >>>    >>> >>> on an IBM z14 results in >>> >>> "qemu-system-s390x: Some features

[libvirt] [jenkins-ci PATCH v2 3/4] projects: Set $OSINFO_SYSTEM_DIR in check_env

This environment variable is only used when running the test suite, so we can move it from make_env to check_env: doing so allows us to remove duplicated code used to set $MAKE in the libosinfo project. Signed-off-by: Andrea Bolognani --- projects/libosinfo.yaml | 7 +--

[libvirt] [PATCH v3 REBASE v2 2/2] qemu: report drive mirror errors on migration

--- src/qemu/qemu_blockjob.c | 14 +--- src/qemu/qemu_blockjob.h | 3 ++- src/qemu/qemu_driver.c| 4 ++-- src/qemu/qemu_migration.c | 55 +-- 4 files changed, 54 insertions(+), 22 deletions(-) diff --git a/src/qemu/qemu_blockjob.c

[libvirt] [PATCH v3 REBASE v2 0/2] qemu: report block job errors from qemu to the user

So that you can see nice report on migration: "error: operation failed: migration of disk sda failed: No space left on device" diff from v2: 1. split into 2 patches 2. change formal documentation where it is present accordingly 3. add variable initialization for safety Nikolay

Re: [libvirt] [PATCH v3 RESEND] vhost-user: add support reconnect for vhost-user ports

On 10/09/2017 02:19 AM, ZhiPeng Lu wrote: > For vhost-user ports, Open vSwitch acts as the server and QEMU the client. > When OVS crashes or restarts, the QEMU process should be reconnected to > OVS. > > Signed-off-by: ZhiPeng Lu > --- > docs/schemas/domaincommon.rng

[libvirt] [PATCH v3 REBASE v2 1/2] qemu: prepare blockjob complete event error usage

This patch pass event error up to the place where we can use it. Error is passed only for sync blockjob event mode as we can't use the error in async mode. In async mode we just pass the event details to the client thru event API but current blockjob event API can not carry extra parameter. ---

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/25/2017 08:13 PM, Jason J. Herne wrote: > On 10/20/2017 10:54 AM, Christian Borntraeger wrote: >> Starting a guest with >>     >> hvm >>    >>    >> >> on an IBM z14 results in >> >> "qemu-system-s390x: Some features requested in the CPU model are not >> available in the

Re: [libvirt] [PATCH v4 1/2] rpc: When adding srv to dmn servers, need to add ref

On 27.10.2017 14:29, Nikolay Shirokovskiy wrote: > > > On 27.10.2017 13:44, John Ferlan wrote: >> >> >> On 10/27/2017 02:29 AM, Nikolay Shirokovskiy wrote: >>> >>> >>> On 27.10.2017 08:26, John Ferlan wrote: From: Nikolay Shirokovskiy Commit id

Re: [libvirt] [PATCH v3 2/2] virtlogd: add missing netserver refcount increment on reload

On Thu, Oct 26, 2017 at 09:14:02AM -0400, John Ferlan wrote: > > > On 10/25/2017 05:48 AM, John Ferlan wrote: > > > > > > On 10/25/2017 05:15 AM, Nikolay Shirokovskiy wrote: > >> > >> > >> On 25.10.2017 12:06, John Ferlan wrote: > >>> > >>> > >>> On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote:

Re: [libvirt] [PATCH v4 1/2] rpc: When adding srv to dmn servers, need to add ref

On 27.10.2017 14:20, John Ferlan wrote: > > > On 10/27/2017 02:29 AM, Nikolay Shirokovskiy wrote: >> >> >> On 27.10.2017 08:26, John Ferlan wrote: >>> From: Nikolay Shirokovskiy >>> >>> Commit id '252610f7d' modified net server management to use a >>> hash table

Re: [libvirt] [PATCH v4 1/2] rpc: When adding srv to dmn servers, need to add ref

On 27.10.2017 13:44, John Ferlan wrote: > > > On 10/27/2017 02:29 AM, Nikolay Shirokovskiy wrote: >> >> >> On 27.10.2017 08:26, John Ferlan wrote: >>> From: Nikolay Shirokovskiy >>> >>> Commit id '252610f7d' modified net server management to use a >>> hash table

Re: [libvirt] [PATCH v4 1/2] rpc: When adding srv to dmn servers, need to add ref

On 10/27/2017 02:29 AM, Nikolay Shirokovskiy wrote: > > > On 27.10.2017 08:26, John Ferlan wrote: >> From: Nikolay Shirokovskiy >> >> Commit id '252610f7d' modified net server management to use a >> hash table to store/manage the various servers; however, during

Re: [libvirt] [jenkins-ci PATCH 4/5] jobs: Define $OSINFO_SYSTEM_DIR in default make_env

On Fri, 2017-10-27 at 09:20 +0100, Daniel P. Berrange wrote: > > title: libosinfo > > -make_env: | > > - MAKE='make' > > - unamestr=`uname` > > - if [ "$unamestr" = 'FreeBSD' ]; then > > - MAKE='gmake' > > - fi > > - export

Re: [libvirt] [PATCH v4 2/2] libvirtd: fix crash on termination

On 10/27/2017 02:32 AM, Nikolay Shirokovskiy wrote: > > > On 27.10.2017 08:26, John Ferlan wrote: >> From: Nikolay Shirokovskiy >> >> The problem is incorrect order of qemu driver shutdown and shutdown >> of netserver threads that serve client requests (thru qemu

Re: [libvirt] [PATCH v4 1/2] rpc: When adding srv to dmn servers, need to add ref

On 10/27/2017 02:29 AM, Nikolay Shirokovskiy wrote: > > > On 27.10.2017 08:26, John Ferlan wrote: >> From: Nikolay Shirokovskiy >> >> Commit id '252610f7d' modified net server management to use a >> hash table to store/manage the various servers; however, during

Re: [libvirt] [PATCH v3 REBASE 0/2] qemu: report block job errors from qemu to the user

On 27.10.2017 13:24, Jiri Denemark wrote: > On Wed, Oct 25, 2017 at 09:57:58 +0300, Nikolay Shirokovskiy wrote: >> ping > > Hi, > > Unfortunately the second patch is no longer applicable on the current > master. It's definitely our fault we didn't review your patches in time, > but it

Re: [libvirt] [PATCH v3 REBASE 0/2] qemu: report block job errors from qemu to the user

On Wed, Oct 25, 2017 at 09:57:58 +0300, Nikolay Shirokovskiy wrote: > ping Hi, Unfortunately the second patch is no longer applicable on the current master. It's definitely our fault we didn't review your patches in time, but it sometimes happens when people get drowned in other work. Don't

Re: [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On Thu, Oct 26, 2017 at 10:09:46 +0200, David Hildenbrand wrote: > On 25.10.2017 18:45, Marc Hartmayer wrote: > > On Wed, Oct 25, 2017 at 05:50 PM +0200, David Hildenbrand > > wrote: > >> On 25.10.2017 17:09, Boris Fiuczynski wrote: > >>> David, I disagree if your proposal is

Re: [libvirt] [PATCH] qemu.conf: Clarify the various _tls_x509_cert_dir descriptions

On 10/27/2017 11:28 AM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1458630 > > Apparantly commit id 'dc4c2f75a' wasn't specific enough, so here's > a few more clarifications. > > Signed-off-by: John Ferlan > --- > src/qemu/qemu.conf | 28

[libvirt] [PATCH] qemu.conf: Clarify the various _tls_x509_cert_dir descriptions

https://bugzilla.redhat.com/show_bug.cgi?id=1458630 Apparantly commit id 'dc4c2f75a' wasn't specific enough, so here's a few more clarifications. Signed-off-by: John Ferlan --- src/qemu/qemu.conf | 28 +--- 1 file changed, 17 insertions(+), 11

Re: [libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

On Fri, Oct 27, 2017 at 14:02:23 +0530, Kothapally Madhu Pavan wrote: > Restoring to a snapshot should not overwrite the persistent configuration > xml of a snapshot as a side effect. This patch fixes the same. Currently, > virDomainSnapshotDef only saves active domain definition of the guest. >

Re: [libvirt] 答复: [PATCH v2] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

On 10/27/2017 10:57 AM, Daniel P. Berrange wrote: > On Fri, Oct 27, 2017 at 10:25:23AM +0200, Michal Privoznik wrote: >> On 10/27/2017 03:47 AM, Caoxinhua wrote: >>> Yes,In qemuxml2argvtest case, mymain call qemuTestDriverInit to init qemu >>> driver, qemuTestDriverInit call mkdtemp() to init

Re: [libvirt] [REPOST PATCH 0/4] Add the ability to LUKS encrypt during LV creation

On 10/19/2017 03:56 PM, John Ferlan wrote: > Repost to address merge conflict from commit id '0a294a8e2' which > used if (virStorageSourceHasBacking(>target)) instead of > if (vol->target.backingStore). > > Original series: > https://www.redhat.com/archives/libvir-list/2017-October/msg00340.html

Re: [libvirt] [PATCH 4/5] storage: Properly resize a local volume using LUKS

On 10/06/2017 08:13 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1490279 > > Turns out the virStorageBackendVolResizeLocal did not differentiate > whether the target volume was a LUKS volume or not and just blindly > did the ftruncate() on the target volume. > > Follow

Re: [libvirt] [PATCH 0/5] Properly resize a local LUKS encrypted volume

On 10/06/2017 08:13 PM, John Ferlan wrote: > The patches hopefully speak for themselves. > > John Ferlan (5): > storage: Alter args to storageBackendResizeQemuImg > storage: Add error path for virStorageBackendCreateQemuImgCmdFromVol > storage: Alter storageBackendCreateQemuImgSecretObject

Re: [libvirt] [PATCH 5/5] docs: Add news article for bug fix

On 10/06/2017 08:13 PM, John Ferlan wrote: > Signed-off-by: John Ferlan > --- > docs/news.xml | 8 > 1 file changed, 8 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index ff36c800a4..116f4a76c9 100644 > --- a/docs/news.xml > +++ b/docs/news.xml > @@

Re: [libvirt] 答复: [PATCH v2] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

On Fri, Oct 27, 2017 at 10:25:23AM +0200, Michal Privoznik wrote: > On 10/27/2017 03:47 AM, Caoxinhua wrote: > > Yes,In qemuxml2argvtest case, mymain call qemuTestDriverInit to init qemu > > driver, qemuTestDriverInit call mkdtemp() to init stateDir, so stateDir is > > randomly. But '-monitor'

Re: [libvirt] [PATCH 0/2] virt-aa-helper cleanups

On 10/26/2017 03:22 PM, Christian Ehrhardt wrote: > As follow up to [1] some smaller extensions and fixups to virt-aa-helper > and its tests. > > [1]: https://www.redhat.com/archives/libvir-list/2017-October/msg01161.html > > Christian Ehrhardt (2): > virt-aa-helper: apparmor wildcards to

[libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

Restoring to a snapshot should not overwrite the persistent configuration xml of a snapshot as a side effect. This patch fixes the same. Currently, virDomainSnapshotDef only saves active domain definition of the guest. And on restore the active domain definition is used as both active and inactive

Re: [libvirt] 答复: [PATCH v2] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

On 10/27/2017 03:47 AM, Caoxinhua wrote: > Yes,In qemuxml2argvtest case, mymain call qemuTestDriverInit to init qemu > driver, qemuTestDriverInit call mkdtemp() to init stateDir, so stateDir is > randomly. But '-monitor' part of the command line must be a const value. Can > I use a const value

Re: [libvirt] [PATCH] qemu: Fix memory leak in virQEMUCapsLoadCPUModels

On Fri, Oct 27, 2017 at 09:53:03 +0200, Marc Hartmayer wrote: > Don't leak @blockNodes in the loop. > > ==226576== 7,120 bytes in 60 blocks are definitely lost in loss record 122 of > 125 > ==226576==at 0x4835214: calloc (vg_replace_malloc.c:711) > ==226576==by 0x4950D7B: virAllocN

Re: [libvirt] [jenkins-ci PATCH 4/5] jobs: Define $OSINFO_SYSTEM_DIR in default make_env

On Fri, Oct 27, 2017 at 09:48:14AM +0200, Andrea Bolognani wrote: > Althought the environment variable is only used when building > libosinfo, there is no harm in having it set in the environment > at all times; moreover, hoisting it to the default make_env > allows us to remove duplicated code

Re: [libvirt] [jenkins-ci PATCH 3/5] jobs: Define $VIR_TEST_{DEBUG, EXPENSIVE} in default check_env

On Fri, Oct 27, 2017 at 09:48:13AM +0200, Andrea Bolognani wrote: > Althought the environment variables are only used when running > libvirt's test suite, there is no harm in having it set in the > environment at all times. > > Signed-off-by: Andrea Bolognani > --- >

[libvirt] [PATCH] qemu: Fix memory leak in virQEMUCapsLoadCPUModels

Don't leak @blockNodes in the loop. ==226576== 7,120 bytes in 60 blocks are definitely lost in loss record 122 of 125 ==226576==at 0x4835214: calloc (vg_replace_malloc.c:711) ==226576==by 0x4950D7B: virAllocN (viralloc.c:191) ==226576==by 0x49EB5BB: virXPathNodeSet (virxml.c:676)

[libvirt] [jenkins-ci PATCH 1/5] README: Update, expand and convert to Markdown

The documentation is not very extensive, plus the documented commands don't really work anymore now that the guests/ directory has been added. Move to Markdown while at it, since it's a much nicer format than whatever ad-hoc pseudo-markup we're using now. Signed-off-by: Andrea Bolognani

[libvirt] [jenkins-ci PATCH 3/5] jobs: Define $VIR_TEST_{DEBUG, EXPENSIVE} in default check_env

Althought the environment variables are only used when running libvirt's test suite, there is no harm in having it set in the environment at all times. Signed-off-by: Andrea Bolognani --- jobs/defaults.yaml| 2 ++ projects/libvirt.yaml | 3 --- 2 files changed, 2

[libvirt] [jenkins-ci PATCH 2/5] jobs: Move check_env defaults

We have a place specifically for defaults, so make use of it instead of setting the default in two separate places. Signed-off-by: Andrea Bolognani --- jobs/autotools.yaml | 1 - jobs/defaults.yaml | 1 + jobs/go.yaml| 1 - 3 files changed, 1 insertion(+), 2

[libvirt] [jenkins-ci PATCH 5/5] projects: Expand test matrix

We're limiting builds to CentOS and Fedora, or even just Fedora, in a lot of cases where the project builds just fine on Debian and even FreeBSD. Let's build all the things on all the operating systems! Signed-off-by: Andrea Bolognani --- projects/libosinfo.yaml | 4

[libvirt] [jenkins-ci PATCH 4/5] jobs: Define $OSINFO_SYSTEM_DIR in default make_env

Althought the environment variable is only used when building libosinfo, there is no harm in having it set in the environment at all times; moreover, hoisting it to the default make_env allows us to remove duplicated code used to set $MAKE in the libosinfo project. $OSINFO_SYSTEM_DIR itself

[libvirt] [jenkins-ci PATCH 0/5] Expand test matrix, plus cleanups

Andrea Bolognani (5): README: Update, expand and convert to Markdown jobs: Move check_env defaults jobs: Define $VIR_TEST_{DEBUG,EXPENSIVE} in default check_env jobs: Define $OSINFO_SYSTEM_DIR in default make_env projects: Expand test matrix README| 34

Re: [libvirt] [PATCH v2 02/22] conf: Add usability blockers to virDomainCapsCPUModel

On Thu, Oct 26, 2017 at 12:24 PM +0200, Jiri Denemark wrote: > On Wed, Oct 25, 2017 at 10:56:51 +0200, Marc Hartmayer wrote: >> On Fri, Oct 13, 2017 at 08:14 PM +0200, Jiri Denemark >> wrote: >> > When a hypervisor marks a CPU model as unusable on the

Re: [libvirt] [jenkins-ci PATCH] guests: disable glusterfs on FreeBSD

On Fri, 2017-10-20 at 21:59 +0200, Andrea Bolognani wrote: > On Fri, 2017-10-20 at 21:49 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > guests/vars/mappings.yml | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/guests/vars/mappings.yml

Re: [libvirt] [PATCH v4 2/2] libvirtd: fix crash on termination

On 27.10.2017 08:26, John Ferlan wrote: > From: Nikolay Shirokovskiy > > The problem is incorrect order of qemu driver shutdown and shutdown > of netserver threads that serve client requests (thru qemu driver > particularly). > > Net server threads are shutdown

Re: [libvirt] [PATCH v4 1/2] rpc: When adding srv to dmn servers, need to add ref

On 27.10.2017 08:26, John Ferlan wrote: > From: Nikolay Shirokovskiy > > Commit id '252610f7d' modified net server management to use a > hash table to store/manage the various servers; however, during > virNetDaemonAddServerPostExec an @srv object is created, added