Re: [libvirt] [PATCH v2 3/3] conf: Allow users to define UUID for devices

On 10/30/2017 03:31 PM, Jim Fehlig wrote: On 10/03/2017 07:53 AM, Daniel P. Berrange wrote: On Tue, Oct 03, 2017 at 02:11:44PM +0200, Martin Kletzander wrote: On Tue, Oct 03, 2017 at 12:58:59PM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1434451 It comes handy

Re: [libvirt] [PATCH v2 3/3] conf: Allow users to define UUID for devices

On 10/03/2017 07:53 AM, Daniel P. Berrange wrote: On Tue, Oct 03, 2017 at 02:11:44PM +0200, Martin Kletzander wrote: On Tue, Oct 03, 2017 at 12:58:59PM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1434451 It comes handy for management application to be able to

Re: [libvirt] [PATCH v5 3/3] libvirtd: fix crash on termination

On Mon, Oct 30, 2017 at 07:14:39AM -0400, John Ferlan wrote: From: Nikolay Shirokovskiy The problem is incorrect order of qemu driver shutdown and shutdown of netserver threads that serve client requests (thru qemu driver particularly). Net server threads are

Re: [libvirt] Entering freeze for next release

On Mon, Oct 30, 2017 at 10:29:32AM +0100, Martin Kletzander wrote: > On Mon, Oct 30, 2017 at 09:04:28AM +0100, Daniel Veillard wrote: > > The Candidate Release 1 is tagged in git, I also pushed signed tarball > > and rpms to the usual place : > > > > ftp://libvirt.org/libvirt/ > > > > I'm

Re: [libvirt] [libvirt-glib] [PATCH v2] spec: Enable unit tests during build

On 10/30/2017 03:59 PM, Michal Privoznik wrote: On 10/30/2017 02:57 PM, mka...@redhat.com wrote: From: Marek Kasik Enable unit tests so that we can catch some problems soon enough before the package gets to the users. Show test suite log if a test fail. ---

Re: [libvirt] [libvirt-glib] [PATCH v2] spec: Enable unit tests during build

On 10/30/2017 02:57 PM, mka...@redhat.com wrote: > From: Marek Kasik > > Enable unit tests so that we can catch some problems soon enough > before the package gets to the users. > Show test suite log if a test fail. > --- > libvirt-glib.spec.in | 6 ++ > 1 file changed, 6

Re: [libvirt] [PATCH 0/2] qemu: Fix QoS for vhostuser

On 10/30/2017 11:44 AM, Martin Kletzander wrote: > On Wed, Oct 25, 2017 at 12:48:08PM +0200, Michal Privoznik wrote: >> Setting QoS on the fly does work for vhostuser. However, it doesn't when >> starting a domain. So when looking into this, I realized that we >> should be more >> explicit about

Re: [libvirt] [PATCH] spec: Enable unit tests during build

On 10/26/2017 12:41 PM, Michal Privoznik wrote: On 10/20/2017 01:51 PM, mka...@redhat.com wrote: From: Marek Kasik Enable unit tests so that we can catch some problems soon enough before the package gets to the users. https://bugzilla.redhat.com/show_bug.cgi?id=1502639 ---

[libvirt] [libvirt-glib] [PATCH v2] spec: Enable unit tests during build

From: Marek Kasik Enable unit tests so that we can catch some problems soon enough before the package gets to the users. Show test suite log if a test fail. --- libvirt-glib.spec.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libvirt-glib.spec.in

Re: [libvirt] [PATCH v5 2/3] virtlogd: add missing netserver refcount increment on reload

On Mon, Oct 30, 2017 at 07:14:38AM -0400, John Ferlan wrote: From: Nikolay Shirokovskiy After virNetDaemonAddServerPostExec call in virtlogd we should have netserver refcount set to 2. One goes to netdaemon servers hashtable and one goes to virtlogd own reference

Re: [libvirt] [PATCH v5 1/3] lockd: Need to Unref @srv when done with it.

On Mon, Oct 30, 2017 at 07:14:37AM -0400, John Ferlan wrote: Commit id '252610f7d' used a hash table to store the @srv, but didn't handle the virObjectUnref if virNetDaemonNew failed nor did it use virObjectUnref once successfully placed into the table which will now be managing it's lifetime

[libvirt] Libvirt config converter can't handle file not ending with new line

Hi Jim I discover a problem when using xen_xl converter. When the file in question doesn't end with a new line, I get the following error: error: configuration file syntax error: memory conf:53: expecting a value After digging a bit (but haven't read libvirt code), it appears that the file

Re: [libvirt] [PATCH v5 0/3] daemon: fix termination/reload issues

On 30.10.2017 14:14, John Ferlan wrote: > v4: https://www.redhat.com/archives/libvir-list/2017-October/msg01249.html > > Difference to v4 - inserted a patch to handle the Unref possibilities > in virLockDaemonNew when either the @srv is placed into the daemon > net server hash table or if

[libvirt] [PATCH] nwfilter: fix deadlock on firewalld restart/reload

Deadlock scenario: 1. domain is being started and domain driver takes read lock for nwfilter update lock thru virNWFilterReadLockFilterUpdates. 2. firewalld restarted and event loop hangs trying to take write lock for nwfilter update lock in nwfilterStateReload. This is deadlock because for

[libvirt] [PATCH v5 3/3] libvirtd: fix crash on termination

From: Nikolay Shirokovskiy The problem is incorrect order of qemu driver shutdown and shutdown of netserver threads that serve client requests (thru qemu driver particularly). Net server threads are shutdown upon dispose which is triggered by last daemon object

[libvirt] [PATCH v5 2/3] virtlogd: add missing netserver refcount increment on reload

From: Nikolay Shirokovskiy After virNetDaemonAddServerPostExec call in virtlogd we should have netserver refcount set to 2. One goes to netdaemon servers hashtable and one goes to virtlogd own reference to netserver. Let's add missing increment in

[libvirt] [PATCH v5 0/3] daemon: fix termination/reload issues

v4: https://www.redhat.com/archives/libvir-list/2017-October/msg01249.html Difference to v4 - inserted a patch to handle the Unref possibilities in virLockDaemonNew when either the @srv is placed into the daemon net server hash table or if virNetDaemonNew fails. Patch 3 has a minor change (from

[libvirt] [PATCH v5 1/3] lockd: Need to Unref @srv when done with it.

Commit id '252610f7d' used a hash table to store the @srv, but didn't handle the virObjectUnref if virNetDaemonNew failed nor did it use virObjectUnref once successfully placed into the table which will now be managing it's lifetime (and would cause the virObjectRef if successfully inserted into

Re: [libvirt] [PATCH 0/2] qemu: Fix QoS for vhostuser

On Wed, Oct 25, 2017 at 12:48:08PM +0200, Michal Privoznik wrote: Setting QoS on the fly does work for vhostuser. However, it doesn't when starting a domain. So when looking into this, I realized that we should be more explicit about types of interface that do support QoS. ACK & SFF Michal

Re: [libvirt] [PATCH 0/2] qemu: Fix QoS for vhostuser

On 10/25/2017 12:48 PM, Michal Privoznik wrote: > Setting QoS on the fly does work for vhostuser. However, it doesn't when > starting a domain. So when looking into this, I realized that we should be > more > explicit about types of interface that do support QoS. > > Michal Privoznik (2): >

Re: [libvirt] Entering freeze for next release

On Mon, Oct 30, 2017 at 09:04:28AM +0100, Daniel Veillard wrote: The Candidate Release 1 is tagged in git, I also pushed signed tarball and rpms to the usual place : ftp://libvirt.org/libvirt/ I'm travelling so not really in a position to do much testing, but

Re: [libvirt] [PATCH go-xml] Add address support for memory device

On Mon, Oct 30, 2017 at 11:05:13 +0800, zhenwei.pi wrote: > Add Base element for DomainAddress. > Add address element for DomainMemorydev. > Add test code for new DomainMemorydev. > > Signed-off-by: zhenwei.pi > --- > domain.go | 2 ++ > domain_test.go | 9

[libvirt] [PATCH dbus v2] Run system instance as an unprivileged user account

There is no reason for the libvirt-dbus daemon to require root privileges. All it actually needs is ability to connect to libvirtd, which can be achieved by dropping in a polkit configuration file Now a libvirt connection to the system bus gives you privileges equivalent to root, so this doesn't

Re: [libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

On 10/27/2017 06:51 PM, Jiri Denemark wrote: On Fri, Oct 27, 2017 at 18:47:51 +0530, Madhu Pavan wrote: On 10/27/2017 02:51 PM, Jiri Denemark wrote: I think this is actually a bit more complicated. When reverting to a snapshot, when reverting a snapshot we should revert both active and

[libvirt] [PATCH 7/7] tests: docs: Add schema and testcase for domainsnapshot

Alter the schema of domainsnapshot to add inactive XML of a snapshot. As, snapshot already has active XML configuration of domain, the inactive XMl is embedded in tags. Sample XML is: Alter the domainsnapshotxml2xmltest to validate the

[libvirt] [PATCH 6/7] virsh: Allow restoring snapshot with non-persistent configuration

Now, snapshot-restore will allow restoring snapshots with non-persistent configuration as both active and inactive XML configurations are saved in snapshot. User can discard non-persistent configuratin of a domain using --active-only flag. When --active-only flag is used, active XML configuration

[libvirt] [PATCH 3/7] conf: Allow editing inactive snapshot configuration

This patch will allow user to edit the inactive XML snapshot configuration when it is available in the snapshot. Signed-off-by: Kothapally Madhu Pavan --- include/libvirt/libvirt-domain.h | 1 + src/conf/domain_conf.c | 6 -- src/conf/domain_conf.h

[libvirt] [PATCH 2/7] qemu: Use active and inactive snapshot configuration on restore

By default, active and inactive XMl snapshot configurations are assigned to domain definition. This will make sure that all the non-persistent configurations of the snapshot are restored back as it is. This patch will also make sure that user has a choice to choose of using active XML

[libvirt] [PATCH 0/7] Keep non-persistent changes alive in snapshot

Restoring to a snapshot should not overwrite the persistent XML configuration of a snapshot as a side effect. This patchset fixes the same. Currently, virDomainSnapshotDef only saves active domain definition of the guest. And on restore the active domain definition is used as both active and

[libvirt] [PATCH 4/7] virsh: Dump inactive XML configuration of snapshot using snapshot-dumpxml

Now, snapshot-dumpxml will display inactive XML configuration of snapshot along with active XML configuration. When --active-only flag is used the inactive XML configuration will not be displayed. Signed-off-by: Kothapally Madhu Pavan --- tools/virsh-snapshot.c | 7

[libvirt] [PATCH 5/7] virsh: Edit inactive XML configuration of snapshot using snapshot-edit

Now, snapshot-edit will allow editing inactive XML configuration of snapshot along with active XML configuration. When --active-only flag is used the inactive XML will not be displayed and will be removed from snapshot. --active-only flag is used when user doesn't what any non-persistent

[libvirt] [PATCH 1/7] qemu: Store inactive domain configuration in snapshot

Inorder to capture the exact state of domain, inactive configuration is needed along with active configuration. This patch stores inactive domain configuration when creating snapshot of a running domain. It also captures the inactive snapshot configuration when a snapshot is redefined.

[libvirt] Entering freeze for next release

The Candidate Release 1 is tagged in git, I also pushed signed tarball and rpms to the usual place : ftp://libvirt.org/libvirt/ I'm travelling so not really in a position to do much testing, but https://ci.centos.org/view/libvirt/ is all green (yay!) so that sounds rather good ATM :-)

Re: [libvirt] Using XML returned from domain hook script

On Sun, Oct 29, 2017 at 08:39:08PM -0600, Jim Fehlig wrote: > Hi All, > > It may be a foolish en devour, but I'm trying to make a qemu hook script > that provides the semantics of an old, custom xen block script. The script > parses info, does some setup based on that, and then rewrites part of