On 11/03/2017 12:19 PM, Dawid Zamirski wrote:
> On Fri, 2017-11-03 at 09:43 -0400, John Ferlan wrote:
>>
>> On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
>>> This commit primes vboxAttachDrives for further changes so when
>>> they
>>> are made, the diff is less noisy:
>>>
>>> * move variable decl
Hello
Am 03.11.2017 um 08:30 schrieb Christian Ehrhardt:
> On Thu, Nov 2, 2017 at 4:34 PM, Daniel P. Berrange
> wrote:
>>
>> On Thu, Nov 02, 2017 at 04:14:06PM +0100, Christian Ehrhardt wrote:
>>> Ping - since there wasn't any reply so far - any best practices one could
>>> share?
>>>
>>> Let me
On Fri, 2017-11-03 at 09:51 -0400, John Ferlan wrote:
>
> On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> >
> > +case VIR_DOMAIN_CONTROLLER_TYPE_SCSI:
> > +VBOX_UTF8_TO_UTF16(VBOX_CONTROLLER_SCSI_NAME,
> > &controllerName);
> > +vboxBusType = StorageBus_SCSI;
> > +
> > +
On Fri, 2017-11-03 at 09:43 -0400, John Ferlan wrote:
>
> On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> > This commit primes vboxAttachDrives for further changes so when
> > they
> > are made, the diff is less noisy:
> >
> > * move variable declarations to the top of the function
> > * add disk
On Fri, 2017-11-03 at 09:51 -0400, John Ferlan wrote:
>
> On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> > This patch enables the VBOX driver to process the
> > element
> > in domain XML through which one can now customize the controller
> > model.
> >
> > Since VirtualBox has two distinct SAS
This adds the missing formatters for JSON properties for the storage.
John Ferlan (1):
qemu: block: Add JSON props generator for iSCSI protocol
This patch was stolen from the iSCSI saga and fixed, since the formatter
did not format the port number into the portal string.
Peter Krempa (11):
q
---
src/qemu/qemu_block.c | 74 +++
1 file changed, 74 insertions(+)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 451d04694..8a1ce8262 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -593,6 +593,47 @@
qemuBlock
Libvirt historically stores storage source path including the volume as
one string in the XML, but that is not really flexible enough when
dealing with the fields in the code. Previously we'd store the slash
separating the two as part of the image name. This was fine for gluster
but it's not necess
QEMU uses curl for accessing files using http(s) and ftp(s). They share
common options so let's generate them in one helper.
---
src/qemu/qemu_block.c | 63 +++
1 file changed, 59 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_block.c b/sr
Format out the node-name if it was assigned for JSON-based storage
specification.
---
src/qemu/qemu_block.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 6f6d294bf..6df0dc0fb 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block
---
src/qemu/qemu_block.c | 32
1 file changed, 32 insertions(+)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 4e588c724..451d04694 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -767,6 +767,34 @@ qemuBlockStorageSourceGetISCS
Add a new test program called 'qemublocktest' to test the block layer
related stuff and test storage source to JSON generator by comparing it
to the JSON parser.
---
tests/Makefile.am | 14 +++-
tests/qemublocktest.c | 189 ++
2 files changed, 2
---
src/qemu/qemu_block.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 8a1ce8262..5f28c4dd6 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -865,6 +865,33 @@ qemuBlockStorageSourceGetRBDPr
Original implementation used 'SocketAddress' equivalent from qemu for
the disk server field, while qemu documentation specifies
'InetSocketAddress'. The backing store parser uses the correct parsing
function but the formatter used the incorrect one (and also with the
legacy mode enabled which was w
Similarly to how we store gluster names, split the name into a pool and
image portions when paring the XML and store them separately.
---
src/conf/domain_conf.c | 13 +++--
src/libxl/libxl_conf.c | 2 +-
src/qemu/qemu_command.c
From: John Ferlan
---
src/qemu/qemu_block.c | 70 ++-
1 file changed, 69 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index dedb92fd5..4e588c724 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_bloc
Extract the part formatting the basic URI part so that it can be reused
to format JSON backing definitions. Parts specific to the command line
format will remain in qemuBuildNetworkDriveURI. The new function is
called qemuBlockStorageSourceGetURI.
---
src/qemu/qemu_block.c | 58 +
---
src/qemu/qemu_block.c | 36
1 file changed, 36 insertions(+)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 5f28c4dd6..6f6d294bf 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -892,6 +892,38 @@ qemuBlockStorageSourceGet
Signed-off-by: John Ferlan
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 1de7898c80..0a09aeba30 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -52,6 +52,16 @@
+
+
+ Securely pass iS
Reposting after 3.9.0 release and refresh to current HEAD. Had to
move the news.xml into the 3.10.0 section as well and address a
couple of merge conflicts.
Original:
https://www.redhat.com/archives/libvir-list/2017-October/msg01012.html
Copy of Original cover letter:
v5: https://www.redhat.com/
Rather than building the "file" string in qemuBuildSCSIHostdevDrvStr
build it in the called helper.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 8e
https://bugzilla.redhat.com/show_bug.cgi?id=1425757
The blockdev-add code provides a mechanism to sanely provide user
and password-secret arguments for iscsi without placing them on the
command line to be viewable by a 'ps -ef' type command or needing
to create separate -iscsi devices for each dis
Rather than picking apart the two pieces we need/want (path, hosts,
and auth)- let's allocate/use a virStorageSourcePtr for iSCSI storage.
The end result is that qemuBuildSCSIiSCSIHostdevDrvStr doesn't need
to "fake" one for the qemuBuildNetworkDriveStr call.
Signed-off-by: John Ferlan
---
src/
Signed-off-by: John Ferlan
---
docs/news.xml | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index ef855d8958..1de7898c80 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,6 +35,19 @@
+
+
+ conf: Move the auth
Since it's not longer used to shuttle the @secinfo, let's remove
the private hostdev completely.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c| 12 ++--
src/conf/domain_conf.h| 4 +---
src/lxc/lxc_native.c | 2 +-
src/qemu/qemu_domain.c| 44
Add the capability to use the blockdev-add query-qmp-schema option
to find the 'password-secret' parameter that will allow the iSCSI
code to use the master secret object to encrypt the secret for an
and only need to provide the object id of the secret on the command
line thus obsfuscating the passp
Rather than placing/using privateData about secinfo in the hostdev,
let's use the virStorageSource private data instead.
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 7 ---
src/qemu/qemu_domain.c | 24
2 files changed, 20 insertions(+), 11 deletions(-)
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> This patch adds element to each device since device
> names alone won't adequately reflect the storage device layout in the
> VM. With this patch, the ouput produced by dumpxml will faithfully
> reproduce the storage layout of the VM if used with
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> Previously any removable storage device without media attached was
> omitted from domain XML dump. They're still (rightfully) omitted in
> snapshot XMl dump but need to be accounted properly to for the device
XML
> names to stay in 'sync' between
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> Primer the code for further changes:
>
> * move variable declarations to the top of the function
> * group together free/release statements
> * error check and report VBOX API calls used
> ---
> src/vbox/vbox_common.c | 188
>
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> If a VBOX VM has e.g. a SATA and SCSI disk attached, the XML generated
> by dumpxml used to produce "sda" for both of those disks. This is an
> invalid domain XML as libvirt does not allow duplicate device names. To
> address this, keep the running
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> ---
> src/vbox/vbox_common.c | 119
> +
> 1 file changed, 119 insertions(+)
>
> diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c
> index 9d45e4a76..715eb670e 100644
> --- a/src/vbox/vbox
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> This patch enables the VBOX driver to process the element
> in domain XML through which one can now customize the controller model.
>
> Since VirtualBox has two distinct SAS and SCSI they do not "map"
> directly to libvirt XML, he VBOX driver uses
On Thu, Nov 02, 2017 at 08:29:44PM +0100, Jiri Denemark wrote:
> Linux kernel shows our "cmt" feature as "cqm". Let's mention the name in
> the cpu_map.xml to make it easier to find.
Thanks! Wasted a few hours looking for the wrong flag the other day.
> Signed-off-by: Jiri Denemark
> ---
> src
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> The optional values are 'piix3', 'piix4' or 'ich6'. Those will be
> needed to allow setting IDE controller model in VirtualBox driver.
> ---
> docs/formatdomain.html.in | 4
> docs/schemas/domaincommon.rng | 18 --
> src/c
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> This patch exposes additional methods of the native VBOX API to the
> libvirt 'unified' vbox API to deal with IStorageController. The exposed
> methods are:
>
> * IStorageController->GetStorageControllerType()
> * IStorageController->SetStorageCont
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> This commit primes vboxAttachDrives for further changes so when they
> are made, the diff is less noisy:
>
> * move variable declarations to the top of the function
> * add disk variable to replace all the def->disks[i] instances
> * add cleanup at
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> Original code was checking for non empty disk source before proceeding
> to actually attach disk device to VM. This prevented from creating
> empty removable devices like DVD or floppy. Therefore, this patch
> re-organizes the loop work-flow to allo
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> Previously, the driver was computing VBOX's devicePort/deviceSlot values
> based on device name and max port/slot values. While this worked, it
> completely ignored values. Additionally, libvirt's built-in
> virDomainDiskDefAssignAddress already do
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> Previously, if one tried to define a VBOX VM and the API failed to
> perform the requested actions for some reason, it would just log the
> error and move on to process remaining disk definitions. This is not
> desired as it could result in incorrec
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> Since the VBOX API requires to register an initial VM before proceeding
> to attach any remaining devices to it, any failure to attach such
> devices should result in automatic cleanup of the initially registered
> VM so that the state of VBOX regis
On Fri, Nov 03, 2017 at 01:03:28PM +0100, Peter Krempa wrote:
Kill some ugly code.
Peter Krempa (9):
util: Fix condition check in virDiskNameToIndex
qemu: command: Remove dead code when formatting -drive
qemu: command: Move disk index validation closer to usage
qemu: command: Directly report
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> When registering a VM we call OpenMedium on each disk image which adds it
> to vbox's global media registry. Therefore, we should make sure to call
> Close when unregistering VM so we cleanup the media registry entries
> after ourselves - this does
On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> Since the removal of VBOX <= 3x, the function arguments are actually
> used so they should not be marked with ATTRIBUTE_UNUSED anymore.
> ---
> src/vbox/vbox_tmpl.c | 49 +++--
> 1 file changed, 23 insert
On Fri, Nov 03, 2017 at 01:03:35PM +0100, Peter Krempa wrote:
To allow agregating the checks, refactor the code to check capabilities
aggregating
only if they were provided.
---
src/qemu/qemu_command.c | 96 +++--
1 file changed, 53 insertions(+), 43
On Fri, Nov 03, 2017 at 01:03:34PM +0100, Peter Krempa wrote:
Stash all the disk definition and capability checks into one function.
---
src/qemu/qemu_command.c | 324
src/qemu/qemu_command.h | 3 +-
src/qemu/qemu_driver.c | 2 +-
3 files changed
On Fri, Nov 03, 2017 at 01:03:32PM +0100, Peter Krempa wrote:
All of the error message are already in a conditional block with known
bus type. Inline the bus type rather than formatting it from a separate
variable.
---
src/qemu/qemu_command.c | 21 ++---
1 file changed, 10 insertio
On Thu, Nov 02, 2017 at 09:03:15PM +0100, Jiri Denemark wrote:
When coverage build is enabled, gcc complains about it:
In file included from qemu/qemu_agent.h:29:0,
from qemu/qemu_driver.c:47:
qemu/qemu_driver.c: In function 'qemuDomainSetInterfaceParameters':
./conf/domain_conf.
To allow agregating the checks, refactor the code to check capabilities
only if they were provided.
---
src/qemu/qemu_command.c | 96 +++--
1 file changed, 53 insertions(+), 43 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
---
src/qemu/qemu_command.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index cfd9ef9e2..507401d3f 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1220,6 +1220,9 @@ int
qemuCheckDiskConfig(virDo
All of the error message are already in a conditional block with known
bus type. Inline the bus type rather than formatting it from a separate
variable.
---
src/qemu/qemu_command.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_command.c b
---
src/qemu/qemu_command.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 507401d3f..1913bbf67 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1428,6 +1428,10 @@ qemuCheckDiskConfig(virDomain
Stash all the disk definition and capability checks into one function.
---
src/qemu/qemu_command.c | 324
src/qemu/qemu_command.h | 3 +-
src/qemu/qemu_driver.c | 2 +-
3 files changed, 166 insertions(+), 163 deletions(-)
diff --git a/src/qemu
To allow merging this with other disk type checks we need to check
qemuCaps only when available, since some of the checks are executed on
disk cold-plug and thus capabilities should not be checked.
Make the checks optional by making them conditional on qemuCaps not
being NULL.
---
src/qemu/qemu_c
The disk index validation is used only in very specific cases and does
not need to be performed otherwise. Move it out of the global check into
the usage place.
---
src/qemu/qemu_command.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_comman
busid and unitid are ever used only if the device is an SD card due to
the check in qemuDiskBusNeedsDeviceArg. Since the SD card does not have
an bus or unit number, most of the code and command line formatter can
be removed since it will never be used.
---
src/qemu/qemu_command.c | 37 +--
Kill some ugly code.
Peter Krempa (9):
util: Fix condition check in virDiskNameToIndex
qemu: command: Remove dead code when formatting -drive
qemu: command: Move disk index validation closer to usage
qemu: command: Directly report bus type in qemuBuildDriveStrValidate
qemu: command: Refa
Use the more common '< 0' rather than the non-zero check.
---
src/util/virutil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virutil.c b/src/util/virutil.c
index 170e92192..8bdcb02fd 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -562,7 +562,7 @@ int v
ping^2,
TKs,
John
On 10/19/2017 11:02 AM, John Ferlan wrote:
>
> ping?
>
> Tks -
>
> John
>
> On 10/06/2017 10:42 AM, John Ferlan wrote:
>> Since the original series (19 patches):
>>
>> https://www.redhat.com/archives/libvir-list/2017-September/msg00594.html
>>
>> didn't garner any attention
On Thu, Oct 26, 2017 at 11:12:08 -0400, John Ferlan wrote:
>
>
> On 10/20/2017 09:47 AM, Peter Krempa wrote:
> > Separate it so that it deals only with single virStorageSource, so that
> > it can later be reused for full backing chain support.
> >
> > Two aliases are passed since authentication
On 03.11.2017 11:42, Martin Kletzander wrote:
> On Fri, Nov 03, 2017 at 11:07:36AM +0300, Nikolay Shirokovskiy wrote:
>> On 02.11.2017 19:32, Martin Kletzander wrote:
>>> This just makes the window of opportunity (between daemonServerClose()
>>> and the actual removal of the virNetServerPtr from
In case ipv6 is used the network inet6 permission is required for
virt-aa-helper.
Signed-off-by: Christian Ehrhardt
---
examples/apparmor/usr.lib.libvirt.virt-aa-helper | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/apparmor/usr.lib.libvirt.virt-aa-helper
b/examples/apparmor/usr.l
Hi,
here a few more apparmor fixes for your review.
One is for an Ubuntu bug [1] which is non fatal, but denies a qemu fix to
fully work.
The other one I was carried in Ubuntu for some time and is related to ipv6
only setups where virt-aa-helper can fail if not permitted inet6.
[1]: https://bugs.
Since qemu 2.9 via 9103f1ce "file-posix: Consider max_segments for
BlockLimits.max_transfer" this is a new access that is denied by the
qemu profile.
It is non fatal, but prevents the fix mentioned to actually work.
It should be safe to allow reading from that path.
Since qemu opens a symlink pat
Reword the message and drop the numbers (which were reversed) from it
so that it actually makes sense.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1509151
---
src/conf/domain_conf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/co
On Fri, Nov 03, 2017 at 11:07:36AM +0300, Nikolay Shirokovskiy wrote:
On 02.11.2017 19:32, Martin Kletzander wrote:
This just makes the window of opportunity (between daemonServerClose()
and the actual removal of the virNetServerPtr from the hash) smaller.
That's why I don't see it as a fix, rat
On 02.11.2017 19:32, Martin Kletzander wrote:
> On Thu, Nov 02, 2017 at 10:49:35AM +0300, Nikolay Shirokovskiy wrote:
>>
>>
>> On 01.11.2017 21:51, John Ferlan wrote:
>>>
>>>
>>> On 10/31/2017 02:54 AM, Nikolay Shirokovskiy wrote:
On 30.10.2017 19:21, Martin Kletzander wrote:
>
On Thu, Nov 2, 2017 at 4:34 PM, Daniel P. Berrange wrote:
>
> On Thu, Nov 02, 2017 at 04:14:06PM +0100, Christian Ehrhardt wrote:
> > Ping - since there wasn't any reply so far - any best practices one could
> > share?
> >
> > Let me add a TL;DR:
> > - bump of ipxe rom versions change the size of
68 matches
Mail list logo
