Re: [libvirt] [PATCH V2] virconf: properly set the end of content

Opps, sorry for missing the 'PATCH V2' subject-prefix. Regards, Jim On 11/08/2017 04:01 PM, Jim Fehlig wrote: There was a recent report of the xen-xl converter not handling config files missing an ending newline https://www.redhat.com/archives/libvir-list/2017-October/msg01353.html Commit

Re: [libvirt] [PATCH] virconf: properly set the end of content

On 11/08/2017 01:56 AM, Daniel P. Berrange wrote: On Tue, Nov 07, 2017 at 03:37:46PM -0700, Jim Fehlig wrote: There was a recent report of the xen-xl converter not handling config files missing an ending newline https://www.redhat.com/archives/libvir-list/2017-October/msg01353.html Commit

[libvirt] [PATCH] virconf: properly set the end of content

There was a recent report of the xen-xl converter not handling config files missing an ending newline https://www.redhat.com/archives/libvir-list/2017-October/msg01353.html Commit 3cc2a9e0 fixed a similar problem when parsing content of a file but missed parsing in-memory content. But AFAICT,

Re: [libvirt] [PATCH v3 0/5] nwfilter common object adjustments

Ping? Any brave souls out there? Tks, John On 10/05/2017 07:32 PM, John Ferlan wrote: > v2: https://www.redhat.com/archives/libvir-list/2017-July/msg00673.html > (and a few pings along the way) > > Don't think much survived from v2 - this is a fresh start anyway. > Perhaps old patch 2 the

Re: [libvirt] [PATCH 3/4] qemu: Remove unnecessary virtio disk detach info.alias check

On 10/20/2017 08:21 AM, Ján Tomko wrote: > On Fri, Oct 20, 2017 at 08:03:29AM -0400, John Ferlan wrote: >> Since qemuAssignDeviceDiskAlias checks whether the input info.alias >> is already present, no need to check here as well. >> >> Signed-off-by: John Ferlan >> --- >>

Re: [libvirt] [PATCH 0/7] x86: Rework KVM-defaults compat code, enable kvm_pv_unhalt by default

On Tue, Nov 07, 2017 at 12:21:16PM +0100, Paolo Bonzini wrote: > On 14/10/2017 01:56, Eduardo Habkost wrote: > > Now, I don't know yet what's the best default for a guest that > > has CONFIG_PARAVIRT_SPINLOCK when it sees a host that supports > > kvm_pv_unhalt. But I'm arguing that it's the guest

Re: [libvirt] [PATCH 08/11] tools: Provide bash autompletion file

On 11/08/2017 10:06 AM, Michal Privoznik wrote: >> $ virsh complete some-command --arg partial > > This is excatly what my patches are doing. With one tiny difference. In > fact bash script calls: > > virsh complete "some-command --arg partial" > > so that I can have cmdComplete which takes

Re: [libvirt] [PATCH 08/11] tools: Provide bash autompletion file

On 11/08/2017 04:53 PM, Eric Blake wrote: > On 11/08/2017 09:09 AM, Michal Privoznik wrote: >> On 11/08/2017 03:46 PM, Martin Kletzander wrote: >>> On Tue, Nov 07, 2017 at 01:22:56PM +0100, Michal Privoznik wrote: Signed-off-by: Michal Privoznik > >>> >>> When I see all

Re: [libvirt] [PATCH 08/11] tools: Provide bash autompletion file

On 11/08/2017 09:09 AM, Michal Privoznik wrote: > On 11/08/2017 03:46 PM, Martin Kletzander wrote: >> On Tue, Nov 07, 2017 at 01:22:56PM +0100, Michal Privoznik wrote: >>> Signed-off-by: Michal Privoznik >> >> When I see all the things you have to do here, wouldn't it be

Re: [libvirt] [PATCH] qemu-ns: Detect /dev/* mount point duplicates even better

On Wed, Nov 08, 2017 at 04:09:57PM +0100, Michal Privoznik wrote: In 4f1570720218302 I've tried to make duplicates detection for nested /dev mount better. However, I've missed the obvious case when there are two same mount points. For instance if: # mount --bind /dev/blah /dev/blah # mount

Re: [libvirt] [PATCH 00/11] Make auto completion better

On Tue, Nov 07, 2017 at 01:22:48PM +0100, Michal Privoznik wrote: After initial RFC [1] I had some time to work on this and here is the result. What's implemented? === Auto completion for both interactive and non-interactive virsh/virt-admin. Known limitations

Re: [libvirt] [PATCH 07/11] vsh: Introduce complete command

On Tue, Nov 07, 2017 at 01:22:55PM +0100, Michal Privoznik wrote: This command is going to be called from bash completion script in the following form: virsh complete "start --domain" Its only purpose is to return list of possible strings for completion. Note that this is a 'hidden', unlisted

Re: [libvirt] [PATCH 07/11] vsh: Introduce complete command

On Wed, Nov 08, 2017 at 04:00:35PM +0100, Michal Privoznik wrote: On 11/08/2017 03:23 PM, Martin Kletzander wrote: On Tue, Nov 07, 2017 at 01:22:55PM +0100, Michal Privoznik wrote: This command is going to be called from bash completion script in the following form:  virsh complete "start

Re: [libvirt] [PATCH 08/11] tools: Provide bash autompletion file

On 11/08/2017 04:18 PM, Martin Kletzander wrote: > On Wed, Nov 08, 2017 at 04:09:10PM +0100, Michal Privoznik wrote: >> On 11/08/2017 03:46 PM, Martin Kletzander wrote: >>> On Tue, Nov 07, 2017 at 01:22:56PM +0100, Michal Privoznik wrote: Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH 08/11] tools: Provide bash autompletion file

On Wed, Nov 08, 2017 at 04:09:10PM +0100, Michal Privoznik wrote: On 11/08/2017 03:46 PM, Martin Kletzander wrote: On Tue, Nov 07, 2017 at 01:22:56PM +0100, Michal Privoznik wrote: Signed-off-by: Michal Privoznik --- configure.ac   |  3 ++ libvirt.spec.in  

Re: [libvirt] [PATCH] qemu-ns: Detect /dev/* mount point duplicates even better

On Wed, Nov 08, 2017 at 04:09:57PM +0100, Michal Privoznik wrote: > In 4f1570720218302 I've tried to make duplicates detection for > nested /dev mount better. However, I've missed the obvious case > when there are two same mount points. For instance if: > > # mount --bind /dev/blah /dev/blah >

[libvirt] [PATCH] qemu-ns: Detect /dev/* mount point duplicates even better

In 4f1570720218302 I've tried to make duplicates detection for nested /dev mount better. However, I've missed the obvious case when there are two same mount points. For instance if: # mount --bind /dev/blah /dev/blah # mount --bind /dev/blah /dev/blah Yeah, very unlikely but possible.

Re: [libvirt] [PATCH 08/11] tools: Provide bash autompletion file

On 11/08/2017 03:46 PM, Martin Kletzander wrote: > On Tue, Nov 07, 2017 at 01:22:56PM +0100, Michal Privoznik wrote: >> Signed-off-by: Michal Privoznik >> --- >> configure.ac   |  3 ++ >> libvirt.spec.in    |  2 ++ >> m4/virt-bash-completion.m4 | 74 >>

Re: [libvirt] [PATCH 07/11] vsh: Introduce complete command

On 11/08/2017 03:23 PM, Martin Kletzander wrote: > On Tue, Nov 07, 2017 at 01:22:55PM +0100, Michal Privoznik wrote: >> This command is going to be called from bash completion script in >> the following form: >> >>  virsh complete "start --domain" >> >> Its only purpose is to return list of

[libvirt] [PATCH] conf: Properly parse

The terminator would not be parsed properly since the XPath selector was looking for an populated element, and also the code did not bother assigning the terminating virStorageSourcePtr to the backingStore property of the parent. Some tests would catch it if there wasn't bigger fallout from the

Re: [libvirt] [PATCH 08/11] tools: Provide bash autompletion file

On Tue, Nov 07, 2017 at 01:22:56PM +0100, Michal Privoznik wrote: Signed-off-by: Michal Privoznik --- configure.ac | 3 ++ libvirt.spec.in| 2 ++ m4/virt-bash-completion.m4 | 74 ++ tools/Makefile.am

Re: [libvirt] [PATCH] conf: Fix type for @liveStatus in virDomainObjListLoadAllConfigs

On Wed, Nov 08, 2017 at 15:18:37 +0100, Peter Krempa wrote: > Use bool instead of an int. > --- > src/bhyve/bhyve_driver.c| 4 ++-- > src/conf/virdomainobjlist.c | 2 +- > src/conf/virdomainobjlist.h | 2 +- > src/libxl/libxl_driver.c| 6 +++--- > src/lxc/lxc_driver.c| 6 +++--- >

Re: [libvirt] [PATCH 07/11] vsh: Introduce complete command

On Tue, Nov 07, 2017 at 01:22:55PM +0100, Michal Privoznik wrote: This command is going to be called from bash completion script in the following form: virsh complete "start --domain" Its only purpose is to return list of possible strings for completion. Note that this is a 'hidden', unlisted

[libvirt] [PATCH] conf: Fix type for @liveStatus in virDomainObjListLoadAllConfigs

Use bool instead of an int. --- src/bhyve/bhyve_driver.c| 4 ++-- src/conf/virdomainobjlist.c | 2 +- src/conf/virdomainobjlist.h | 2 +- src/libxl/libxl_driver.c| 6 +++--- src/lxc/lxc_driver.c| 6 +++--- src/qemu/qemu_driver.c | 6 +++--- src/uml/uml_driver.c| 4

Re: [libvirt] [[RFC] 0/8] Implement async QEMU event handling in libvirtd.

On Mon, Nov 06, 2017 at 06:43:12AM +0100, Prerna wrote: > Thanks for your reply Daniel. I am still on vacation all of this week so > have not been able to respond. > Few questions inline: > > On Thu, Oct 26, 2017 at 2:43 PM, Daniel P. Berrange > wrote: > > > On Tue, Oct 24,

[libvirt] [REPOST PATCH v6 6/8] qemu: Use secret objects to pass iSCSI passwords

https://bugzilla.redhat.com/show_bug.cgi?id=1425757 The blockdev-add code provides a mechanism to sanely provide user and password-secret arguments for iscsi without placing them on the command line to be viewable by a 'ps -ef' type command or needing to create separate -iscsi devices for each

[libvirt] [REPOST PATCH v6 2/8] qemu: Use private storage source for iscsi instead of private hostdev

Rather than placing/using privateData about secinfo in the hostdev, let's use the virStorageSource private data instead. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 7 --- src/qemu/qemu_domain.c | 24 2 files changed, 20

[libvirt] [REPOST PATCH v6 5/8] qemu: Get capabilities to use iscsi password-secret argument

Add the capability to use the blockdev-add query-qmp-schema option to find the 'password-secret' parameter that will allow the iSCSI code to use the master secret object to encrypt the secret for an and only need to provide the object id of the secret on the command line thus obsfuscating the

[libvirt] [REPOST PATCH v6 7/8] docs: Add news article regarding auth/encryption placement

Signed-off-by: John Ferlan --- docs/news.xml | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 87391af856..9ec2780985 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,19 @@ + + +

[libvirt] [REPOST PATCH v6 8/8] docs: Add news article to describe iSCSI usage of secret object

Signed-off-by: John Ferlan --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 9ec2780985..800067595f 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -137,6 +137,16 @@ order of appearance.

[libvirt] [REPOST PATCH v6 4/8] qemu: Refactor qemuBuildSCSIiSCSIHostdevDrvStr slightly

Rather than building the "file" string in qemuBuildSCSIHostdevDrvStr build it in the called helper. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c

[libvirt] [REPOST PATCH v6 3/8] qemu: Remove private hostdev

Since it's not longer used to shuttle the @secinfo, let's remove the private hostdev completely. Signed-off-by: John Ferlan --- src/conf/domain_conf.c| 12 ++-- src/conf/domain_conf.h| 4 +--- src/lxc/lxc_native.c | 2 +-

[libvirt] [REPOST PATCH v6 1/8] conf, qemu: Replace iscsisrc fields with virStorageSourcePtr

Rather than picking apart the two pieces we need/want (path, hosts, and auth)- let's allocate/use a virStorageSourcePtr for iSCSI storage. The end result is that qemuBuildSCSIiSCSIHostdevDrvStr doesn't need to "fake" one for the qemuBuildNetworkDriveStr call. Signed-off-by: John Ferlan

[libvirt] [REPOST PATCH v6 0/8] Use secret objects to pass iSCSI passwords

Repost after updating the series to account for Peter's most recent -drive and blockdev-add saga changes. Includes adding the port number to the .args output and updating the *.xmlfor the newly added ppc and gic*-aarch64 capabilitiesdata Also merge the news.xml changes w/ recent vbox changes.

Re: [libvirt] [PATCH 11/12] qemu: block: Add node-names to JSON backing storage strings

On 11/03/2017 10:29 AM, Peter Krempa wrote: > Format out the node-name if it was assigned for JSON-based storage > specification. > --- > src/qemu/qemu_block.c | 5 + > 1 file changed, 5 insertions(+) > And Coverity also notes that for virStorageType) actualType == VIR_STORAGE_TYPE_VOLUME

Re: [libvirt] [PATCH 07/12] qemu: block: Add JSON props generator for NBD storage backing

On 11/03/2017 10:29 AM, Peter Krempa wrote: > --- > src/qemu/qemu_block.c | 32 > 1 file changed, 32 insertions(+) > > diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c > index 4e588c724..451d04694 100644 > --- a/src/qemu/qemu_block.c > +++

Re: [libvirt] [PATCH 09/12] qemu: block: Add JSON props generator for sheepdog storage backing

On 11/03/2017 10:29 AM, Peter Krempa wrote: > --- > src/qemu/qemu_block.c | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c > index 8a1ce8262..5f28c4dd6 100644 > --- a/src/qemu/qemu_block.c > +++

Re: [libvirt] [PATCH] util: storage: Fix parsing of IPv6 portal address for iSCSI

On Tue, Nov 07, 2017 at 16:26:51 +0100, Peter Krempa wrote: > Split on the last colon and avoid parsing port if the split remainder > contains the closing square bracket, so that IPv6 addresses are > interpreted correctly. > --- > src/util/virstoragefile.c | 3 ++- > tests/virstoragetest.c|

Re: [libvirt] [PATCH go-xml] Add support for host paravirt bootloader, used by Xen and bhyve.

On Tue, Nov 07, 2017 at 02:17:41PM -0600, Brandon Bergren wrote: > --- > domain.go | 2 ++ > domain_test.go | 16 > 2 files changed, 18 insertions(+) THanks, pushed to git master Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] [PATCH 3/4] tests: Rename ppc64le caps to ppc64

On Tue, 2017-11-07 at 17:47 -0500, John Ferlan wrote: > So this is just for our tests right? I guess I see a name change like > this and I think - is there some sort of migrate or save/restore issue > we could have by changing the "name"... Nah, it's pretty much just the names of the files in

Re: [libvirt] [PATCH 03/11] vsh: Add @silent to vshConnectionHook

On Tue, Nov 07, 2017 at 01:22:51PM +0100, Michal Privoznik wrote: In near future we will want to not report error when connecting fails. In order to achieve that we have to pass a boolean that suppresses error messages. Signed-off-by: Michal Privoznik ---

Re: [libvirt] [PATCH 02/11] vshCommandOpt: Relax check for valid options

On Tue, Nov 07, 2017 at 01:22:50PM +0100, Michal Privoznik wrote: When trying to get an opt for command typed on the command line we first check if command has such option. Because if it doesn't it is a programming error. For instance: vshCommandOptBool(cmd, "config") called from say cmdStart()

Re: [libvirt] [PATCH v3 0/5] Predictable file names for memory-backend-file

On 11/07/2017 10:45 PM, John Ferlan wrote: > > > On 11/07/2017 10:50 AM, Michal Privoznik wrote: >> v3 of: >> >> https://www.redhat.com/archives/libvir-list/2017-October/msg01091.html >> >> diff to v2: >> - Pushed 1/4 and 2/4 from the original series >> - Split 3/4 into smaller patches >> >>

Re: [libvirt] [PATCH] virconf: properly set the end of content

On Tue, Nov 07, 2017 at 03:37:46PM -0700, Jim Fehlig wrote: > There was a recent report of the xen-xl converter not handling > config files missing an ending newline > > https://www.redhat.com/archives/libvir-list/2017-October/msg01353.html > > Commit 3cc2a9e0 fixed a similar problem when