[libvirt] [PATCH] virhostcpu: Report correct topolgy info on host with deconfigured core

2017-11-13 Thread Nitesh Konkar
The host which has a deconfigured core is treated as though the topology is not correct and the SMT is not reliable. Which is not true, so report the topology correctly by detecting if the host is actually in a proper SMT mode with the deconfigured core. Signed-off-by: Nitesh Konkar

[libvirt] 答复: Help:Can libvirt restore several xen snapshots more faster at same time?

2017-11-13 Thread Chenjia (C)
Dear libvirt expert: Thanks for your reply. May be our description is not suitable, in last message,'snapshot' means the domain state file which 'virsh save ' generate. Our project detailed steps are as follows: 1) create 40 xen guestOS by 'vrish create xen*.xml'

Re: [libvirt] [PATCH v2 2/2] remote: free client all event callbacks at remoteClientCloseFunc

2017-11-13 Thread xinhua.Cao
在 2017/11/13 22:27, Martin Kletzander 写道: On Mon, Nov 13, 2017 at 09:07:12PM +0800, xinhua.Cao wrote: 在 2017/11/12 22:45, John Ferlan 写道: On 11/11/2017 03:20 AM, xinhua.Cao wrote: 在 2017/11/11 5:43, John Ferlan 写道: On 11/06/2017 12:47 AM, xinhua.Cao wrote: base on commit

Re: [libvirt] [PATCH v4 2/2] remote: Move the call to remoteClientFreePrivateCallbacks from FreeFunc to CloseFunc

2017-11-13 Thread xinhua.Cao
在 2017/11/13 22:31, Martin Kletzander 写道: On Mon, Nov 13, 2017 at 09:07:58PM +0800, xinhua.Cao wrote: Still because of commit id 'fe8f1c8b' where we generate a REF for the Register and that's transparent to the consumer (e.g. how would they know they need to ensure that Deregister is called),

Re: [libvirt] Help:Can libvirt restore several xen snapshots more faster at same time?

2017-11-13 Thread Jim Fehlig
On 11/13/2017 03:31 AM, Chenjia (C) wrote: Dear libvirt expert, we find a blocker issue in our project. Would you please offer us some feedback? Our project have a requirement: restore as much as xen snapshot at same time.  we have done the following test(our environment is cpu E52620, 

Re: [libvirt] [PATCH 10/21] conf: Sort cache banks in capabilities XML

2017-11-13 Thread John Ferlan
On 11/13/2017 03:50 AM, Martin Kletzander wrote: > Because the cache banks are initialized based on the order in which their > respective directories exist on the filesystem, they can appear in diferrent s/diferrent/different/ > order. This is here mainly for tests because the cache directory

[libvirt] [PATCH] vircapstest: Avoid (im)possible strcmp call with NULL argument

2017-11-13 Thread Jiri Denemark
Some compiler may get confused and decide we are calling strcmp with NULL argument from test_virCapsDomainDataLookupLXC. Although this does not really happen since the call is guarded with (data->machinetype != expect_machinetype), using STRNEQ_NULLABLE is easier to understand, less fragile, and

Re: [libvirt] [PATCH 09/21] util: Introduce virBitmapShrink

2017-11-13 Thread John Ferlan
On 11/13/2017 03:50 AM, Martin Kletzander wrote: > Sometimes the size of the bitmap matters and it might not be guessed correctly > when parsing from some type of input. For example virBitmapNewData() has Byte > granularity, virBitmapNewString() has nibble granularity and so on. >

Re: [libvirt] [PATCH 08/21] util: Reintroduce virBitmapSubtract

2017-11-13 Thread John Ferlan
On 11/13/2017 03:50 AM, Martin Kletzander wrote: > Already introduced in the past with 9479642fd3c5, but then renamed to > virBitmapIntersect by a908e9e45eb2. This time we'll really use it. > > Signed-off-by: Martin Kletzander > --- > src/libvirt_private.syms | 1 + >

Re: [libvirt] [PATCH 07/21] util: Introduce virBitmapNewString

2017-11-13 Thread John Ferlan
On 11/13/2017 03:50 AM, Martin Kletzander wrote: > Our bitmaps can be represented as data (raw bytes for which we have > virBitmapNewData() and virBitmapToData()), human representation (list > of numbers in a string for which we have virBitmapParse() and > virBitmapFormat()) and hexadecimal

Re: [libvirt] [PATCH 05/21] util: Rename virBitmapDataToString to virBitmapDataFormat

2017-11-13 Thread John Ferlan
On 11/13/2017 03:50 AM, Martin Kletzander wrote: > It is literally only a wrapper around virBitmapNewData() and > virBitmapFormat(), only the naming was wrong since it was introduced. in commit id '7d8afc47'. > And because we have virBitmap*String functions where the meaning of > the 'String'

Re: [libvirt] [PATCH 03/21] util: Make prefix optional in virBitampString

2017-11-13 Thread John Ferlan
$subj: s/virBitampString/virBitmapString/ On 11/13/2017 03:50 AM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_capabilities.c | 4 ++-- > src/util/virbitmap.c | 6 -- > src/util/virbitmap.h | 2 +- > 3 files

Re: [libvirt] [PATCH 02/21] util: Introduce virPrettySize

2017-11-13 Thread John Ferlan
On 11/13/2017 03:50 AM, Martin Kletzander wrote: > We can't output better memory sizes if we want to be compatible with libvirt > older than the one which introduced /memory/unit, but for new things we can > just > output nicer capacity to the user if available. And this function enables >

Re: [libvirt] [PATCH] qemu: Properly report errors from qemuDomainFixupCPUs

2017-11-13 Thread Pavel Hrdina
On Mon, Nov 13, 2017 at 04:56:32PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature --

[libvirt] [PATCH v2 12/12] virt-admin: Introduce vshAdmServerCompleter

2017-11-13 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- tools/Makefile.am| 9 ++ tools/virt-admin-completer.c | 76 tools/virt-admin-completer.h | 33 +++ tools/virt-admin.c | 8 + 4 files changed, 126

[libvirt] [PATCH v2 04/12] vshCommandOpt: Allow caller avoiding assert()

2017-11-13 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- tools/vsh.c | 7 --- tools/vsh.h | 3 ++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index 3a9941017..26f1f9e03 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -816,8 +816,8 @@

[libvirt] [PATCH v2 07/12] vshCompleter: Pass partially parsed command

2017-11-13 Thread Michal Privoznik
The callback we're calling might need to make decisions on already passed arguments. For instance, a completer that is supposed to bring up list of domain's interfaces might want to see what domain user wants to work with. Signed-off-by: Michal Privoznik --- tools/vsh.c | 9

[libvirt] [PATCH v2 05/12] vsh: Fix vshCompleter signature

2017-11-13 Thread Michal Privoznik
The first argument passed to this function is vshControl *. There's no need to use void pointer. Signed-off-by: Michal Privoznik --- tools/vsh.c | 2 +- tools/vsh.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index

[libvirt] [PATCH v2 06/12] vsh: Call vshCmdOptDef.completer properly

2017-11-13 Thread Michal Privoznik
The idea is that .completer for vshCmdOptDef would be called if the last token on the input is a cmd opt. For instance: virsh # start --domain However, with current code that's not happening. Signed-off-by: Michal Privoznik --- tools/vsh.c | 48

[libvirt] [PATCH v2 02/12] vshCommandStringParse: Allow retrieving partial result

2017-11-13 Thread Michal Privoznik
In the future, this function is going to be called from vshReadlineParse() to provide parsed input for completer callbacks. The idea is to allow the callbacks to provide more specific data. For instance, for the following input: virsh # domifaddr --domain fedora --interface the --interface

[libvirt] [PATCH v2 10/12] virsh: Introduce virshDomainNameCompleter

2017-11-13 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- tools/Makefile.am| 9 +++ tools/virsh-completer.c | 90 + tools/virsh-completer.h | 33 tools/virsh-domain-monitor.c | 30 +++ tools/virsh-domain.c | 182

[libvirt] [PATCH v2 11/12] virsh: Introduce virshDomainInterfaceCompleter

2017-11-13 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- tools/virsh-completer.c | 60 tools/virsh-completer.h | 8 ++ tools/virsh-domain-monitor.c | 3 +++ tools/virsh-domain.c | 4 +++ 4 files changed, 75 insertions(+) diff

[libvirt] [PATCH v2 01/12] vshCommandParse: Don't leak @tkdata

2017-11-13 Thread Michal Privoznik
When parsing cmd line which has "--" on it, this is leaked. Problem is, parser->getNextArg() allocates new string and stores it into tkdata. But as soon as "--" is detected 'continue' is issued without any free of the allocated memory. ==5304== 3 bytes in 1 blocks are definitely lost in loss

[libvirt] [PATCH v2 09/12] tools: Provide bash autompletion file

2017-11-13 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- configure.ac | 3 ++ libvirt.spec.in| 2 ++ m4/virt-bash-completion.m4 | 74 ++ tools/Makefile.am | 22 -- tools/bash-completion/vsh | 67

[libvirt] [PATCH v2 03/12] vshReadlineParse: Escape returned results if needed

2017-11-13 Thread Michal Privoznik
When returning a string that needs escaping there are two scenarios that can happen. Firstly, user already started the string with a quote (or double quote) in which case we don't need to do anything - readline takes care of that. However, if they haven't typed anything yet, we need to escape the

[libvirt] [PATCH v2 00/12] Make auto completion better

2017-11-13 Thread Michal Privoznik
v2 of: https://www.redhat.com/archives/libvir-list/2017-November/msg00213.html diff to v1: -cmdComplete reworked -Dozen of small improvements The command completion is still missing. I mean, 'virsh start' will still give you list of --options rather than a list of domains to start with it. And

[libvirt] [PATCH v2 08/12] vsh: Introduce complete command

2017-11-13 Thread Michal Privoznik
This command is going to be called from bash completion script in the following form: virsh complete "start --domain" Its only purpose is to return list of possible strings for completion. Note that this is a 'hidden', unlisted command and therefore there's no documentation to it.

[libvirt] [PATCH] qemu: Properly report errors from qemuDomainFixupCPUs

2017-11-13 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 6d7827220e..a36e157529 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@

Re: [libvirt] [PATCH] Revert "virNetDevSupportBandwidth: Enable QoS for vhostuser"

2017-11-13 Thread Michal Privoznik
On 11/13/2017 09:47 AM, Martin Kletzander wrote: > On Fri, Nov 10, 2017 at 04:23:27PM +0100, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1497410 >> >> This reverts commit bc8a99ef06417a2303ccab455f9f045e2a617916. >> >> The vhostuser is not a TAP. Therefore our QoS code

Re: [libvirt] [PATCH 0/4] libvirtd: fix hang on termination in qemu driver

2017-11-13 Thread John Ferlan
On 10/25/2017 05:05 AM, Nikolay Shirokovskiy wrote: > Libvirtd termination can hang. For example if some API call in qemu > driver awaiting monitor response it will never finish because event > loop does not functional during termination. As a result we hang > in virNetDaemonClose call during

Re: [libvirt] [PATCH 4/4] news: Update for configuration of HPT resizing

2017-11-13 Thread John Ferlan
On 11/06/2017 11:08 AM, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > docs/news.xml | 10 ++ > 1 file changed, 10 insertions(+) > With the very obvious merge with current top... Reviewed-by: John Ferlan John --

Re: [libvirt] [PATCH 3/4] docs: Document configuration of HPT resizing

2017-11-13 Thread John Ferlan
On 11/06/2017 11:08 AM, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > docs/formatdomain.html.in | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > Reviewed-by: John Ferlan John -- libvir-list mailing list

Re: [libvirt] [PATCH 2/4] tests: Add tests for configuration of HPT resizing

2017-11-13 Thread John Ferlan
On 11/06/2017 11:08 AM, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > ...qemuxml2argv-pseries-hpt-resizing-disabled.args | 20 > .../qemuxml2argv-pseries-hpt-resizing-disabled.xml | 19 +++ >

Re: [libvirt] [PATCH 1/4] qemu: Enable configuration of HPT resizing for pSeries guests

2017-11-13 Thread John Ferlan
On 11/06/2017 11:08 AM, Andrea Bolognani wrote: > Most of the time it's okay to leave this up to negotiation between > the guest and the host, but in some situations it can be useful to > manually decide the behavior, especially to enforce its availability. > > Resolves:

Re: [libvirt] [PATCH v5 3/3] libvirtd: fix crash on termination

2017-11-13 Thread Martin Kletzander
On Tue, Nov 07, 2017 at 05:06:33PM +0100, Erik Skultety wrote: On Tue, Nov 07, 2017 at 10:28:10AM -0500, John Ferlan wrote: On 11/07/2017 04:46 AM, Martin Kletzander wrote: > On Mon, Nov 06, 2017 at 03:20:13PM -0500, John Ferlan wrote: >> >> >> On 11/03/2017 05:20 AM, Nikolay Shirokovskiy

Re: [libvirt] [PATCH v4 2/2] remote: Move the call to remoteClientFreePrivateCallbacks from FreeFunc to CloseFunc

2017-11-13 Thread Martin Kletzander
On Mon, Nov 13, 2017 at 09:07:58PM +0800, xinhua.Cao wrote: Still because of commit id 'fe8f1c8b' where we generate a REF for the Register and that's transparent to the consumer (e.g. how would they know they need to ensure that Deregister is called), thus the purpose of this patch is to find a

Re: [libvirt] [PATCH v2 2/2] remote: free client all event callbacks at remoteClientCloseFunc

2017-11-13 Thread Martin Kletzander
On Mon, Nov 13, 2017 at 09:07:12PM +0800, xinhua.Cao wrote: 在 2017/11/12 22:45, John Ferlan 写道: On 11/11/2017 03:20 AM, xinhua.Cao wrote: 在 2017/11/11 5:43, John Ferlan 写道: On 11/06/2017 12:47 AM, xinhua.Cao wrote: base on commit fe8f1c8b8650c8ab5e7d27338f4538582651bd14, we solve libvirt

[libvirt] Help:Can libvirt restore several xen snapshots more faster at same time?

2017-11-13 Thread Chenjia (C)
Dear libvirt expert, we find a blocker issue in our project. Would you please offer us some feedback? Our project have a requirement: restore as much as xen snapshot at same time. we have done the following test(our environment is cpu E52620, 256G memory, SSD hard disk. The xen snapshot

[libvirt] [PATCH v4 1/2] remote: Extract common clearing of event callbacks of client private data

2017-11-13 Thread xinhua.Cao
Extract common clearing of event callbacks as remoteClientFreePrivateCallbacks. the common function also separation including the sysident handling. --- daemon/remote.c | 73 ++--- 1 file changed, 39 insertions(+), 34 deletions(-) diff --git

[libvirt] [PATCH v4 2/2] remote: Move the call to remoteClientFreePrivateCallbacks from FreeFunc to CloseFunc

2017-11-13 Thread xinhua.Cao
Still because of commit id 'fe8f1c8b' where we generate a REF for the Register and that's transparent to the consumer (e.g. how would they know they need to ensure that Deregister is called), thus the purpose of this patch is to find a way to Deregister if it's determined that the consumer hasn't

Re: [libvirt] [PATCH v2 2/2] remote: free client all event callbacks at remoteClientCloseFunc

2017-11-13 Thread xinhua.Cao
在 2017/11/12 22:45, John Ferlan 写道: On 11/11/2017 03:20 AM, xinhua.Cao wrote: 在 2017/11/11 5:43, John Ferlan 写道: On 11/06/2017 12:47 AM, xinhua.Cao wrote: base on commit fe8f1c8b8650c8ab5e7d27338f4538582651bd14, we solve libvirt coredump problem, but it introduce a memory leak sense: 1.

Re: [libvirt] [PATCH] conf: Fix message when maximum vCPU count is less than current

2017-11-13 Thread Peter Krempa
On Fri, Nov 03, 2017 at 09:44:26 +0100, Peter Krempa wrote: > Reword the message and drop the numbers (which were reversed) from it > so that it actually makes sense. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1509151 > --- > src/conf/domain_conf.c | 6 +++--- > 1 file changed, 3

Re: [libvirt] [PATCH 01/21] Only output initialized capabilities with VIR_TEST_DEBUG > 1

2017-11-13 Thread Pavel Hrdina
On Mon, Nov 13, 2017 at 09:50:16AM +0100, Martin Kletzander wrote: > Currenty virTestInit() outputs all capabilities that it created when running > with VIR_TEST_DEBUG=1. Since this is quite a lot of output for every call of > this function (and it is not needed until debugging a really deep-down

[libvirt] [PATCH 05/21] util: Rename virBitmapDataToString to virBitmapDataFormat

2017-11-13 Thread Martin Kletzander
It is literally only a wrapper around virBitmapNewData() and virBitmapFormat(), only the naming was wrong since it was introduced. And because we have virBitmap*String functions where the meaning of the 'String' is constant, this might confuse someone. Signed-off-by: Martin Kletzander

[libvirt] [PATCH 12/21] resctrl: Instantiate all resctrl information at once

2017-11-13 Thread Martin Kletzander
This allows for looking up the cache control information more sensibly from conf/capabilities.c and also provides more data to the virresctrl module that will get more usable later on. Signed-off-by: Martin Kletzander --- po/POTFILES.in | 1 +

[libvirt] [PATCH 03/21] util: Make prefix optional in virBitampString

2017-11-13 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- src/qemu/qemu_capabilities.c | 4 ++-- src/util/virbitmap.c | 6 -- src/util/virbitmap.h | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH 21/21] docs: Add CAT (resctrl) support into news.xml

2017-11-13 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index ef855d895886..e06c981e36da 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,17 @@ + +

[libvirt] [PATCH 18/21] tests: Minor adjustments for test data

2017-11-13 Thread Martin Kletzander
This patch modifies some not yet used test data so that the adding a test using this data is a clean patch and not an addition of huge file with some adjustments in small files that will be hidden in the middle of that commit. These changes include: - Add system dir in

[libvirt] [PATCH 15/21] caps2xml resctrl-skx-twocaches

2017-11-13 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- .../resctrl/info/L3/cbm_mask | 1 + .../resctrl/info/L3/min_cbm_bits | 1 + .../resctrl/info/L3/num_closids| 1 + .../linux-resctrl-skx-twocaches/resctrl/schemata | 1 +

[libvirt] [PATCH 16/21] resctrl: Add functions to work with resctrl allocations

2017-11-13 Thread Martin Kletzander
With this commit we finally have a way to read and manipulate basic resctrl settings. Locking is done only on exposed functions that read/write from/to resctrlfs. Not in fuctions that are exposed in virresctrlpriv.h as those are only supposed to be used from tests. Signed-off-by: Martin

[libvirt] [PATCH 04/21] util: Rename virBitmapString to virBitmapToString

2017-11-13 Thread Martin Kletzander
This follows the virBitmapToData() function and, similarly to virBitmapNewData(), we'll be able to have virBitmapNewString() later on without name confusion. Signed-off-by: Martin Kletzander --- src/libvirt_private.syms | 2 +- src/qemu/qemu_capabilities.c | 4 ++--

[libvirt] [PATCH 17/21] conf: cachetune

2017-11-13 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- docs/formatdomain.html.in | 24 ++ docs/schemas/domaincommon.rng | 32 +++ src/conf/domain_conf.c | 249 + src/conf/domain_conf.h

[libvirt] [PATCH 09/21] util: Introduce virBitmapShrink

2017-11-13 Thread Martin Kletzander
Sometimes the size of the bitmap matters and it might not be guessed correctly when parsing from some type of input. For example virBitmapNewData() has Byte granularity, virBitmapNewString() has nibble granularity and so on. virBitmapParseUnlimited() can be tricked into creating huge bitmap

[libvirt] [PATCH 19/21] tests: Add virresctrltest

2017-11-13 Thread Martin Kletzander
This test has 2 different uses: 1) DO_TEST_FREE initializes capabilities from vircaps2xmldata (since it exists there already) and then requests list of free bitmaps (all unallocated space) from virresctrl.c 2) DO_TEST_ALLOC takes capabilities from vircaps2xmldata, and uses resctrl info

[libvirt] [PATCH 10/21] conf: Sort cache banks in capabilities XML

2017-11-13 Thread Martin Kletzander
Because the cache banks are initialized based on the order in which their respective directories exist on the filesystem, they can appear in diferrent order. This is here mainly for tests because the cache directory might have different order of children nodes and tests would fail otherwise. It

[libvirt] [PATCH 20/21] qemu: Add support for resctrl

2017-11-13 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- src/qemu/qemu_process.c | 61 + 1 file changed, 56 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 7df440ee4345..335146ab71b8 100644 ---

[libvirt] [PATCH 07/21] util: Introduce virBitmapNewString

2017-11-13 Thread Martin Kletzander
Our bitmaps can be represented as data (raw bytes for which we have virBitmapNewData() and virBitmapToData()), human representation (list of numbers in a string for which we have virBitmapParse() and virBitmapFormat()) and hexadecimal string (for which we have only virBitmapToString()). So let's

[libvirt] [PATCH 02/21] util: Introduce virPrettySize

2017-11-13 Thread Martin Kletzander
We can't output better memory sizes if we want to be compatible with libvirt older than the one which introduced /memory/unit, but for new things we can just output nicer capacity to the user if available. And this function enables that. Signed-off-by: Martin Kletzander ---

[libvirt] [PATCH 13/21] tests: Remove executable bits on plain data files

2017-11-13 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- tests/vircaps2xmldata/linux-resctrl-cdp/resctrl/info/L3CODE/cbm_mask | 0 tests/vircaps2xmldata/linux-resctrl-cdp/resctrl/info/L3CODE/min_cbm_bits | 0 tests/vircaps2xmldata/linux-resctrl-cdp/resctrl/info/L3CODE/num_closids | 0

[libvirt] [PATCH 14/21] tests: Change some schemata for the default group

2017-11-13 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- tests/vircaps2xmldata/linux-resctrl-cdp/resctrl/schemata | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vircaps2xmldata/linux-resctrl-cdp/resctrl/schemata

[libvirt] [PATCH 01/21] Only output initialized capabilities with VIR_TEST_DEBUG > 1

2017-11-13 Thread Martin Kletzander
Currenty virTestInit() outputs all capabilities that it created when running with VIR_TEST_DEBUG=1. Since this is quite a lot of output for every call of this function (and it is not needed until debugging a really deep-down issue) let's just output the info when VIR_TEST_DEBUG is strictly

[libvirt] [PATCH 11/21] conf: Format cache banks in capabilities with virPrettySize

2017-11-13 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- src/conf/capabilities.c| 45 ++ tests/vircaps2xmldata/vircaps-x86_64-caches.xml| 2 +- .../vircaps2xmldata/vircaps-x86_64-resctrl-cdp.xml | 4 +-

[libvirt] [PATCH 08/21] util: Reintroduce virBitmapSubtract

2017-11-13 Thread Martin Kletzander
Already introduced in the past with 9479642fd3c5, but then renamed to virBitmapIntersect by a908e9e45eb2. This time we'll really use it. Signed-off-by: Martin Kletzander --- src/libvirt_private.syms | 1 + src/util/virbitmap.c | 22 ++

[libvirt] [PATCH 06/21] util: Don't output too many zeros from virBitmapToString

2017-11-13 Thread Martin Kletzander
Truncate the output so that it is only as big as is needed to fit all the bits, not all the units from the map. This will be needed in the future in order to properly format bitmaps for kernel's sysfs files. Signed-off-by: Martin Kletzander --- src/qemu/qemu_capabilities.c

[libvirt] [PATCH 00/21] Initial support for resctrl (CAT)

2017-11-13 Thread Martin Kletzander
This is an initial support for resctrl, so that domains can make use of Cache Allocation Technology (). After bunch of initial discussions I followed most of those things except one detail. In order to distinguish different allocations while minimizing the number of them at the same time, I

Re: [libvirt] [PATCH] Revert "virNetDevSupportBandwidth: Enable QoS for vhostuser"

2017-11-13 Thread Martin Kletzander
On Fri, Nov 10, 2017 at 04:23:27PM +0100, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1497410 This reverts commit bc8a99ef06417a2303ccab455f9f045e2a617916. The vhostuser is not a TAP. Therefore our QoS code is not able to set any bandwidth. I don't really understand

Re: [libvirt] [PATCH] spec: don't package product dirs

2017-11-13 Thread Martin Kletzander
On Thu, Sep 28, 2017 at 09:35:45AM +0300, Nikolay Shirokovskiy wrote: Directories /var/{lib,cache}/libvirt/qemu/ are created by libvirtd on start and their owner:group is changed according to the config. Thus no need to include them in libvirt-daemon-driver-qemu package. Otherwise we see noisy

Re: [libvirt] [PATCH] news: add entries for specifying distance between vNUMA cells

2017-11-13 Thread Erik Skultety
On Sun, Nov 12, 2017 at 07:47:19PM -0700, Jim Fehlig wrote: > Add two new entries under new features for 3.10.0. One > advertising support for specifying distance between vNUMA cells > and another advertising Xen's support for vNUMA configuration. > > Signed-off-by: Jim Fehlig