Re: [libvirt] libvirt 3.9.0 locks (was libvirt 3.5.0 locks)

2017-12-05 9:23 GMT+03:00 Nikolay Shirokovskiy : > >> >> So what next that can i do to fix this? (And i'm happy if this fixed >> before 3.10, but may be is too late...) >> > > You can revert aeda1b8c in your downstream build until it is fixed upstream. Thanks! --

Re: [libvirt] [PATCH for 3.11 0/2] qemuxml2argvdata: Drop useless prefix for test cases

On 12/04/2017 06:04 PM, Andrea Bolognani wrote: > On Sat, 2017-12-02 at 08:11 +0100, Michal Privoznik wrote: >> The patches are trimmed out a lot to fit the size limit of our list. Anyway, >> the interesting bits are kept and also you can find the patches at my github: >> >>

Re: [libvirt] libvirt 3.9.0 locks (was libvirt 3.5.0 locks)

On 04.12.2017 18:46, Vasiliy Tolstov wrote: > 2017-12-01 16:14 GMT+03:00 Nikolay Shirokovskiy : >> On 01.12.2017 15:26, Vasiliy Tolstov wrote: >>> Hi again. I'm still try to determine why my libvirtd locks, this is >>> another portion of gdb stuff: >>>

Re: [libvirt] [PATCH v4 0/3] Move ide validation from qemuBuildControllerDevStr to qemuDomainDeviceDefValidate

On 12/03/2017 11:06 PM, Lin Ma wrote: > Validate IDE controllers in qemuDomainDeviceDefValidate for reminding users > earlier. > > v3->v4: > Drop changes in tests/qemuxml2argvdata/qemuxml2argv-disk-floppy-pseries.args > Merged patch #3 and #4 for avoiding git bisect failure. > > Lin Ma (3): >

[libvirt] [PATCH 2/4] storage: Privatize virStoragePoolObjListPtr

Move the structure into virstorageobj.c. Use the virStoragePoolObjListNew allocator to fill in the @pools for the storage driver and test driver. Signed-off-by: John Ferlan --- src/conf/virstorageobj.c | 19 +++- src/conf/virstorageobj.h | 9 +++---

[libvirt] [PATCH 4/4] storage: Reduce need for using storageDriverLock

Now that the storage pools are self locking, we can reduce the number of places that need to take the big hammer storage driver lock Signed-off-by: John Ferlan --- src/storage/storage_driver.c | 103 +++ 1 file changed, 16

[libvirt] [PATCH 1/4] storage: Fix path check in storagePoolLookupByTargetPath

Commit id '5ab746b8' introduced the function as perhaps a copy of storageVolLookupByPath; however, it did not use the @cleanpath variable even though it used the virFileSanitizePath. So in essance the only "check" being done for failure is whether it was possible to strdup the path. Looking at

[libvirt] [PATCH 0/4] Complete storage pool object privatization and use of RWLockable

After this series the storage pool will be private to virstorageobj and will be a self locking list of hash tables similar to other drivers. All that remains will be to make the storage volume lists be hash tables, but that's only once this is accepted. First patch is related to review comment

[libvirt] [PATCH 3/4] storage: Convert virStoragePoolObjList to use virObjectRWLockable

Now that we have a private storage pool list, we can take the next step and convert to using objects. In this case, we're going to use RWLockable objects (just like every other driver) with two hash tables for lookup by UUID or Name. Along the way the ForEach and Search API's will be adjusted to

[libvirt] [PATCH 08/17] qemu: Introduce qemuDomainDeviceDefValidateControllerSCSI

Move SCSI validation from qemu_command into qemu_domain. This includes the @model reset/check when the controller model hasn't yet been set. While at it modify the switch to account for all virDomainControllerModelSCSI types rather than using the default label. Rename/reorder the args in

[libvirt] [PATCH 15/17] qemu: Introduce qemuDomainDeviceDefValidateControllerSATA

Move the SATA controller check from command line building to controller def validation. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 6 -- src/qemu/qemu_domain.c | 17 - 2 files changed, 16 insertions(+), 7 deletions(-) diff --git

[libvirt] [PATCH 03/17] qemu: Use virDomainControllerType in qemuBuildControllerDevStr switch

Make sure all types of virDomainControllerType are handled in the switch statement. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index

[libvirt] [PATCH 01/17] qemu: Introduce qemuDomainDeviceDefValidateController

Introduce the bare bones helper to validate whether the controller definition is valid. Signed-off-by: John Ferlan --- src/qemu/qemu_domain.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH 10/17] qemu: Use virDomainPCIControllerOpts in qemuBuildControllerDevStr

Shorten up a few characters and reference the pciopts pointer Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 115 +--- 1 file changed, 59 insertions(+), 56 deletions(-) diff --git a/src/qemu/qemu_command.c

[libvirt] [PATCH 00/17] Move qemu command line controller checks to qemuDomainDeviceDefValidateController* checks

Recent series to just move IDE checks: (v4: https://www.redhat.com/archives/libvir-list/2017-December/msg00049.html) gave me enough "push" in order to move the bulk of qemu_command controller command line build "validation" checks into their own Validation helpers. The IDE only checks are

[libvirt] [PATCH 16/17] qemu: Introduce qemuDomainDeviceDefValidateControllerUSB

Move the USB controller validation checs out of qemu_command and into the proper qemu_domain validation helper. We will start slowly and also modity the xml2argv test to change from a RUN to PARSE failure check when the QEMU_CAPS_PIIX3_USB_UHCI is removed. Signed-off-by: John Ferlan

[libvirt] [PATCH 07/17] qemu: Introduce qemuDomainDeviceDefValidateControllerIDE

From: Lin Ma Move the IDE controller check from command line building to controller def validation. Cause the IDE case for command line building to generate a failure if called to add an IDE since that shouldn't happen if the Validate code did the right thing. Signed-off-by:

[libvirt] [PATCH 09/17] qemu: Introduce qemuDomainDeviceDefValidateControllerPCI

Move PCI validation checks out of qemu_command into the proper qemu_domain validation helper. Since there's a lot to move, we'll start slow by replicating the check in qemuBuildControllerDevCommandLine to skip the pcie-root and pci-root tests for not pseries guests. Next we'll move the

[libvirt] [PATCH 06/17] tests: Drop IDE controller in CCW

From: Lin Ma Adding an IDE controller for a machinetype that has no built-in IDE controller, libvirt will log an error. Currently the machinetype list which returns by qemuDomainMachineHasBuiltinIDE only includes 440fx, malta, sun4u and g3beige. Signed-off-by: Lin Ma

[libvirt] [PATCH 14/17] qemu: Complete PCI command checks to controller def validate

Move the qemuCaps checks over to qemuDomainControllerDefValidatePCI and add empty lines between cases so it's a bit easier on the eyes to read. This requires two test updates in order to set the correct capability bit for an xml2xml test as well as setting up the similar capability for the

[libvirt] [PATCH 11/17] qemu: Move PCI command modelName check to controller def validate

Move the various modelName == NAME_NONE from the command line generation into domain controller validation. Also rather than have multiple cases with the same check, let's make the code more generic, but also note that it was the modelName option that caused the failure. We also have to be sure

[libvirt] [PATCH 17/17] qemu: Complete move USB command checks to controller def validate

Move the remainder of the qemuBuildUSBControllerDevStr checks over to qemuDomainDeviceDefValidateControllerUSB. This also allows the command code to shorten up a bit and become a void procedure. This also requires modifying the xml2xml test a bit in order to include the correct capability bit and

[libvirt] [PATCH 13/17] qemu: Move PCI more command checks to controller def validate

Excluding the qemuCaps checks, move the remainder of the checks that validate whether the PCI definition is valid or not into qemuDomainControllerDefValidatePCI. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 96 --

[libvirt] [PATCH 02/17] qemu: Introduce qemuDomainDeviceDefSkipController

In order to be able to reuse some code for both controller def validation and command line building, create a convenience helper that will perform the "skip" avoidance checks. It will also set some flags to allow the caller to specifically skip (or fail) depending on the result of the flag (as

[libvirt] [PATCH 04/17] qemu: Move CCW S390 Address check to controller def validate

Move the call to qemuDomainCheckCCWS390AddressSupport from qemuBuildControllerDevStr to qemuDomainDeviceDefValidateController. This means we will get the qemuCaps from the driver opaque variable passed to qemuDomainDeviceDefValidate. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 05/17] tests: Remove use of IDE disk for pseries floppy test

From: Lin Ma Adding an IDE controller for a machinetype that has no built-in IDE controller, libvirt will log an error. Currently the machinetype list which returns by qemuDomainMachineHasBuiltinIDE only includes 440fx, malta, sun4u and g3beige. Remove the disk and the .args file

[libvirt] [PATCH 12/17] qemu: Move PCI command modelName TypeToString to controller def validate

Similar to the checking the modelName vs. NAME_NONE, let's make the ModelNameTypeToString check more generic too within the checking done in controller validation (with the same ignore certain models. NB: We need to keep the ModelNameTypeToString fetch in command line validation since we use it,

[libvirt] [RESEND PATCH] qemu: Add support for hot unplug redirdev device

From: Chen Hanxiao We lacked of hot unplugging redirdev device. This patch add support for it. We could use detach-device --live now. Signed-off-by: Chen Hanxiao --- rebase on 3.10 src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_hotplug.c |

Re: [libvirt] [PATCH for 3.11 0/2] qemuxml2argvdata: Drop useless prefix for test cases

On 12/02/2017 02:11 AM, Michal Privoznik wrote: > The patches are trimmed out a lot to fit the size limit of our list. Anyway, > the interesting bits are kept and also you can find the patches at my github: > > https://github.com/zippy2/libvirt/commits/qemuxml2argvdata > > If this approach

Re: [libvirt] [PATCH 1/2] libxl: add support for multiple IP addresses

On 12/04/2017 03:27 PM, Marek Marczykowski-Górecki wrote: On Mon, Dec 04, 2017 at 03:14:33PM -0700, Jim Fehlig wrote: On 12/04/2017 02:53 PM, Marek Marczykowski-Górecki wrote: On Mon, Dec 04, 2017 at 02:46:58PM -0700, Jim Fehlig wrote: There's another instance of this check in xenFormatNet()

Re: [libvirt] [PATCH 1/2] libxl: add support for multiple IP addresses

On Mon, Dec 04, 2017 at 03:14:33PM -0700, Jim Fehlig wrote: > On 12/04/2017 02:53 PM, Marek Marczykowski-Górecki wrote: > > On Mon, Dec 04, 2017 at 02:46:58PM -0700, Jim Fehlig wrote: > > > There's another instance of this check in xenFormatNet() in > > > src/xenconfig/xen_common.c. I suppose

Re: [libvirt] [PATCH 1/2] libxl: add support for multiple IP addresses

On 12/04/2017 02:53 PM, Marek Marczykowski-Górecki wrote: On Mon, Dec 04, 2017 at 02:46:58PM -0700, Jim Fehlig wrote: There's another instance of this check in xenFormatNet() in src/xenconfig/xen_common.c. I suppose multiple IP addrs are not supported in xml <-> xl.cfg conversions. Do you have

Re: [libvirt] [PATCH 1/2] libxl: add support for multiple IP addresses

On Mon, Dec 04, 2017 at 02:46:58PM -0700, Jim Fehlig wrote: > There's another instance of this check in xenFormatNet() in > src/xenconfig/xen_common.c. I suppose multiple IP addrs are not supported in > xml <-> xl.cfg conversions. Do you have time to fix the config converter > too? Where should I

Re: [libvirt] [PATCH 2/2] tests: add test for multiple IPs for libxl driver

On 12/02/2017 07:35 PM, Marek Marczykowski-Górecki wrote: --- tests/libxlxml2domconfigdata/multiple-ip.json | 37 - tests/libxlxml2domconfigdata/multiple-ip.xml | 22 - tests/libxlxml2domconfigtest.c| 1 +- 3 files changed, 60 insertions(+)

Re: [libvirt] [PATCH 1/2] libxl: add support for multiple IP addresses

On 12/02/2017 07:35 PM, Marek Marczykowski-Górecki wrote: vif-* scripts support it for a long time, and expect addresses to be separated by spaces. Add appropriate support to libxl driver. --- src/libxl/libxl_conf.c | 29 +++-- src/libxl/libxl_domain.c | 12

[libvirt] Release of libvirt-3.10.0

A little bit late but it's out, the new release is tagged in git and signed tarball and rpms have been pushed to the usual place: ftp://libvirt.org/libvirt/ I also pushed the corresponding release of python bindings at ftp://libvirt.org/libvirt/python/ This release brings a

Re: [libvirt] [PATCH for 3.11 0/2] qemuxml2argvdata: Drop useless prefix for test cases

On Sat, Dec 02, 2017 at 08:11:48AM +0100, Michal Privoznik wrote: > The patches are trimmed out a lot to fit the size limit of our list. Anyway, > the interesting bits are kept and also you can find the patches at my github: > > https://github.com/zippy2/libvirt/commits/qemuxml2argvdata > > If

Re: [libvirt] [PATCH for 3.11 0/2] qemuxml2argvdata: Drop useless prefix for test cases

On Sat, 2017-12-02 at 08:11 +0100, Michal Privoznik wrote: > The patches are trimmed out a lot to fit the size limit of our list. Anyway, > the interesting bits are kept and also you can find the patches at my github: > > https://github.com/zippy2/libvirt/commits/qemuxml2argvdata > > If this

[libvirt] [PATCH 2/3] travis: Upgrade brew packages

Installed packages might be outdated by the time the build runs, so we should update them. Signed-off-by: Andrea Bolognani --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 480419dfd..70fee3b6a 100644 ---

[libvirt] [PATCH 1/3] util: gettid() is Linux-specific

The manual page clearly states that gettid() is Linux-specific and should not be used in programs that are intended to be portable. Unfortunately, it looks like macOS implemented the functionality and defined SYS_gettid accordingly, only to deprecate syscall() altogether with 10.12 (Sierra),

[libvirt] [PATCH 3/3] travis: Don't try to install brew packages twice

gettext, gnutls and libgcrypt are already installed on the system, so we don't need to request their installation. Signed-off-by: Andrea Bolognani --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index

[libvirt] [PATCH 0/3] macOS build and CI fixes

The first one is technically a build breaker, but only affects development builds so it can wait the end of the freeze I guess. The second patch gets Travis to the point where the build failure would actually show up, and the last one is just a small cleanup. Andrea Bolognani (3): util:

Re: [libvirt] libvirt 3.9.0 locks (was libvirt 3.5.0 locks)

2017-12-01 16:14 GMT+03:00 Nikolay Shirokovskiy : > On 01.12.2017 15:26, Vasiliy Tolstov wrote: >> Hi again. I'm still try to determine why my libvirtd locks, this is >> another portion of gdb stuff: >> https://gist.github.com/vtolstov/ae8c4a67e15b2fbd14bbb95c226fb427

[libvirt] [PATCH] virfile: relax checks for hugetlbfs

There are use cases where it is useful to use the support in libvirt for file-backed guest memory, but without using hugetlbfs but tmpfs instead (for example, to run tests on hosts that do not have hugepages configured, or to use Linux's idle page tracking to monitor guest memory accesses at a 4k

Re: [libvirt] [PATCH] apparmor: allow qemu abstraction to read /proc/pid/cmdline

On Mon, 2017-12-04 at 12:03 +0100, Michal Privoznik wrote: > On 12/01/2017 02:26 PM, Jamie Strandboge wrote: > > On Thu, 2017-11-30 at 10:43 -0700, Jim Fehlig wrote: > > > Noticed the following denial in audit.log when shutting down > > > an apparmor confined domain > > > > > > type=AVC

Re: [libvirt] [PATCH] apparmor: allow qemu abstraction to read /proc/pid/cmdline

On 12/04/2017 04:03 AM, Michal Privoznik wrote: On 12/01/2017 02:26 PM, Jamie Strandboge wrote: On Thu, 2017-11-30 at 10:43 -0700, Jim Fehlig wrote: Noticed the following denial in audit.log when shutting down an apparmor confined domain type=AVC msg=audit(1512002299.742:131):

Re: [libvirt] [PATCH v2] libvirt: Adding POWER9 DD1.0/DD2.0 PVR value to cpu_map.xml

On Mon, 2017-12-04 at 17:28 +0530, seeteena wrote: > Thanks Andrea. I don't see any error really. > > but had seen those pvr values missing for DD1/DD2.0 hardware. > > if this is not causing any impact, we can ignore this patch. Cool, let's drop it then. -- Andrea Bolognani / Red Hat /

Re: [libvirt] [PATCH] apparmor: allow qemu abstraction to read /proc/pid/cmdline

On 12/01/2017 02:26 PM, Jamie Strandboge wrote: > On Thu, 2017-11-30 at 10:43 -0700, Jim Fehlig wrote: >> Noticed the following denial in audit.log when shutting down >> an apparmor confined domain >> >> type=AVC msg=audit(1512002299.742:131): apparmor="DENIED" >> operation="open"

Re: [libvirt] [PATCH v2] libvirt: Adding POWER9 DD1.0/DD2.0 PVR value to cpu_map.xml

On Tue, 2017-11-28 at 15:16 +0530, Seeteena Thoufeek wrote: > DD1.0/DD2.0 PVR value is missing from cpu_map.xml. This patch > provides those details > > Signed-off-by: Seeteena Thoufeek > --- > src/cpu/cpu_map.xml | 2 ++ > 1 file changed, 2 insertions(+) > > diff

[libvirt] [PATCH] cfg.mk: Simplify backslash alignment check

The use of [[:blank:]] was intended to cover tabs as well, but it couldn't possibly work in its current form, so the regex was tweaked in d09429abe826. With the original reason for using [[:blank:]] now gone, we can replace its usage with plain spaces. A comment about the purpose of the check is

Re: [libvirt] [PATCH] Adjust backslash alignment syntax-check

On Thu, 2017-11-23 at 06:46 +0100, Michal Privoznik wrote: > > @@ -1038,7 +1038,7 @@ sc_prohibit_http_urls: > > $(_sc_search_regexp) > > > > sc_prohibit_backslash_alignment: > > - @prohibit='[[:blank:]][[:blank:]]\\$$' \ > > + @prohibit='([[:blank:]][[:blank:]]| )\\$$' \ > >