Re: [libvirt] [PATCH v5 3/3] libvirtd: fix crash on termination

On 22.12.2017 17:13, John Ferlan wrote: > [...] > >>> >>> Still adding the "virHashRemoveAll(dmn->servers);" into >>> virNetDaemonClose doesn't help the situation as I can still either crash >>> randomly or hang, so I'm less convinced this would really fix anything. >>> It does change the

Re: [libvirt] [PATCH v5 3/3] libvirtd: fix crash on termination

[...] >> >> Still adding the "virHashRemoveAll(dmn->servers);" into >> virNetDaemonClose doesn't help the situation as I can still either crash >> randomly or hang, so I'm less convinced this would really fix anything. >> It does change the "nature" of the hung thread stack trace though, as >>

Re: [libvirt] [PATCH v2 00/14] Fix race on srv->nclients_unauth and some other changes

On Thu, Dec 21, 2017 at 07:23 PM +0100, John Ferlan wrote: > On 12/21/2017 09:28 AM, Marc Hartmayer wrote: >> This patch series fixes some locking issues, a memory leak, some other >> cosmetic changes, and it fixes a bug that led to a libvirtd which >> doesn't accept new

Re: [libvirt] [PATCH v2 14/14] remote: add locking around the critical section in remoteSASLFinish

On Thu, Dec 21, 2017 at 07:20 PM +0100, John Ferlan wrote: > On 12/21/2017 09:29 AM, Marc Hartmayer wrote: >> ...as there is an access to priv->sasl the priv->lock is needed. >> >> Signed-off-by: Marc Hartmayer >> Reviewed-by: Bjoern Walk

Re: [libvirt] RFC: Introduce a dlm-corosync for Lock manager plugin

On Fri, Dec 22, 2017 at 12:59:24AM -0700, Lin Fu wrote: > > How are locks acquired by libdlm scoped ? The reason we have virtlockd is > > that the fcntl() locks need to be held by a running process, and we wanted > > them to persist across libvirtd restarts. This required holding them in a > >

Re: [libvirt] [PATCH v5 3/3] libvirtd: fix crash on termination

On Fri, Dec 22, 2017 at 10:52:45AM +0300, Nikolay Shirokovskiy wrote: > > > On 21.12.2017 15:14, Erik Skultety wrote: > > On Thu, Dec 21, 2017 at 12:48:44PM +0300, Nikolay Shirokovskiy wrote: > >> > >> > >> On 21.12.2017 11:49, Erik Skultety wrote: > >>> On Thu, Dec 21, 2017 at 09:39:16AM +0100,

[libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

From: zhangshengyu --- docs/schemas/domaincommon.rng | 28 + src/conf/domain_conf.c | 8 src/qemu/qemu_block.c | 24 ++- src/qemu/qemu_command.c

Re: [libvirt] [PATCH v5 3/3] libvirtd: fix crash on termination

On 21.12.2017 17:59, John Ferlan wrote: > [...] > >>> >>> Patch looks good to me too. But still original "libvirtd: fix crash on >>> termination" >>> fixes another issue and if applied fixes "virt-manager issue" as well as >>> John >>> figured out. > > Not sure there's enough coffee in the

[libvirt] [PATCH v3 0/2] qemu: Add support for hot unplugging

v3: use helper qemuDomainDelChardevTLSObjects and address some comments v2: rebased on master Chen Hanxiao (2): qemu: Add support for hot unplugging redirdev device which can use the detach-device --live news: add change of hot unplug redirdev docs/news.xml | 11 ++

Re: [libvirt] RFC: Introduce a dlm-corosync for Lock manager plugin

> How are locks acquired by libdlm scoped ? The reason we have virtlockd is > that the fcntl() locks need to be held by a running process, and we wanted > them to persist across libvirtd restarts. This required holding them in a > separate process. Locks are managed by 'dlm_controld' daemon.

Re: [libvirt] [PATCH v5 3/3] libvirtd: fix crash on termination

On 21.12.2017 15:57, John Ferlan wrote: > [...] > >>> >>> So short story made really long, I think the best course of action will >>> be to add this patch and reorder the Unref()'s (adminProgram thru srv, >>> but not dmn). It seems to resolve these corner cases, but I'm also open >>> to other

[libvirt] [PATCH v3 2/2] news: add change of hot unplug redirdev

From: Chen Hanxiao Add hot unplug redirdev in news 'Improvements' section Signed-off-by: Chen Hanxiao --- v3: move it into 'Improvements' section docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml

[libvirt] [PATCH v3 1/2] qemu: Add support for hot unplugging redirdev device which can use the detach-device --live

From: Chen Hanxiao We lacked of hot unplugging redirdev device. This patch add support for it. We could use detach-device --live now. Signed-off-by: Chen Hanxiao --- v3: use helper qemuDomainDelChardevTLSObjects address John's comments v2: