[libvirt] [PATCH 2/3] cpu_x86: Add debug messages to x86DecodeUseCandidate

When translating CPUID data into CPU model + features, the code sometimes uses an unexpected CPU model. There may be several reasons for this, starting with wrong expectations and ending with an actual bug in our code. These debug messages will help determining the reason. Signed-off-by: Jiri

[libvirt] [PATCH 3/3] cpu_x86: Copy CPU signature from ancestor

When specifying a new CPU model in cpu_map.xml as an extension to an existing model, we forgot to copy the signature (family + model) from the original CPU model. We don't use this way of specifying CPU models, but it's still supported and it becomes useful when someone wants to quickly hack up a

[libvirt] [PATCH 1/3] cputest: Fix cpu-cpuid.py diff command

The cpuidMap in cpu-cpuid.py was created for converting old data files (with QEMU's feature-words bits) to the new model-expansion based data. When I added tests for CPU live update based on disabled/enabled feature lists I shamelessly used the existing cpuidMap for generating the

[libvirt] [PATCH 0/3] cpu_x86: Few small fixes

I found these issues when working on patches and tests for CVE-2017-5715 part of Spectre. Jiri Denemark (3): cputest: Fix cpu-cpuid.py diff command cpu_x86: Add debug messages to x86DecodeUseCandidate cpu_x86: Copy CPU signature from ancestor src/cpu/cpu_x86.c

Re: [libvirt] [PATCH v4.1 0/2] qemu: Add support for hot unplugging redirdev

On 01/06/2018 12:59 AM, Chen Hanxiao wrote: > v4.1: > call qemuDomainRemoveRedirdevDevice in qemuDomainRemoveDevice > v4: > update commit messages and news > v3: > use helper qemuDomainDelChardevTLSObjects and address some comments > v2: > rebased on master > > > Chen Hanxiao (2): >

[libvirt] [PATCH V2] nodedev: Fix failing to parse PCI address for non-PCI network devices

Based loosely on a patch from Fei Li . Commit 8708ca01c added virNetDevSwitchdevFeature() to check if a network device has Switchdev capabilities. virNetDevSwitchdevFeature() attempts to retrieve the PCI device associated with the network device, ignoring non-PCI devices. It does

Re: [libvirt] [PATCH] nodedev: Fix failing to parse PCI address for non-PCI network devices

On 01/03/2018 01:40 AM, Erik Skultety wrote: On Fri, Dec 22, 2017 at 01:05:26PM +0800, Fei Li wrote: Commit 8708ca01c added virNetDevSwitchdevFeature to check whether the NIC had Switchdev capabilities; however this causes errors for network devices whose address is not in PCI format, like qeth

Re: [libvirt] [PATCH] qemu: Prepare BIOS/UEFI when starting a domain

On 01/03/2018 02:20 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1527740 > > Users might use a block device as UEFI VAR store. Or even have > OVMF stored there. Therefore, when starting a domain and separate > mount namespace is used, we have to create all the /dev

Re: [libvirt] [PATCH] tests: Only format the CPU frequency if it's known

On 01/08/2018 09:50 AM, Peter Krempa wrote: > On Mon, Jan 08, 2018 at 15:10:29 +0100, Andrea Bolognani wrote: >> Instead of formatting 'MHz: 0', which can be confusing, skip the >> field altogether. This behavior is consistent with that of 'virsh >> nodeinfo'. >> >> Suggested-by: John Ferlan

[libvirt] [PATCH v2] nodedev: update mdev_types caps before dumpxml

In current implemention, mdev_types caps keep constant all the time. But, it is possible that a device capable of mdev_types sometime(for example:bind to proper driver) and incapable of mdev_types at other times(for example: unbind from its driver). We should keep the info of xml dumped out

Re: [libvirt] [PATCH] tests: Only format the CPU frequency if it's known

On Mon, Jan 08, 2018 at 15:10:29 +0100, Andrea Bolognani wrote: > Instead of formatting 'MHz: 0', which can be confusing, skip the > field altogether. This behavior is consistent with that of 'virsh > nodeinfo'. > > Suggested-by: John Ferlan > Signed-off-by: Andrea Bolognani

Re: [libvirt] [PATCH v3 5/5] util: Don't report CPU frequency for ARM hosts

On Fri, 2018-01-05 at 15:52 -0500, John Ferlan wrote: > Suggestion - follow cmdNodeinfo for virhostcputest.c and don't print the > MHz if it's 0. It's the indication that the data wasn't obtainable. I > think printing 0 is perhaps just as bad as printing the erroneous 100. > > I trust you can

[libvirt] [PATCH] tests: Only format the CPU frequency if it's known

Instead of formatting 'MHz: 0', which can be confusing, skip the field altogether. This behavior is consistent with that of 'virsh nodeinfo'. Suggested-by: John Ferlan Signed-off-by: Andrea Bolognani --- .../linux-aarch64-f21-mustang.expected

Re: [libvirt] [PATCH] virsh: Checking the volume capacity before uploading a new file.

On Mon, Jan 08, 2018 at 13:55:10 +0100, Peter Krempa wrote: > On Sun, Jan 07, 2018 at 21:31:24 -0200, Julio Faracco wrote: > > The current command 'vol-upload' is not checking if the volume accepts > > a file bigger than its capacity. It can cause an interrupt of the > > upload stream. This

Re: [libvirt] [PATCH] virsh: Checking the volume capacity before uploading a new file.

On Sun, Jan 07, 2018 at 21:31:24 -0200, Julio Faracco wrote: > The current command 'vol-upload' is not checking if the volume accepts > a file bigger than its capacity. It can cause an interrupt of the > upload stream. This commit adds a check that fails before starting to > send new file to

Re: [libvirt] [PATCH 3/3] util: virsysinfo: parse frequency information on S390

On 01/08/2018 03:39 AM, Bjoern Walk wrote: > John Ferlan [2018-01-04, 03:56PM -0500]: >> On 12/19/2017 05:08 AM, Bjoern Walk wrote: >>> diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c >>> index ab81b1f7..0c2267e3 100644 >>> --- a/src/util/virsysinfo.c >>> +++

Re: [libvirt] [PATCH v3 2/5] util: virhostcpu: factor out frequency parsing

On Fri, 2018-01-05 at 15:41 -0500, John Ferlan wrote: > > src/util/virhostcpu.c | 141 > > ++ > > 1 file changed, 62 insertions(+), 79 deletions(-) > > Couple of nits... see below > > Reviewed-by: John Ferlan > > > diff

Re: [libvirt] [PATCH] cpu: Add support for al57 Intel features

On 2018年01月05日 02:52, John Ferlan wrote: On 12/17/2017 06:02 PM, Shaohe Feng wrote: We can start qemu with a "cpu,+la57" to set 57-bit vitrual address space. So VM can be aware that it need to enable 5-level paging. Corresponding QEMU commits: al57

Re: [libvirt] [PATCH v2 2/2] tests: Adding test case for 'domrename' command inside virshtest.

On Mon, Jan 08, 2018 at 01:03:00 -0200, Julio Faracco wrote: > This commit adds a domrename test case inside the 'virshtest' test for > test driver. > > Signed-off-by: Julio Faracco > --- > tests/virshtest.c | 13 + > 1 file changed, 13 insertions(+) > > diff

Re: [libvirt] [PATCH 2/5] util: introduce virHostCPUGetMicrocodeVersion

On Thursday, 4 January 2018 16:27:45 CET Jiri Denemark wrote: > It's not pointless. It makes the log useful without having to look at > /usr/include/asm-generic/errno-base.h. And it will only be done once in > libvirtd lifetime so it's not really wasting CPU cycles or something. Theoretically you

Re: [libvirt] [PATCH v2 1/2] test: Implementing testDomainRename().

On Mon, Jan 08, 2018 at 01:02:59 -0200, Julio Faracco wrote: > There is no method to rename inactive domains for test driver. > After this patch, we can rename the domains using 'domrename'. > > virsh# domrename test anothertest > Domain successfully renamed > > Signed-off-by: Julio

Re: [libvirt] [PATCH 3/3] util: virsysinfo: parse frequency information on S390

John Ferlan [2018-01-04, 03:56PM -0500]: > On 12/19/2017 05:08 AM, Bjoern Walk wrote: > > diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c > > index ab81b1f7..0c2267e3 100644 > > --- a/src/util/virsysinfo.c > > +++ b/src/util/virsysinfo.c > > @@ -495,6 +495,7 @@

Re: [libvirt] [PATCH 1/3] util: virhostcpu: parse frequency information on S390

John Ferlan [2018-01-05, 03:53PM -0500]: > > > On 12/19/2017 05:08 AM, Bjoern Walk wrote: > > Since kernel version 4.7, processor frequency information is available > > on S390. Let's adjust the parser so this information shows up for virsh > > nodeinfo: > > > > # virsh

Re: [libvirt] [PATCH 1/3] util: virhostcpu: parse frequency information on S390

John Ferlan [2018-01-05, 03:13PM -0500]: > Doh - should have read the cover letter - this goes on top of > Andrea's changes... Sometimes it's just better to wait and/or provide > review to the series you trying to use! > Ye, sorry, should have made it more clear or

Re: [libvirt] [PATCH 2/3] tests: virhostcputest: testcase for S390 system

John Ferlan [2018-01-05, 03:55PM -0500]: > > > On 12/19/2017 05:08 AM, Bjoern Walk wrote: > > Let's add a testcase for a S390 system running kernel version 4.14 on > > LPAR. > > > > Reviewed-by: Marc Hartmayer > > Reviewed-by: Boris Fiuczynski