Re: [libvirt] [PATCH] virsh: fix build without readline

2018-01-13 Thread Roman Bogorodskiy
John Ferlan wrote: > > > On 01/13/2018 02:00 AM, Roman Bogorodskiy wrote: > > Completion in virsh is enabled when readline is available. However, > > when it's not available, we should: > > > > * avoid defining completers with completion functions; > > * in cmdComplete(), mark unused

[libvirt] [PATCH v2] virsh: fix build without readline

2018-01-13 Thread Roman Bogorodskiy
Completion in virsh is enabled when readline is available. In order to fix build when it's not available, do the following: * Unconditionally add virsh-completer.[ch] and virt-admin-completer.[ch] to the build, and provide stub functions for when readline is not available. This way virsh

Re: [libvirt] [PATCH] virsh: fix build without readline

2018-01-13 Thread John Ferlan
On 01/13/2018 02:00 AM, Roman Bogorodskiy wrote: > Completion in virsh is enabled when readline is available. However, > when it's not available, we should: > > * avoid defining completers with completion functions; > * in cmdComplete(), mark unused arguments when there's no readline with >

[libvirt] [PATCH] AppArmor: Allow libvirtd to kill unconfined processes

2018-01-13 Thread intrigeri+libvirt
From: intrigeri On startup libvirtd runs a number of QEMU processes unconfined such as: /usr/bin/qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -machine none,accel=kvm:tcg -qmp unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowait