Christian Ehrhardt:
> I recently had spotted this issue and discussed on IRC but couldn't
> recreate after a while when I wanted to debug.
I've seen it the last few times I've started libvirtd.service on two
different Debian sid ("unstable") systems.
> But the reason and the rule totally make sen
Apparently we can't assume that people run readline recent enough
to have rl_completion_quote_character (added in readline-5.0
released in 2011). However, we can't compile without it. So if
not present, disable readline.
Signed-off-by: Michal Privoznik
---
Frankly, I hate this patch. How far int
When building without readline, this function does nothing but
return false. Without touching any of its arguments. Therefore,
we have to mark them as unused even though they might be used
when building with readline support.
Signed-off-by: Michal Privoznik
---
tools/vsh.c | 3 ++-
1 file change
The functions defined in these sources are referenced all over
the place, however, compiler only when building with readline.
Thus when building without it linker gets sad as it can't find
them.
Signed-off-by: Michal Privoznik
---
tools/Makefile.am | 20 ++--
1 file changed, 2 in
After I've merged bash completion patches, couple of build problems
emerged.
Michal Privoznik (3):
vsh: Mark cmdComplete arguments as unused
tools: Always compile {virsh,virt-admin}-completer.c
m4: Check for rl_completion_quote_character
m4/virt-readline.m4 | 13 +
tools/Makefi
On Sat, Jan 13, 2018 at 9:54 AM, wrote:
> From: intrigeri
>
> On startup libvirtd runs a number of QEMU processes unconfined such as:
>
> /usr/bin/qemu-system-x86_64 -S -no-user-config -nodefaults -nographic
> -machine none,accel=kvm:tcg -qmp
> unix:/var/lib/libvirt/qemu/capabilities.monitor
