Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

2018-01-16 Thread John Ferlan
On 01/16/2018 03:52 AM, lichs...@gmail.com wrote: > From: zhangshengyu > This needs to be split up better into multiple patches - there are many examples of how to do that. Just see how patches were done the last time someone added a new transport type. Typically

[libvirt] Libvirt fails to apply security context to fd/node to USB device

2018-01-16 Thread Randy Aybar
Hi, I'm attempting to attach and expose a USB device (WiFi adapter for testing) to an LXC container with SELinux enabled. But when enabling the XML snippet, the container fails to start with this error: 2018-01-12 19:24:31.914+: 2181: error : virSecuritySELinuxSetFileconHelper:1182 :

Re: [libvirt] [PATCH] docs: formatdomain: Document the CPU feature 'name' attribute

2018-01-16 Thread Eduardo Habkost
On Fri, Jan 12, 2018 at 08:31:16PM +0100, Kashyap Chamarthy wrote: > Currently, the CPU feature 'name' XML attribute, as in: > > [...] > > IvyBridge > Intel > > > [...] > > isn't explicitly documented in formatdomain.html. > > Document it now. > >

[libvirt] [PATCH] qemu: avoid denial of service reading from QEMU monitor (CVE-2018-xxxx)

2018-01-16 Thread Daniel P. Berrange
We read from QEMU until seeing a \r\n pair to indicate a completed reply or event. To avoid memory denial-of-service though, we must have a size limit on amount of data we buffer. 10 MB is large enough that it ought to cope with normal QEMU replies, and small enough that we're not consuming

[libvirt] [PATCH] tools: avoid text spilling into variables

2018-01-16 Thread Dariusz Gadomski
From: Christian Ehrhardt While libvirt-guests.sh is running cases can let guest_is_on fail which causes check_guests_shutdown to print output. That output shall not spill into the users of function check_guests_shutdown which is therefore now returning values in

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-16 Thread Kang, Luwei
> > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > CCing libvirt developers. > > ... > > > This case is slightly more problematic, however: the new feature is > > > actually migratable (under very controlled circumstances) because of > > > patch 2/2, but it is not

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

2018-01-16 Thread Eduardo Habkost
On Tue, Jan 16, 2018 at 06:10:17AM +, Kang, Luwei wrote: > > > On Mon, Jan 15, 2018 at 12:04:55 -0200, Eduardo Habkost wrote: > > > > CCing libvirt developers. > > > ... > > > > This case is slightly more problematic, however: the new feature is > > > > actually migratable (under very

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

2018-01-16 Thread Andrea Bolognani
On Mon, 2018-01-15 at 18:51 +0100, Michal Privoznik wrote: > > At least FreeBSD ships it, though: > > > > # pkg list readline | grep pc$ > > /usr/local/libdata/pkgconfig/readline.pc > > is this GNU readline? I've heard that FreeBSD is ditching GNU software. FreeBSD (starting with version

Re: [libvirt] [PATCH] check/add for mdev_types capability

2018-01-16 Thread Erik Skultety
On Tue, Jan 16, 2018 at 12:04:53AM -0500, Dan Zheng wrote: > >From be62ea5394d52fa168079edc3aa7e558363a3026 Mon Sep 17 00:00:00 2001 > From: Dan Zheng > Date: Tue, 16 Jan 2018 12:21:21 +0800 > Subject: [PATCH] nodedev: check/add for mdev_types capability > > This is similar to

[libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

2018-01-16 Thread lichstor
From: zhangshengyu --- docs/schemas/domaincommon.rng | 28 + src/conf/domain_conf.c | 8 src/qemu/qemu_block.c | 24 ++- src/qemu/qemu_command.c