Hi, all.
It turns out that systemd daemon-reload reset settings that are managable
thru 'systemctl set-property' interface.
> virsh schedinfo tst3 | grep global_quota
global_quota : -1
> virsh schedinfo tst3 --set global_quota=5 | grep global_quota
global_quota : 5
> systemctl daemon
Just noticed this list is for development-related discussions, sorry for
sending support question. Will resend to libvirt-users.
On Mon, Jan 29, 2018 at 5:08 PM, Thiago Padilha
wrote:
> I have a container rootfs that I use to keep all work-related stuff. This
> container was originally created b
On 01/29/2018 12:53 PM, Ján Tomko wrote:
> On Mon, Jan 29, 2018 at 12:43:14PM -0500, John Ferlan wrote:
>>
>>
>> On 01/29/2018 04:18 AM, Ján Tomko wrote:
>>> On Fri, Jan 05, 2018 at 06:47:25PM -0500, John Ferlan wrote:
Move the checks that various attributes are not set on any controller
>>>
On Mon, Jan 29, 2018 at 05:54:03PM +0100, Ján Tomko wrote:
On Mon, Jan 29, 2018 at 05:45:44PM +0100, Martin Kletzander wrote:
We are skipping non-directories under /sys/fs/resctrl/(info/) since those are
not
interesting for us. However in tests it can sometimes happen that ent->d_type
is 0 ins
I have a container rootfs that I use to keep all work-related stuff. This
container was originally created by lxd (which creates all containers for
use with user namespacing), but now I decided to start using libvirt for
container management since I already use it for virtual machines, which
will s
On 01/28/2018 03:48 AM, Michal Privoznik wrote:
> On 01/06/2018 12:47 AM, John Ferlan wrote:
>> Move the qemuCaps checks over to qemuDomainControllerDefValidatePCI.
>>
>> This requires two test updates in order to set the correct capability
>> bit for an xml2xml test as well as setting up the sim
On Mon, Jan 29, 2018 at 12:43:14PM -0500, John Ferlan wrote:
On 01/29/2018 04:18 AM, Ján Tomko wrote:
On Fri, Jan 05, 2018 at 06:47:25PM -0500, John Ferlan wrote:
Move the checks that various attributes are not set on any controller
other than SCSI controller using virtio-scsi model into the
On 01/29/2018 04:18 AM, Ján Tomko wrote:
> On Fri, Jan 05, 2018 at 06:47:25PM -0500, John Ferlan wrote:
>> Move the checks that various attributes are not set on any controller
>> other than SCSI controller using virtio-scsi model into the common
>> controller validate checks.
>>
>> Need to also
On 01/29/2018 04:28 AM, Ján Tomko wrote:
> On Sun, Jan 28, 2018 at 09:48:19AM +0100, Michal Privoznik wrote:
>> On 01/06/2018 12:47 AM, John Ferlan wrote:
>>> Move the checks that various attributes are not set on any controller
>>> other than SCSI controller using virtio-scsi model into the comm
On 01/28/2018 03:48 AM, Michal Privoznik wrote:
> On 01/06/2018 12:47 AM, John Ferlan wrote:
>> Rather than one function serving two purposes, let's split things
>> up into qemuDomainResetSCSIControllerModel for all current callers
>> and then add qemuDomainCheckSCSIControllerModel when building
Commits f83c7c88 and 6eb1f2b9 broke the build on FreeBSD and OSX because
of symbols being undefined for those platforms.
Signed-off-by: Erik Skultety
---
Pushed under the build breaker rule.
src/conf/node_device_conf.c | 6 ++
src/util/virpci.c | 9 +
2 files changed, 15
On Mon, Jan 29, 2018 at 04:31:40PM +0100, Martin Kletzander wrote:
The first patch is the only interesting one.
Martin Kletzander (4):
util: Check for empty allocation instead of just NULL pointer
util: Use "resctrl" instead of "resctrlfs" spelling
util: Make it possible for virResctrlAllocSe
On Mon, Jan 29, 2018 at 05:45:44PM +0100, Martin Kletzander wrote:
We are skipping non-directories under /sys/fs/resctrl/(info/) since those are
not
interesting for us. However in tests it can sometimes happen that ent->d_type
is 0 instead of 4 (DT_DIR) for directories.
I've seen it fail on tw
We are skipping non-directories under /sys/fs/resctrl/(info/) since those are
not
interesting for us. However in tests it can sometimes happen that ent->d_type
is 0 instead of 4 (DT_DIR) for directories.
I've seen it fail on two machines. Different machines, different systems, I
cannot reproduc
We are skipping non-directories under /sys/fs/resctrl/(info/) since those are
not
interesting for us. However in tests it can sometimes happen that ent->d_type
is 0 instead of 4 (DT_DIR) for directories.
I've seen it fail on two machines. Different machines, different systems, I
cannot reproduc
Convert the stats field in _qemuDomainJobInfo to be a union. This
will allow for the collection of various different types of stats
in the same field. While doing this, also change the name of the
field from @stats to @migStats to make it easier to find.
When starting the async job that will end u
Signed-off-by: John Ferlan
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 2268fdf79..60f2742fa 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -56,6 +56,17 @@
interfaces, NWFilters, and so on).
Extract out the parts of qemuDomainGetJobStatsInternal that get
the migration stats. We're about to add the ability to get just
dump information.
Signed-off-by: John Ferlan
---
src/qemu/qemu_driver.c | 52 --
1 file changed, 33 insertions(+), 19 de
Add an API to allow fetching the memory only dump statistics
for a job via the qemuDomainGetJobInfo API. This adds a new
statsType QEMU_DOMAIN_JOB_STATS_TYPE_MEMDUMP and corresponding
data structure to the stats union in _qemuDomainJobInfo.
Signed-off-by: John Ferlan
---
src/qemu/qemu_domain.c |
https://bugzilla.redhat.com/show_bug.cgi?id=916061
If the QEMU version running is new enough (based on the DUMP_COMPLETED
event), then we can add a 'detach' boolean to the dump-guest-memory
command in order to tell QEMU to run in a thread. This ensures that we
don't lock out other commands while t
Add a TYPE_SAVEDUMP so that when coalescing stats for a save or
dump we don't needlessly try to get the mirror stats for a migration.
Other conditions can still use MIGRATION and SAVEDUMP interchangably
including usage of the @migStats field to fetch/store the data.
Signed-off-by: John Ferlan
---
v2: https://www.redhat.com/archives/libvir-list/2018-January/msg00636.html
Summary of changes since v2:
* Generate a dump stats extraction helper in order to share with the
DUMP_COMPLETED event and the query-dump command. Additionally add the
error string from Qemu to be processed later
Add data to qemuDomainJobObj in order to store the dump completion
event information. Once the event has been received future code
waiting on the event will be able to process the stats and error
buffer. If there's no async job, we can just ignore.
Signed-off-by: John Ferlan
---
src/qemu/qemu_do
Add the DUMP_COMPLETED check to the capabilities. This is the
mechanism used to determine whether the dump-guest-memory command
can support the "-detach" option and thus be able to wait on the
event and allow for a query of the progress of the dump.
Signed-off-by: John Ferlan
---
src/qemu/qemu_c
Add a @detach parameter to the API in order allow running the QEMU
code as a thread.
Signed-off-by: John Ferlan
---
src/qemu/qemu_driver.c | 2 +-
src/qemu/qemu_monitor.c | 7 +--
src/qemu/qemu_monitor.h | 3 ++-
src/qemu/qemu_monitor_json.c | 4 +++-
src/qemu/qemu_monitor_js
The event will be fired when the domain memory only dump completes.
Alloc a return buffer to store/pass along the dump statistics that
will be eventually shared by a query-dump command.
Signed-off-by: John Ferlan
---
src/qemu/qemu_monitor.c | 29
src/qemu/qemu_monitor.
Add the query-dump API's in order to allow the dump-guest-memory
to be used to monitor progress. This will use the dump stats
extraction helper to fill a return buffer.
Signed-off-by: John Ferlan
---
src/qemu/qemu_monitor.c | 9 +
src/qemu/qemu_monitor.h | 2 ++
src/qemu/qemu
We are skipping non-directories under /sys/fs/resctrl/info/ since those are not
interesting for us. However in tests it can sometimes happen that ent->d_type
is 0 instead of 4 (DT_DIR) for directories.
I've seen it fail on two machines. Different machines, different systems, I
cannot reproduce i
We are skipping non-directories under /sys/fs/resctrl/info/ since those are not
interesting for us. However in tests it can sometimes happen that ent->d_type
is 0 instead of 4 (DT_DIR) for directories.
I've seen it fail on two machines. Different machines, different systems, I
cannot reproduce i
This wil be used in the future, but it makes sense for now as well. It makes
sure there is no mask leftover that would leak.
Signed-off-by: Martin Kletzander
---
src/util/virresctrl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index a1d09c5
Signed-off-by: Martin Kletzander
---
src/util/virresctrl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index 89b1382b6857..684cb22fd8a2 100644
--- a/src/util/virresctrl.c
+++ b/src/util/virresctrl.c
@@ -392,7 +392,6 @@ int
virResctrlGetInfo(
Pointed out during review on one or two places, but it actually appears in lot
more places. So let's be consistent.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_process.c | 2 +-
src/util/virresctrl.c | 14 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/s
When working on the CAT series one of the changes was that the pointer got
allocated in another part of the code, even when resctrl was not available on
the host system. However this one particular place neglected that so it needs
to be fixed in order to get the proper error message when requestin
The first patch is the only interesting one.
Martin Kletzander (4):
util: Check for empty allocation instead of just NULL pointer
util: Use "resctrl" instead of "resctrlfs" spelling
util: Make it possible for virResctrlAllocSetMask to replace existing
mask
util: Remove unused variable
On Thu, Jan 25, 2018 at 10:23:47AM +0100, Erik Skultety wrote:
> TL;DR:
> nodedev:
> - contained a decent amount of redundant code handling the same thing,
> now it doesn't.
> - only updated dynamic capabilities during dumpXML, now it does every
> time it tou
On Mon, Jan 29, 2018 at 02:02:19PM +0100, Michal Privoznik wrote
> On 01/29/2018 01:24 PM, Erik Skultety wrote:
> > On Fri, Jan 26, 2018 at 12:39:00PM +0100, Michal Privoznik wrote:
> >> On 01/25/2018 10:23 AM, Erik Skultety wrote:
> >>> This is a replacement for the existing udevPCIGetMdevTypesCap
On 01/29/2018 01:24 PM, Erik Skultety wrote:
> On Fri, Jan 26, 2018 at 12:39:00PM +0100, Michal Privoznik wrote:
>> On 01/25/2018 10:23 AM, Erik Skultety wrote:
>>> This is a replacement for the existing udevPCIGetMdevTypesCap which is
>>> static to the udev backend. This simple helper constructs t
On 01/26/2018 04:07 AM, John Ferlan wrote:
>
>
> On 01/18/2018 11:04 AM, Michal Privoznik wrote:
>> This is a definition that holds information on SCSI persistent
>> reservation settings. The XML part looks like this:
>>
>>
>>
>>
>>
>> If @managed is set to 'yes' then the is not parse
On Thu, 2018-01-25 at 16:16 +, Daniel P. Berrangé wrote:
> > My reasoning was to try and organize them the
> > way we already do with and capabilities - even
> > though pSeries is not a hypervisor per se, you can kinda see
> > sPAPR as a specification implemented by various hypervisors, like
On Mon, Jan 29, 2018 at 16:35:34 +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
> of VM from the output of /proc/net/arp
>
> Signed-off-by: Chen Hanxiao
> ---
> v3:
> add docs in virDomainInterfaceAddresses
> remove err
On Fri, Jan 26, 2018 at 12:39:00PM +0100, Michal Privoznik wrote:
> On 01/25/2018 10:23 AM, Erik Skultety wrote:
> > This is a replacement for the existing udevPCIGetMdevTypesCap which is
> > static to the udev backend. This simple helper constructs the sysfs path
> > from the device's base path fo
On Thu, 2018-01-25 at 16:58 +, Daniel P. Berrangé wrote:
> On Thu, Jan 25, 2018 at 05:45:51PM +0100, Andrea Bolognani wrote:
> > Basically all existing guest types, regardless of the architectur,
> > get both a USB controller and a virtio memory balloon by default.
> >
> > s390 guests are an e
On Mon, Jan 29, 2018 at 16:35:33 +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> introduce helper to parse /proc/net/arp and
> store it in struct virArpTable.
>
> Signed-off-by: Chen Hanxiao
> ---
> v3:
> s/virGetArpTable/virArpTableGet
> alloc virArpTable in virArpTableGet
> return E
On 01/23/2018 03:42 AM, Julio Faracco wrote:
> Hi Peter,
>
> I agree about "length" parameter.
> What I didn't understand is this error (check my test case):
>
> # virsh vol-create-as --pool disk-loop loop0 --capacity 20M
>
> # virsh vol-info loop0 disk-loop
> Name: loop0
> Type:
On Fri, Jan 26, 2018 at 01:35:27PM +, Daniel P. Berrangé wrote:
> Currently the secondary drivers can only be used if you have a
> connection to a primary hypervisor driver. This series introduces
> explicit URIs that allow opening a connection that only talks to a
> specific secondary driver.
On 01/29/2018 12:07 PM, Peter Krempa wrote:
> On Mon, Jan 29, 2018 at 07:09:54 +0100, Michal Privoznik wrote:
>> On 12/20/2017 07:35 AM, Nikolay Shirokovskiy wrote:
>>> Host tcp4/tcp6 ports is a global resource thus we need to make
>>> port accounting also global or we have issues described in [1]
On Mon, Jan 29, 2018 at 07:09:54 +0100, Michal Privoznik wrote:
> On 12/20/2017 07:35 AM, Nikolay Shirokovskiy wrote:
> > Host tcp4/tcp6 ports is a global resource thus we need to make
> > port accounting also global or we have issues described in [1] when
> > port allocator ranges of different ins
On Fri, Jan 26, 2018 at 13:35:27 +, Daniel Berrange wrote:
> Currently the secondary drivers can only be used if you have a
> connection to a primary hypervisor driver. This series introduces
> explicit URIs that allow opening a connection that only talks to a
> specific secondary driver. In th
On Fri, Jan 26, 2018 at 13:35:37 +, Daniel Berrange wrote:
> Now that we can open connections to the secondary drivers on demand,
> there is no need to pass a virConnectPtr into all the backend
> functions.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/storage/storage_backend.h
On Fri, Jan 26, 2018 at 13:35:36 +, Daniel Berrange wrote:
> Instead of passing around a virConnectPtr object, just open a connection
> to the secret driver at time of use. Opening connections on demand will
> be beneficial when the secret driver is in a separate daemon. It also
> solves the pr
On Fri, Jan 26, 2018 at 13:35:29 +, Daniel Berrange wrote:
> Allow the possibility of opening a connection to only the storage
> driver, by defining storage:///system and storage:///session URIs
> and registering a fake hypervisor driver that supports them.
>
> The hypervisor drivers can now d
Hi Jirka,
On Thu, Jan 25, 2018 at 8:43 PM, Jiri Denemark wrote:
> On Thu, Jan 25, 2018 at 19:51:23 +0530, Prerna Saxena wrote:
> > In case of non-p2p migration, in case libvirt client gets disconnected
> from source libvirt
> > after PERFORM phase is over, the daemon just resets the current
> mi
On Sun, Jan 28, 2018 at 09:48:19AM +0100, Michal Privoznik wrote:
On 01/06/2018 12:47 AM, John Ferlan wrote:
Move the checks that various attributes are not set on any controller
other than SCSI controller using virtio-scsi model into the common
controller validate checks.
Need to also add a qe
On Fri, Jan 05, 2018 at 06:47:25PM -0500, John Ferlan wrote:
Move the checks that various attributes are not set on any controller
other than SCSI controller using virtio-scsi model into the common
controller validate checks.
Need to also add a qemuDomainResetSCSIControllerModel call in order
to
On 01/29/2018 09:47 AM, Erik Skultety wrote:
> On Fri, Jan 26, 2018 at 12:40:46PM +0100, Michal Privoznik wrote:
>> On 01/25/2018 10:23 AM, Erik Skultety wrote:
>>> We currently have 2 methods that do the capability matching. This should
>>> be condensed to a single function and all the derivates s
On 01/29/2018 09:42 AM, Erik Skultety wrote:
> On Fri, Jan 26, 2018 at 12:40:34PM +0100, Michal Privoznik wrote:
>> On 01/25/2018 10:23 AM, Erik Skultety wrote:
>>> This patch drops the capability matching redundancy by simply converting
>>> the string input to our internal types which are then in
On 01/15/2018 08:18 PM, Julio Faracco wrote:
> This commit introduce the virsh-rename test script to test the 'domrename'
> command. The test contains one succedeed script to rename and another
> failed test.
>
> Signed-off-by: Julio Faracco
> ---
> tests/Makefile.am | 1 +
> tests/virsh-renam
On 01/15/2018 08:18 PM, Julio Faracco wrote:
> There is no method to rename inactive domains for test driver.
> After this patch, we can rename the domains using 'domrename'.
>
> virsh# domrename test anothertest
> Domain successfully renamed
>
> Signed-off-by: Julio Faracco
> ---
> src
On Fri, Jan 26, 2018 at 12:40:46PM +0100, Michal Privoznik wrote:
> On 01/25/2018 10:23 AM, Erik Skultety wrote:
> > We currently have 2 methods that do the capability matching. This should
> > be condensed to a single function and all the derivates should just call
> > into that using a proper typ
On Fri, Jan 26, 2018 at 12:40:34PM +0100, Michal Privoznik wrote:
> On 01/25/2018 10:23 AM, Erik Skultety wrote:
> > This patch drops the capability matching redundancy by simply converting
> > the string input to our internal types which are then in turn used for
> > the actual capability matching
From: Chen Hanxiao
We can use:
domifaddr f26-cloud --source arp
to get the address.
Acked-by: Michal Privoznik
Signed-off-by: Chen Hanxiao
---
tools/virsh-domain-monitor.c | 2 ++
tools/virsh.pod | 7 ---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/
From: Chen Hanxiao
Signed-off-by: Chen Hanxiao
---
v3:
more verbose description
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 2268fdf79..706546e6d 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -56,6 +56,15 @@
int
introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the output of /proc/net/arp
Chen Hanxiao (4):
util: introduce helper to parse /proc/net/arp
qemu: introduce qemuARPGetInterfaces to get IP from host's arp table
virsh: add --source arp to domifaddr
news: qemu: us
From: Chen Hanxiao
introduce VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP to get ip address
of VM from the output of /proc/net/arp
Signed-off-by: Chen Hanxiao
---
v3:
add docs in virDomainInterfaceAddresses
remove error label
show network interface which did not match the arp table
include/li
From: Chen Hanxiao
introduce helper to parse /proc/net/arp and
store it in struct virArpTable.
Signed-off-by: Chen Hanxiao
---
v3:
s/virGetArpTable/virArpTableGet
alloc virArpTable in virArpTableGet
return ENOSUPP on none-Linux platform
move helpers to virarptable.[ch]
po/POTFILES.in
On Thu, Jan 25, 2018 at 05:44:04PM +, Daniel P. Berrangé wrote:
The flock() function and d_type field in struct dirent are not portable
to the mingw platform.
Signed-off-by: Daniel P. Berrangé
---
* Pushed as CI build fix
Thanks for that. I have not seen a failure on travis, but I mis
66 matches
Mail list logo
