[libvirt] [PATCH] libxl: add support for specifying clock offset and adjustment

libxl supports setting the domain real time clock to local time or UTC via the localtime field of libxl_domain_build_info. Adjustment of the clock is also supported via the rtc_timeoffset field. The libvirt libxl driver has never supported these settings, instead relying on libxl's default of a

Re: [libvirt] [PATCH v2 1/2] util: Add helper APIs to get/verify VF Representor name

On 02/12/2018 03:07 AM, Jai Singh Rana wrote: > Switchdev VF Representor interface name on host is derived based on BDF > of pci SR-IOV device in 'hostdev' and querying required net sysfs > entries on host. Really short for what's being added here. Not sure what BDF is... s/pci/PCI

Re: [libvirt] [PATCH v2 2/2] qemu: conf: Network stats support for hostdev VF Representor

On 02/12/2018 03:07 AM, Jai Singh Rana wrote: > In case of , return stats if its a Switchdev > VF Representor interface of pci SR-IOV device. > --- > v2 fixes bracket spacing in domain_conf.c > > src/conf/domain_conf.c | 7 +++ > src/qemu/qemu_driver.c | 34

Re: [libvirt] [PATCH v2 14/14] m4: enforce that all enum cases are listed in switch statements

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > As a general rule any time we switch() on something that is an enum, we > want to have a case for every enum constant. The -Wswitch warning will > report any switch where we've violated this rule, except if that switch > has a default case. >

Re: [libvirt] [PATCH v2 13/14] tools: handle missing switch enum cases

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > Cast away enum type in places where we don't wish to cover all cases. > > Signed-off-by: Daniel P. Berrangé > --- > tools/virt-host-validate-qemu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

Re: [libvirt] [PATCH v2 12/14] xen: handle missing switch enum cases

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements. > > Signed-off-by: Daniel P. Berrangé > --- > src/vmx/vmx.c | 26 -- > src/xenconfig/xen_common.c | 18 +++--- >

Re: [libvirt] [PATCH v2 11/14] security: handle missing switch enum cases

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements. > > Signed-off-by: Daniel P. Berrangé > --- > src/security/security_driver.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: John Ferlan

Re: [libvirt] [PATCH v2 10/14] rpc: handle missing switch enum cases

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements. > > Signed-off-by: Daniel P. Berrangé > --- > src/rpc/virnetclient.c| 2 ++ > src/rpc/virnetclientprogram.c | 1 + > src/rpc/virnetserverprogram.c | 4 >

Re: [libvirt] [PATCH v2 09/14] qemu: handle missing switch enum cases

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements, or cast away > enum type in places where we don't wish to cover all cases. > > Signed-off-by: Daniel P. Berrangé > --- > src/qemu/qemu_command.c | 26

Re: [libvirt] [PATCH v2 08/14] nwfilter: handle missing switch enum cases

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements, or cast away > enum type in places where we don't wish to cover all cases. > > Signed-off-by: Daniel P. Berrangé > --- > src/conf/nwfilter_conf.h |

Re: [libvirt] [PATCH v2 07/14] lxc: handle missing switch enum cases

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements, or cast away > enum type in places where we don't wish to cover all cases. > > Signed-off-by: Daniel P. Berrangé > --- > src/lxc/lxc_container.c | 8 >

Re: [libvirt] [PATCH v2 06/14] libxl: handle missing switch enum cases

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > Cast away enum type for libxl schedular constants since we don't want to > cover all of them and don't want build to break when new ones are added. > > Signed-off-by: Daniel P. Berrangé > --- > src/libxl/libxl_driver.c |

Re: [libvirt] [PATCH v2 05/14] hyperv: handle missing switch enum cases

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements. This improves > debug logging integration with openwsman. > > Signed-off-by: Daniel P. Berrangé > --- > src/hyperv/hyperv_driver.c | 18 -- > 1 file

Re: [libvirt] [PATCH v2 04/14] esx: handle missing switch enum cases

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements, or explicitly > cast away enum type where we don't want to list all cases. > > Signed-off-by: Daniel P. Berrangé > --- > src/esx/esx_driver.c | 1 + >

Re: [libvirt] [PATCH v2 03/14] conf: handle missing switch enum cases

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements. > > Signed-off-by: Daniel P. Berrangé > --- > src/conf/domain_audit.c | 1 + > src/conf/domain_conf.c | 46 -- >

Re: [libvirt] [PATCH v2 02/14] util: handle missing switch enum cases

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > Ensure all enum cases are listed in switch statements. > > Reviewed-by: John Ferlan > Signed-off-by: Daniel P. Berrangé > --- > src/util/virconf.c | 11 ++- >

Re: [libvirt] [PATCH v2 01/14] util: add a virReportEnumRangeError for bad value reporting

On 02/20/2018 12:08 PM, Daniel P. Berrangé wrote: > To ensure we have standardized error messages when reporting problems > with enum values being out of a range, add virReportEnumRangeError(). > >virReportEnumRangeError(virDomainState, 34); > > results in a message > >"internal

Re: [libvirt] [PATCH v2 0/2] Couple of hotplug cleanups

ping? Tks - On 02/14/2018 01:29 PM, John Ferlan wrote: > Necromancing some old branches... > > v1: https://www.redhat.com/archives/libvir-list/2017-October/msg00930.html > > Changes since v1 - beef up commit messages and drop patches 3 & 4 as > that's a bit more involved and Jan seemed to

Re: [libvirt] [PATCH libvirt] qemu: log the crash information for S390

On 02/15/2018 06:58 AM, Bjoern Walk wrote: > Since QEMU 2.12 guest crash information for S390 is available in the > QEMU monitor, e.g.: > > { > "timestamp": { > "seconds": 1518004739, > "microseconds": 552563 > }, > "event": "GUEST_PANICKED", > "data": { >

[libvirt] [PATCH glib] m4: disable gcc8 -Wcast-function-type warnings from -Wextra

The -Wextra flag bundle gained a new warning -Wcast-function-type. This complains if you cast between two function prototypes where the number of parameters or their data types are not compatible. Unfortunately we need such "bad" function casts for our event callbacks. It is possible to silence

[libvirt] [PATCH v2 06/14] libxl: handle missing switch enum cases

Cast away enum type for libxl schedular constants since we don't want to cover all of them and don't want build to break when new ones are added. Signed-off-by: Daniel P. Berrangé --- src/libxl/libxl_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH v2 14/14] m4: enforce that all enum cases are listed in switch statements

As a general rule any time we switch() on something that is an enum, we want to have a case for every enum constant. The -Wswitch warning will report any switch where we've violated this rule, except if that switch has a default case. Unfortunately it is reasonable to want to list all enum

[libvirt] [PATCH v2 10/14] rpc: handle missing switch enum cases

Ensure all enum cases are listed in switch statements. Signed-off-by: Daniel P. Berrangé --- src/rpc/virnetclient.c| 2 ++ src/rpc/virnetclientprogram.c | 1 + src/rpc/virnetserverprogram.c | 4 3 files changed, 7 insertions(+) diff --git

[libvirt] [PATCH v2 05/14] hyperv: handle missing switch enum cases

Ensure all enum cases are listed in switch statements. This improves debug logging integration with openwsman. Signed-off-by: Daniel P. Berrangé --- src/hyperv/hyperv_driver.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH v2 08/14] nwfilter: handle missing switch enum cases

Ensure all enum cases are listed in switch statements, or cast away enum type in places where we don't wish to cover all cases. Signed-off-by: Daniel P. Berrangé --- src/conf/nwfilter_conf.h | 4 ++-- src/nwfilter/nwfilter_ebiptables_driver.c | 17

[libvirt] [PATCH v2 11/14] security: handle missing switch enum cases

Ensure all enum cases are listed in switch statements. Signed-off-by: Daniel P. Berrangé --- src/security/security_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/security/security_driver.c b/src/security/security_driver.c index 4800d5255a..a845dc7995

[libvirt] [PATCH v2 03/14] conf: handle missing switch enum cases

Ensure all enum cases are listed in switch statements. Signed-off-by: Daniel P. Berrangé --- src/conf/domain_audit.c | 1 + src/conf/domain_conf.c | 46 -- src/conf/nwfilter_conf.c | 31 ++- 3 files

[libvirt] [PATCH v2 02/14] util: handle missing switch enum cases

Ensure all enum cases are listed in switch statements. Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/util/virconf.c | 11 ++- src/util/virfirewall.c | 6 -- src/util/virlog.c| 9

[libvirt] [PATCH v2 04/14] esx: handle missing switch enum cases

Ensure all enum cases are listed in switch statements, or explicitly cast away enum type where we don't want to list all cases. Signed-off-by: Daniel P. Berrangé --- src/esx/esx_driver.c | 1 + src/esx/esx_vi.c | 11 +++ src/esx/esx_vi_types.c | 9

[libvirt] [PATCH v2 07/14] lxc: handle missing switch enum cases

Ensure all enum cases are listed in switch statements, or cast away enum type in places where we don't wish to cover all cases. Signed-off-by: Daniel P. Berrangé --- src/lxc/lxc_container.c | 8 src/lxc/lxc_controller.c | 8 +++- src/lxc/lxc_driver.c |

[libvirt] [PATCH v2 09/14] qemu: handle missing switch enum cases

Ensure all enum cases are listed in switch statements, or cast away enum type in places where we don't wish to cover all cases. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_command.c | 26 ++ src/qemu/qemu_domain.c| 21

[libvirt] [PATCH v2 13/14] tools: handle missing switch enum cases

Cast away enum type in places where we don't wish to cover all cases. Signed-off-by: Daniel P. Berrangé --- tools/virt-host-validate-qemu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virt-host-validate-qemu.c

[libvirt] [PATCH v2 12/14] xen: handle missing switch enum cases

Ensure all enum cases are listed in switch statements. Signed-off-by: Daniel P. Berrangé --- src/vmx/vmx.c | 26 -- src/xenconfig/xen_common.c | 18 +++--- src/xenconfig/xen_xl.c | 7 ++- 3 files changed, 45

[libvirt] [PATCH v2 01/14] util: add a virReportEnumRangeError for bad value reporting

To ensure we have standardized error messages when reporting problems with enum values being out of a range, add virReportEnumRangeError(). virReportEnumRangeError(virDomainState, 34); results in a message "internal error: Unexpected enum value 34 for virDomainState" Signed-off-by:

[libvirt] [PATCH v2 00/14] Enforce presence of all switch enum cases

This is the same as the previous series, but with standardized error reporting macro to get consistent error messages. This is just the first part of the previous series. The second part is much more work to convert to this new error reporting macro, so i'll drip-feed the rest for review over

Re: [libvirt] [PATCH v2 16/42] util: add default: case to all switch statements

On Thu, Feb 15, 2018 at 04:43:21PM +, Daniel P. Berrangé wrote: Even if the compiler has validated that all enum constants have case statements in a switch, it is not safe to omit a default: case statement. When assigning a value to a variable / struct field that is defined with an enum

Re: [libvirt] [PATCH v2 17/42] conf: add default: case to all switch statements

On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > Even if the compiler has validated that all enum constants have case > statements in a switch, it is not safe to omit a default: case > statement. When assigning a value to a variable / struct field that is > defined with an enum type, nothing

[libvirt] [PATCH] Fix build with GCC 8 new switch fallthrough warnings

GCC 8 became more fussy about detecting switch fallthroughs. First it doesn't like it if you have a fallthrough attribute that is not before a case statement. e.g. FOO: BAR: WIZZ: ATTRIBUTE_FALLTHROUGH; Is unacceptable as there's no final case statement, so while FOO & BAR are

Re: [libvirt] [PATCH v2] conf: add enum constants for default controller models

On 02/20/2018 05:56 AM, Daniel P. Berrangé wrote: > The controller model is slightly unusual in that the default value is > -1, not 0. As a result the default value is not covered by any of the > existing enum cases. This in turn means that any switch() statements > that think they have covered

Re: [libvirt] [PATCH v2] conf: add enum constants for default controller models

On Tue, Feb 20, 2018 at 10:56:31AM +, Daniel P. Berrangé wrote: The controller model is slightly unusual in that the default value is -1, not 0. As a result the default value is not covered by any of the existing enum cases. This in turn means that any switch() statements that think they

Re: [libvirt] [PATCH v2 05/15] qemu: Simplify modelName stringification

On Mon, Feb 19, 2018 at 16:26:35 +0100, Andrea Bolognani wrote: > On Mon, 2018-02-19 at 16:06 +0100, Peter Krempa wrote: > > > case VIR_DOMAIN_CONTROLLER_TYPE_PCI: { > > > -const virDomainPCIControllerOpts *pciopts; > > > -const char *modelName = NULL; > > > - > > > -

Re: [libvirt] [PATCH v2 02/42] util: handle missing switch enum cases

On Tue, Feb 20, 2018 at 01:05:23PM +0100, Andrea Bolognani wrote: > On Tue, 2018-02-20 at 11:25 +, Daniel P. Berrangé wrote: > > > Yesterday I argued in a different thread that it would be better > > > to include the enum name in the error message, since that's useful > > > information for

Re: [libvirt] [PATCH v2 02/42] util: handle missing switch enum cases

On Tue, 2018-02-20 at 11:25 +, Daniel P. Berrangé wrote: > > Yesterday I argued in a different thread that it would be better > > to include the enum name in the error message, since that's useful > > information for developers whereas users 1) should never see this > > kind of error to begin

Re: [libvirt] [PATCH v2 02/42] util: handle missing switch enum cases

On 02/20/2018 06:25 AM, Daniel P. Berrangé wrote: > On Tue, Feb 20, 2018 at 12:19:15PM +0100, Andrea Bolognani wrote: >> On Tue, 2018-02-20 at 09:54 +, Daniel P. Berrangé wrote: > +case VIR_CONF_LAST: > default: > +

Re: [libvirt] [PATCH 2/2] storage_conf: Make virStorageAuthDefFormat return void

On Tue, Feb 20, 2018 at 12:30:32PM +0100, Michal Privoznik wrote: > This function returns nothing but zero. Therefore it makes no > sense to have it returning an integer. > > Signed-off-by: Michal Privoznik > --- > src/conf/domain_conf.c| 18 ++ >

Re: [libvirt] [PATCH 1/2] virDomainDiskSourceFormatInternal: Avoid leaking @childBuf

On Tue, Feb 20, 2018 at 12:30:31PM +0100, Michal Privoznik wrote: > If formatting of storage encryption or private data fails we must > jump to the error label instead of returning immediately > otherwise @attrBuf and @childBuf might be leaked. > > Signed-off-by: Michal Privoznik

[libvirt] [PATCH 2/2] storage_conf: Make virStorageAuthDefFormat return void

This function returns nothing but zero. Therefore it makes no sense to have it returning an integer. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c| 18 ++ src/conf/storage_conf.c | 6 ++ src/util/virstoragefile.c | 4 +---

[libvirt] [PATCH 1/2] virDomainDiskSourceFormatInternal: Avoid leaking @childBuf

If formatting of storage encryption or private data fails we must jump to the error label instead of returning immediately otherwise @attrBuf and @childBuf might be leaked. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+),

[libvirt] [PATCH 0/2] Couple of small fixes

These came to existence as I'm walking through code working on PR stuff (as in Persistent Reservations, not Public Relations). The fist patch is a bug fix, the second is an improvement. Michal Privoznik (2): virDomainDiskSourceFormatInternal: Avoid leaking @childBuf storage_conf: Make

Re: [libvirt] [PATCH v2 02/42] util: handle missing switch enum cases

On Tue, Feb 20, 2018 at 12:19:15PM +0100, Andrea Bolognani wrote: > On Tue, 2018-02-20 at 09:54 +, Daniel P. Berrangé wrote: > > > > +case VIR_CONF_LAST: > > > > default: > > > > +virReportError(VIR_ERR_INTERNAL_ERROR, > > > > +

Re: [libvirt] [PATCH v2 02/42] util: handle missing switch enum cases

On Tue, 2018-02-20 at 09:54 +, Daniel P. Berrangé wrote: > > > +case VIR_CONF_LAST: > > > default: > > > +virReportError(VIR_ERR_INTERNAL_ERROR, > > > + _("Unexpected conf value type %d"), > > > val->type); > > > return -1; > >

[libvirt] [PATCH v2] conf: add enum constants for default controller models

The controller model is slightly unusual in that the default value is -1, not 0. As a result the default value is not covered by any of the existing enum cases. This in turn means that any switch() statements that think they have covered all cases, will in fact not match the default value at all.

Re: [libvirt] [PATCH v2 01/42] conf: add enum constants for default controller models

On Tue, Feb 20, 2018 at 10:38:41AM +0100, Ján Tomko wrote: > On Thu, Feb 15, 2018 at 04:43:06PM +, Daniel P. Berrangé wrote: > > The controller model is slightly unusual in that the default value is > > -1, not 0. As a result the default value is not covered by any of the > > existing enum

Re: [libvirt] [PATCH v2 01/42] conf: add enum constants for default controller models

On Mon, Feb 19, 2018 at 01:33:23PM -0500, John Ferlan wrote: > > > On 02/15/2018 11:43 AM, Daniel P. Berrangé wrote: > > The controller model is slightly unusual in that the default value is > > -1, not 0. As a result the default value is not covered by any of the > > existing enum cases. This

Re: [libvirt] [PATCH v2 02/42] util: handle missing switch enum cases

On Tue, Feb 20, 2018 at 10:49:29AM +0100, Ján Tomko wrote: > On Thu, Feb 15, 2018 at 04:43:07PM +, Daniel P. Berrangé wrote: > > Ensure all enum cases are listed in switch statements. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > src/util/virconf.c

Re: [libvirt] [PATCH v2 02/42] util: handle missing switch enum cases

On Thu, Feb 15, 2018 at 04:43:07PM +, Daniel P. Berrangé wrote: Ensure all enum cases are listed in switch statements. Signed-off-by: Daniel P. Berrangé --- src/util/virconf.c | 13 - src/util/virfirewall.c | 7 +--

Re: [libvirt] [PATCH v2 01/42] conf: add enum constants for default controller models

On Thu, Feb 15, 2018 at 04:43:06PM +, Daniel P. Berrangé wrote: The controller model is slightly unusual in that the default value is -1, not 0. As a result the default value is not covered by any of the existing enum cases. This in turn means that any switch() statements that think they

Re: [libvirt] [tck Patch] Require perl(IO::Pty)

On Mon, Feb 19, 2018 at 06:17:31PM -0500, Laine Stump wrote: > The Net::OpenSSH module requires IO::Pty if password authentication > will be used, but The Fedora Net::OpenSSH maintainers don't want to > put anything stronger that "Suggests: perl(IO::Pty)" in their > specfile, which unfortunately

Re: [libvirt] [PATCH] nwfilter: assure that virNWFilterSnoop(Eth|Dhcp)Hdr objects don't change size

On Mon, Feb 19, 2018 at 02:30:19PM -0500, Laine Stump wrote: > These two objects are used to access fields in actual ethernet packets > captures with libpcap, so it's essential that they don't change size > for any reason. This patch uses gnulib's verify() macro to make sure > their sizes don't

Re: [libvirt] [PATCH v2 04/10] conf: stop passing virConnectPtr into virDomainDiskTranslateSourcePool

On Fri, Feb 16, 2018 at 04:28:05PM +0100, Jiri Denemark wrote: > On Fri, Feb 16, 2018 at 09:39:17 -0500, John Ferlan wrote: > ... > > Here's the command it uses: > > > > /usr/bin/virt-install --hvm --accelerate --name 'avocado-vt-vm1' \ > >--memory=1024 --vcpu=2 --import --vnc --os-variant

Re: [libvirt] [PATCH] daemon: trigger RPC re-generation when Makefile.am changes

On Mon, Feb 19, 2018 at 04:50:12PM +, Daniel P. Berrangé wrote: > The src/Makefile.am rules all re-generate the RPC dispatch code whenever > the Makefile.am changes, so for consistency do that for > daemon/Makefile.am too. > > Signed-off-by: Daniel P. Berrangé > --- >