Re: [libvirt] [PATCH] virtlockd: acquire locks on re-exec

On Thu, Mar 01, 2018 at 04:42:36PM -0700, Jim Fehlig wrote: Locks held by virtlockd are dropped on re-exec. virtlockd 94306 POSIX 5.4G WRITE 0 0 0 /tmp/test.qcow2 virtlockd 94306 POSIX 5B WRITE 0 0 0 /run/virtlockd.pid virtlockd 94306 POSIX 5B WRITE 0 0 0

Re: [libvirt] update keycodemapdb submodule for 4.1.0 release

On Thu, Mar 01, 2018 at 04:52:09PM +, Daniel P. Berrangé wrote: On Thu, Mar 01, 2018 at 09:47:32AM -0700, Jim Fehlig wrote: I mistakenly dropped keycodemapdb commit 6b3d716e from our libvirt 4.1.0 builds only to stumble across the failures in py3 environments that are fixed by that commit.

Re: [libvirt] [tck PATCH 0/2] set CTRL_IP_LEARNING and DHCPSERVER in filter during no-ip-spoofing test

Self-NACK to this series. I found a bug in one of the patches, and modified the other to be more useful in a couple other places. I posted a V2 series with the same subject line. On 02/28/2018 01:30 PM, Laine Stump wrote: > We've recently discovered two separate bugs that caused libvirt's >

[libvirt] [tck PATCH v2 4/4] nwfilter tests: remove all hardcoded references to 192.168.122 network

The nwfilter tests have a few places that hardcode 192.168.122 as the address of libvirt's default network. Remove all of these and replace them with addresses that are dynamically determined based on get_network_ip(). (This will have the immediate effect of helping the tests to succeed when

[libvirt] [tck PATCH v2 2/4] new NetworkHelper function get_network_ip()

This function gets the first IP address for the named virtual network. It is returned as a Net::IP object, so that we will have info about its netmask/prefix and can easily get it broadcast address and perform arithmetic on the address. Signed-off-by: Laine Stump --- Change

[libvirt] [tck PATCH v2 3/4] set CTRL_IP_LEARNING and DHCPSERVER in filter during no-ip-spoofing test

Adding these parameters to the clean-traffic filter causes a significant extra piece of code to be executed (a separate thread is started up, which uses libpcap to capture DHCP traffic and learn the IP address of the guest / test appliance), so let's get some test coverage on that code.

[libvirt] [tck PATCH v2 0/4] set CTRL_IP_LEARNING and DHCPSERVER in filter during no-ip-spoofing test

We've recently discovered two separate bugs that caused libvirt's "DHCP Snooping" feature to not work: https://bugzilla.redhat.com/show_bug.cgi?id=1529338 - libvirt regression https://bugzilla.redhat.com/show_bug.cgi?id=1547237 - libpcap regression Since we didn't have any test suite covering

[libvirt] [tck PATCH v2 1/4] nwfilter tests: auto-add test appliance ssh key to known_hosts on host

Without this option, attempts to ssh into the test appliance will fail unless someone has previously ssh'ed into the appliance manually and accepted its key. Signed-off-by: Laine Stump --- New in V2. This isn't necessarily related to the $subject of the cover letter, but it's

[libvirt] [PATCH] qemu: remove unused QEMU_CAPS_ENABLE_KVM

It needs for the -enable-kvm flag. This qemu flag can be compiled out, but we already detect that case with the QEMU_CAPS_KVM check. So this check is redundant and can be removed Signed-off-by: Klim Kireev --- src/qemu/qemu_capabilities.c | 13

Re: [libvirt] [PATCH v2 01/12] virstoragefile: Introduce virStoragePRDef

On 02/21/2018 01:11 PM, Michal Privoznik wrote: > This is a definition that holds information on SCSI persistent > reservation settings. The XML part looks like this: > > > > > > If @managed is set to 'yes' then the is not parsed. > This design was agreed on here: > >

Re: [libvirt] [PATCH v2 04/12] qemu: Generate alias and socket path for pr-helper

On 02/21/2018 01:11 PM, Michal Privoznik wrote: > While we're not generating the command line just yet (look for > the next commits), we can generate the alias for pr-manager. > A domain can have up to one managed pr-manager (in which case > socket path is decided by libvirt and pr-helper is

Re: [libvirt] [PATCH v2 03/12] qemu: Introduce pr-manager-helper capability

On 02/21/2018 01:11 PM, Michal Privoznik wrote: > The capability tracks if qemu has pr-manager-helper object. At > this time don't actually detect if qemu has the capability. Not > just yet. Only after the code is written the feature will be > enabled. > > Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH v2 02/12] qemuDomainDiskChangeSupported: Deny changing reservations

On 02/21/2018 01:11 PM, Michal Privoznik wrote: > Couple of reasons for that: > > a) there's no monitor command to change path where the pr-helper > connects to, or > b) there's no monitor command to introduce a new pr-helper for a > disk that already exists. > > Signed-off-by: Michal

[libvirt] [PATCH] virtlockd: acquire locks on re-exec

Locks held by virtlockd are dropped on re-exec. virtlockd 94306 POSIX 5.4G WRITE 0 0 0 /tmp/test.qcow2 virtlockd 94306 POSIX 5B WRITE 0 0 0 /run/virtlockd.pid virtlockd 94306 POSIX 5B WRITE 0 0 0 /run/virtlockd.pid Acquire locks in PostExecRestart code

Re: [libvirt] [PATCH v2 2/2] news: add logging of guest crash information on S390

On 02/27/2018 04:32 AM, Bjoern Walk wrote: > Signed-off-by: Bjoern Walk > --- > docs/news.xml | 9 + > 1 file changed, 9 insertions(+) > Reviewed-by: John Ferlan John BTW: I'll move the appropriate section once 4.2.0 is open for

Re: [libvirt] [PATCH v2 1/2] qemu: log the crash information for S390

On 02/27/2018 04:32 AM, Bjoern Walk wrote: > Since QEMU 2.12 guest crash information for S390 is available in the > QEMU monitor, e.g.: > > { > "timestamp": { > "seconds": 1518004739, > "microseconds": 552563 > }, > "event": "GUEST_PANICKED", > "data": { >

[libvirt] [RFC PATCH v3 7/9] qemu: Implement the SBBC pSeries feature

This is the first pSeries-specific optional feature that is used to represent a hardware bug and to control how it will be exposed to the guest. Signed-off-by: Andrea Bolognani --- docs/schemas/domaincommon.rng | 15 +++ src/conf/domain_conf.c

[libvirt] [RFC PATCH v3 3/9] qemu: Prefer qom-list-properties to device-list-properties

The former command is only implemented in the very latest QEMU version, but it's a proper superset of the latter and can thus be used as a drop-in replacement when available. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 10 +-

Re: [libvirt] [PATCH] tests: introduce qemucapsfixreplies helper

On Thu, Mar 01, 2018 at 04:06:00PM +0100, Andrea Bolognani wrote: > On Thu, 2018-03-01 at 15:29 +0100, Pavel Hrdina wrote: > > Sometimes we don't regenerate QEMU capabilities replies using QEMU > > binary but we simply add a new entry manually. In that case you need > > to manually fix all the

[libvirt] [RFC PATCH v3 4/9] qemu: Add capabilities for optional pSeries features

Using the new qom-list-properties QMP command allows us to probe for the corresponding QEMU machine type options. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 16 ++ src/qemu/qemu_capabilities.h | 6 +

[libvirt] [RFC PATCH v3 2/9] qemu: Add capability for qom-list-properties

Signed-off-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 4 +++- src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.12.0-gicv2.aarch64.xml | 1 +

[libvirt] [RFC PATCH v3 8/9] qemu: Implement the CFPC pSeries feature

Signed-off-by: Andrea Bolognani --- docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 4 src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c

[libvirt] [RFC PATCH v3 9/9] qemu: Implement the IBS pSeries feature

Signed-off-by: Andrea Bolognani --- docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 4 src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c

[libvirt] [RFC PATCH v3 6/9] qemu: Implement the HTM pSeries feature

This is the first in a list of pSeries-specific optional features that have recently been introduced in QEMU. Along with the feature proper, some generic code that will make it easier to implement subsequent features is introduced as well. Signed-off-by: Andrea Bolognani ---

[libvirt] [RFC PATCH v3 5/9] tests: Rename pseries-features-hpt test

We're going to use the same test case to exercise all optional pSeries features, so a more generic name is needed. Signed-off-by: Andrea Bolognani --- .../{pseries-features-hpt.args => pseries-features.args} | 0 .../{pseries-features-hpt.xml =>

[libvirt] [RFC PATCH v3 1/9] tests: Add capabilities data for QEMU 2.12

The data comes from builds that include the proposed qom-list-properties command. See http://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg00242.html for the relevant patches. Signed-off-by: Andrea Bolognani --- .../caps_2.12.0-gicv2.aarch64.replies |

[libvirt] [RFC PATCH v3 0/9] Add optional pSeries features

Applies cleanly on top of 6722a32444db6335f2104e67d873199c76e5701e. Some of the patches are fairly big because of all the capabilities data being added and the subsequent test suite churn: I'm sending a redacted version to the list, the rest of the code can be grabbed from

[libvirt] [PATCH 2/6] qemu: domain: Split out formating of Job data from private data formatter

Separate the code for later refactoring Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 84 -- 1 file changed, 47 insertions(+), 37 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

[libvirt] [PATCH 6/6] qemu: domain: Extract parsing of job-related private XML

Similarly to the formatter extract the parser code. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 108 - 1 file changed, 63 insertions(+), 45 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c

[libvirt] [PATCH 5/6] qemu: domain: Use virXMLFormatElement in qemuDomainObjPrivateXMLFormatJob

Modernize the code by using the clever formatter rather than checking manually when to format the end of the element. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

[libvirt] [PATCH 1/6] qemu: Add qemu functions for storage source private data handling

The qemu driver registered the helpers from util code, but it will be necessary to format also some qemu-specific data. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH 4/6] qemu: domain: Return early in qemuDomainObjPrivateXMLFormatJob

Remove one level of nesting by returing early. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 54 ++ 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c

[libvirt] [PATCH 0/6] qemu: domain: Private data handling refactors

Extracted from a huge work-in-progres series since these look stand-alone. Peter Krempa (6): qemu: Add qemu functions for storage source private data handling qemu: domain: Split out formating of Job data from private data formatter qemu: domain: Don't overwrite job type in private data

[libvirt] [PATCH 3/6] qemu: domain: Don't overwrite job type in private data

The code overwrote the internal job type and then fixed it back. Since the job type is not accessed in the code this does not make much sense. Use the temporary value instead. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 10 -- 1 file changed, 4

Re: [libvirt] [PATCH] news: Update release notes

On 03/01/2018 03:20 PM, Andrea Bolognani wrote: > On Thu, 2018-03-01 at 14:15 +0100, Peter Krempa wrote: >>> + >>> + Allow opening secondary drivers >>> + >>> + >>> + Up until now it was possible to connect to only hypervisor >>> drivers >>> +

Re: [libvirt] [PATCH] news: Update release notes

On 03/01/2018 04:59 PM, Peter Krempa wrote: > On Thu, Mar 01, 2018 at 14:51:45 +, Daniel Berrange wrote: >> On Thu, Mar 01, 2018 at 03:41:00PM +0100, Peter Krempa wrote: >>> On Thu, Mar 01, 2018 at 14:34:58 +, Daniel Berrange wrote: On Thu, Mar 01, 2018 at 03:28:57PM +0100, Peter

Re: [libvirt] update keycodemapdb submodule for 4.1.0 release

On Thu, Mar 01, 2018 at 09:47:32AM -0700, Jim Fehlig wrote: > I mistakenly dropped keycodemapdb commit 6b3d716e from our libvirt 4.1.0 > builds only to stumble across the failures in py3 environments that are > fixed by that commit. Should the submodule be updated for the 4.1.0 release? Since the

[libvirt] update keycodemapdb submodule for 4.1.0 release

I mistakenly dropped keycodemapdb commit 6b3d716e from our libvirt 4.1.0 builds only to stumble across the failures in py3 environments that are fixed by that commit. Should the submodule be updated for the 4.1.0 release? Regards, Jim -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] src: Fix checking for clang

On Thu, Mar 01, 2018 at 05:37:38PM +0100, Andrea Bolognani wrote: > The check was trying to use the shell variable $CC instead of > the make variable $(CC); it also interpreted grep's return code > wrong: 1 means the provided pattern was *not* matched. As a > result, pdwtags was never run, not

[libvirt] [PATCH] src: Fix checking for clang

The check was trying to use the shell variable $CC instead of the make variable $(CC); it also interpreted grep's return code wrong: 1 means the provided pattern was *not* matched. As a result, pdwtags was never run, not even when building with gcc. Signed-off-by: Andrea Bolognani

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 03:26:48PM +0100, Erik Skultety wrote: On Thu, Mar 01, 2018 at 02:08:29PM +0100, --help wrote: Signed-off-by: --help --- docs/news.xml | 102 ++ 1 file changed, 102 insertions(+) I think it

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 05:02:55PM +0100, Peter Krempa wrote: > On Thu, Mar 01, 2018 at 15:26:48 +0100, Erik Skultety wrote: > > On Thu, Mar 01, 2018 at 02:08:29PM +0100, --help wrote: > > > Signed-off-by: --help > > > --- > > > docs/news.xml | 102 > > >

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 15:26:48 +0100, Erik Skultety wrote: > On Thu, Mar 01, 2018 at 02:08:29PM +0100, --help wrote: > > Signed-off-by: --help > > --- > > docs/news.xml | 102 > > ++ > > 1 file changed, 102

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 14:51:45 +, Daniel Berrange wrote: > On Thu, Mar 01, 2018 at 03:41:00PM +0100, Peter Krempa wrote: > > On Thu, Mar 01, 2018 at 14:34:58 +, Daniel Berrange wrote: > > > On Thu, Mar 01, 2018 at 03:28:57PM +0100, Peter Krempa wrote: [...] > > I'm not saying it's a

Re: [libvirt] [PATCH] tests: introduce qemucapsfixreplies helper

On Thu, 2018-03-01 at 15:29 +0100, Pavel Hrdina wrote: > Sometimes we don't regenerate QEMU capabilities replies using QEMU > binary but we simply add a new entry manually. In that case you need > to manually fix all the replies ids. This helper will do that for you. > > Signed-off-by: Pavel

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 15:40:01 +0100, Michal Privoznik wrote: > On 03/01/2018 03:29 PM, Daniel P. Berrangé wrote: > > On Thu, Mar 01, 2018 at 03:12:39PM +0100, Michal Privoznik wrote: > >> On 03/01/2018 02:15 PM, Peter Krempa wrote: > >>> On Thu, Mar 01, 2018 at 14:08:29 +0100, Michal Privoznik

[libvirt] [PATCH] virt-aa-helper: resolve yet to be created paths

In certain cases a xml contains paths that do not yet exist, but are valid as qemu will create them later on - for example vhostuser mode=server sockets. In any such cases so far the check to virFileExists failed and due to that the paths stayed non-resolved in regard to symlinks. But for

Re: [libvirt] [PATCH] news: Update release notes

On Thu, 2018-03-01 at 14:42 +, Daniel P. Berrangé wrote: > > Looks like Peter has opinion on this too. So should I leave this item > > out or reword it? > > Do we usually document when we just fix compiler warnings ? I'd just > personally leave out, or just say "Fixed some compiler warnings

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 03:41:00PM +0100, Peter Krempa wrote: > On Thu, Mar 01, 2018 at 14:34:58 +, Daniel Berrange wrote: > > On Thu, Mar 01, 2018 at 03:28:57PM +0100, Peter Krempa wrote: > > > On Thu, Mar 01, 2018 at 15:12:39 +0100, Michal Privoznik wrote: > > > > On 03/01/2018 02:15 PM,

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 14:34:58 +, Daniel Berrange wrote: > On Thu, Mar 01, 2018 at 03:28:57PM +0100, Peter Krempa wrote: > > On Thu, Mar 01, 2018 at 15:12:39 +0100, Michal Privoznik wrote: > > > On 03/01/2018 02:15 PM, Peter Krempa wrote: > > > > On Thu, Mar 01, 2018 at 14:08:29 +0100,

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 03:40:01PM +0100, Michal Privoznik wrote: > On 03/01/2018 03:29 PM, Daniel P. Berrangé wrote: > > On Thu, Mar 01, 2018 at 03:12:39PM +0100, Michal Privoznik wrote: > >> On 03/01/2018 02:15 PM, Peter Krempa wrote: > >>> On Thu, Mar 01, 2018 at 14:08:29 +0100, Michal

Re: [libvirt] [PATCH] news: Update release notes

On 03/01/2018 03:29 PM, Daniel P. Berrangé wrote: > On Thu, Mar 01, 2018 at 03:12:39PM +0100, Michal Privoznik wrote: >> On 03/01/2018 02:15 PM, Peter Krempa wrote: >>> On Thu, Mar 01, 2018 at 14:08:29 +0100, Michal Privoznik wrote: Signed-off-by: --help >>> >>> Hmm. >>>

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 03:28:57PM +0100, Peter Krempa wrote: > On Thu, Mar 01, 2018 at 15:12:39 +0100, Michal Privoznik wrote: > > On 03/01/2018 02:15 PM, Peter Krempa wrote: > > > On Thu, Mar 01, 2018 at 14:08:29 +0100, Michal Privoznik wrote: > > >> Signed-off-by: --help >

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 02:08:29PM +0100, --help wrote: > Signed-off-by: --help > --- > docs/news.xml | 102 > ++ > 1 file changed, 102 insertions(+) I think it might be worth mentioning the following bug fix as well:

[libvirt] [PATCH] tests: introduce qemucapsfixreplies helper

Sometimes we don't regenerate QEMU capabilities replies using QEMU binary but we simply add a new entry manually. In that case you need to manually fix all the replies ids. This helper will do that for you. Signed-off-by: Pavel Hrdina --- tests/qemucapsfixreplies | 22

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 15:12:39 +0100, Michal Privoznik wrote: > On 03/01/2018 02:15 PM, Peter Krempa wrote: > > On Thu, Mar 01, 2018 at 14:08:29 +0100, Michal Privoznik wrote: > >> Signed-off-by: --help > > > > Hmm. > > > >> --- > >> docs/news.xml | 102 > >>

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 03:12:39PM +0100, Michal Privoznik wrote: > On 03/01/2018 02:15 PM, Peter Krempa wrote: > > On Thu, Mar 01, 2018 at 14:08:29 +0100, Michal Privoznik wrote: > >> Signed-off-by: --help > > > > Hmm. > > > >> --- > >> docs/news.xml | 102 > >>

Re: [libvirt] [PATCH] news: Update release notes

On Thu, 2018-03-01 at 14:15 +0100, Peter Krempa wrote: > > + > > + Allow opening secondary drivers > > + > > + > > + Up until now it was possible to connect to only hypervisor > > drivers > > + (e.g. qemu:///system, lxc:///, vbox:///system, and

Re: [libvirt] [PATCH] news: Update release notes

On 03/01/2018 02:15 PM, Peter Krempa wrote: > On Thu, Mar 01, 2018 at 14:08:29 +0100, Michal Privoznik wrote: >> Signed-off-by: --help > > Hmm. > >> --- >> docs/news.xml | 102 >> ++ >> 1 file changed, 102

Re: [libvirt] [PATCH] news: Update release notes

On 03/01/2018 02:27 PM, Daniel P. Berrangé wrote: > On Thu, Mar 01, 2018 at 02:08:29PM +0100, --help wrote: >> Signed-off-by: --help > > You're going to have todo better than that to beat the exploits of > Little Bobby Tables [1]. Oh snap. I was playing with git config when

Re: [libvirt] [PATCH 1/2] conf: Fix crash in virDomainDefCompatibleDevice

On Thu, Mar 01, 2018 at 08:03:38 -0500, John Ferlan wrote: > Commit id 'edae027c' blindly assumed that the passed @oldDev > parameter would not be NULL when calling virDomainDeviceGetInfo; > however, commit id 'b6a264e8' passed NULL for AttachDevice > callers under the premise that there wouldn't

[libvirt] [PATCH] bugfix: add lock in ClientClose to avoid data race

From: l00425170 When libvirt client registers callback function, remoteDispatchConnectDomainEventCallbackRegisterAny is called, then virInsertElementsN will be called to add new callback for struct daemonClientPrivate *priv. But at the same time, if the corresponding

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 02:08:29PM +0100, --help wrote: > Signed-off-by: --help You're going to have todo better than that to beat the exploits of Little Bobby Tables [1]. > --- > docs/news.xml | 102 > ++ > 1 file

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 14:08:29 +0100, Michal Privoznik wrote: > Signed-off-by: --help Hmm. > --- > docs/news.xml | 102 > ++ > 1 file changed, 102 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml >

[libvirt] [PATCH] news: Update release notes

Signed-off-by: --help --- docs/news.xml | 102 ++ 1 file changed, 102 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 86a0c8d18..53bf9a49c 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,28

[libvirt] [PATCH 2/2] qemu: Call virDomainDefCompatibleDevice when live add cdrom/floppy

Prior to calling qemuDomainChangeEjectableMedia when adding the cdrom/floppy to the guest, make a second pass at the virDomainDefCompatibleDevice with the old_disk that's being updated by the call. This is similar to the qemuDomainChangeDiskLive path from qemuDomainUpdateDeviceLive prior to

[libvirt] [PATCH 0/2] Fix crash from live attach of device (for 4.1.0)

Fix is in patch 1/2 - if virDomainDefCompatibleDevice is called with a NULL @oldDev, then call to virDomainDeviceGetInfo would fail rather spectacularly. Patch 2 extends the similar fix/adjustment from the update path to the add path for the cdrom/floppy since the add path since it's possible to

[libvirt] [PATCH 1/2] conf: Fix crash in virDomainDefCompatibleDevice

Commit id 'edae027c' blindly assumed that the passed @oldDev parameter would not be NULL when calling virDomainDeviceGetInfo; however, commit id 'b6a264e8' passed NULL for AttachDevice callers under the premise that there wouldn't be a device to check/update against. Signed-off-by: John Ferlan

Re: [libvirt] [PATCH] virtio-scsi: Add virtqueue_size parameter for qemu

On Wed, Feb 28, 2018 at 10:20:28PM +0300, Klim Kireev wrote: In QEMU commit 5c0919d02066c3d0eb896c33265ad90101a6a84a adds new option virtqueue_size. This Patch allows this option to be set in libvirt. --- docs/formatdomain.html.in | 6 ++ src/conf/domain_conf.c| 12