[libvirt] [Question]Libvirt doesn't care about qemu monitor event if fail to destroy qemu process

2018-03-04 Thread Wuzongyong (Euler Dept)
Hi, We unregister qemu monitor after sending QEMU_PROCESS_EVENT_MONITOR_EOF to workerPool: static void qemuProcessHandleMonitorEOF(qemuMonitorPtr mon, virDomainObjPtr vm, void *opaque) { virQEMUDriverPtr driver = opaque;

Re: [libvirt] [PATCH] util, remote: Fixing the sending of stream when length is defined.

2018-03-04 Thread Julio Faracco
I'm not sure about this part. When offset is equal of length, nbytes is 0 and the function will return 0. Do you see any possible problems to remove this part? I checked all ret = 0 and I'm not seeing problems until now. > -if (got == 0) > -break; > - -- libvir-list mailing

[libvirt] [PATCH] util, remote: Fixing the sending of stream when length is defined.

2018-03-04 Thread Julio Faracco
When a length of a file is defined, the responsible thread to send stream is finishing inappropriately. It is happening because there is wrong conditional which compares an offset with the length and because of that the code throws ENOSPC error. To test it: virsh# vol-upload ... --length N

[libvirt] [PATCH go-xml] fix type tag for rdp and destkop graphics devices

2018-03-04 Thread Ryan Goodfellow
The current behavior is to generate a type="vnc" tag in the element generated from either a DomainGrapicRDP or DomainGraphicDesktop. The correct tags should be type="rdp" and type="desktop" respectively. This commit emits the correct tags and adds a test for correct graphics device tagging. ---