On 03/01/2018 04:43 AM, xinhua.Cao wrote:
> From: l00425170
>
> When libvirt client registers callback function,
> remoteDispatchConnectDomainEventCallbackRegisterAny is called, then
> virInsertElementsN
> will be called to add new callback for struct
On Tue, Mar 13, 2018 at 18:20:51 +, Daniel P. Berrangé wrote:
> On Tue, Mar 13, 2018 at 06:13:46PM +, Jonathan Davies wrote:
> > Thanks all the helpful replies.
> >
> > Just to check I've understood: The design is that the call is synchronous
> > but may become asynchronous if it times
This is the only Python script which we invoke directly, which
works pretty fine in general but becomes a problem if the user
has explicitly overridden Python binary detection at configure
time.
Signed-off-by: Andrea Bolognani
---
docs/Makefile.am | 2 +-
1 file changed, 1
Very few tweaks needed.
The generated files are bit by bit identical to those produced
before, regardless of whether the script is invoked using Python
2 or Python 3.
Signed-off-by: Andrea Bolognani
---
src/esx/esx_vi_generator.py | 30 +-
1
A lot of tweaks needed.
The generated files are bit by bit identical to those produced
before when the script is invoked using Python 2, but using
Python 3 results in some errors being reported and the build
step to be considered failed. The output files are mostly the
same, except , and are
We use Python in out build system: more specifically, we're stuck
with Python 2 even though Python 3's been out for a decade and some
major Linux distributions have gone Python 3-only recently.
This series tries to solve the issue, but falls quite short. Maybe
someone who actually knows Python
A few tweaks needed.
The generated files are bit by bit identical to those produced
before when the script is invoked using Python 2, but not when
Python 3 is used, in which case members of the various structs
are shuffled around.
Signed-off-by: Andrea Bolognani
---
All the input files and scripts used to generate the release notes
live in the docs/ directory, so it makes sense for the output file
to be created there as well. A symbolic link is created in the
top-level source directory to comply with GNU standards as well as
user expectations.
Signed-off-by:
On 13/03/18 14:23, Daniel P. Berrangé wrote:
On Tue, Mar 13, 2018 at 02:07:08PM +, Jonathan Davies wrote:
qemuDomainDetachNetDevice should not treat a timeout in a call to
qemuDomainWaitForDeviceRemoval as success. Instead, it should treat it
as failure -- this is the intention behind
On Tue, Mar 13, 2018 at 06:13:46PM +, Jonathan Davies wrote:
> On 13/03/18 14:23, Daniel P. Berrangé wrote:
> > On Tue, Mar 13, 2018 at 02:07:08PM +, Jonathan Davies wrote:
> > > qemuDomainDetachNetDevice should not treat a timeout in a call to
> > > qemuDomainWaitForDeviceRemoval as
see 2/2
Peter Krempa (2):
REPRODUCER -- DO NOT PUSH
qemu: hotplug: Clean up memory backing files after failed memory
hotplug
dom.xml | 110
mem.xml | 6 +++
src/qemu/qemu_hotplug.c | 7 +++
3 files
Libvirt provides full path to the backing file since commit
fec8f9c49afb479f6. This made qemu create the backend object but did not
delete it. This was fixed for unplug case in 4d83a6722f but not in case
of failure to hotplug the frontend. We'd leave the files behind which
would make memory
https://bugzilla.redhat.com/show_bug.cgi?id=1553085
This breaks hotplug so that we can see whether the file was left
dangling.
Reproduce by:
virsh create dom.xml
virsh attach-device memplug mem.xml
ls /var/lib/libvirt/qemu/ram/libvirt/qemu/*-memplug
After the failed hotplug, qemu should leave
Signed-off-by: Daniel P. Berrangé
---
notices/2018/0003.xml | 269 ++
1 file changed, 269 insertions(+)
create mode 100644 notices/2018/0003.xml
diff --git a/notices/2018/0003.xml b/notices/2018/0003.xml
new file mode 100644
The libxlDomainMigrateBegin3Params API locks and ref counts the associated
virDomainObj but relies on the helper function libxlDomainMigrationBegin
to unref/unlock the object. libxlDomainMigrationBegin is also used by
libxlDomainMigratePerform3Params for p2p migration, but in that case the
It is rather tedious making the list of vulnerable tags and branches
for the security notice reports. This script takes the changeset of
the commit that first introduced the flaw and then outputs an XML
snippet listing every tag and branch which contains that vulnerable
changeset. This can be
This provides the security notices we've had so far in 2018 and a
script to make future ones easier to create.
Daniel P. Berrangé (4):
LSN-2018-0001 / CVE-2017-5715 - Spectre variant 2 branch target
injection
LSN-2018-0002 / CVE-2018-5748 - QEMU monitor denial of service
LSN-2018-0003 /
Signed-off-by: Daniel P. Berrangé
---
notices/2018/0001.xml | 276 ++
1 file changed, 276 insertions(+)
create mode 100644 notices/2018/0001.xml
diff --git a/notices/2018/0001.xml b/notices/2018/0001.xml
new file mode 100644
On 03/13/2018 12:44 PM, Marc Hartmayer wrote:
> On Tue, Mar 13, 2018 at 01:39 PM +0100, John Ferlan
> wrote:
>> On 03/13/2018 03:44 AM, Marc Hartmayer wrote:
>>> On Fri, Mar 09, 2018 at 05:47 PM +0100, John Ferlan
>>> wrote:
For
Signed-off-by: Daniel P. Berrangé
---
notices/2018/0002.xml | 274 ++
1 file changed, 274 insertions(+)
create mode 100644 notices/2018/0002.xml
diff --git a/notices/2018/0002.xml b/notices/2018/0002.xml
new file mode 100644
libxlDomainMigrationPrepare adds the incoming domain def to the list of
domains via virDomainObjListAdd, which returns a locked and ref counted
virDomainObj. On exit the object is unlocked but not unref'ed. The same
is true for libxlDomainMigrationPrepareTunnel3. Convert both to use the
While reviewing a patch [0] from John's series to rework
virDomainObjListFindBy{UUID|ID}Ref, I noticed several problems with locking
and ref counting in the libxl migration APIs. This series changes the Begin,
Prepare, Perform, and Confirm APIs to use the standard pattern of get a
locked and ref
ibxlDomObjFromDomain to returns locked and ref counted virDomainObj but
libxlDomainMigratePerform3Params only unlocks the object on exit. Convert
it to use the virDomainObjEndAPI function for cleanup.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_driver.c | 3 +--
1 file
The libxlDomainMigrateConfirm3Params API locks and ref counts the associated
virDomainObj but relies on the helper function libxlDomainMigrationConfirm
to unlock the object. Unref'ing the object is not done in either function.
libxlDomainMigrationConfirm is also used by
On Tue, Mar 13, 2018 at 01:39 PM +0100, John Ferlan wrote:
> On 03/13/2018 03:44 AM, Marc Hartmayer wrote:
>> On Fri, Mar 09, 2018 at 05:47 PM +0100, John Ferlan
>> wrote:
>>> For bhyveDomObjFromDomain, bhyveDomainLookupByUUID, and
>>>
Some fields reported by dmidecode have plenty of useless spaces
(in fact some have nothing but spaces). To deal with this we have
introduced virSkipSpacesBackwards() and use it in
virSysinfoParseX86Processor() and virSysinfoParseX86Memory().
However, other functions (e.g.
Commit 99e30acfdce added 'qemustatusxml2xmloutdata' to EXTRA_DIST but
the directory added in the commit is called 'qemustatusxml2xmldata'
Signed-off-by: Peter Krempa
---
Pushed under the
I-didn't-run-distcheck-when-messing-with-files-in-the-tree-and-broke-the-build-rule.
On Tue, Mar 13, 2018 at 03:42:10PM +0100, Jiri Denemark wrote:
> On Tue, Mar 13, 2018 at 14:23:22 +, Daniel P. Berrangé wrote:
> > On Tue, Mar 13, 2018 at 02:07:08PM +, Jonathan Davies wrote:
> > > If qemuDomainWaitForDeviceRemoval times out, it returns 0. In this
> > > instance, if
Add a helper that parses a storage source XML node into a new
virStorageSource object. Since there are multiple approaches to store
the 'type' and 'format' attributes, they need to be parsed manually
prior to calling the function.
Signed-off-by: Peter Krempa
---
On Tue, Mar 13, 2018 at 14:23:22 +, Daniel P. Berrangé wrote:
> On Tue, Mar 13, 2018 at 02:07:08PM +, Jonathan Davies wrote:
> > If qemuDomainWaitForDeviceRemoval times out, it returns 0. In this
> > instance, if qemuDomainDetachNetDevice returns 0, virsh detach-interface
> > reports:
> >
Rather than checking that the security label is legal when parsing it
move the code into a separate function.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 68 --
1 file changed, 44 insertions(+), 24 deletions(-)
Split out the parser and separate it from the private data part so that
it can be later reused in other parts of the code.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 43 +--
1 file changed, 29 insertions(+), 14
Move out formatting of 'startuPolicy' which is a property of the disk
out of the element. Extracting the code formating the content
and attributes will also allow reuse in other parts of the code.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 90
The wrapper functionality can be moved to the only user
virDomainDiskSourceFormatInternal. Also removes comment which does not
reflect the truth any more.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 31 +++
1 file changed, 7
Since seclabels are formatted along with the source element and will
also make sense to be passed for the backing chain we should parse them
in the place where we parse the disk source. Same applies for
validation.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 39
Since we already parse the of a disk source, we should
also validate the configuration for the whole backing chain and not only
for the top level image.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 24 ++--
1 file changed, 14 insertions(+),
Move it to a single location which also allows to get rid of the
temporrary variable.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
Now that the function is using virXMLFormatElement we don't need to
conditionally format anything, since we'll format the element according
to the presence of content.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 126
Fixup and cleanup the disk source parsing code and make it usable in
other parts of the code by exporting it.
Peter Krempa (10):
conf: Remove unnecessary condition from
virDomainDiskSourceFormatInternal
conf: Refactor seclabel formatting in
virDomainDiskSourceFormatInternal
conf:
Call the formatter function only once.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index ddabc77a9b..ebe1172fd2 100644
---
Commit 1b28038300b forgot to fix the arguments for this one caller.
Signed-off-by: Peter Krempa
---
Pushed under the build-breaker rule.
tests/bhyvexml2xmltest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/bhyvexml2xmltest.c
On Tue, 2018-03-13 at 11:20 +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> Makefile.am | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Makefile.am b/Makefile.am
> index 0d46c16c22..81c7f52d9c 100644
> --- a/Makefile.am
> +++ b/Makefile.am
>
On Tue, Mar 13, 2018 at 14:37:05 +0100, Michal Privoznik wrote:
> We're freeing individual items in it but not the array itself.
>
> ==19200== 40 bytes in 1 blocks are definitely lost in loss record 847 of 1,059
> ==19200==at 0x4C2D12F: realloc (vg_replace_malloc.c:785)
> ==19200==by
On Tue, Mar 13, 2018 at 02:07:08PM +, Jonathan Davies wrote:
> qemuDomainDetachNetDevice should not treat a timeout in a call to
> qemuDomainWaitForDeviceRemoval as success. Instead, it should treat it
> as failure -- this is the intention behind having a timeout.
Actually this is intentional
On Tue, Mar 13, 2018 at 14:37:04 +0100, Michal Privoznik wrote:
> Probably due to copy-paste error we're storing asset tag into
> def->sku which we even use in the next step to store SKU number
> and thus the asset tag leaks.
>
> ==19200== 41 bytes in 1 blocks are definitely lost in loss record
On Tue, Mar 13, 2018 at 14:07:08 +, Jonathan Davies wrote:
> qemuDomainDetachNetDevice should not treat a timeout in a call to
> qemuDomainWaitForDeviceRemoval as success. Instead, it should treat it
> as failure -- this is the intention behind having a timeout.
>
> If
On Mon, Mar 12, 2018 at 01:57:36PM +, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> src/conf/domain_conf.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index
qemuDomainDetachNetDevice should not treat a timeout in a call to
qemuDomainWaitForDeviceRemoval as success. Instead, it should treat it
as failure -- this is the intention behind having a timeout.
If qemuDomainWaitForDeviceRemoval times out, it returns 0. In this
instance, if
On Tue, Mar 13, 2018 at 02:37:30PM +0100, Michal Privoznik wrote:
This is missing in 6bc4a371cf and therefore we are effectively
overwriting user provided aliases for devices.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_alias.c | 3 +++
1 file changed, 3
On 13/03/18 12:41, Daniel P. Berrangé wrote:
> On Tue, Mar 13, 2018 at 01:37:25PM +0100, Cedric Bosdonnat wrote:
>> On Tue, 2018-03-13 at 16:45 +0530, Sukrit Bhatnagar wrote:
>>> Here is the output:
>>>
>>> skrtbhtngr@ubuntu:~/libvirt$ ./autogen.sh --system
>>>
>>> Updating submodules...
>>>
*** BLURB HERE ***
Michal Privoznik (2):
virSysinfoParseX86Chassis: Store asset tag into correct pointer
virSecurityDACChownListFree: Don't leak list->items array
src/security/security_dac.c | 1 +
src/util/virsysinfo.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
--
This is missing in 6bc4a371cf and therefore we are effectively
overwriting user provided aliases for devices.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_alias.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c
Probably due to copy-paste error we're storing asset tag into
def->sku which we even use in the next step to store SKU number
and thus the asset tag leaks.
==19200== 41 bytes in 1 blocks are definitely lost in loss record 849 of 1,059
==19200==at 0x4C2AF0F: malloc (vg_replace_malloc.c:299)
We're freeing individual items in it but not the array itself.
==19200== 40 bytes in 1 blocks are definitely lost in loss record 847 of 1,059
==19200==at 0x4C2D12F: realloc (vg_replace_malloc.c:785)
==19200==by 0x52C5532: virReallocN (viralloc.c:245)
==19200==by 0x52C5628: virExpandN
On 03/13/2018 03:58 AM, Marc Hartmayer wrote:
> On Fri, Mar 09, 2018 at 05:48 PM +0100, John Ferlan
> wrote:
>> Some of the indents were only 2 spaces, make consistent w/ 4 spaces
>>
>> Signed-off-by: John Ferlan
>> ---
>> src/openvz/openvz_driver.c |
On Tue, Mar 13, 2018 at 10:07:58AM +, Daniel P. Berrangé wrote:
> On Tue, Mar 13, 2018 at 09:39:13AM +0100, Pavel Hrdina wrote:
> > On Mon, Mar 12, 2018 at 04:30:30PM +, Daniel P. Berrangé wrote:
> > > On Mon, Mar 12, 2018 at 05:21:46PM +0100, Pavel Hrdina wrote:
> > > > We will switch to
On Tue, Mar 13, 2018 at 01:37:25PM +0100, Cedric Bosdonnat wrote:
> On Tue, 2018-03-13 at 16:45 +0530, Sukrit Bhatnagar wrote:
> > Here is the output:
> >
> > skrtbhtngr@ubuntu:~/libvirt$ ./autogen.sh --system
> >
> > Updating submodules...
> > Submodule 'gnulib'
On 03/13/2018 03:44 AM, Marc Hartmayer wrote:
> On Fri, Mar 09, 2018 at 05:47 PM +0100, John Ferlan
> wrote:
>> For bhyveDomObjFromDomain, bhyveDomainLookupByUUID, and
>> bhyveDomainLookupByID let's return a locked and referenced
>> @vm object so that callers can then use
On Tue, 2018-03-13 at 16:45 +0530, Sukrit Bhatnagar wrote:
> Here is the output:
>
> skrtbhtngr@ubuntu:~/libvirt$ ./autogen.sh --system
>
> Updating submodules...
> Submodule 'gnulib' (git://git.sv.gnu.org/gnulib.git) registered for path
> '.gnulib'
> Submodule 'keycodemapdb'
On Wed, Mar 07, 2018 at 15:42:36 +0100, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> .../qemustatusxml2xmldata/migration-out-nbd-in.xml | 449
> +
> .../migration-out-nbd-out.xml | 1 +
> tests/qemuxml2xmltest.c
On Wed, Mar 07, 2018 at 15:42:35 +0100, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> tests/qemustatusxml2xmldata/modern-in.xml | 448
> +
> tests/qemustatusxml2xmldata/modern-out.xml | 1 +
> tests/qemuxml2xmltest.c
On Wed, Mar 07, 2018 at 15:42:34 +0100, Peter Krempa wrote:
> The testCompareDomXML2XMLPreFormatCallback is no longer used and thus
> can be removed.
>
> Signed-off-by: Peter Krempa
> ---
> tests/genericxml2xmltest.c | 2 +-
> tests/lxcxml2xmltest.c | 2 +-
>
On Wed, Mar 07, 2018 at 15:42:33 +0100, Peter Krempa wrote:
> Now that the better approach is in place we can remove the old functions
> doing the fake formatting.
>
> Signed-off-by: Peter Krempa
> ---
> tests/qemuxml2xmltest.c | 218
>
On Wed, Mar 07, 2018 at 15:42:32 +0100, Peter Krempa wrote:
> Add a random lockstate string to the status XML2XML test.
>
> Signed-off-by: Peter Krempa
> ---
> tests/qemustatusxml2xmldata/blockjob-mirror-in.xml | 1 +
> 1 file changed, 1 insertion(+)
ACK
Jirka
--
On Wed, Mar 07, 2018 at 15:42:31 +0100, Peter Krempa wrote:
> Add new approach to properly test status XML files by supplying a full
> XML file rather than generating synthetic test cases by prepending the
> status header. The two tests introduced here are copies of existing
> cases using the
On Wed, Mar 07, 2018 at 15:42:29 +0100, Peter Krempa wrote:
> Nobody should use format detection due to security implications. The
> result of the change is that 'raw' format will be printed unless
> specified explicitly.
>
> Signed-off-by: Peter Krempa
> ---
ACK
Jirka
--
On Wed, Mar 07, 2018 at 15:42:28 +0100, Peter Krempa wrote:
> Add a single testcase for the case where format probing is allowed.
>
> Signed-off-by: Peter Krempa
> ---
> .../qemuxml2argvdata/disk-many-format-probing.args | 29
>
On Wed, Mar 07, 2018 at 15:42:27 +0100, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> tests/qemuxml2xmltest.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
ACK
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
On Wed, Mar 07, 2018 at 15:42:30 +0100, Peter Krempa wrote:
> We have a test of the domain XML that allows format detection, so
> there's no need to do it for snapshot XMLs where the parameter would
> influence the domain XML portion.
> ---
>
Here is the output:
skrtbhtngr@ubuntu:~/libvirt$ ./autogen.sh --system
Updating submodules...
Submodule 'gnulib' (git://git.sv.gnu.org/gnulib.git) registered for path
'.gnulib'
Submodule 'keycodemapdb' (https://gitlab.com/keycodemap/keycodemapdb.git)
registered for path 'src/keycodemapdb'
Signed-off-by: Jiri Denemark
---
Makefile.am | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 0d46c16c22..81c7f52d9c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -69,6 +69,9 @@ EXTRA_DIST += \
rpm: clean
@(unset CDPATH ;
On Mon, Mar 12, 2018 at 05:21:45PM +0100, Pavel Hrdina wrote:
> This is called for every API, create a function for it.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/domain.c | 220
> ---
> 1 file changed, 75
On Mon, Mar 12, 2018 at 05:21:44PM +0100, Pavel Hrdina wrote:
> There is no need to open connection if parsing arguments fails.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/connect.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P.
On Mon, Mar 12, 2018 at 05:21:43PM +0100, Pavel Hrdina wrote:
> Fixes an bug that was introduced by <8e24f602>.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/connect.c | 2 +-
> src/connect.h | 4
> src/domain.c | 51 +++
On Mon, Mar 12, 2018 at 05:21:41PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/connect.h | 21 ++---
> src/domain.c | 1 +
> src/util.c| 42 +-
> 3 files changed, 36 insertions(+), 28
On Mon, Mar 12, 2018 at 05:21:42PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/connect.c | 1 -
> src/domain.c | 1 +
> src/domain.h | 1 -
> src/events.c | 1 +
> src/events.h | 3 ---
> src/main.c| 2 ++
> src/util.c| 2 ++
> src/util.h
On Mon, Mar 12, 2018 at 05:21:39PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Mon, Mar 12, 2018 at 05:21:40PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> libvirt-dbus.spec.in | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|:
On Mon, Mar 12, 2018 at 05:21:38PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/main.c | 4
> 1 file changed, 4 insertions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-
On Mon, Mar 12, 2018 at 05:21:37PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/events.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|:
On Mon, Mar 12, 2018 at 05:21:36PM +0100, Pavel Hrdina wrote:
> The reply contains only two strings.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
Regards,
On Mon, Mar 12, 2018 at 05:21:35PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/domain.c | 2 +-
> src/domain.h | 2 ++
> src/events.c | 8
> 3 files changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé
On Mon, Mar 12, 2018 at 05:21:33PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/util.c | 4 ++--
> src/util.h | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|:
On Mon, Mar 12, 2018 at 05:21:34PM +0100, Pavel Hrdina wrote:
> This also fixes the one wrong interface name in events.c.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/connect.c | 2 +-
> src/connect.h | 2 ++
> src/events.c | 2 +-
> 3 files changed, 4 insertions(+), 2
On Tue, Mar 13, 2018 at 09:39:13AM +0100, Pavel Hrdina wrote:
> On Mon, Mar 12, 2018 at 04:30:30PM +, Daniel P. Berrangé wrote:
> > On Mon, Mar 12, 2018 at 05:21:46PM +0100, Pavel Hrdina wrote:
> > > We will switch to libdbus library because the systemd sd-bus
> > > implementation is not
On Mon, Mar 12, 2018 at 05:21:31PM +0100, Pavel Hrdina wrote:
> The correct prefix is VIRT.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/connect.c | 8 +++---
> src/domain.c | 78
> +--
> src/events.c | 12 -
On Mon, Mar 12, 2018 at 05:21:32PM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/util.c | 34 ++
> src/util.h | 38 --
> 2 files changed, 42 insertions(+), 30 deletions(-)
Reviewed-by:
Since data.count is not a pointer, but an integer,
compare it against an integer value instead of using
the implicit "boolean" conversion that is customarily
used for pointers.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_domain_address.c | 2 +-
1 file changed, 1 insertion(+),
To match the rest of the file.
Signed-off-by: Ján Tomko
---
src/conf/domain_conf.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 5859c8f4b..337ce7942 100644
--- a/src/conf/domain_conf.h
+++
I managed to push commit 1cdc9ece without incorporating Andrea's
review feedback.
These are the follow-up fixes I pushed as trivial before the commit
police gets me.
Ján Tomko (2):
Adjust whitespace in virDomainDefHasUSB prototype
qemuDomainUSBAddressAddHubs: use numeric comparison
On Mon, Mar 12, 2018 at 04:30:30PM +, Daniel P. Berrangé wrote:
> On Mon, Mar 12, 2018 at 05:21:46PM +0100, Pavel Hrdina wrote:
> > We will switch to libdbus library because the systemd sd-bus
> > implementation is not thread safe.
>
> Hmmm, libdbus.so isn't all that great with threads
On Tue, Mar 13, 2018 at 02:09:30AM +0530, Sukrit Bhatnagar wrote:
> Hi,
>
> I am Sukrit, currently pursuing Masters in Computer Science and Engineering
> from Indian Institute of Technology Bombay, India.
>
> I am interested in applying for a few projects listed on the ideas page.
>
> But, I am
On Fri, Mar 09, 2018 at 05:48 PM +0100, John Ferlan wrote:
> Some of the indents were only 2 spaces, make consistent w/ 4 spaces
>
> Signed-off-by: John Ferlan
> ---
> src/openvz/openvz_driver.c | 64
> +++---
> 1
On Fri, Mar 09, 2018 at 05:47 PM +0100, John Ferlan wrote:
> For bhyveDomObjFromDomain, bhyveDomainLookupByUUID, and
> bhyveDomainLookupByID let's return a locked and referenced
> @vm object so that callers can then use the common and more
> consistent virDomainObjEndAPI in
94 matches
Mail list logo