On Wed, 2018-03-21 at 17:46 +0100, Michal Privoznik wrote:
>
> ACK. Although you've missed some other occurrences. I'm fixing them too.
>
> Michal
Thanks very much. As to the slightly weird U64(struct counter64) in comments...
I copy-pasted that from what mib2c generated with the patched .m2d. I
On Tue, Mar 20, 2018 at 03:10:12PM +, Daniel P. Berrangé wrote:
> On Tue, Mar 20, 2018 at 03:20:31PM +0100, Martin Kletzander wrote:
> > 1) Default devices/values
> >
> > Libvirt itself must default to whatever values there were before any
> > particular element was introduced due to the fact
On Wed, Mar 21, 2018 at 10:22 PM, Christian Ehrhardt <
christian.ehrha...@canonical.com> wrote:
> So far users added manual rules for most of these uncommon devices,
> but recent changes made some of the callbacks mandatory for hotplug
> so we should take shot at implementing them as those callbac
On Wed, Mar 21, 2018 at 08:19:46AM +0100, Peter Krempa wrote:
> On Tue, Mar 20, 2018 at 18:55:44 -0400, John Ferlan wrote:
> > Add VM Generation ID device XML schema, parse, format, and documentation.
> >
> > Signed-off-by: John Ferlan
> > ---
> > docs/formatdomain.html.in | 54
On Thu, Mar 22, 2018 at 09:40:40AM +0100, Pavel Hrdina wrote:
> On Tue, Mar 20, 2018 at 03:10:12PM +, Daniel P. Berrangé wrote:
> > > - I understand OpenStack has some really sensible and wisely chosen
> > > and/or tested default values.
> >
> > In terms of default devices and OS specific cho
On Wed, Mar 21, 2018 at 11:53:32AM -0400, John Ferlan wrote:
> Rather than unlock the object that was expected to be locked on
> input, let the caller perform the unlock or more succinctly a
> virSecretObjEndAPI on the object which will perform the Unref
> and Unlock and clear the @obj.
I understa
On Wed, Mar 21, 2018 at 04:34:23PM -0300, Eduardo Habkost wrote:
> On Wed, Mar 21, 2018 at 06:39:52PM +, Daniel P. Berrangé wrote:
> > On Wed, Mar 21, 2018 at 03:00:41PM -0300, Eduardo Habkost wrote:
> > > On Tue, Mar 20, 2018 at 03:10:12PM +, Daniel P. Berrangé wrote:
> > > > On Tue, Mar 2
On Wed, Mar 21, 2018 at 05:28:33PM +0100, Michal Privoznik wrote:
> The flags passed to virCommandPassFD() are unnamed and
> documentation to this function doesn't list them either.
> Give them name and mention it in documentation to functions
> using them.
>
> Signed-off-by: Michal Privoznik
> -
On Wed, Mar 21, 2018 at 05:32:27PM +0100, Marek Marczykowski-Górecki wrote:
> When support for mode=custom will be added in the future, semantics of
> current config will change. Reduce the surprise by emitting a warning.
>
> Signed-off-by: Marek Marczykowski-Górecki
> ---
> Changes since v5:
>
On Wed, Mar 21, 2018 at 05:28:34PM +0100, Michal Privoznik wrote:
> The set of arguments was changed a long time ago (040d9963420
> which dates back to July 2013) but the corresponding
> documentation was not updated.
>
> Signed-off-by: Michal Privoznik
> ---
> src/util/vircommand.c | 5 ++---
>
On Wed, Mar 21, 2018 at 05:32:26PM +0100, Marek Marczykowski-Górecki wrote:
> Preparation for global nestedhvm configuration - libxlMakeDomBuildInfo
> needs access to libxlDriverConfig.
> No functional change.
>
> Adjusting tests require slightly more mockup functions, because of
> libxlDriverConf
On Wed, Mar 21, 2018 at 05:32:31PM +0100, Marek Marczykowski-Górecki wrote:
> Test enabling/disabling individual CPU features and also setting
> nested HVM support, which is also controlled by CPU features node.
>
> Signed-off-by: Marek Marczykowski-Górecki
> Reviewed-by: Jim Fehlig
> ---
> Chan
On Wed, Mar 21, 2018 at 05:32:32PM +0100, Marek Marczykowski-Górecki wrote:
> Only "libxl" format supported for now. Special care needed around
> vmx/svm, because those two are translated into "nestedhvm" setting.
>
> Signed-off-by: Marek Marczykowski-Górecki
> ---
> Changes since v5:
> - adjust
On Wed, Mar 21, 2018 at 05:32:33PM +0100, Marek Marczykowski-Górecki wrote:
> Check conversion of "cpuid" setting, check all supported policy settings
> ("1", "0", "x"). Also, check interaction with "nestedhvm" - should not
> be included as "vmx=1" in "cpuid" setting.
>
> Signed-off-by: Marek Marc
On Thu, Mar 22, 2018 at 01:15:31AM +0100, Marek Marczykowski-Górecki wrote:
> Introduce global libxl option for enabling nested HVM feature, similar
> to kvm module parameter. This will prevent enabling experimental feature
> by mere presence of element in domain
> config, unless explicitly enable
On 03/15/2018 01:31 PM, Peter Krempa wrote:
> On Wed, Mar 14, 2018 at 17:05:38 +0100, Michal Privoznik wrote:
>> Before we exec() qemu we have to spawn pr-helper processes for
>> all managed reservations (well, technically there can only one).
>> The only caveat there is that we should place the pr
On Wed, 2018-03-21 at 16:11 +0100, Pavel Hrdina wrote:
> > +++ b/guests/vars/projects/blacklist.yml
> > @@ -0,0 +1,3 @@
> > +---
> > +packages:
> > + - nano
>
> In the past we've installed some packages, that were removed from
> ansible and it would make sense to list them in the blacklist in ord
On Thu, Mar 22, 2018 at 11:16:47AM +0100, Michal Privoznik wrote:
> On 03/15/2018 01:31 PM, Peter Krempa wrote:
> > On Wed, Mar 14, 2018 at 17:05:38 +0100, Michal Privoznik wrote:
> >> Before we exec() qemu we have to spawn pr-helper processes for
> >> all managed reservations (well, technically th
On Thu, Mar 22, 2018 at 11:18:17AM +0100, Andrea Bolognani wrote:
> On Wed, 2018-03-21 at 16:11 +0100, Pavel Hrdina wrote:
> > > +++ b/guests/vars/projects/blacklist.yml
> > > @@ -0,0 +1,3 @@
> > > +---
> > > +packages:
> > > + - nano
> >
> > In the past we've installed some packages, that were r
> On 22 Mar 2018, at 10:37, Daniel P. Berrangé wrote:
>
> On Thu, Mar 22, 2018 at 09:40:40AM +0100, Pavel Hrdina wrote:
>> On Tue, Mar 20, 2018 at 03:10:12PM +, Daniel P. Berrangé wrote:
- I understand OpenStack has some really sensible and wisely chosen
and/or tested default valu
On Thu, 2018-03-22 at 10:31 +, Daniel P. Berrangé wrote:
> > > The list of the removed packages is:
> > >
> > > polkit-devel
> > > glibc-rpcgen on Fedora > 27 (it was glibc-common)
> >
> > The rpcgen stuff is pretty confusing, even though I'm the one who
> > made the change :) Anyway,
On Thu, Mar 22, 2018 at 11:18:17AM +0100, Andrea Bolognani wrote:
> On Wed, 2018-03-21 at 16:11 +0100, Pavel Hrdina wrote:
> > > +++ b/guests/vars/projects/blacklist.yml
> > > @@ -0,0 +1,3 @@
> > > +---
> > > +packages:
> > > + - nano
> >
> > In the past we've installed some packages, that were r
Also add flake8 target in tests Makefile and rewrite
some parts to be more pythonic.
Signed-off-by: Katerina Koukiou
---
HACKING.md | 2 +-
test/Makefile.am | 15 ---
test/conftest.py | 15 +++
test/libvirttest.py | 51 -
On Wed, Mar 21, 2018 at 02:21:05PM +, Daniel P. Berrangé wrote:
> On Wed, Mar 21, 2018 at 11:02:43AM +0100, Pavel Hrdina wrote:
> > We will switch to GDBus implementation of D-Bus protocol because
> > sd-bus implementation is not thread safe.
> >
> > Processing messages in threads is essential
As of commit d4ea32e85f9e, libvirt no longer performs Ubuntu 12.04
builds on Travis, and reproducing locally issues that would hit
those CI jobs was the only reason introduced support in the first
place.
Signed-off-by: Andrea Bolognani
---
guests/host_vars/libvirt-ubuntu-12/install.yml | 3 ---
On Thu, Mar 22, 2018 at 01:11:03PM +0100, Andrea Bolognani wrote:
> As of commit d4ea32e85f9e, libvirt no longer performs Ubuntu 12.04
> builds on Travis, and reproducing locally issues that would hit
> those CI jobs was the only reason introduced support in the first
> place.
>
> Signed-off-by: A
On Thu, Mar 22, 2018 at 01:10:14PM +0100, Pavel Hrdina wrote:
> On Wed, Mar 21, 2018 at 02:21:05PM +, Daniel P. Berrangé wrote:
> > On Wed, Mar 21, 2018 at 11:02:43AM +0100, Pavel Hrdina wrote:
> > > We will switch to GDBus implementation of D-Bus protocol because
> > > sd-bus implementation is
Signed-off-by: Pavel Hrdina
---
Pushed under trivial rule. Thanks Katerina!
run.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/run.in b/run.in
index 1e48dc8..e98edaf 100644
--- a/run.in
+++ b/run.in
@@ -15,7 +15,7 @@
#
# Find this script
-b=@abs_tob_builddir@
+b=@abs
On Thu, Mar 22, 2018 at 09:56:12AM +, Daniel P. Berrangé wrote:
> On Wed, Mar 21, 2018 at 04:34:23PM -0300, Eduardo Habkost wrote:
> > On Wed, Mar 21, 2018 at 06:39:52PM +, Daniel P. Berrangé wrote:
> > > On Wed, Mar 21, 2018 at 03:00:41PM -0300, Eduardo Habkost wrote:
> > > > On Tue, Mar 2
On Thu, Mar 22, 2018 at 01:06:56PM +0100, Katerina Koukiou wrote:
Also add flake8 target in tests Makefile and rewrite
some parts to be more pythonic.
Using conjunctions like 'also' and 'and' this way in the commit message
is usually a sign that the commit contains multiple logical changes
and
On Tue, Mar 20, 2018 at 06:48:43AM +, Radostin Stoyanov wrote:
Changes since v1
(https://www.redhat.com/archives/libvir-list/2018-March/msg01001.html)
01 - Fixed typo.
03 - Added whitespace after comma in: value = value + re.sub("^(\d+)U$","\\1",
token[1])
05 and 06 - Use printf style form
GLib uses macros to create cleanup functions that are used by
g_auto or g_autoptr macros. They expect a function defined as
"void (*)(void *)" which is usually not that case.
Signed-off-by: Pavel Hrdina
---
Pushed under build-breaker rule.
m4/virt-compile-warnings.m4 | 2 ++
1 file changed, 2
Daniel P. Berrangé (2):
rpc: remove remains of obsolete log_buffer_size config parameter
rpc: avoid duplicating config in virtlockd/virtlogd augeas tests
src/locking/test_virtlockd.aug.in | 15 ---
src/locking/virtlockd.aug | 1 -
src/locking/virtlockd.conf| 15 ++
Most of the augeas test files use ::CONFIG:: to pull in the master
config file for testing. This ensures that entries added to the config
file are actually tested by augeas.
This identified the missing admin_max_clients example in the virtlogd
config file, which in turn prompted a change in descri
The global log buffer feature was deleted in:
commit c0c8c1d7bb53e0420f8573ea961ef7e19b7fff85
Author: Daniel P. Berrange
Date: Mon Mar 3 14:54:33 2014 +
Remove global log buffer feature entirely
A earlier commit changed the global log buffer so that it only
records messa
Thank you all for getting back so quickly. Some responses inline
-Original Message-
From: sendmail On Behalf Of Laine Stump
Sent: Wednesday, March 21, 2018 7:54 PM
To: libvirt
Cc: Ciprian Barbu ; Alexandru Avadanii
; Alex Williamson
Subject: Re: [libvirt] PCI passthrough/SR-IOV on Ca
The code that calls VIR_WARN after a function fails, doesn't
report the error message raised by the failing function.
Such error messages are now reported in lxc/lxc_driver.c
Signed-off-by: Prafullkumar T
---
src/lxc/lxc_driver.c | 36 ++--
1 file changed, 18 inse
Hello,
Thank you for getting back to me so soon. I switched to Thunderbird for
better text clarity. See some comment inline:
On 21.03.2018 19:54, Laine Stump wrote:
On 03/21/2018 11:46 AM, Ciprian Barbu wrote:
Hello,
In the context of running Openstack on a cluster of Cavium ThunderX cn8890
[ I fixed up ovirt-de...@redhat.com to be de...@ovirt.org since the
former is deprecated. I'm also not trimming down much of the reply so
that they can get the whole picture. Sorry for the confusion ]
On Tue, Mar 20, 2018 at 03:10:12PM +, Daniel P. Berrangé wrote:
On Tue, Mar 20, 2018 at
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index f765c09416..0eec50b6bd 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -10
The directory and the files contained within need to be owned
by the user or compilation will fail, either loudly or silently
depending on the OS, due to missing write permissions.
Signed-off-by: Andrea Bolognani
---
guests/tasks/users.yml | 4
1 file changed, 4 insertions(+)
diff --git a/
On Thu, 2018-03-22 at 14:54 +, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> src/remote/remote_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index f765c09416..0eec50b6bd 1006
On Thu, Mar 22, 2018 at 04:03:20PM +0100, Andrea Bolognani wrote:
> The directory and the files contained within need to be owned
> by the user or compilation will fail, either loudly or silently
> depending on the OS, due to missing write permissions.
>
> Signed-off-by: Andrea Bolognani
> ---
>
On 03/22/2018 10:54 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> src/remote/remote_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: John Ferlan
John
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman
Starting with commit id 'fab9d6e1' the formatting of:
{ "command-name", QEMU_CAPS_NAME },
was altered to:
{ "command-name", QEMU_CAPS_NAME},
and then commit id 'e2b05c9a' altered that to:
{ "command-name", QEMU_CAPS_NAME}
So, let's just fix that up to make things consistent with the
rest of t
On Thu, Mar 22, 2018 at 11:22:10AM -0400, John Ferlan wrote:
Starting with commit id 'fab9d6e1' the formatting of:
{ "command-name", QEMU_CAPS_NAME },
was altered to:
{ "command-name", QEMU_CAPS_NAME},
and then commit id 'e2b05c9a' altered that to:
{ "command-name", QEMU_CAPS_NAME}
So, let'
On Thu, Mar 22, 2018 at 10:03:50AM +, Daniel P. Berrangé wrote:
> On Wed, Mar 21, 2018 at 05:32:31PM +0100, Marek Marczykowski-Górecki wrote:
> > Test enabling/disabling individual CPU features and also setting
> > nested HVM support, which is also controlled by CPU features node.
> >
> > Sign
On Thu, Mar 22, 2018 at 04:47:21PM +0100, Marek Marczykowski-Górecki wrote:
> On Thu, Mar 22, 2018 at 10:03:50AM +, Daniel P. Berrangé wrote:
> > On Wed, Mar 21, 2018 at 05:32:31PM +0100, Marek Marczykowski-Górecki wrote:
> > > Test enabling/disabling individual CPU features and also setting
>
On Mon, Mar 19, 2018 at 12:44:31PM +0100, Christian Ehrhardt wrote:
libvirt-guests.sh when run with more active guests than requested to
shut down in parallel will run until it times out only shutting down
the first set of guests.
This patch fixes parallel shutdown by fixing a variable scope iss
On Thu, Mar 22, 2018 at 01:06:56PM +0100, Katerina Koukiou wrote:
> Also add flake8 target in tests Makefile and rewrite
> some parts to be more pythonic.
>
> Signed-off-by: Katerina Koukiou
> ---
> HACKING.md | 2 +-
> test/Makefile.am | 15 ---
> test/conftest.py
On Wed, 2018-03-21 at 22:22 +0100, Christian Ehrhardt wrote:
> So far the virt-aa-helper tests only checked the return code and
> thereby
> catched aborts like issues failing to parse the XML. But there is one
> category of virt-aa-helper issues so far untested - not generating
> the
> expected rul
Hi !
I'm submitting my messages on this mailing list to request a bit of
help on a case that I have
where a Python application makes a call to virDomainIsActive, and the
call never returns.
I have tried to investigate, but as there are no debug symbols for
libvirt on Debian Stretch,
i can only ha
Signed-off-by: Katerina Koukiou
---
src/test/test_driver.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 4de0cc533..f9482970a 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -1782,13 +1782
On Thu, Mar 22, 2018 at 03:54:01PM +0100, Martin Kletzander wrote:
> >
> > > One more thing could be automatically figuring out best values based on
> > > libosinfo-provided data.
> > >
> > > 2) Policies
> > >
> > > Lot of the time there are parts of the domain definition that need to be
> > > a
Hi,
On Thursday, 22 March 2018 17:10:49 CET Mathieu Tarral wrote:
> I have tried to investigate, but as there are no debug symbols for
> libvirt on Debian Stretch,
Yes there are: Stretch started the migration to automatically generated
packages with debug symbols -- see:
https://wiki.debian.org/A
Move to pytest to take advantage of:
* tests parametrization
* pdb support
* more compact tests - not forcing large test classes
Signed-off-by: Katerina Koukiou
---
HACKING.md | 2 +-
test/Makefile.am | 7 ---
test/conftest.py | 15 +++
test/libvirttest.py
The new test APIs allow to validate JSON objects against the QAPI
schema. The infrastructure was developed as part of not-yet-posted
blockdev JSON property generator. It is quite useful for developing
generators for complex objects against the schema.
Since it's kind of useful by itself I decided
Most other buffer APIs tolerate the buffer being NULL.
Signed-off-by: Peter Krempa
---
src/util/virbuffer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/util/virbuffer.c b/src/util/virbuffer.c
index 1a6bf122e0..3d6defb73a 100644
--- a/src/util/virbuffer.c
+++ b/src/util/virbuffer.c
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 +
src/util/virjson.c | 7 +++
src/util/virjson.h | 2 ++
3 files changed, 10 insertions(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index c3e4fd23df..03fe3b315f 100644
--- a/src/libvirt_private.
Prepare for testing of the schema of used commands by changing few
arguments to values which will not be rejected.
Signed-off-by: Peter Krempa
---
tests/qemumonitorjsontest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjs
Add infrastructure that will allow testing schema of the commands we
pass to the fake monitor object, so that we can make sure that it
actually does something.
Signed-off-by: Peter Krempa
---
tests/Makefile.am| 2 +-
tests/qemuhotplugtest.c | 3 +-
tests/qemumonitortestutils.c
Extract the code into qemu_qapi.c/h so that we separate it from various
parts of the code.
Signed-off-by: Peter Krempa
---
po/POTFILES.in | 1 +
src/qemu/Makefile.inc.am | 2 +
src/qemu/qemu_capabilities.c | 158 +---
src/qemu/qemu_qapi.c
The 'simple' monitor tests were quite useless, since the code did not
even check whether the correct command was called.
This patch uses the QAPI schema validator to validate that the arguments
are in format according to the schema.
Signed-off-by: Peter Krempa
---
tests/qemumonitorjsontest.c |
virQEMUQapiSchemaTraverse would return previous-to-last queried item on
a query. It would not be a problem if checking if the given path exists
since error reporting works properly but if the caller is interrested in
the result, it would be wrong.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_qa
Add a function which will allow to test whether a JSON object conforms
to the QAPI schema. This greatly helps when developing formatters for
new JSON objects and will help make sure that the code will not break in
cases which have unit tests but were actually not function-tested
(mostly various dis
Change the prefix of the functions to 'virQEMUQapi' and rename the two
public APIs so that the verb is put last.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 4 ++--
src/qemu/qemu_qapi.c | 36 ++--
src/qemu/qemu_qapi.h | 10 +
The JSON array was processed to the hash table used by the query apis in
the monitor code. Move it to a new helper in qemu_qapi.c.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 9 ++--
src/qemu/qemu_monitor.c | 2 +-
src/qemu/qemu_monitor.h | 2 +-
src/qemu/qemu
Adding this for completeness
Signed-off-by: Katerina Koukiou
---
Needed by the libvirt-dbus which is using test_driver for tests.
src/test/test_driver.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 4de0cc53
On Thu, Mar 22, 2018 at 02:22:14PM +, Daniel P. Berrangé wrote:
Daniel P. Berrangé (2):
rpc: remove remains of obsolete log_buffer_size config parameter
rpc: avoid duplicating config in virtlockd/virtlogd augeas tests
src/locking/test_virtlockd.aug.in | 15 ---
src/locking/virtl
On Thu, Mar 22, 2018 at 02:22:16PM +, Daniel P. Berrangé wrote:
Most of the augeas test files use ::CONFIG:: to pull in the master
config file for testing. This ensures that entries added to the config
file are actually tested by augeas.
This identified the missing admin_max_clients example
On Thu, Mar 22, 2018 at 07:22:40PM +0100, Katerina Koukiou wrote:
Move to pytest to take advantage of:
* tests parametrization
* pdb support
* more compact tests - not forcing large test classes
Signed-off-by: Katerina Koukiou
---
HACKING.md | 2 +-
test/Makefile.am | 7 ---
t
On Mon, Mar 19, 2018 at 02:35:30PM -0400, Farhan Ali wrote:
QEMU on S390 (since v2.11) can support the virtio-gpu-ccw device,
which can be used as a video device.
Signed-off-by: Farhan Ali
---
docs/formatdomain.html.in | 3 +++
src/qemu/qemu_command.c| 13 +++--
src/qemu/qem
On Mon, Mar 19, 2018 at 02:35:31PM -0400, Farhan Ali wrote:
A test cases to test the virtio-gpu-ccw device.
Signed-off-by: Farhan Ali
Signed-off-by: Boris Fiuczynski
---
.../qemuxml2argvdata/video-virtio-gpu-ccw-auto.xml | 18 ++
tests/qemuxml2argvdata/video-virtio-gpu-ccw.args | 25 +
On Mon, Mar 19, 2018 at 02:35:28PM -0400, Farhan Ali wrote:
Hi,
This patch series adds Libvirt support for video and input devices
for QEMU guests on S390. QEMU v2.11.0 added support for the
virtio-gpu-ccw device [1] and virtio-{keyboard, mouse, tablet}-ccw devices [2],
which can be used as vide
On 03/22/2018 03:18 PM, Ján Tomko wrote:
On Mon, Mar 19, 2018 at 02:35:30PM -0400, Farhan Ali wrote:
QEMU on S390 (since v2.11) can support the virtio-gpu-ccw device,
which can be used as a video device.
Signed-off-by: Farhan Ali
---
docs/formatdomain.html.in | 3 +++
src/qemu/qemu_comm
On 03/22/2018 03:27 PM, Ján Tomko wrote:
On Mon, Mar 19, 2018 at 02:35:31PM -0400, Farhan Ali wrote:
A test cases to test the virtio-gpu-ccw device.
Signed-off-by: Farhan Ali
Signed-off-by: Boris Fiuczynski
---
.../qemuxml2argvdata/video-virtio-gpu-ccw-auto.xml | 18 ++
tests/qemuxml
On Thu, Mar 22, 2018 at 07:31:38PM +0100, Peter Krempa wrote:
Most other buffer APIs tolerate the buffer being NULL.
Signed-off-by: Peter Krempa
---
src/util/virbuffer.c | 3 +++
1 file changed, 3 insertions(+)
ACK
Jan
signature.asc
Description: Digital signature
--
libvir-list mailing lis
On 03/22/2018 03:32 PM, Ján Tomko wrote:
On Mon, Mar 19, 2018 at 02:35:28PM -0400, Farhan Ali wrote:
Hi,
This patch series adds Libvirt support for video and input devices
for QEMU guests on S390. QEMU v2.11.0 added support for the
virtio-gpu-ccw device [1] and virtio-{keyboard, mouse, tablet
On Thu, Mar 22, 2018 at 07:31:39PM +0100, Peter Krempa wrote:
Extract the code into qemu_qapi.c/h so that we separate it from various
parts of the code.
Signed-off-by: Peter Krempa
---
po/POTFILES.in | 1 +
src/qemu/Makefile.inc.am | 2 +
src/qemu/qemu_capabilities.c | 158 +
On Thu, Mar 22, 2018 at 07:31:40PM +0100, Peter Krempa wrote:
Change the prefix of the functions to 'virQEMUQapi' and rename the two
Please, virQEMUQAPI
public APIs so that the verb is put last.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 4 ++--
src/qemu/qemu_qapi.c
On Thu, Mar 22, 2018 at 07:31:41PM +0100, Peter Krempa wrote:
The JSON array was processed to the hash table used by the query apis in
the monitor code. Move it to a new helper in qemu_qapi.c.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 9 ++--
src/qemu/qemu_monitor.c
On Thu, Mar 22, 2018 at 07:31:42PM +0100, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 +
src/util/virjson.c | 7 +++
src/util/virjson.h | 2 ++
3 files changed, 10 insertions(+)
ACK
Jan
signature.asc
Description: Digital signature
--
libvir
On Thu, Mar 22, 2018 at 07:31:43PM +0100, Peter Krempa wrote:
virQEMUQapiSchemaTraverse would return previous-to-last queried item on
a query. It would not be a problem if checking if the given path exists
since error reporting works properly but if the caller is interrested in
s/interrested/in
On Thu, Mar 22, 2018 at 07:31:44PM +0100, Peter Krempa wrote:
Add the QAPI schema (returned by 'query-qmp-schema' command) which will
be used for QAPI schema testing in upcomming patches.
s/upcomming/upcoming/
Signed-off-by: Peter Krempa
---
tests/Makefile.am | 1 +
tests/qemuqap
On Thu, Mar 22, 2018 at 07:31:45PM +0100, Peter Krempa wrote:
Add a function which will allow to test whether a JSON object conforms
to the QAPI schema. This greatly helps when developing formatters for
new JSON objects and will help make sure that the code will not break in
cases which have unit
On Thu, Mar 22, 2018 at 07:31:46PM +0100, Peter Krempa wrote:
Prepare for testing of the schema of used commands by changing few
arguments to values which will not be rejected.
Signed-off-by: Peter Krempa
---
tests/qemumonitorjsontest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On Thu, Mar 22, 2018 at 07:31:47PM +0100, Peter Krempa wrote:
Add infrastructure that will allow testing schema of the commands we
pass to the fake monitor object, so that we can make sure that it
actually does something.
Signed-off-by: Peter Krempa
---
tests/Makefile.am| 2 +-
test
On Thu, Mar 22, 2018 at 07:31:48PM +0100, Peter Krempa wrote:
The 'simple' monitor tests were quite useless, since the code did not
even check whether the correct command was called.
This patch uses the QAPI schema validator to validate that the arguments
are in format according to the schema.
On Thu, Mar 22, 2018 at 07:42:27PM +0100, Katerina Koukiou wrote:
Adding this for completeness
Signed-off-by: Katerina Koukiou
---
Needed by the libvirt-dbus which is using test_driver for tests.
src/test/test_driver.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
ACK & p
Signed-off-by: Stefan Raspl
---
updater/virt-tools/config.ini | 3 +++
1 file changed, 3 insertions(+)
diff --git a/updater/virt-tools/config.ini b/updater/virt-tools/config.ini
index ff1bff3..8b199b7 100644
--- a/updater/virt-tools/config.ini
+++ b/updater/virt-tools/config.ini
@@ -179,3 +179,6
Stefan Raspl (1):
Add KVM on Z to Planet virttools
updater/virt-tools/config.ini | 3 +++
1 file changed, 3 insertions(+)
--
2.13.5
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 03/21/2018 10:32 AM, Marek Marczykowski-Górecki wrote:
Test enabling/disabling individual CPU features and also setting
nested HVM support, which is also controlled by CPU features node.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
Changes since v3:
- adjust for m
On 03/21/2018 10:32 AM, Marek Marczykowski-Górecki wrote:
Preparation for global nestedhvm configuration - libxlMakeDomBuildInfo
needs access to libxlDriverConfig.
No functional change.
Adjusting tests require slightly more mockup functions, because of
libxlDriverConfigNew() call.
Signed-off-by
On 03/21/2018 06:15 PM, Marek Marczykowski-Górecki wrote:
Introduce global libxl option for enabling nested HVM feature, similar
to kvm module parameter. This will prevent enabling experimental feature
by mere presence of element in domain
config, unless explicitly enabled. element
may be used
On 03/22/2018 04:44 PM, Jim Fehlig wrote:
On 03/21/2018 10:32 AM, Marek Marczykowski-Górecki wrote:
Preparation for global nestedhvm configuration - libxlMakeDomBuildInfo
needs access to libxlDriverConfig.
No functional change.
Adjusting tests require slightly more mockup functions, because of
On Thu, Mar 22, 2018 at 04:48:48PM -0600, Jim Fehlig wrote:
> On 03/22/2018 04:44 PM, Jim Fehlig wrote:
> > On 03/21/2018 10:32 AM, Marek Marczykowski-Górecki wrote:
> > > Preparation for global nestedhvm configuration - libxlMakeDomBuildInfo
> > > needs access to libxlDriverConfig.
> > > No functi
On 03/22/2018 04:59 PM, Marek Marczykowski-Górecki wrote:
On Thu, Mar 22, 2018 at 04:48:48PM -0600, Jim Fehlig wrote:
On 03/22/2018 04:44 PM, Jim Fehlig wrote:
On 03/21/2018 10:32 AM, Marek Marczykowski-Górecki wrote:
Preparation for global nestedhvm configuration - libxlMakeDomBuildInfo
needs
On Thu, Mar 22, 2018 at 5:26 PM, Martin Kletzander
wrote:
> On Mon, Mar 19, 2018 at 12:44:31PM +0100, Christian Ehrhardt wrote:
>
>> libvirt-guests.sh when run with more active guests than requested to
>> shut down in parallel will run until it times out only shutting down
>> the first set of gue
On Thu, Mar 22, 2018 at 5:35 PM, Jamie Strandboge
wrote:
> On Wed, 2018-03-21 at 22:22 +0100, Christian Ehrhardt wrote:
> > So far the virt-aa-helper tests only checked the return code and
> > thereby
> > catched aborts like issues failing to parse the XML. But there is one
> > category of virt-a
99 matches
Mail list logo