[libvirt] [PATCH 1/2] util: honor reportError parameter in virSocketAddrParseInternal

Signed-off-by: Jim Fehlig --- src/util/virsocketaddr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index 95b527436..31a740cb8 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c @@

[libvirt] [PATCH 2/2] util: introduce virSocketAddrParseAny

When preparing for migration, the libxl driver creates a new TCP listen socket for the incoming migration by calling virNetSocketNewListenTCP, passing the destination host name. virNetSocketNewListenTCP calls virSocketAddrParse to check if the host name is a wildcard address, in which case it

[libvirt] [PATCH 0/2] utils: squelch errors from virNetSocketNewConnectTCP

Patch1 fixes a case where error is reported even when the reportError parameter is false. Patch2 is essentially a V2 of a patch posted earlier, incorporating some ideas from jferlan's review https://www.redhat.com/archives/libvir-list/2018-March/msg01120.html Jim Fehlig (2): util: honor

Re: [libvirt] [dbus PATCH v2] Add 'Version' property for virConnectGetVersion

On Mon, 2018-03-26 at 18:09 +0200, Pavel Hrdina wrote: > On Mon, Mar 26, 2018 at 05:19:22PM +0200, Katerina Koukiou wrote: > > --- > > data/org.libvirt.Connect.xml | 4 > > src/connect.c| 25 - > > test/test_connect.py | 9 + > > 3

Re: [libvirt] [dbus PATCH 2/4] spec: cleanup spec file based on fedora package review

On Mon, Mar 26, 2018 at 05:54:48PM +0200, Ján Tomko wrote: > On Mon, Mar 26, 2018 at 03:33:51PM +0200, Pavel Hrdina wrote: > > All of these changes are simple enough so I've put the into single > > commit: > > > >- remove obsolete tags and commands > >- %global macro is preferred over

Re: [libvirt] [dbus PATCH v2] Add 'Version' property for virConnectGetVersion

On Mon, Mar 26, 2018 at 05:19:22PM +0200, Katerina Koukiou wrote: > --- > data/org.libvirt.Connect.xml | 4 > src/connect.c| 25 - > test/test_connect.py | 9 + > 3 files changed, 37 insertions(+), 1 deletion(-) Looks like that the

Re: [libvirt] [dbus PATCH v2] Add 'Version' property for virConnectGetVersion

On Mon, Mar 26, 2018 at 05:54:17PM +0200, Ján Tomko wrote: > On Mon, Mar 26, 2018 at 05:19:22PM +0200, Katerina Koukiou wrote: > > --- > > data/org.libvirt.Connect.xml | 4 > > src/connect.c| 25 - > > test/test_connect.py | 9 + > > 3

Re: [libvirt] [PATCH sandbox] Delete the virt-sandbox-service command

On Mon, 2018-03-26 at 15:35 +0100, Daniel P. Berrangé wrote: > This command attempted to create sandboxed containers for running > systemd services that exist on the host. This code has proved very > fragile, however, since it needs heuristics to figure out which dirs > need to be made private in

Re: [libvirt] [dbus PATCH 2/4] spec: cleanup spec file based on fedora package review

On Mon, Mar 26, 2018 at 03:33:51PM +0200, Pavel Hrdina wrote: All of these changes are simple enough so I've put the into single commit: - remove obsolete tags and commands - %global macro is preferred over %define macro - use %autosetup, %make_build and %make_install macros -

Re: [libvirt] [dbus PATCH v2] Add 'Version' property for virConnectGetVersion

On Mon, Mar 26, 2018 at 05:19:22PM +0200, Katerina Koukiou wrote: --- data/org.libvirt.Connect.xml | 4 src/connect.c| 25 - test/test_connect.py | 9 + 3 files changed, 37 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [dbus PATCH v2] Add 'Version' property for virConnectGetVersion

On Mon, Mar 26, 2018 at 05:19:22PM +0200, Katerina Koukiou wrote: > --- > data/org.libvirt.Connect.xml | 4 > src/connect.c| 25 - > test/test_connect.py | 9 + > 3 files changed, 37 insertions(+), 1 deletion(-) Thanks, I've pushed

Re: [libvirt] [PATCH v2 3/3] news: Document device mapper fix

On Mon, Mar 26, 2018 at 16:43:03 +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > docs/news.xml | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index 1088895746..6f1ceb6389 100644 > ---

Re: [libvirt] [dbus PATCH 1/4] maint: remove AUTHORS from repository

On Mon, Mar 26, 2018 at 04:22:02PM +0100, Daniel P. Berrangé wrote: > On Mon, Mar 26, 2018 at 05:11:06PM +0200, Pavel Hrdina wrote: > > On Mon, Mar 26, 2018 at 02:56:06PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Mar 26, 2018 at 03:33:50PM +0200, Pavel Hrdina wrote: > > > > This is tracked by

Re: [libvirt] [PATCH v2 2/3] qemu: Handle device mapper targets properly

On 03/26/2018 05:17 PM, Peter Krempa wrote: > On Mon, Mar 26, 2018 at 16:43:02 +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1557769 >> >> Problem with device mapper targets is that there can be several >> other devices 'hidden' behind them. For instance, /dev/dm-1

Re: [libvirt] [dbus PATCH 1/4] maint: remove AUTHORS from repository

On Mon, Mar 26, 2018 at 05:11:06PM +0200, Pavel Hrdina wrote: > On Mon, Mar 26, 2018 at 02:56:06PM +0100, Daniel P. Berrangé wrote: > > On Mon, Mar 26, 2018 at 03:33:50PM +0200, Pavel Hrdina wrote: > > > This is tracked by git itself. Suggested during fedora package review. > > > > AUTHORS is a

[libvirt] [dbus PATCH v2] Add 'Version' property for virConnectGetVersion

--- data/org.libvirt.Connect.xml | 4 src/connect.c| 25 - test/test_connect.py | 9 + 3 files changed, 37 insertions(+), 1 deletion(-) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index e47c2f5..56a1126

Re: [libvirt] [dbus PATCH 2/4] spec: cleanup spec file based on fedora package review

On Mon, Mar 26, 2018 at 03:43:02PM +0200, Ján Tomko wrote: > On Mon, Mar 26, 2018 at 03:33:51PM +0200, Pavel Hrdina wrote: > > All of these changes are simple enough so I've put the into single > > commit: > > > > Sigh, > > Jan This means that you want me to send a v2 where I split the changes

Re: [libvirt] [PATCH v2 2/3] qemu: Handle device mapper targets properly

On Mon, Mar 26, 2018 at 16:43:02 +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1557769 > > Problem with device mapper targets is that there can be several > other devices 'hidden' behind them. For instance, /dev/dm-1 can > consist of /dev/sda, /dev/sdb and /dev/sdc.

Re: [libvirt] [dbus PATCH 2/2] Add 'NumOfDomains' property for virConnectGetNumOfDomains

On Mon, 2018-03-26 at 16:07 +0100, Daniel P. Berrangé wrote: > On Mon, Mar 26, 2018 at 04:58:09PM +0200, Katerina Koukiou wrote: > > --- > > data/org.libvirt.Connect.xml | 4 > > src/connect.c| 20 > > test/test_connect.py | 1 + > > 3 files

Re: [libvirt] [PATCH v2 1/3] util: Introduce virDevMapperGetTargets

On Mon, Mar 26, 2018 at 16:43:01 +0200, Michal Privoznik wrote: > This helper fetches dependencies for given device mapper target. > > At the same time, we need to provide a dummy log function because > by default libdevmapper prints out error messages to stderr which > we need to suppress. > >

Re: [libvirt] [dbus PATCH 1/4] maint: remove AUTHORS from repository

On Mon, Mar 26, 2018 at 02:56:06PM +0100, Daniel P. Berrangé wrote: > On Mon, Mar 26, 2018 at 03:33:50PM +0200, Pavel Hrdina wrote: > > This is tracked by git itself. Suggested during fedora package review. > > AUTHORS is a file that autoconf/automake expects to exist in all > projects. Also the

Re: [libvirt] [dbus PATCH 2/2] Add 'NumOfDomains' property for virConnectGetNumOfDomains

On Mon, Mar 26, 2018 at 04:58:09PM +0200, Katerina Koukiou wrote: > --- > data/org.libvirt.Connect.xml | 4 > src/connect.c| 20 > test/test_connect.py | 1 + > 3 files changed, 25 insertions(+) > > diff --git a/data/org.libvirt.Connect.xml

Re: [libvirt] [dbus PATCH 1/2] Add 'Version' property for virConnectGetVersion

On Mon, 2018-03-26 at 16:58 +0200, Katerina Koukiou wrote: > --- > data/org.libvirt.Connect.xml | 4 > src/connect.c| 25 - > test/test_connect.py | 8 > 3 files changed, 36 insertions(+), 1 deletion(-) > > diff --git

[libvirt] [dbus PATCH 1/2] Add 'Version' property for virConnectGetVersion

--- data/org.libvirt.Connect.xml | 4 src/connect.c| 25 - test/test_connect.py | 8 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index e47c2f5..56a1126

[libvirt] [dbus PATCH 2/2] Add 'NumOfDomains' property for virConnectGetNumOfDomains

--- data/org.libvirt.Connect.xml | 4 src/connect.c| 20 test/test_connect.py | 1 + 3 files changed, 25 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 56a1126..a58504d 100644 ---

[libvirt] [dbus PATCH 0/2] Add missing properties from LIBVIRT 0.0.3

Implemented the following properties: * virConnectGetVersion * virConnectNumOfDomains Katerina Koukiou (2): Add 'Version' property for virConnectGetVersion Add 'NumOfDomains' property for virConnectGetNumOfDomains data/org.libvirt.Connect.xml | 8 src/connect.c| 45

[libvirt] [PATCH v2 1/3] util: Introduce virDevMapperGetTargets

This helper fetches dependencies for given device mapper target. At the same time, we need to provide a dummy log function because by default libdevmapper prints out error messages to stderr which we need to suppress. Signed-off-by: Michal Privoznik ---

[libvirt] [PATCH v2 2/3] qemu: Handle device mapper targets properly

https://bugzilla.redhat.com/show_bug.cgi?id=1557769 Problem with device mapper targets is that there can be several other devices 'hidden' behind them. For instance, /dev/dm-1 can consist of /dev/sda, /dev/sdb and /dev/sdc. Therefore, when setting up devices CGroup and namespaces we have to take

[libvirt] [PATCH v2 3/3] news: Document device mapper fix

Signed-off-by: Michal Privoznik --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 1088895746..6f1ceb6389 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -94,6 +94,16 @@ + +

[libvirt] [PATCH v2 0/3] Improve handling of multipath devices

v2 of: https://www.redhat.com/archives/libvir-list/2018-March/msg01541.html diff to v1: - Moved code to new file virdevmapper.c - Rename to virDevMapperGetTargets because this bug is not specific just to multipath rather than all device mapper targets - Reworked logging as suggested in review

[libvirt] [PATCH sandbox] Delete the virt-sandbox-service command

This command attempted to create sandboxed containers for running systemd services that exist on the host. This code has proved very fragile, however, since it needs heuristics to figure out which dirs need to be made private in the container vs shared with the host. Even a relatively simple

Re: [libvirt] [PATCH v3 1/9] qemu: provide support to query the SEV capability

On Mon, 2018-03-26 at 08:52 -0500, Brijesh Singh wrote: > > I tried applying just this patch, but kept getting: > > > > 29) caps_2.12.0(x86_64) > > ... libvirt: QEMU Driver error : internal error: query-cpu-definitions > > reply data was not an array > > > > a small bit of debugging found that

[libvirt] Plans for next release

I was reminded that the end of the month is very soon :-) I suggest to enter freeze tomorrow morning, then going RC2 on Thursday and then push the release over the week-end or Monday morning hope this works for all ! Daniel -- Daniel Veillard | Red Hat Developers Tools

Re: [libvirt] [dbus PATCH 4/4] spec: fix D-Bus spelling and improve description

On Mon, Mar 26, 2018 at 03:33:53PM +0200, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- libvirt-dbus.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ACK Jan signature.asc Description: Digital signature -- libvir-list mailing list

Re: [libvirt] [dbus PATCH 3/4] spec: Require dbus and polkit

On Mon, Mar 26, 2018 at 03:33:52PM +0200, Pavel Hrdina wrote: libvirt-dbus installs configuration files for these packages therefore it should depend on it. Signed-off-by: Pavel Hrdina --- libvirt-dbus.spec.in | 2 ++ 1 file changed, 2 insertions(+) ACK Jan

Re: [libvirt] [dbus PATCH 1/4] maint: remove AUTHORS from repository

On Mon, Mar 26, 2018 at 03:33:50PM +0200, Pavel Hrdina wrote: This is tracked by git itself. Suggested during fedora package review. Signed-off-by: Pavel Hrdina --- AUTHORS.in | 13 - Makefile.am | 14 -- libvirt-dbus.spec.in | 2

Re: [libvirt] [dbus PATCH 1/4] maint: remove AUTHORS from repository

On Mon, Mar 26, 2018 at 03:33:50PM +0200, Pavel Hrdina wrote: > This is tracked by git itself. Suggested during fedora package review. AUTHORS is a file that autoconf/automake expects to exist in all projects. Also the git history is not included with the tar.gz dist, so IMHO the AUTHORS is

Re: [libvirt] [PATCH v3 1/9] qemu: provide support to query the SEV capability

Hi John, On 03/23/2018 02:18 PM, John Ferlan wrote: On 03/14/2018 11:44 AM, Brijesh Singh wrote: QEMU version >= 2.12 provides support for launching an encrypted VMs on AMD x86 platform using Secure Encrypted Virtualization (SEV) feature. This patch adds support to query the SEV capability

Re: [libvirt] [dbus PATCH 2/4] spec: cleanup spec file based on fedora package review

On Mon, Mar 26, 2018 at 03:33:51PM +0200, Pavel Hrdina wrote: All of these changes are simple enough so I've put the into single commit: Sigh, Jan signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [dbus PATCH 0/4] remove AUTHORS file and cleanup spec file

Pavel Hrdina (4): maint: remove AUTHORS from repository spec: cleanup spec file based on fedora package review spec: Require dbus and polkit spec: fix D-Bus spelling and improve description AUTHORS.in | 13 - Makefile.am | 14 --

[libvirt] [dbus PATCH 2/4] spec: cleanup spec file based on fedora package review

All of these changes are simple enough so I've put the into single commit: - remove obsolete tags and commands - %global macro is preferred over %define macro - use %autosetup, %make_build and %make_install macros - COPYING file should be listed using %license macro

[libvirt] [dbus PATCH 1/4] maint: remove AUTHORS from repository

This is tracked by git itself. Suggested during fedora package review. Signed-off-by: Pavel Hrdina --- AUTHORS.in | 13 - Makefile.am | 14 -- libvirt-dbus.spec.in | 2 +- 3 files changed, 1 insertion(+), 28 deletions(-) delete

[libvirt] [dbus PATCH 4/4] spec: fix D-Bus spelling and improve description

Signed-off-by: Pavel Hrdina --- libvirt-dbus.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt-dbus.spec.in b/libvirt-dbus.spec.in index f0e63b5..675f463 100644 --- a/libvirt-dbus.spec.in +++ b/libvirt-dbus.spec.in @@ -8,7 +8,7 @@

[libvirt] [dbus PATCH 3/4] spec: Require dbus and polkit

libvirt-dbus installs configuration files for these packages therefore it should depend on it. Signed-off-by: Pavel Hrdina --- libvirt-dbus.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libvirt-dbus.spec.in b/libvirt-dbus.spec.in index 4b8e752..f0e63b5 100644

Re: [libvirt] [PATCH 2/3] qemu: support passing pre-opened UNIX socket listen FD

On Mon, Mar 26, 2018 at 03:19:36PM +0200, Ján Tomko wrote: > On Wed, Mar 14, 2018 at 05:33:05PM +, Daniel P. Berrangé wrote: > > There is a race condition when spawning QEMU where libvirt has spawned > > QEMU but the monitor socket is not yet open. Libvirt has to repeatedly > > try to

Re: [libvirt] [PATCH 2/3] qemu: support passing pre-opened UNIX socket listen FD

On Wed, Mar 14, 2018 at 05:33:05PM +, Daniel P. Berrangé wrote: There is a race condition when spawning QEMU where libvirt has spawned QEMU but the monitor socket is not yet open. Libvirt has to repeatedly try to connect() to QEMU's monitor until eventually it succeeds, or times out. We use

Re: [libvirt] [PATCHv2 2/6] qemu: use query-cpus-fast in JSON monitor

On 03/26/2018 07:28 AM, Viktor Mihajlovski wrote: > On 26.03.2018 10:12, Viktor Mihajlovski wrote: >> On 23.03.2018 17:05, John Ferlan wrote: >> [...] diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 8b4efc8..4079fb3 100644 --- a/src/qemu/qemu_domain.c +++

Re: [libvirt] [PATCHv2 4/6] qemu: add architecture-specific CPU info handling

On 23.03.2018 17:08, John Ferlan wrote: [...] >> +static void >> +qemuMonitorJSONExtractCPUS390Info(virJSONValuePtr jsoncpu, >> + struct qemuMonitorQueryCpusEntry *cpu) >> +{ >> +const char *cpu_state = virJSONValueObjectGetString(jsoncpu, >> "cpu-state"); >>

Re: [libvirt] [PATCH 2/3] qemu: support passing pre-opened UNIX socket listen FD

On 03/14/2018 01:33 PM, Daniel P. Berrangé wrote: > There is a race condition when spawning QEMU where libvirt has spawned > QEMU but the monitor socket is not yet open. Libvirt has to repeatedly > try to connect() to QEMU's monitor until eventually it succeeds, or > times out. We use kill() to

Re: [libvirt] [PATCH 3/3] qemu: don't retry connect() if doing FD passing

On 03/14/2018 01:33 PM, Daniel P. Berrangé wrote: > Since libvirt called bind() and listen() on the UNIX socket, it is > guaranteed that connect() will immediately succeed, if QEMU is running > normally. It will only fail if QEMU has closed the monitor socket by > mistake or if QEMU has exited,

Re: [libvirt] [PATCH 1/3] qemu: probe for -chardev 'fd' parameter for FD passing

On 03/14/2018 01:33 PM, Daniel P. Berrangé wrote: > QEMU >= 2.12 will support passing of pre-opened file descriptors for > socket based character devices. > > should we include 2.12 pre-release git snapshot of capaibilities ? > > Signed-off-by: Daniel P. Berrangé >

Re: [libvirt] [PATCHv2 2/6] qemu: use query-cpus-fast in JSON monitor

On 26.03.2018 10:12, Viktor Mihajlovski wrote: > On 23.03.2018 17:05, John Ferlan wrote: > [...] >>> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c >>> index 8b4efc8..4079fb3 100644 >>> --- a/src/qemu/qemu_domain.c >>> +++ b/src/qemu/qemu_domain.c >>> @@ -8683,7 +8683,12 @@

Re: [libvirt] [PATCH sandbox] Fix argparser incompatibilities with newer python 3

On Fri, 2018-03-23 at 16:44 +, Daniel P. Berrangé wrote: > Python 3 changes such that if no subparser command is listed, it just > throws an error. To get back the old behavior we need to set the > 'required' attribute and a dest name. > > Since we treat 'debug' as a global attribute we need

Re: [libvirt] [PATCHv2 3/6] tests: add qemumonitorjson tests for query-cpus-fast

On 23.03.2018 17:07, John Ferlan wrote: > > > On 03/05/2018 06:44 AM, Viktor Mihajlovski wrote: >> Extended the json monitor test program with support for query-cpus-fast >> and added a sample file set for x86 data obtained using the it. >> >> Signed-off-by: Viktor Mihajlovski

Re: [libvirt] [PATCH sandbox] rpm: fix references to python 2 packages / files

On Fri, 2018-03-23 at 15:57 +, Daniel P. Berrangé wrote: > Since we switched to python 3, we should have deps on the python 3 based > packages, and look at the python 3 sitelib directory. > > Signed-off-by: Daniel P. Berrangé > --- > libvirt-sandbox.spec.in | 6 +++--- >

Re: [libvirt] [PATCH sandbox] Explicitly check for python3 in configure.ac

On Fri, 2018-03-23 at 15:57 +, Daniel P. Berrangé wrote: > A bare AM_PATH_PYTHON statement is satisfied by any version of python >= > 2.0.0, but we converted to Python 3, so should be explicit about it. > > Signed-off-by: Daniel P. Berrangé > --- > configure.ac | 2 +- >

[libvirt] [PATCH] docs: formatdomain: Clarify CPU feature policy option "require"

(Thanks: Jiri Denemark, for clarifying this on IRC.) Signed-off-by: Kashyap Chamarthy --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6fd2189cd..2410c92af 100644

Re: [libvirt] [PATCH 4/5] qemu: Handle multipath devices properly

On Mon, Mar 26, 2018 at 07:16:45 +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1557769 > > Problem with multipath devices is that there can be several other > devices 'hidden' behind them. For instance, /dev/dm-1 can > consist of /dev/sda, /dev/sdb and /dev/sdc.

Re: [libvirt] Compiling Libvirt 3.0.0 failed: cannot stat t...@kkcor.gmo

On Mon, Mar 26, 2018 at 01:10:30PM +0300, Mathieu Tarral wrote: > Hi Daniel, > > > This is over a year old now - if building & reporting errors against > > git, please only use current git master. > > The reason why i use this release is because i'm trying to reproduce a bug > that i have with

Re: [libvirt] Call to virDomainIsActive hangs forever

On Fri, Mar 23, 2018 at 01:24:46PM +0100, Erik Skultety wrote: > On Thu, Mar 22, 2018 at 06:10:49PM +0200, Mathieu Tarral wrote: > > Hi ! > > > > I'm submitting my messages on this mailing list to request a bit of > > help on a case that I have > > where a Python application makes a call to

Re: [libvirt] [PATCH 3/5] virfile: Introduce virFileMajMinToName

On 03/26/2018 11:58 AM, Peter Krempa wrote: > On Mon, Mar 26, 2018 at 07:16:44 +0200, Michal Privoznik wrote: >> This function can be used to translate MAJ:MIN device pair into >> /dev/blah name. >> >> Signed-off-by: Michal Privoznik >> --- >> src/libvirt_private.syms | 1 +

Re: [libvirt] Compiling Libvirt 3.0.0 failed: cannot stat t...@kkcor.gmo

Hi Daniel, > This is over a year old now - if building & reporting errors against > git, please only use current git master. The reason why i use this release is because i'm trying to reproduce a bug that i have with the Debian Stretch package, which is release 3.0.0:

Re: [libvirt] Compiling Libvirt 3.0.0 failed: cannot stat t...@kkcor.gmo

On Mon, Mar 26, 2018 at 12:56:13PM +0300, Mathieu Tarral wrote: > Hi, > > I tried to compile libvirt 3.0.0, from git, on a Debian Stretch. This is over a year old now - if building & reporting errors against git, please only use current git master. > It failed with these weird errors that i'm

Re: [libvirt] [PATCH 3/5] virfile: Introduce virFileMajMinToName

On Mon, Mar 26, 2018 at 07:16:44 +0200, Michal Privoznik wrote: > This function can be used to translate MAJ:MIN device pair into > /dev/blah name. > > Signed-off-by: Michal Privoznik > --- > src/libvirt_private.syms | 1 + > src/util/virfile.c | 53 >

[libvirt] Compiling Libvirt 3.0.0 failed: cannot stat t...@kkcor.gmo

Hi, I tried to compile libvirt 3.0.0, from git, on a Debian Stretch. It failed with these weird errors that i'm not able to fix by myself: rm -f ky.gmo && : -c --statistics -o ky.gmo ky.po rm -f lt.gmo && : -c --statistics -o lt.gmo lt.po mv: cannot stat 't...@kkcor.gmo': No such file or

Re: [libvirt] [PATCH sandbox] Python 3 renamed string.lowercase to string.ascii_lowercase

On Sun, Mar 25, 2018 at 11:32:04AM +0200, Ján Tomko wrote: > On Fri, Mar 23, 2018 at 04:44:51PM +, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > ACK, but the commit message is misleading. > > Python2 has ascii_lowercase as early as 2.2 and in

Re: [libvirt] [PATCH 2/5] utils: Introduce virFileGetMPathTargets

On Mon, Mar 26, 2018 at 07:16:43 +0200, Michal Privoznik wrote: > This helper fetches targets for multipath devices. > > Signed-off-by: Michal Privoznik > --- > src/libvirt_private.syms | 1 + > src/util/virfile.c | 90 >

Re: [libvirt] [PATCH 1/5] virlog: Don't log devmapper

On 03/26/2018 10:44 AM, Peter Krempa wrote: > On Mon, Mar 26, 2018 at 09:49:08 +0200, Peter Krempa wrote: >> On Mon, Mar 26, 2018 at 07:16:42 +0200, Michal Privoznik wrote: >>> Unless overridden, libdevmapper logs all messages to stderr. >>> Therefore if something goes wrong in

Re: [libvirt] [PATCH 1/5] virlog: Don't log devmapper

On Mon, Mar 26, 2018 at 10:16:54 +0200, Michal Privoznik wrote: > On 03/26/2018 09:49 AM, Peter Krempa wrote: > > On Mon, Mar 26, 2018 at 07:16:42 +0200, Michal Privoznik wrote: > >> Unless overridden, libdevmapper logs all messages to stderr. > >> Therefore if something goes wrong in

Re: [libvirt] [PATCH 1/5] virlog: Don't log devmapper

On Mon, Mar 26, 2018 at 09:49:08 +0200, Peter Krempa wrote: > On Mon, Mar 26, 2018 at 07:16:42 +0200, Michal Privoznik wrote: > > Unless overridden, libdevmapper logs all messages to stderr. > > Therefore if something goes wrong in storage_backend_mpath.c or > > parthelper.c we don't honour user

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On Sun, Mar 25, 2018 at 01:55:07AM +0530, Sukrit Bhatnagar wrote: > Hi, > > I am interested in implementing the GCC cleanup attribute for automatic > resource freeing as part of GSoC'18. I have shared a proposal for the same. > > This mail is to discuss the code design for implementing it. > >

Re: [libvirt] [PATCH 1/5] virlog: Don't log devmapper

On 03/26/2018 09:49 AM, Peter Krempa wrote: > On Mon, Mar 26, 2018 at 07:16:42 +0200, Michal Privoznik wrote: >> Unless overridden, libdevmapper logs all messages to stderr. >> Therefore if something goes wrong in storage_backend_mpath.c or >> parthelper.c we don't honour user set logging targets.

Re: [libvirt] [PATCHv2 1/6] qemu: add capability detection for query-cpus-fast

On 23.03.2018 17:03, John Ferlan wrote: > > > On 03/05/2018 06:44 AM, Viktor Mihajlovski wrote: >> Detect whether QEMU supports the QMP query-cpus-fast API >> and set QEMU_CAPS_QUERY_CPUS_FAST in this case. >> >> Signed-off-by: Viktor Mihajlovski >> Reviewed-by:

Re: [libvirt] [PATCHv2 2/6] qemu: use query-cpus-fast in JSON monitor

On 23.03.2018 17:05, John Ferlan wrote: [...] >> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c >> index 8b4efc8..4079fb3 100644 >> --- a/src/qemu/qemu_domain.c >> +++ b/src/qemu/qemu_domain.c >> @@ -8683,7 +8683,12 @@ qemuDomainRefreshVcpuInfo(virQEMUDriverPtr driver, >> if

Re: [libvirt] [dbus PATCH v2 0/6] Use API calls supporting flags

On Fri, Mar 23, 2018 at 05:57:58PM +0100, Katerina Koukiou wrote: > * Use API calls with flags parameter when possible > * Since libvirt-dbus API doesn't follow strictly the naming > of libvirt API there should be documentation regarding which > libvirt API is used for each libvirt-dbus API. >

Re: [libvirt] [dbus PATCH v2 5/6] virtDBusDomainDestroy: Use virDomainDestroyFlags instead of virDomainDestroy

On Fri, Mar 23, 2018 at 05:58:03PM +0100, Katerina Koukiou wrote: > We need to catch Exceptions when testing this API call, since > virDomainDestroyFlags > will be supported in test-driver in 4.2.0 libvirt release. > > Better version checks for unsupported API calls need to be done in all tests,

Re: [libvirt] [dbus PATCH v2 1/6] virtDBusDomainGetVcpus: Should be implemented as method and not as property

On Fri, Mar 23, 2018 at 05:57:59PM +0100, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 - > src/domain.c| 51 > ++--- > test/test_domain.py | 3 ++- >

Re: [libvirt] [PATCH 1/5] virlog: Don't log devmapper

On Mon, Mar 26, 2018 at 07:16:42 +0200, Michal Privoznik wrote: > Unless overridden, libdevmapper logs all messages to stderr. > Therefore if something goes wrong in storage_backend_mpath.c or > parthelper.c we don't honour user set logging targets. > > Signed-off-by: Michal Privoznik

Re: [libvirt] [dbus PATCH v2 6/6] Use Documentation Annotations in D-Bus Interface XML

On Fri, Mar 23, 2018 at 05:58:04PM +0100, Katerina Koukiou wrote: > Since we don't follow the exact naming of libvirt API for libvirt-dbus, > documentation should clarify which API call is used internally each time. > > Signed-off-by: Katerina Koukiou > --- >

Re: [libvirt] [tck PATCH] require libguestfs-tool package

On Sun, Mar 25, 2018 at 06:47:14PM -0400, Laine Stump wrote: > The nwfilter tests use virt-builder to download and configure a guest > appliance, but we don't require the libguestfs-tools package. Up until > now it's just happened that it was always already installed on the > test systems, so it