[libvirt] virNetSocketNewListenTCP tries just one address

2018-03-27 Thread Olaf Hering
To rescue this bug from the noise in a subthread: If a hostname resolves to more than one address and the host currently configured itself for just IPv4, doing a bind() to some IPv6 address will fail. As a result an error is returned instead of continuing with the next item in 'runp'. > Mär 20 09

Re: [libvirt] virNetSocketNewListenTCP tries just one address

2018-03-27 Thread Daniel P . Berrangé
On Tue, Mar 27, 2018 at 09:57:13AM +0200, Olaf Hering wrote: > To rescue this bug from the noise in a subthread: > > If a hostname resolves to more than one address and the host currently > configured itself for just IPv4, doing a bind() to some IPv6 address > will fail. As a result an error is re

[libvirt] [PATCH 3/4] qemu: hotplug: Introduce hot unplug for mediated devices

2018-03-27 Thread Erik Skultety
Mediated devices support hot-{plug,unplug} since their introduction in kernel 4.10, however this feature has been missing in libvirt since commit ec783d7c introduced a hostdev type for mdevs. Signed-off-by: Erik Skultety --- src/qemu/qemu_hotplug.c | 47 ++

[libvirt] [PATCH 1/4] qemu: hotplug: Provide a string of a subsystem type instead of an int

2018-03-27 Thread Erik Skultety
If one tries to detach a non-existent device, the error they get is: "Unexpected hostdev type ". Let's use ToString conversion, since the XML parser would have complained already if the type to be unplugged was unknown to libvirt. Signed-off-by: Erik Skultety --- src/qemu/qemu_hotplug.c | 3 ++-

[libvirt] [PATCH 0/4] Introduce support for mediated devices hot plug

2018-03-27 Thread Erik Skultety
Libvirt shouldn't forbid the operation as unsupported. In fact, from VFIO point of view, mdevs have supported hot plug since the beginning. Then it's up to the 3rd party vendor driver whether it can cope with this feature reliably or not. Erik Skultety (4): qemu: hotplug: Provide a string of a s

[libvirt] [PATCH 4/4] news: Update release news with mediated devices hot {plug, unplug}

2018-03-27 Thread Erik Skultety
Signed-off-by: Erik Skultety --- docs/news.xml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 108889574..6075cc9ca 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -92,6 +92,20 @@ previously started domains to 256, or restart th

[libvirt] [PATCH 2/4] qemu: hotplug: Introduce hot plug support for mediated devices

2018-03-27 Thread Erik Skultety
Mediated devices support hot-{plug,unplug} since their introduction in kernel 4.10, however this feature has been missing in libvirt since commit ec783d7c introduced a hostdev type for mdevs. Signed-off-by: Erik Skultety --- src/qemu/qemu_hotplug.c | 86 ++

Re: [libvirt] virNetSocketNewListenTCP tries just one address

2018-03-27 Thread Ján Tomko
On Tue, Mar 27, 2018 at 09:57:13AM +0200, Olaf Hering wrote: To rescue this bug from the noise in a subthread: If a hostname resolves to more than one address and the host currently configured itself for just IPv4, doing a bind() to some IPv6 address will fail. As a result an error is returned i

Re: [libvirt] [PATCH 1/4] qemu: hotplug: Provide a string of a subsystem type instead of an int

2018-03-27 Thread Peter Krempa
On Tue, Mar 27, 2018 at 10:57:13 +0200, Erik Skultety wrote: > If one tries to detach a non-existent device, the error they get is: > "Unexpected hostdev type ". Let's use ToString conversion, since > the XML parser would have complained already if the type to be unplugged > was unknown to libvirt.

Re: [libvirt] virNetSocketNewListenTCP tries just one address

2018-03-27 Thread Olaf Hering
On Tue, Mar 27, Ján Tomko wrote: > Why does your hostname resolve to an unavailable address? How can the DNS server possibly know how a host has configured itself? In this case I had BOOTPROTO='dhcp4' instead of 'dhcp' in /etc/sysconfig/network/ifcfg-br0 due to all the migration issues I'm seein

Re: [libvirt] [PATCH 1/4] qemu: hotplug: Provide a string of a subsystem type instead of an int

2018-03-27 Thread Daniel P . Berrangé
On Tue, Mar 27, 2018 at 11:17:51AM +0200, Peter Krempa wrote: > On Tue, Mar 27, 2018 at 10:57:13 +0200, Erik Skultety wrote: > > If one tries to detach a non-existent device, the error they get is: > > "Unexpected hostdev type ". Let's use ToString conversion, since > > the XML parser would have co

Re: [libvirt] [PATCH 2/4] qemu: hotplug: Introduce hot plug support for mediated devices

2018-03-27 Thread Peter Krempa
On Tue, Mar 27, 2018 at 10:57:14 +0200, Erik Skultety wrote: > Mediated devices support hot-{plug,unplug} since their introduction in > kernel 4.10, however this feature has been missing in libvirt since > commit ec783d7c introduced a hostdev type for mdevs. I think the feature was missing since d

Re: [libvirt] [PATCH 3/4] qemu: hotplug: Introduce hot unplug for mediated devices

2018-03-27 Thread Peter Krempa
On Tue, Mar 27, 2018 at 10:57:15 +0200, Erik Skultety wrote: > Mediated devices support hot-{plug,unplug} since their introduction in > kernel 4.10, however this feature has been missing in libvirt since > commit ec783d7c introduced a hostdev type for mdevs. > > Signed-off-by: Erik Skultety > ---

Re: [libvirt] [PATCH 4/4] news: Update release news with mediated devices hot {plug, unplug}

2018-03-27 Thread Peter Krempa
On Tue, Mar 27, 2018 at 10:57:16 +0200, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > docs/news.xml | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index 108889574..6075cc9ca 100644 > --- a/docs/news.xml > +++ b/docs/news.xml

Re: [libvirt] [PATCH 3/4] qemu: hotplug: Introduce hot unplug for mediated devices

2018-03-27 Thread Peter Krempa
On Tue, Mar 27, 2018 at 10:57:15 +0200, Erik Skultety wrote: > Mediated devices support hot-{plug,unplug} since their introduction in > kernel 4.10, however this feature has been missing in libvirt since > commit ec783d7c introduced a hostdev type for mdevs. > > Signed-off-by: Erik Skultety > ---

[libvirt] [dbus PATCH 2/3] Implement LookupByName method for Connect Interface

2018-03-27 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + test/test_connect.py | 1 + 3 files changed, 36 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 53f

[libvirt] [dbus PATCH 3/3] Implement LookupByUUID method for Connect Interface

2018-03-27 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + test/test_connect.py | 1 + 3 files changed, 36 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index c99

[libvirt] [dbus PATCH 1/3] Implement LookupByID method for Connect Interface.

2018-03-27 Thread Katerina Koukiou
tests: Moved `domain` method from test_domain.py to libvirttest.py so that it can be reused from test_connect.py. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + src/domain.c | 1 + te

[libvirt] [dbus PATCH 0/3] Implement LookupBy* methods for libvirt

2018-03-27 Thread Katerina Koukiou
Katerina Koukiou (3): Implement LookupByID method for Connect Interface. Implement LookupByName method for Connect Interface Implement LookupByUUID method for Connect Interface data/org.libvirt.Connect.xml | 18 + src/connect.c| 87 +++

Re: [libvirt] [dbus PATCH 0/3] Implement LookupBy* methods for libvirt

2018-03-27 Thread Pavel Hrdina
On Tue, Mar 27, 2018 at 11:59:07AM +0200, Katerina Koukiou wrote: > Katerina Koukiou (3): > Implement LookupByID method for Connect Interface. > Implement LookupByName method for Connect Interface > Implement LookupByUUID method for Connect Interface All the methods should contain Domain in

Re: [libvirt] [PATCH 01/12] conf: introduce domain XML element for iothread

2018-03-27 Thread Sergio Lopez
Hi, I'd like to resurrect this thread: https://www.redhat.com/archives/libvir-list/2017-February/msg01084.html Recent benchmarks have demonstrated that using large values for poll-max-ns significantly decreases the perceived latency in the Guest, at the expense of the iothread using more CPU:

[libvirt] Entering freeze for libvirt-4.2.0

2018-03-27 Thread Daniel Veillard
As planned I just tagged the RC1 in git and pushed the signed tarball and rpms at the usual place: ftp://libvirt.org/libvirt/ This seems fine with my minimal testing, and CI at https://ci.centos.org/view/libvirt/ looks pretty good (except libvirt-master-build, weird ...) so this should no

Re: [libvirt] Call to virDomainIsActive hangs forever

2018-03-27 Thread Mathieu Tarral
I have installed the following debug symbols: - libvirt-daemon-dbgsym_3.0.0-4+deb9u3_amd64.deb - libvirt-daemon-system-dbgsym_3.0.0-4+deb9u3_amd64.deb - libvirt-clients-dbgsym_3.0.0-4+deb9u3_amd64.deb - libvirt0-dbgsym_3.0.0-4+deb9u3_amd64.deb - python3-libvirt-dbgsym_3.0.0-2_amd64.deb And i was

Re: [libvirt] Call to virDomainIsActive hangs forever

2018-03-27 Thread Daniel P . Berrangé
On Tue, Mar 27, 2018 at 03:30:14PM +0300, Mathieu Tarral wrote: > I have installed the following debug symbols: > > - libvirt-daemon-dbgsym_3.0.0-4+deb9u3_amd64.deb > - libvirt-daemon-system-dbgsym_3.0.0-4+deb9u3_amd64.deb > - libvirt-clients-dbgsym_3.0.0-4+deb9u3_amd64.deb > - libvirt0-dbgsym_3.0

[libvirt] Google summer of code proposal review request

2018-03-27 Thread Asmaa Osama
Hi everyone, I've written and shared my proposal for GSoC and I'd be grateful for any advice or comments. It's only a few hours before deadline, but any help is welcomed -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] libvirt api documentation not reachable

2018-03-27 Thread syam Mohan
Hi, It seems this page is not accessible now. It was fine till yesterday. Can some one please fix it? Thanks!! -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] libvirt api documentation not reachable

2018-03-27 Thread Daniel P . Berrangé
On Tue, Mar 27, 2018 at 06:06:53PM +0530, syam Mohan wrote: > Hi, > > It seems this page is not accessible now. It was fine till yesterday. > > Can some one please fix it? What page are you actually referring to ? The API docs are at https://libvirt.org/html/index.html and still working AFAIC

Re: [libvirt] [jenkins-ci PATCH] guests: Enable ccache

2018-03-27 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 10:41:55AM +0100, Andrea Bolognani wrote: > We install ccache on all guests where it's available, but > Fedora is the only one actually using it at the moment, > because it enables it automatically. > > Tweak the user's profile so that compilation will use ccache > if it's

Re: [libvirt] [jenkins-ci PATCH] guests: Enable ccache

2018-03-27 Thread Andrea Bolognani
On Tue, 2018-03-27 at 13:58 +0100, Daniel P. Berrangé wrote: > On Fri, Mar 23, 2018 at 10:41:55AM +0100, Andrea Bolognani wrote: > > We install ccache on all guests where it's available, but > > Fedora is the only one actually using it at the moment, > > because it enables it automatically. > > >

Re: [libvirt] Call to virDomainIsActive hangs forever

2018-03-27 Thread Mathieu Tarral
> Are you sure this isa different thread ? It looks identical to the first > stack trace you give above. Yes, the first one is calling libvirtmod.virDomainGetState and the second one libvirtmod.virDomainIsActive. > Interesting. This is an identical stack trace - so we have 2 python > threads bot

Re: [libvirt] [dbus PATCH 1/3] Implement LookupByID method for Connect Interface.

2018-03-27 Thread Ján Tomko
On Tue, Mar 27, 2018 at 11:59:08AM +0200, Katerina Koukiou wrote: tests: Moved `domain` method from test_domain.py to libvirttest.py so that it can be reused from test_connect.py. See https://www.redhat.com/archives/libvir-list/2018-March/msg01375.html Jan Signed-off-by: Katerina Koukiou -

Re: [libvirt] Call to virDomainIsActive hangs forever

2018-03-27 Thread Daniel P . Berrangé
On Tue, Mar 27, 2018 at 04:04:33PM +0300, Mathieu Tarral wrote: > > Are you sure this isa different thread ? It looks identical to the first > > stack trace you give above. > > Yes, the first one is calling libvirtmod.virDomainGetState > and the second one libvirtmod.virDomainIsActive. > > > Int

[libvirt] [dbus PATCH v2 3/4] Implement DomainLookupByName method for Connect Interface

2018-03-27 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + test/test_connect.py | 1 + 3 files changed, 36 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 7c3

[libvirt] [dbus PATCH v2 2/4] Implement DomainLookupByID method for Connect Interface.

2018-03-27 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + test/test_connect.py | 12 3 files changed, 47 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xm

[libvirt] [dbus PATCH v2 0/4] Implement LookupBy* methods for Connect

2018-03-27 Thread Katerina Koukiou
Changes from v1: * Added to method names Domain prefix. * Seperated move of domain method in seperate commit. Katerina Koukiou (4): tests: Moved `domain` method from test_domain.py to libvirttest.py Implement DomainLookupByID method for Connect Interface. Implement DomainLookupByName metho

[libvirt] [dbus PATCH v2 1/4] tests: Moved `domain` method from test_domain.py to libvirttest.py

2018-03-27 Thread Katerina Koukiou
>From there it can be reused from test_connect.py. Signed-off-by: Katerina Koukiou --- test/libvirttest.py | 5 + test/test_domain.py | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/test/libvirttest.py b/test/libvirttest.py index 23fe536..c4dc96f 100644 --- a/test/l

[libvirt] [dbus PATCH v2 4/4] Implement DomainLookupByUUID method for Connect Interface

2018-03-27 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + test/test_connect.py | 1 + 3 files changed, 36 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index fd6

Re: [libvirt] Compiling Libvirt 3.0.0 failed: cannot stat t...@kkcor.gmo

2018-03-27 Thread Mathieu Tarral
I'm now compiling libvirt from git master (5bb07527c11a6123e044a5dfc48bdeccee144994), and it failed with the same errors: rm -f ar.gmo && : -c --statistics -o ar.gmo ar.po [0/1878] rm -f as.gmo && : -c --statistics -o as.gmo as.po rm -f ast.gmo && : -c --statistics -o ast.gmo ast.po mv:

Re: [libvirt] [PATCH 1/4] qemu: hotplug: Provide a string of a subsystem type instead of an int

2018-03-27 Thread Erik Skultety
On Tue, Mar 27, 2018 at 10:24:54AM +0100, Daniel P. Berrangé wrote: > On Tue, Mar 27, 2018 at 11:17:51AM +0200, Peter Krempa wrote: > > On Tue, Mar 27, 2018 at 10:57:13 +0200, Erik Skultety wrote: > > > If one tries to detach a non-existent device, the error they get is: > > > "Unexpected hostdev t

Re: [libvirt] [PATCH 1/4] qemu: hotplug: Provide a string of a subsystem type instead of an int

2018-03-27 Thread Daniel P . Berrangé
On Tue, Mar 27, 2018 at 03:42:08PM +0200, Erik Skultety wrote: > On Tue, Mar 27, 2018 at 10:24:54AM +0100, Daniel P. Berrangé wrote: > > On Tue, Mar 27, 2018 at 11:17:51AM +0200, Peter Krempa wrote: > > > On Tue, Mar 27, 2018 at 10:57:13 +0200, Erik Skultety wrote: > > > > If one tries to detach a

[libvirt] [jenkins-ci PATCH 2/2] guests: Install and enable chrony

2018-03-27 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- guests/site.yml | 1 + guests/tasks/services.yml | 15 +++ guests/vars/mappings.yml | 3 +++ guests/vars/projects/base.yml | 1 + 4 files changed, 20 insertions(+) create mode 100644 guests/tasks/services.yml diff --git a

[libvirt] [jenkins-ci PATCH 0/2] guests: Install and enable chrony

2018-03-27 Thread Andrea Bolognani
Time travel is no longer allowed on these premises. Andrea Bolognani (2): guests: Move environment configuration steps together guests: Install and enable chrony guests/site.yml | 7 --- guests/tasks/services.yml | 15 +++ guests/vars/mappings.yml | 3

[libvirt] [jenkins-ci PATCH 1/2] guests: Move environment configuration steps together

2018-03-27 Thread Andrea Bolognani
We're going to add more steps that require base packages to be installed soon, so let's group all configuration steps except the very basic one together after base package installation has been performed. Signed-off-by: Andrea Bolognani --- guests/site.yml | 6 +++--- 1 file changed, 3 insertion

Re: [libvirt] [dbus PATCH v2 0/4] Implement LookupBy* methods for Connect

2018-03-27 Thread Ján Tomko
On Tue, Mar 27, 2018 at 03:29:55PM +0200, Katerina Koukiou wrote: Changes from v1: * Added to method names Domain prefix. * Seperated move of domain method in seperate commit. Katerina Koukiou (4): tests: Moved `domain` method from test_domain.py to libvirttest.py Implement DomainLookupByID me

Re: [libvirt] [dbus PATCH v2 2/4] Implement DomainLookupByID method for Connect Interface.

2018-03-27 Thread Pavel Hrdina
On Tue, Mar 27, 2018 at 03:29:57PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 6 ++ > src/connect.c| 29 + > test/test_connect.py | 12 > 3 files changed, 47 insertio

Re: [libvirt] [dbus PATCH v2 1/4] tests: Moved `domain` method from test_domain.py to libvirttest.py

2018-03-27 Thread Pavel Hrdina
On Tue, Mar 27, 2018 at 03:29:56PM +0200, Katerina Koukiou wrote: > >From there it can be reused from test_connect.py. I'll remove the ">" before pushing :). Pavel signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo

Re: [libvirt] [dbus PATCH v2 2/4] Implement DomainLookupByID method for Connect Interface.

2018-03-27 Thread Katerina Koukiou
On Tue, 2018-03-27 at 16:14 +0200, Pavel Hrdina wrote: > On Tue, Mar 27, 2018 at 03:29:57PM +0200, Katerina Koukiou wrote: > > Signed-off-by: Katerina Koukiou > > --- > > data/org.libvirt.Connect.xml | 6 ++ > > src/connect.c| 29 + > > test/test_c

Re: [libvirt] [PATCH v3 1/9] qemu: provide support to query the SEV capability

2018-03-27 Thread Brijesh Singh
On 03/26/2018 09:32 AM, Andrea Bolognani wrote: On Mon, 2018-03-26 at 08:52 -0500, Brijesh Singh wrote: I tried applying just this patch, but kept getting: 29) caps_2.12.0(x86_64) ... libvirt: QEMU Driver error : internal error: query-cpu-definitions reply data was not an array a small bit o

Re: [libvirt] [dbus PATCH v2 1/4] tests: Moved `domain` method from test_domain.py to libvirttest.py

2018-03-27 Thread Katerina Koukiou
On Tue, 2018-03-27 at 16:20 +0200, Pavel Hrdina wrote: > On Tue, Mar 27, 2018 at 03:29:56PM +0200, Katerina Koukiou wrote: > > > From there it can be reused from test_connect.py. > > I'll remove the ">" before pushing :). ACK. > > Pavel Thanks, Katerina -- libvir-list mailing list libvir-list

Re: [libvirt] Entering freeze for libvirt-4.2.0

2018-03-27 Thread Andrea Bolognani
On Tue, 2018-03-27 at 14:15 +0200, Daniel Veillard wrote: > This seems fine with my minimal testing, and CI at > https://ci.centos.org/view/libvirt/ looks pretty good (except > libvirt-master-build, weird ...) There are more errors now, but all of them seem to be related to communications issues

Re: [libvirt] [PATCH v3 1/9] qemu: provide support to query the SEV capability

2018-03-27 Thread Andrea Bolognani
On Tue, 2018-03-27 at 09:26 -0500, Brijesh Singh wrote: > > You're going to have to either fetch capabilities from your own > > QEMU 2.12 binary or hack it up by adding the return data in the > > right spot and call tests/qemucapsfixreplies to re-align the ids. > > Right, running the tests/qemucap

Re: [libvirt] [dbus PATCH v2 1/4] tests: Moved `domain` method from test_domain.py to libvirttest.py

2018-03-27 Thread Andrea Bolognani
On Tue, 2018-03-27 at 16:20 +0200, Pavel Hrdina wrote: > On Tue, Mar 27, 2018 at 03:29:56PM +0200, Katerina Koukiou wrote: > > >From there it can be reused from test_connect.py. > > I'll remove the ">" before pushing :). The >From is clearly an artifact of sending patches over email; I fully expe

[libvirt] [PATCH v4 0/9] x86: Secure Encrypted Virtualization (AMD)

2018-03-27 Thread Brijesh Singh
This patch series provides support for launching an encrypted guest using AMD's new Secure Encrypted Virtualization (SEV) feature. SEV is an extension to the AMD-V architecture which supports running multiple VMs under the control of a hypervisor. When enabled, SEV feature allows the memory conte

[libvirt] [PATCH v4 1/9] qemu: provide support to query the SEV capability

2018-03-27 Thread Brijesh Singh
QEMU version >= 2.12 provides support for launching an encrypted VMs on AMD x86 platform using Secure Encrypted Virtualization (SEV) feature. This patch adds support to query the SEV capability from the qemu. Reviewed-by: "Daniel P. Berrangé" Signed-off-by: Brijesh Singh --- src/conf/domain_cap

[libvirt] [PATCH v4 4/9] qemu: add support to launch SEV guest

2018-03-27 Thread Brijesh Singh
QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted VMs on AMD platform using SEV feature. The various inputs required to launch SEV guest is provided through the tag. A typical SEV guest launch command line looks like this: # $QEMU ...\ -object sev-guest,id=sev0,cbitpos=

[libvirt] [PATCH v4 5/9] libvirt: add new public API to get launch security info

2018-03-27 Thread Brijesh Singh
The API can be used outside the libvirt to get the launch security information. When SEV is enabled, the API can be used to get the measurement of the launch process. Signed-off-by: Brijesh Singh --- include/libvirt/libvirt-domain.h | 17 ++ src/driver-hypervisor.h | 7

[libvirt] [PATCH v4 3/9] conf: introduce launch-security element in domain

2018-03-27 Thread Brijesh Singh
The launch-security element can be used to define the security model to use when launching a domain. Currently we support 'sev'. When 'sev' is used, the VM will be launched with AMD SEV feature enabled. SEV feature supports running encrypted VM under the control of KVM. Encrypted VMs have their pa

[libvirt] [PATCH v4 2/9] qemu: introduce SEV feature in hypervisor capabilities

2018-03-27 Thread Brijesh Singh
Extend hypervisor capabilities to include sev feature. When available, hypervisor supports launching an encrypted VM on AMD platform. The sev feature tag provides additional details like platform diffie-hellman key and certificate chain which can be used by the guest owner to establish a cryptograp

[libvirt] [PATCH v4 6/9] remote: implement the remote protocol for launch security

2018-03-27 Thread Brijesh Singh
Add remote support for launch security info. Signed-off-by: Brijesh Singh --- src/remote/remote_daemon_dispatch.c | 47 + src/remote/remote_driver.c | 42 - src/remote/remote_protocol.x| 20 +++- src

[libvirt] [PATCH v4 8/9] virsh: implement new command for launch security

2018-03-27 Thread Brijesh Singh
Add new 'launch-security' command, the command can be used to get or set the launch security information when booting encrypted VMs. Signed-off-by: Brijesh Singh --- tools/virsh-domain.c | 84 1 file changed, 84 insertions(+) diff --git a/too

[libvirt] [PATCH v4 9/9] tests: extend tests to include sev specific tag parsing

2018-03-27 Thread Brijesh Singh
From: Xiaogang Chen Update qemuxml2xmltest, genericxml2xmltest and qemuxml2argvtest to include sev specific tag, a typical SEV specific tag looks like + QEMUGuest1 + c7a5fdbd-edaf-9455-926a-d65c16db1809 + 219100 + 219100 + 1 + +hvm + + + + destroy + restart + destroy + +

Re: [libvirt] [jenkins-ci PATCH 0/2] guests: Install and enable chrony

2018-03-27 Thread Pavel Hrdina
On Tue, Mar 27, 2018 at 03:55:03PM +0200, Andrea Bolognani wrote: > Time travel is no longer allowed on these premises. > > Andrea Bolognani (2): > guests: Move environment configuration steps together > guests: Install and enable chrony Reviewed-by: Pavel Hrdina signature.asc Description:

[libvirt] [PATCH v4 7/9] qemu_driver: add support to launch security info

2018-03-27 Thread Brijesh Singh
This patch implement the internal driver API for launch event into qemu driver. When SEV is enabled, execute 'query-sev-launch-measurement' to get the measurement of memory encrypted through launch sequence. Signed-off-by: Brijesh Singh --- src/qemu/qemu_driver.c | 66 +

[libvirt] [jenkins-ci PATCH] Revert "local"

2018-03-27 Thread Andrea Bolognani
This reverts commit c190e17fb8f689a0591dedded33d10cecafe3e20. As the original commit message so eloquently explains, the diff contains the tweaks I need for my local setup and it was, of course, never supposed to be pushed :/ Signed-off-by: Andrea Bolognani --- Pushed under the -ETOOEMBARRASSING

[libvirt] [dbus PATCH] domain: remove G_GNUC_UNUSED for used attributes

2018-03-27 Thread Ján Tomko
A few functions use the G_GNUC_UNUSED marker for objectPath, even though it's passed to virtDBusDomainGetVirDomain later. Signed-off-by: Ján Tomko --- Also passes the build with clang 5.0.1, once that lock issue is fixed: connect.c:59:29: error: unused variable 'lock' [-Werror,-Wunused-variable]

[libvirt] [dbus PATCH 0/2] misc fixes

2018-03-27 Thread Pavel Hrdina
Pavel Hrdina (2): Initialize struct using 0 instead of NULL util: Introduce virtDBusUtilAutoLock src/connect.c | 6 +++--- src/domain.c | 4 ++-- src/gdbus.c | 4 ++-- src/main.c| 2 +- src/util.h| 2 ++ 5 files changed, 10 insertions(+), 8 deletions(-) -- 2.14.3 -- libvir-list

[libvirt] [dbus PATCH 2/2] util: Introduce virtDBusUtilAutoLock

2018-03-27 Thread Pavel Hrdina
clang 6.0.0 complains about unused variable if g_autoptr is used to automatically unlock mutex. Signed-off-by: Pavel Hrdina --- src/connect.c | 2 +- src/util.h| 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/connect.c b/src/connect.c index c6b85ce..2350736 100644 --

[libvirt] [dbus PATCH 1/2] Initialize struct using 0 instead of NULL

2018-03-27 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/connect.c | 4 ++-- src/domain.c | 4 ++-- src/gdbus.c | 4 ++-- src/main.c| 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/connect.c b/src/connect.c index 56ead8d..c6b85ce 100644 --- a/src/connect.c +++ b/src/connect.c @@ -281,

Re: [libvirt] [dbus PATCH 1/2] Initialize struct using 0 instead of NULL

2018-03-27 Thread Ján Tomko
On Tue, Mar 27, 2018 at 06:44:41PM +0200, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- src/connect.c | 4 ++-- src/domain.c | 4 ++-- src/gdbus.c | 4 ++-- src/main.c| 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) ACK Jano signature.asc Description: Digital signature --

Re: [libvirt] [dbus PATCH 2/2] util: Introduce virtDBusUtilAutoLock

2018-03-27 Thread Ján Tomko
On Tue, Mar 27, 2018 at 06:44:42PM +0200, Pavel Hrdina wrote: clang 6.0.0 complains about unused variable if g_autoptr is used to s/clang 6.0.0/Clang/ Also happens with 5.0.1 and the man page uses the Clang spelling, so you're free to capitalize it at the beginning of the sentence. automatic

Re: [libvirt] virNetSocketNewListenTCP tries just one address

2018-03-27 Thread Ján Tomko
On Tue, Mar 27, 2018 at 11:18:10AM +0200, Olaf Hering wrote: On Tue, Mar 27, Ján Tomko wrote: Why does your hostname resolve to an unavailable address? How can the DNS server possibly know how a host has configured itself? It cannot, but the admin of the network should be able to control b

Re: [libvirt] [jenkins-ci PATCH] Revert "local"

2018-03-27 Thread Peter Krempa
On Tue, Mar 27, 2018 at 18:19:43 +0200, Andrea Bolognani wrote: > This reverts commit c190e17fb8f689a0591dedded33d10cecafe3e20. > > As the original commit message so eloquently explains, the > diff contains the tweaks I need for my local setup and it was, > of course, never supposed to be pushed :

Re: [libvirt] [PATCH v2 2/3] qemu: Handle device mapper targets properly

2018-03-27 Thread Peter Krempa
On Mon, Mar 26, 2018 at 17:22:01 +0200, Michal Privoznik wrote: > On 03/26/2018 05:17 PM, Peter Krempa wrote: > > On Mon, Mar 26, 2018 at 16:43:02 +0200, Michal Privoznik wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1557769 > >> > >> Problem with device mapper targets is that there can b

[libvirt] [PATCH 1/2] libxl: drop support for Xen < 4.6

2018-03-27 Thread Jim Fehlig
Currently the libxl driver claims support for Xen >= 4.4, but Xen 4.4 and 4.5 are no longer supported upstream. Let's increase the minimum supported version to 4.6. Signed-off-by: Jim Fehlig --- docs/drvxen.html.in | 11 +-- m4/virt-driver-libxl.m4 | 23 ++- 2 fil

[libvirt] [PATCH 0/2] libxl: drop support for Xen 4.4 and 4.5

2018-03-27 Thread Jim Fehlig
Bla bla bla... Jim Fehlig (2): libxl: drop support for Xen < 4.6 news: announce dropping support for Xen 4.4 and 4.5 docs/drvxen.html.in | 11 +-- docs/news.xml | 9 + m4/virt-driver-libxl.m4 | 23 ++- 3 files changed, 16 insertions(+), 27 d

[libvirt] [PATCH 2/2] news: announce dropping support for Xen 4.4 and 4.5

2018-03-27 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 108889574..a2e0af100 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -56,6 +56,15 @@ on S390. + + + Xe

Re: [libvirt] [PATCH v6 2/9] libxl: pass driver config to libxlMakeDomBuildInfo

2018-03-27 Thread Jim Fehlig
On 03/22/2018 07:59 PM, Jim Fehlig wrote: On 03/22/2018 04:59 PM, Marek Marczykowski-Górecki wrote: On Thu, Mar 22, 2018 at 04:48:48PM -0600, Jim Fehlig wrote: On 03/22/2018 04:44 PM, Jim Fehlig wrote: On 03/21/2018 10:32 AM, Marek Marczykowski-Górecki wrote: Preparation for global nestedhvm

Re: [libvirt] [PATCH v6 2/9] libxl: pass driver config to libxlMakeDomBuildInfo

2018-03-27 Thread Marek Marczykowski-Górecki
On Tue, Mar 27, 2018 at 04:34:27PM -0600, Jim Fehlig wrote: > Did you have an opportunity to look at this problem on Xen 4.5? Actually I'm on it right now. Getting Xen 4.5 built using modern gcc is kind of a challenge, thanks to -Werror... > Alternatively we could increase the minimum supported X

Re: [libvirt] [PATCH v6 2/9] libxl: pass driver config to libxlMakeDomBuildInfo

2018-03-27 Thread Marek Marczykowski-Górecki
On Wed, Mar 28, 2018 at 12:38:22AM +0200, Marek Marczykowski-Górecki wrote: > On Tue, Mar 27, 2018 at 04:34:27PM -0600, Jim Fehlig wrote: > > Did you have an opportunity to look at this problem on Xen 4.5? > > Actually I'm on it right now. Getting Xen 4.5 built using modern gcc is > kind of a chal

[libvirt] [PATCH v6.1 2/9] libxl: pass driver config to libxlMakeDomBuildInfo

2018-03-27 Thread Marek Marczykowski-Górecki
Preparation for global nestedhvm configuration - libxlMakeDomBuildInfo needs access to libxlDriverConfig. No functional change. Adjusting tests require slightly more mockup functions, because of libxlDriverConfigNew() call. Signed-off-by: Marek Marczykowski-Górecki --- Changes since v6: - tests

Re: [libvirt] [PATCH] virsh: add missing help info of --source to domifaddr

2018-03-27 Thread Chen Hanxiao
At 2018-03-16 10:03:15, "Chen Hanxiao" wrote: >From: Chen Hanxiao > >commit b4b5c82ce forgot to add this. > >Signed-off-by: Chen Hanxiao >--- > tools/virsh-domain-monitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-mo