On Thu, Mar 29, 2018 at 08:52:16 +0200, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1560976
>
> For historical reasons we've used 32 bytes long static buffer for
> storing PTY aliases. This breaks users scenario where they try to
> start a machine with user alias consisti
As planned I tagged it on git and pushed signed tarball and rpms
to the usual place at:
ftp://libvirt.org/libvirt/
this is virtually identical to rc1, the only change between two versions
is a comment edit pushed by Dan !
Still please give it a try, especially for other platforms and OSe
On 03/29/2018 09:18 AM, Peter Krempa wrote:
> On Thu, Mar 29, 2018 at 08:52:16 +0200, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1560976
>>
>> For historical reasons we've used 32 bytes long static buffer for
>> storing PTY aliases. This breaks users scenario where they
On Thu, Mar 29, 2018 at 10:13:43 +0200, Michal Privoznik wrote:
> On 03/29/2018 09:18 AM, Peter Krempa wrote:
> > On Thu, Mar 29, 2018 at 08:52:16 +0200, Michal Privoznik wrote:
> >> https://bugzilla.redhat.com/show_bug.cgi?id=1560976
> >>
> >> For historical reasons we've used 32 bytes long static
On 03/29/2018 10:22 AM, Peter Krempa wrote:
> On Thu, Mar 29, 2018 at 10:13:43 +0200, Michal Privoznik wrote:
>> On 03/29/2018 09:18 AM, Peter Krempa wrote:
>>> On Thu, Mar 29, 2018 at 08:52:16 +0200, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1560976
For his
From: Wim ten Have
When virt-install requests to create fully allocated storage object when
the parameter sparse=no is set, libvirt doesn't allow that to happen
for qcow2 formatted files.
Regardless of its XML instuction request libvirt always targets its
filesystem object storage with prealloc
From: Wim ten Have
Signed-off-by: Wim ten Have
---
tests/storagevolxml2argvdata/qcow2-nocapacity-convert-prealloc.argv | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/tests/storagevolxml2argvdata/qcow2-nocapacity-convert-prealloc.argv
b/tests/storagevolxml2argvdata/qcow2-n
From: Wim ten Have
This patch adds support to qcow2 formatted storage objects by instructing
qemu-img to build them with preallocation=falloc whenever the XML
described storage matches its . For all other
cases the objects are built with preallocation=metadata.
Signed-off-by: Wim ten Have
---
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 4
src/domain.c| 21 +
test/test_domain.py | 17 +
3 files changed, 42 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index f3
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 4
src/domain.c| 21 +
test/test_domain.py | 15 +++
3 files changed, 40 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 3921
* Implemented Suspend and Resume APIs.
* Merged all Domain Lifecycle events signals into one signal.
* Reused virsh functions for taking the Event Strings names from ENUM.
Katerina Koukiou (4):
Implement Suspend method for Domain interface.
Implement Resume method for Domain interface.
Merge
The functions were copied from src/util/virutil.* files from
libvirt project.
They will be needed for other function of enum to string
as well.
Signed-off-by: Katerina Koukiou
---
m4/virt-compile-warnings.m4 | 3 +++
src/events.c| 35 +--
src/uti
Instead of having multiple signals regarding to domain events,
like DomainStarted, DomainUndefined etc, we will have only one
called Domain, and the specific event type will be specified in
the signals arguments.
The domain name argument in not needed in the signal since we can
fetch it from path.
The function docs state that 'strcontent' may be NULL, but code added in
3506f1ecfde did not use the 'cmpcontent' variable which was fixed and
dereferenced it.
Signed-off-by: Peter Krempa
---
tests/testutils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/testutil
This is a collection of patches from my blockdev-add branch which are
basically ready.
First few patches are refactors and cleanups which should be justified
enough by itself even if the code which will use some of them was not
posted yet.
Other few patches add checks which will reject configurat
This format is used by the storage driver and other hypervisors but qemu
does not have nothion of the 'iso' format and libvirt does not translate
it to anything useful, so it would not work anyways. Users should use
'raw' instead.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c
For some reason we've decided to silently translate the disk
detect_zeroes mode if it would be invalid. Extract the
logic so that it does not need to be copypasta'd across the code base.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 22 ++
src/conf/domain_conf.h
In some use cases (mostly in tests) it is not required to check the
seclabel definition validity. Add possibility to call
virDomainDiskDefParse without the domain definition.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
QEMU does not support it so save us hassle and forbid it right away.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c| 23 +++
tests/qemuxml2argvdata/disk-drive-fmt-cow.xml | 27 +++
tests/qemuxml2argvtest.c
This is a storage driver type, which is not handled in qemu driver
properly. For accessing directories, disk type 'dir' is used instead.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c| 7 +++
tests/qemuxml2argvdata/disk-drive-fmt-dir.xml | 27
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 +
tests/qemucapabilitiesdata/caps_
Add a new kind of XML output test for the files in qemuxml2argvtest
where we can validate setup and defaults applied when starting up the
VM.
This is achieved by formatting of the definition processed by the
qemuxml2argvtest into a XML and it's compared against files in
qemuxml2startupxmloutdata.
Reject configurations when qemu would not support the image.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index e02da9e608..cbad7d0f4c 100644
--- a
Signed-off-by: Peter Krempa
---
.../qemuxml2argvdata/luks-disks-source-qcow2.args | 66 ++
tests/qemuxml2argvdata/luks-disks-source-qcow2.xml | 81 ++
tests/qemuxml2argvtest.c | 2 +
3 files changed, 149 insertions(+)
create mode 10
It will be necessary to initialize various aspects for the detected
members of the backing chain. Add a function that will handle it and
call it from qemuDomainPrepareDiskSource and qemuDomainDetermineDiskChain
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 48 +
The old qcow2 encryption format was buggy, so the new approach is to use
luks inside qcow2. As it turns out, it didn't require that many changes.
It was necessary to fix the command line formatter to stop mangling the
format when secrets are present and specify the encryption format and
secret in
Make the function more usable by returning the full disk definition and
fix the only caller for the new semantics. The new name for the function
is virDomainDiskDefParse.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 33 -
src/conf/domain_conf.h |
The qemu command line generator code set disk caching of shareable disks
to 'none' when formatting the command line silently. Move this code to a
common place when preparing the domain definition for startup so that it
does not have to be duplicated.
The new test case shows that the actual cache m
On Thu, Mar 29, 2018 at 01:07:56PM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 4
src/domain.c| 21 +
test/test_domain.py | 17 +
3 files changed, 42 insertions(+)
ACK
Jano
s
On Thu, Mar 29, 2018 at 01:07:55PM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 4
src/domain.c| 21 +
test/test_domain.py | 15 +++
3 files changed, 40 insertions(+)
ACK
Jano
sig
If the virHashAddEntry fails, then we need to "careful" about
how we free the @obj. When virDomainObjParseFile returns there
is one reference and the object is locked, so use virDomainObjEndAPI
when done.
Add a virObjectRef in the error path for the second virHashAddEntry
call since it doesn't cal
If the virHashAddEntry fails, then we need to "careful" about
how we free the @vm. When virDomainObjNew returns there is one
reference and the object is locked, so use virDomainObjEndAPI
when done.
Add a virObjectRef in the error path for the second virHashAddEntry
call since it doesn't call virOb
Create a common helper to add an object to the locked domain
objlist hash tables and use it.
Signed-off-by: John Ferlan
---
src/conf/virdomainobjlist.c | 64 +++--
1 file changed, 39 insertions(+), 25 deletions(-)
diff --git a/src/conf/virdomainobjlist.c
When virDomainObjParseFile runs, it returns a locked @obj with
one reference. Rather than just use virObjectUnref to clean that
up, use virObjectEndAPI.
Signed-off-by: John Ferlan
---
src/lxc/lxc_controller.c | 2 +-
tests/qemuxml2xmltest.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(
As evidenced by various code comments, the process of adding and
removing objects to/from the domain object list is problematic.
Long story short is that the Add logic doesn't generate enough
object references and the Remove logic removes one extra than
was added during Add and leaves the object u
On Thu, Mar 29, 2018 at 01:07:58PM +0200, Katerina Koukiou wrote:
> The functions were copied from src/util/virutil.* files from
> libvirt project.
>
> They will be needed for other function of enum to string
> as well.
This should be split into two patches, one that introduces the
new macros and
Since virCloseCallbacksRun was ignoring the value anyway, let's
just change it to be a void function.
Signed-off-by: John Ferlan
---
src/bhyve/bhyve_process.c| 8 ++--
src/lxc/lxc_process.c| 8 ++--
src/qemu/qemu_migration.c| 7 ++-
src/qemu/qemu_process.c | 7 ++
Upon entry from virCloseCallbacksRun, the @dom will have a
Ref and Lock from virDomainObjListFindByUUIDRef, so there's
no need to take an extra reference nor should the code call
virDomainObjEndAPI when done since that both Unref's and
Unlock's the @dom which means the callers call to EndAPI
would
Slightly related to some current work to clean up the Add/Remove
domain object list processing - as it turns out the close callbacks
run code didn't even pay attention to what was returned and it
really didn't need to - so let's just call it what it is a void
function and let the virCloseCallbacksR
On Thu, Mar 29, 2018 at 01:07:57PM +0200, Katerina Koukiou wrote:
Instead of having multiple signals regarding to domain events,
like DomainStarted, DomainUndefined etc, we will have only one
called Domain, and the specific event type will be specified in
the signals arguments.
The domain name a
On Thu, Mar 29, 2018 at 02:44:54PM +0200, Pavel Hrdina wrote:
On Thu, Mar 29, 2018 at 01:07:58PM +0200, Katerina Koukiou wrote:
The functions were copied from src/util/virutil.* files from
libvirt project.
They will be needed for other function of enum to string
as well.
This should be split
On Thu, Mar 29, 2018 at 01:07:57PM +0200, Katerina Koukiou wrote:
> Instead of having multiple signals regarding to domain events,
> like DomainStarted, DomainUndefined etc, we will have only one
> called Domain, and the specific event type will be specified in
> the signals arguments.
>
> The dom
My commit 2e0d6cdec41 claimed qemuMonitorJSONCheckError guarantees
"return" object exists in the JSON reply. But it only makes sure the key
is there, while the type of the value is not checked. A lot of callers
do not care since they only want to see whether their QMP command failed
or not, but any
On Thu, 2018-03-29 at 15:14 +0200, Pavel Hrdina wrote:
> On Thu, Mar 29, 2018 at 01:07:57PM +0200, Katerina Koukiou wrote:
> > Instead of having multiple signals regarding to domain events,
> > like DomainStarted, DomainUndefined etc, we will have only one
> > called Domain, and the specific event
On Thu, 2018-03-29 at 15:05 +0200, Ján Tomko wrote:
> On Thu, Mar 29, 2018 at 01:07:57PM +0200, Katerina Koukiou wrote:
> > Instead of having multiple signals regarding to domain events,
> > like DomainStarted, DomainUndefined etc, we will have only one
> > called Domain, and the specific event typ
On Thu, 2018-03-29 at 15:11 +0200, Ján Tomko wrote:
> On Thu, Mar 29, 2018 at 02:44:54PM +0200, Pavel Hrdina wrote:
> > On Thu, Mar 29, 2018 at 01:07:58PM +0200, Katerina Koukiou wrote:
> > > The functions were copied from src/util/virutil.* files from
> > > libvirt project.
> > >
> > > They will
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 4
src/domain.c| 21 +
test/test_domain.py | 17 +
3 files changed, 42 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index f3
This function replaces the manual translation of Event ENUMS.
Note: VIR_ENUM_SENTINELS is needed for VIR_DOMAIN_EVENT_LAST.
Signed-off-by: Katerina Koukiou
---
src/events.c | 55 +--
src/events.h | 3 +++
src/util.h | 1 +
3 files changed,
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 4
src/domain.c| 21 +
test/test_domain.py | 15 +++
3 files changed, 40 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 3921
The functions were copied from src/util/virutil.* files from
libvirt project
Signed-off-by: Katerina Koukiou
---
src/util.c | 27 +++
src/util.h | 28
2 files changed, 55 insertions(+)
diff --git a/src/util.c b/src/util.c
index d6c27f3..3179d
* Implemented Suspend and Resume APIs.
* Reused virsh functions for taking the Event Strings names from ENUM.
* Merged all Domain Lifecycle events signals into one signal.
Katerina Koukiou (5):
Implement Suspend method for Domain interface.
Implement Resume method for Domain interface.
utils
Instead of having multiple signals regarding to domain events,
like DomainStarted, DomainUndefined etc, we will have only one
called DomainEvents, and the specific event type will be specified in
the signals arguments.
The domain name argument in not needed in the signal since we can
fetch it from
On Thu, 2018-03-29 at 14:44 +0200, Pavel Hrdina wrote:
> On Thu, Mar 29, 2018 at 01:07:58PM +0200, Katerina Koukiou wrote:
> > The functions were copied from src/util/virutil.* files from
> > libvirt project.
> >
> > They will be needed for other function of enum to string
> > as well.
>
> This s
On 03/16/2018 01:02 PM, Sukrit Bhatnagar wrote:
> This patch adds virQEMUBuildBufferEscapeComma wherever applicable in
> src/qemu/qemu_command.c
> Based on:
> https://wiki.libvirt.org/page/BiteSizedTasks#qemu:_Use_comma_escaping_for_more_command_line_values
>
Try to keep shorter lines in your
On 03/26/2018 06:53 AM, Kashyap Chamarthy wrote:
> (Thanks: Jiri Denemark, for clarifying this on IRC.)
Lost context here! That should have gone under the --- cause it'll look
awfully strange in git history.
Is there "more" or "extra" text you'd like to see added? Or is the
commit message goo
On 03/26/2018 04:29 PM, Jim Fehlig wrote:
> Signed-off-by: Jim Fehlig
> ---
> src/util/virsocketaddr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: John Ferlan
May was well wait for 4.2.0 to be released before pushing...
John
> diff --git a/src/util/virsocketad
On 03/26/2018 04:29 PM, Jim Fehlig wrote:
> When preparing for migration, the libxl driver creates a new TCP listen
> socket for the incoming migration by calling virNetSocketNewListenTCP,
> passing the destination host name. virNetSocketNewListenTCP calls
> virSocketAddrParse to check if the hos
On 03/15/2018 10:03 PM, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> commit b4b5c82ce forgot to add this.
>
> Signed-off-by: Chen Hanxiao
> ---
> tools/virsh-domain-monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-
On 03/09/2018 09:48 AM, John Ferlan wrote:
Rather than repeat code throughout, create and use a couple of
accessors in order to lookup by UUID.
Signed-off-by: John Ferlan
---
src/openvz/openvz_driver.c | 266 +
1 file changed, 76 insertions(+), 190
On 03/09/2018 09:48 AM, John Ferlan wrote:
If openvzDomainLookupByID or openvzDomainLookupByName fails
to find a vm, let's be a bit more descriptive by providing
the failing id or name in the error message.
Signed-off-by: John Ferlan
---
src/openvz/openvz_driver.c | 10 ++
1 file cha
On 03/09/2018 09:48 AM, John Ferlan wrote:
For openvzDomObjFromDomainLocked and openvzDomainLookupByID
let's return a locked and referenced @vm object so that callers
can then use the common and more consistent virDomainObjEndAPI
in order to handle cleanup rather than needing to know that the
ret
On Thu, Mar 29, 2018 at 16:35:59 +0200, Jiri Denemark wrote:
> My commit 2e0d6cdec41 claimed qemuMonitorJSONCheckError guarantees
> "return" object exists in the JSON reply. But it only makes sure the key
> is there, while the type of the value is not checked. A lot of callers
> do not care since t
62 matches
Mail list logo
