Re: [libvirt] [qemu RFC] qapi: add "firmware.json"

Hi, > I threw in "-kernel" because, although it also (usually?) means > "memory", I expected people would want it separate. > > Regarding memory vs. pflash, I thought that these two, combined with the > access permissions, could cover all of RAM, ROM, and read-only and > read-write pflash too.

Re: [libvirt] [PATCH V2 2/8] tests: move sexpr2xml tests to WITH_LIBXL

On 04/09/2018 08:32 AM, Daniel P. Berrangé wrote: On Fri, Apr 06, 2018 at 02:44:54PM -0600, Jim Fehlig wrote: In preparation of removing the legacy Xen driver, move the sexpr2xml tests from WITH_XEN to WITH_LIBXL. Even though the legacy driver will be removed, we'll want to maintain the ability

[libvirt] [PATCH] news: announce dropping of legacy Xen driver

Signed-off-by: Jim Fehlig --- Not sure if removal of a feature is a feature, but this seems better placed under "New features" than "Improvements" or "Bug fixes". docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index

Re: [libvirt] [PATCH 2/6] tpm: Add support for external swtpm TPM emulator

On 04/06/2018 10:54 AM, Daniel P. Berrangé wrote: On Fri, Apr 06, 2018 at 10:49:23AM -0400, Stefan Berger wrote: I would feel better if we just directly killed the process - with this approach if something goes wrong with swtpm it may never respond to this request and stay running. swtpm can

[libvirt] [PATCH v2 1/1] storage: extend preallocation flags support for qemu-img

From: Wim ten Have This patch adds support to qcow2 formatted filesystem object storage by instructing qemu-img to build them with preallocation=falloc whenever the XML described storage matches its . For all other cases the filesystem stored objects are built with

Re: [libvirt] [PATCH v1 1/2] storage: extend preallocation flags support for qemu-img

On Wed, 4 Apr 2018 13:31:39 +0200 Michal Privoznik wrote: > On 04/03/2018 04:14 PM, Wim Ten Have wrote: > > From: Wim ten Have > > > > This patch adds support to qcow2 formatted filesystem object storage by > > instructing qemu-img to build them

[libvirt] [PATCH v2 0/1] Fix qcow2 fully allocated filesystem objects.

From: Wim ten Have When tools like virt-install request to create a fully allocated filesystem object storage by setting the parameter sparse=no, libvirt doesn't allow that to happen for qcow2 formatted files. Regardless of its XML instuction request libvirt always

Re: [libvirt] [qemu RFC] qapi: add "firmware.json"

On 04/09/18 10:49, Daniel P. Berrangé wrote: > On Sat, Apr 07, 2018 at 02:01:17AM +0200, Laszlo Ersek wrote: >> Add a schema that describes the properties of virtual machine firmware. >> >> Each firmware executable installed on a host system should come with a >> JSON file that conforms to this

Re: [libvirt] Race condition between qemuDomainCreate and qemuDomainDestroy

On 04/09/2018 12:12 PM, Laine Stump wrote: > On 04/06/2018 12:27 PM, John Ferlan wrote: >> >> On 04/03/2018 07:47 AM, Marc Hartmayer wrote: >>> On Tue, Mar 20, 2018 at 11:25 AM +0100, Marc Hartmayer >>> wrote: Hi, there is a race condition between

[libvirt] [dbus PATCH v2 05/11] APIs should appear in alphabetical order: Move Create method

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 10 +- src/domain.c| 48 ++--- 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/data/org.libvirt.Domain.xml

[libvirt] [dbus PATCH v2 04/11] APIs should appear in alphabetical order: Move UUID property

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 8 src/domain.c| 42 +- test/test_domain.py | 2 +- 3 files changed, 26 insertions(+), 26 deletions(-) diff --git

[libvirt] [dbus PATCH v2 09/11] APIs should appear in alphabetical order: Move Undefine method

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 8 src/domain.c| 40 test/test_domain.py | 26 +- 3 files changed, 37 insertions(+), 37 deletions(-) diff

[libvirt] [dbus PATCH v2 11/11] APIs should appear in alphabetical order: Move ListDomains method

Also test was renamed from test_list_domains to test_connect_list_domains to follow the naming convention. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 12 +++ src/connect.c| 82 ++--

[libvirt] [dbus PATCH v2 10/11] APIs should appear in alphabetical order: Move Shutdown method

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 10 +- src/domain.c| 48 ++--- 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/data/org.libvirt.Domain.xml

[libvirt] [dbus PATCH v2 06/11] APIs should appear in alphabetical order: Move Destroy method

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 10 - src/domain.c| 49 +++-- 2 files changed, 30 insertions(+), 29 deletions(-) diff --git a/data/org.libvirt.Domain.xml

[libvirt] [dbus PATCH v2 08/11] APIs should appear in alphabetical order: Move Resume method

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 8 src/domain.c| 42 +- test/test_domain.py | 32 3 files changed, 41 insertions(+), 41 deletions(-)

[libvirt] [dbus PATCH v2 00/11] Some code move to have functions sorted

Better do it now before the projects grows more. Katerina Koukiou (11): APIs should appear in alphabetical order: Move Active property APIs should appear in alphabetical order: Move Autostart property APIs should appear in alphabetical order: Move Id property APIs should appear in

[libvirt] [dbus PATCH v2 07/11] APIs should appear in alphabetical order: Move GetStats method

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 14 - src/domain.c| 75 ++--- 2 files changed, 44 insertions(+), 45 deletions(-) diff --git a/data/org.libvirt.Domain.xml

[libvirt] [dbus PATCH v2 02/11] APIs should appear in alphabetical order: Move Autostart property

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 8 src/domain.c| 42 +- test/test_domain.py | 2 +- 3 files changed, 26 insertions(+), 26 deletions(-) diff --git

[libvirt] [dbus PATCH v2 03/11] APIs should appear in alphabetical order: Move Id property

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 8 src/domain.c| 44 ++-- test/test_domain.py | 2 +- 3 files changed, 27 insertions(+), 27 deletions(-) diff --git

[libvirt] [dbus PATCH v2 01/11] APIs should appear in alphabetical order: Move Active property

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 8 src/domain.c| 44 ++-- test/test_domain.py | 2 +- 3 files changed, 27 insertions(+), 27 deletions(-) diff --git

Re: [libvirt] [qemu RFC] qapi: add "firmware.json"

On 04/09/18 10:26, Gerd Hoffmann wrote: >> +# { >> +# "executable": { >> +# "pathname": "/usr/share/OVMF/OVMF_CODE.secboot.fd", >> +# "description": "OVMF with Secure Boot and SMM-protected varstore", >> +# "tags": [ >> +# "FD_SIZE_4MB", >> +#

Re: [libvirt] [qemu RFC] qapi: add "firmware.json"

On 04/09/18 10:19, Gerd Hoffmann wrote: >>> +{ 'enum' : 'SystemFirmwareType', >>> + 'data' : [ 'bios', 'slof', 'uboot', 'uefi' ] } >> >> The naming here is quite a bad mixture between firmware interface >> ('bios', 'uefi') and firmware implementations ('slof', 'uboot'). There >> could be other

Re: [libvirt] [qemu RFC] qapi: add "firmware.json"

On 04/09/18 10:08, Thomas Huth wrote: > On 07.04.2018 02:01, Laszlo Ersek wrote: >> Add a schema that describes the properties of virtual machine firmware. > [...] >> +## >> +# @SystemFirmware: >> +# >> +# Describes a system firmware binary and any NVRAM slots that it requires. >> +# >> +#

Re: [libvirt] [qemu RFC] qapi: add "firmware.json"

On 04/09/18 09:26, Thomas Huth wrote: > Hi Laszlo, > > On 07.04.2018 02:01, Laszlo Ersek wrote: >> Add a schema that describes the properties of virtual machine firmware. >> >> Each firmware executable installed on a host system should come with a >> JSON file that conforms to this schema, and

Re: [libvirt] [libvirt PATCH v2 05/44] Deprecate QEMU_CAPS_PCI_MULTIFUNCTION

On Mon, 2018-04-09 at 17:19 +0200, Ján Tomko wrote: > Supported since QEMU 0.13, but we require QEMU 0.15. s/0.15/1.5.0/ > diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c > index 24eb8cbc5b..288de59de1 100644 > --- a/tests/qemuxml2argvtest.c > +++ b/tests/qemuxml2argvtest.c > @@

Re: [libvirt] Race condition between qemuDomainCreate and qemuDomainDestroy

On 04/06/2018 12:27 PM, John Ferlan wrote: > > On 04/03/2018 07:47 AM, Marc Hartmayer wrote: >> On Tue, Mar 20, 2018 at 11:25 AM +0100, Marc Hartmayer >> wrote: >>> Hi, >>> >>> there is a race condition between 'qemuDomainCreate' and >>> 'qemuDomainDestroy' causing a

Re: [libvirt] [PATCH 0/8] Simplify & standarize more parts of driver URI handling

On Mon, Apr 09, 2018 at 04:45:43PM +0100, Daniel P. Berrangé wrote: > The motivating goal of this series was/is to make it possible to answer > whether there is any driver registered to handle a given URI scheme > without having to call into the drivers. > > Ultimately this ended up being a nice

Re: [libvirt] [dbus PATCH] APIs should appear in aplhabetical order in all files.

On Mon, 2018-04-09 at 17:45 +0200, Pavel Hrdina wrote: > On Mon, Apr 09, 2018 at 05:10:48PM +0200, Katerina Koukiou wrote: > > In C and XML files the order is: > > 1) properties > > 2) methods > > 3) signals > > All of them sorted in their category alphabetically. > > > > Signed-off-by: Katerina

Re: [libvirt] [libvirt PATCH v2 04/44] Require QEMU 1.5.0

On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote: > According to the policy described on https://libvirt.org/platforms.html > the QEMU versions in the oldest relevant releses are: Empty line here. Possibly indent the distros with two spaces. > SLES 12: 2.0.0 > RHEL 7: 1.5.3 > Ubuntu 14.04:

Re: [libvirt] [libvirt PATCH v2 14/44] Deprecate QEMU_CAPS_SDL

On 04/09/2018 10:33 AM, Daniel P. Berrangé wrote: > On Mon, Apr 09, 2018 at 05:20:07PM +0200, Ján Tomko wrote: >> Implied by QEMU >= 1.2.0. >> >> +++ b/src/qemu/qemu_capabilities.h >> @@ -85,7 +85,7 @@ typedef enum { >> /* 25 */ >> X_QEMU_CAPS_BALLOON, /* -balloon available */ >>

[libvirt] [PATCH 7/8] driver: enforce a non-NULL URI scheme

Now that the legacy Xen driver has been dropped, we no longer need to support URIs such as "/path/to/xend/socket", and so can mandate that a URI scheme must always be present. Signed-off-by: Daniel P. Berrangé --- src/libvirt.c | 15 ++

[libvirt] [PATCH 6/8] driver: ensure NULL URI isn't passed to drivers with whitelisted URIs

Ensuring that we don't call the virDrvConnectOpen method with a NULL URI means that the drivers can drop various checks for NULL URIs. These were not needed anymore since the probe functionality was split Signed-off-by: Daniel P. Berrangé --- src/bhyve/bhyve_driver.c

[libvirt] [PATCH 4/8] driver: allow drivers to indicate if they permit remote connections

Add a localOnly flag to the virConnectDriver struct which allows a driver to indicate whether it is local-only, or permits remote connections. Stateful drivers running inside libvirtd are generally local only. This allows us to remote the check for uri->server != NULL from most drivers.

[libvirt] [PATCH 2/8] lxc: allow use of lxc:///system URI as preferred format

Historically we have used a bare lxc:/// URI for connecting to LXC. This is different from our practice with QEMU, UML, Parallels, Libxl, BHyve and VirtualBox drivers, which all use a path of '/system' or '/session' or both. By making LXC allow '/system', we have fully standardized on the use of

[libvirt] [PATCH 3/8] driver: introduce a driver method for probing default URIs

Currently the virDrvConnectOpen method is supposed to handle both opening an explicit URI and auto-probing a driver if no URI is given. Introduce a dedicated virDrvConnectURIProbe method to enable the probing functionality to be split from the driver opening functionality. It is still possible

[libvirt] [PATCH 8/8] driver: ensure URI path is non-NULL to simplify drivers

Avoid the need for the drivers to explicitly check for a NULL path by making sure it is at least the empty string. Signed-off-by: Daniel P. Berrangé --- src/bhyve/bhyve_driver.c | 2 +- src/esx/esx_driver.c | 2 +- src/libvirt.c | 8 +++-

[libvirt] [PATCH 0/8] Simplify & standarize more parts of driver URI handling

The motivating goal of this series was/is to make it possible to answer whether there is any driver registered to handle a given URI scheme without having to call into the drivers. Ultimately this ended up being a nice simplification and cleanup of driver URI opening code, removing repetative

[libvirt] [PATCH 5/8] driver: declare supported URI schemes in virConnectDriver struct

Declare what URI schemes a driver supports in its virConnectDriver struct. This allows us to skip trying to open the driver entirely if the URI scheme doesn't match. Signed-off-by: Daniel P. Berrangé --- src/bhyve/bhyve_driver.c| 4 +--- src/driver.h

Re: [libvirt] [dbus PATCH] APIs should appear in aplhabetical order in all files.

On Mon, Apr 09, 2018 at 05:10:48PM +0200, Katerina Koukiou wrote: > In C and XML files the order is: > 1) properties > 2) methods > 3) signals > All of them sorted in their category alphabetically. > > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml |

[libvirt] [PATCH 1/8] xen: encourage use of xen:///system URI as preferred format

Historically we have used a bare xen:/// URI for connecting to the legacy Xen driver. The new libxl Xen driver follows the new practice of allowing '/system' as a path, as well as bare '/' for compat with the old Xen driver. This documents xen:///system as the preferred format for Xen, leaving

Re: [libvirt] [libvirt PATCH v2 03/44] Force QMP capability probing

On Thu, Apr 05, 2018 at 02:22:54PM +0200, Ján Tomko wrote: > Remove the qmpOnly attribute of virQEMUCapsNewForBinaryInternal > and instead always assume it's true. > > This effectively sets the minimum QEMU version to 1.2.0, > breaking support for QEMU in RHEL6. > > @@ -5077,8 +4225,7 @@

[libvirt] [libvirt PATCH v2 40/44] Deprecate QEMU_CAPS_DUMP_GUEST_CORE

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 19 +--

Re: [libvirt] [libvirt PATCH v2 14/44] Deprecate QEMU_CAPS_SDL

On Mon, Apr 09, 2018 at 05:20:07PM +0200, Ján Tomko wrote: > Implied by QEMU >= 1.2.0. > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_capabilities.c | 4 +--- > src/qemu/qemu_capabilities.h | 2 +- > src/qemu/qemu_command.c

Re: [libvirt] [RFC] Defining firmware (OVMF, et al) metadata format & file

On 04/09/18 11:02, Kashyap Chamarthy wrote: > - It also provides a persistent command history in a convenient file: > '~/.qmp-shell_history' I noticed it used readline, but I didn't know about the dedicated history file. Nice! Thanks! Laszlo -- libvir-list mailing list

Re: [libvirt] [libvirt PATCH v2 03/44] Force QMP capability probing

On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote: > Remove the qmpOnly attribute of virQEMUCapsNewForBinaryInternal s/attribute/argument/ > and instead always assume it's true. > > This effectively sets the minimum QEMU version to 1.2.0, > breaking support for QEMU in RHEL6. I don't think we

[libvirt] [libvirt PATCH v2 44/44] Deprecate QEMU_CAPS_MACHINE_USB_OPT

Implied by QEMU >= 1.3.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c

[libvirt] [libvirt PATCH v2 43/44] Deprecate QEMU_CAPS_DISPLAY

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 12 src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 8

[libvirt] [libvirt PATCH v2 25/44] Deprecate QEMU_CAPS_CHARDEV_SPICEVMC

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 +--- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 5 -

[libvirt] [libvirt PATCH v2 23/44] Deprecate QEMU_CAPS_VGA_NONE

Last use was removed by commit 0586cf98 deprecating QEMU_CAPS_DEVICE. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 -

[libvirt] [libvirt PATCH v2 28/44] Deprecate QEMU_CAPS_NO_SHUTDOWN

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 4 +---

[libvirt] [libvirt PATCH v2 34/44] Deprecate QEMU_CAPS_WAKEUP

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 2 -- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_driver.c | 16

[libvirt] [libvirt PATCH v2 20/44] Deprecate QEMU_CAPS_FSDEV

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 6 --

[libvirt] [libvirt PATCH v2 19/44] Deprecate QEMU_CAPS_BOOT_MENU

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 15 ---

[libvirt] [libvirt PATCH v2 33/44] Deprecate QEMU_CAPS_DRIVE_IOTUNE

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 9 - src/qemu/qemu_driver.c

[libvirt] [libvirt PATCH v2 42/44] Deprecate QEMU_CAPS_HOST_PCI_MULTIDOMAIN

Implied by QEMU >= 1.2.0. Delete the negative test cases now that they always pass. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c

[libvirt] [libvirt PATCH v2 26/44] Deprecate QEMU_CAPS_DEVICE_SPICEVMC

The (now assumed) QEMU_CAPS_CHARDEV_SPICEVMC is preferred. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 -- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 71

[libvirt] [libvirt PATCH v2 37/44] Deprecate QEMU_CAPS_DTB

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 11 ++-

[libvirt] [libvirt PATCH v2 41/44] Deprecate QEMU_CAPS_VNC_SHARE_POLICY

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 7 ---

[libvirt] [libvirt PATCH v2 39/44] Deprecate QEMU_CAPS_MACHINE_OPT

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 317 +

[libvirt] [libvirt PATCH v2 22/44] Deprecate QEMU_CAPS_SMBIOS_TYPE

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 12 ++--

[libvirt] [libvirt PATCH v2 32/44] Deprecate QEMU_CAPS_FSDEV_WRITEOUT

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 16

[libvirt] [libvirt PATCH v2 15/44] Deprecate QEMU_CAPS_RTC

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 41 --

[libvirt] [libvirt PATCH v2 18/44] Deprecate QEMU_CAPS_NODEFCONFIG

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 -

[libvirt] [libvirt PATCH v2 24/44] Deprecate QEMU_CAPS_DRIVE_AIO

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 7 ---

[libvirt] [libvirt PATCH v2 16/44] Deprecate QEMU_CAPS_RTC_TD_HACK

Implied by QEMU >= 0.12.0. Deprecated by QEMU commit 1ed2fc1 included in 0.12.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 21 + 2 files changed, 2 insertions(+), 21 deletions(-) diff --git

[libvirt] [libvirt PATCH v2 31/44] Deprecate QEMU_CAPS_DRIVE_COPY_ON_READ

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 7 ---

[libvirt] [libvirt PATCH v2 38/44] Deprecate QEMU_CAPS_IPV6_MIGRATION

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_migration.c | 10 +-

[libvirt] [libvirt PATCH v2 17/44] Deprecate QEMU_CAPS_VHOST_NET

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 3 +-- src/qemu/qemu_hotplug.c

[libvirt] [libvirt PATCH v2 35/44] Deprecate QEMU_CAPS_NETDEV_BRIDGE

Unused since commit <2d80fbb1>. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 -

[libvirt] [libvirt PATCH v2 36/44] Deprecate QEMU_CAPS_SECCOMP_SANDBOX

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 14 --

[libvirt] [libvirt PATCH v2 27/44] Deprecate QEMU_CAPS_DRIVE_CACHE_DIRECTSYNC

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 7 ---

[libvirt] [libvirt PATCH v2 29/44] Deprecate QEMU_CAPS_DRIVE_CACHE_UNSAFE

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 7 ---

[libvirt] [libvirt PATCH v2 30/44] Deprecate QEMU_CAPS_FSDEV_READONLY

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 12 ++--

[libvirt] [libvirt PATCH v2 11/44] Deprecate QEMU_CAPS_NO_USER_CONFIG

Implied by QEMU >= 1.2.0. Delete this one first, because QEMU_CAPS_NODEFCONFIG is only used when QEMU_CAPS_NO_USER_CONFIG is unsupported. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h

[libvirt] [libvirt PATCH v2 13/44] Deprecate QEMU_CAPS_DRIVE_SERIAL

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 20

[libvirt] [libvirt PATCH v2 21/44] Deprecate QEMU_CAPS_NAME_PROCESS

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 3 +--

[libvirt] [libvirt PATCH v2 14/44] Deprecate QEMU_CAPS_SDL

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 +--- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 9 +

[libvirt] [libvirt PATCH v2 12/44] Deprecate QEMU_CAPS_MEM_PATH

Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 12 ++

[libvirt] [libvirt PATCH v2 09/44] Remove qemuDomainSupportsNetdev

Now that we assume QEMU_CAPS_NETDEV, the only thing left to check is whether we need to use the legacy -net syntax because of a non-conforming armchitecture. Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c | 20 +--- src/qemu/qemu_domain.c| 10

[libvirt] [libvirt PATCH v2 07/44] Clean up qemuDomainAttachNetDevice

Now that we assume -netdev support, we no longer set the VLAN or need the hostPlugged bool. Signed-off-by: Ján Tomko --- src/qemu/qemu_hotplug.c | 42 +- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git

[libvirt] [libvirt PATCH v2 10/44] Deprecate QEMU_CAPS_MONITOR_JSON

We require QEMU >= 0.15.0, assume every QEMU supports it. Sadly that does not let us trivially drop qemuMonitor's priv->monJSON bool, because of qemuDomainQemuAttach. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 -

[libvirt] [libvirt PATCH v2 08/44] Remove unused qemuDomainNetVLAN

Signed-off-by: Ján Tomko --- src/qemu/qemu_domain.c | 6 -- src/qemu/qemu_domain.h | 2 -- 2 files changed, 8 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 37837c8cf3..fab1519969 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt] [libvirt PATCH v2 06/44] Deprecate QEMU_CAPS_NETDEV

This makes qemuDomainSupportsNetdev identical to qemuDomainSupportsNicdev and leaves some code in qemuDomainAttachNetDevice to be cleaned up later. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h

[libvirt] [libvirt PATCH v2 05/44] Deprecate QEMU_CAPS_PCI_MULTIFUNCTION

Supported since QEMU 0.13, but we require QEMU 0.15. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 15 --

[libvirt] [dbus PATCH] APIs should appear in aplhabetical order in all files.

In C and XML files the order is: 1) properties 2) methods 3) signals All of them sorted in their category alphabetically. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 12 +-- data/org.libvirt.Domain.xml | 54 ++-- src/connect.c

Re: [libvirt] [libvirt PATCH v2 02/44] Delete bogus cpu-host-passthrough test

On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote: > We test the same XML for a type='kvm' domain twice, once with > QEMU_CAPS_KVM (expecting success), once without (expecting failure). > > The failure case relies on QEMU_CAPS_MACHINE_OPT not being set, > failing in qemuBuildObsoleteAccelArg. >

Re: [libvirt] Race condition between qemuDomainCreate and qemuDomainDestroy

On Fri, Apr 06, 2018 at 06:27 PM +0200, John Ferlan wrote: > On 04/03/2018 07:47 AM, Marc Hartmayer wrote: >> On Tue, Mar 20, 2018 at 11:25 AM +0100, Marc Hartmayer >> wrote: >>> Hi, >>> >>> there is a race condition between 'qemuDomainCreate'

Re: [libvirt] [PATCH 4/4] qemu: Obtain reference on monConfig

On Mon, Apr 09, 2018 at 04:25 PM +0200, Marc Hartmayer wrote: > On Fri, Apr 06, 2018 at 06:53 PM +0200, John Ferlan > wrote: >> Because we allow a QEMU_JOB_DESTROY to occur while we're starting >> up and we drop the @vm lock prior to

Re: [libvirt] [PATCH 3/4] conf: Convert virDomainChrSourceDefNew to return object

On Fri, Apr 06, 2018 at 06:53 PM +0200, John Ferlan wrote: > Let's use object referencing to handle the ChrSourceDef. A subsequent > patch then can allow the monConfig to take an extra reference before > dropping the domain lock to then ensure nothing free's the memory that >

Re: [libvirt] [libvirt PATCH v2 00/4] Require QEMU 1.5.0

On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote: > v2: > * Change the version from 1.3.0 to 1.5.0 > * Mention this breaks RHEL 6 QEMU and list the versions > in relevant long-term releases > > Some of the patches are very big, available in my repo: >

Re: [libvirt] [libvirt PATCH v2 01/44] qemuxml2argvtest: Fix q35-virt-manager capabilities

On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote: > Use QEMU_CAPS_MACHINE_OPT and QEMU_CAPS_MACHINE_VMPORT_OPT > since it specifies . > > Signed-off-by: Ján Tomko > --- > tests/qemuxml2argvdata/q35-virt-manager-basic.args | 2 +- > tests/qemuxml2argvtest.c

Re: [libvirt] [PATCH V2 0/8] Remove the legacy xen driver

On Fri, Apr 06, 2018 at 02:44:52PM -0600, Jim Fehlig wrote: > Long overdue removal the old xen driver. The first 3 patches move existing > tests to WITH_LIBXL since we'll want to continue supporting conversion of > the various xen config formats. The remain patches remove the cruft. > > Patch8,

Re: [libvirt] [PATCH 2/4] qemu: Use virDomainChrSourceDefNew for monConfig

On Fri, Apr 06, 2018 at 06:53 PM +0200, John Ferlan wrote: > Rather than VIR_ALLOC, use the New function for allocation. We > already use the Free function anyway. > > Signed-off-by: John Ferlan > --- > src/conf/domain_conf.c | 2 +- >

Re: [libvirt] [PATCH V2 2/8] tests: move sexpr2xml tests to WITH_LIBXL

On Fri, Apr 06, 2018 at 02:44:54PM -0600, Jim Fehlig wrote: > In preparation of removing the legacy Xen driver, move the > sexpr2xml tests from WITH_XEN to WITH_LIBXL. Even though the > legacy driver will be removed, we'll want to maintain the ability > to convert sexpr to XML. Requires fixing up

Re: [libvirt] [PATCH 1/4] conf: Use virDomainChrSourceDefNew for vhostuser

On Fri, Apr 06, 2018 at 06:53 PM +0200, John Ferlan wrote: > Rather than using VIR_ALLOC, use the New API since we already > use the virDomainChrSourceDefFree function when done. > > Signed-off-by: John Ferlan > --- > src/conf/domain_conf.c | 2 +- > 1

Re: [libvirt] [PATCH 4/4] qemu: Obtain reference on monConfig

On Fri, Apr 06, 2018 at 06:53 PM +0200, John Ferlan wrote: > Because we allow a QEMU_JOB_DESTROY to occur while we're starting > up and we drop the @vm lock prior to qemuMonitorOpen, it's possible > that a domain destroy operation "wins" the race, calls qemuProcessStop > which

Re: [libvirt] [dbus PATCH v2 5/8] Implement Secure property for Connect Interface

On Mon, Apr 09, 2018 at 04:00:55PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 5 + > src/connect.c| 20 > test/test_connect.py | 1 + > 3 files changed, 26

Re: [libvirt] [dbus PATCH v2 4/8] Implement Encrypted property for Connect Interface

On Mon, Apr 09, 2018 at 04:00:54PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 5 + > src/connect.c| 20 > test/test_connect.py | 1 + > 3 files changed, 26

Re: [libvirt] [dbus PATCH v2 1/8] Implement GetCapabilities method for connect Interface

On Mon, Apr 09, 2018 at 04:00:51PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 5 + > src/connect.c| 23 +++ > test/test_connect.py | 3 +++ > 3 files changed, 31

  1   2   >