On 04/10/2018 10:58 AM, Michal Privoznik wrote:
> Now that we generate pr-manager alias and socket path store them
> in status XML so that they are preserved across daemon restarts.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_domain.c | 64
> +
On 04/10/2018 10:58 AM, Michal Privoznik wrote:
> While we're not generating the command line just yet (look for
> the next commits), we can generate the alias for pr-manager.
> A domain can have up to one managed pr-manager (in which case
> socket path is decided by libvirt and pr-helper is spaw
On 04/13/2018 05:16 AM, Nikolay Shirokovskiy wrote:
>
>
> On 13.04.2018 00:16, John Snow wrote:
>>
>>
>> On 04/03/2018 08:01 AM, Nikolay Shirokovskiy wrote:
>>> Hi, all.
>>>
>>>
On Wed, Apr 11, 2018 at 04:41:49PM +0200, Jiri Denemark wrote:
Some migration capabilities may be enabled automatically, but only if
both sides of migration support them. Thus we need to be able transfer
the list of supported migration capabilities in migration cookie.
Signed-off-by: Jiri Denema
On 2018-04-11 14:02, John Ferlan wrote:
>
>
> On 04/03/2018 05:32 AM, Rainer Müller wrote:
>> The vmware driver wants to execute vmware-vmx from the same directory in
>> which vmrun was found. However, on VMware Fusion 10 vmrun at
>> /Applications/VMware Fusion.app/Contents/Public/vmrun is a syml
On 04/10/2018 10:58 AM, Michal Privoznik wrote:
> Couple of reasons for that:
>
> a) there's no monitor command to change path where the pr-helper
> connects to, or
> b) there's no monitor command to introduce a new pr-helper for a
> disk that already exists.
>
> Signed-off-by: Michal Privoznik
On 04/13/2018 08:01 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> 1. It looks unsafe to use nbd server + backup(sync=none) on same node,
>>> synchronization is needed, like in block/replication, which uses
>>> backup_wait_for_overlapping_requests, backup_cow_request_begin,
>>> backup_cow_request_en
On Wed, Apr 11, 2018 at 04:41:48PM +0200, Jiri Denemark wrote:
Since the monitor code no longer needs to see this enum, we move it
to the place where migration parameters are defined and drop the
"monitor" reference from the name.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_driver.c
On Wed, Apr 11, 2018 at 04:41:47PM +0200, Jiri Denemark wrote:
We want to have all migration capabilities parsing and formatting at one
place, i.e., in qemu_migration_params.c. The parsing is already there in
qemuMigrationCapsCheck.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_param
On Wed, Apr 11, 2018 at 04:41:45PM +0200, Jiri Denemark wrote:
It's no longer used by the monitor code so we can hide it inside
qemu_migration_params.c.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 36
src/qemu/qemu_monitor.h | 36
On Wed, Apr 11, 2018 at 04:41:44PM +0200, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark
---
src/qemu/Makefile.inc.am | 1 +
src/qemu/qemu_migration_params.c | 5 +++--
src/qemu/qemu_migration_paramspriv.h | 31
3 files changed, 35 insertions(+), 2
On Wed, Apr 11, 2018 at 04:41:42PM +0200, Jiri Denemark wrote:
We want to have all migration parameters parsing and formatting at once
place, i.e., in qemu_migration_params.c.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 74 +---
src/qemu/qemu_m
On Wed, Apr 11, 2018 at 04:41:41PM +0200, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark
---
src/libvirt_private.syms | 1 +
src/util/virjson.c | 8
src/util/virjson.h | 2 ++
3 files changed, 11 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Dig
On Wed, Apr 11, 2018 at 04:41:40PM +0200, Jiri Denemark wrote:
The test is mostly useless and we want to refactor migration parameters
even further. The refactoring will allow us to introduce enhanced tests
for migration parameters.
Signed-off-by: Jiri Denemark
---
tests/qemumonitorjsontest.c |
13.04.2018 18:05, Nikolay Shirokovskiy wrote:
On 13.04.2018 14:41, Vladimir Sementsov-Ogievskiy wrote:
13.04.2018 11:51, Nikolay Shirokovskiy wrote:
On 13.04.2018 03:04, John Snow wrote:
On 04/12/2018 10:08 AM, Vladimir Sementsov-Ogievskiy wrote:
I propose, not to say that bitmap represents
On Wed, Apr 11, 2018 at 04:41:37PM +0200, Jiri Denemark wrote:
By merging qemuMigrationAnyCompressionParse into
qemuMigrationParamsSetCompression we can drop the useless intermediate
qemuMigrationCompression structure and parse compression related typed
parameters and flags directly into qemuMigr
On 13.04.2018 14:41, Vladimir Sementsov-Ogievskiy wrote:
> 13.04.2018 11:51, Nikolay Shirokovskiy wrote:
>>
>> On 13.04.2018 03:04, John Snow wrote:
>>>
>>> On 04/12/2018 10:08 AM, Vladimir Sementsov-Ogievskiy wrote:
I propose, not to say that bitmap represents a checkpoint. It is simpler
>>
On Fri, Apr 13, 2018 at 16:22:00 +0200, Ján Tomko wrote:
> On Wed, Apr 11, 2018 at 04:41:31PM +0200, Jiri Denemark wrote:
> >So far it's used only for CPU throttling parameters which are all ints,
> >but we'll soon want to use it for more parameters with different types.
> >
> >Signed-off-by: Jiri
On Thu, Apr 05, 2018 at 02:22:51PM +0200, Ján Tomko wrote:
v2:
* Change the version from 1.3.0 to 1.5.0
* Mention this breaks RHEL 6 QEMU and list the versions
in relevant long-term releases
Some of the patches are very big, available in my repo:
https://repo.or.cz/libvirt/jtomko.git/shortlog/re
So far we are repeating the following lines over and over:
virClassNew(virClassForObject(),
"virSomeObject",
sizeof(virSomeObject),
virSomeObjectDispose);
While this works, it is impossible to do some checking. Firstly,
the class name (the 2nd argument)
Our virObject code relies heavily on the fact that the first
member of the class struct is type of virObject (or some
derivation of if). Let's check for that.
Signed-off-by: Michal Privoznik
---
src/util/virobject.c | 31 +--
src/util/virobject.h | 5 -
2 files c
Strictly speaking this is not needed right now. However, next
commits will require dispose function to exist.
Signed-off-by: Michal Privoznik
---
src/rpc/virnetsaslcontext.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/rpc/virnetsaslcontext.c b/src/rpc/virnetsas
Now that we have macro that does some checks lets forbid raw
usage of virClassNew() in favor of VIR_CLASS_NEW().
Signed-off-by: Michal Privoznik
---
cfg.mk | 8
1 file changed, 8 insertions(+)
diff --git a/cfg.mk b/cfg.mk
index 4078bc2c63..5b7a9728d2 100644
--- a/cfg.mk
+++ b/cfg.mk
@@
There's a typo in struct name.
Signed-off-by: Michal Privoznik
---
src/conf/domain_event.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c
index 7baccd5b57..fdb48a1eaa 100644
--- a/src/conf/domain_event.c
+++ b/src/conf/do
This is inspired by commit of f574e2e5214fb9. Also, the more the code is
unified the easier it is to maintain.
Michal Privoznik (9):
domain_event: s/MetadataCange/MetadataChange/g
util: Make structs follow our naming convention
datatypes: Rename @parent to @parentName in virNodeDevice
src:
In next patches this name will be needed for a different memeber.
Also, it makes sense to rename the variable because it does not
contain reference to parent device, just its name.
Signed-off-by: Michal Privoznik
---
src/conf/virnodedeviceobj.c | 2 +-
src/datatypes.c
There are two structs virMacMap and virFDStreamData that don't
have the underscore prefix. Put it there so that they follow the
rest of the code.
Signed-off-by: Michal Privoznik
---
src/util/virfdstream.c | 4 ++--
src/util/virmacmap.c | 2 +-
src/util/virmacmap.h | 2 +-
3 files changed, 4
On Wed, Apr 11, 2018 at 04:41:33PM +0200, Jiri Denemark wrote:
The API will soon be called from qemuMigrationParamsFromFlags. Let's
move it to avoid the need to add a forward declaration.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 59
1 f
On Wed, Apr 11, 2018 at 04:41:32PM +0200, Jiri Denemark wrote:
It's become only a tiny wrapper around virBitmapSetBit, which can easily
be called directly. We don't need to call virBitmapClearBit since
migParams->caps bitmap is initialized with zeros.
Signed-off-by: Jiri Denemark
---
src/qemu/q
On Wed, Apr 11, 2018 at 04:41:31PM +0200, Jiri Denemark wrote:
So far it's used only for CPU throttling parameters which are all ints,
but we'll soon want to use it for more parameters with different types.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 31 +++--
On 04/10/2018 10:49 AM, Ján Tomko wrote:
> If QEMU uses a seccomp blacklist (since 2.11), -sandbox on
> no longer tries to whitelist all the calls, but uses sets
> of blacklists:
> default (always blacklisted with -sandbox on)
> obsolete (defaults to deny)
> elevateprivileges (setuid & co, defaul
On 04/10/2018 10:49 AM, Ján Tomko wrote:
> Exit early if possible to simplify the logic.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 18 --
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
Reviewed-by: John Ferlan
John
> diff --git a/src/qemu/qemu_co
On 04/10/2018 10:49 AM, Ján Tomko wrote:
> Move the building of -sandbox command line into a separate function.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 30 +-
> 1 file changed, 21 insertions(+), 9 deletions(-)
>
Reviewed-by: John Ferlan
Jo
On Wed, Apr 11, 2018 at 04:41:28PM +0200, Jiri Denemark wrote:
Some migration capabilities are always enabled if QEMU supports them. We
can just drop the explicit code for them and let
qemuMigrationParamsCheck automatically set such capabilities.
QEMU_MONITOR_MIGRATION_CAPS_EVENTS would normally
On Fri, Apr 13, 2018 at 03:40:49PM +0200, Andrea Bolognani wrote:
> On Fri, 2018-04-13 at 14:25 +0100, Daniel P. Berrangé wrote:
> > On Fri, Apr 13, 2018 at 03:05:10PM +0200, Andrea Bolognani wrote:
> > > No, wait, actually its native variant is, but the same is true for
> > > the Adwaita icon them
Hello list,
Some host boot loaders, e.g. grub-bhyve when using the bhyve
driver, take commands on stdin. While there is the
tag to set arbitrary command line tags,
there is no or similar to provide standard
input to the boot loader.
Typical input could be something along the lines of e.g. the
f
On Fri, 2018-04-13 at 14:25 +0100, Daniel P. Berrangé wrote:
> On Fri, Apr 13, 2018 at 03:05:10PM +0200, Andrea Bolognani wrote:
> > No, wait, actually its native variant is, but the same is true for
> > the Adwaita icon theme. Weird. I don't see how we would need one of
> > them to be native and t
On Fri, 2018-04-13 at 14:28 +0100, Daniel P. Berrangé wrote:
> On Fri, Apr 13, 2018 at 03:24:09PM +0200, Andrea Bolognani wrote:
> > > + - mingw32-glib2
> >
> > Forgot to mention: mingw*-glib2 is not necessary here based on our
> > discussion, as it's already required to build libvirt-glib :)
>
On Wed, Apr 11, 2018 at 04:41:27PM +0200, Jiri Denemark wrote:
It's just a tiny wrapper around qemuMigrationParamsSetCapability and
setting priv->job.postcopyEnabled is not something qemuMigrationParams
code should be doing anyway so let the callers do it.
Signed-off-by: Jiri Denemark
---
src/q
On Wed, Apr 11, 2018 at 04:41:26PM +0200, Jiri Denemark wrote:
It is no longer used outside qemu_migration_params.c.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 2 +-
src/qemu/qemu_migration_params.h | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
Reviewed-by:
On Wed, Apr 11, 2018 at 04:41:25PM +0200, Jiri Denemark wrote:
Every migration entry point in qemu_driver is supposed to call
qemuMigrationParamsFromFlags to transform flags and parameters into
qemuMigrationParams structure and pass the result to qemuMigration*
APIs.
Signed-off-by: Jiri Denemark
On Fri, Apr 13, 2018 at 03:24:09PM +0200, Andrea Bolognani wrote:
> On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote:
> > diff --git a/guests/vars/projects/virt-viewer.yml
> > b/guests/vars/projects/virt-viewer.yml
> > index 6f3dbf9..85d1589 100644
> > --- a/guests/vars/projects/virt-vi
On Fri, Apr 13, 2018 at 03:05:10PM +0200, Andrea Bolognani wrote:
> On Fri, 2018-04-13 at 13:44 +0100, Daniel P. Berrangé wrote:
> > > Because of the missing dependencies mentioned below, you also need
> > >
> > > mingw32-hicolor-icon-theme:
> > > FedoraRawhide: mingw32-hicolor-icon-theme
>
On Fri, 2018-04-13 at 13:44 +0100, Daniel P. Berrangé wrote:
> > Because of the missing dependencies mentioned below, you also need
> >
> > mingw32-hicolor-icon-theme:
> > FedoraRawhide: mingw32-hicolor-icon-theme
>
> There's no such package AFAIK
There sure is:
$ dnf info mingw32-hicol
On Wed, Apr 11, 2018 at 04:41:24PM +0200, Jiri Denemark wrote:
Some migration parameters and capabilities are supposed to be set on
both sides of migration while others should only be set on one side. For
example, CPU throttling parameters make no sense on the destination and
they can be used eve
On 04/13/2018 02:49 PM, Clementine Hayat wrote:
>
> I'll take a look into coccinelle. It may take a bit more time thought.
>
Yeah, don't waste too much time on it. I merely just wanted to mention
it. It not that trivial to learn. But once you do, it's awesome tool.
Michal
--
libvir-list mailin
2018-04-13 8:25 GMT+00:00 Erik Skultety :
> On Fri, Apr 13, 2018 at 09:45:48AM +0200, Michal Privoznik wrote:
>> On 04/13/2018 09:31 AM, Ján Tomko wrote:
>> > On Thu, Apr 12, 2018 at 07:49:15PM +, Clementine Hayat wrote:
>> >> Add a function named virDomainObjCheckIsActive in src/conf/domain_co
On Fri, 2018-04-13 at 13:20 +0100, Daniel P. Berrangé wrote:
> On Fri, Apr 13, 2018 at 02:17:45PM +0200, Andrea Bolognani wrote:
> > On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote:
> > >- gtk-doc
> > >- intltool
> > >- libxml2
> > > + - mingw32-glib2
> > > + - mingw64-gli
On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote:
[...]
> + mingw32-gtk-vnc:
> +FedoraRawhide: mingw32-gtk-vnc
This (and the corresponding mingw64 entry) will drag in the version
of the library based on GTK+ 2 rather than the one based on GTK+ 3,
which is not what we want. It shoul
On Wed, Apr 11, 2018 at 04:41:22PM +0200, Jiri Denemark wrote:
We reached the point when qemuMigrationParamsApply is the only API which
sends migration parameters and capabilities to QEMU. Thus all but the
TLS parameters can be set before we ask QEMU for the current values of
all parameters in qe
On Fri, 2018-04-13 at 13:20 +0100, Daniel P. Berrangé wrote:
> On Fri, Apr 13, 2018 at 02:17:45PM +0200, Andrea Bolognani wrote:
> > On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote:
> > > diff --git a/guests/vars/projects/libvirt-glib.yml
> > > b/guests/vars/projects/libvirt-glib.yml
>
On Wed, Apr 11, 2018 at 04:41:21PM +0200, Jiri Denemark wrote:
We reached the point when qemuMigrationParamsApply is the only API which
sends migration parameters and capabilities to QEMU. Thus all but the
TLS parameters can be set before we ask QEMU for the current values of
all parameters in qe
On Fri, Apr 13, 2018 at 01:15:17PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 5 +
> src/domain.c| 49
> +
> 2 files changed, 54 insertions(+)
>
> diff --git a/data/org.l
On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote:
> diff --git a/guests/vars/projects/libvirt-glib.yml
> b/guests/vars/projects/libvirt-glib.yml
> index 13a5128..bb21ae0 100644
> --- a/guests/vars/projects/libvirt-glib.yml
> +++ b/guests/vars/projects/libvirt-glib.yml
> @@ -5,4 +5,6 @@
On Wed, Apr 11, 2018 at 04:41:18PM +0200, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_monitor.c | 14 --
src/qemu/qemu_monitor.h | 3 --
src/qemu/qemu_monitor_json.c | 53
src/qemu/qemu_monitor_json.h | 3 --
4 files ch
On Fri, Apr 13, 2018 at 03:02:07PM +0300, Nikolay Shirokovskiy wrote:
>
>
> On 13.04.2018 12:07, Daniel P. Berrangé wrote:
> > On Tue, Apr 03, 2018 at 03:01:22PM +0300, Nikolay Shirokovskiy wrote:
> >> *Temporary snapshot API*
> >>
> >> In previous version it is called 'Fleece API' after qemu ter
On Wed, Apr 11, 2018 at 04:41:20PM +0200, Jiri Denemark wrote:
Prefer xbzrle-cache-size migration parameter over the special
migrate-set-cache-size QMP command.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c| 6 ++---
src/qemu/qemu_migration_params.c | 42 +--
The icotool command is used to manipulate Windows icon files.
Signed-off-by: Andrea Bolognani
---
guests/vars/mappings.yml | 4
guests/vars/projects/virt-viewer.yml | 1 +
2 files changed, 5 insertions(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index e0
On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote:
> Daniel P. Berrangé (2):
> Enable mingw build for libvirt-glib project
> Enable mingw build for virt-viewer project
>
> guests/vars/mappings.yml | 72
> +++
> guests/vars/projects/libvi
13.04.2018 00:35, John Snow wrote:
On 04/12/2018 08:26 AM, Vladimir Sementsov-Ogievskiy wrote:
1. It looks unsafe to use nbd server + backup(sync=none) on same node,
synchronization is needed, like in block/replication, which uses
backup_wait_for_overlapping_requests, backup_cow_request_begin,
On Wed, Apr 11, 2018 at 04:41:19PM +0200, Jiri Denemark wrote:
Originally QEMU provided query-migrate-cache-size and
migrate-set-cache-size QMP commands for querying/setting XBZRLE cache
size. In version 2.11 QEMU added support for XBZRLE cache size to the
general migration paramaters commands.
On Wed, Apr 11, 2018 at 04:41:17PM +0200, Jiri Denemark wrote:
Rework all remaining callers of qemuMonitorSetMigrationCapability to use
the new qemuMonitorSetMigrationCapabilities API.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 11 ---
tests/qemumonitorjsontest.c
On Fri, Apr 13, 2018 at 01:15:14PM +0200, Katerina Koukiou wrote:
> This method is not tested for now since the test driver
> doesn't support this API.
>
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 6
> src/domain.c| 72
> +++
On Mon, Apr 02, 2018 at 07:04:25PM -0400, John Ferlan wrote:
>
>
> On 04/02/2018 10:18 AM, Brijesh Singh wrote:
> > QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted
> > VMs on AMD platform using SEV feature. The various inputs required to
> > launch SEV guest is provided t
13.04.2018 11:51, Nikolay Shirokovskiy wrote:
On 13.04.2018 03:04, John Snow wrote:
On 04/12/2018 10:08 AM, Vladimir Sementsov-Ogievskiy wrote:
I propose, not to say that bitmap represents a checkpoint. It is simpler
to say (and it reflects the reality) that bitmap is a difference between
two
On Wed, Apr 11, 2018 at 04:41:14PM +0200, Jiri Denemark wrote:
All users of migration parameters are supposed to use APIs provided by
qemu_migration_params.c without having to worry about the internals.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 5 +
src/qemu/qemu_mi
On Fri, Apr 13, 2018 at 01:15:12PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 5 +++--
> src/domain.c| 22 +-
> test/test_domain.py | 7 +++
> 3 files changed, 31 insertions(+), 3 deletio
On Wed, Apr 11, 2018 at 04:41:13PM +0200, Jiri Denemark wrote:
The new name is qemuMigrationParamsApply and it will soon become the
only API which will send all requested migration parameters and
capabilities to QEMU. All other qemuMigrationParams* APIs will just
operate on the qemuMigrationParam
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 25 +
2 files changed, 31 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index eec9dcb..838ebed 100644
--- a/data/org.libvirt.D
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 29 +
test/test_domain.py | 2 +-
3 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xm
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 4
src/domain.c| 21 +
2 files changed, 25 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index c672053..074dd62 100644
--- a/data/org.libvirt.Domain.
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 36
2 files changed, 42 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 41814c7..36167d8 100644
--- a/data/or
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 5 +
src/domain.c| 24
test/test_domain.py | 15 +++
3 files changed, 44 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 5 +
src/domain.c| 49 +
2 files changed, 54 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index 5c310ad..c672053 100644
--- a
This method is not tested for now since the test driver
doesn't suport this API.
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 25 +
2 files changed, 31 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/
This method is not tested for now since the test driver
doesn't support this API.
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6
src/domain.c| 72 +
2 files changed, 78 insertions(+)
diff --git a/data/org.li
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 6 ++
src/domain.c| 31 +++
2 files changed, 37 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index c3c64fa..10c4da8 100644
--- a/data/org.lib
Changes from v2:
Adjusted to reviews.
Katerina Koukiou (20):
Implement Setter for Autostart property for Domain interface
Implement SchedulerType property for Domain Interface
Implement MemoryStats for Domain Interface
Implement AttachDevice method for Domain Interface
Implement DetachDe
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 5 +++--
src/domain.c| 22 +-
test/test_domain.py | 7 +++
3 files changed, 31 insertions(+), 3 deletions(-)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 5 +
src/domain.c| 24
test/test_domain.py | 2 ++
3 files changed, 31 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index e29cd4c..f300
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Domain.xml | 4
src/domain.c| 23 +++
test/test_domain.py | 3 +++
3 files changed, 30 insertions(+)
diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
index b8ee5b8..df9fb
On Thu, Apr 12, 2018 at 04:32:59PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 6 ++
> src/domain.c| 25 +
> 2 files changed, 31 insertions(+)
[...]
> +static void
> +virtDBusDomainMigrateSet
On Thu, Apr 12, 2018 at 04:32:58PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 6 ++
> src/domain.c| 28
> 2 files changed, 34 insertions(+)
[...]
> +static void
> +virtDBusDomainMigrate
On Thu, Apr 12, 2018 at 04:32:56PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 6 ++
> src/domain.c| 37 +
> 2 files changed, 43 insertions(+)
[...]
> +static void
> +virtDBusDoma
On Wed, Apr 11, 2018 at 04:41:11PM +0200, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c| 31 ---
src/qemu/qemu_migration_params.c | 9 +++--
src/qemu/qemu_migration_params.h | 1 +
3 files changed, 20 insertions(+), 21 dele
On Wed, Apr 11, 2018 at 04:41:10PM +0200, Jiri Denemark wrote:
The new name is qemuMigrationParamsEnableTLS.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c| 12 ++--
src/qemu/qemu_migration_params.c | 18 +-
src/qemu/qemu_migration_params.h | 16 +++
On Wed, Apr 11, 2018 at 04:41:07PM +0200, Jiri Denemark wrote:
The code can be merged directly in qemuMigrationParamsAddTLSObjects.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c| 15 ---
src/qemu/qemu_migration_params.c | 73 ++--
src/qemu/qemu
On Wed, Apr 11, 2018 at 04:41:06PM +0200, Jiri Denemark wrote:
Restore the original values of all migration parameters we store in
qemuDomainJobObj instead of explicitly resting only a limited set of
them.
The result is not strictly equivalent to the previous code wrt reseting
TLS state because
On Thu, Apr 12, 2018 at 04:32:55PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 6 ++
> src/domain.c| 37 +
> 2 files changed, 43 insertions(+)
>
> diff --git a/data/org.libvirt.Dom
On Thu, Apr 12, 2018 at 19:49:15 +, Clementine Hayat wrote:
> Add a function named virDomainObjCheckIsActive in src/conf/domain_conf.c.
> It calls virDomainObjIsActive, raises error and returns.
>
> There is a lot of occurence of this pattern and it will save 3 lines on
> each call. Knowing th
On Wed, Apr 11, 2018 at 04:41:04PM +0200, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domain.c | 6 +++---
src/qemu/qemu_domain.h | 8 +---
src/qemu/qemu_process.c | 4 ++--
3 files changed, 10 insertions(+), 8 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.
On Thu, Apr 12, 2018 at 04:32:52PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 6 ++
> src/domain.c| 29 +
> test/test_domain.py | 2 +-
> 3 files changed, 36 insertions(+), 1 dele
On Thu, Apr 12, 2018 at 04:32:50PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou
> ---
> data/org.libvirt.Domain.xml | 6 ++
> src/domain.c| 31 +++
> 2 files changed, 37 insertions(+)
[...]
> +static void
> +virtDBusDomainMigr
On Wed, Apr 11, 2018 at 04:41:01PM +0200, Jiri Denemark wrote:
Currently migration parameters are stored in a structure which mimics
the QEMU migration parameters handled by query-migrate-parameters and
migrate-set-parameters. The new structure will become a libvirt's
abstraction on top of QEMU m
On 13.04.2018 01:10, John Snow wrote:
>
> On 04/12/2018 04:58 AM, Nikolay Shirokovskiy wrote:
>> On 11.04.2018 19:32, Eric Blake wrote:
>>> On 04/03/2018 07:01 AM, Nikolay Shirokovskiy wrote:
>
>
> [snip]
>
>
>>>
>>> I'm trying to figure out how BlockCheckpoint and BlockSnapshots relate.
>>>
Jim,
while fixing and debugging virNetSocketNewListenTCP in master, I had
breakpoints in virNetSocketNewListenTCP and virNetSocketNew. After
starting a migration the receiving libvirtd went into both functions. I
hit continue a 4 times, but forgot to do it for the fifth call to let it
proceed. lib
On 13.04.2018 00:16, John Snow wrote:
>
>
> On 04/03/2018 08:01 AM, Nikolay Shirokovskiy wrote:
>> Hi, all.
>>
>>
>>
On Tue, Apr 03, 2018 at 03:01:22PM +0300, Nikolay Shirokovskiy wrote:
> *Temporary snapshot API*
>
> In previous version it is called 'Fleece API' after qemu terms and I'll still
> use BlockSnapshot prefix for commands as in previous RFC instead of
> TmpSnapshots which I inclined more now.
>
> vi
On Wed, Apr 11, 2018 at 04:40:57PM +0200, Jiri Denemark wrote:
Our *Free functions usually do not take a double pointer and the caller
has to make sure it doesn't use the stale pointer after the *Free
function returns.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_driver.c | 2 +-
sr
On Wed, Apr 11, 2018 at 04:40:56PM +0200, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration_params.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
Thank you.
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
--
li
1 - 100 of 116 matches
Mail list logo
