Re: [libvirt] [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

On 04/20/18 18:37, Markus Armbruster wrote: > Laszlo Ersek writes: > >> On 04/20/18 14:53, Markus Armbruster wrote: >>> Laszlo Ersek writes: >> >> [snip] >> The targets with softmmu are: aarch64, alpha, arm, cris, hppa, i386, lm32, m68k,

[libvirt] [qemu RFC v3 2/3] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget

Now that we have @SysEmuTarget, it makes sense to restict @TargetInfo.@arch to valid sysemu targets at the schema level. Cc: "Daniel P. Berrange" Cc: David Gibson Cc: Eric Blake Cc: Gerd Hoffmann Cc: Kashyap

[libvirt] [qemu RFC v3 3/3] qapi: add "firmware.json"

Add a schema that describes the different uses and properties of virtual machine firmware. Each firmware executable installed on a host system should come with at least one JSON file that conforms to this schema. Each file informs the management applications about - the firmware's properties and

[libvirt] [qemu RFC v3 0/3] qapi: add "firmware.json"

This version seeks to address the RFCv2 feedback. Changes are noted per patch. Cc: "Daniel P. Berrange" Cc: David Gibson Cc: Eric Blake Cc: Gerd Hoffmann Cc: Kashyap Chamarthy Cc: Markus

[libvirt] [qemu RFC v3 1/3] qapi: add SysEmuTarget to "common.json"

We'll soon need an enumeration type that lists all the softmmu targets that QEMU (the project) supports. Introduce @SysEmuTarget to "common.json". Cc: "Daniel P. Berrange" Cc: David Gibson Cc: Eric Blake Cc: Gerd Hoffmann

Re: [libvirt] [RFC v2] external (pull) backup API

On 04/20/2018 01:24 PM, John Snow wrote: >>> Why is option 3 unworkable, exactly?: >>> >>> (3) Checkpoints exist as structures only with libvirt. They are saved >>> and remembered in the XML entirely. >>> >>> Or put another way: >>> >>> Can you explain to me why it's important for libvirt to be

Re: [libvirt] [PATCH v2 2/2] conf: Rework/rename virDomainObjListFindByIDRef

On 04/20/2018 07:08 AM, John Ferlan wrote: Rework the code such that virDomainObjListFindByID will always return a locked/ref counted object so that the callers can always do the same cleanup logic to call virDomainObjEndAPI. Makes accessing the objects much more consistent. NB: There were 2

Re: [libvirt] [PATCH v2 1/2] conf: Rework/rename virDomainObjListFindByUUIDRef

On 04/20/2018 07:08 AM, John Ferlan wrote: Now that every caller is using virDomainObjListFindByUUIDRef, let's just remove it and keep the name as virDomainObjListFindByUUID. Signed-off-by: John Ferlan --- src/bhyve/bhyve_driver.c | 4 ++--

Re: [libvirt] [PATCH] git: add config file telling git-publish how to send patches

On Fri, Apr 20, 2018 at 11:36:03 +0100, Daniel Berrange wrote: > On Fri, Apr 20, 2018 at 12:22:35PM +0200, Martin Kletzander wrote: > > On Thu, Apr 19, 2018 at 05:29:22PM +0100, Daniel P. Berrangé wrote: > > > On Thu, Apr 19, 2018 at 06:11:20PM +0200, Martin Kletzander wrote: > > > > On Thu, Apr

Re: [libvirt] [RFC PATCH 22/30] tests: qemublock: Add tests for all other format without special options

On Fri, Apr 20, 2018 at 13:55:35 +0200, Kevin Wolf wrote: > Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > > Similarly to the 'raw' case add tests for bochs, cloop, dmg, ploop, vdi > > vhd, and vpc. Covering all supproted non-backing formats. > > > > Note that the JSON name for 'ploop'

Re: [libvirt] [RFC v2] external (pull) backup API

On 04/20/2018 08:22 AM, Nikolay Shirokovskiy wrote: > > > On 19.04.2018 20:28, John Snow wrote: >> >> >> On 04/16/2018 06:20 AM, Vladimir Sementsov-Ogievskiy wrote: >>> >>> So my point is: if we are going to implement something complicated, >>> let's implement entirely what we want, not a

[libvirt] [PATCH 1/4] Revert "util: virlog: Introduce wildcard to log filters"

This reverts commit 8daa593b0741452a78daea76075254ae7d3c6ab6. There are two undesirable aspects to the impl - Only a bare wildcard is permitted - The wildcard match is not performed in the order listed --- src/remote/libvirtd.conf | 4 +--- src/util/virlog.c| 44

[libvirt] [PATCH 2/4] log: rename virLogFlags to virLogFilterFlags to match docs

Signed-off-by: Daniel P. Berrangé --- src/util/virlog.c | 2 +- src/util/virlog.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 5810643e1b..5262d613f6 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c

[libvirt] [PATCH 3/4] log: support logging using shell wildcard syntax

Rather than specialcasing handling of the '*' character, use fnmatch() to get normal shell wildcard syntax, as described in 'man glob(7)'. Signed-off-by: Daniel P. Berrangé --- src/util/virlog.c | 17 +++-- src/util/virlog.h | 1 + 2 files changed, 16

[libvirt] [PATCH 4/4] log: update docs for daemons to improve user understanding

Strongly recommend against use of the log_levels setting since it creates overly verbose logs and has a serious performance impact. Describe the log filter syntax better and mention use of shell glob syntax. Also provide more realistic example of good settings to use. The libvirtd example is

[libvirt] [PATCH 0/4] Reimplement logging wildcards to use full shell glob syntax

This series provides a more generalized support for wildcards in logging and removes the ordering constraint. Daniel P. Berrangé (4): Revert "util: virlog: Introduce wildcard to log filters" log: rename virLogFlags to virLogFilterFlags to match docs log: support logging using shell wildcard

Re: [libvirt] [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

Laszlo Ersek writes: > On 04/20/18 14:53, Markus Armbruster wrote: >> Laszlo Ersek writes: > > [snip] > >>> The targets with softmmu are: aarch64, alpha, arm, cris, hppa, i386, >>> lm32, m68k, microblaze, microblazeel, mips, mips64, mips64el, mipsel, >>>

Re: [libvirt] [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

On 04/20/18 14:53, Markus Armbruster wrote: > Laszlo Ersek writes: [snip] >> The targets with softmmu are: aarch64, alpha, arm, cris, hppa, i386, >> lm32, m68k, microblaze, microblazeel, mips, mips64, mips64el, mipsel, >> moxie, nios2, or1k, ppc, ppc64, ppcemb, riscv32,

[libvirt] [PATCH 0/3] qemu: Allow disabling ROM for PCI devices

All the details are in the bug report referenced in 2/3. Andrea Bolognani (3): conf: Add rom.enabled attribute for PCI devices qemu: Format rom.enabled attribute for PCI devices news: Document rom.enabled attribute for PCI devices docs/formatdomain.html.in | 3 +++

Re: [libvirt] [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

On 04/20/18 12:41, Gerd Hoffmann wrote: Since your schema is likely to end up just being a file in docs/specs, > >>> I think it would be useful to have this as part of the schema. Should >>> be easy then to write up a small utility then which takes a json file as >>> input and translates

[libvirt] [PATCH 3/3] news: Document rom.enabled attribute for PCI devices

Signed-off-by: Andrea Bolognani --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index dec3f134ce..de95d919a2 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -56,6 +56,16 @@ host-passthrough CPU

[libvirt] [PATCH 2/3] qemu: Format rom.enabled attribute for PCI devices

The attribute can be used to disable ROM loading completely for a device. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1425058 Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 13 ++--

[libvirt] [PATCH 1/3] conf: Add rom.enabled attribute for PCI devices

The attribute can be used to disable ROM loading completely for a device. Signed-off-by: Andrea Bolognani --- docs/formatdomain.html.in | 3 +++ docs/schemas/domaincommon.rng | 5 + src/conf/device_conf.h| 1 + src/conf/domain_conf.c| 26

Re: [libvirt] [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

On 04/20/18 11:34, Daniel P. Berrangé wrote: > On Fri, Apr 20, 2018 at 10:11:08AM +0200, Laszlo Ersek wrote: >> On 04/19/18 11:12, Daniel P. Berrangé wrote: >>> On Thu, Apr 19, 2018 at 10:39:32AM +0200, Laszlo Ersek wrote: On 04/19/18 09:56, Daniel P. Berrangé wrote: > On Thu, Apr 19,

Re: [libvirt] [dbus PATCH] Fix GError memory leaks

On Fri, Apr 20, 2018 at 02:14:43PM +0200, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- src/gdbus.c | 8 src/main.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital

Re: [libvirt] [dbus PATCH 3/3] domain: Implement SetPerfEvents method

On Fri, 2018-04-20 at 14:17 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > data/org.libvirt.Domain.xml | 6 ++ > src/domain.c| 31 +++ > 2 files changed, 37 insertions(+) Reviewed-by: Katerina Koukiou

Re: [libvirt] --disable-nls is ignored in master

On Fri, Apr 20, 2018 at 04:37:34PM +0200, Olaf Hering wrote: > It seems some of the recent changes for 'po' broke the --disable-nls > configure option. > I expect no locales will be installed with --disable-nls, but they are > installed anyway. > This leads to the well known "error: Installed

Re: [libvirt] [dbus PATCH 2/3] util: Introduce virtDBusUtilGVariantToTypedParams

On Fri, 2018-04-20 at 14:17 +0200, Pavel Hrdina wrote: > This converts D-Bus dictionary into virTypedParameters. > > Signed-off-by: Pavel Hrdina > --- > src/util.c | 83 > ++ > src/util.h | 6 + > 2 files

[libvirt] --disable-nls is ignored in master

It seems some of the recent changes for 'po' broke the --disable-nls configure option. I expect no locales will be installed with --disable-nls, but they are installed anyway. This leads to the well known "error: Installed (but unpackaged) file(s) found:" failure. I tested

Re: [libvirt] [dbus PATCH 1/3] util: Introduce virtDBusUtilTypedParams

On Fri, 2018-04-20 at 14:17 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/util.c | 6 ++ > src/util.h | 11 +++ > 2 files changed, 17 insertions(+) Reviewed-by: Katerina Koukiou -- libvir-list mailing list

Re: [libvirt] [PATCH v2 4/4] qemu: remove pointless connect retry logic in agent

On 04/18/2018 01:30 PM, Daniel P. Berrangé wrote: > When the agent code was first introduced back in > > commit c160ce3316852a797d7b06b4ee101233866e69a9 > Author: Daniel P. Berrange > Date: Wed Oct 5 18:31:54 2011 +0100 > > QEMU guest agent support > > there

Re: [libvirt] [PATCH v2 3/4] qemu: don't retry connect() if doing FD passing

On 04/18/2018 01:30 PM, Daniel P. Berrangé wrote: > Since libvirt called bind() and listen() on the UNIX socket, it is > guaranteed that connect() will immediately succeed, if QEMU is running > normally. It will only fail if QEMU has closed the monitor socket by > mistake or if QEMU has exited,

Re: [libvirt] [PATCH v2 2/4] qemu: support passing pre-opened UNIX socket listen FD

On 04/18/2018 01:30 PM, Daniel P. Berrangé wrote: > There is a race condition when spawning QEMU where libvirt has spawned > QEMU but the monitor socket is not yet open. Libvirt has to repeatedly > try to connect() to QEMU's monitor until eventually it succeeds, or > times out. We use kill() to

Re: [libvirt] [dbus PATCH v2] Implement GetAllDomainStats method for Connect Interface

On Fri, Apr 20, 2018 at 02:56:18PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Connect.xml | 7 +++ > src/connect.c| 47 > > 2 files changed, 54 insertions(+)

[libvirt] [PATCH v2 0/2] Rename/remove virDomainObjListFindBy{UUID|ID}Ref

These were actually posted before as part of a larger series to rework/rename virDomainObjListFindBy{UUID|ID}Ref as patches 19 and 20: https://www.redhat.com/archives/libvir-list/2018-March/msg00508.html https://www.redhat.com/archives/libvir-list/2018-March/msg00509.html Even though it's only 6

[libvirt] [PATCH v2 2/2] conf: Rework/rename virDomainObjListFindByIDRef

Rework the code such that virDomainObjListFindByID will always return a locked/ref counted object so that the callers can always do the same cleanup logic to call virDomainObjEndAPI. Makes accessing the objects much more consistent. NB: There were 2 callers (lxcDomainLookupByID and

[libvirt] [PATCH v2 1/2] conf: Rework/rename virDomainObjListFindByUUIDRef

Now that every caller is using virDomainObjListFindByUUIDRef, let's just remove it and keep the name as virDomainObjListFindByUUID. Signed-off-by: John Ferlan --- src/bhyve/bhyve_driver.c | 4 ++-- src/conf/virdomainobjlist.c | 35 +++

Re: [libvirt] [jenkins-ci PATCH 4/5] guests: Create ccache symlink farm

On Thu, 2018-04-19 at 17:36 +0200, Martin Kletzander wrote: > > Replicate the setup in the user's ~/.ccache directory so > > that it works across all guests. With the linke farm in > > s/linke/link/ ? Close: I actually meant to write Linkle[1] :P > > - name: '{{ flavor }}: Configure ccache' > >

Re: [libvirt] [PATCH] remote: remove obsolete & incorrect comment from libvirtd.conf

On Fri, 2018-04-20 at 12:34 +0100, Daniel P. Berrangé wrote: > The libvirtd.conf file has a comment pointing people to format.html > which has nothing todo with the configuration file format. s/todo/to do/ > It also has a comment about tests/daemon-conf which no longer exists, > and even if it

[libvirt] [dbus PATCH v2] Implement GetAllDomainStats method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 7 +++ src/connect.c| 47 2 files changed, 54 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index

Re: [libvirt] [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

Laszlo Ersek writes: > On 04/19/18 09:56, Daniel P. Berrangé wrote: >> On Thu, Apr 19, 2018 at 09:48:36AM +0200, Markus Armbruster wrote: >>> Laszlo Ersek writes: >>> On 04/18/18 10:47, Markus Armbruster wrote: > Laszlo Ersek

Re: [libvirt] [dbus PATCH 7/8] Implement GetCPUModelNames method for Connect Interface

On Fri, 2018-04-20 at 13:39 +0200, Ján Tomko wrote: > On Thu, Apr 19, 2018 at 03:58:06PM +0200, Katerina Koukiou wrote: > > Signed-off-by: Katerina Koukiou > > --- > > data/org.libvirt.Connect.xml | 7 +++ > > src/connect.c| 35 > >

Re: [libvirt] [RFC v2] external (pull) backup API

On 19.04.2018 20:28, John Snow wrote: > > > On 04/16/2018 06:20 AM, Vladimir Sementsov-Ogievskiy wrote: >> >> So my point is: if we are going to implement something complicated, >> let's implement entirely what we want, not a semi-solution. Otherwise, >> implement a minimal and simple thing,

[libvirt] [dbus PATCH 0/3] Introduce GVariant to TypedParams helper

Pavel Hrdina (3): util: Introduce virtDBusUtilTypedParams util: Introduce virtDBusUtilGVariantToTypedParams domain: Implement SetPerfEvents method data/org.libvirt.Domain.xml | 6 +++ src/domain.c| 31 src/util.c | 89

[libvirt] [dbus PATCH 3/3] domain: Implement SetPerfEvents method

Signed-off-by: Pavel Hrdina --- data/org.libvirt.Domain.xml | 6 ++ src/domain.c| 31 +++ 2 files changed, 37 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index 0f3d926..a57b05a 100644

[libvirt] [dbus PATCH 2/3] util: Introduce virtDBusUtilGVariantToTypedParams

This converts D-Bus dictionary into virTypedParameters. Signed-off-by: Pavel Hrdina --- src/util.c | 83 ++ src/util.h | 6 + 2 files changed, 89 insertions(+) diff --git a/src/util.c b/src/util.c index

[libvirt] [dbus PATCH 1/3] util: Introduce virtDBusUtilTypedParams

Signed-off-by: Pavel Hrdina --- src/util.c | 6 ++ src/util.h | 11 +++ 2 files changed, 17 insertions(+) diff --git a/src/util.c b/src/util.c index b21f2c5..ac965c4 100644 --- a/src/util.c +++ b/src/util.c @@ -20,6 +20,12 @@ virtDBusErrorQuark(void) return

[libvirt] [dbus PATCH] Fix GError memory leaks

Signed-off-by: Pavel Hrdina --- src/gdbus.c | 8 src/main.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gdbus.c b/src/gdbus.c index cb06813..3407116 100644 --- a/src/gdbus.c +++ b/src/gdbus.c @@ -86,7 +86,7 @@

Re: [libvirt] [REPOST PATCH 2/2] vz: Use virDomainObjListFindBy{UUID|ID}Ref

On 20.04.2018 14:44, John Ferlan wrote: > > > On 04/20/2018 02:53 AM, Nikolay Shirokovskiy wrote: >> >> >> On 02.04.2018 16:21, John Ferlan wrote: >>> For vzDomainLookupByID and vzDomainLookupByUUID let's >>> return a locked and referenced @vm object so that callers >>> can then use the common

Re: [libvirt] [PATCH jenkins-ci] Add missing job dependencies for libvirt-glib/virt-viewer mingw builds

On Fri, 2018-04-20 at 12:27 +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > projects/libvirt-glib.yaml | 4 ++-- > projects/virt-viewer.yaml | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Whoops. Reviewed-by: Andrea Bolognani

Re: [libvirt] [RFC PATCH 22/30] tests: qemublock: Add tests for all other format without special options

Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > Similarly to the 'raw' case add tests for bochs, cloop, dmg, ploop, vdi > vhd, and vpc. Covering all supproted non-backing formats. > > Note that the JSON name for 'ploop' maps to 'parallels' and 'vhd' maps > to 'vhdx'. Your -drive lines

Re: [libvirt] [REPOST PATCH 2/2] vz: Use virDomainObjListFindBy{UUID|ID}Ref

On 04/20/2018 02:53 AM, Nikolay Shirokovskiy wrote: > > > On 02.04.2018 16:21, John Ferlan wrote: >> For vzDomainLookupByID and vzDomainLookupByUUID let's >> return a locked and referenced @vm object so that callers >> can then use the common and more consistent virDomainObjEndAPI >> in order

Re: [libvirt] [dbus PATCH 7/8] Implement GetCPUModelNames method for Connect Interface

On Thu, Apr 19, 2018 at 03:58:06PM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 7 +++ src/connect.c| 35 +++ tests/test_connect.py| 4 3 files changed, 46

[libvirt] [PATCH] remote: remove obsolete & incorrect comment from libvirtd.conf

The libvirtd.conf file has a comment pointing people to format.html which has nothing todo with the configuration file format. It also has a comment about tests/daemon-conf which no longer exists, and even if it did exist such comment is not relevant to end users when this file is installed in

[libvirt] [PATCH jenkins-ci] Add missing job dependencies for libvirt-glib/virt-viewer mingw builds

Signed-off-by: Daniel P. Berrangé --- projects/libvirt-glib.yaml | 4 ++-- projects/virt-viewer.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/projects/libvirt-glib.yaml b/projects/libvirt-glib.yaml index 2d0e721..286d25b 100644 ---

[libvirt] [PATCH] remote: always build generated source files

The generated source files for dispatching libvirtd RPC messages contain translations and are thus listed in POTFILES. This means they are required in order to build libvirt.pot. Rather than changing the files that go into libvirt.pot dynamically, just unconditionally build the remote driver

Re: [libvirt] [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

> > > Since your schema is likely to end up just being a file in docs/specs, > > I think it would be useful to have this as part of the schema. Should > > be easy then to write up a small utility then which takes a json file as > > input and translates that into qemu command line options. > >

Re: [libvirt] [PATCH] git: add config file telling git-publish how to send patches

On Fri, Apr 20, 2018 at 12:22:35PM +0200, Martin Kletzander wrote: > On Thu, Apr 19, 2018 at 05:29:22PM +0100, Daniel P. Berrangé wrote: > > On Thu, Apr 19, 2018 at 06:11:20PM +0200, Martin Kletzander wrote: > > > On Thu, Apr 19, 2018 at 10:06:45AM +0100, Daniel P. Berrangé wrote: > > > > On Thu,

Re: [libvirt] [PATCH] git: add config file telling git-publish how to send patches

On Thu, Apr 19, 2018 at 05:29:22PM +0100, Daniel P. Berrangé wrote: On Thu, Apr 19, 2018 at 06:11:20PM +0200, Martin Kletzander wrote: On Thu, Apr 19, 2018 at 10:06:45AM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 19, 2018 at 10:55:01AM +0200, Peter Krempa wrote: > > On Wed, Apr 18, 2018 at

Re: [libvirt] [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

On Fri, Apr 20, 2018 at 11:46:24AM +0200, Gerd Hoffmann wrote: > Hi, > > > Since your schema is likely to end up just being a file in docs/specs, > > rather than directly part of our existnig qapi schema, I suggest we just > > ignore whats there. Just define an arch enum in your spec which is

Re: [libvirt] [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

Hi, > Since your schema is likely to end up just being a file in docs/specs, > rather than directly part of our existnig qapi schema, I suggest we just > ignore whats there. Just define an arch enum in your spec which is right, > and let someone else worry about fixing the mess I think it

Re: [libvirt] [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

On Fri, Apr 20, 2018 at 10:11:08AM +0200, Laszlo Ersek wrote: > On 04/19/18 11:12, Daniel P. Berrangé wrote: > > On Thu, Apr 19, 2018 at 10:39:32AM +0200, Laszlo Ersek wrote: > >> On 04/19/18 09:56, Daniel P. Berrangé wrote: > >>> On Thu, Apr 19, 2018 at 09:48:36AM +0200, Markus Armbruster wrote:

Re: [libvirt] [PATCH 2/2] storage: Check qemu-img encryption type capability

On Thu, Apr 19, 2018 at 02:21:43PM -0400, John Ferlan wrote: > > [...] > > >> Oh, OK - well I didn't find that to be obvious... So there is a way > >> using secret objects to create a qcow[2] encrypted volume? > > > > Sure, the exact same syntax as with luks volumes - you just specify > >

Re: [libvirt] [PATCH v2 4/4] vmware: Use virDomainObjListFindBy{UUID|ID}Ref

On Mon, Apr 02, 2018 at 09:16:40AM -0400, John Ferlan wrote: > For vmwareDomObjFromDomainLocked and vmwareDomainLookupByID > let's return a locked and referenced @vm object so that callers > can then use the common and more consistent virDomainObjEndAPI > in order to handle cleanup rather than

Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

Am 20.04.2018 um 10:50 hat Peter Krempa geschrieben: > On Fri, Apr 20, 2018 at 10:41:50 +0200, Kevin Wolf wrote: > > Am 20.04.2018 um 09:56 hat Peter Krempa geschrieben: > > > Is there a special need to use 'host_cdrom' explicitly if the CDROM > > > drive is used? That would complicate things

[libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard

https://bugzilla.redhat.com/show_bug.cgi?id=1480668 QEMU has this new feature memory-backend-file.discard-data=yes which is a nifty optimization. Basically, when qemu is quitting or on memory hotplug it calls munmap() and close() on the file that is backing the memory. However, this does not mean

[libvirt] [PATCH v4 1/5] qemuMonitorJSONGetDeviceProps: Separate props processing

The code that processes list of device properties is going to be reused. Therefore put it into a separate function. Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor_json.c | 59 +++- 1 file changed, 36 insertions(+), 23

[libvirt] [PATCH v4 3/5] qemu_capabilities: Introduce QEMU_CAPS_QOM_LIST_PROPERTIES

This capability tracks if qemu has "qom-list-properties" monitor command. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 +

[libvirt] [PATCH v4 0/5] Enable memory-backend-file.discard-data

v4 of: https://www.redhat.com/archives/libvir-list/2018-April/msg01897.html diff to v3: - patches 1 and 2 from the original set are pushed, - patch 3 is split into two (1 and 2 in this series), - Introduced new QEMU_CAPS_QOM_LIST_PROPERTIES - virQEMUCapsProbeQMPGenericProps is called iff the

[libvirt] [PATCH v4 4/5] qemu_capabilities: Introduce QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD

This capability tracks if memory-backend-file has discard-data attribute or not. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 18 + src/qemu/qemu_capabilities.h |1 + .../caps_2.12.0.aarch64.replies

[libvirt] [PATCH v4 2/5] qemu_monitor: Introduce qemuMonitorGetObjectProps

Now that we've gotten rid of misleading names we can introduce qemuMonitorGetObjectProps() function which queries -object properties. Again, some parts of code can be reused. Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor.c | 13 +

Re: [libvirt] [PATCH v2 3/4] vmware: Add more descriptive error message on Find failure

On Mon, Apr 02, 2018 at 09:16:39AM -0400, John Ferlan wrote: > If vmwareDomainLookupByID or vmwareDomainLookupByName fails > to find a vm, let's be a bit more descriptive by providing > the failing id or name in the error message. > > Signed-off-by: John Ferlan > --- >

Re: [libvirt] [PATCH v2 2/4] vmware: Create accessors to virDomainObjListFindByUUID

On Mon, Apr 02, 2018 at 09:16:38AM -0400, John Ferlan wrote: > Rather than repeat code throughout, create and use a couple of > accessors in order to lookup by UUID. > > Signed-off-by: John Ferlan > --- > src/vmware/vmware_driver.c | 180 >

[libvirt] [PATCH] Qemu driver: Support network-backed pflash disks.

So far libvirt domain XML only allows local filepaths that can be used to specify a loader element or its matching NVRAM disk. Given that Vms may themselves move across hypervisor hosts, it should be possible to allocate loaders/NVRAM disks on network storage for uninterrupted access.

Re: [libvirt] [qemu RFC v2] qapi: add "firmware.json"

On 04/20/18 10:47, Paolo Bonzini wrote: > On 20/04/2018 03:03, David Gibson wrote: >>> This also implies I shouldn't add "openbios" separately, which was >>> suggested earlier by Gerd -- according to >>> , OpenBIOS is another >>> implementation of OFW. >> >>

[libvirt] [PATCH] Qemu driver: Support network-backed pflash disks.

This implements support for firmware loader & NVRAM disks over network-backed disks. As discussed in https://www.redhat.com/archives/libvir-list/2018-March/msg01721.html, the patch embeds the spec for disks in and elements as well. Currently, the source type is annotated by introducing a

Re: [libvirt] [PATCH v2 1/4] vmware: Properly clean up in vmwareDomainLookupByName

On Mon, Apr 02, 2018 at 09:16:37AM -0400, John Ferlan wrote: > The virDomainObjListFindByName returns a locked and reffed > domain object, all we did was unlock it, leaving an extra > ref. Use the virDomainObjEndAPI to cleanup instead. > > Signed-off-by: John Ferlan > --- >

Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

On Fri, Apr 20, 2018 at 10:41:50 +0200, Kevin Wolf wrote: > Am 20.04.2018 um 09:56 hat Peter Krempa geschrieben: > > Is there a special need to use 'host_cdrom' explicitly if the CDROM > > drive is used? That would complicate things since we don't know when > > that will happen. > > You don't get

Re: [libvirt] [RFC PATCH 02/30] qemu: domain: Format storage source node names into private data

On Fri, Apr 20, 2018 at 10:32:11 +0200, Kevin Wolf wrote: > Am 20.04.2018 um 09:45 hat Peter Krempa geschrieben: > > On Fri, Apr 20, 2018 at 09:30:16 +0200, Kevin Wolf wrote: > > > Am 19.04.2018 um 17:24 hat Peter Krempa geschrieben: > > > > Save and restore node names if we know them in the

Re: [libvirt] [qemu RFC v2] qapi: add "firmware.json"

On 20/04/2018 03:03, David Gibson wrote: >> This also implies I shouldn't add "openbios" separately, which was >> suggested earlier by Gerd -- according to >> , OpenBIOS is another >> implementation of OFW. > > Right. Although I think OpenBIOS and SLOF

Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

Am 20.04.2018 um 09:56 hat Peter Krempa geschrieben: > Is there a special need to use 'host_cdrom' explicitly if the CDROM > drive is used? That would complicate things since we don't know when > that will happen. You don't get the full CD-ROM passthrough functionality with host_device.

Re: [libvirt] [RFC PATCH 02/30] qemu: domain: Format storage source node names into private data

Am 20.04.2018 um 09:45 hat Peter Krempa geschrieben: > On Fri, Apr 20, 2018 at 09:30:16 +0200, Kevin Wolf wrote: > > Am 19.04.2018 um 17:24 hat Peter Krempa geschrieben: > > > Save and restore node names if we know them in the status XML so that we > > > don't need to recalculate them or don't

Re: [libvirt] [RFC PATCH 15/30] qemu: block: Add support for creating 'format' layer for blockdev-add

Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > When using blockdev-add and friends, libvirt will need to create also > properties for the qcow2/raw/... format handler in qemu. This patch adds > the infrastructure and implements all formats known to libvirt including > all properties which

Re: [libvirt] [RFC PATCH 14/30] [RFC] qemu: block: Always set discard for storage nodes

Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > According to my research it seems that qemu always sets discard for the > storage nodes. Replicate this in our generator. > --- > src/qemu/qemu_block.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

Re: [libvirt] [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

On 04/19/18 11:12, Daniel P. Berrangé wrote: > On Thu, Apr 19, 2018 at 10:39:32AM +0200, Laszlo Ersek wrote: >> On 04/19/18 09:56, Daniel P. Berrangé wrote: >>> On Thu, Apr 19, 2018 at 09:48:36AM +0200, Markus Armbruster wrote: Laszlo Ersek writes: > On 04/18/18

Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

On Fri, Apr 20, 2018 at 09:45:40 +0200, Kevin Wolf wrote: > Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > > 'file' backend in qemu supports few more options than the current > > implementation. Extract it so that changes don't pollute the code. > > > > Signed-off-by: Peter Krempa

Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > 'file' backend in qemu supports few more options than the current > implementation. Extract it so that changes don't pollute the code. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_block.c | 16 +--- >

Re: [libvirt] [RFC PATCH 02/30] qemu: domain: Format storage source node names into private data

On Fri, Apr 20, 2018 at 09:30:16 +0200, Kevin Wolf wrote: > Am 19.04.2018 um 17:24 hat Peter Krempa geschrieben: > > Save and restore node names if we know them in the status XML so that we > > don't need to recalculate them or don't lose them in some cases. > > > > Signed-off-by: Peter Krempa

Re: [libvirt] [RFC PATCH 02/30] qemu: domain: Format storage source node names into private data

Am 19.04.2018 um 17:24 hat Peter Krempa geschrieben: > Save and restore node names if we know them in the status XML so that we > don't need to recalculate them or don't lose them in some cases. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_domain.c | 12

Re: [libvirt] [PATCH 0/2] vmx: start reading/writing CPU topology

On Thu, Apr 19, 2018 at 03:03:36PM +0200, Pino Toscano wrote: Read/write only cpuid.coresPerSocket for now. Pino Toscano (2): vmx: convert cpuid.coresPerSocket for CPU topology vmx: write cpuid.coresPerSocket back from CPU topology src/vmx/vmx.c | 57

Re: [libvirt] [PATCH v3 3/5] qemu_monitor: Introduce qemuMonitorGetObjectProps

On 04/19/2018 06:04 PM, Ján Tomko wrote: > On Thu, Apr 19, 2018 at 04:00:25PM +0200, Michal Privoznik wrote: >> Now that we've gotten rid of misleading names we can introduce >> qemuMonitorGetObjectProps() function which queries -object >> properties. Again, some parts of code can be reused. >> >

Re: [libvirt] [PATCH] tests: Xen: use qemu-system-i386 for emulator

On Wed, Apr 11, 2018 at 01:25:10PM -0600, Jim Fehlig wrote: Many of the old xm and sexpr test files used qemu-dm as the emulator. Modern Xen systems no longer use the old, forked qemu-dm, instead preferring the distro provided qemu or an "upstream" qemu that is built when the Xen tools are

Re: [libvirt] [REPOST PATCH 2/2] vz: Use virDomainObjListFindBy{UUID|ID}Ref

On 02.04.2018 16:21, John Ferlan wrote: > For vzDomainLookupByID and vzDomainLookupByUUID let's > return a locked and referenced @vm object so that callers > can then use the common and more consistent virDomainObjEndAPI > in order to handle cleanup rather than needing to know that the >

Re: [libvirt] [REPOST PATCH 1/2] vz: Unify vzDomObjFromDomain{Ref}

On 02.04.2018 16:21, John Ferlan wrote: > Rather than have two API's doing different things for different > callers, let's make one API that will always return a locked and > ref counted object. That way, the callers will always know that > they must call virDomainObjEndAPI and not have to