Function qemuMonitorGetCPUModelBaseline exposed to carry out a QMP
query-cpu-model-baseline transaction with QEMU.
QEMU determines a baseline CPU Model from two input CPU Models to
complete the query-cpu-model-baseline transaction.
---
src/qemu/qemu_monitor.c | 13 +
src/qemu/qemu
Function qemuMonitorJSONBuildCPUModelInfoToJSON
builds and returns JSON of form
{"model": {"name": "IvyBridge", "props": {}}}
from qemuMonitorCPUModelInfo.
Function qemuMonitorJSONBuildCPUModelInfoToJSON
returns virJsonValuePtr on success and NULL on failure.
---
src/qemu/qemu_monitor_json.c
This is part of resolution of:
https://bugzilla.redhat.com/show_bug.cgi?id=1511999
Signed-off-by: Chris Venteicher
diff to v1:
- Replaced c++ style comments with c style
- qemuMonitorJSONGetCPUModelInfo{ToJSON,FromJSON} use To/From form
- qemuMonitorJSONGetCPUModelInfo{ToJSON,FromJSON} return p
Extract cpu_model parsing code from qemuMonitorJSONGetCPUModelExpansion
into a separate helper for future reuse.
---
src/qemu/qemu_monitor_json.c | 77 +++-
1 file changed, 47 insertions(+), 30 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qe
On 04/30/2018 02:28 PM, Julio Faracco wrote:
> Hi John,
>
> Thanks for your comments.
> Probably, this is a requirement for test driver too.
> See my tests:
>
> # virsh -c test:///default
>
> virsh # shutdown test
> Domain test is being shutdown
>
> virsh # domrename test /
>
On 04/30/2018 01:25 PM, Chris Venteicher wrote:
> Please see responses below.
>
> New patchset with all recommended changes will be sent soon.
>
> Chris
>
> - Original Message -
>> From: "John Ferlan"
>> To: "Chris Venteicher" , libvir-list@redhat.com
>> Sent: Friday, April 27, 2018 1
On 04/18/2018 10:44 AM, Nikolay Shirokovskiy wrote:
> Signed-off-by: Nikolay Shirokovskiy
> ---
> src/libvirt_private.syms | 1 +
> src/util/virerror.c | 12 +---
> src/util/virerror.h | 1 +
> 3 files changed, 11 insertions(+), 3 deletions(-)
>
NACK, you should be using v
On 04/18/2018 10:44 AM, Nikolay Shirokovskiy wrote:
> Block job abort operation can not handle properly qemu crashes
> when waiting for abort/pivot completion. Deadlock scenario is next:
>
> - qemuDomainBlockJobAbort waits for pivot/abort completion
> - qemu crashes, then qemuProcessBeginStopJob
On 04/18/2018 10:44 AM, Nikolay Shirokovskiy wrote:
> Clearing beingDestroyed right after acquiring job condition is racy.
> It is not known when EOF will be delivired. Let's keep this flag
delivered
> set. This makes possible to make a clear distinction between monitor
> errors/eofs and domain
On 04/18/2018 10:44 AM, Nikolay Shirokovskiy wrote:
> Commit [1] dropped support for synchronous block job cancel.
> This patch erases remnants from comments.
>
> [1] commit 2350d101 "qemu: Remove support for legacy block jobs"
>
> Signed-off-by: Nikolay Shirokovskiy
> ---
> src/qemu/qemu_dri
On 04/18/2018 10:44 AM, Nikolay Shirokovskiy wrote:
> lastError.code is used as flag in qemu monitor. Unfortunately
> due to temporary OOM conditions (very unlikely through as thread local
> error is allocated on first use) we can fail to set this flag
> in case of monitor eofs/errors. This can c
Hi John,
Thanks for your comments.
Probably, this is a requirement for test driver too.
See my tests:
# virsh -c test:///default
virsh # shutdown test
Domain test is being shutdown
virsh # domrename test /
Domain successfully renamed
virsh # start /
error: Failed to
On 30/04/18 18:11, Andrea Bolognani wrote:
- $(MAKE) check VG="libtool --mode=execute $(VALGRIND)"
+ $(MAKE) check VG="$(LIBTOOL) --mode=execute $(VALGRIND)"
What we might want to do here is call $(top_srcdir)/libtool
instead of plain libtool, so that we run the local copy installed
Please see responses below.
New patchset with all recommended changes will be sent soon.
Chris
- Original Message -
> From: "John Ferlan"
> To: "Chris Venteicher" , libvir-list@redhat.com
> Sent: Friday, April 27, 2018 1:41:03 PM
> Subject: Re: [libvirt] [PATCHv2 3/3] qemu_monitor: quer
On Mon, 2018-04-30 at 16:01 +0100, Maciej Wolny wrote:
> This caused an error on Debian, where the tool is called libtoolize, not
> libtool.
Can you please share the specific error message?
libtool and libtoolize are two different programs: the latter is
used to setup a project for using the form
On Mon, 2018-04-30 at 10:59 +0100, Daniel P. Berrangé wrote:
> On Mon, Apr 30, 2018 at 11:47:33AM +0200, Andrea Bolognani wrote:
> > Mocking canonicalize_file_name() causes a linking error:
> >
> > ../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function
> > `canonicalize_file_name':
> >
The latter is a glibc extension that's not available on other
operating systems, notably FreeBSD.
So far we have worked around the issue through gnulib, but that
makes it difficult to use mocking in our test suite, so just
drop it in favor of the portable alternative.
Signed-off-by: Andrea Bologn
Changes from [v1]:
* drop the virnetsockettest changes, since the relationship
between the errors seen on FreeBSD and IPv4 clients connecting
to IPv6 sockets has turned out to be just a red herring;
* fix the mocking instead of dropping test cases that don't work
without it.
[v1] https://
Since we've dropped all usages from the library, mocking it has
become entirely pointless.
Signed-off-by: Andrea Bolognani
---
tests/virpcimock.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/tests/virpcimock.c b/tests/virpcimock.c
index 9a5e6b4cec..001b320683 100644
Now what we have removed all uses of the function, we want to
prevent it from creeping back in.
Signed-off-by: Andrea Bolognani
---
cfg.mk | 10 ++
1 file changed, 10 insertions(+)
diff --git a/cfg.mk b/cfg.mk
index c3d18279ce..7ffa10f563 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -462,6 +462,
There are only a couple issues preventing it from working on
other platform such as FreeBSD. Let's fix them.
With the mocking in place, qemumemlocktest and qemuxml2xmltest
can finally succeed on FreeBSD.
This commit is best viewed with 'git show -w'.
Signed-off-by: Andrea Bolognani
---
tests/v
We're no longer using canonicalize_file_name(), so we have no
use for the gnulib module any more.
Signed-off-by: Andrea Bolognani
---
bootstrap.conf | 1 -
1 file changed, 1 deletion(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 9559922fce..fb56872c4d 100644
--- a/bootstrap.conf
+++ b/b
Clang complains about it:
virfilewrapper.c:270:27: error: second argument to 'va_arg'
is of promotable type 'mode_t' (aka 'unsigned short'); this
va_arg has undefined behavior because arguments will be
promoted to 'int' [-Werror,-Wvarargs]
mode = va_arg(ap, mode_t);
We need to use VIR_MOCK_REAL_INIT_VERSIONED() and ask for a
specific version of the symbol here, because the implementation
dlsym() returns by default on Linux is unsuitable for our use.
Signed-off-by: Andrea Bolognani
---
tests/virpcimock.c | 34 ++
1 file change
This will be used later on to choose the modern implementation
of the functions we need to mock instead of the default, and
broken, one.
Signed-off-by: Andrea Bolognani
---
tests/virmock.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/tests/virmock.h b/tests/virmock.h
index
On Mon, Apr 30, 2018 at 06:16:53PM +0300, Yoni Bettan wrote:
> Signed-off-by: Yoni Bettan
> ---
> updater/virt-tools/config.ini | 6 ++
> updater/virt-tools/images/ybettan.png | Bin 0 -> 105973 bytes
> 2 files changed, 6 insertions(+)
> create mode 100644 updater/virt-tools/images
On 04/27/2018 11:24 AM, Daniel P. Berrangé wrote:
> Today the nwfilter driver is entangled with the virt drivers in both
> directions. At various times when rebuilding filters nwfilter will call
> out to the virt driver to iterate over running guest's NICs. This has
> caused very complicated lock o
Signed-off-by: Yoni Bettan
---
updater/virt-tools/config.ini | 6 ++
updater/virt-tools/images/ybettan.png | Bin 0 -> 105973 bytes
2 files changed, 6 insertions(+)
create mode 100644 updater/virt-tools/images/ybettan.png
diff --git a/updater/virt-tools/config.ini b/updater/virt-t
This caused an error on Debian, where the tool is called libtoolize, not
libtool.
---
tests/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7b93fbde6..05db6b119 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -48
On 04/23/2018 08:28 AM, Daniel P. Berrangé wrote:
> Strongly recommend against use of the log_levels setting since it
> creates overly verbose logs and has a serious performance impact.
>
> Describe the log filter syntax better and mention use of shell
> glob syntax. Also provide more realistic
On 04/23/2018 08:28 AM, Daniel P. Berrangé wrote:
> Rather than specialcasing handling of the '*' character, use fnmatch()
> to get normal shell wildcard syntax, as described in 'man glob(7)'.
>
> To get an indication of the performance impact of using globs instead
> of plain string matches, a
On Fri, Apr 27, 2018 at 16:25:08 +0100, Daniel P. Berrangé wrote:
> Use the virNWFilterBinding struct in the gentech driver code
> directly.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/nwfilter/nwfilter_dhcpsnoop.c | 35 +++---
> src/nwfilter/nwfilter_driver.c | 21 +++-
> s
On 04/23/2018 08:28 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> src/util/virlog.c | 2 +-
> src/util/virlog.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Looks like your v1 already had an R-b too from Erik...
Reviewed-by: John Ferlan
John
--
On Fri, Apr 27, 2018 at 16:25:07 +0100, Daniel P. Berrangé wrote:
> The vm name is not needed for any functional requirement, but it will be
> useful when debugging problems to identify which VM is associated with a
> filter, since UUID is not human friendly.
>
> Signed-off-by: Daniel P. Berrangé
On Fri, Apr 27, 2018 at 16:25:06 +0100, Daniel P. Berrangé wrote:
> The virDomainNet struct contains everything related to configuring a
> guest network device. Out of all of this info, only 5 fields are
> relevant to configuring network filters. It will be more convenient for
> future changes to t
On Fri, Apr 27, 2018 at 16:25:05 +0100, Daniel P. Berrangé wrote:
> The filter parameters were not correctly free'd when an error hits while
> adding to the hash table.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/nwfilter/nwfilter_gentech_driver.c | 22 ++
> src/nwfilte
On Fri, Apr 27, 2018 at 04:25:03PM +0100, Daniel P. Berrangé wrote:
> The virNWFilterIPAddrLearnReq type should only be used by the IP address
> learning code, so can live in the implementation file instead of header
> file.
>
> Signed-off-by: Daniel P. Berrangé
> ---
Could have split the patch i
On Mon, Apr 30, 2018 at 09:20:29AM -0400, John Ferlan wrote:
>
>
> On 04/25/2018 11:55 AM, Marc Hartmayer wrote:
> > 1. Don't allocate if there is nothing that needs to be
> >allocated. Especially as the result of calling calloc(0, ...) is
> >implementation-defined.
>
> Following VIR_ALL
On Fri, Apr 27, 2018 at 16:25:04 +0100, Daniel P. Berrangé wrote:
> There is a bunch of left over code in the nwfilter driver related to
> monitoring firewalld over dbus, that is no longer used since the
> conversion to use virFirewall APIs.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/conf
On Fri, Apr 27, 2018 at 16:25:03 +0100, Daniel P. Berrangé wrote:
> The virNWFilterIPAddrLearnReq type should only be used by the IP address
> learning code, so can live in the implementation file instead of header
> file.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/nwfilter/nwfilter_gente
On Fri, Apr 27, 2018 at 16:25:02 +0100, Daniel P. Berrangé wrote:
> All the code now just uses the virHashTablePtr type directly.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/conf/domain_conf.c | 2 +-
> src/conf/domain_conf.h | 2 +-
> src/conf/nwfilter_co
On 04/23/2018 09:26 PM, Julio Faracco wrote:
> The 'domrename' command needs to check if the new domain name contains
> the slash character. This character is not accepted by libvirt XML
> definition because it is an invalid char (see Cole's commit b1fc6a7b7).
> This commit enhace the 'domrename'
On 04/25/2018 11:55 AM, Marc Hartmayer wrote:
> 1. Don't allocate if there is nothing that needs to be
>allocated. Especially as the result of calling calloc(0, ...) is
>implementation-defined.
Following VIR_ALLOC_N one finds :
VIR_ALLOC_N(params_val, nparams)
which equates to
# defin
On Fri, Apr 27, 2018 at 16:25:01 +0100, Daniel P. Berrangé wrote:
> This removes the virNWFilterHashTableFree, virNWFilterHashTablePut
> and virNWFilterHashTableRemove methods, in favour of just calling
> the virHash APIs directly.
>
> The virNWFilterHashTablePut method was unreasonably complex be
On Fri, Apr 27, 2018 at 16:25:00 +0100, Daniel P. Berrangé wrote:
> The virNWFilterHashTable struct only contains a single virHashTable
> member since
>
> commit 293d4fe2f11db98c91175525056c8883725d4b22
> Author: Daniel P. Berrange
> Date: Mon Mar 24 16:35:23 2014 +
>
> Remove po
On Mon, Apr 30, 2018 at 10:08:05 +0100, Daniel Berrange wrote:
> On Mon, Apr 30, 2018 at 10:42:24AM +0200, Peter Krempa wrote:
> > On Fri, Apr 27, 2018 at 10:55:56 +0100, Daniel Berrange wrote:
> > > On Thu, Apr 26, 2018 at 04:51:49PM +0200, Peter Krempa wrote:
> > > > Since libvirt is currently no
On Mon, Apr 30, 2018 at 13:36:39 +0200, Peter Krempa wrote:
> When a VM is destroyed while being migrated (waiting in
> qemuMigrationSrcWaitForCompletion) the private object cleanup code frees
> the 'current' job info. Since the migration code attempts to setup
> various aspects of the current job
When a VM is destroyed while being migrated (waiting in
qemuMigrationSrcWaitForCompletion) the private object cleanup code frees
the 'current' job info. Since the migration code attempts to setup
various aspects of the current job even on failure this results into a
crash.
Job data is cleared in q
On Fri, Apr 27, 2018 at 16:26:36 +0200, Peter Krempa wrote:
> When a VM is destroyed while being migrated (waiting in
> qemuMigrationSrcWaitForCompletion) the private object cleanup code frees
> the 'current' job info. Since the migration code attempts to setup
> various aspects of the current job
On Mon, Apr 30, 2018 at 11:47:33AM +0200, Andrea Bolognani wrote:
> On Fri, 2018-04-27 at 16:35 +0100, Daniel P. Berrangé wrote:
> > On Fri, Apr 27, 2018 at 05:21:21PM +0200, Andrea Bolognani wrote:
> > > When hostdevs are involved, libvirt needs to poke into sysfs to
> > > collect some information
On Fri, 2018-04-27 at 16:35 +0100, Daniel P. Berrangé wrote:
> On Fri, Apr 27, 2018 at 05:21:21PM +0200, Andrea Bolognani wrote:
> > When hostdevs are involved, libvirt needs to poke into sysfs to
> > collect some information about them; since that pseudo-filesystem
> > doesn't exist on platforms o
On Thu, Apr 26, 2018 at 04:51:46PM +0200, Peter Krempa wrote:
> The NBD server in qemu supports TLS transport. Detect this capability.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_capabilities.c | 2 ++
> src/qemu/qemu_capabilities.h | 1 +
>
On Mon, Apr 30, 2018 at 10:42:24AM +0200, Peter Krempa wrote:
> On Fri, Apr 27, 2018 at 10:55:56 +0100, Daniel Berrange wrote:
> > On Thu, Apr 26, 2018 at 04:51:49PM +0200, Peter Krempa wrote:
> > > Since libvirt is currently not able to setup the NBD migration stream
> > > secured by TLS we should
On Thu, Apr 26, 2018 at 04:51:47PM +0200, Peter Krempa wrote:
> To allow encryption of the non-shared storage migration NBD connection
> we will need to instantiated the NBD server with the TLS env.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_migration.c| 2 +-
> src/qemu/qemu_moni
On Thu, Apr 26, 2018 at 04:51:48PM +0200, Peter Krempa wrote:
> Use the TLS env for migration when starting the NBD server if TLS is
> enabled for migration.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_migration.c | 19 ---
> 1 file changed, 16 insertions(+), 3 deletion
On Mon, Apr 30, 2018 at 10:29:46AM +0200, Andrea Bolognani wrote:
> On Fri, 2018-04-27 at 16:32 +0100, Daniel P. Berrangé wrote:
> > > +/* From FreeBSD's inet6(4):
> > > + *
> > > + * By default, FreeBSD does not route IPv4 traffic to AF_INET6
> > > + * sockets.
On Fri, Apr 27, 2018 at 10:55:56 +0100, Daniel Berrange wrote:
> On Thu, Apr 26, 2018 at 04:51:49PM +0200, Peter Krempa wrote:
> > Since libvirt is currently not able to setup the NBD migration stream
> > secured by TLS we should not allow such migration since data would be
> > transferred unencryp
On Fri, 2018-04-27 at 16:32 +0100, Daniel P. Berrangé wrote:
> > +/* From FreeBSD's inet6(4):
> > + *
> > + * By default, FreeBSD does not route IPv4 traffic to AF_INET6
> > + * sockets. The default behavior intentionally violates RFC2553
> > + * for s
58 matches
Mail list logo
