Signed-off-by: Yoni Bettan
---
updater/virt-tools/config.ini | 6 ++
updater/virt-tools/images/ybettan.png | Bin 0 -> 8965 bytes
2 files changed, 6 insertions(+)
create mode 100644 updater/virt-tools/images/ybettan.png
diff --git a/updater/virt-tools/config.ini b/updater/virt-too
On 04/30/2018 07:14 PM, Daniel P. Berrangé wrote:
On Mon, Apr 30, 2018 at 06:16:53PM +0300, Yoni Bettan wrote:
Signed-off-by: Yoni Bettan
---
updater/virt-tools/config.ini | 6 ++
updater/virt-tools/images/ybettan.png | Bin 0 -> 105973 bytes
2 files changed, 6 insertions(+)
On Tue, May 01, 2018 at 10:04:35AM +0300, Yoni Bettan wrote:
> Signed-off-by: Yoni Bettan
> ---
> updater/virt-tools/config.ini | 6 ++
> updater/virt-tools/images/ybettan.png | Bin 0 -> 8965 bytes
> 2 files changed, 6 insertions(+)
> create mode 100644 updater/virt-tools/images/y
On 05/01/2018 11:30 AM, Daniel P. Berrangé wrote:
On Tue, May 01, 2018 at 10:04:35AM +0300, Yoni Bettan wrote:
Signed-off-by: Yoni Bettan
---
updater/virt-tools/config.ini | 6 ++
updater/virt-tools/images/ybettan.png | Bin 0 -> 8965 bytes
2 files changed, 6 insertions(+)
Fixes "can't find libtool" error when running valgrind checks.
---
tests/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7b93fbde6..923d84ed3 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -487,7 +487,7 @@ VALGR
The test code for UNIX and TCP sockets will need to be rewritten and
extended later, and will benefit from code sharing.
Signed-off-by: Daniel P. Berrangé
---
tests/virnetsockettest.c | 120 ---
1 file changed, 51 insertions(+), 69 deletions(-)
diff -
The current socket test is rather crazy in that it sets up a server
listening for sockets and then runs a client connect call, relying on
the fact that the kernel will accept this despite the application
not having called accept() yet. It then closes the client socket and
calls accept() on the serv
The virnetsockettest is somewhat unreliable on FreeBSD. On a single CPU
guest it will appear to run successfully, as you add more CPUs though it
will increasingly get failures. Testing on a 8 CPU guest gives 100%
failure rate.
Daniel P. Berrangé (2):
tests: merge code for UNIX and TCP socket tes
I'll change the $SUBJ to be:
conf: Enable TPM CRB interface in the domain XML
[follows convention we typically use]
On 04/26/2018 01:42 PM, Stefan Berger wrote:
> Enable the TPM CRB to be specified in the domain XML. This
> now allows to describe the TPM device like this:
>
>
>
>
On 04/26/2018 01:42 PM, Stefan Berger wrote:
> QEMU on x86_64 (since v2.12) can support tpm-crb devices.
> Introduce qemu capabilities for this device.
>
> Signed-off-by: Stefan Berger
> ---
> src/qemu/qemu_capabilities.c | 5 +
> src/qemu/qemu_capabilities.h
I'll change the $subj to be:
qemu: Add tpm-crb QEMU device to the command line
On 04/26/2018 01:42 PM, Stefan Berger wrote:
> Add a test case for the formation of the tpm-crb QEMU device
> command line.
And the commit msg changes to:
Alter qemuBuildTPMDevStr to format the tpm-crb on the comman
On 05/01/2018 05:34 AM, Maciej Wolny wrote:
Fixes "can't find libtool" error when running valgrind checks.
The subject no longer matches the patch.
---
tests/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7b93fbde
On 04/30/2018 10:01 AM, Maciej Wolny wrote:
This caused an error on Debian, where the tool is called libtoolize, not
libtool.
The commit message is incorrect (we are not trying to call the installed
libtoolize program, but the just-built libtool script that resides in
our tree), but the fix i
On 05/01/2018 09:13 AM, John Ferlan wrote:
On 04/26/2018 01:42 PM, Stefan Berger wrote:
QEMU on x86_64 (since v2.12) can support tpm-crb devices.
Introduce qemu capabilities for this device.
Signed-off-by: Stefan Berger
---
src/qemu/qemu_capabilities.c | 5 +
src/q
Fixes "can't find libtool" error when running valgrind checks.
---
tests/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7b93fbde6..05db6b119 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -487,7 +487,7 @@ VALGR
On 04/30/2018 10:55 PM, Chris Venteicher wrote:
> This is part of resolution of:
> https://bugzilla.redhat.com/show_bug.cgi?id=1511999
>
> Signed-off-by: Chris Venteicher
>
> diff to v1:
> - Replaced c++ style comments with c style
> - qemuMonitorJSONGetCPUModelInfo{ToJSON,FromJSON} use To/Fr
On 05/01/2018 09:14 AM, John Ferlan wrote:
I'll change the $subj to be:
qemu: Add tpm-crb QEMU device to the command line
On 04/26/2018 01:42 PM, Stefan Berger wrote:
Add a test case for the formation of the tpm-crb QEMU device
command line.
And the commit msg changes to:
Alter qemuBuildTPMD
The 'domrename' command needs to check if the new domain name contains
the slash character. This character is not accepted by libvirt XML
definition because it is an invalid char (see Cole's commit b1fc6a7b7).
This commit enhace the 'domrename' command adding this check.
Resolves: https://bugzilla
As QEMU driver, test driver does not accept slashes inside domain names.
This commit fixes this problem checking slashes inside the new name when
'domrename' is executed.
Signed-off-by: Julio Faracco
---
src/test/test_driver.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/test/te
Dismiss this packages guys.
I forgot --cover-letter, since I was submitting only one single patch
to fix this problem.
Sending a V5 soon.
--
Julio Cesar Faracco
2018-05-01 12:47 GMT-03:00 Julio Faracco :
> The 'domrename' command needs to check if the new domain name contains
> the slash charac
As QEMU driver, test driver does not accept slashes inside domain names.
This commit fixes this problem checking slashes inside the new name when
'domrename' is executed.
Signed-off-by: Julio Faracco
---
src/test/test_driver.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/test/te
The commits enhace the 'domrename' command of QEMU and Test drivers to
avoid slashes chars inside the new domain name.
Julio Faracco (2):
qemu: avoid slash characters to the new domain name.
test: avoid slash characters to the new domain name.
src/qemu/qemu_driver.c | 6 ++
src/test/test
The 'domrename' command needs to check if the new domain name contains
the slash character. This character is not accepted by libvirt XML
definition because it is an invalid char (see Cole's commit b1fc6a7b7).
This commit enhace the 'domrename' command adding this check.
Resolves: https://bugzilla
After 0.7.5 release, libssh deprecated ssh_get_publickey() method to
introduce ssh_get_server_publickey(). This commit check the current
version of libssh and use the proper method during the compilation.
See the error:
make[3]: Entering directory '/home/julio/Desktop/virt/libvirt/src'
CC
Add SDL graphics gl attribute, modify the domain XML schema, add a
test, modify the documentation to include the new option.
Signed-off-by: Maciej Wolny
---
docs/schemas/domaincommon.rng | 8 +
src/conf/domain_conf.c | 41
Quoting John Ferlan (2018-05-01 08:57:08)
>
>
> On 04/30/2018 10:55 PM, Chris Venteicher wrote:
> > This is part of resolution of:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1511999
> >
> > Signed-off-by: Chris Venteicher
> >
> > diff to v1:
> > - Replaced c++ style comments with c style
On 05/01/2018 11:56 AM, Julio Faracco wrote:
> The commits enhace the 'domrename' command of QEMU and Test drivers to
> avoid slashes chars inside the new domain name.
>
> Julio Faracco (2):
> qemu: avoid slash characters to the new domain name.
> test: avoid slash characters to the new doma
On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Everything besides the top of the chain is readonly. Track this when
> parsing the XML and detecting the chain from the disk. Also fix the
> state when taking snapshots.
>
> All other cases where the top image is changed already preserve the
> readon
On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Save and restore node names if we know them in the status XML so that we
> don't need to recalculate them or don't lose them in some cases.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_domain.c| 12
> tests
On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Few things which are currently stored the virDomainDiskDef structure are
> actually relevant for the storage source as well. Add the fields with a
> note that they are just mirror of the values from the disk.
>
> Signed-off-by: Peter Krempa
> ---
>
On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Some properties don't make sense to be configured for every single layer
> of the backing chain, but to avoid needing to pass the disk structure we
> will copy them to the individual virStorageSource-s
Source's ???
or just without the -s
>
> Zero
On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Add a flag denoting that a virStorageSource is going to be used as a
> floppy image. This will be useful in cases where the user passes in
> files which shall be exposed as an image to the guest.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qem
On 04/25/2018 11:15 AM, Peter Krempa wrote:
> 'file' backend in qemu supports few more options than the current
> implementation. Extract it so that changes don't pollute the code.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_block.c | 16 +---
> 1 file changed, 13 inserti
On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_block.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
Reviewed-by: John Ferlan
John
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/
On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Move it to the validation callback and make it more robust. This will
> also put the checks in the correct place to use with -blockdev.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_command.c | 14 --
> src/qemu/qemu_domain.c |
On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Handle VIR_STORAGE_TYPE_DIR in qemuBlockStorageSourceGetBackendProps so
> that a 'vvfat' driver is used, which emulates a FAT filesystem
> containing the folders.
>
> qemu requires us to add it as a storage layer, since a 'raw' layer is
> usually put
On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/util/virfile.c | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
Reviewed-by: John Ferlan
John
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/l
On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Add detection mechanism which will allow to check whether a path to a
> block device is a physical CDROM drive. This will be useful once we will
> need to pass it to hypervisors.
>
> The linux implementation uses an ioctl to do the detection, while t
38 matches
Mail list logo
