[libvirt] [PATCH 06/12] virsh: Create macros for VSH_OT_ARGV "domain" option

2018-05-04 Thread Lin Ma
Signed-off-by: Lin Ma --- tools/virsh-domain-monitor.c | 3 +++ tools/virsh-domain.c | 3 +++ tools/virsh-snapshot.c | 3 +++ tools/virsh.h| 9 + 4 files changed, 18 insertions(+) diff --git a/tools/virsh-domain-monitor.c

[libvirt] [PATCH 07/12] virsh: Apply macro for current VSH_OT_ARGV "domain" options

2018-05-04 Thread Lin Ma
Signed-off-by: Lin Ma --- tools/virsh-domain-monitor.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index e4a21534cb..1e1ee60198 100644 --- a/tools/virsh-domain-monitor.c +++

[libvirt] [PATCH 05/12] vshReadlineParse: Ignore vshReadlineOptionsGenerator for VSH_OT_ARGV options

2018-05-04 Thread Lin Ma
Currently the VSH_OT_ARGV options don't support complete, But some of VSH_OT_ARGV options are gonna support complete in upcoming patches. Once applied the upcoming completion patches for VSH_OT_ARGV options, If we don't ignore VSH_OT_ARGV here, The vshReadlineOptionsGenerator will be called,

[libvirt] [PATCH 02/12] virsh: Conditionally Ignore the first entry in list of completions

2018-05-04 Thread Lin Ma
The first entry in the returned array is the substitution for TEXT. It causes unnecessary output if other commands or options share the same prefix, e.g. $ virsh des des desc destroy or $ virsh domblklist --d --d--details --domain This patch fixes the above issue.

Re: [libvirt] [jenkins-ci PATCH] projects: Run libvirt's 'make check' on all machines

2018-05-04 Thread Daniel P . Berrangé
On Thu, May 03, 2018 at 06:25:19PM +0200, Andrea Bolognani wrote: > Up until now, we had to skip it on FreeBSD due to some > portability issues in the test suite, but as of libvirt > commit 0b86e23d2569 they've all been fixed. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [sandbox PATCH] maint: Drop autobuild.sh

2018-05-04 Thread Daniel P . Berrangé
On Thu, May 03, 2018 at 06:28:13PM +0200, Andrea Bolognani wrote: > On Thu, 2018-05-03 at 16:59 +0100, Daniel P. Berrangé wrote: > > On Thu, May 03, 2018 at 05:58:07PM +0200, Andrea Bolognani wrote: > > > Renaming the scripts sounds good to me. Just come up with > > > a reasonable name and I'll go

Re: [libvirt] Expose vfio device display/migration to libvirt and above, was Re: [PATCH 0/3] sample: vfio mdev display devices.

2018-05-04 Thread Daniel P . Berrangé
On Thu, May 03, 2018 at 12:58:00PM -0600, Alex Williamson wrote: > Hi, > > The previous discussion hasn't produced results, so let's start over. > Here's the situation: > > - We currently have kernel and QEMU support for the QEMU vfio-pci >display option. > > - The default for this option

Re: [libvirt] [PATCH 0/3] sample: vfio mdev display devices.

2018-05-04 Thread Erik Skultety
On Fri, Apr 27, 2018 at 12:15:01AM +0530, Kirti Wankhede wrote: > > > On 4/26/2018 1:22 AM, Dr. David Alan Gilbert wrote: > > * Alex Williamson (alex.william...@redhat.com) wrote: > >> On Wed, 25 Apr 2018 21:00:39 +0530 > >> Kirti Wankhede wrote: > >> > >>> On 4/25/2018 4:29

[libvirt] [dbus PATCH v2 7/9] Remove reason to string translation in virtDBusEventsDomainTrayChange

2018-05-04 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 2 +- src/events.c| 15 +-- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index 6448a46..98c018c 100644

[libvirt] [dbus PATCH v2 4/9] Change DomainEvent argument from string to unsigned int

2018-05-04 Thread Katerina Koukiou
Modify the relevant tests to comply with the new signal. Note: argument matching in connect_to_signal method is only usable with string and thus had to be refactored. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 2 +- src/events.c |

[libvirt] [dbus PATCH v2 2/9] Abandon usage of all *TypeToString functions in connect.c

2018-05-04 Thread Katerina Koukiou
Converting ENUMS to str can be user friendly though it can be problematic in matters of backward compatibility. In particular when some ENUM in libvirt API will introduce a new constant, libvirt-dbus will fail with: size of array ‘_GStaticAssertCompileTimeAssertion_5’ is negative So using ints

[libvirt] [dbus PATCH v2 6/9] Remove virtDBusUtilEnum{From, From}String functions

2018-05-04 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- src/util.c | 27 --- src/util.h | 28 2 files changed, 55 deletions(-) diff --git a/src/util.c b/src/util.c index a9d130e..4efa3ec 100644 --- a/src/util.c +++ b/src/util.c @@ -214,33

[libvirt] [dbus PATCH v2 9/9] Remove reason to string translation in virtDBusEventsDomainDiskChange

2018-05-04 Thread Katerina Koukiou
Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 2 +- src/events.c| 17 ++--- 2 files changed, 3 insertions(+), 16 deletions(-) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index 3627b1b..a09e868

[libvirt] [dbus PATCH v2 8/9] Remove state to string translation in virtDBusDomainGetState

2018-05-04 Thread Katerina Koukiou
Adjust tests to comply with the new type. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 2 +- src/domain.c| 31 +-- tests/libvirttest.py| 12 tests/test_domain.py| 10 +- 4

[libvirt] [dbus PATCH v2 3/9] Abandon usage of all *TypeToString functions in network.c

2018-05-04 Thread Katerina Koukiou
Converting ENUMS to str can be user friendly though it can be problematic in matters of backward compatibility. In particular when some ENUM in libvirt API will introduce a new constant, libvirt-dbus will fail with: size of array ‘_GStaticAssertCompileTimeAssertion_5’ is negative So using ints

[libvirt] [dbus PATCH v2 0/9] Remove all enum->string and string->enum code

2018-05-04 Thread Katerina Koukiou
Changes from v1: * Added the three last patches Katerina Koukiou (9): Abandon usage of all *TypeToString functions in domain.c Abandon usage of all *TypeToString functions in connect.c Abandon usage of all *TypeToString functions in network.c Change DomainEvent argument from string to

[libvirt] [dbus PATCH v2 5/9] Change NetworkEvent argument from string to unsigned int

2018-05-04 Thread Katerina Koukiou
Modify the relevant tests to comply with the new signal. Note: argument matching in connect_to_signal method is only usable with string and thus had to be refactored. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 2 +- src/events.c |

[libvirt] [dbus PATCH v2 1/9] Abandon usage of all *TypeToString functions in domain.c

2018-05-04 Thread Katerina Koukiou
Converting ENUMS to str can be user friendly though it can be problematic in matters of backward compatibility. In particular when some ENUM in libvirt API will introduce a new constant, libvirt-dbus will fail with: size of array ‘_GStaticAssertCompileTimeAssertion_5’ is negative So using ints

Re: [libvirt] Expose vfio device display/migration to libvirt and above, was Re: [PATCH 0/3] sample: vfio mdev display devices.

2018-05-04 Thread Erik Skultety
On Thu, May 03, 2018 at 12:58:00PM -0600, Alex Williamson wrote: > Hi, > > The previous discussion hasn't produced results, so let's start over. > Here's the situation: > > - We currently have kernel and QEMU support for the QEMU vfio-pci >display option. > > - The default for this option is

<    1   2