Re: [libvirt] [PATCH] xenconfig: xm: Fix checking for extra in parser

On 05/11/2018 02:33 AM, Filip Alac wrote: Parser assumed extra was always present when root was specified. Fixed by handling root and extra separately. Contributions to libvirt must now assert they are in compliance with the DCO. See https://libvirt.org/hacking.html --- src/xenconfig/xen

[libvirt] [PATCH] maint: typo fix in VIR_MIGRATE_PARAM_URI

s/filed/field/ Signed-off-by: Eric Blake --- Pushing under the trivial rule include/libvirt/libvirt-domain.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 12fd34037e..d7cbd18796 100644 --- a/include

[libvirt] [dbus PATCH v2 3/3] virtDBusNetworkGetDHCPLeases: fix type for expirytime

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Network.xml | 2 +- src/network.c| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/data/org.libvirt.Network.xml b/data/org.libvirt.Network.xml index dec3533..19ad132 100644 --- a/data/org.libvirt.Network.x

[libvirt] [dbus PATCH v2 2/3] Replace uint -> int wherever libvirt uses int type

Follow this pattern even if negative values will not appear, in order to be consistent with libvirt APIs. Signed-off-by: Katerina Koukiou --- Added type change for MemoryStats data/org.libvirt.Connect.xml | 18 +- data/org.libvirt.Domain.xml | 18 +- dat

[libvirt] [dbus PATCH v2 1/3] virtDBusNetworkGetDHCPLeases: fix lease type

Signed-off-by: Katerina Koukiou --- src/network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network.c b/src/network.c index 1763eca..7596687 100644 --- a/src/network.c +++ b/src/network.c @@ -228,7 +228,7 @@ virtDBusNetworkGetDHCPLeases(GVariant *inArgs, if (nle

[libvirt] [dbus PATCH v2 0/3] Type fixes

Katerina Koukiou (3): virtDBusNetworkGetDHCPLeases: fix lease type Replace uint -> int wherever libvirt uses int type virtDBusNetworkGetDHCPLeases: fix type for expirytime data/org.libvirt.Connect.xml | 18 +- data/org.libvirt.Domain.xml | 18 +- dat

Re: [libvirt] [PATCH v5 7/7] qemu: Implement memoryBacking/discard

On Fri, May 11, 2018 at 05:09:18PM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1480668 QEMU has this new feature memory-backend-file.discard-data=yes which is a nifty optimization. Basically, when qemu is quitting or on memory hotplug it calls munmap() and close()

Re: [libvirt] [PATCH v5 6/7] conf: Introduce memoryBacking/discard

On Fri, May 11, 2018 at 05:09:17PM +0200, Michal Privoznik wrote: QEMU has possibility to call madvise(.., MADV_REMOVE) in some cases. Expose this feature to users by new element/attribute discard. Signed-off-by: Michal Privoznik --- docs/formatdomain.html.in | 34 ++

Re: [libvirt] [PATCH v5 5/7] conf: Move virDomainMemtune formatting into a separate function

On Fri, May 11, 2018 at 05:09:16PM +0200, Michal Privoznik wrote: At the same time convert the code to use virXMLFormatElement. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 114 +++-- 1 file changed, 63 insertions(+), 51 deletions(-)

Re: [libvirt] [PATCH v2 3/4] log: support logging using shell wildcard syntax

On Mon, Apr 30, 2018 at 11:05:48AM -0400, John Ferlan wrote: > > > On 04/23/2018 08:28 AM, Daniel P. Berrangé wrote: > > Rather than specialcasing handling of the '*' character, use fnmatch() > > to get normal shell wildcard syntax, as described in 'man glob(7)'. > > > > To get an indication of

[libvirt] [PATCH 1/5] vircrypto: provide constants for hash sizes

The callers needing to know the size of the resulting digest rely on _DIGEST_SIZE constants from gnulib. Introduce VIR_CRYPTO_HASH_SIZE_ constants to remove the dependency. Signed-off-by: Ján Tomko --- src/util/vircrypto.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/vircrypt

[libvirt] [PATCH 5/5] vircrypto: Rely on GnuTLS for hash functions

Ditch the use of gnulib's digest functions in favor of GnuTLS, which might be more likely to get FIPS-certified. Signed-off-by: Ján Tomko --- bootstrap.conf | 2 -- src/util/vircrypto.c | 32 +++- 2 files changed, 23 insertions(+), 11 deletions(-) diff --git a

[libvirt] [dbus PATCH v2 3/3] events: Register VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON

Signed-off-by: Katerina Koukiou --- Return empty string when variable is NULL data/org.libvirt.Domain.xml | 8 src/events.c| 31 +++ 2 files changed, 39 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml ind

[libvirt] [PATCH 0/5] Rely on GnuTLS for md5/sha256 functions

Ján Tomko (5): vircrypto: provide constants for hash sizes Introduce virCryptoHashBuf esx: use virCryptoHashBuf esx: Use VIR_CRYPTO_HASH_SIZE_MD5 vircrypto: Rely on GnuTLS for hash functions bootstrap.conf | 2 -- src/esx/esx_network_driver.c| 22 --

[libvirt] [PATCH 3/5] esx: use virCryptoHashBuf

Instead of using md5_buffer from gnulib directly. Signed-off-by: Ján Tomko --- src/esx/esx_network_driver.c| 13 + src/esx/esx_storage_backend_iscsi.c | 19 +-- src/esx/esx_storage_backend_vmfs.c | 9 + 3 files changed, 27 insertions(+), 14 deletions

[libvirt] [PATCH 4/5] esx: Use VIR_CRYPTO_HASH_SIZE_MD5

Do not rely on gnulib's MD5_DIGEST_SIZE from md5.h. Include vircrypto.h and use VIR_CRYPTO_HASH_SIZE_MD5. Signed-off-by: Ján Tomko --- src/esx/esx_network_driver.c| 9 - src/esx/esx_storage_backend_iscsi.c | 27 +-- src/esx/esx_storage_backend_vmfs.c |

[libvirt] [PATCH 2/5] Introduce virCryptoHashBuf

A function that keeps the hash in binary form instead of converting it to human-readable hexadecimal form. Signed-off-by: Ján Tomko --- src/util/vircrypto.c | 31 +-- src/util/vircrypto.h | 7 +++ 2 files changed, 28 insertions(+), 10 deletions(-) diff --git a/s

[libvirt] [dbus PATCH v2 1/3] events: Register VIR_DOMAIN_EVENT_ID_BLOCK_JOB_2

Signed-off-by: Katerina Koukiou --- Use only v2 of BlockJob data/org.libvirt.Domain.xml | 8 src/events.c| 28 2 files changed, 36 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index b6e49d6..f5e49b0 1

[libvirt] [dbus PATCH v2 0/3] Domain Events

Katerina Koukiou (3): events: Register VIR_DOMAIN_EVENT_ID_BLOCK_JOB_2 events: Register VIR_DOMAIN_EVENT_ID_GRAPHICS events: Register VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON data/org.libvirt.Domain.xml | 25 ++ src/events.c| 119 +

[libvirt] [dbus PATCH v2 2/3] events: Register VIR_DOMAIN_EVENT_ID_GRAPHICS

Signed-off-by: Katerina Koukiou --- Return empty string when variable is NULL data/org.libvirt.Domain.xml | 9 +++ src/events.c| 60 + src/util.h | 2 ++ 3 files changed, 71 insertions(+) diff --git a/data/org.li

Re: [libvirt] [dbus PATCH 0/2] Fixes required before first release

On Fri, 2018-05-11 at 16:26 +0200, Ján Tomko wrote: > Does this count as a release plan announcement? There is still some cleanup work required. > > Will the next release still be considered API/ABI-unstable? It will be stable. Katerina > > Jano > > On Fri, May 11, 2018 at 03:21:54PM +0200,

Re: [libvirt] [dbus PATCH 2/2] Replace uint -> int wherever libvirt uses int type

On Fri, May 11, 2018 at 03:21:56PM +0200, Katerina Koukiou wrote: > Follow this pattern even if negative values will not > appear, in order to be consistent with libvirt APIs. > > Note: In virtDBusNetworkGetDHCPLeases the lease->type > was corrected from string to int. This should be separate pat

[libvirt] [PATCH v5 7/7] qemu: Implement memoryBacking/discard

https://bugzilla.redhat.com/show_bug.cgi?id=1480668 QEMU has this new feature memory-backend-file.discard-data=yes which is a nifty optimization. Basically, when qemu is quitting or on memory hotplug it calls munmap() and close() on the file that is backing the memory. However, this does not mean

[libvirt] [PATCH v5 6/7] conf: Introduce memoryBacking/discard

QEMU has possibility to call madvise(.., MADV_REMOVE) in some cases. Expose this feature to users by new element/attribute discard. Signed-off-by: Michal Privoznik --- docs/formatdomain.html.in | 34 +++-- docs/schemas/cputypes.rng | 5

[libvirt] [PATCH v5 2/7] qemu_monitor: Introduce qemuMonitorGetObjectProps

Now that we've gotten rid of misleading names we can introduce qemuMonitorGetObjectProps() function which queries -object properties. Again, some parts of code can be reused. Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko --- src/qemu/qemu_monitor.c | 13 + src/qemu/qem

[libvirt] [PATCH v5 5/7] conf: Move virDomainMemtune formatting into a separate function

At the same time convert the code to use virXMLFormatElement. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 114 +++-- 1 file changed, 63 insertions(+), 51 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH v5 1/7] qemuMonitorJSONGetDeviceProps: Separate props processing

The code that processes list of device properties is going to be reused. Therefore put it into a separate function. Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko --- src/qemu/qemu_monitor_json.c | 81 +--- 1 file changed, 47 insertions(+), 34 del

[libvirt] [PATCH v5 3/7] qemu_capabilities: Introduce QEMU_CAPS_QOM_LIST_PROPERTIES

This capability tracks if qemu has "qom-list-properties" monitor command. Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 3 +++ tests/qemucapabilitiesdata/caps_2.12.0.aa

[libvirt] [PATCH v5 0/7] Enable memory-backend-file.discard-data

v5 of: https://www.redhat.com/archives/libvir-list/2018-April/msg02029.html diff to v4: - last patch in the original series is split into two, - more tests added - couple of small changes (e.g. s/int/virTristateBool/) Michal Privoznik (7): qemuMonitorJSONGetDeviceProps: Separate props processin

Re: [libvirt] [PATCH] virbuffer: Set child buffer indent properly

On Fri, May 11, 2018 at 02:56:17PM +0200, Michal Privoznik wrote: There's this macro virBufferSetChildIndent which sets offset of child buffer from given parent buffer. However, it is calling virBufferAdjustIndent() which only adds adjustment instead of calling virBufferSetIndent() which clears o

[libvirt] [PATCH v2 6/5] docs/news.xml: Update with QEMU SDL OpenGL Improvement

Signed-off-by: Maciej Wolny --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 80181415c..e4a10f667 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -37,6 +37,15 @@ + + +qemu: Add suport

Re: [libvirt] [dbus PATCH 0/2] Fixes required before first release

Does this count as a release plan announcement? Will the next release still be considered API/ABI-unstable? Jano On Fri, May 11, 2018 at 03:21:54PM +0200, Katerina Koukiou wrote: Katerina Koukiou (2): domain: Replace State property with GetState method Replace uint -> int wherever libvirt us

Re: [libvirt] [PATCH v2 4/5] qemu: Add QEMU_CAPS_SDL_GL to qemu capabilities

On 10/05/18 21:17, John Ferlan wrote: > > > On 05/10/2018 06:53 AM, Maciej Wolny wrote: >> Support OpenGL acceleration capability when using SDL graphics. >> >> Signed-off-by: Maciej Wolny >> --- >> src/qemu/qemu_capabilities.c | 2 ++ >> src/qemu/qemu_capabilities.h

Re: [libvirt] [PATCH v2 4/5] qemu: Add QEMU_CAPS_SDL_GL to qemu capabilities

On 11/05/18 11:34, John Ferlan wrote:> I actually spent some time trying to figure out which magic incantation > of the virQEMUCaps* would work. I even tried various forms in > virQEMUCapsQMPSchemaQueries, but could not get the flag to be added from > qemu 2.4 and beyond. Again, my "assumption" i

Re: [libvirt] [dbus PATCH 1/2] domain: Replace State property with GetState method

On Fri, May 11, 2018 at 03:21:55PM +0200, Katerina Koukiou wrote: > virDomainGetState API uses flags arg, thus we can't leave it > as a property. > > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 10 + > src/domain.c| 49 >

Re: [libvirt] [PATCH v2 3/5] qemu: Add gl property to graphics of type sdl in domain config

On 11/05/18 09:42, Martin Kletzander wrote: > On Thu, May 10, 2018 at 11:53:57AM +0100, Maciej Wolny wrote: >> Support OpenGL accelerated rendering when using SDL graphics in the >> domain config. Add associated test and documentation. >> >> Signed-off-by: Maciej Wolny >> --- >> docs/formatdomain.

[libvirt] [PATCH] xenconfig: xm: Fix checking for extra in parser

Parser assumed extra was always present when root was specified. Fixed by handling root and extra separately. --- src/xenconfig/xen_xm.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c index 8ef68bbc..4becb40b 100644 --- a

[libvirt] [dbus PATCH 2/2] Replace uint -> int wherever libvirt uses int type

Follow this pattern even if negative values will not appear, in order to be consistent with libvirt APIs. Note: In virtDBusNetworkGetDHCPLeases the lease->type was corrected from string to int. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 18 +- data/or

[libvirt] [dbus PATCH 0/2] Fixes required before first release

Katerina Koukiou (2): domain: Replace State property with GetState method Replace uint -> int wherever libvirt uses int type data/org.libvirt.Connect.xml | 18 +-- data/org.libvirt.Domain.xml | 26 +--- data/org.libvirt.Network.xml | 2 +- data/org.libvirt.Se

[libvirt] [dbus PATCH 1/2] domain: Replace State property with GetState method

virDomainGetState API uses flags arg, thus we can't leave it as a property. Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 10 + src/domain.c| 49 ++--- tests/test_domain.py| 9 - 3 files changed,

[libvirt] [PATCH 2/2] virutil.c: do not include stdarg.h

Last functions using it were moved to virfile.c in commit . Signed-off-by: Ján Tomko --- src/util/virutil.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index 4b03fe60eb..bb4474acd5 100644 --- a/src/util/virutil.c +++ b/src/util/virutil.c @@ -28,7 +2

[libvirt] [PATCH 1/2] virutil.c: do not include ioctl.h

Added by commit 61674cc, but we have started using set_nonblocking_flag from gnulib incommit da3c4714 Signed-off-by: Ján Tomko --- src/util/virutil.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index cd6fbf2f30..4b03fe60eb 100644 --- a/src/util/viru

[libvirt] [PATCH 0/2] Some include cleanups

Ján Tomko (2): virutil.c: do not include ioctl.h virutil.c: do not include stdarg.h src/util/virutil.c | 2 -- 1 file changed, 2 deletions(-) -- 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCHv3 07/13] FIXUP: compile and link with Jansson instead of yajl

--- src/Makefile.am | 8 src/util/Makefile.inc.am | 4 ++-- tests/Makefile.am| 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 0c380780c3..361cc98f0f 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -550,7

[libvirt] [PATCHv3 05/13] FIXUP: Deprecate building --with-yajl

--- m4/virt-yajl.m4 | 27 +++ 1 file changed, 3 insertions(+), 24 deletions(-) diff --git a/m4/virt-yajl.m4 b/m4/virt-yajl.m4 index c4ea0102a3..8d4c43a6b2 100644 --- a/m4/virt-yajl.m4 +++ b/m4/virt-yajl.m4 @@ -23,31 +23,10 @@ AC_DEFUN([LIBVIRT_ARG_YAJL],[ AC_DEFUN([LIBV

[libvirt] [PATCHv3 00/13] Switch from yajl to Jansson

Per the discussion here: https://www.redhat.com/archives/libvir-list/2017-November/msg00225.html Switch from using yajl to Jansson. v1: https://www.redhat.com/archives/libvir-list/2018-March/msg01781.html v2: https://www.redhat.com/archives/libvir-list/2018-May/msg00695.html Patches 3-9 are meant

[libvirt] [PATCHv3 11/13] build: remove references to WITH_YAJL for SETUID_RPC_CLIENT

We no longer allow building WITH_YAJL, remove the remaining uses of the macro. Signed-off-by: Ján Tomko --- config-post.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/config-post.h b/config-post.h index cb2fc2b4ee..f561935bd7 100644 --- a/config-post.h +++ b/config-post.h @@ -45,8 +45,6

[libvirt] [PATCHv3 12/13] build: switch --with-qemu default from yes to check

Unless explicitly requested, enable the QEMU driver only if the Jansson library is present. Signed-off-by: Ján Tomko --- m4/virt-driver-qemu.m4 | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4 index 80e1d3ad46..ddb2834705 10

[libvirt] [PATCHv3 09/13] FIXUP: libvirt.spec: use jansson instead of yajl

--- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 9ea5e6b32a..f653b98465 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -336,7 +336,7 @@ BuildRequires: systemd-devel >= 185 BuildRequires: libudev-devel >= 145

[libvirt] [PATCHv3 10/13] Remove functions using yajl

We no longer support building WITH_YAJL, remove the dead code as well as the virJSONParser structures that are no longer used. Signed-off-by: Ján Tomko --- src/util/virjson.c | 530 + 1 file changed, 1 insertion(+), 529 deletions(-) diff --git

[libvirt] [PATCHv3 13/13] build: require Jansson if QEMU driver is enabled

If the QEMU driver was requested, require Jansson, since we need to use the JSON monitor to probe capabilities for all QEMU version supported by libvirt. Signed-off-by: Ján Tomko --- m4/virt-driver-qemu.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-dr

[libvirt] [PATCHv3 08/13] FIXUP: s/WITH_YAJL/WITH_JANSSON/

--- src/qemu/qemu_driver.c | 2 +- tests/Makefile.am | 10 +- tests/cputest.c| 16 tests/libxlxml2domconfigtest.c | 4 ++-- tests/qemuagenttest.c | 2 +- tests/qemucapabilitiestest.c | 2 +- tests/qemucaps2xmltest.c

[libvirt] [PATCHv3 03/13] Switch from yajl to Jansson

Yajl has not seen much activity upstream recently. Switch to using Jansson >= 2.7. All the platforms we target on https://libvirt.org/platforms.html have a version >= 2.7 listed on the sites below: https://repology.org/metapackage/jansson/versions https://build.opensuse.org/package/show/devel:libr

[libvirt] [PATCHv3 04/13] FIXUP: fix tests

Jansson does not add an extra newline after the output and it formats empty elements differently. --- tests/qemublocktest.c| 1 + tests/qemumigparamsdata/empty.json | 4 +--- tests/qemumigparamsdata/unsupported.json | 4 +--- tests/virmacmaptestdata/empty.json | 4 +

[libvirt] [PATCHv3 02/13] build: undef WITH_JANSSON for SETUID_RPC_CLIENT

There is no code using WITH_JANSSON yet, but once we add it, it should not be compiled for the setuid_rpc_client. Signed-off-by: Ján Tomko --- config-post.h | 1 + 1 file changed, 1 insertion(+) diff --git a/config-post.h b/config-post.h index f7eba0d7ca..cb2fc2b4ee 100644 --- a/config-post.h +

[libvirt] [PATCHv3 06/13] FIXUP: make nss depend on Jansson instead of yajl

--- m4/virt-nss.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/virt-nss.m4 b/m4/virt-nss.m4 index 951a74e835..082b7b14f6 100644 --- a/m4/virt-nss.m4 +++ b/m4/virt-nss.m4 @@ -27,9 +27,9 @@ AC_DEFUN([LIBVIRT_CHECK_NSS],[ bsd_nss=no fail=0 if test "x$with_nss_p

[libvirt] [PATCHv3 01/13] build: add --with-jansson

Introduce the configure argument and check for Jansson >= 2.7 Signed-off-by: Ján Tomko --- configure.ac | 3 +++ m4/virt-jansson.m4 | 29 + 2 files changed, 32 insertions(+) create mode 100644 m4/virt-jansson.m4 diff --git a/configure.ac b/configure.ac index

[libvirt] [PATCH] virbuffer: Set child buffer indent properly

There's this macro virBufferSetChildIndent which sets offset of child buffer from given parent buffer. However, it is calling virBufferAdjustIndent() which only adds adjustment instead of calling virBufferSetIndent() which clears out any adjustment previously set. Signed-off-by: Michal Privoznik

Re: [libvirt] [dbus PATCH 22/22] events: Register VIR_DOMAIN_EVENT_ID_WATCHDOG

On Thu, May 10, 2018 at 07:26:14PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 + > src/events.c| 26 ++ > 2 files changed, 31 insertions(+) Reviewed-by: Pavel Hrdina signature.asc Descri

Re: [libvirt] [dbus PATCH 21/22] events: Register VIR_DOMAIN_EVENT_ID_TUNABLE

On Thu, May 10, 2018 at 07:26:13PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 + > src/events.c| 30 ++ > 2 files changed, 35 insertions(+) Reviewed-by: Pavel Hrdina signature.asc De

Re: [libvirt] [dbus PATCH 20/22] events: Register VIR_DOMAIN_EVENT_ID_RTC_CHANGE

On Thu, May 10, 2018 at 07:26:12PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 + > src/events.c| 26 ++ > 2 files changed, 31 insertions(+) Reviewed-by: Pavel Hrdina signature.asc Descri

Re: [libvirt] [dbus PATCH 19/22] events: Register VIR_DOMAIN_EVENT_ID_PMWAKEUP

On Thu, May 10, 2018 at 07:26:11PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 + > src/events.c| 26 ++ > 2 files changed, 31 insertions(+) Reviewed-by: Pavel Hrdina signature.asc Descri

Re: [libvirt] [dbus PATCH 18/22] events: Register VIR_DOMAIN_EVENT_ID_PMSUSPEND_DISK

On Thu, May 10, 2018 at 07:26:10PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 + > src/events.c| 26 ++ > 2 files changed, 31 insertions(+) Reviewed-by: Pavel Hrdina signature.asc Descri

Re: [libvirt] [dbus PATCH 17/22] events: Register VIR_DOMAIN_EVENT_ID_PMSUSPEND

On Thu, May 10, 2018 at 07:26:09PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 + > src/events.c| 26 ++ > 2 files changed, 31 insertions(+) Reviewed-by: Pavel Hrdina signature.asc Descri

Re: [libvirt] [dbus PATCH 16/22] events: Register VIR_DOMAIN_EVENT_ID_MIGRATION_ITERATION

On Thu, May 10, 2018 at 07:26:08PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 + > src/events.c| 26 ++ > 2 files changed, 31 insertions(+) Reviewed-by: Pavel Hrdina signature.asc Descri

Re: [libvirt] [dbus PATCH 15/22] events: Register VIR_DOMAIN_EVENT_ID_METADATA_CHANGE

On Thu, May 10, 2018 at 07:26:07PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 6 ++ > src/events.c| 27 +++ > 2 files changed, 33 insertions(+) Reviewed-by: Pavel Hrdina signature.asc Desc

Re: [libvirt] [dbus PATCH 14/22] events: Register VIR_DOMAIN_EVENT_ID_JOB_COMPLETED

On Thu, May 10, 2018 at 07:26:06PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 + > src/events.c| 30 ++ > 2 files changed, 35 insertions(+) Reviewed-by: Pavel Hrdina signature.asc De

Re: [libvirt] [dbus PATCH 13/22] events: Register VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON

On Thu, May 10, 2018 at 07:26:05PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 8 > src/events.c| 30 ++ > 2 files changed, 38 insertions(+) > > diff --git a/data/org.libvirt.Domain.x

Re: [libvirt] [dbus PATCH 12/22] events: Register VIR_DOMAIN_EVENT_ID_IO_ERROR

On Fri, May 11, 2018 at 02:13:32PM +0200, Pavel Hrdina wrote: > On Thu, May 10, 2018 at 07:26:04PM +0200, Katerina Koukiou wrote: > > Signed-off-by: Katerina Koukiou > > --- > > data/org.libvirt.Domain.xml | 7 +++ > > src/events.c| 29 + > > 2 fil

Re: [libvirt] [dbus PATCH 12/22] events: Register VIR_DOMAIN_EVENT_ID_IO_ERROR

On Thu, May 10, 2018 at 07:26:04PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 7 +++ > src/events.c| 29 + > 2 files changed, 36 insertions(+) Reviewed-by: Pavel Hrdina signature.asc D

Re: [libvirt] [dbus PATCH 11/22] events: Register VIR_DOMAIN_EVENT_ID_REBOOT

On Thu, May 10, 2018 at 07:26:03PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 4 > src/events.c| 25 + > 2 files changed, 29 insertions(+) Reviewed-by: Pavel Hrdina signature.asc Descript

Re: [libvirt] [dbus PATCH 10/22] events: Register VIR_DOMAIN_EVENT_ID_GRAPHICS

On Thu, May 10, 2018 at 07:26:02PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 9 +++ > src/events.c| 60 > + > 2 files changed, 69 insertions(+) > > diff --git a/data/org

Re: [libvirt] [PATCH v2 4/5] qemu: Add QEMU_CAPS_SDL_GL to qemu capabilities

On 05/11/2018 07:47 AM, Martin Kletzander wrote: > On Fri, May 11, 2018 at 06:34:54AM -0400, John Ferlan wrote: >> On 05/11/2018 04:26 AM, Martin Kletzander wrote: >>> On Thu, May 10, 2018 at 04:17:52PM -0400, John Ferlan wrote: On 05/10/2018 06:53 AM, Maciej Wolny wrote: > Sup

Re: [libvirt] [PATCHv2 10/12] FIXUP: s/WITH_YAJL/WITH_JANSSON/

On Fri, May 11, 2018 at 13:53:30 +0200, Ján Tomko wrote: > On Fri, May 11, 2018 at 09:49:00AM +0200, Peter Krempa wrote: > > On Thu, May 10, 2018 at 18:44:22 +0200, Ján Tomko wrote: > > > --- > > > src/qemu/qemu_driver.c | 2 +- > > > tests/Makefile.am | 10 +- > > >

[libvirt] [dbus PATCH 8/8] Implement NWFilterLookupByUUID method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + 2 files changed, 35 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 6847aaf..9f42d8c 100644 --- a/data/org.l

[libvirt] [dbus PATCH 4/8] Implement Name property for NWFilter Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.NWFilter.xml | 5 + src/nwfilter.c| 43 +++ 2 files changed, 48 insertions(+) diff --git a/data/org.libvirt.NWFilter.xml b/data/org.libvirt.NWFilter.xml index c025d30..9a1b44f 100644

[libvirt] [dbus PATCH 2/8] Implement ListNWFilters method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 38 ++ 2 files changed, 44 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 243ef35..a78a87d 100644 --- a/d

[libvirt] [dbus PATCH 6/8] Implement GetXMLDesc method for NWFilter Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.NWFilter.xml | 6 ++ src/nwfilter.c| 28 2 files changed, 34 insertions(+) diff --git a/data/org.libvirt.NWFilter.xml b/data/org.libvirt.NWFilter.xml index fae61dc..69e3357 100644 --- a/data/or

[libvirt] [dbus PATCH 1/8] Introduce NWFilter Interface

Signed-off-by: Katerina Koukiou --- data/Makefile.am | 1 + data/org.libvirt.NWFilter.xml | 7 + src/Makefile.am | 1 + src/connect.c | 6 src/connect.h | 1 + src/nwfilter.c| 65 +

[libvirt] [dbus PATCH 3/8] Implement NWFilterDefineXML method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + 2 files changed, 35 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index a78a87d..c228c6d 100644 --- a/data/org.l

[libvirt] [dbus PATCH 7/8] Implement NWFilterLookupByName method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + 2 files changed, 35 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index c228c6d..6847aaf 100644 --- a/data/org.l

[libvirt] [dbus PATCH 0/8] NWFilter APIs

Katerina Koukiou (8): Introduce NWFilter Interface Implement ListNWFilters method for Connect Interface Implement NWFilterDefineXML method for Connect Interface Implement Name property for NWFilter Interface Implement UUID property for NWFilter Interface Implement GetXMLDesc method for

[libvirt] [dbus PATCH 5/8] Implement UUID property for NWFilter Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.NWFilter.xml | 5 + src/nwfilter.c| 21 + 2 files changed, 26 insertions(+) diff --git a/data/org.libvirt.NWFilter.xml b/data/org.libvirt.NWFilter.xml index 9a1b44f..fae61dc 100644 --- a/data/org.libvir

Re: [libvirt] [PATCHv2 10/12] FIXUP: s/WITH_YAJL/WITH_JANSSON/

On Fri, May 11, 2018 at 09:49:00AM +0200, Peter Krempa wrote: On Thu, May 10, 2018 at 18:44:22 +0200, Ján Tomko wrote: --- src/qemu/qemu_driver.c | 2 +- tests/Makefile.am | 10 +- tests/cputest.c| 16 tests/libxlxml2domconfigtest.c

Re: [libvirt] [PATCH v2 4/5] qemu: Add QEMU_CAPS_SDL_GL to qemu capabilities

On Fri, May 11, 2018 at 06:34:54AM -0400, John Ferlan wrote: On 05/11/2018 04:26 AM, Martin Kletzander wrote: On Thu, May 10, 2018 at 04:17:52PM -0400, John Ferlan wrote: On 05/10/2018 06:53 AM, Maciej Wolny wrote: Support OpenGL acceleration capability when using SDL graphics. Signed-off-b

Re: [libvirt] [dbus PATCH 09/22] events: Register VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED

On Thu, May 10, 2018 at 07:26:01PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 5 + > src/events.c| 26 ++ > 2 files changed, 31 insertions(+) Reviewed-by: Pavel Hrdina signature.asc Descri

Re: [libvirt] [dbus PATCH 08/22] events: Register VIR_DOMAIN_EVENT_ID_CONTROL_ERROR

On Thu, May 10, 2018 at 07:26:00PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.Domain.xml | 4 > src/events.c| 25 + > 2 files changed, 29 insertions(+) Reviewed-by: Pavel Hrdina signature.asc Descript

[libvirt] [REPOST PATCHv3 3/6] qemu: Alter VM Generation ID for specific startup/launch transitions

Before we generate the command line for qemu, if the domain about to be launched desires to utilize the VM Generation ID functionality, then handle both the regenerating the GUID value for backup recovery (restore operation) and the startup after snapshot as both require a new GUID to be generated

[libvirt] [REPOST PATCHv3 0/6] Add support for VM Generation ID (vmgenid)

Repost of : https://www.redhat.com/archives/libvir-list/2018-May/msg00251.html to update patch 2 with the recent capabilities changes. Sync'd up to commit id 'c9da6cbe'. Cover from the v3 posting: v2: https://www.redhat.com/archives/libvir-list/2018-April/msg02234.html Changes since v2: *

[libvirt] [REPOST PATCHv3 4/6] qemu: Add VM Generation ID to qemu command line

https://bugzilla.redhat.com/show_bug.cgi?id=1149445 If the domain requests usage of the genid functionality, then add the QEMU '-device vmgenid' to the command line providing either the supplied or generated GUID value. Add tests for both a generated and supplied GUID value. Signed-off-by: John

[libvirt] [REPOST PATCHv3 6/6] docs: Add news article for VM Generation ID

Signed-off-by: John Ferlan --- docs/news.xml | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 80181415c6..c8495e6035 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,19 @@ + + + Add support for VM

[libvirt] [REPOST PATCHv3 5/6] domcaps: Add 'genid' to domain capabilities

Report domaincaps if the guest config accepts or $GUID. Signed-off-by: John Ferlan --- docs/formatdomaincaps.html.in | 7 ++- docs/schemas/domaincaps.rng | 7 +++ src/conf/domain_capabilities.c | 3 +++ src/

[libvirt] [REPOST PATCHv3 1/6] conf: Add VM Generation ID parse/format support

The VM Generation ID is a mechanism to provide a unique 128-bit, cryptographically random, and integer value identifier known as the GUID (Globally Unique Identifier) to the guest OS. The value is used to help notify the guest operating system when the virtual machine is executed with a different c

[libvirt] [REPOST PATCHv3 2/6] qemu: Add VM Generation ID device capability

Add the query of the device objects for the vmgenid device Signed-off-by: John Ferlan --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 3 +++ tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/cap

Re: [libvirt] [PATCH] virsh: Don't skip the first entry when the typed command share same prefix

On 05/11/2018 11:13 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > tools/vsh.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/vsh.c b/tools/vsh.c > index f76076b164..1516e578d9 100644 > --- a/tools/vsh.c > +++ b/tools/vsh.c > @@ -3495,11 +3495,11 @@ cmd

Re: [libvirt] ZFS backend does fail if used on non top level pools

> This one is the "unknown" for me.  What happens if you create > Xzfs/images/vol1 (or your command below) without first creating Xzfs/images? Answer: it fails, unless you give the '-p' flag.    -p    Creates all the non-existing parent datasets. Datasets created in this 

Re: [libvirt] [PATCH v2 4/5] qemu: Add QEMU_CAPS_SDL_GL to qemu capabilities

On 05/11/2018 04:26 AM, Martin Kletzander wrote: > On Thu, May 10, 2018 at 04:17:52PM -0400, John Ferlan wrote: >> >> >> On 05/10/2018 06:53 AM, Maciej Wolny wrote: >>> Support OpenGL acceleration capability when using SDL graphics. >>> >>> Signed-off-by: Maciej Wolny >>> --- >>>  src/qemu/qemu_

[libvirt] [PATCH] virsh: Don't skip the first entry when the typed command share same prefix

Signed-off-by: Lin Ma --- tools/vsh.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index f76076b164..1516e578d9 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -3495,11 +3495,11 @@ cmdComplete(vshControl *ctl, const vshCmd *cmd) if (!(ma

Re: [libvirt] [PATCH v2 11/12] virsh: add helper for returning event name string

On 05/11/2018 10:22 AM, Lin Ma wrote: > > > On 05/10/2018 05:17 PM, Michal Privoznik wrote: >> On 05/08/2018 04:20 PM, Lin Ma wrote: >>> Signed-off-by: Lin Ma >>> --- >>>   tools/virsh-util.c | 60 >>> ++ >>>   tools/virsh-util.h |  3 +++ >>>  

Re: [libvirt] [PATCH v2 11/12] virsh: add helper for returning event name string

On 05/10/2018 05:17 PM, Michal Privoznik wrote: On 05/08/2018 04:20 PM, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-util.c | 60 ++ tools/virsh-util.h | 3 +++ 2 files changed, 63 insertions(+) diff --git a/tools/virsh-util.c b

  1   2   >