On Fri, 1 Jun 2018 12:43:09 +0800
Yi Min Zhao wrote:
> 在 2018/5/29 下午5:04, Cornelia Huck 写道:
> > On Mon, 28 May 2018 16:26:57 +0800
> > Xiao Feng Ren wrote:
> >> As the model of Shmem is not support in qemu, the rng device doesn't
> >> support MSI-X. So remove them.
> > So, should qemu add s
The first feature is SCSI persistent reservation, the other is
support for multihead screenshots.
Signed-off-by: Michal Privoznik
---
docs/news.xml | 19 +++
1 file changed, 19 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index c45850f625..453ac1d02a 100644
--- a/doc
Provide information about host IOMMU support in capabilities XML.
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=967231
v1:
https://www.redhat.com/archives/libvir-list/2018-May/msg01914.html
v2:
https://www.redhat.com/archives/libvir-list/2018-May/msg01997.html
- Remove incorrect warning me
Signed-off-by: Filip Alac
---
docs/news.xml | 8
1 file changed, 8 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index c45850f625..b5ac50f3a1 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -123,6 +123,14 @@
secret-event, pool-event and nodedev-event)
Signed-off-by: Filip Alac
---
docs/schemas/capability.rng | 13 +
src/conf/capabilities.c | 9 +
src/conf/capabilities.h | 3 +++
src/libvirt_private.syms| 1 +
src/q
Signed-off-by: Filip Alac
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_hostdev.c | 29 -
src/util/virutil.c | 28
src/util/virutil.h | 2 ++
4 files changed, 35 insertions(+), 25 deletions(-)
diff --git a/src/libvirt_pr
On Thu, May 31, 2018 at 11:19:04AM -0400, John Ferlan wrote:
On 05/31/2018 08:14 AM, Martin Kletzander wrote:
On Wed, May 30, 2018 at 12:00:26PM -0400, John Ferlan wrote:
On 05/21/2018 11:00 AM, Martin Kletzander wrote:
TSEG (Top of Memory Segment) is one of many regions that SMM (System
M
On EOF, the loop can be terminated right away since most of it is
skipped anyways and the handling of the last command is repeated after
the loop.
Signed-off-by: Peter Krempa
---
tests/qemumonitortestutils.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff -
Use qemuMonitorTestNewFromFileFull which allows to test commands used
along with providing replies. This has two advantages:
1) It's easier to see which command was used when looking at the files
2) We check that the used commands are actually in the correct order
Signed-off-by: Peter Krempa
---
qemucapabilitiestest for simplicity uses one test monitor object for
simulating work of two separate inquiries of the qemu process. To allow
better testing in the future it will be required to reset the counter
so that it accurately simulates how qemu would behave.
This patch adds a private monito
Change the output of qemucapsprobe to record the commands used for
querying. This allows to easily identify which reply belongs to which
command and also will allow to test whether we use stable queries.
This change includes changing dropping of the QMP greeting from the file
and reformatting of t
Hi,
As the title says, VNC inside a windows virtual machine doesn’t work after I
try to use mstsc to access the vm with a gpu passthrough.
It seems that the scenario is normal, but could someone tell me something
deeply about the reason why vnc shows blackscreen?
Thanks.
--
libvir-list mailin
Rather than skipping output on failure fail loudly.
Signed-off-by: Peter Krempa
---
tests/qemucapsprobemock.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tests/qemucapsprobemock.c b/tests/qemucapsprobemock.c
index f26fa6b285..a0d2acb69a 100644
--- a/tests/qemucap
De-confusify the 'replies' files for human usage by recording which
commands were used for gathering given block. Additionally this tests
that the commands emitted by libvirt are as recorded.
This series is in RFC state, since it creates some churn in the
capability files and also 'tests/qemucapsf
Use the LD_PRELOAD .so library used in 'qemucapsprobe' to regenerate the
files. The library is instrumented to write the replies to 'caps.json'
and instrumentation in the test move it to the correct place.
Use 'fix-files.sh' to do so as it's using a static variable to
track the initial newline.
--
The test file can be broken up by newlines and is automatically
concatenated back. Fix the control flow so that the concatenation code
'continues' the loop rather than branching out.
Also add an anotation to the concatenation code.
Signed-off-by: Peter Krempa
---
tests/qemumonitortestutils.c |
The prettyfied output may sometimes contain empty lines which would
desynchonize the test monitor workers. The skipping code can be much
simplified though. Also a extract it so so that it's obvious what
it's doing and can be reused.
Signed-off-by: Peter Krempa
---
tests/qemucapsprobemock.c | 26
On Fri, Jun 01, 2018 at 10:20:00 +0200, Peter Krempa wrote:
> This is supposed to be squashed in into the previous patch.
>
> The files were regenerated by instrumenting the qemucapabilitiestest
> with the LD_PRELOAD hack used to gather the data in qemucapsprobe. See
> next patch
> ---
[...]
> d
https://bugzilla.redhat.com/show_bug.cgi?id=1584071
Jiri Denemark (2):
qemu: Report error on unexpected job stats type
qemu: Fix reporting completed migration stats on destination
src/qemu/qemu_domain.c| 8 +---
src/qemu/qemu_migration.c | 1 +
2 files changed, 6 insertions(+), 3 del
This has been broken since commit v4.0.0-165-g93412bb827 which added
jobInfo->statsType enum to distinguish various statistics types. During
migration the type will always be QEMU_DOMAIN_JOB_STATS_TYPE_MIGRATION,
however the destination code consuming the statistics data from
migration cookie faile
If we ever fail to properly set jobinfo->statsType,
qemuDomainJobInfoToParams would return -1 without setting an error.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domain.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domai
On 06/01/2018 10:15 AM, Filip Alac wrote:
> Provide information about host IOMMU support in capabilities XML.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=967231
>
> v1:
> https://www.redhat.com/archives/libvir-list/2018-May/msg01914.html
>
> v2:
> https://www.redhat.com/archives/lib
On 06/01/2018 10:16 AM, Filip Alac wrote:
> Signed-off-by: Filip Alac
> ---
> docs/news.xml | 8
> 1 file changed, 8 insertions(+)
ACK
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 06/01/2018 10:15 AM, Filip Alac wrote:
> Signed-off-by: Filip Alac
> ---
> docs/schemas/capability.rng | 13 +
> src/conf/capabilities.c | 9 +
> src/conf/capabilities.h | 3 +++
> src/libvirt
On 06/01/2018 10:15 AM, Filip Alac wrote:
> Signed-off-by: Filip Alac
> ---
> src/libvirt_private.syms | 1 +
> src/qemu/qemu_hostdev.c | 29 -
> src/util/virutil.c | 28
> src/util/virutil.h | 2 ++
> 4 files changed, 35 ins
On Thu, May 31, 2018 at 07:17:18PM +0200, Peter Krempa wrote:
Disks are client-only so we don't need to have this variable. We also
always pass false for 'isListen' to qemuBuildTLSx509BackendProps for all
disk-related code-paths.
---
This applies on top of my branch collecting all ACKed postings
On Wed, May 30, 2018 at 10:21:54PM +0200, Martin Kletzander wrote:
> On Tue, May 29, 2018 at 10:06:25AM -0400, John Ferlan wrote:
> >
> >
> > On 05/29/2018 09:44 AM, Michal Privoznik wrote:
> > > On 05/29/2018 03:38 PM, Martin Kletzander wrote:
> > > > On Fri, May 25, 2018 at 09:37:44AM -0500, Er
On Wed, May 30, 2018 at 03:43:31PM +0200, Martin Kletzander wrote:
> On Wed, May 30, 2018 at 02:16:08PM +0200, Michal Privoznik wrote:
> > On 05/29/2018 03:44 PM, Martin Kletzander wrote:
> > > On Tue, May 29, 2018 at 10:24:44AM +0200, Michal Privoznik wrote:
> > > > Now that we have strong PRNG ge
On Sat, May 26, 2018 at 08:27:47AM -0400, John Ferlan wrote:
> In a previous commit:
>
>commit d4bf8f415074759baf051644559e04fe7f8b
>Author: Daniel P. Berrangé
>Date: Wed Feb 14 09:43:59 2018 +
>
> nwfilter: handle missing switch enum cases
>
> Ensure all enum ca
On Tue, May 22, 2018 at 11:40:25AM +0200, Ján Tomko wrote:
> On Mon, May 21, 2018 at 04:46:13PM +0100, Daniel P. Berrangé wrote:
> > On Mon, May 21, 2018 at 05:37:10PM +0200, Ján Tomko wrote:
> > > @Stefan, please take a look at the docs/ changes in patch 6
> > >
> > > Add , mapping to vhost-vsock
On Thu, May 24, 2018 at 02:00:06PM +0200, Olaf Hering wrote:
> Currently virNetSocketNewListenTCP bails out early under the following
> conditions:
> - the hostname resolves to at least one IPv4 and at least one IPv6
> address
> - the local interfaces have that one IPv4 address assigned, but not
On Tue, May 22, 2018 at 08:45:54AM +0200, Andrea Bolognani wrote:
> Changes from [v2]:
>
> * now that libvirt-perl uses Module::Build and ExtUtils::MakeMaker
> support has been dropped, we don't need to special case any job,
> so revert back to [v1] and rebase on top of master because the
>
On Mon, May 28, 2018 at 01:04:28PM +0530, Sukrit Bhatnagar wrote:
> On 25 May 2018 at 16:20, Pavel Hrdina wrote:
> > On Fri, May 25, 2018 at 12:06:50PM +0200, Andrea Bolognani wrote:
> >> On Fri, 2018-05-25 at 10:04 +0200, Pavel Hrdina wrote:
> >> > On Fri, May 25, 2018 at 09:13:51AM +0200, Andrea
On Thu, May 24, 2018 at 12:39:11PM +0200, Ján Tomko wrote:
> Add a new 'vsock' element for the vsock device.
> The 'model' attribute is optional.
> A subelement should be used to specify the guest cid,
> or should be used.
I always find the vs naming somewhat confusing
because we are not cons
On Wed, May 30, 2018 at 03:13:32PM +0200, Andrea Bolognani wrote:
> Andrea Bolognani (2):
> travis: Move PATH to macOS-specific environment
> travis: Install and use ccache on macOS
>
> .travis.yml | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
On Fri, Jun 01, 2018 at 09:47:15AM +0200, Michal Privoznik wrote:
The first feature is SCSI persistent reservation, the other is
support for multihead screenshots.
Signed-off-by: Michal Privoznik
---
docs/news.xml | 19 +++
1 file changed, 19 insertions(+)
Reviewed-by: Ján Tom
Document the addition of vsock.
Signed-off-by: Ján Tomko
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 453ac1d02a..a2829eff6a 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -113,6 +113,15 @@
libvirt has done as we
Last-minute change of the element name suggested by Dan:
https://www.redhat.com/archives/libvir-list/2018-June/msg00034.html
The news patch is rebased on top of Michal's addition:
[PATCH for 4.4.0] news: Document two new features introduced in this release
Ján Tomko (2):
conf: rename to
ne
To avoid the vs. confusion,
change to:
Signed-off-by: Ján Tomko
Suggested-by: Daniel P. Berrangé
---
docs/formatdomain.html.in | 6 +++---
docs/schemas/domaincommon.rng | 4 ++--
src/conf/domain_conf.c| 20 ++--
t
On Fri, Jun 01, 2018 at 13:36:05 +0200, Ján Tomko wrote:
> Document the addition of vsock.
>
> Signed-off-by: Ján Tomko
> ---
> docs/news.xml | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index 453ac1d02a..a2829eff6a 100644
> --- a/docs/news.x
On Fri, Jun 01, 2018 at 13:36:04 +0200, Ján Tomko wrote:
> To avoid the vs. confusion,
> change to:
>
>
> Signed-off-by: Ján Tomko
> Suggested-by: Daniel P. Berrangé
> ---
> docs/formatdomain.html.in | 6 +++---
> docs/schemas/domaincommon.rng | 4 ++--
On Fri, Jun 01, 2018 at 11:17:44AM +0100, Daniel P. Berrangé wrote:
On Wed, May 30, 2018 at 10:21:54PM +0200, Martin Kletzander wrote:
On Tue, May 29, 2018 at 10:06:25AM -0400, John Ferlan wrote:
>
>
> On 05/29/2018 09:44 AM, Michal Privoznik wrote:
> > On 05/29/2018 03:38 PM, Martin Kletzander
2018-05-30 11:05 GMT+02:00 Pino Toscano :
> Hi Matthias,
>
> while testing the recent improvements I did in the VMX parser for CPU
> topology (see https://bugzilla.redhat.com/1568148), our QE Ming Xie set
> a guest in ESXi 5.5 to 7 cores. The result was the error triggered by
> the following code:
Now that the old qcow2 encryption is removed we can safely delete all
this code since it's not needed any more.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 13 --
src/qemu/qemu_monitor.h | 4 --
src/qemu/qemu_monitor_json.c | 28
src/qemu/qemu_monitor
v2:
- add entries to formatdomain.html and formatstorageencryption.html
saying that the encryption should not be used.
This applies on top of my branch collecting all ACKed postings of
recent blockdev-related work. Current version can be fetched by:
git fetch git://pipo.sk/pipo/libvirt.git blockd
The encryption was buggy and qemu actually dropped it upstream. Forbid
it for all versions since it would cause other problems too.
Problems with the old encryption include weak crypto, corruption of
images with blockjobs and a lot of usability problems.
This requires changing of the encryption t
Signed-off-by: Kashyap Chamarthy
---
src/qemu/qemu.conf | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
index 31738ff19c..444247cf31 100644
--- a/src/qemu/qemu.conf
+++ b/src/qemu/qemu.conf
@@ -403,13 +403,14 @@
#
# user = "
On Fri, Jun 01, 2018 at 11:25:35AM +0100, Daniel P. Berrangé wrote:
On Wed, May 30, 2018 at 03:43:31PM +0200, Martin Kletzander wrote:
On Wed, May 30, 2018 at 02:16:08PM +0200, Michal Privoznik wrote:
> On 05/29/2018 03:44 PM, Martin Kletzander wrote:
> > On Tue, May 29, 2018 at 10:24:44AM +0200
At least since Fedora 26 (maybe earlier, but we don't support older
Fedora releases), the "tc" tool is provided by a separate iproute-tc
package.
Signed-off-by: Jiri Denemark
---
libvirt.spec.in | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 17d
[...]
First thanks for taking the time to elaborate - it is helpful. Much
better than just stating no because I don't like it ;-).
>>
1. Add poll-max-ns property of each iothread:
https://www.redhat.com/archives/libvir-list/2017-February/msg01047.html
>>>
>>> This is about tunabl
On Fri, Jun 01, 2018 at 02:08:38PM +0200, Kashyap Chamarthy wrote:
Signed-off-by: Kashyap Chamarthy
---
src/qemu/qemu.conf | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Why?
Jano
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
htt
On Fri, Jun 01, 2018 at 02:01:03PM +0200, Martin Kletzander wrote:
> On Fri, Jun 01, 2018 at 11:17:44AM +0100, Daniel P. Berrangé wrote:
> > On Wed, May 30, 2018 at 10:21:54PM +0200, Martin Kletzander wrote:
> > > On Tue, May 29, 2018 at 10:06:25AM -0400, John Ferlan wrote:
> > > >
> > > >
> > > >
On Fri, Jun 01, 2018 at 02:10:56PM +0200, Martin Kletzander wrote:
> On Fri, Jun 01, 2018 at 11:25:35AM +0100, Daniel P. Berrangé wrote:
> > On Wed, May 30, 2018 at 03:43:31PM +0200, Martin Kletzander wrote:
> > > On Wed, May 30, 2018 at 02:16:08PM +0200, Michal Privoznik wrote:
> > > > On 05/29/20
On Fri, Jun 01, 2018 at 01:36:04PM +0200, Ján Tomko wrote:
> To avoid the vs. confusion,
> change to:
>
>
> Signed-off-by: Ján Tomko
> Suggested-by: Daniel P. Berrangé
> ---
> docs/formatdomain.html.in | 6 +++---
> docs/schemas/domaincommon.rng | 4 ++-
On Fri, Jun 01, 2018 at 02:08:38PM +0200, Kashyap Chamarthy wrote:
> Signed-off-by: Kashyap Chamarthy
> ---
> src/qemu/qemu.conf | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
> index 31738ff19c..444247cf31 100644
> --- a/src
On Fri, Jun 01, 2018 at 13:32:20 +0100, Daniel Berrange wrote:
> On Fri, Jun 01, 2018 at 02:08:38PM +0200, Kashyap Chamarthy wrote:
> > Signed-off-by: Kashyap Chamarthy
> > ---
> > src/qemu/qemu.conf | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/qemu/qem
On Fri, Jun 01, 2018 at 01:25:26PM +0100, Daniel P. Berrangé wrote:
On Fri, Jun 01, 2018 at 02:01:03PM +0200, Martin Kletzander wrote:
On Fri, Jun 01, 2018 at 11:17:44AM +0100, Daniel P. Berrangé wrote:
> On Wed, May 30, 2018 at 10:21:54PM +0200, Martin Kletzander wrote:
> > On Tue, May 29, 2018
On Fri, Jun 01, 2018 at 02:46:40PM +0200, Peter Krempa wrote:
> On Fri, Jun 01, 2018 at 13:32:20 +0100, Daniel Berrange wrote:
> > On Fri, Jun 01, 2018 at 02:08:38PM +0200, Kashyap Chamarthy wrote:
> > > Signed-off-by: Kashyap Chamarthy
> > > ---
> > > src/qemu/qemu.conf | 5 +++--
> > > 1 file c
On Fri, Jun 01, 2018 at 02:24:51PM +0200, Ján Tomko wrote:
> On Fri, Jun 01, 2018 at 02:08:38PM +0200, Kashyap Chamarthy wrote:
> > Signed-off-by: Kashyap Chamarthy
> > ---
> > src/qemu/qemu.conf | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
> Why?
Dan already answered it
On Fri, Jun 01, 2018 at 02:11:12PM +0100, Daniel P. Berrangé wrote:
> On Fri, Jun 01, 2018 at 02:46:40PM +0200, Peter Krempa wrote:
> > On Fri, Jun 01, 2018 at 13:32:20 +0100, Daniel Berrange wrote:
[...]
> > > The reason the config file documents 'root' is because that is what
> > > configure de
On Fri, Jun 01, 2018 at 14:14:27 +0200, Jiri Denemark wrote:
> At least since Fedora 26 (maybe earlier, but we don't support older
> Fedora releases), the "tc" tool is provided by a separate iproute-tc
> package.
>
> Signed-off-by: Jiri Denemark
> ---
> libvirt.spec.in | 6 ++
> 1 file chang
We need to check if TLS is enabled as the variable is a tristate.
Currently we'd setup TLS even if it was explicitly turned off.
Thankfully TLS for disks was only used with the vxhs protocol so hardly
anybody would ever be able to hit the problem.
Signed-off-by: Peter Krempa
---
This applies on
On Fri, Jun 01, 2018 at 10:46:03 +0200, Jiri Denemark wrote:
> This has been broken since commit v4.0.0-165-g93412bb827 which added
> jobInfo->statsType enum to distinguish various statistics types. During
> migration the type will always be QEMU_DOMAIN_JOB_STATS_TYPE_MIGRATION,
> however the desti
On Fri, Jun 01, 2018 at 17:23:24 +0200, Peter Krempa wrote:
> We need to check if TLS is enabled as the variable is a tristate.
> Currently we'd setup TLS even if it was explicitly turned off.
> Thankfully TLS for disks was only used with the vxhs protocol so hardly
> anybody would ever be able to
On Fri, Jun 01, 2018 at 10:46:02 +0200, Jiri Denemark wrote:
> If we ever fail to properly set jobinfo->statsType,
> qemuDomainJobInfoToParams would return -1 without setting an error.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_domain.c | 8 +---
> 1 file changed, 5 insertions(+)
On Fri, Jun 01, 2018 at 05:05:30PM +0200, Kashyap Chamarthy wrote:
On Fri, Jun 01, 2018 at 02:11:12PM +0100, Daniel P. Berrangé wrote:
On Fri, Jun 01, 2018 at 02:46:40PM +0200, Peter Krempa wrote:
> On Fri, Jun 01, 2018 at 13:32:20 +0100, Daniel Berrange wrote:
[...]
> > The reason the confi
Emphasize that it's for the 'drive' part of the disk.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_alias.c | 4 ++--
src/qemu/qemu_alias.h | 2 +-
src/qemu/qemu_block.c | 2 +-
src/qemu/qemu_command.c | 4 ++--
src/qemu/qemu_driver.c| 18 +-
src/qemu/qemu_h
Introduce a new setup function for all the related configuration and
move the setup and attachment of the PR code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 8
src/qemu/qemu_block.h | 3 +++
src/qemu/qemu_command.c | 21 +
src/qemu/qemu_command.h
This refactor unifies setup of data for disk hotplug and command line
generation.
This applies on top of
'qemu: Handle managed persisten reservations separately'
as that applies on top of the staging branch for my ACKed refactors
which moved now, you can fetch everything at:
git fetch git://pip
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 9 +
src/qemu/qemu_block.h | 3 +++
src/qemu/qemu_command.c | 9 -
src/qemu/qemu_command.h | 3 ++-
src/qemu/qemu_hotplug.c | 37 +
5 files changed, 23 insertions(+), 38 deletions(-
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 21 +
src/qemu/qemu_block.h | 6 ++
src/qemu/qemu_command.c | 13 +
src/qemu/qemu_hotplug.c | 37 -
4 files changed, 40 insertions(+), 37 deletions(-)
diff --git a
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 106
1 file changed, 62 insertions(+), 44 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 118a412ffa..9fabfdcfef 100644
--- a/src/qemu/qemu_command.c
+++ b
Create a new "Prepare" function and move the drive add code into the new
helpers. This will eventually allow to simplify and unify the attaching
code for use with blockdev at the same time as providing compatibility
with older qemus.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 18 +
Replace access via wrapper by direct call to monitor API.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 6564615597..d8ca894519 100644
--- a/src/qemu
Now that we have one place that sets up all disk-related objects to
qemuBlockStorageSourceAttachDataPtr we can easily reuse the data in the
command-line formatter by implementing a worker which will convert the
data.
A huge advantage is that it will be way easier to integrate this with
-blockdev l
It prepares all disk so use the plural form.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 87b043d3f3..118a412ffa 100644
--- a/src/qemu/qemu_command.c
+++
On Fri, Jun 01, 2018 at 17:31:02 +0200, Peter Krempa wrote:
> On Fri, Jun 01, 2018 at 10:46:02 +0200, Jiri Denemark wrote:
> > If we ever fail to properly set jobinfo->statsType,
> > qemuDomainJobInfoToParams would return -1 without setting an error.
> >
> > Signed-off-by: Jiri Denemark
> > ---
>
It's out with a bit of delay, tagged in git and starball and rpms are
signed and pushed to the usual place:
ftp://libvirt.org/libvirt/
Seems to work fine in my limited testing, still a few red things on
https://ci.centos.org/view/libvirt/ but not the python bindings, so maybe that
one is so
On Fri, Jun 01, 2018 at 05:49:24PM +0200, Ján Tomko wrote:
> On Fri, Jun 01, 2018 at 05:05:30PM +0200, Kashyap Chamarthy wrote:
> > On Fri, Jun 01, 2018 at 02:11:12PM +0100, Daniel P. Berrangé wrote:
> > > On Fri, Jun 01, 2018 at 02:46:40PM +0200, Peter Krempa wrote:
> > > > On Fri, Jun 01, 2018 at
On Fri, Jun 01, 2018 at 17:55:12 +0200, Jiri Denemark wrote:
> On Fri, Jun 01, 2018 at 17:31:02 +0200, Peter Krempa wrote:
> > On Fri, Jun 01, 2018 at 10:46:02 +0200, Jiri Denemark wrote:
> > > If we ever fail to properly set jobinfo->statsType,
> > > qemuDomainJobInfoToParams would return -1 witho
On Fri, Jun 01, 2018 at 17:01:06 +0100, Daniel Berrange wrote:
> On Fri, Jun 01, 2018 at 05:49:24PM +0200, Ján Tomko wrote:
> > On Fri, Jun 01, 2018 at 05:05:30PM +0200, Kashyap Chamarthy wrote:
> > > On Fri, Jun 01, 2018 at 02:11:12PM +0100, Daniel P. Berrangé wrote:
[...]
> > > > Most commented
On Fri, Jun 01, 2018 at 18:04:29 +0200, Jiri Denemark wrote:
> On Fri, Jun 01, 2018 at 17:55:12 +0200, Jiri Denemark wrote:
> > On Fri, Jun 01, 2018 at 17:31:02 +0200, Peter Krempa wrote:
> > > On Fri, Jun 01, 2018 at 10:46:02 +0200, Jiri Denemark wrote:
> > > > If we ever fail to properly set jobi
On Fri, Jun 01, 2018 at 06:04:29PM +0200, Jiri Denemark wrote:
> On Fri, Jun 01, 2018 at 17:55:12 +0200, Jiri Denemark wrote:
> > On Fri, Jun 01, 2018 at 17:31:02 +0200, Peter Krempa wrote:
> > > On Fri, Jun 01, 2018 at 10:46:02 +0200, Jiri Denemark wrote:
> > > > If we ever fail to properly set jo
On 05/28/2018 09:36 AM, Erik Skultety wrote:
On Wed, May 23, 2018 at 04:18:31PM -0500, Brijesh Singh wrote:
The API can be used outside the libvirt to get the launch security
information. When SEV is enabled, the API can be used to get the
measurement of the launch process.
Signed-off-by: Br
在 2018/5/29 下午5:04, Cornelia Huck 写道:
On Mon, 28 May 2018 16:26:57 +0800
Xiao Feng Ren wrote:
On 5/25/2018 6:22 PM, Bjoern Walk wrote:
Cornelia Huck [2018-05-24, 06:25PM +0200]:
On Thu, 24 May 2018 14:24:32 +0200
Xiao Feng Ren wrote:
From: Yi Min Zhao
This commit adds hotplug suppo
在 2018/5/29 下午5:04, Cornelia Huck 写道:
On Mon, 28 May 2018 16:26:57 +0800
Xiao Feng Ren wrote:
On 5/25/2018 6:22 PM, Bjoern Walk wrote:
Cornelia Huck [2018-05-24, 06:25PM +0200]:
On Thu, 24 May 2018 14:24:32 +0200
Xiao Feng Ren wrote:
From: Yi Min Zhao
This commit adds hotplug suppo
On 06/01/2018 04:15 AM, Filip Alac wrote:
Signed-off-by: Filip Alac
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_hostdev.c | 29 -
src/util/virutil.c | 28
src/util/virutil.h | 2 ++
4 files changed, 35 insertions
(Sorry, I missed these while I was off remodeling)
On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> The leading digit from the MAC address should be an even number
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
> ---
> scripts/domain/215-nic-hotplug-many.t | 6 +++---
> 1
On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> The config file may have the URI listed with or without quotes, and the
> nwfilter tests didn't strip quotes before checking against the
> whitelisted URI.
I'm curious what you were doing that you ended up setting this. Running
tests against qem
On Thu, May 31, 2018 at 03:57:20PM -0600, Jim Fehlig wrote:
Per-domain log files were introduced in commit a30b08b7179. The FILE
objects associated with these log files are stored in a hash table
using domid as a key. When a domain is shutdown, destroyed, or
otherwise powered-off, the FILE object
On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> Support for the 'cow' format was delete from QEMU so will always throw
> an error if tried in libvirt with modern QEMU
>
> commit 550830f9351291c585c963204ad9127998b1c1ce
> Author: Stefan Hajnoczi
> Date: Tue Sep 16 15:24:24 2014 +0100
>
On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> Some versions of libvirt/dnsmasq will spawn a child process, so we must
> trim output from ps to only show the first (main) process.
>
> With IPv6 networking we might also get a link local address, which we
> should skip because it will be differe
On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> The ability to use qcow legacy encryption is disabled with QEMU for a
> long time. Switch to using luks encryption, although this is not yet
> fully wired up in libvirt so the tests still (temporarily) fail.
>
> Signed-off-by: Daniel P. Berrangé
On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> Libvirt support for luks-inside-qcow2 is not quite ready yet.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
> ---
> scripts/qemu/100-disk-encryption.t | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/qemu/100-
On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> Libvirt may report two seclabels, one for SELinux and one for DAC. Make
> sure we grab the right one from the XML. Also fix the number of tests.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
> ---
> scripts/selinux/100-static
On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> Perl has started to forbid code from declaring "my $_", because $_ is
> implicitly always a local scope. Rewrite the code to avoid tickling this
> warning.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
> ---
> lib/Sys/Virt/TC
On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> It is reasonable to run TCK against a manually started libvirtd, so we
> should not abort the entire test suite. Just mark the hook scripts as
> skipped.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
(I guess, although it's a
On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> Some versions of libvirt/dnsmasq will spawn a child process, so we must
> trim output from ps to only show the first (main) process.
>
> With IPv6 networking we might also get a link local address, which we
> should skip because it will be differe
On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
> The referenced QEMU bug is long since fixed
>
> Signed-off-by: Daniel P. Berrangé
Heh. Yeah, I saw that one when I was looking at the nwfilter tests a few
months ago, and meant to go back and re-enable it, but didn't manage to
stay focused long
On 06/01/2018 09:06 PM, Laine Stump wrote:
> On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote:
>> The ability to use qcow legacy encryption is disabled with QEMU for a
>> long time. Switch to using luks encryption, although this is not yet
>> fully wired up in libvirt so the tests still (temporaril
1 - 100 of 101 matches
Mail list logo
