Re: [libvirt] [PATCH 3/9] qemu: Reuse qemuBlockStorageSourceAttachApply in disk hotplug

2018-06-03 Thread Peter Krempa
On Sat, Jun 02, 2018 at 17:39:51 +0200, Ján Tomko wrote: > On Fri, Jun 01, 2018 at 05:51:06PM +0200, Peter Krempa wrote: > > Create a new "Prepare" function and move the drive add code into the new > > helpers. This will eventually allow to simplify and unify the attaching > > code for use with blo

Re: [libvirt] [RFC PATCH 6/6] qemu: Format pseries.cap-hpt-mps on the command line

2018-06-03 Thread David Gibson
On Thu, May 24, 2018 at 07:34:25AM +0200, Peter Krempa wrote: > On Wed, May 23, 2018 at 19:09:59 +0200, Andrea Bolognani wrote: > > On Wed, 2018-05-23 at 18:40 +0200, Peter Krempa wrote: > > > On Wed, May 23, 2018 at 18:18:02 +0200, Andrea Bolognani wrote: > > > > +/* QEMU expects the a

Re: [libvirt] [PATCH 05/13] qemu: Auto add pci-root for s390/s390x guests

2018-06-03 Thread Yi Min Zhao
在 2018/6/2 下午10:18, Ján Tomko 写道: On Thu, May 24, 2018 at 02:24:30PM +0200, Xiao Feng Ren wrote: From: Yi Min Zhao The pci-root depends on zpci capability. So autogenerate pci-root if zpci exists. Signed-off-by: Yi Min Zhao Reviewed-by: Boris Fiuczynski Reviewed-by: Stefan Zimmermann Rev

Re: [libvirt] [PATCH libvirt v2 1/9] virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no connectRegisterCloseCallback

2018-06-03 Thread Marc Hartmayer
On Fri, Apr 27, 2018 at 02:16 AM +0200, John Ferlan wrote: > On 04/26/2018 12:09 PM, Marc Hartmayer wrote: >> On Thu, Apr 26, 2018 at 05:06 PM +0200, John Ferlan >> wrote: >>> On 04/12/2018 08:40 AM, Marc Hartmayer wrote: The commit 'close callback: move it to driver' (88f09b75eb99) moved >

Re: [libvirt] [PATCH 04/13] qemu: Enable PCI multi bus for S390 guests

2018-06-03 Thread Yi Min Zhao
在 2018/6/2 下午10:16, Ján Tomko 写道: On Thu, May 24, 2018 at 02:24:29PM +0200, Xiao Feng Ren wrote: From: Yi Min Zhao QEMU on s390 supports PCI multibus since forever. But zPCI, as extension of PCI device on s390, is the significant capability. Only when zPCI capability is existing, we consider

Re: [libvirt] [PATCH 01/13] conf: Add definitions for 'uid' and 'fid' PCI address attributes

2018-06-03 Thread Yi Min Zhao
在 2018/6/2 下午10:12, Ján Tomko 写道: On Thu, May 24, 2018 at 02:24:26PM +0200, Xiao Feng Ren wrote: From: Yi Min Zhao Add zPCI definitions in preparation of extending the PCI address with parameters uid (user-defined identifier) and fid (PCI function identifier). Signed-off-by: Yi Min Zhao Re

Re: [libvirt] [PATCH 11/13] tests: Add new tests for zPCI

2018-06-03 Thread Yi Min Zhao
在 2018/6/2 下午10:26, Ján Tomko 写道: On Thu, May 24, 2018 at 02:24:36PM +0200, Xiao Feng Ren wrote: From: Yi Min Zhao This patch adds new test cases for zPCI when 'uid' and 'fid' are defined with different conditions in XML. Signed-off-by: Yi Min Zhao Reviewed-by: Boris Fiuczynski Reviewed-b

Re: [libvirt] [RFC PATCH 2/2] conf: Extend cputune/cachetune to support memory bandwidth allocation

2018-06-03 Thread bing.niu
Hi Jano, Thanks for review, please see my response. On 2018年06月02日 22:54, Ján Tomko wrote: On Tue, May 29, 2018 at 06:58:03PM +0800, bing@intel.com wrote: From: Bing Niu Extend current cachetune section to support memory bandwidth allocation. Add a new cachetune element llc for memory all

Re: [libvirt] [RFC PATCH 1/2] util: Add memory bandwidth support to resctrl

2018-06-03 Thread bing.niu
Hi Jano, Thanks a lot for the review! please see my reply below. On 2018年06月02日 22:50, Ján Tomko wrote: On Tue, May 29, 2018 at 06:58:02PM +0800, bing@intel.com wrote: From: Bing Niu Add memory bandwidth allocation support basing on existing virresctrl implementation. Two new structures

[libvirt] Ping Re: [PATCH] conf: Introduce align for hostmem-file

2018-06-03 Thread WangJie (Pluto)
Ping? On 2018/5/29 20:38, Jie Wang wrote: > QEMU has add the 'align' option to 'memory-backend-file'. Expose > this option to users by new element align. > > Signed-off-by: Jie Wang > --- > docs/formatdomain.html.in | 18 +++ > docs/schemas/domaincommon.rng

[libvirt] [PATCH 2/2] vircgroup: Add virCgroupSetupMemtune()

2018-06-03 Thread Fabiano Fidêncio
virCgroupSetupMemtune() has been introduced in order to remove the code duplication present between virLXCCgroupSetupMemTune() and qemuSetupMemoryCgroup(). Signed-off-by: Fabiano Fidêncio --- src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 20 ++-- src/qemu/qemu_cgrou

[libvirt] [PATCH 0/2] Share cgroup code that is duplicated between QEMU and LXC

2018-06-03 Thread Fabiano Fidêncio
virLXCCgroupSetupBlkioTune() and qemuSetupBlkioCgroup() and virLXCCgroupSetupCpuTune() and qemuSetupCpuCgroup() are the most similar functions between QEMU and LXC code. Let's move their common code to virCgroup. Fabiano Fidêncio (2): vircgroup: Add virCgroupSetupBlkiotune() vircgroup: Add vi

[libvirt] [PATCH 1/2] vircgroup: Add virCgroupSetupBlkiotune()

2018-06-03 Thread Fabiano Fidêncio
virCgroupSetupBlkiotune() has been introduced in order to remove the code duplication present between virLXCCgroupSetupBlkioTune() and qemuSetupBlkioCgroup(). Signed-off-by: Fabiano Fidêncio --- src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 49 +-

Re: [libvirt] [PATCH v8 10/18] conf: Add support for choosing emulation of a TPM 2

2018-06-03 Thread Stefan Berger
On 06/02/2018 09:27 AM, Ján Tomko wrote: On Thu, May 24, 2018 at 04:26:06PM -0400, Stefan Berger wrote: This patch extends the TPM's device XML with TPM 2 support. This only works for the emulator type backend and looks as follows:       The swtpm process now has --tpm2 as an addition

Re: [libvirt] [PATCH v8 13/18] security: Add swtpm paths to the domain's AppArmor profile

2018-06-03 Thread Stefan Berger
On 06/02/2018 09:32 AM, Ján Tomko wrote: On Thu, May 24, 2018 at 04:26:09PM -0400, Stefan Berger wrote: This patch extends the AppArmor domain profile with file paths the swtpm accesses for state, log, pid, and socket files. Both, QEMU and swtpm, use this AppArmor profile. Signed-off-by: Stefa

Re: [libvirt] [PATCH] bhyve: add support for passing stdin to loader

2018-06-03 Thread Roman Bogorodskiy
Fabian Freyer wrote: > On 26 Apr 2018, at 18:38, John Ferlan wrote: > > > On 04/13/2018 03:27 PM, Fabian Freyer wrote: > >> This commit adds the node to the domain definition, > >> with the following semantics: > >> > >> To pass standard input verbatim to the bootloader, set > >> > >> some