On 05/17/2018 05:43 PM, Eric Blake wrote:
Here's my updated counterproposal for a backup API.
/**
* virDomainBackupBegin:
*
* There are two fundamental backup approaches. The first, called a
* push model, instructs the hypervisor to copy the state of the guest
* disk to the desi
On 06/07/2018 12:19 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> This patch introduces --all to show all block devices info
> of guests like:
>
> virsh # domblkinfo w08 --all
> Target CapacityAllocation Physical
> ---
> hda
Since virConfGetValueBool() can return earlier, the parameter 'value'
might be not initialised properly inside this method. Another proof:
Valgrind is returning this error during the libvirtd daemon startup:
==16199== Conditional jump or move depends on uninitialised value(s)
==16199==at 0x27F
On 05/17/2018 05:43 PM, Eric Blake wrote:
Here's my updated counterproposal for a backup API.
/**
* virDomainBackupEnd:
* @domain: a domain object
* @id: the id of an active backup job previously started with
* virDomainBackupBegin()
* @flags: bitwise-OR of supported virDomainB
On 06/08/2018 03:45 AM, Peter Krempa wrote:
> On Thu, Jun 07, 2018 at 22:02:06 -0400, John Ferlan wrote:
>>
>>
>> On 06/04/2018 09:58 AM, Peter Krempa wrote:
>>> Use qemuMonitorTestNewFromFileFull which allows to test commands used
>>> along with providing replies. This has two advantages:
>>>
>
Add missing data files for bhyve cpu topology tests that should have been
added in b66fda0a74.
Signed-off-by: Roman Bogorodskiy
---
Pushed under the build breaker rule.
...yvexml2argv-cputopology-nvcpu-mismatch.xml | 26 +++
.../bhyvexml2argv-cputopology.args| 9 +++
Andrea Bolognani wrote:
> On Tue, 2018-05-29 at 20:57 +0400, Roman Bogorodskiy wrote:
> > Changes since v1:
> >
> > - Added a check that nvcpus == sockets * cores * threads and
> >a test for that.
> >
> > Roman Bogorodskiy (2):
> > bhyve: add CPU topology support
> > docs: bhyve: doc
Commit id d8e8b63d introduced the test, but neglected to check for
error from virTestLoadFile in testCompareXMLToDomConfig.
Found by Coverity
Signed-off-by: John Ferlan
---
tests/libxlxml2domconfigtest.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/libxlxml2domco
Commit id '7ef0471bf' added a new parameter to qemuMonitorOpen,
but didn't update the ATTTRIBUTE_NONNULL for the @cb (param 5).
Signed-off-by: John Ferlan
---
src/qemu/qemu_monitor.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monit
Resolve a few things that have built up previous and a couple
that are more recent.
John Ferlan (6):
vbox: Fix resource leak
vbox: Fix resource leak
qemu: Fix Coverity build for qemu_monitor
test: Fix resource leak in qemumonitorjsontest
test: Check return status for libxlxml2domconfigte
Commit id 1bd5a08d added a call to virXMLFormatElement without
also checking the return status.
Found by Coverity.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index ab
Need to free the allocated hardDiskToOpen array. The contents of the
array are just pointers returned by virVBoxSnapshotConfHardDiskByLocation
and not allocated AFAICT so they don't need to also be freed as well.
Found by Coverity
Signed-off-by: John Ferlan
---
src/vbox/vbox_common.c | 8 --
Introduced by commmit id 37bd4571c. Need to goto cleanup and
not return directly.
Found by Coverity
Signed-off-by: John Ferlan
---
tests/qemumonitorjsontest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
index 3b49
The @disk was allocated, filled in, and consumed on the normal path,
but for error/cleanup paths it would be leaked. Rename to newHardDisk
and manage properly.
Found by Coverity
Signed-off-by: John Ferlan
---
src/vbox/vbox_common.c | 20 +++-
1 file changed, 11 insertions(+), 9
On Mon, May 28, 2018 at 12:28:22AM +0200, Fabiano Fidêncio wrote:
Signed-off-by: Fabiano Fidêncio
---
src/vmx/vmx.c | 194 +-
1 file changed, 70 insertions(+), 124 deletions(-)
-if (virUUIDParse(value->str, uuid) < 0) {
-virRepo
On Mon, May 28, 2018 at 12:28:21AM +0200, Fabiano Fidêncio wrote:
Signed-off-by: Fabiano Fidêncio
---
src/xenconfig/xen_xm.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: Digital signature
--
libvir
On Mon, May 28, 2018 at 12:28:20AM +0200, Fabiano Fidêncio wrote:
xenParseXMDisk() does a lot of stuff and, in order to make things
cleaner, let's split it in two new functions:
- xenParseXMDisk(): it's a new function that keeps the old name. It's
responsible for the whole per-disk logic from the
On 06/08/2018 07:09 AM, Erik Skultety wrote:
> On Mon, Jun 04, 2018 at 07:40:42PM -0400, John Ferlan wrote:
>>
>>
>> On 05/30/2018 09:43 AM, Erik Skultety wrote:
>>> Signed-off-by: Erik Skultety
>>> ---
>>> src/qemu/qemu_command.c| 24 +++-
>>> .../hostd
On Fri, Jun 08, 2018 at 11:52:07AM -0400, Laine Stump wrote:
> Signed-off-by: Laine Stump
> ---
> lib/Sys/Virt/TCK.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm
> index 78d3774..67eb5f0 100644
> --- a/lib/Sys/Virt/TCK.pm
> +
Signed-off-by: Laine Stump
---
lib/Sys/Virt/TCK.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm
index 78d3774..67eb5f0 100644
--- a/lib/Sys/Virt/TCK.pm
+++ b/lib/Sys/Virt/TCK.pm
@@ -1259,7 +1259,7 @@ sub get_network_ip {
if ($n
[...]
if (mdevsrc->display)
>>
>> ->display > VIR_TRISTATE_SWITCH_ABSENT
>>
>>> +virBufferAsprintf(buf, " display='%s'",
>>> +
>>> virTristateSwitchTypeToString(mdevsrc->display));
>>> +}
>>> +
>>> }
>>> virBufferAddLit(b
On Fri, Jun 08, 2018 at 11:29:35AM -0400, Laine Stump wrote:
> On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote:
> > Despite having StrictHostKeyChecking=no, SSH still complains about the
> > host key mismatch and disables password auth as a result. Using
> > /dev/null as the known_hosts file ensur
On Fri, Jun 08, 2018 at 11:42:14AM -0400, Laine Stump wrote:
> On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote:
> > The source file headers all say GPL and do not mention the Artistic
> > license, likewise the Build.PL file and RPM Spec. Remove bogus
> > references to the Artistic license from the
On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
What? You've found a style error in my cargo-cult perl? Astounding!! :-P
(My recollection is that I tried several different combinations until I
hit on one that worked. I don't perl so good...)
Reviewed-by: La
On Fri, Jun 08, 2018 at 11:38:07AM -0400, Laine Stump wrote:
> On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote:
> > The TCK module requires stuff in the NetworkHelpers and also vica-verca.
> > This circular dependancy causes import problems, when trying to use the
> > functions in NetworkHelpers f
On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote:
> The source file headers all say GPL and do not mention the Artistic
> license, likewise the Build.PL file and RPM Spec. Remove bogus
> references to the Artistic license from the LICENSE file.
>
> Signed-off-by: Daniel P. Berrangé
So what's the
On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
I don't pretend to know much of anything about this testing framework,
but I guess this make the code here more like what's in the other files.
Reviewed-by: Laine Stump
> ---
> lib/Sys/Virt/TCK.pm | 20
On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote:
> The TCK module requires stuff in the NetworkHelpers and also vica-verca.
> This circular dependancy causes import problems, when trying to use the
> functions in NetworkHelpers from the TCK module.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-
On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote:
> Despite having StrictHostKeyChecking=no, SSH still complains about the
> host key mismatch and disables password auth as a result. Using
> /dev/null as the known_hosts file ensures the keys are never saved to
> the user's profile.
Interesting. I
On 06/08/2018 11:10 AM, Daniel P. Berrangé wrote:
> I do still need to figure out just which APIs from newer libvirt
> we require.
I had added a function that uses the (relatively new I guess) API to get
guest IP addresses, but wrote the code so that it would fall back to the
older method of parsi
On Fri, May 11, 2018 at 01:57:43PM +0200, Katerina Koukiou wrote:
Katerina Koukiou (8):
Introduce NWFilter Interface
Implement ListNWFilters method for Connect Interface
Implement NWFilterDefineXML method for Connect Interface
We have define, but there's no Undefine.
Jano
Implement Name
On Fri, May 11, 2018 at 01:57:51PM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 29 +
2 files changed, 35 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Descri
On Fri, May 11, 2018 at 01:57:50PM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 29 +
2 files changed, 35 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Descri
On Fri, May 11, 2018 at 01:57:49PM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.NWFilter.xml | 6 ++
src/nwfilter.c| 28
2 files changed, 34 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Descr
On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
> ---
> .gitignore | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index ca3e424..65b446f 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -3,7
On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> conf/default.cfg | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/conf/default.cfg b/conf/default.cfg
> index d9d858c..494c303 100644
> --- a/conf/default.cfg
> +++ b
Re: Jano's below comment
(Also, some of the patches have double "<< >>" around your e-mail,
how did that happen?)
I am not sure what I am doing that is causing the double "<< >>" around
my email address in some patches. I tried fixing it after I saw Jano
note but it somehow happens again...I
On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
> ---
> Build.PL | 12 +++-
> MANIFEST | 1 -
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/Build.PL b/Build.PL
> index bf2d7a9..75a1436 100644
> --- a/
On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote:
> The changelog entries only make sense in the context of a distro, not
> upstream.
If even that. I don't recall *ever* getting any useful info from the
changelog (and wouldn't trust it anyway, since it's just manually
written from the POV of one p
On Fri, May 11, 2018 at 01:57:48PM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.NWFilter.xml | 5 +
src/nwfilter.c| 21 +
2 files changed, 26 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description:
On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
> ---
> perl-Sys-Virt-TCK.spec.PL | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
> index d3544b6..49
On Fri, Jun 08, 2018 at 11:07:13AM -0400, Laine Stump wrote:
> On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote:
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > perl-Sys-Virt-TCK.spec.PL | 15 ---
> > 1 file changed, 12 insertions(+), 3 deletions(-)
> >
> > diff --git a/perl-Sys-Vir
On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
> ---
> perl-Sys-Virt-TCK.spec.PL | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
> index 2d5c38b..d3544b6 100644
> --- a
On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
> ---
> perl-Sys-Virt-TCK.spec.PL | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
> index b4cb4a9..2d5c38b 100644
> --- a
On Fri, May 11, 2018 at 01:57:47PM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.NWFilter.xml | 5 +
src/nwfilter.c| 43 +++
2 files changed, 48 insertions(+)
Reviewed-by: Ján Tomko
Jano
signa
On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
> ---
> perl-Sys-Virt-TCK.spec.PL | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
> index c92fa34..b4cb4a9 100644
> -
On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> perl-Sys-Virt-TCK.spec.PL | 15 ---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
> index 39cc72f..c92fa34 100644
>
On Fri, Jun 08, 2018 at 10:59:58AM -0400, Laine Stump wrote:
> My own machine has a virtual network on 192.168.123.0/24, and I've
> been told that it's a common selection for people who create a second
> network after libvirt's default (and in the past was used as a manual
> alternative for the def
On Fri, Jun 08, 2018 at 11:00:34AM -0400, Laine Stump wrote:
> When new pids are more than 9 digits long
>
> The nwfilter tests use tck-test${pid} as the auto-generated name for
> their test domains (and therefore the tap devices created for those
> test domains). When the pid is > 9 digits long,
On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
> ---
> perl-Sys-Virt-TCK.spec.PL | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
> index 4b1683f..39cc7
On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote:
> We don't need to manually build variables for perl install locations
> as RPM includes that.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
> ---
> perl-Sys-Virt-TCK.spec.PL | 16
> 1 file changed, 4 insertion
When new pids are more than 9 digits long
The nwfilter tests use tck-test${pid} as the auto-generated name for
their test domains (and therefore the tap devices created for those
test domains). When the pid is > 9 digits long, the total length of
the name is > 16, which is the maximum length for a
My own machine has a virtual network on 192.168.123.0/24, and I've
been told that it's a common selection for people who create a second
network after libvirt's default (and in the past was used as a manual
alternative for the default network itself when 192.168.122.0/24
casued a conflict). Changin
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index 4b1683f..69e5621 100644
--- a/perl-Sys-Virt-TCK.spec.PL
+++ b/perl-Sys-Virt-TCK.spec.PL
Signed-off-by: Daniel P. Berrangé
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index ca3e424..65b446f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,7 +3,10 @@
*.orig
*~
Build
+META.json
META.yml
+MYMETA.json
+MYMETA.yml
Makefile
Makefile.PL
The source file headers all say GPL and do not mention the Artistic
license, likewise the Build.PL file and RPM Spec. Remove bogus
references to the Artistic license from the LICENSE file.
Signed-off-by: Daniel P. Berrangé
---
LICENSE | 159 ---
Signed-off-by: Daniel P. Berrangé
---
conf/default.cfg | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/conf/default.cfg b/conf/default.cfg
index d9d858c..494c303 100644
--- a/conf/default.cfg
+++ b/conf/default.cfg
@@ -49,7 +49,7 @@ images = (
hvm
xe
The changelog entries only make sense in the context of a distro, not
upstream.
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 2 --
1 file changed, 2 deletions(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index a9b4148..0026b7e 100644
--- a/perl-Sys-
Signed-off-by: Daniel P. Berrangé
---
lib/Sys/Virt/TCK.pm | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm
index 29280f6..1a835bd 100644
--- a/lib/Sys/Virt/TCK.pm
+++ b/lib/Sys/Virt/TCK.pm
@@ -35,7 +35,7 @@ use XML
Signed-off-by: Daniel P. Berrangé
---
Build.PL | 12 +++-
MANIFEST | 1 -
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/Build.PL b/Build.PL
index bf2d7a9..75a1436 100644
--- a/Build.PL
+++ b/Build.PL
@@ -61,6 +61,9 @@ EOF
my $b = $class->new(
module_name => "Sys::V
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index 0dea8de..a9b4148 100644
--- a/perl-Sys-Virt-TCK.spec.PL
+++ b/perl-Sys-Virt-TCK.spec.PL
@@ -105,10 +10
The TCK module requires stuff in the NetworkHelpers and also vica-verca.
This circular dependancy causes import problems, when trying to use the
functions in NetworkHelpers from the TCK module.
Signed-off-by: Daniel P. Berrangé
---
MANIFEST | 1 -
lib/Sys/Virt/T
We don't need to manually build variables for perl install locations
as RPM includes that.
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
i
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 1 -
1 file changed, 1 deletion(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index be40d40..ab2194f 100644
--- a/perl-Sys-Virt-TCK.spec.PL
+++ b/perl-Sys-Virt-TCK.spec.PL
@@ -34,7 +34,6 @@ License: GPLv2
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 1 -
1 file changed, 1 deletion(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index ab2194f..0dea8de 100644
--- a/perl-Sys-Virt-TCK.spec.PL
+++ b/perl-Sys-Virt-TCK.spec.PL
@@ -31,7 +31,6 @@ Name: perl-%{app
Signed-off-by: Daniel P. Berrangé
---
lib/Sys/Virt/TCK.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm
index 60bd136..78d3774 100644
--- a/lib/Sys/Virt/TCK.pm
+++ b/lib/Sys/Virt/TCK.pm
@@ -1275,7 +1275,7 @@ sub get_ip_from_leases{
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 4
1 file changed, 4 deletions(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index 69e5621..be40d40 100644
--- a/perl-Sys-Virt-TCK.spec.PL
+++ b/perl-Sys-Virt-TCK.spec.PL
@@ -105,10 +105,6 @@ find $RPM
Some final misc fixes before doing a new release
Daniel P. Berrangé (15):
rpm: use standard perl variables
rpm: add some missing dependencies
rpm: remove obsolete clean section
rpm: remove obsolete build root setting
rpm: remove obsolete group setting
rpm: cleanup docs file list
rpm:
Despite having StrictHostKeyChecking=no, SSH still complains about the
host key mismatch and disables password auth as a result. Using
/dev/null as the known_hosts file ensures the keys are never saved to
the user's profile.
Signed-off-by: Daniel P. Berrangé
---
scripts/nwfilter/210-no-mac-spoof
They're both pretty much guaranteed to be dragged in by
other packages already, but since we're being explicit in
the spec file might as well be explicit here too.
Signed-off-by: Andrea Bolognani
---
guests/vars/mappings.yml | 10 ++
guests/vars/projects/libvirt.yml | 2 ++
2 fi
On Fri, Jun 08, 2018 at 02:45:39PM +0100, Daniel P. Berrangé wrote:
> Some final misc fixes before doing a new release
Self-NACK. Some more things need fixing and the license change
patch is actually wrong.
>
> Daniel P. Berrangé (12):
> rpm: use standard perl variables
> rpm: fix license ta
The API can be used by application to retrieve the Platform Diffie-Hellman
Key and Platform Certificate chain.
Signed-off-by: Brijesh Singh
Reviewed-by: Erik Skultety
---
include/libvirt/libvirt-host.h | 42
src/driver-hypervisor.h| 6 ++
src/li
Add remote support for launch security info.
Signed-off-by: Brijesh Singh
Reviewed-by: Erik Skultety
---
src/remote/remote_daemon_dispatch.c | 47 +
src/remote/remote_driver.c | 40 +++
src/remote/remote_protocol.x
Extend hypervisor capabilities to include sev feature. When available,
hypervisor supports launching an encrypted VM on AMD platform. The
sev feature tag provides additional details like Platform Diffie-Hellman
(PDH) key and certificate chain which can be used by the guest owner to
establish a cryp
QEMU uses /dev/sev device while creating the SEV guest, lets add /dev/sev
in the list of devices allowed to be accessed by the QEMU.
Signed-off-by: Brijesh Singh <>
Reviewed-by: Erik Skultety
---
docs/drvqemu.html.in | 3 ++-
src/qemu/qemu.conf | 2 +-
src/qemu/qemu
This patch implements the internal driver API for launch event into
qemu driver. When SEV is enabled, execute 'query-sev-launch-measurement'
to get the measurement of memory encrypted through launch sequence.
Signed-off-by: Brijesh Singh
Reviewed-by: Erik Skultety
---
src/qemu/qemu_driver.c
The API can be used outside the libvirt to get the launch security
information. When SEV is enabled, the API can be used to get the
measurement of the launch process.
Signed-off-by: Brijesh Singh
Reviewed-by: Erik Skultety
---
include/libvirt/libvirt-domain.h | 17 ++
src/driver-hyp
QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted
VMs on AMD platform using SEV feature. The various inputs required to
launch SEV guest is provided through the tag. A typical
SEV guest launch command line looks like this:
# $QEMU ...\
-object sev-guest,id=sev0,cbitpos=
The launch-security element can be used to define the security
model to use when launching a domain. Currently we support 'sev'.
When 'sev' is used, the VM will be launched with AMD SEV feature enabled.
SEV feature supports running encrypted VM under the control of KVM.
Encrypted VMs have their pa
Signed-off-by: Brijesh Singh <>
---
src/qemu/qemu_capabilities.c | 7
src/qemu/qemu_capabilities.h | 4 +++
src/qemu/qemu_driver.c | 82
3 files changed, 93 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabiliti
Add remote support for virNodeGetSEVInfo().
Signed-off-by: Brijesh Singh
Reviewed-by: Erik Skultety
---
src/remote/remote_daemon_dispatch.c | 44 +
src/remote/remote_driver.c | 40 +
src/remote/remote_protocol.x
This patch series provides support for launching an encrypted guest using
AMD's new Secure Encrypted Virtualization (SEV) feature.
SEV is an extension to the AMD-V architecture which supports running
multiple VMs under the control of a hypervisor. When enabled, SEV feature
allows the memory conte
QEMU version >= 2.12 provides support for launching an encrypted VMs on
AMD x86 platform using Secure Encrypted Virtualization (SEV) feature.
This patch adds support to query the SEV capability from the qemu.
Signed-off-by: Brijesh Singh
Reviewed-by: Erik Skultety
---
src/conf/domain_capabiliti
On Fri, May 11, 2018 at 01:57:46PM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 29 +
2 files changed, 35 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Descri
Recent versions of Ansible point out this mistake too.
Signed-off-by: Andrea Bolognani
---
To be applied on top of
https://www.redhat.com/archives/libvir-list/2018-June/msg00685.html
Should have posted both at the same time as a series, but
it's too late for that now ¯\_(ツ)_/¯
guests/tasks/
On Fri, May 11, 2018 at 01:57:45PM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
data/org.libvirt.Connect.xml | 6 ++
src/connect.c| 38 ++
2 files changed, 44 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.a
On Fri, May 11, 2018 at 01:57:44PM +0200, Katerina Koukiou wrote:
Signed-off-by: Katerina Koukiou
---
data/Makefile.am | 1 +
data/org.libvirt.NWFilter.xml | 7 +
src/Makefile.am | 1 +
src/connect.c | 6
src/connect.h | 1 +
sr
Despite having StrictHostKeyChecking=no, SSH still complains about the
host key mismatch and disables password auth as a result. Using
/dev/null as the known_hosts file ensures the keys are never saved to
the user's profile.
Signed-off-by: Daniel P. Berrangé
---
scripts/nwfilter/210-no-mac-spoof
These jobs can be used to mark job type over qemu agent.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_domain.c | 4 +++-
src/qemu/qemu_domain.h | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 09404f6569..e5e11f0cb7
The changelog entries only make sense in the context of a distro, not
upstream.
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 2 --
1 file changed, 2 deletions(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index 49f4a3c..42d2cef 100644
--- a/perl-Sys-
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index 39cc72f..c92fa34 100644
--- a/perl-Sys-Virt-TCK.spec.PL
+++ b/perl-Sys-Virt-TCK.spec.PL
Signed-off-by: Daniel P. Berrangé
---
Build.PL | 12 +++-
MANIFEST | 1 -
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/Build.PL b/Build.PL
index bf2d7a9..75a1436 100644
--- a/Build.PL
+++ b/Build.PL
@@ -61,6 +61,9 @@ EOF
my $b = $class->new(
module_name => "Sys::V
Signed-off-by: Daniel P. Berrangé
---
conf/default.cfg | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/conf/default.cfg b/conf/default.cfg
index d9d858c..494c303 100644
--- a/conf/default.cfg
+++ b/conf/default.cfg
@@ -49,7 +49,7 @@ images = (
hvm
xe
Signed-off-by: Daniel P. Berrangé
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index ca3e424..65b446f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,7 +3,10 @@
*.orig
*~
Build
+META.json
META.yml
+MYMETA.json
+MYMETA.yml
Makefile
Makefile.PL
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index d3544b6..49f4a3c 100644
--- a/perl-Sys-Virt-TCK.spec.PL
+++ b/perl-Sys-Virt-TCK.spec.PL
@@ -105,10 +10
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index 4b1683f..39cc72f 100644
--- a/perl-Sys-Virt-TCK.spec.PL
+++ b/perl-Sys-Virt-TCK.spec.PL
@@ -30,7 +30,7 @@
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 4
1 file changed, 4 deletions(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index c92fa34..b4cb4a9 100644
--- a/perl-Sys-Virt-TCK.spec.PL
+++ b/perl-Sys-Virt-TCK.spec.PL
@@ -105,10 +105,6 @@ find $RPM
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 1 -
1 file changed, 1 deletion(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
index 2d5c38b..d3544b6 100644
--- a/perl-Sys-Virt-TCK.spec.PL
+++ b/perl-Sys-Virt-TCK.spec.PL
@@ -31,7 +31,6 @@ Name: perl-%{app
The point is to break QEMU_JOB_* into smaller pieces which
enables us to achieve higher throughput. For instance, if there
are two threads, one is trying to query something on qemu
monitor while the other is trying to query something on agent
monitor these two threads would serialize. There is not
We don't need to manually build variables for perl install locations
as RPM includes that.
Signed-off-by: Daniel P. Berrangé
---
perl-Sys-Virt-TCK.spec.PL | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL
i
1 - 100 of 136 matches
Mail list logo
