[libvirt] [jenkins-ci POC 1/2] guests: Remove OS detection

We're going to need information about the OS outside of Ansible soon, so drop the OS detection code and start storing the information as host variables instead. Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-centos-7/main.yml| 4 ++ guests/host_vars/libvirt-debian-8/main.yml

[libvirt] [jenkins-ci POC 2/2] guests: Add Dockerfile generator

This is basically the exact same algorithm used by the Ansible playbooks to process package mappings, implemented as a standalone script. There's little to none error handling, and some information is hardcoded instead of being configurable at runtime; more importantly, before it can be considered

[libvirt] [jenkins-ci POC 0/2] guests: Add Dockerfile generator

See 2/2 for details. Andrea Bolognani (2): guests: Remove OS detection guests: Add Dockerfile generator guests/dockerfile-generator | 72 +++ guests/host_vars/libvirt-centos-7/docker.yml | 2 + guests/host_vars/libvirt-centos-7/main.yml| 4 ++ guests/

Re: [libvirt] [dbus PATCH v2 04/17] tests: rename test_* functions which are not tests

On Thu, Jun 14, 2018 at 05:59:40PM +0200, Katerina Koukiou wrote: > pytest collects functions starting with test prefix > to run them as tests by default. > > Rename functions that are not supposed to be run as tests, > to avoid unexpected failures. > > Note: this commit also renames domain funct

Re: [libvirt] [dbus PATCH v2 05/17] Implement StorageVolCreateXML method for StoragePool Interface

On Thu, Jun 14, 2018 at 05:59:41PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.StoragePool.xml | 7 +++ > src/storagepool.c| 34 ++ > tests/libvirttest.py | 31 ++

Re: [libvirt] [dbus PATCH v2 03/17] test: move XML definition of entities to seperate file

On Thu, Jun 14, 2018 at 05:59:39PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > tests/test_connect.py | 47 +++ > tests/xmldata.py | 37 + > 2 files changed, 44 insertions(+), 40 delet

Re: [libvirt] [dbus PATCH v2 01/17] Introduce StorageVol Interface

On Thu, Jun 14, 2018 at 05:59:37PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/Makefile.am| 4 ++- > data/org.libvirt.StorageVol.xml | 7 > src/Makefile.am | 4 ++- > src/connect.c | 6 > src/connect

Re: [libvirt] [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

On Thu, Jun 14, 2018 at 09:09:48AM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 03:05:08PM -0300, Eduardo Habkost wrote: > > Getting back to this discussion: > > > > On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jun 05, 2018 at 09:27:46AM +0200, Ge

Re: [libvirt] [PATCH v2 3/3] news: add cmdDomblkinfo --all option

On 06/11/2018 06:52 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Update news for cmdDomblkinfo --all option. > > Signed-off-by: Chen Hanxiao > --- > docs/news.xml | 8 > 1 file changed, 8 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index e0cf381f33..c07db048

Re: [libvirt] [PATCH v2 2/3] cmdDomblkinfo: add --all to show all block devices info

On 06/11/2018 06:52 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > This patch introduces --all to show all block devices info > of guests like: > > virsh # domblkinfo --all > Target CapacityAllocation Physical > --- > hda

Re: [libvirt] [PATCH v2 1/3] cmdDomblkinfo: introduce helper cmdDomblkinfoPrint

On 06/11/2018 06:52 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Introduce helper cmdDomblkinfoPrint for printing. > > Signed-off-by: Chen Hanxiao > --- > tools/virsh-domain-monitor.c | 39 ++-- > 1 file changed, 24 insertions(+), 15 deletions(-) > Revi

[libvirt] [PATCH v2 06/11] qemu: assign addresses to virtio devices on RISC-V

Signed-off-by: Lubomir Rintel --- src/qemu/qemu_domain_address.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 01cfdbeadf..d3259212f5 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_do

[libvirt] [PATCH v2 04/11] docs/schemas: add RISC-V architectures

Signed-off-by: Lubomir Rintel --- docs/schemas/basictypes.rng | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng index 1a18cd31b1..14a3670e5c 100644 --- a/docs/schemas/basictypes.rng +++ b/docs/schemas/basictypes.rng @@ -398,6 +398,8 @@

[libvirt] [PATCH v2 10/11] tests/qemuxml2argvtest: test RISC-V virt machine arguments

Signed-off-by: Lubomir Rintel --- tests/qemuxml2argvdata/riscv64-virt.args | 31 +++ tests/qemuxml2argvdata/riscv64-virt.xml | 32 +++ tests/qemuxml2argvtest.c | 3 ++ .../riscv64-virt.xml | 39 +++

[libvirt] [PATCH v2 02/11] qemu: rename qemuDomainArmVirt()

It's ARM specific. Signed-off-by: Lubomir Rintel --- src/qemu/qemu_capabilities.c | 4 ++-- src/qemu/qemu_command.c| 4 ++-- src/qemu/qemu_domain.c | 16 src/qemu/qemu_domain.h | 2 +- src/qemu/qemu_domain_address.c | 4 ++-- 5 files changed, 15 ins

[libvirt] [PATCH v2 08/11] tests/util: add RISC-V capabilities

Signed-off-by: Lubomir Rintel --- tests/testutilsqemu.c | 72 +++ 1 file changed, 72 insertions(+) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index dc7e90b952..c6376262b9 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -28

[libvirt] [PATCH v2 03/11] util: add RISC-V architectures

Signed-off-by: Lubomir Rintel --- src/qemu/qemu_domain.c | 2 ++ src/util/virarch.c | 3 +++ src/util/virarch.h | 6 ++ 3 files changed, 11 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index dfaba677b1..275090fb58 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt] [PATCH v2 11/11] tests/virschematest: add RISC-V to capabilityschemadata/caps-qemu-kvm

Signed-off-by: Lubomir Rintel --- tests/capabilityschemadata/caps-qemu-kvm.xml | 36 1 file changed, 36 insertions(+) diff --git a/tests/capabilityschemadata/caps-qemu-kvm.xml b/tests/capabilityschemadata/caps-qemu-kvm.xml index 88ec89e733..1aa98d140f 100644 --- a/tests/cap

[libvirt] [PATCH v2 09/11] tests/captest: check RISC-V capabilities lookup

Signed-off-by: Lubomir Rintel --- tests/vircapstest.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/vircapstest.c b/tests/vircapstest.c index 1df3fa091f..e016e466d2 100644 --- a/tests/vircapstest.c +++ b/tests/vircapstest.c @@ -180,6 +180,12 @@ test_virCapsDomainDataLookupQEMU(c

[libvirt] [PATCH v2 01/11] qemu: rename qemuDomainMachineIsVirt()

It's ARM specific. Signed-off-by: Lubomir Rintel --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_domain.c | 6 +++--- src/qemu/qemu_domain.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c ind

[libvirt] [PATCH v2 05/11] qemu: no USB by default on RISC-V machines

Signed-off-by: Lubomir Rintel --- src/qemu/qemu_domain.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 275090fb58..72b72364d5 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3198,6 +3198,11 @@

[libvirt] [PATCH v2 00/11] RISC-V Guest Support

Hello, here's a second version of the RISV-V support patch set, initally submitted just under a month ago [1]. [1] https://www.redhat.com/archives/libvir-list/2018-May/thread.html#01008 Thanks to the Andrea's suggestions the patch is now considerably thinner, and split to hopefully more manageab

Re: [libvirt] [PATCH v2 0/6] travis: Various cleanups and fixes

On Thu, Jun 14, 2018 at 06:53:33PM +0200, Andrea Bolognani wrote: > Changes from [v1]: > > * keep DOCKER_CMD around instead of removing it completely, > which will help once we introduce MinGW builds; > > * the last two patches are new. > > > [v1] https://www.redhat.com/archives/libvir-list/2

[libvirt] [PATCH v2 4/6] travis: Rename DOCKER_CMD to LINUX_CMD

The new name is arguably more informative, especially now that we have MACOS_CMD and knowing that MINGW_CMD will be introduced later on. We still use DOCKER_CMD when calling Docker, and we assign the actual script on a per-image basis. Having this separation will help us when we introduce MinGW bu

[libvirt] [PATCH v2 6/6] travis: Skip first compilation for Linux builds

We already perform a full build as part of distcheck, so we can speed things up a bit by skipping the first compilation. Signed-off-by: Andrea Bolognani --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1e2e307ac5..a4a0bbb072 100644 --- a/.travis.

[libvirt] [PATCH v2 3/6] travis: Introduce MACOS_CMD

It mirrors the existing DOCKER_CMD, both in how it's defined as part of the environment and how it's called by passing it directly to the shell. In addition to making the configuration more consistent, this also allows us to move from having the macOS build script divided into four steps, some of

[libvirt] [PATCH v2 1/6] travis: Skip macOS upgrade

Upgrading takes quite a bit of time, doesn't offer any real value and causes a lot of grief. Let's just skip it. We need to install xz explicitly now, since it's required to make dist and no longer being dragged in by Python 3. Signed-off-by: Andrea Bolognani --- .travis.yml | 4 +--- 1 file ch

[libvirt] [PATCH v2 0/6] travis: Various cleanups and fixes

Changes from [v1]: * keep DOCKER_CMD around instead of removing it completely, which will help once we introduce MinGW builds; * the last two patches are new. [v1] https://www.redhat.com/archives/libvir-list/2018-June/msg00579.html Andrea Bolognani (6): travis: Skip macOS upgrade travis:

[libvirt] [PATCH v2 5/6] travis: Fix error path

Without a proper separator, all commands in the error path end up being interpreted as a single command, which is not what we want. Signed-off-by: Andrea Bolognani --- .travis.yml | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index a90

[libvirt] [PATCH v2 2/6] travis: Don't duplicate Docker invocation

All variable parts are taken from the environment, so we can exploit inheritance and avoid duplication. This will become more important as we start building on additional platforms. Signed-off-by: Andrea Bolognani --- .travis.yml | 31 +++ 1 file changed, 11 insertion

Re: [libvirt] [PATCH 3/4] qemuDomainAgentJob: Introduce query and modify jobs

On 06/14/2018 10:22 AM, Michal Privoznik wrote: > On 06/14/2018 12:11 AM, John Ferlan wrote: >> >> >> On 06/08/2018 09:45 AM, Michal Privoznik wrote: >>> These jobs can be used to mark job type over qemu agent. >>> >>> Signed-off-by: Michal Privoznik >>> --- >>> src/qemu/qemu_domain.c | 4 +++-

Re: [libvirt] [PATCH 2/4] qemu: Introduce APIs for manipulating qemuDomainAgentJob

On 06/14/2018 10:32 AM, Michal Privoznik wrote: > On 06/14/2018 12:10 AM, John Ferlan wrote: >> >> >> On 06/08/2018 09:45 AM, Michal Privoznik wrote: >>> The point is to break QEMU_JOB_* into smaller pieces which >>> enables us to achieve higher throughput. For instance, if there >>> are two thr

Re: [libvirt] [libvirt-go-xml PATCH 1/2] Add support for domain launch security

On Thu, Jun 14, 2018 at 04:54:43PM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 14, 2018 at 04:30:29PM +0200, Erik Skultety wrote: > > Signed-off-by: Erik Skultety > > --- > > domain.go | 135 > > +- > > 1 file changed, 134 insertions

[libvirt] [dbus PATCH v2 16/17] Implement Delete method for StorageVol Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.StorageVol.xml | 5 + src/storagevol.c| 25 + tests/test_storage.py | 6 ++ 3 files changed, 36 insertions(+) diff --git a/data/org.libvirt.StorageVol.xml b/da

[libvirt] [dbus PATCH v2 10/17] Implement StorageVolLookupByKey method for Connect Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 30 ++ tests/test_connect.py| 15 +++ 3 files changed, 51 insertions(+) diff --git a/data/org.libvirt.Connect.xml b

[libvirt] [dbus PATCH v2 15/17] Implement GetInfo method for StorageVol Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.StorageVol.xml | 6 ++ src/storagevol.c| 29 + 2 files changed, 35 insertions(+) diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml index aed3

[libvirt] [dbus PATCH v2 07/17] Implement Key property for StorageVol Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.StorageVol.xml | 5 + src/storagevol.c| 23 +++ tests/test_storage.py | 1 + 3 files changed, 29 insertions(+) diff --git a/data/org.libvirt.StorageVol.xml b/data/org.

[libvirt] [dbus PATCH v2 06/17] Implement Name property for StorageVol Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.StorageVol.xml | 5 + src/storagevol.c| 44 + tests/test_storage.py | 11 +++ 3 files changed, 60 insertions(+) diff --git a/data/org.libvir

[libvirt] [dbus PATCH v2 13/17] Implement Resize method for StorageVol Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.StorageVol.xml | 6 ++ src/storagevol.c| 26 ++ 2 files changed, 32 insertions(+) diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml index c1fecf3

[libvirt] [dbus PATCH v2 04/17] tests: rename test_* functions which are not tests

pytest collects functions starting with test prefix to run them as tests by default. Rename functions that are not supposed to be run as tests, to avoid unexpected failures. Note: this commit also renames domain function to follow the naming convention for same purpose functions. Signed-off-by:

[libvirt] [dbus PATCH v2 17/17] Implement StorageVolCreateXMLFrom method for StoragePool Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.StoragePool.xml | 9 + src/storagepool.c| 41 tests/test_storage.py| 22 + 3 files changed, 72 insertions(+) diff --git a

[libvirt] [dbus PATCH v2 03/17] test: move XML definition of entities to seperate file

Signed-off-by: Katerina Koukiou --- tests/test_connect.py | 47 +++ tests/xmldata.py | 37 + 2 files changed, 44 insertions(+), 40 deletions(-) create mode 100644 tests/xmldata.py diff --git a/tests/test_connec

[libvirt] [dbus PATCH v2 09/17] Implement GetXMLDesc method for StorageVol Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.StorageVol.xml | 6 ++ src/storagevol.c| 29 + tests/test_storage.py | 7 +++ 3 files changed, 42 insertions(+) diff --git a/data/org.libvirt.StorageVol.xm

[libvirt] [dbus PATCH v2 05/17] Implement StorageVolCreateXML method for StoragePool Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.StoragePool.xml | 7 +++ src/storagepool.c| 34 ++ tests/libvirttest.py | 31 +++ tests/test_storage.py| 3 +++ tests/xmldata.py

[libvirt] [dbus PATCH v2 14/17] Implement Wipe method for StorageVol Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.StorageVol.xml | 6 ++ src/storagevol.c| 26 ++ 2 files changed, 32 insertions(+) diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml index fdde430

[libvirt] [dbus PATCH v2 12/17] Implement StorageVolLookupByPath method for Connect Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 30 ++ tests/test_connect.py| 1 + 3 files changed, 37 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libv

[libvirt] [dbus PATCH v2 08/17] Implement Path property for StorageVol Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.StorageVol.xml | 5 + src/storagevol.c| 23 +++ tests/test_storage.py | 1 + 3 files changed, 29 insertions(+) diff --git a/data/org.libvirt.StorageVol.xml b/data/org.

[libvirt] [dbus PATCH v2 02/17] Implement ListStorageVolumes for StoragePool Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.StoragePool.xml | 6 ++ src/storagepool.c| 43 tests/test_storage.py| 8 3 files changed, 57 insertions(+) diff --git a/data/org.libvir

[libvirt] [dbus PATCH v2 11/17] Implement StorageVolLookupByName method for StoragePool Interface

Signed-off-by: Katerina Koukiou Reviewed-by: Ján Tomko --- data/org.libvirt.StoragePool.xml | 6 ++ src/storagepool.c| 34 ++ 2 files changed, 40 insertions(+) diff --git a/data/org.libvirt.StoragePool.xml b/data/org.libvirt.StoragePool.xml i

Re: [libvirt] [PATCH 2/2] conf: Fix formatting of element in domain capabilities XML

On Thu, Jun 14, 2018 at 02:28:03PM +0200, Erik Skultety wrote: We only formatted the element when QEMU supported the feature when in fact we should always format the element to make clear that libvirt knows about the feature and the fact whether it is or isn't supported depends on QEMU version,

[libvirt] [dbus PATCH v2 00/17] StorageVolume APIs

Changes from v1: - Fixes from reviews - And more: * tests: Moved all xml definitions for tests in separate file. * tests: Renamed all functions that are not supposed to be run as tests, so that they don't have test prefix. I found out that these were running as tests, when I add

[libvirt] [dbus PATCH v2 01/17] Introduce StorageVol Interface

Signed-off-by: Katerina Koukiou --- data/Makefile.am| 4 ++- data/org.libvirt.StorageVol.xml | 7 src/Makefile.am | 4 ++- src/connect.c | 6 src/connect.h | 1 + src/storagevol.c| 77 ++

Re: [libvirt] [PATCH 1/2] schema: Fix the definition of SEV in domain capabilities schema

On Thu, Jun 14, 2018 at 02:28:02PM +0200, Erik Skultety wrote: The whole element was optional which it shouldn't be as if the platform doesn't support SEV we should format . Signed-off-by: Erik Skultety --- docs/schemas/domaincaps.rng | 19 ++- 1 file changed, 10 insertions(+),

Re: [libvirt] [libvirt-go-xml PATCH 1/2] Add support for domain launch security

On Thu, Jun 14, 2018 at 04:30:29PM +0200, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > domain.go | 135 > +- > 1 file changed, 134 insertions(+), 1 deletion(-) > > diff --git a/domain.go b/domain.go > index aeeb24a..27e2

Re: [libvirt] [libvirt-go-xml PATCH 2/2] Add support for SEV in domain capabilities XML

On Thu, Jun 14, 2018 at 04:30:30PM +0200, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > domain_capabilities.go | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/domain_capabilities.go b/domain_capabilities.go > index 3f5a752..4844fd9 100644 > --- a/domain_capabilities

Re: [libvirt] [PATCH 1/2] schema: Fix the definition of SEV in domain capabilities schema

On Thu, Jun 14, 2018 at 02:28:02PM +0200, Erik Skultety wrote: The whole element was optional which it shouldn't be as if the platform doesn't support SEV we should format . Signed-off-by: Erik Skultety --- docs/schemas/domaincaps.rng | 19 ++- 1 file changed, 10 insertions(+),

Re: [libvirt] [libvirt-go PATCH 2/2] Add support for AMD SEV platform info

On Thu, Jun 14, 2018 at 04:30:01PM +0200, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > connect.go| 59 > +++ > connect_compat.go | 12 +++ > connect_compat.h | 7 +++ > 3 files changed, 78 insertions(+) > >

Re: [libvirt] [libvirt-go PATCH 1/2] Add support for AMD SEV launch security info

On Thu, Jun 14, 2018 at 04:30:00PM +0200, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > domain.go| 41 + > domain_compat.go | 13 + > domain_compat.h | 6 ++ > 3 files changed, 60 insertions(+) > > diff --git a/domai

Re: [libvirt] [PATCH v4 2/2] xen_common: convert to typesafe virConf acessors

On Thu, Jun 14, 2018 at 06:59:53AM +0200, Fabiano Fidêncio wrote: There are still a few places using virConfGetValue(), checking for the specific type of the pointers and so on. Those places are not going to be converted as: - Using virConfGetValue*() would trigger virReportError() in the curren

Re: [libvirt] [PATCH 4/5] Introcude VIR_CONNECT_GET_ALL_DOMAINS_STATS_BEST_EFFORT

On Thu, Jun 14, 2018 at 11:07:43AM +0200, Michal Privoznik wrote: > On 06/13/2018 05:34 PM, John Ferlan wrote: > > > > $SUBJ: "Introduce" and "NO_WAIT" > > > > > > On 06/07/2018 07:59 AM, Michal Privoznik wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1552092 > >> > >> If there's a long

Re: [libvirt] [libvirt-python PATCH v2 2/2] Add support for virNodeGetSEVInfo

On Thu, Jun 14, 2018 at 05:15:09PM +0200, Ján Tomko wrote: > On Wed, Jun 13, 2018 at 12:48:37PM +0200, Erik Skultety wrote: > > This binding allows to query the AMD's SEV firmware for various platform > > specific things, like a PDH certificate and a certificate chain to > > establish a trusted con

Re: [libvirt] [PATCH 4/5] Introcude VIR_CONNECT_GET_ALL_DOMAINS_STATS_BEST_EFFORT

On 06/14/2018 04:10 PM, John Ferlan wrote: > > [...] > diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index da773b76cb..1a1d34620d 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -2055,6 +2055

Re: [libvirt] [PATCH v4 1/2] xen_common: Split per-Vif logic from xenParseVif()

On Thu, Jun 14, 2018 at 06:59:52AM +0200, Fabiano Fidêncio wrote: xenParseVif() does a lot of stuff and, in order to make things cleaner, let's split it in two new functions: - xenParseVif(): it's a new function that keeps the old name. It's responsible for the whole per-Vif logic from the old xe

Re: [libvirt] [PATCH] cpu: add 'amd-ssbd' and 'amd-no-ssb' CPU features (CVE-2018-3639)

On Thu, Jun 14, 2018 at 11:48:41AM +0100, Daniel P. Berrangé wrote: > AMD x86 CPUs have two separate ways to mitigate the Speculative Store > Bypass hardware flaw. In current processors only non-architectural MSRs > are available, and so hypervisors must expose a virtualized MSR and CPU > flag "vir

Re: [libvirt] [libvirt-python PATCH v2 2/2] Add support for virNodeGetSEVInfo

On Wed, Jun 13, 2018 at 12:48:37PM +0200, Erik Skultety wrote: This binding allows to query the AMD's SEV firmware for various platform specific things, like a PDH certificate and a certificate chain to establish a trusted connection with the firmware. Because the API uses typed params, it's exem

Re: [libvirt] [libvirt-python PATCH v2 1/2] Add support for virDomainGetLaunchSecurityInfo

On Wed, Jun 13, 2018 at 12:48:36PM +0200, Erik Skultety wrote: Libvirt recently introduced support for getting launch security parameters, most notably AMD SEV VM memory measurement. This API can't be generated as it's using typed parameters which we need to allocate. Signed-off-by: Erik Skultet

Re: [libvirt] [PATCH 1/4] qemu: Introduce qemuDomainAgentJob

[...] >>> >>> +/* The following members are for QEMU_AGENT_JOB_* */ >>> +qemuDomainAgentJob agentActive; /* Currently running agent job */ >> >> Hmm... I seem to recall a recent patch that spoke against using an enum >> type for struct fields: >> >> https://www.redhat.com/archives/li

Re: [libvirt] [PATCHv2] docs: schema: Add missing element to input device

On Thu, Jun 14, 2018 at 06:26:51PM +0800, Lily Zhu wrote: For the 2 optional sub-elements - and of input device, make the order of them interchangeable in the XML. They should be interchangeable even with the other sub-elements. In other words, every sub-element of should be in a big . Ja

[libvirt] [PATCH 2/4] qemu: Introduce APIs for manipulating qemuDomainAgentJob

On 06/14/2018 12:10 AM, John Ferlan wrote: > > > On 06/08/2018 09:45 AM, Michal Privoznik wrote: >> The point is to break QEMU_JOB_* into smaller pieces which >> enables us to achieve higher throughput. For instance, if there >> are two threads, one is trying to query something on qemu >> monitor

[libvirt] [libvirt-go-xml PATCH 2/2] Add support for SEV in domain capabilities XML

Signed-off-by: Erik Skultety --- domain_capabilities.go | 7 +++ 1 file changed, 7 insertions(+) diff --git a/domain_capabilities.go b/domain_capabilities.go index 3f5a752..4844fd9 100644 --- a/domain_capabilities.go +++ b/domain_capabilities.go @@ -106,6 +106,7 @@ type DomainCapsFeatures st

[libvirt] [libvirt-go-xml PATCH 1/2] Add support for domain launch security

Signed-off-by: Erik Skultety --- domain.go | 135 +- 1 file changed, 134 insertions(+), 1 deletion(-) diff --git a/domain.go b/domain.go index aeeb24a..27e2fdc 100644 --- a/domain.go +++ b/domain.go @@ -1863,6 +1863,15 @@ type DomainFea

[libvirt] [libvirt-go-xml PATCH 0/2] Add support for the AMD SEV feature

*** BLURB HERE *** Erik Skultety (2): Add support for domain launch security Add support for SEV in domain capabilities XML domain.go | 135 - domain_capabilities.go | 7 +++ 2 files changed, 141 insertions(+), 1 deletion(-) --

[libvirt] [libvirt-go PATCH 0/2] Add bindings for recent libvirt SEV APIs

*** BLURB HERE *** Erik Skultety (2): Add support for AMD SEV launch security info Add support for AMD SEV platform info connect.go| 59 +++ connect_compat.go | 12 +++ connect_compat.h | 7 +++ domain.go | 41

[libvirt] [libvirt-go PATCH 1/2] Add support for AMD SEV launch security info

Signed-off-by: Erik Skultety --- domain.go| 41 + domain_compat.go | 13 + domain_compat.h | 6 ++ 3 files changed, 60 insertions(+) diff --git a/domain.go b/domain.go index a3049aa..6499cfa 100644 --- a/domain.go +++ b/domain.go

[libvirt] [libvirt-go PATCH 2/2] Add support for AMD SEV platform info

Signed-off-by: Erik Skultety --- connect.go| 59 +++ connect_compat.go | 12 +++ connect_compat.h | 7 +++ 3 files changed, 78 insertions(+) diff --git a/connect.go b/connect.go index e3e643e..8bb5fe6 100644 --- a/connect.

Re: [libvirt] [PATCH 3/4] qemuDomainAgentJob: Introduce query and modify jobs

On 06/14/2018 12:11 AM, John Ferlan wrote: > > > On 06/08/2018 09:45 AM, Michal Privoznik wrote: >> These jobs can be used to mark job type over qemu agent. >> >> Signed-off-by: Michal Privoznik >> --- >> src/qemu/qemu_domain.c | 4 +++- >> src/qemu/qemu_domain.h | 2 ++ >> 2 files changed, 5 i

Re: [libvirt] [PATCH 1/4] qemu: Introduce qemuDomainAgentJob

On 06/14/2018 12:04 AM, John Ferlan wrote: > > > On 06/08/2018 09:45 AM, Michal Privoznik wrote: >> This enum will list all possible jobs for guest agent. The idea >> is when a thread needs to talk to guest agent only it will take >> the QEMU_AGENT_JOB instead of QEMU_JOB helping better >> concur

Re: [libvirt] [PATCH 4/4] qemu: Switch code to use new agent job APIs

On 06/14/2018 12:14 AM, John Ferlan wrote: > > > On 06/08/2018 09:45 AM, Michal Privoznik wrote: >> There are two sets of functions here: >> 1) some functions talk on both monitor and agent monitor, >> 2) some functions only talk on agent monitor. >> >> For functions from set 1) we need to use >>

Re: [libvirt] [PATCH 4/5] Introcude VIR_CONNECT_GET_ALL_DOMAINS_STATS_BEST_EFFORT

[...] >>> diff --git a/include/libvirt/libvirt-domain.h >>> b/include/libvirt/libvirt-domain.h >>> index da773b76cb..1a1d34620d 100644 >>> --- a/include/libvirt/libvirt-domain.h >>> +++ b/include/libvirt/libvirt-domain.h >>> @@ -2055,6 +2055,7 @@ typedef enum { >>> VIR_CONNECT_GET_ALL_DOMA

Re: [libvirt] Call to virDomainIsActive hangs forever

On Thu, Jun 14, 2018 at 04:31:57PM +0300, Mathieu Tarral wrote: > Hi Daniel, > > Thanks for your help, i was able to run the libvirt daemon from master, > and after add some debug messages, i understood that the call > to virDomainIsActive was actually hanging from the client. > > It never reache

Re: [libvirt] [PATCH 3/5] qemu_domain: Introduce qemuDomainObjBeginJobInstant

[...] >>> qemuDomainObjPrivatePtr priv = obj->privateData; >>> unsigned long long now; >>> @@ -6395,12 +6400,18 @@ qemuDomainObjBeginJobInternal(virQEMUDriverPtr >>> driver, >>> } >>> >>> while (!nested && !qemuDomainNestedJobAllowed(priv, job)) { >>> +if (instant) >

Re: [libvirt] [dbus PATCH 15/15] Implement StorageVolCreateXMLFrom method for StoragePool Interface

On Tue, Jun 12, 2018 at 11:00:28AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.StoragePool.xml | 9 + src/storagepool.c| 41 tests/test_storage.py| 21 3 files

Re: [libvirt] [dbus PATCH 14/15] Implement Delete method for StorageVol Interface

On Tue, Jun 12, 2018 at 11:00:27AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.StorageVol.xml | 5 + src/storagevol.c| 25 + tests/test_storage.py | 6 ++ 3 files changed, 36 insertions(+) Reviewe

Re: [libvirt] [dbus PATCH 13/15] Implement GetInfo method for StorageVol Interface

On Tue, Jun 12, 2018 at 11:00:26AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.StorageVol.xml | 6 ++ src/storagevol.c| 29 + 2 files changed, 35 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc

Re: [libvirt] [PATCH v2 1/2] qemu: Check for existing hostdev address for cold attach device

On 06/13/2018 09:42 PM, Laine Stump wrote: > On 06/13/2018 07:16 AM, John Ferlan wrote: >> >> On 06/13/2018 04:15 AM, Ján Tomko wrote: >>> On Tue, Jun 12, 2018 at 10:32:06AM -0400, John Ferlan wrote: Add a check during qemuDomainAttachDeviceConfig whether the new/incoming device would

Re: [libvirt] [dbus PATCH 12/15] Implement Wipe method for StorageVol Interface

On Tue, Jun 12, 2018 at 11:00:25AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.StorageVol.xml | 6 ++ src/storagevol.c| 26 ++ 2 files changed, 32 insertions(+) +if (!storageVol) +return; + +if (v

Re: [libvirt] [dbus PATCH 12/15] Implement Wipe method for StorageVol Interface

On Tue, Jun 12, 2018 at 11:00:25AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.StorageVol.xml | 6 ++ src/storagevol.c| 26 ++ 2 files changed, 32 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Des

[libvirt] [PATCH] vmx: allow an odd number of vCPUs

Most probably this was a limitation in older ESX versions, and it seems it does not exist anymore in more recent versions; see the following thread: https://www.redhat.com/archives/libvir-list/2018-May/msg02159.html https://www.redhat.com/archives/libvir-list/2018-June/msg00043.html Hence, allow a

Re: [libvirt] [dbus PATCH 11/15] Implement Resize method for StorageVol Interface

On Tue, Jun 12, 2018 at 11:00:24AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.StorageVol.xml | 6 ++ src/storagevol.c| 26 ++ 2 files changed, 32 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Des

Re: [libvirt] Call to virDomainIsActive hangs forever

Hi Daniel, Thanks for your help, i was able to run the libvirt daemon from master, and after add some debug messages, i understood that the call to virDomainIsActive was actually hanging from the client. It never reached the daemon. Looking back at the call again: https://gist.github.com/Wenzel/

Re: [libvirt] [dbus PATCH 08/15] Implement StorageVolLookupByKey method for Connect Interface

On Tue, Jun 12, 2018 at 11:00:21AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 30 ++ tests/test_connect.py| 14 ++ 3 files changed, 50 insertions(+) diff

Re: [libvirt] [dbus PATCH 10/15] Implement StorageVolLookupByPath method for Connect Interface

On Tue, Jun 12, 2018 at 11:00:23AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 29 + tests/test_connect.py| 1 + 3 files changed, 36 insertions(+) diff --git a/src/c

Re: [libvirt] [dbus PATCH 06/15] Implement Path property for StorageVol Interface

On Tue, Jun 12, 2018 at 11:00:19AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.StorageVol.xml | 5 + src/storagevol.c| 23 +++ tests/test_storage.py | 1 + 3 files changed, 29 insertions(+) diff --git a/dat

Re: [libvirt] [dbus PATCH 09/15] Implement StorageVolLookupByName method for StoragePool Interface

On Tue, Jun 12, 2018 at 11:00:22AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.StoragePool.xml | 6 ++ src/storagepool.c| 34 ++ 2 files changed, 40 insertions(+) diff --git a/src/storagepool.c b/src/stor

Re: [libvirt] [dbus PATCH 08/15] Implement StorageVolLookupByKey method for Connect Interface

On Tue, Jun 12, 2018 at 11:00:21AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 30 ++ tests/test_connect.py| 14 ++ 3 files changed, 50 insertions(+) Re

Re: [libvirt] [dbus PATCH 07/15] Implement GetXMLDesc method for StorageVol Interface

On Tue, Jun 12, 2018 at 11:00:20AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.StorageVol.xml | 6 ++ src/storagevol.c| 29 + tests/test_storage.py | 7 +++ 3 files changed, 42 insertions(+) R

Re: [libvirt] [dbus PATCH 06/15] Implement Path property for StorageVol Interface

On Tue, Jun 12, 2018 at 11:00:19AM +0200, Katerina Koukiou wrote: Signed-off-by: Katerina Koukiou --- data/org.libvirt.StorageVol.xml | 5 + src/storagevol.c| 23 +++ tests/test_storage.py | 1 + 3 files changed, 29 insertions(+) Reviewed-by: J

Re: [libvirt] [dbus PATCH 03/15] Implement StorageVolCreateXML method for StoragePool Interface

On Tue, Jun 12, 2018 at 11:00:16AM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou > --- > data/org.libvirt.StoragePool.xml | 7 +++ > src/storagepool.c| 34 ++ > tests/libvirttest.py | 17 + > tests

[libvirt] [PATCH v3 17/20] nwfilter: remove virt driver callback layer for rebuilding filters

Now that the nwfilter driver keeps a list of bindings that it has created, there is no need for the complex virt driver callbacks. It is possible to simply iterate of the list of recorded filter bindings. This means that rebuilding filters no longer has to acquire any locks on the virDomainObj obj

[libvirt] [PATCH v3 16/20] nwfilter: keep track of active filter bindings

Currently the nwfilter driver does not keep any record of what filter bindings it has active. This means that when it needs to recreate filters, it has to rely on triggering callbacks provided by the virt drivers. This introduces a hash table recording the virNWFilterBinding objects so the driver h

  1   2   >