Please see my inline reply.
> -Original Message-
> From: Martin Kletzander [mailto:mklet...@redhat.com]
> Sent: Thursday, June 14, 2018 3:54 PM
> To: Wang, Huaqiang
> Cc: libvir-list@redhat.com; Feng, Shaohe ; Niu, Bing
> ; Ding, Jian-feng ; Zang, Rui
>
> Subject: Re: [libvirt] [RFC
Prepare for new checkpoint and backup APIs by describing the XML
that will represent a checkpoint and backup. The checkpoint XML
is modeled heavily after virDomainSnapshotPtr, since both represent
a point in time of the guest (however, a snapshot exists with the
intent to roll back to that point,
After running libvirt daemon with valgrind tools, some errors are
appearing when you try to start a domain. One example:
==18012== Syscall param mount(type) points to unaddressable byte(s)
==18012==at 0x6FEE3CA: mount (syscall-template.S:78)
==18012==by 0x531344D: virFileMoveMount
On 06/25/2018 06:16 PM, John Ferlan wrote:
On 06/13/2018 12:42 PM, Eric Blake wrote:
Introduce a bunch of new public APIs related to backup checkpoints.
Checkpoints are modeled heavily after virDomainSnapshotPtr (both
represent a point in time of the guest), although a snapshot exists
with
On Mon, Jun 25, 2018 at 05:13:26PM +0200, Erik Skultety wrote:
> On Fri, Jun 22, 2018 at 05:44:18PM -0300, Marcos Paulo de Souza wrote:
> > On Mon, Jun 25, 2018 at 01:35:33PM +0200, Erik Skultety wrote:
> > > On Sat, Jun 23, 2018 at 11:32:55AM -0300, Marcos Paulo de Souza wrote:
> > > > Both
On 06/13/2018 12:42 PM, Eric Blake wrote:
> Introduce a bunch of new public APIs related to backup checkpoints.
> Checkpoints are modeled heavily after virDomainSnapshotPtr (both
> represent a point in time of the guest), although a snapshot exists
> with the intent of rolling back to that
On 06/22/2018 04:16 PM, John Ferlan wrote:
On 06/13/2018 12:42 PM, Eric Blake wrote:
Upcoming patches plan to introduce virDomainCheckpointPtr as a new
object for use in incremental backups, along with documentation
how incremental backups differ from snapshots. But first, we need
to rename
On 06/13/2018 12:42 PM, Eric Blake wrote:
> Prepare for new checkpoint and backup APIs by describing the XML
> that will represent a checkpoint. This is modeled heavily after
> the XML for virDomainSnapshotPtr, since both represent a point in
> time of the guest. But while a snapshot exists
In python 3.7, async is now a keyword, so this throws a syntax error:
File "/usr/lib64/python3.7/site-packages/libvirtaio.py", line 49
from asyncio import async as ensure_future
^
SyntaxError: invalid syntax
Switch to getattr trickery to accomplish the same
On 06/22/2018 07:24 AM, Han Han wrote:
> For input,hub,redirdev devices, their sub-elements should be interleaved.
>
> input device: interleave for , ,
> hub device: interleave for ,
> redirdev device: interleave for , , ,
>
> Signed-off-by: Han Han
> ---
> docs/schemas/domaincommon.rng |
On 06/25/2018 04:15 PM, w00251574 wrote:
> Subject: [PATCH] qemu: Fix memory leak in qemuDomainBlockJobSetSpeed()
>
> fix 'device' leak in qemuDomainBlockJobSetSpeed
>
> Signed-off-by: Jie Wang
> ---
> src/qemu/qemu_driver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
On 06/25/2018 03:48 PM, w00251574 wrote:
> Subject: [PATCH] qemu: monitor: Fix memory leak in
> qemuMonitorJSONNBDServerStart()
>
> Exiting early through the return path did result in 'port_str'
> being leaked.
>
> Signed-off-by: Jie Wang
> ---
> src/qemu/qemu_monitor_json.c | 2 +-
> 1 file
On 06/21/2018 04:21 PM, Andrea Bolognani wrote:
> SASL authentication is configured server-side, so the sample
> configuration file should be shipped along with the daemon
> rather than with the libraries.
>
> Signed-off-by: Andrea Bolognani
> ---
> libvirt.spec.in | 3 +--
> 1 file changed, 1
This makes the feature fully functional.
https://bugzilla.redhat.com/show_bug.cgi?id=1571078
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_command.c | 12
tests/qemuxml2argvdata/pseries-features.args | 3 ++-
2 files changed, 14 insertions(+), 1
Signed-off-by: Andrea Bolognani
---
docs/formatdomain.html.in | 11 --
docs/schemas/domaincommon.rng | 21 +++
src/conf/domain_conf.c| 36 ---
src/conf/domain_conf.h| 1 +
Signed-off-by: Andrea Bolognani
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index f843648c75..a32d2b88a5 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -94,6 +94,17 @@
independent calls run at the same time.
We're going to introduce a second HPT-related setting soon,
at which point using a single location to store everything is
no longer going to cut it.
This mostly, but not completely, reverts 3dd1eb3b2650.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 21 ++---
This doesn't seem very useful at the moment, but it will make
sense once we introduce another HPT-related setting.
The output XML is decoupled from the input XML in preparation
of future changes as well; while doing so, we can shave a few
lines off the latter.
This commit is best viewed with
This applies cleanly on top of a0d6894af1b1.
Patch 1/7 is too big to go through the list; it can be fetched,
along with the rest of the series, from [1].
Patch 2/7 conflicts with patch 1/3 from [2], but making this one
depend on it didn't feel right; whichever of the two series gets
reviewed and
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_capabilities.c | 8 +
src/qemu/qemu_capabilities.h | 1 +
.../caps_2.12.0.aarch64.replies | 48 ++--
.../caps_2.12.0.aarch64.xml | 2 +-
.../caps_2.12.0.ppc64.replies
Signed-off-by: Andrea Bolognani
---
.../caps_3.0.0.ppc64.replies | 23673
.../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1074 +
tests/qemucapabilitiestest.c | 1 +
3 files changed, 24748 insertions(+)
create mode 100644
On Fri, Jun 22, 2018 at 05:44:18PM -0300, Marcos Paulo de Souza wrote:
> On Mon, Jun 25, 2018 at 01:35:33PM +0200, Erik Skultety wrote:
> > On Sat, Jun 23, 2018 at 11:32:55AM -0300, Marcos Paulo de Souza wrote:
> > > Both /hosts/cpu/arch and /hosts/cpu/features appear twice in the
> > >
On Mon, Jun 25, 2018 at 01:35:33PM +0200, Erik Skultety wrote:
> On Sat, Jun 23, 2018 at 11:32:55AM -0300, Marcos Paulo de Souza wrote:
> > Both /hosts/cpu/arch and /hosts/cpu/features appear twice in the
> > documentation.
> >
> > Signed-off-by: Marcos Paulo de Souza
> > ---
> >
> > This is my
On Fri, Jun 08, 2018 at 01:04:40AM +0530, Sukrit Bhatnagar wrote:
> By making use of the GCC's __attribute__((cleanup)) handled by VIR_AUTOFREE
> macro, majority of the VIR_FREE calls can be dropped, which in turn leads to
> getting rid of most of our cleanup sections.
You're missing the SoB line
Subject: [PATCH] qemu: Fix memory leak in qemuDomainBlockJobSetSpeed()
fix 'device' leak in qemuDomainBlockJobSetSpeed
Signed-off-by: Jie Wang
---
src/qemu/qemu_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index
On 06/13/2018 12:42 PM, Eric Blake wrote:
> Prepare for introducing a bunch of new public APIs related to
> backup checkpoints by first introducing a new internal type
> and errors associated with that type. Checkpoints are modeled
> heavily after virDomainSnapshotPtr (both represent a point
On 06/13/2018 12:42 PM, Eric Blake wrote:
> Upcoming patches will add support for incremental backups via
> a new API; but first, we need a landing page that gives an
> overview of capturing various pieces of guest state, and which
> APIs are best suited to which tasks.
>
> Signed-off-by: Eric
On Mon, Jun 25, 2018 at 09:30:49AM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter
> ---
> src/connect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/connect.c b/src/connect.c
> index 09e5628..32dda14 100644
> --- a/src/connect.c
> +++ b/src/connect.c
> @@
Subject: [PATCH] qemu: monitor: Fix memory leak in
qemuMonitorJSONNBDServerStart()
Exiting early through the return path did result in 'port_str'
being leaked.
Signed-off-by: Jie Wang
---
src/qemu/qemu_monitor_json.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Anya Harter
---
src/connect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/connect.c b/src/connect.c
index 09e5628..32dda14 100644
--- a/src/connect.c
+++ b/src/connect.c
@@ -68,7 +68,7 @@ virtDBusConnectClose(virtDBusConnect *connect,
for (gint i =
On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote:
> Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben:
> > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote:
> > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote:
> > > > Am 22.06.2018 um 15:36 hat
Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben:
> On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote:
> > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote:
> > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben:
> > > >
> > > >
> > > > On
On Sat, Jun 23, 2018 at 11:32:55AM -0300, Marcos Paulo de Souza wrote:
> Both /hosts/cpu/arch and /hosts/cpu/features appear twice in the
> documentation.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
>
> This is my first submission to libvirt, so let me know if I forgot something.
Which repo
On Fri, Jun 22, 2018 at 07:54:00PM +0200, Kevin Wolf wrote:
> Am 22.06.2018 um 17:40 hat Daniel P. Berrangé geschrieben:
> > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote:
> > > This was in fact one release longer than our deprecation policy says.
> > > Are we serious about the
On Mon, Jun 25, 2018 at 11:37:07 +0100, Daniel Berrange wrote:
> On Mon, Jun 25, 2018 at 12:29:48PM +0200, Peter Krempa wrote:
> > On Mon, Jun 25, 2018 at 10:50:32 +0100, Daniel Berrange wrote:
> > > Currently we format the serial, geometry and error policy on the -drive
> > > backend argument.
>
On Mon, Jun 25, 2018 at 12:29:48PM +0200, Peter Krempa wrote:
> On Mon, Jun 25, 2018 at 10:50:32 +0100, Daniel Berrange wrote:
> > Currently we format the serial, geometry and error policy on the -drive
> > backend argument.
> >
> > QEMU added the ability to set serial and geometry on the
On 25 June 2018 at 11:31, Peter Krempa wrote:
> On Mon, Jun 25, 2018 at 11:01:46 +0100, Peter Maydell wrote:
>> On 22 June 2018 at 16:40, Daniel P. Berrangé wrote:
>> > - SD card - requires -drive with if=sd, no -device support AFAICT
>>
>> Hmm? You can use -device if you want:
>> -drive
On Mon, Jun 25, 2018 at 11:01:46 +0100, Peter Maydell wrote:
> On 22 June 2018 at 16:40, Daniel P. Berrangé wrote:
> > - SD card - requires -drive with if=sd, no -device support AFAICT
>
> Hmm? You can use -device if you want:
> -drive if=none,id=mydrive,... -device sd-card,...,drive=mydrive
On Mon, Jun 25, 2018 at 10:50:32 +0100, Daniel Berrange wrote:
> Currently we format the serial, geometry and error policy on the -drive
> backend argument.
>
> QEMU added the ability to set serial and geometry on the frontend in
> the 1.2 release, and ability to set error policy in the 2.7
On Mon, Jun 25, 2018 at 11:10:29AM +0200, Kashyap Chamarthy wrote:
> On Mon, Jun 25, 2018 at 10:57:31AM +0200, Erik Skultety wrote:
> > On Fri, Jun 22, 2018 at 12:09:39PM +0200, Kashyap Chamarthy wrote:
> > > Since libvirt 1.3.4, any RNG source is accepted for the 'random'
> > > backend. However,
On 22 June 2018 at 16:40, Daniel P. Berrangé wrote:
> - SD card - requires -drive with if=sd, no -device support AFAICT
Hmm? You can use -device if you want:
-drive if=none,id=mydrive,... -device sd-card,...,drive=mydrive
(the sd-card device then plugs into the sd controller device
via the
On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote:
> On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote:
> > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben:
> > >
> > >
> > > On 06/22/2018 02:55 PM, Kevin Wolf wrote:
> > > > Am 22.06.2018 um 13:38 hat
Currently we format the serial, geometry and error policy on the -drive
backend argument.
QEMU added the ability to set serial and geometry on the frontend in
the 1.2 release, and ability to set error policy in the 2.7 release.
usb-storage is an oddity, however, as it lacks error policy support
On Mon, Jun 25, 2018 at 10:57:31AM +0200, Erik Skultety wrote:
> On Fri, Jun 22, 2018 at 12:09:39PM +0200, Kashyap Chamarthy wrote:
> > Since libvirt 1.3.4, any RNG source is accepted for the 'random'
> > backend. However, '/dev/urandom' is the _recommended_ source of
> > entropy.
> >
>
> s/\n//
On Mon, Jun 25, 2018 at 10:23:03AM +0200, Thomas Huth wrote:
> On 25.06.2018 09:16, Peter Krempa wrote:
> > On Fri, Jun 22, 2018 at 14:55:02 +0200, Kevin Wolf wrote:
> >> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben:
> >>>
> >>> On 06/15/2018 04:21 PM, Kevin Wolf wrote:
> The
On Fri, Jun 22, 2018 at 12:09:39PM +0200, Kashyap Chamarthy wrote:
> Since libvirt 1.3.4, any RNG source is accepted for the 'random'
> backend. However, '/dev/urandom' is the _recommended_ source of
> entropy.
>
s/\n//
> Mention it so in the docs.
"Therefore we should mention that in the
On Fri, Jun 22, 2018 at 04:43:35AM +0530, Sukrit Bhatnagar wrote:
> On Mon, 18 Jun 2018 at 17:20, Andrea Bolognani wrote:
> >
> > On Mon, 2018-06-18 at 11:52 +0100, Daniel P. Berrangé wrote:
> > > On Mon, Jun 18, 2018 at 12:24:39PM +0200, Pavel Hrdina wrote:
> > > > # define
On 25.06.2018 09:16, Peter Krempa wrote:
> On Fri, Jun 22, 2018 at 14:55:02 +0200, Kevin Wolf wrote:
>> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben:
>>>
>>> On 06/15/2018 04:21 PM, Kevin Wolf wrote:
The -drive option serial was deprecated in QEMU 2.10. It's time to
On Mon, Jun 18, 2018 at 11:52:04AM +0100, Daniel P. Berrangé wrote:
> On Mon, Jun 18, 2018 at 12:24:39PM +0200, Pavel Hrdina wrote:
> > Hi,
> >
> > It took me longer to sit down and write this mail but here it goes.
> >
> > There was a lot of ideas about the macro design and it's easy to
> > get
On 22.06.2018 16:25, Kevin Wolf wrote:
> Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben:
>>
>>
>> On 06/22/2018 02:55 PM, Kevin Wolf wrote:
>>> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben:
On 06/15/2018 04:21 PM, Kevin Wolf wrote:
> The -drive option
On Fri, Jun 22, 2018 at 14:55:02 +0200, Kevin Wolf wrote:
> Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben:
> >
> > On 06/15/2018 04:21 PM, Kevin Wolf wrote:
> > > The -drive option serial was deprecated in QEMU 2.10. It's time to
> > > remove it.
> > >
> > > Tests need to be
If a thread is unable to acquire a job (e.g. because of timeout)
an error is reported and the error message contains reference to
the other thread holding the job. Well, the error message should
report agent job too as it is yet another source of possible
failure.
Signed-off-by: Michal Privoznik
52 matches
Mail list logo
