On Wed, 2018-07-04 at 07:35 +0200, Pavel Hrdina wrote:
> Create section for authors that started the project and add Katerina
> into the list of primary maintainers.
>
> Suggested-by: Andrea Bolognani
> Signed-off-by: Pavel Hrdina
One day I will learn to check the list before posting patches
Hi， I Have do it in the last git email sending with correct author name.
在 2018-07-04 12:48:21，"杜 博" 写道：
>Bobo Du
>在 2018-07-04 12:44:22，"Michal Prívozník" 写道：
>>On 07/04/2018 04:36 AM, Chen Hanxiao wrote:
>>>
>>> At 2018-07-03 15:36:19, "Michal Prívozník" wrote:
On 07/02/2018 01:08 PM,
Bobo Du
在 2018-07-04 12:44:22，"Michal Prívozník" 写道：
>On 07/04/2018 04:36 AM, Chen Hanxiao wrote:
>>
>> At 2018-07-03 15:36:19, "Michal Prívozník" wrote:
>>> On 07/02/2018 01:08 PM, dubo163 wrote:
From: dubobo
the libvirtd pid file is not match the os process pid number
On 07/04/2018 04:36 AM, Chen Hanxiao wrote:
>
> At 2018-07-03 15:36:19, "Michal Prívozník" wrote:
>> On 07/02/2018 01:08 PM, dubo163 wrote:
>>> From: dubobo
>>>
>>> the libvirtd pid file is not match the os process pid number
>>> which is smaller than before.
>>>
>>> this would be exist if the
List Katerina, who is currently the top libvirt-dbus
contributor by number of commits, among the maintainers.
Signed-off-by: Andrea Bolognani
---
AUTHORS.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/AUTHORS.in b/AUTHORS.in
index 988dd6a..bb09e0e 100644
--- a/AUTHORS.in
+++
Create section for authors that started the project and add Katerina
into the list of primary maintainers.
Suggested-by: Andrea Bolognani
Signed-off-by: Pavel Hrdina
---
AUTHORS.in | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/AUTHORS.in b/AUTHORS.in
index
On Tue, Jul 03, 2018 at 04:19:47PM -0400, Anya Harter wrote:
> which are unused outside domain_addr.c
>
> The commit where the last external use was removed is linked in each
> commit when it exists
>
> Anya Harter (4):
> domain_addr: make virDomainPCIAddressBusIsEmpty static
> domain_addr:
On Tue, Jul 03, 2018 at 03:57:29PM -0400, Anya Harter wrote:
>
>
> On 07/03/2018 09:03 AM, Ján Tomko wrote:
> > On Tue, Jul 03, 2018 at 02:18:02PM +0200, Pavel Hrdina wrote:
> >> On Mon, Jul 02, 2018 at 11:42:08AM -0400, Anya Harter wrote:
> >>> so that g_free(connect->nodeDevPath) line appears
Thanks, I'll take a look.
On Tue, Jul 3, 2018 at 9:24 PM Peter Krempa wrote:
> On Tue, Jul 03, 2018 at 20:41:54 +0800, dujiancheng wrote:
> > From: Dujiancheng
> >
> > dujiancheng (1):
> > qemu: Added support L2 table cache for qcow2 disk.
> > L2 table cache can be set by the new
the libvirtd pid file is not match the os process pid number
which is smaller than before.
this would be exist if the libvirtd process coredump or the os
process was killed which the next pid number is smaller.
you can be also edit the pid file to write the longer number than
before,then restart
Bobo Du (1):
util:Fix with process number and pid file do not match
src/util/virpidfile.c | 8
1 file changed, 8 insertions(+)
--
1.8.3.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Adding usb bus address support to the optional address parameter of virsh
attach-disk. The address is used as bus:port. e.g.
usb:1:1
Signed-off-by: Han Han
---
tools/virsh-domain.c | 38 +-
tools/virsh.pod | 2 +-
2 files changed, 38 insertions(+), 2
Adding sata bus address support to the optional address parameter of virsh
attach-disk. The address is used as controller.bus.unit. e.g.
sata:0.0.0
Signed-off-by: Han Han
---
tools/virsh-domain.c | 46 +++-
tools/virsh.pod | 2 +-
2 files changed,
Add usb and sata support for attach-disk of address parameter in virsh.
Han Han (2):
virsh: usb support for virsh attach-disk --address
virsh: sata support for virsh attach-disk --address
tools/virsh-domain.c | 82 +++-
tools/virsh.pod | 2 +-
2
At 2018-07-03 15:36:19, "Michal Prívozník" wrote:
>On 07/02/2018 01:08 PM, dubo163 wrote:
>> From: dubobo
>>
>> the libvirtd pid file is not match the os process pid number
>> which is smaller than before.
>>
>> this would be exist if the libvirtd process coredump or the os
>> process was
By using this macro we can avoid boilerplate code to check for arrays of
objects from ESX driver. This replacement was done using the coccinelle
script bellow:
@@
identifier ptr;
@@
-if (!ptr || *ptr) { ... }
+ESX_VI_CHECK_ARG_LIST(ptr);
Signed-off-by: Marcos Paulo de Souza
---
Changes from
This macro avoids code duplication when checking for arrays of objects.
Signed-off-by: Marcos Paulo de Souza
---
Changes from v1:
* Change VIR_ERR_INVALID_ARG to VIR_ERR_INTERNAL_ERROR (Michal)
* Change esxVI_checkArgList to ESX_VI_CHECK_ARG_LIST (Matthias)
src/esx/esx_util.h | 8
Hi guys,
in this second version I address the comments of Michal and Matthias. Changes
from v1 are placed in each patch.
Please let me know if you have more suggestions for the approach taken.
Thanks,
Marcos Paulo de Souza (2):
esx_util.h: Add ESX_VI_CHECK_ARG_LIST macro
esx: Use
dubobo (1):
util:Fix with process number and pid file do not match
src/util/virpidfile.c | 8
1 file changed, 8 insertions(+)
--
1.8.3.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
the libvirtd pid file is not match the os process pid number
which is smaller than before.
this would be exist if the libvirtd process coredump or the os
process was killed which the next pid number is smaller.
you can be also edit the pid file to write the longer number than
before,then restart
On 07/03/2018 07:08 PM, Matthias Bolte wrote:
> 2018-07-03 17:03 GMT+02:00 Michal Privoznik :
>> *** BLURB HERE ***
>>
>> Michal Privoznik (2):
>> esx: Report error in esxVI_LookupVirtualMachineByName
>> esx: De-duplicate @virtualMachine check in esxDomainLookupByName
>>
>>
never used outside domain_addr.c
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 2 +-
src/conf/domain_addr.h | 3 ---
src/libvirt_private.syms | 1 -
3 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
index
which are unused outside domain_addr.c
The commit where the last external use was removed is linked in each
commit when it exists
Anya Harter (4):
domain_addr: make virDomainPCIAddressBusIsEmpty static
domain_addr: make virDomainCCWAddress funcs static
domain_addr: make
SetCreate, SetAddControllers, Reserve
last uses of these functions outside domain_addr.c removed in commit:
40c284f0a6b53a182af7b12173bcb5dd3eb0c826
Assign
never used outside domain_addr.c
move Assign and Reserve above their first call within domain_addr.c
Signed-off-by: Anya
never used outside domain_addr.c
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 2 +-
src/conf/domain_addr.h | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
index eb0784cd2c..ec2dfdbbdc 100644
---
Allocate, Validate, SetCreate
last uses of these functions outside domain_addr.c removed in commit:
7bdd06b4e103269992122603949f585fc2bfdc6
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 6 +++---
src/conf/domain_addr.h | 12
src/libvirt_private.syms | 3
On 07/03/2018 09:03 AM, Ján Tomko wrote:
> On Tue, Jul 03, 2018 at 02:18:02PM +0200, Pavel Hrdina wrote:
>> On Mon, Jul 02, 2018 at 11:42:08AM -0400, Anya Harter wrote:
>>> so that g_free(connect->nodeDevPath) line appears in alphabetical order
>>> with the rest of the lines
>>>
>>>
On 07/03/2018 11:25 AM, Anya Harter wrote:
> from src/qemu/qemu_domain_address.c to src/conf/domain_addr.c
> and rename to virDomainCCWAddressSetCreateFromDomain
>
> (rename to have Address in full instead of Addr to follow
> the naming convention of other virDomainCCWAddress functions)
>
>
>
> Is there any update so far? I’m asking because I’m still getting
> segmentation faults and hang-ups on termination of libvirtd (using the
> newest version of libvirt).
>
> Example for a hang-up:
> ➤ bt
> #0 0x03fffca8df84 in pthread_cond_wait@@GLIBC_2.3.2 () from
>
On 07/03/2018 06:32 AM, Marc Hartmayer wrote:
> On Thu, Jun 21, 2018 at 03:47 PM +0200, Marc Hartmayer
> wrote:
>> On Wed, Jun 13, 2018 at 03:11 PM +0200, John Ferlan
>> wrote:
>>> On 06/07/2018 08:17 AM, Marc Hartmayer wrote:
On Wed, May 09, 2018 at 09:51 PM +0200, John Ferlan
2018-07-03 17:03 GMT+02:00 Michal Privoznik :
> *** BLURB HERE ***
>
> Michal Privoznik (2):
> esx: Report error in esxVI_LookupVirtualMachineByName
> esx: De-duplicate @virtualMachine check in esxDomainLookupByName
>
> src/esx/esx_driver.c | 7 +--
> src/esx/esx_vi.c | 5 -
> 2
On Fri, Jan 19, 2018 at 06:23 PM +0100, John Ferlan wrote:
> When virNetDaemonQuit is called from libvirtd's shutdown
> handler (daemonShutdownHandler) we need to perform the quit
> in multiple steps. The first part is to "request" the quit
> and notify the NetServer's of the impending quit which
On Wed, Feb 14, 2018 at 11:36 PM +0100, John Ferlan wrote:
> On 01/26/2018 03:47 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 19.01.2018 20:23, John Ferlan wrote:
>>> RFC:
>>> https://www.redhat.com/archives/libvir-list/2018-January/msg00318.html
>>>
>>> Adjustments since RFC...
>>>
>>> Patches
Signed-off-by: Daniel P. Berrangé
---
Pushed as a build fix
mingw-libvirt.spec.in | 4
1 file changed, 4 insertions(+)
diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
index 917d2143d8..cc1e619927 100644
--- a/mingw-libvirt.spec.in
+++ b/mingw-libvirt.spec.in
@@ -248,6 +248,8
from src/qemu/qemu_domain_address.c to src/conf/domain_addr.c
and rename to virDomainCCWAddressSetCreateFromDomain
(rename to have Address in full instead of Addr to follow
the naming convention of other virDomainCCWAddress functions)
Signed-off-by: Anya Harter
---
renamed function in v2 patch
On 07/03/2018 01:51 PM, dubo163 wrote:
> the libvirtd pid file is not match the os process pid number
> which is smaller than before.
>
> this would be exist if the libvirtd process coredump or the os
> process was killed which the next pid number is smaller.
>
> you can be also edit the pid
On 07/02/2018 04:48 PM, John Ferlan wrote:
>
>
> On 06/28/2018 04:23 PM, Anya Harter wrote:
>> from src/qemu/qemu_domain_address.[ch] to src/conf/domain_addr.[ch]
>>
>> Signed-off-by: Anya Harter
>> ---
>> src/conf/domain_addr.c | 24
>>
On Tue, Jul 03, 2018 at 04:22 PM +0200, Peter Krempa wrote:
> On Tue, Jul 03, 2018 at 09:34:56 -0400, John Ferlan wrote:
>>
>>
>> On 07/03/2018 08:05 AM, Peter Krempa wrote:
>> > The private data of a virStorageSource which is backing an iSCSI hostdev
>> > may be NULL if no authentication is
*** BLURB HERE ***
Michal Privoznik (2):
esx: Report error in esxVI_LookupVirtualMachineByName
esx: De-duplicate @virtualMachine check in esxDomainLookupByName
src/esx/esx_driver.c | 7 +--
src/esx/esx_vi.c | 5 -
2 files changed, 5 insertions(+), 7 deletions(-)
--
2.16.4
--
When reviewing 00d9edfe2f39f60b40 I've changed proposed patch and
made it to not report error if no domain is found. This is wrong
and the original patch was okay. Thing is, both callers pass
occurrence = OptionalItem so no error message overwriting is done
as I thought initially.
Signed-off-by:
The function call esxVI_LookupVirtualMachineByName(occurrence =
OptionalItem) and then checks if @virtualMachine is NULL. If it
is an error is reported. The same result can be achieved by
setting occurrence to RequiredItem.
Signed-off-by: Michal Privoznik
---
src/esx/esx_driver.c | 7 +--
1
On 07/03/2018 03:43 PM, Matthias Bolte wrote:
> 2018-07-03 11:31 GMT+02:00 Michal Prívozník :
>> On 07/03/2018 04:20 AM, Marcos Paulo de Souza wrote:
>>> The same pattern is used in lots of other places.
>>>
>>> Signed-off-by: Marcos Paulo de Souza
>>> ---
>>> src/esx/esx_vi.c | 14
On Tue, Jul 03, 2018 at 09:34:56 -0400, John Ferlan wrote:
>
>
> On 07/03/2018 08:05 AM, Peter Krempa wrote:
> > The private data of a virStorageSource which is backing an iSCSI hostdev
> > may be NULL if no authentication is present. The code handling the
> > hotplug would attempt to extract
2018-07-03 4:20 GMT+02:00 Marcos Paulo de Souza :
> This macro avoids code duplication when checking for arrays of objects.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
> src/esx/esx_vi.c | 189 ---
> 1 file changed, 46 insertions(+), 143
2018-07-03 11:31 GMT+02:00 Michal Prívozník :
> On 07/03/2018 04:20 AM, Marcos Paulo de Souza wrote:
>> The same pattern is used in lots of other places.
>>
>> Signed-off-by: Marcos Paulo de Souza
>> ---
>> src/esx/esx_vi.c | 14 --
>> 1 file changed, 4 insertions(+), 10 deletions(-)
On 07/03/2018 08:05 AM, Peter Krempa wrote:
> The private data of a virStorageSource which is backing an iSCSI hostdev
> may be NULL if no authentication is present. The code handling the
> hotplug would attempt to extract the authentication info stored in
> 'secinfo' without checking if it is
On Tue, Jul 03, 2018 at 20:41:54 +0800, dujiancheng wrote:
> From: Dujiancheng
>
> dujiancheng (1):
> qemu: Added support L2 table cache for qcow2 disk.
> L2 table cache can be set by the new element diskCache.
> Use the following methods to set the L2
On 07/03/2018 02:38 PM, John Ferlan wrote:
>
>
> On 07/03/2018 01:08 AM, Michal Prívozník wrote:
>> On 07/03/2018 01:38 AM, John Ferlan wrote:
>>>
>>>
>>> On 06/29/2018 11:01 AM, Michal Privoznik wrote:
When scanning for targets, iSCSI might give different results
depending on the
On 07/03/2018 02:42 PM, John Ferlan wrote:
>
>
> On 07/03/2018 01:08 AM, Michal Prívozník wrote:
>> On 07/03/2018 01:40 AM, John Ferlan wrote:
>>>
>>>
>>> On 06/29/2018 11:01 AM, Michal Privoznik wrote:
After new iSCSI interface is successfully set up, we issue
>>>
>>> s/new/a new/
>>>
On 07/03/2018 02:51 PM, John Ferlan wrote:
>
>
> On 07/03/2018 01:08 AM, Michal Prívozník wrote:
>> On 07/03/2018 01:18 AM, John Ferlan wrote:
>>>
>>>
>>> On 06/29/2018 11:01 AM, Michal Privoznik wrote:
Firstly, we can utilize virCommandSetOutputBuffer() API which
will collect the
On Tue, Jul 03, 2018 at 02:18:02PM +0200, Pavel Hrdina wrote:
On Mon, Jul 02, 2018 at 11:42:08AM -0400, Anya Harter wrote:
so that g_free(connect->nodeDevPath) line appears in alphabetical order
with the rest of the lines
Signed-off-by: Anya Harter
---
src/connect.c | 2 +-
1 file changed, 1
$SUBJ/
util: Remove unused bypassSecurityDriver from qemuOpenFileAs
On 07/03/2018 01:57 AM, Michal Privoznik wrote:
> This argument is not used anymore. The only function that is
> passing non-NULL (qemuDomainSaveMemory) does not actually care
> for the value (after 23087cfdb) and every other
On 07/03/2018 01:08 AM, Michal Prívozník wrote:
> On 07/03/2018 01:18 AM, John Ferlan wrote:
>>
>>
>> On 06/29/2018 11:01 AM, Michal Privoznik wrote:
>>> Firstly, we can utilize virCommandSetOutputBuffer() API which
>>> will collect the command output for us. Secondly, sscanf()-ing
>>> through
From: Dujiancheng
dujiancheng (1):
qemu: Added support L2 table cache for qcow2 disk.
L2 table cache can be set by the new element diskCache.
Use the following methods to set the L2 table cache
and cache clean interval:
On 07/03/2018 01:08 AM, Michal Prívozník wrote:
> On 07/03/2018 01:40 AM, John Ferlan wrote:
>>
>>
>> On 06/29/2018 11:01 AM, Michal Privoznik wrote:
>>> After new iSCSI interface is successfully set up, we issue
>>
>> s/new/a new/
>> s/issue/issue a/
>>
>>> sendtargets command. However, after
On 07/03/2018 01:35 PM, Peter Maydell wrote:
> On 3 July 2018 at 12:32, Kevin Wolf wrote:
>> Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben:
>>> Just posted latest version here:
>>>
>>> https://www.redhat.com/archives/libvir-list/2018-July/msg00130.html
>>>
>>> It will be in the
On 07/03/2018 01:08 AM, Michal Prívozník wrote:
> On 07/03/2018 01:38 AM, John Ferlan wrote:
>>
>>
>> On 06/29/2018 11:01 AM, Michal Privoznik wrote:
>>> When scanning for targets, iSCSI might give different results
>>> depending on the interface used. This is basically just name of
>>
>>
On Tue, Jul 03, 2018 at 12:18:54 +0100, Daniel Berrange wrote:
> Currently we format the serial, geometry and error policy on the -drive
> backend argument.
>
> QEMU added the ability to set serial and geometry on the frontend in
> the 1.2 release deprecating use of -drive, with support being
Add a new helper that will be solely used to create arguments for the
transaction command. Later on this will make it possible to remove the
overloading which was caused by the fact that snapshots were created
without transaction and also will help in blockdevizing of snapshots.
Signed-off-by:
Since we now always do the snapshot via the 'transaction' command we can
drop the code which would enter monitor for individual disk snapshots.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 25 +++--
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git
While qemu supports the 'transaction' command since v1.1.0
(52e7c241ac766406f05fa) and the 'blockdev-snapshot-sync' command since
v0.14.0-rc0 we need to keep the capability bits present since some qemu
downstreams (RHEL/CentOS 7 for example) chose to cripple qemu by
arbitrarily compile out some
Remove the dual mode code which allowed to create snapshots without
support for 'transaction'.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 17 -
src/qemu/qemu_monitor.h | 6 --
src/qemu/qemu_monitor_json.c | 37 -
Require that the 'transaction' command is present for external snapshots
to work and remove the various hacks which were present to make it work
without that.
Peter Krempa (8):
qemu: snapshot: Require support of 'transaction' command for external
snapshots
qemu: snapshot: Remove monitor
With 'transaction' support we don't need to keep around the multipurpose
code which would create the snapshot if 'transaction' is not supported.
To simplify this add a new helper that just wraps the arguments for
'blockdev-snapshot-sync' operation in 'transaction' and use it instead
of
Now that we use only the separate function for creating data for the
'transaction' command we can remove all the boilerplate which was
necessary before.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 42 ++
1 file changed, 10
In the cleanup path we already checked whether a snapshot needed to be
taken by looking into the collected data. Use the same approach when
creating the snapshot command data and when commiting the changes to the
domain definition.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 10
Currently we'd audit that we managed to format the data for the
'transaction' command rather than the (un)successful attempt to create
the snapshot.
Move the auditing code so that it can actually audit the result of the
'transaction' command.
Signed-off-by: Peter Krempa
---
On Mon, Jul 02, 2018 at 11:42:08AM -0400, Anya Harter wrote:
> so that g_free(connect->nodeDevPath) line appears in alphabetical order
> with the rest of the lines
>
> Signed-off-by: Anya Harter
> ---
> src/connect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
In general we don't
The private data of a virStorageSource which is backing an iSCSI hostdev
may be NULL if no authentication is present. The code handling the
hotplug would attempt to extract the authentication info stored in
'secinfo' without checking if it is allocated which resulted in a crash.
Here we opt the
the libvirtd pid file is not match the os process pid number
which is smaller than before.
this would be exist if the libvirtd process coredump or the os
process was killed which the next pid number is smaller.
you can be also edit the pid file to write the longer number than
before,then restart
dubo163 (1):
util:Fix with process number and pid file do not match
src/util/virpidfile.c | 8
1 file changed, 8 insertions(+)
--
1.8.3.1
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Semantically, there is no difference between an uninitialized worker
pool and an initialized worker pool with zero workers. Let's allow the
worker pool to be initialized for max_workers=0 as well then which
makes the API more symmetric and simplifies code. Validity of the
worker pool is delegated
The include guard should match the file name and comment.
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
src/rpc/virnetserverprogram.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/rpc/virnetserverprogram.h b/src/rpc/virnetserverprogram.h
index
Hypervisor drivers (e.g. QEMU) assume that they run in a separate
thread from the main event loop thread otherwise deadlocks can
occur. Therefore let's report an error if max_workers < 1 is set in
the libvirtd configuration file.
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
---
tools/virt-admin.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/virt-admin.c b/tools/virt-admin.c
index c86b5763a73c..107a1d870df5 100644
--- a/tools/virt-admin.c
+++ b/tools/virt-admin.c
@@ -552,7
@srv must be unlocked for the call virNetServerProcessMsg otherwise a
deadlock can occur.
Since the pointer 'srv->workers' will never be changed after
initialization and the thread pool has it's own locking we can release
the lock of 'srv' earlier. This also fixes the deadlock.
Signed-off-by:
One way to reproduce the bugs is to set admin_max_workers=0 in
libvirtd.conf, restart libvirtd, and then call:
$ virt-admin server-threadpool-info admin
Changelog:
v1->v2:
- Worked in Daniel Berrangé's comments that:
1. max_workers=0 should not be allowed for the libvirtd (patch 3)
...since maxWorkers=0 is only intended for virtlockd or virlogd which
must not be multithreaded.
Signed-off-by: Marc Hartmayer
Reviewed-by: Boris Fiuczynski
Reviewed-by: Bjoern Walk
---
src/util/virthreadpool.c | 8
1 file changed, 8 insertions(+)
diff --git
On Tue, Jul 03, 2018 at 01:32:29PM +0200, Kevin Wolf wrote:
> Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben:
> > On Tue, Jul 03, 2018 at 12:53:44PM +0200, Christian Borntraeger wrote:
> > >
> > >
> > > On 07/02/2018 10:04 AM, Kevin Wolf wrote:
> > > > Am 25.06.2018 um 13:45 hat Peter
On 3 July 2018 at 12:32, Kevin Wolf wrote:
> Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben:
>> Just posted latest version here:
>>
>> https://www.redhat.com/archives/libvir-list/2018-July/msg00130.html
>>
>> It will be in the next release on ~ Aug 1st
>
> It would have been a lot
Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben:
> On Tue, Jul 03, 2018 at 12:53:44PM +0200, Christian Borntraeger wrote:
> >
> >
> > On 07/02/2018 10:04 AM, Kevin Wolf wrote:
> > > Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben:
> > >> On Mon, Jun 25, 2018 at 13:41:06 +0200,
On Tue, Jul 03, 2018 at 12:53:44PM +0200, Christian Borntraeger wrote:
>
>
> On 07/02/2018 10:04 AM, Kevin Wolf wrote:
> > Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben:
> >> On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote:
> >>> Am 25.06.2018 um 11:53 hat Daniel P. Berrangé
Currently we format the serial, geometry and error policy on the -drive
backend argument.
QEMU added the ability to set serial and geometry on the frontend in
the 1.2 release deprecating use of -drive, with support being deleted
from -drive in 3.0.
We keep formatting error policy on -drive for
On 07/02/2018 10:04 AM, Kevin Wolf wrote:
> Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben:
>> On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote:
>>> Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben:
On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote:
On Thu, Jun 21, 2018 at 03:47 PM +0200, Marc Hartmayer
wrote:
> On Wed, Jun 13, 2018 at 03:11 PM +0200, John Ferlan
> wrote:
>> On 06/07/2018 08:17 AM, Marc Hartmayer wrote:
>>> On Wed, May 09, 2018 at 09:51 PM +0200, John Ferlan
>>> wrote:
On 05/07/2018 11:24 AM, Marc Hartmayer wrote:
On Tue, Jul 03, 2018 at 11:31:36AM +0200, Michal Prívozník wrote:
> On 07/03/2018 04:20 AM, Marcos Paulo de Souza wrote:
> > This macro avoids code duplication when checking for arrays of objects.
> >
> > Signed-off-by: Marcos Paulo de Souza
> > ---
> > src/esx/esx_vi.c | 189
On 07/03/2018 04:21 AM, Marcos Paulo de Souza wrote:
> Instead of duplicating code to do the same checking. Now all functions
> of virHypervisorDriver from esx driver are using this macro.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
> src/esx/esx_driver.c | 10 ++
> 1 file changed, 2
On 07/03/2018 04:20 AM, Marcos Paulo de Souza wrote:
> This macro avoids code duplication when checking for arrays of objects.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
> src/esx/esx_vi.c | 189 ---
> 1 file changed, 46 insertions(+), 143
On 07/03/2018 04:20 AM, Marcos Paulo de Souza wrote:
> The same pattern is used in lots of other places.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
> src/esx/esx_vi.c | 14 --
> 1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/src/esx/esx_vi.c
From: Jiri Denemark
Once we called qemuDomainObjEnterRemote to talk to the destination
daemon during a peer to peer migration, the vm lock is released and we
only hold an async job. If the source domain dies at this point the
monitor EOF callback is allowed to do its job and (among other things)
From: Andrea Bolognani
Signed-off-by: Andrea Bolognani
---
docs/news.xml | 81 +++
1 file changed, 81 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 468d340..7348838 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -61,6
From: Jiri Denemark
The variable is used to store the offline migration capability of the
destination daemon. Let's call it 'dstOffline' so that we can later use
'offline' to indicate whether we were asked to do offline migration.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_migration.c | 8
From: Daniel Veillard
- docs/news.xml: updated for the release
Signed-off-by: Daniel Veillard
---
docs/news.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/news.xml b/docs/news.xml
index 7348838..33824dd 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -33,7
From: John Ferlan
Force would be used to force eject a cdrom live, since the code
doesn't support live update, remove the flag.
Signed-off-by: John Ferlan
ACKed-by: Michal Prívozník
---
src/lxc/lxc_driver.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
From: John Ferlan
Although commit e3497f3f noted that the LIVE option doesn't
matter and removed the call to virDomainDefCompatibleDevice,
it didn't go quite far enough and change the order of the checks
and rework the code to just handle the config change causing
a failure after
From: Laine Stump
This function retrieves the name of the OVS bridge that the given
netdev is attached to. This separate function is necessary because OVS
set the IFLA_MASTER attribute to "ovs-system" for all netdevs that are
attached to an OVS bridge, so the standard method of retrieving the
From: Anya Harter
the last use of this function was deleted in commit
19a148b7c8353d5c214bed699f8fe983317baf93
Signed-off-by: Anya Harter
---
src/conf/domain_addr.c | 44
src/conf/domain_addr.h | 5 -
src/libvirt_private.syms | 1 -
3
From: John Ferlan
Signed-off-by: John Ferlan
---
configure.ac | 2 +-
docs/news.xml | 8
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index e25bf0a..59d2d09 100644
--- a/configure.ac
+++ b/configure.ac
@@ -16,7 +16,7 @@ dnl You should have
Andrea Bolognani (5):
news: Update for 4.5.0 release
qemu: Add capability for the HTM pSeries feature
conf: Parse and format the HTM pSeries feature
qemu: Format the HTM pSeries feature
news: Update for the HTM pSeries feature
Anya Harter (2):
domain_addr: delete
On 07/02/2018 01:08 PM, dubo163 wrote:
> From: dubobo
>
> the libvirtd pid file is not match the os process pid number
> which is smaller than before.
>
> this would be exist if the libvirtd process coredump or the os
> process was killed which the next pid number is smaller.
>
> you can be
1 - 100 of 101 matches
Mail list logo
