Rename nwfilter-binding-undefine to nwfilter-binding-delete.
Signed-off-by: Han Han
---
tools/virsh.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 4c6e21fc22..771e99591e 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@
On 07/11/2018 06:10 AM, nert@wheatley wrote:
> On Mon, Jul 09, 2018 at 05:00:49PM -0400, Jason Baron wrote:
>>
>>
>> On 07/08/2018 02:01 AM, Martin Kletzander wrote:
>>> On Thu, Jul 05, 2018 at 06:24:20PM +0200, Roman Mohr wrote:
On Thu, Jul 5, 2018 at 4:20 PM Jason Baron wrote:
Quoting Collin Walling (2018-07-11 17:48:54)
> I understand your approach, but I do not 100% agree with exposing the QEMU
> command stuff outside of qemu_capabilities.
>
> In patch 10/11, you have a function defined in qemu_caps for baselining. I'd
> spawn / kill your QEMU process within there.
Quoting Collin Walling (2018-07-11 18:25:00)
> Not sure if I agree with the renaming here.
>
> From what I understand, "if a cpu property is not migratable, then the
> cpu model is also not migratable".
>
> So I think the original naming scheme is fine.
Very much welcome the feedback here
On 07/09/2018 11:56 PM, Chris Venteicher wrote:
> Filter out cpu properties in qemuMonitorCPUModelInfo structure based on
> boolean value of true or false.
>
> Goal is to form a list of "enabled" or "disabled" properties.
>
> Required to convert between cpu model feature / property lists that
>
On 07/09/2018 11:56 PM, Chris Venteicher wrote:
> Bi-directional conversion functions.
> Converts model / name and features / properties between the two structures.
>
> Created reusable functions to bridge the internal (virCpuDef) and
> QEMU/QMP specific structures for describing CPU Models.
>
Not sure if I agree with the renaming here.
>From what I understand, "if a cpu property is not migratable, then the
cpu model is also not migratable".
So I think the original naming scheme is fine.
On 07/09/2018 11:56 PM, Chris Venteicher wrote:
> Renamed variable in CPUModelInfo such that
>
Hey Chris,
Your patches are looking better with each iteration. Awesome progress thus far!
I'd to make one suggestion for you that will keep your patches a bit cleaner
and also makes the review process smoother: introduce code in the same patches
that it gets used.
Take for example:
6/11
I understand your approach, but I do not 100% agree with exposing the QEMU
command stuff outside of qemu_capabilities.
In patch 10/11, you have a function defined in qemu_caps for baselining. I'd
spawn / kill your QEMU process within there. For when the features flag is set
(requiring you to
On 07/09/2018 11:56 PM, Chris Venteicher wrote:
> Baseline cpu model using QEMU/QMP query-cpu-model-baseline
>
> query-cpu-model-baseline only compares two CPUModels so multiple
> exchanges are needed to evaluate more than two CPUModels.
> ---
> src/qemu/qemu_capabilities.c | 85
Ivan Mishonov wrote:
> ---
> src/bhyve/bhyve_command.c | 2 +-
> src/bhyve/bhyve_device.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Hi Ivan,
Thanks for your contribution!
Some general comments:
- For quite some time already commits should have the Signed-off line
On Wed, Jul 11, 2018 at 05:47:58PM +0200, Michal Privoznik wrote:
> On 07/11/2018 05:25 PM, Pavel Hrdina wrote:
> > On Wed, Jul 11, 2018 at 05:05:07PM +0200, Michal Privoznik wrote:
> >> On 07/11/2018 10:22 AM, Pavel Hrdina wrote:
> >>> We can safely validate the hugepage nodeset attribute at a
Signed-off-by: Andrea Bolognani
---
guests/README.markdown | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/guests/README.markdown b/guests/README.markdown
index bc780f3..4a40619 100644
--- a/guests/README.markdown
+++ b/guests/README.markdown
@@ -6,16 +6,16 @@ of the
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 62 +-
1 file changed, 61 insertions(+), 1 deletion(-)
diff --git a/guests/lcitool b/guests/lcitool
index 1dd1ec8..cefce65 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@ -23,6 +23,7 @@
The on-disk configuration format and its behavior
are fully backwards compatible with the previous
implementation.
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 109 +
1 file changed, 109 insertions(+)
diff --git a/guests/lcitool
We use an actual YAML parser this time around, and bring
the behavior more in line with what Ansible is doing, so
interoperability should be more solid overall.
New in this implementation is more flexibility in defining
host lists, including support for explicit lists as well
as glob patterns.
We're going to rewrite the script completely, and getting
the current implementation out of the way firts will make
the diffs more reasonable.
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 227 -
1 file changed, 227 deletions(-)
delete
The 'prepare' alias was kinda redundant and offered
dubious value, so it has been dropped.
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 30 ++
1 file changed, 30 insertions(+)
diff --git a/guests/lcitool b/guests/lcitool
index cefce65..c17c174 100755
---
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/guests/lcitool b/guests/lcitool
index 3564eb8..1dd1ec8 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@ -237,6 +237,7 @@ class Application:
Doesn't do much right now, but it's a start :)
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 69 ++
1 file changed, 69 insertions(+)
create mode 100755 guests/lcitool
diff --git a/guests/lcitool b/guests/lcitool
new file mode 100755
index
While the previous implementation has served us well, it was
very quickly cobbled together using a language that's not really
suitable for the purpose; the fact that we had to embed a Perl
(previously Python) script in there is a clear indication that we
had outgrown the language pretty much from
On 07/11/2018 05:25 PM, Pavel Hrdina wrote:
> On Wed, Jul 11, 2018 at 05:05:07PM +0200, Michal Privoznik wrote:
>> On 07/11/2018 10:22 AM, Pavel Hrdina wrote:
>>> We can safely validate the hugepage nodeset attribute at a define time.
>>> This validation is not done for already existing domains
On Wed, Jul 11, 2018 at 05:05:05PM +0200, Michal Privoznik wrote:
> On 07/11/2018 10:22 AM, Pavel Hrdina wrote:
> > Previously we were ignoring "nodeset" attribute for hugepage pages
> > if there was no guest NUMA topology configured in the domain XML.
> > Commit partially fixed
> > that issue
Vmware fusion allows you to configure a network interface
as "hostonly". This uses a private network that is not
normally accessible from the physical networks on the
Mac/PC.
We map "hostonly" in the vmx configuration to "network"
in the domain configuration. Some comments in vmx.c
seem to point
On Wed, Jul 11, 2018 at 05:05:07PM +0200, Michal Privoznik wrote:
> On 07/11/2018 10:22 AM, Pavel Hrdina wrote:
> > We can safely validate the hugepage nodeset attribute at a define time.
> > This validation is not done for already existing domains when the daemon
> > is restarted.
> >
> > All
The problem is not that it is initialized to a non-NULL value.
If we were to detect multiple declarations in a line. we would
search for a comma (separator), right? In the case I mentioned,
the comma inside the function has to be avoided by the rule.
On Wed, 11 Jul 2018 at 15:57, Erik Skultety
On 07/11/2018 10:22 AM, Pavel Hrdina wrote:
> Both of these cases were working before commit
> tried to fix the case were
> there is no guest NUMA configured but there is "nodeset='0'" attribute.
> The case where "nodeset='1'" without any guest NUMA topology is covered
> by "hugepage-pages8" test
On 07/11/2018 10:22 AM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/conf/domain_conf.c | 75 ++
> 1 file changed, 40 insertions(+), 35 deletions(-)
ACK
Michal
--
libvir-list mailing list
libvir-list@redhat.com
On 07/11/2018 10:22 AM, Pavel Hrdina wrote:
> We can safely validate the hugepage nodeset attribute at a define time.
> This validation is not done for already existing domains when the daemon
> is restarted.
>
> All the changes to the tests are necessary because we move the error
> from domain
On 07/11/2018 10:22 AM, Pavel Hrdina wrote:
> Previously we were ignoring "nodeset" attribute for hugepage pages
> if there was no guest NUMA topology configured in the domain XML.
> Commit partially fixed
> that issue but it introduced a somehow valid regression.
>
> In case that there is no
On Tue, Jul 03, 2018 at 01:37 PM +0200, Marc Hartmayer
wrote:
> One way to reproduce the bugs is to set admin_max_workers=0 in
> libvirtd.conf, restart libvirtd, and then call:
>
> $ virt-admin server-threadpool-info admin
>
> Changelog:
> v1->v2:
> - Worked in Daniel Berrangé's comments
Since QEMU 2.12, QEMU understands a new vfio-pci device option 'display'
which can be used to turn on display capabilities on vgpu-enabled
mediated devices, IOW emulated GPU devices like QXL will no longer be
needed with vgpu-enable mdevs.
QEMU defaults to 'auto' for the 'display' attribute, which
Signed-off-by: Erik Skultety
Acked-by: Michal Privoznik
---
docs/news.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 773c95b0da..fd08c01aeb 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -44,6 +44,16 @@
support should be
QEMU 2.12 introduced a new type of display for mediated devices using
vfio-pci backend which allows a mediated device to be used as a VGA
compatible device as an alternative to an emulated video device. QEMU
exposes this feature via a vfio device property 'display' with supported
values
QEMU 2.12 introduced a new vfio-pci device option 'display=on/off/auto'.
This patch introduces the necessary capability.
Signed-off-by: Erik Skultety
Reviewed-by: John Ferlan
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 3
The exit path is the same for both success and failure, so the label
should be called cleanup.
Signed-off-by: Erik Skultety
---
src/conf/domain_conf.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/conf/domain_conf.c
Since 2.10 QEMU supports a new display type egl-headless which uses the
drm nodes for OpenGL rendering copying back the rendered bits back to
QEMU into a dma-buf which can be accessed by standard "display" apps
like VNC or SPICE. Although this display type can be used on its own,
for any practical
Since QEMU 2.10, it's possible to use a new type of display -
egl-headless which uses drm nodes to provide OpenGL support. This patch
adds a capability for that. However, since QEMU doesn't provide a QMP
command to probe it, we have to base the capability on specific QEMU
version.
Signed-off-by:
RFC here:
https://www.redhat.com/archives/libvir-list/2018-May/msg02218.html
Since v1 [1]:
- remodeled egl-headless to be a standalone graphics element instead of a
result of some automagic with graphic's element
- pushed the first 5 simple fixes that were RB'd
- fixed some nits raised during
A simple helper which will loop through all the graphics elements and
checks whether at least one of them enables OpenGL support, either by
containing or being of type 'egl-headless'.
Signed-off-by: Erik Skultety
Acked-by: Michal Privoznik
---
src/conf/domain_conf.c | 43
On Tue, Jul 10, 2018 at 05:01:22PM +0200, Cornelia Huck wrote:
[...]
> Who is, in general, testing which libvirt version? I can think of:
> - libvirt developers, which will probably run libvirt current git, but
> more likely a released QEMU?
> - QEMU (and other related tools) developers, who
Hi,
While trying to add vhost-user-gpu support to libvirt, I am wondering
how the guest should be configured to enable domain memory sharing.
Naively, I thought this alone should work:
But it doesn't seem to produce memory-backend-file share=on or
memory-backend-memfd (the later would be
On Wed, Jul 11, 2018 at 10:09:01AM +0200, Michal Privoznik wrote:
> On 07/11/2018 09:58 AM, Erik Skultety wrote:
> > On Tue, Jul 10, 2018 at 01:39:03PM +0200, Michal Privoznik wrote:
> >> On 07/09/2018 06:24 PM, Erik Skultety wrote:
> >>> QEMU 2.12 introduced a new type of display for mediated
Jiri Denemark [2018-07-11, 01:17PM +0200]:
> On Wed, Jul 11, 2018 at 12:49:13 +0200, Bjoern Walk wrote:
> > This patch series introduces the ability to save additional information
> > for the domain state and exposes this information in virsh domstate.
> >
> > For example in the case of QEMU
On 07/11/2018 01:31 AM, Marcos Paulo de Souza wrote:
> ESX driver can't function without a server being informed, so this flag
> makes libvirt to check for a valid server before calling connectOpen.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
> src/esx/esx_driver.c | 8 +---
> 1 file
From: Marc Hartmayer
This patch adds the Python binding for the virDomainGetStateParams
API. The Python side can be generated automatically, the C side not.
Reviewed-by: Bjoern Walk
Signed-off-by: Marc Hartmayer
---
generator.py | 1 +
libvirt-override-api.xml | 6 ++
On 07/11/2018 01:30 AM, Marcos Paulo de Souza wrote:
> Hi guys,
>
> this is the third version of the patchset to add a new member to
> virConnectDriver in order to simplfy the check for a server. Now, libvirt does
> the work inside virConnectOpenInternal after getting the correct driver from
>
On Wed, Jul 11, 2018 at 12:49:13 +0200, Bjoern Walk wrote:
> This patch series introduces the ability to save additional information
> for the domain state and exposes this information in virsh domstate.
>
> For example in the case of QEMU guest panic events, we can provide additional
>
Users will probably want to only work with a subset of
guests but, like any other customization, that should be
handled with local tweaks.
Signed-off-by: Andrea Bolognani
---
guests/inventory | 4
1 file changed, 4 insertions(+)
diff --git a/guests/inventory b/guests/inventory
index
Implement the API function virDomainGetStateParams for the QEMU
hypervisor driver.
Reviewed-by: Marc Hartmayer
Reviewed-by: Stefan Zimmermann
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
---
src/qemu/qemu_driver.c | 50 ++
1 file changed,
Add a new parameter to virsh domstate, --info, to additionally report
additional information for the domain state:
virsh # domstate --info guest-1
crashed (panicked: disabled-wait core='1' psw-mask='0x0010f146' \
psw-addr='0x000200018000')
When the new API
This patch series introduces the ability to save additional information
for the domain state and exposes this information in virsh domstate.
For example in the case of QEMU guest panic events, we can provide additional
information like the crash reason or register state of the domain. This
Implement the API function virDomainGetStateParams for the remote driver
and wire up the remote protocol.
Reviewed-by: Stefan Zimmermann
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
---
src/remote/remote_daemon_dispatch.c | 1 -
src/remote/remote_driver.c | 1 +
Add the ability to set and retrieve additional state information for the
domain.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
---
src/conf/domain_conf.c | 15 ++-
src/conf/domain_conf.h | 6 ++
src/libvirt_private.syms | 1 +
3 files changed, 21 insertions(+),
Let's make the formatting of the log output consistent to the domstate
output and put the reason first.
Signed-off-by: Bjoern Walk
---
src/qemu/qemu_monitor.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index
This API function extends and generalizes the virDomainGetState function
by returning a dictionary of typed parameters.
In later commits, the domain state, reason and the previously introduced
additional state information are returned.
Reviewed-by: Stefan Zimmermann
Reviewed-by: Boris
Since version 2.12, QEMU reports additional information in case of a
guest panic. Let's set the state information when handling the guest
panic event and make it available for later.
Reviewed-by: Boris Fiuczynski
Reviewed-by: Stefan Zimmermann
Signed-off-by: Bjoern Walk
---
On some architectures, QEMU exposes additional information on certain
domain states, e.g. for guest crashes. Let's add a field @info to the
virDomainStateReason struct inside virDomainObj which holds additional
state information.
One drawback is that this information is not serialized and is lost
Signed-off-by: Bjoern Walk
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 773c95b0..6cbd2c78 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,6 +35,17 @@
+
+
+ Ability to set/get
On Wed, Jul 11, 2018 at 10:35:25AM +0200, Pavel Hrdina wrote:
> On Wed, Jul 11, 2018 at 12:42:43AM +0530, Sukrit Bhatnagar wrote:
> > On Tue, 10 Jul 2018 at 16:24, Erik Skultety wrote:
> > >
> > > On Sat, Jun 30, 2018 at 02:30:08PM +0530, Sukrit Bhatnagar wrote:
> > > > Add rule to ensure that
Rename virFileIsCDROM to virFileCheckCDROM and add enum type
virFileCDRomStatus of cdrom statuses. Add argument cd_status in
virFileCheckCDROM filled with cdrom status.
Now virFileCheckCDROM could be used to check the cdrom drive status such
as no info, no disc, tray open, drive not ready or ok.
v2: https://www.redhat.com/archives/libvir-list/2018-July/msg00655.html
v1: https://www.redhat.com/archives/libvir-list/2018-July/msg00103.html
Rename virFileIsCDROM to virFileCheckCDROM and add new argument filled
with cdrom status. Now it could be used to get cdrom status.
In libvirt, it gives
Implement virFileCheckCDROM in virStorageBackendVolOpen to check if
cdrom backend is ready. Skip the error of cdrom not ready.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1596096
Signed-off-by: Han Han
---
src/storage/storage_util.c | 8
1 file changed, 8 insertions(+)
diff
On 07/11/2018 03:51 AM, Shichangkuo wrote:
>
>
>> -Original Message-
>> From: Michal Privoznik [mailto:mpriv...@redhat.com]
>> Sent: Tuesday, July 10, 2018 9:27 PM
>> To: shichangkuo (Cloud); 'libvir-list@redhat.com'; 'jfer...@redhat.com'
>> Subject: Re: [libvirt] [PATCH] storage: prefer
On Wed, Jul 11, 2018 at 12:42:43AM +0530, Sukrit Bhatnagar wrote:
> On Tue, 10 Jul 2018 at 16:24, Erik Skultety wrote:
> >
> > On Sat, Jun 30, 2018 at 02:30:08PM +0530, Sukrit Bhatnagar wrote:
> > > Add rule to ensure that each variable declaration made using
> > > a cleanup macro is in its own
On 07/10/2018 01:37 PM, Ján Tomko wrote:
On Wed, Jul 04, 2018 at 01:21:44PM +0200, Boris Fiuczynski wrote:
Add support and tests for vhost-vsock-ccw.
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_command.c | 15 +++--
src/qemu/qemu_domain_address.c
We can safely validate the hugepage nodeset attribute at a define time.
This validation is not done for already existing domains when the daemon
is restarted.
All the changes to the tests are necessary because we move the error
from domain start into XML parse.
Signed-off-by: Pavel Hrdina
---
Previously we were ignoring "nodeset" attribute for hugepage pages
if there was no guest NUMA topology configured in the domain XML.
Commit partially fixed
that issue but it introduced a somehow valid regression.
In case that there is no guest NUMA topology configured and the
"nodeset" attribute
Both of these cases were working before commit
tried to fix the case were
there is no guest NUMA configured but there is "nodeset='0'" attribute.
The case where "nodeset='1'" without any guest NUMA topology is covered
by "hugepage-pages8" test case.
Signed-off-by: Pavel Hrdina
---
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 75 ++
1 file changed, 40 insertions(+), 35 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 20d67e7854..5249f59d1a 100644
--- a/src/conf/domain_conf.c
+++
Pavel Hrdina (4):
tests: Add additional hugepage tests to cover current state
conf: Move hugepage XML validation check out of qemu_command
conf: Move hugepages validation out of XML parser
conf: Introduce virDomainDefPostParseMemtune
src/conf/domain_conf.c| 134
On 07/11/2018 09:58 AM, Erik Skultety wrote:
> On Tue, Jul 10, 2018 at 01:39:03PM +0200, Michal Privoznik wrote:
>> On 07/09/2018 06:24 PM, Erik Skultety wrote:
>>> QEMU 2.12 introduced a new type of display for mediated devices using
>>> vfio-pci backend which allows a mediated device to be used
On Tue, Jul 10, 2018 at 01:39:03PM +0200, Michal Privoznik wrote:
> On 07/09/2018 06:24 PM, Erik Skultety wrote:
> > QEMU 2.12 introduced a new type of display for mediated devices using
> > vfio-pci backend which allows a mediated device to be used as a VGA
> > compatible device as an alternative
On Wed, Jul 11, 2018 at 3:04 PM, Peter Krempa wrote:
> On Wed, Jul 11, 2018 at 11:07:52 +0800, Han Han wrote:
> > Add enum type of cdrom statuses. Add argument cd_status in
> > virFileCheckCDROM to store cdrom status.
> > Now virFileCheckCDROM could be used to check the cdrom drive status such
>
On Wed, 11 Jul 2018 08:53:20 +0200
Thomas Huth wrote:
> On 10.07.2018 17:24, Peter Krempa wrote:
> > On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote:
> >> So, from that I gather that a hard failure would be the easiest for
> >> libvirt to detect (and everything else would become
On Wed, Jul 11, 2018 at 11:07:53 +0800, Han Han wrote:
> Implement virFileCheckCDROM in virStorageBackendVolOpen to check if
> cdrom backend is ready. Skip the error of cdrom not ready.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1596096
>
> Signed-off-by: Han Han
> ---
>
On Wed, Jul 11, 2018 at 11:07:52 +0800, Han Han wrote:
> Add enum type of cdrom statuses. Add argument cd_status in
> virFileCheckCDROM to store cdrom status.
> Now virFileCheckCDROM could be used to check the cdrom drive status such
> as no info, no disc, trey open, drive not ready or ok.
tray
On 10.07.2018 17:24, Peter Krempa wrote:
> On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote:
>> On Tue, 10 Jul 2018 16:39:31 +0200
>> Peter Krempa wrote:
>>> On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote:
On Tue, 10 Jul 2018 07:59:15 +0200
Markus Armbruster
...
> > diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
> > index fa57221d62..49e0e03f03 100644
> > --- a/tests/qemuxml2xmltest.c
> > +++ b/tests/qemuxml2xmltest.c
> > @@ -479,6 +479,8 @@ mymain(void)
> > DO_TEST("hostdev-pci-address", NONE);
> > DO_TEST("hostdev-vfio",
79 matches
Mail list logo
