Hi, everyone!
For VIR_NETWORK_FORWARD_*, I try to replace 'if' type conditions
with typed 'switch()'.
It might be more clear.
Signed-off-by: Shi Lei
---
src/conf/domain_conf.c | 46 +-
src/conf/network_conf.c | 49 ++-
src/conf/virnetworkobj.c | 15 ++--
Current mdev device create interface depends on fixed mdev type, which get uuid
from user to create instance of mdev device. If user wants to use customized
number of resource for mdev device, then only can create new mdev type for that
which may not be flexible. This requirement comes not only
For mdev device, create new sysfs attribute "instances" to show
number of instances allocated for possible aggregation type.
For compatibility default or without aggregated allocation, the
number is 1.
Cc: Kirti Wankhede
Cc: Alex Williamson
Cc: Kevin Tian
Signed-off-by: Zhenyu Wang
---
New aggregation type is created for KVMGT which can be used
with new mdev create "instances=xxx" parameter to combine
minimal resource number for target instances, which can create
user defined number of resources. For KVMGT, aggregated resource
is determined by memory and fence resource
For special mdev type which can aggregate instances for mdev device,
this extends mdev create interface by allowing extra "instances=xxx"
parameter, which is passed to mdev device model to be able to create
arbitrary bundled number of instances for target mdev device.
v2: create new
Update mdev doc on new aggregration attribute and instances attribute
for mdev.
Cc: Kirti Wankhede
Cc: Alex Williamson
Cc: Kevin Tian
Signed-off-by: Zhenyu Wang
---
Documentation/vfio-mediated-device.txt | 39 ++
1 file changed, 33 insertions(+), 6 deletions(-)
diff
On 07/18/2018 10:44 AM, Ján Tomko wrote:
> Unless explicitly requested, enable the QEMU driver
> only if the Jansson library is present.
>
> Signed-off-by: Ján Tomko
> ---
> m4/virt-driver-qemu.m4 | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Perhaps it's obvious for
On 07/18/2018 10:44 AM, Ján Tomko wrote:
> Yajl has not seen much activity upstream recently.
> Switch to using Jansson >= 2.5.
>
> All the platforms we target on https://libvirt.org/platforms.html
> have a version >= 2.7 listed on the sites below:
>
Commit id 1bff5bbe25eb7a7e7a4e0067c4ca7cbc1cb34999 accidentally
reverted .gnulib back to d6397dde2e127e246e3eeb5254a21f42cac783c8
which was two updates ago.
Update to the latest 68df637b5f1b5c10370f6981d2a43a5cf74368df
which includes three changes since the previous fetch of
On 07/12/2018 09:39 PM, Han Han wrote:
> Add nwfilterbinding schema in virt-xml-validate for autoprobing.
> Add document of nwfilterbinding schema in tools/virt-xml-validate.pod.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1600330
>
> Signed-off-by: Han Han
> ---
>
https://bugzilla.redhat.com/show_bug.cgi?id=1601377
Fix typo from commit id d45bee449 for the parent_wwpn field
resulting in parent_wwnn being printed twice.
Signed-off-by: John Ferlan
---
tools/virsh-pool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh-pool.c
On 07/19/2018 04:15 AM, Nikolay Shirokovskiy wrote:
>
>
> On 17.07.2018 22:28, John Ferlan wrote:
>>
>>
> +} else {
> +to->code = VIR_ERR_NO_MEMORY;
> +to->domain = VIR_FROM_NONE;
> +to->level = VIR_ERR_ERROR;
Should we do a
The usage has once again changed slightly; additionally,
a few concrete examples are now provided.
Signed-off-by: Andrea Bolognani
---
guests/README.markdown | 38 --
1 file changed, 32 insertions(+), 6 deletions(-)
diff --git a/guests/README.markdown
We're going to add more extra-vars later on, and they
will be in some cases more complex than simple strings;
using JSON allows us to do that and also be less verbose.
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git
For CentOS CI, we need build dependencies for all known
projects to be installed; however, when using lcitool
for development purposes, it is very convenient to install
just the subset relevant to the project that's being
worked on, as doing so reduces the storage requirements
and makes the update
The information is mostly duplicated and can be easily
inferred in a programmatic manner, so storing it in the
inventory is far from the cleanest solution.
As a side-effect, we reintroduce the error message that
was supposed to be displayed when attempting to install
a FreeBSD guest but was lost
The rationale is the same as for moving playbooks.
Signed-off-by: Andrea Bolognani
---
guests/{ => configs}/kickstart.cfg | 0
guests/{ => configs}/preseed.cfg | 0
guests/lcitool | 2 +-
3 files changed, 1 insertion(+), 1 deletion(-)
rename guests/{ =>
This has two advantages: it unclutters the top-level
directory, and opens the door for adding more playbooks
down the line without turning it into a mess.
Thanks to the changes made earlier, moving the playbook
is almost entirely transparent to lcitool.
Signed-off-by: Andrea Bolognani
---
This series makes the guests/ directory less crowded by moving
a bunch of files to subdirectories, enhances the lcitool script
so that it works when called from any directory, and introduces
the ability to skip installation of build dependencies for
projects you don't care about. Some of these
Up until now, the only way to run lcitool has been from
the same directory it lives. After this patch, the script
is able to figure out its own location and adjust all
paths accordingly.
Suggested-by: Katerina Koukiou
Signed-off-by: Andrea Bolognani
---
guests/lcitool | 61
We want to get rid of relative paths in playbooks and
tasks, and in order to do that we have to provide Ansible
with some more information.
base is the directory where lcitool lives, and
playbook_base is the directory where a playbook should
look for its private resources: they match for the time
Signed-off-by: Peter Krempa
---
.../disk-network-gluster.x86_64-latest.args| 44 ++
tests/qemuxml2argvtest.c | 1 +
2 files changed, 45 insertions(+)
create mode 100644
tests/qemuxml2argvdata/disk-network-gluster.x86_64-latest.args
diff
'disk-network-source-auth' and 'disk-netowrk-tlsx509'
Signed-off-by: Peter Krempa
---
.../disk-network-source-auth.x86_64-latest.args| 47 +
.../disk-network-tlsx509.x86_64-latest.args| 59 ++
tests/qemuxml2argvtest.c |
Signed-off-by: Peter Krempa
---
.../disk-readonly-disk.x86_64-latest.args | 34
.../disk-shared.x86_64-latest.args | 37 ++
tests/qemuxml2argvtest.c | 2 ++
3 files changed, 73 insertions(+)
create mode
Signed-off-by: Peter Krempa
---
.../disk-floppy.x86_64-latest.args | 35 ++
.../floppy-drive-fat.x86_64-latest.args| 33
tests/qemuxml2argvtest.c | 2 ++
3 files changed, 70 insertions(+)
create mode
Move the authentication and ipv6 cases into the main test file. To allow
removal of the separate testing of the secure credential passing via the
'secret' object in qemu, use the DO_TEST_CAPS_VER macro with version
2.5.0 when the secret object is not supported by qemu.
Signed-off-by: Peter Krempa
Signed-off-by: Peter Krempa
---
.../disk-network-iscsi.x86_64-latest.args | 63 ++
tests/qemuxml2argvtest.c | 1 +
2 files changed, 64 insertions(+)
create mode 100644 tests/qemuxml2argvdata/disk-network-iscsi.x86_64-latest.args
diff
Signed-off-by: Peter Krempa
---
.../disk-network-nbd.x86_64-latest.args| 46 ++
tests/qemuxml2argvtest.c | 1 +
2 files changed, 47 insertions(+)
create mode 100644 tests/qemuxml2argvdata/disk-network-nbd.x86_64-latest.args
diff --git
Move the 'unsafe' cache test into 'disk-cache' and remove all the
individual cases for one cache mode each.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/disk-cache-directsync.args | 30
tests/qemuxml2argvdata/disk-cache-directsync.xml | 37 ---
We have several cases when a VM has multiple disks in the test files so
having another one without any interresting configuration is not
necessary.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/disk-many.args | 32 -
tests/qemuxml2argvdata/disk-many.xml | 48
The xml2argv variant was unused. The xml2xml variant is redundant in
other tests for RBD.
Signed-off-by: Peter Krempa
---
.../disk-network-rbd-ceph-env.args | 25
.../qemuxml2argvdata/disk-network-rbd-ceph-env.xml | 39 ---
Signed-off-by: Peter Krempa
---
.../qemuxml2argvdata/disk-network-nbd-export.args | 30
tests/qemuxml2argvdata/disk-network-nbd-export.xml | 37 ---
.../disk-network-nbd-ipv6-export.args | 29 ---
.../disk-network-nbd-ipv6-export.xml
Signed-off-by: Peter Krempa
---
.../disk-network-sheepdog.x86_64-latest.args | 35 ++
tests/qemuxml2argvtest.c | 1 +
2 files changed, 36 insertions(+)
create mode 100644
tests/qemuxml2argvdata/disk-network-sheepdog.x86_64-latest.args
diff
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/disk-cache.args | 38 +++
tests/qemuxml2argvtest.c| 1 +
tests/qemuxml2xmloutdata/disk-cache.xml | 54 +
tests/qemuxml2xmltest.c | 1 +
4 files changed,
Signed-off-by: Peter Krempa
---
.../disk-cdrom-network.x86_64-latest.args | 41 ++
.../disk-cdrom-tray.x86_64-latest.args | 39
.../qemuxml2argvdata/disk-cdrom.x86_64-latest.args | 35 ++
tests/qemuxml2argvtest.c
Move various different iSCSI configuration into one test file.
Signed-off-by: Peter Krempa
---
.../qemuxml2argvdata/disk-network-iscsi-auth.args | 34
tests/qemuxml2argvdata/disk-network-iscsi-auth.xml | 43
We'll agregate testing of all cache modes in this test later on.
Signed-off-by: Peter Krempa
---
...k-write-cache.x86_64-2.6.0.args => disk-cache.x86_64-2.6.0.args} | 0
...k-write-cache.x86_64-2.7.0.args => disk-cache.x86_64-2.7.0.args} | 0
...write-cache.x86_64-latest.args =>
Test empty cdroms along with cdroms with medium.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/disk-cdrom-empty.args | 28 ---
tests/qemuxml2argvdata/disk-cdrom-empty.xml | 36
tests/qemuxml2argvdata/disk-cdrom.args| 4 ++-
This test also excercises options of 'discard'.
Signed-off-by: Peter Krempa
---
.../disk-detect-zeroes.x86_64-latest.args | 37 ++
tests/qemuxml2argvtest.c | 1 +
2 files changed, 38 insertions(+)
create mode 100644
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/disk-aio.x86_64-latest.args | 37 ++
tests/qemuxml2argvtest.c | 1 +
2 files changed, 38 insertions(+)
create mode 100644 tests/qemuxml2argvdata/disk-aio.x86_64-latest.args
diff --git
Unify most of the tests into a common test named disk-cdrom-network by
adding multiple cdroms. The 'http' test is dropped since there can be
only 4 cdroms.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/disk-cdrom-network-ftp.args | 27
Few disk tests were testing support for pure -drive command line
generation for disks now that we assume it for all qemu versions the
cases are obsolete.
Replacements:
disk-readonly-no-device -> disk-readonly-disk
disk-floppy-tray-no-device -> disk-floppy-tray
disk-cdrom-tray-no-device ->
Signed-off-by: Peter Krempa
---
.../disk-copy_on_read.x86_64-latest.args | 41 ++
tests/qemuxml2argvtest.c | 1 +
2 files changed, 42 insertions(+)
create mode 100644 tests/qemuxml2argvdata/disk-copy_on_read.x86_64-latest.args
diff --git
Signed-off-by: Peter Krempa
---
...ress-conflict.xml => disk-address-conflict.xml} | 0
...-drive-boot-cdrom.args => disk-boot-cdrom.args} | 0
...sk-drive-boot-cdrom.xml => disk-boot-cdrom.xml} | 0
...sk-drive-boot-disk.args => disk-boot-disk.args} | 0
...disk-drive-boot-disk.xml =>
We also have disk-copy_on_read.xml which also tests the command line.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/disk-copy-on-read.xml | 30 -
tests/qemuxml2xmloutdata/disk-copy-on-read.xml | 36 --
tests/qemuxml2xmltest.c
Clean up many test files and add CAPS_LATEST versions of tests which
will change when we switch from -drive to -blockdev
This series removes many duplicated and obsolete tests and adds much
more useful CAPS_LATEST testing
Peter Krempa (24):
tests: qemu: Drop 'drive' from disk tests
tests:
On 07/03/2018 07:37 AM, Marc Hartmayer wrote:
> The include guard should match the file name and comment.
>
> Signed-off-by: Marc Hartmayer
> Reviewed-by: Boris Fiuczynski
> ---
> src/rpc/virnetserverprogram.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: John
On 07/03/2018 07:37 AM, Marc Hartmayer wrote:
> Signed-off-by: Marc Hartmayer
> Reviewed-by: Boris Fiuczynski
> ---
> tools/virt-admin.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Reviewed-by: John Ferlan
John
--
libvir-list mailing list
libvir-list@redhat.com
On 07/03/2018 07:37 AM, Marc Hartmayer wrote:
> ...since maxWorkers=0 is only intended for virtlockd or virlogd which
> must not be multithreaded.
>
> Signed-off-by: Marc Hartmayer
> Reviewed-by: Boris Fiuczynski
> Reviewed-by: Bjoern Walk
> ---
> src/util/virthreadpool.c | 8
> 1
On 07/03/2018 07:37 AM, Marc Hartmayer wrote:
> Hypervisor drivers (e.g. QEMU) assume that they run in a separate
> thread from the main event loop thread otherwise deadlocks can
> occur. Therefore let's report an error if max_workers < 1 is set in
> the libvirtd configuration file.
>
>
On 07/03/2018 07:37 AM, Marc Hartmayer wrote:
> Semantically, there is no difference between an uninitialized worker
> pool and an initialized worker pool with zero workers. Let's allow the
> worker pool to be initialized for max_workers=0 as well then which
> makes the API more symmetric and
On 07/03/2018 07:37 AM, Marc Hartmayer wrote:
> @srv must be unlocked for the call virNetServerProcessMsg otherwise a
> deadlock can occur.
>
> Since the pointer 'srv->workers' will never be changed after
> initialization and the thread pool has it's own locking we can release
> the lock of
Through Qemu we can send commands to a Qemu Guest Agent running inside
a domain.
This way we can communicate with a running Domain by asking for it's
network information, requesting a filesystem trim or even execute a
command inside a Domain.
Commands need to be send as JSON Strings, but these
*** BLURB HERE ***
Wido den Hollander (1):
Add support for Qemu Guest Agent commands
src/main/java/org/libvirt/Domain.java | 34 ++
src/main/java/org/libvirt/Library.java| 3 +
.../java/org/libvirt/jna/LibvirtQemu.java | 16 +++
On Wed, Jul 18, 2018 at 01:36:54PM +0200, Peter Krempa wrote:
When changing cdrom media we did not handle the managed PR objects thus
we'd either have a stale PR object left behind or the media change would
fail.
Signed-off-by: Peter Krempa
---
Opps this one was also left behind in the
On Tue, Jul 17, 2018 at 02:14:30PM +0200, Peter Krempa wrote:
Remove the issue of the monitor command to the caller so that the
function can be used with the modern approach.
Additionally improve the error message.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 26
On Tue, Jul 17, 2018 at 02:14:29PM +0200, Peter Krempa wrote:
Prepare for the -blockdev implementation of ejectable media changing by
splitting up the old bits.
Additionally since both callers make sure that the device is a cdrom or
floppy the check is no longer necessary.
Signed-off-by: Peter
On Tue, Jul 17, 2018 at 02:14:28PM +0200, Peter Krempa wrote:
Similarly to qemuDomainDiskRemoveManagedPR make it enter monitor on
it's own so that it can be reused. Future users will be in the snapshot
its
code and in removable media change code.
Signed-off-by: Peter Krempa
---
On Tue, Jul 17, 2018 at 02:14:27PM +0200, Peter Krempa wrote:
Extract the (possible) removal of the PR backend and daemon into a
separate helper which enters monitor on it's own. This simplifies the
its
code and allows reuse of this function in the future e.g. for blockjobs
where removing a
On Tue, Jul 17, 2018 at 02:14:26PM +0200, Peter Krempa wrote:
Add code which will convert a disk definition into
qemuHotplugDiskSourceData and then reuse qemuHotplugDiskSourceRemove to
remove all the backend related objects.
This unifies the detach code as much as possible with the already
The corresponding libvirt-jenkins-ci commit is d2bbe1eee61a.
Signed-off-by: Andrea Bolognani
---
Pushed under the Dockerfile refresh rule.
buildenv-centos-7.Dockerfile | 4 ++--
buildenv-debian-8.Dockerfile | 2 +-
buildenv-debian-9.Dockerfile | 2 +-
On Thu, Jul 19, 2018 at 11:49:51AM +0200, Andrea Bolognani wrote:
> Andrea Bolognani (4):
> guests: Install jansson for libvirt
> guests: Don't install yajl for libvirt
> guests: Remove yajl mapping
> guests: Remove yajl kludge
>
> guests/tasks/kludges.yml | 2 --
>
There are no users left.
Signed-off-by: Andrea Bolognani
---
guests/vars/mappings.yml | 5 -
1 file changed, 5 deletions(-)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index eb31131..f6b308a 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@
Andrea Bolognani (4):
guests: Install jansson for libvirt
guests: Don't install yajl for libvirt
guests: Remove yajl mapping
guests: Remove yajl kludge
guests/tasks/kludges.yml | 2 --
guests/vars/mappings.yml | 10 +-
guests/vars/projects/libvirt.yml | 2 +-
3
Signed-off-by: Andrea Bolognani
---
guests/vars/projects/libvirt.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml
index 8c90a85..e512a50 100644
--- a/guests/vars/projects/libvirt.yml
+++ b/guests/vars/projects/libvirt.yml
libvirt has switched from yajl to jansson as its JSON
implementation, so we need to have the latter available
when building or the QEMU driver will be disabled.
Signed-off-by: Andrea Bolognani
---
guests/vars/mappings.yml | 5 +
guests/vars/projects/libvirt.yml | 1 +
2 files
No longer necessary now that yajl itself is not
being installed.
Signed-off-by: Andrea Bolognani
---
guests/tasks/kludges.yml | 2 --
1 file changed, 2 deletions(-)
diff --git a/guests/tasks/kludges.yml b/guests/tasks/kludges.yml
index 0ad61a7..31e9d6a 100644
--- a/guests/tasks/kludges.yml
+++
On Thu, Jul 19, 2018 at 01:21:48AM -0300, Julio Faracco wrote:
> If a domain is configured to start on boot, it has a symlink to the
> domain definition inside the autostart directory. If you rename this
> domain, the definition is renamed too. The symlink need to be pointed to
> this renamed
On Thu, Jul 19, 2018 at 10:20:55AM +0200, Andrea Bolognani wrote:
> This calls lcitool, part of the libvirt-jenkins-ci
> project, to refresh the Dockerfiles so that they
> contain up to date information about build
> requirements.
>
> Signed-off-by: Andrea Bolognani
> ---
> refresh | 30
This calls lcitool, part of the libvirt-jenkins-ci
project, to refresh the Dockerfiles so that they
contain up to date information about build
requirements.
Signed-off-by: Andrea Bolognani
---
refresh | 30 ++
1 file changed, 30 insertions(+)
create mode 100755
On 17.07.2018 22:28, John Ferlan wrote:
>
>
+} else {
+to->code = VIR_ERR_NO_MEMORY;
+to->domain = VIR_FROM_NONE;
+to->level = VIR_ERR_ERROR;
>>>
>>> Should we do a VIR_FREE(to->message); so that nothing that was there
>>> before somehow
71 matches
Mail list logo
