[libvirt] [PATCH v2 1/3] configure: Introduce libiscsi in build system

2018-07-23 Thread clem
From: Clementine Hayat The minimal required version is 1.18.0 because the synchrounous function needed were introduced here. Signed-off-by: Clementine Hayat --- configure.ac| 3 +++ m4/virt-libiscsi.m4 | 30 ++ 2 files changed, 33 insertions(+) create mode

[libvirt] [PATCH v2 2/3] storage: Introduce iscsi_direct pool type

2018-07-23 Thread clem
From: Clementine Hayat Introducing the pool as a noop. Integration inside the build system. Implementation will be in the following commits. Signed-off-by: Clementine Hayat --- configure.ac | 6 ++- m4/virt-storage-iscsi-direct.m4| 41 +++

[libvirt] [PATCH v2 3/3] storage: Implement iscsi_direct pool backend

2018-07-23 Thread clem
From: Clementine Hayat We need here libiscsi for the storgae pool backend. For the iscsi-direct storage pool, only checkPool and refreshPool should be necessary. The pool is state-less and just need the informations within the volume to work. Signed-off-by: Clementine Hayat --- m4/virt-storage

[libvirt] [PATCH v2 0/3] iscsi-direct: first part

2018-07-23 Thread clem
From: Clementine Hayat Hello, This is the implementation of the iscsi-direct backend storage pool version 2. The documentation, some API calls and tests are still missing and will be comming in a second part. Best Regards, -- Clementine Hayat Clementine Hayat (3): configure: Introduce libi

Re: [libvirt] [PATCHv2 11/11] qemu_driver: BaselineHypervisorCPU supports S390 using QEMU/QMP

2018-07-23 Thread Collin Walling
On 07/21/2018 12:05 AM, Chris Venteicher wrote: > Quoting David Hildenbrand (2018-07-18 02:26:24) >> On 18.07.2018 00:39, Collin Walling wrote: >>> On 07/17/2018 05:01 PM, David Hildenbrand wrote: On 13.07.2018 18:00, Jiri Denemark wrote: > On Mon, Jul 09, 2018 at 22:56:55 -0500, Chris Ven

Re: [libvirt] [PATCH v2 4/5] check-file-access: Allow specifying action

2018-07-23 Thread John Ferlan
On 07/23/2018 04:44 AM, Michal Prívozník wrote: > On 07/21/2018 02:57 PM, John Ferlan wrote: >> >> >> On 07/12/2018 03:37 AM, Michal Privoznik wrote: >>> The check-file-access.pl script is used to match access list >>> generated by virtestmock against whitelisted rules stored in >>> file_access_w

Re: [libvirt] [PATCH v2] conf: virDomainDefValidateInternal prohibit some characters in shmem name

2018-07-23 Thread John Ferlan
On 07/12/2018 09:10 AM, Simon Kobyda wrote: > XML shmem name will not include character '/', and will not be equal to > strings > "." or "..", as shmem name is used in a path. Validate that the provided XML shmem name is not directory specific "." or ".." names as well as ensuring that there i

[libvirt] [PATCH] use model "qemu" for s390 tcg cpu-model-expansion

2018-07-23 Thread Collin Walling
When calling the query-cpu-model-expansion command via libvirt, we pass in model name "max" when using TCG. However, this model name is not supported for s390 on TCG. Let's use the model name "qemu" as an alternative. QEMU Results: When executing query-cpu-model-expansion via QEMU on s390 wit

[libvirt] [PATCH] qemu: caps: use model "qemu" for s390 tcg cpu-model-expansion

2018-07-23 Thread Collin Walling
Use model name "qemu" instead of "max" when calling query-cpu-model-expansion for s390 on tcg. Signed-off-by: Collin Walling --- src/qemu/qemu_capabilities.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index

[libvirt] [PATCHv3] replace 'if' type conditions with 'switch' for VIR_NETWORK_FORWARD_

2018-07-23 Thread Shi Lei
Signed-off-by: Shi Lei --- v2 here: https://www.redhat.com/archives/libvir-list/2018-July/msg01423.html since v2: - typecast def->forward.type to virNetworkForwardType explicitly in all the switches rather than change its type to enum in the struct definition v1 here: https://www.redhat.com

Re: [libvirt] [PATCH v1 01/40] util: cgroup: modify virCgroupFree to take virCgroupPtr

2018-07-23 Thread Erik Skultety
On Mon, Jul 23, 2018 at 08:19:21PM +0530, Sukrit Bhatnagar wrote: > On Mon, 23 Jul 2018 at 16:29, Erik Skultety wrote: > > > > On Sat, Jul 21, 2018 at 05:36:33PM +0530, Sukrit Bhatnagar wrote: > > > Modify virCgroupFree function signature to take a value of type > > > virCgroupPtr instead of virCg

Re: [libvirt] [PATCH v1 15/40] util: firewall: use VIR_AUTOFREE instead of VIR_FREE for scalar types

2018-07-23 Thread Erik Skultety
On Mon, Jul 23, 2018 at 11:18:07PM +0530, Sukrit Bhatnagar wrote: > On Mon, 23 Jul 2018 at 18:39, Erik Skultety wrote: > > > > On Sat, Jul 21, 2018 at 05:36:47PM +0530, Sukrit Bhatnagar wrote: > > > By making use of GNU C's cleanup attribute handled by the > > > VIR_AUTOFREE macro for declaring sc

<    1   2